Re: [PR] KAFKA-19090: Move DelayedFuture and DelayedFuturePurgatory to server-common module [kafka]

2025-04-06 Thread via GitHub
FrankYang0529 commented on PR #19390: URL: https://github.com/apache/kafka/pull/19390#issuecomment-2781427559 Flaky test OffloadAndTxnConsumeFromLeaderTest#executeTieredStorageTest is not related to this PR. https://issues.apache.org/jira/browse/KAFKA-17998 -- This is an automated

[PR] KAFKA-19076: replace `String` by `Supplier` for UnifiedLog#maybeHandleIOException [kafka]

2025-04-06 Thread via GitHub
Rancho-7 opened a new pull request, #19392: URL: https://github.com/apache/kafka/pull/19392 jira: https://issues.apache.org/jira/browse/KAFKA-19076 the message is used when the function encounters error, so the error message should be created lazy. -- This is an automated messa

Re: [PR] MINOR: Move BrokerReconfigurable to the sever-common module [kafka]

2025-04-06 Thread via GitHub
chia7712 commented on code in PR #19383: URL: https://github.com/apache/kafka/pull/19383#discussion_r2030160837 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -1038,9 +1039,10 @@ class ReplicaManager(val config: KafkaConfig, callback: ((Map[TopicPartition,

Re: [PR] MINOR: Move BrokerReconfigurable to the sever-common module [kafka]

2025-04-06 Thread via GitHub
chia7712 commented on code in PR #19383: URL: https://github.com/apache/kafka/pull/19383#discussion_r2030162491 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -1038,9 +1039,10 @@ class ReplicaManager(val config: KafkaConfig, callback: ((Map[TopicPartition,

Re: [PR] MINOR: small optimization by judgment [kafka]

2025-04-06 Thread via GitHub
chia7712 merged PR #19386: URL: https://github.com/apache/kafka/pull/19386 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] MINOR: Clean up unreachable code in FetcherTest [kafka]

2025-04-06 Thread via GitHub
chia7712 merged PR #19376: URL: https://github.com/apache/kafka/pull/19376 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] Minor: Add functionalinterface to the producer callback [kafka]

2025-04-06 Thread via GitHub
chia7712 merged PR #19366: URL: https://github.com/apache/kafka/pull/19366 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] MINOR: Cleanup 0.10.x legacy references in ClusterResourceListener and TopicConfig (clients module) [kafka]

2025-04-06 Thread via GitHub
FrankYang0529 commented on PR #19388: URL: https://github.com/apache/kafka/pull/19388#issuecomment-2781454638 This line may also be removed since 4.0 clients doesn't work with broker less than 2.1. https://github.com/apache/kafka/blob/a65626b6a806fca960377f9fd5d5383cdcb72946/clients/

[jira] [Assigned] (KAFKA-19097) Fix order of arguments to assertEquals

2025-04-06 Thread HongYi Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] HongYi Chen reassigned KAFKA-19097: --- Assignee: HongYi Chen > Fix order of arguments to assertEquals > --

[jira] [Commented] (KAFKA-19097) Fix order of arguments to assertEquals

2025-04-06 Thread HongYi Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17941353#comment-17941353 ] HongYi Chen commented on KAFKA-19097: - Thanks, I think I'll take this opportunity to

Re: [PR] KAFKA-19042 Move ProducerCompressionTest, ProducerFailureHandlingTest, and ProducerIdExpirationTest to client-integration-tests module [kafka]

2025-04-06 Thread via GitHub
m1a2st commented on code in PR #19319: URL: https://github.com/apache/kafka/pull/19319#discussion_r2030063959 ## clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/producer/ProducerCompressionTest.java: ## @@ -0,0 +1,187 @@ +/* + * Licensed to the Apache So

[jira] [Created] (KAFKA-19097) Fix order of arguments to assertEquals

2025-04-06 Thread Lorcan (Jira)
Lorcan created KAFKA-19097: -- Summary: Fix order of arguments to assertEquals Key: KAFKA-19097 URL: https://issues.apache.org/jira/browse/KAFKA-19097 Project: Kafka Issue Type: Improvement

[jira] [Commented] (KAFKA-19097) Fix order of arguments to assertEquals

2025-04-06 Thread HongYi Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17941345#comment-17941345 ] HongYi Chen commented on KAFKA-19097: - Hi [~lorcanj], If you're not currently workin

[PR] KAFKA-14523: Decouple RemoteLogManager and Partition [kafka]

2025-04-06 Thread via GitHub
mimaison opened a new pull request, #19391: URL: https://github.com/apache/kafka/pull/19391 Remove the last dependency in the core module. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] MINOR: redundant gradle expression is removed [kafka]

2025-04-06 Thread via GitHub
dejan2609 commented on PR #19200: URL: https://github.com/apache/kafka/pull/19200#issuecomment-2781405881 Just a reminder for @apoorvmittal10 and @mumrah -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

Re: [PR] KAFKA-14523: Decouple RemoteLogManager and Partition [kafka]

2025-04-06 Thread via GitHub
mimaison commented on PR #19391: URL: https://github.com/apache/kafka/pull/19391#issuecomment-2781406235 After that the last remaining piece of work before being able to move the `kafka.log.remote` classes to the storage module is to figure what to do with `ServerConfigs`. `RemoteLogManager

Re: [PR] KAFKA-19042 Move ProducerCompressionTest, ProducerFailureHandlingTest, and ProducerIdExpirationTest to client-integration-tests module [kafka]

2025-04-06 Thread via GitHub
gongxuanzhang commented on code in PR #19319: URL: https://github.com/apache/kafka/pull/19319#discussion_r2030143065 ## clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/producer/ProducerCompressionTest.java: ## @@ -0,0 +1,187 @@ +/* + * Licensed to the Ap

Re: [PR] MINOR: Various Java cleanups in core [kafka]

2025-04-06 Thread via GitHub
mimaison closed pull request #19385: MINOR: Various Java cleanups in core URL: https://github.com/apache/kafka/pull/19385 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] MINOR:modify scala $var to java string [kafka]

2025-04-06 Thread via GitHub
chia7712 commented on code in PR #18393: URL: https://github.com/apache/kafka/pull/18393#discussion_r2030143366 ## storage/src/main/java/org/apache/kafka/storage/internals/log/LocalLog.java: ## @@ -470,8 +470,8 @@ public FetchDataInfo read(long startOffset, return maybe

Re: [PR] KAFKA-19042 Move ProducerCompressionTest, ProducerFailureHandlingTest, and ProducerIdExpirationTest to client-integration-tests module [kafka]

2025-04-06 Thread via GitHub
gongxuanzhang commented on code in PR #19319: URL: https://github.com/apache/kafka/pull/19319#discussion_r2030143065 ## clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/producer/ProducerCompressionTest.java: ## @@ -0,0 +1,187 @@ +/* + * Licensed to the Ap

Re: [PR] KAFKA-19042 Move ProducerCompressionTest, ProducerFailureHandlingTest, and ProducerIdExpirationTest to client-integration-tests module [kafka]

2025-04-06 Thread via GitHub
gongxuanzhang commented on code in PR #19319: URL: https://github.com/apache/kafka/pull/19319#discussion_r2030144540 ## clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/producer/ProducerCompressionTest.java: ## @@ -0,0 +1,187 @@ +/* + * Licensed to the Ap

[PR] KAFKA-19042: [5/N] Move PlaintextConsumerCommitTest to client-integration-tests module [kafka]

2025-04-06 Thread via GitHub
m1a2st opened a new pull request, #19389: URL: https://github.com/apache/kafka/pull/19389 Use Java to rewrite PlaintextConsumerCommitTest by new test infra and move it to client-integration-tests module. -- This is an automated message from the Apache Git Service. To respond to the messag

[jira] [Assigned] (KAFKA-6629) SegmentedCacheFunctionTest does not cover session window serdes

2025-04-06 Thread Lorcan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-6629?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lorcan reassigned KAFKA-6629: - Assignee: Lorcan > SegmentedCacheFunctionTest does not cover session window serdes > ---

[PR] KAFKA-19090: Move DelayedFuture and DelayedFuturePurgatory to server-common module [kafka]

2025-04-06 Thread via GitHub
FrankYang0529 opened a new pull request, #19390: URL: https://github.com/apache/kafka/pull/19390 1. Move DelayedFuture and DelayedFuturePurgatory from core to server-common module. 2. Rewrite DelayedFuture and DelayedFuturePurgatory in Java. -- This is an automated message from the Apa

[jira] [Updated] (KAFKA-19097) Fix order of arguments to assertEquals

2025-04-06 Thread Lorcan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lorcan updated KAFKA-19097: --- Priority: Minor (was: Trivial) > Fix order of arguments to assertEquals > -

[jira] [Commented] (KAFKA-19097) Fix order of arguments to assertEquals

2025-04-06 Thread Lorcan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17941349#comment-17941349 ] Lorcan commented on KAFKA-19097: Hi [~apalan60], yes feel free to assign yourself. I not

Re: [PR] MINOR: small optimization by judgment [kafka]

2025-04-06 Thread via GitHub
ijuma commented on PR #19386: URL: https://github.com/apache/kafka/pull/19386#issuecomment-2781471808 We should probably cherry-pick this to the 4.0 branch. The original problem was introduced then, is that right? -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] KAFKA-19042: [5/N] Move PlaintextConsumerCommitTest to client-integration-tests module [kafka]

2025-04-06 Thread via GitHub
FrankYang0529 commented on code in PR #19389: URL: https://github.com/apache/kafka/pull/19389#discussion_r2030191468 ## clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/consumer/PlaintextConsumerCommitTest.java: ## @@ -0,0 +1,680 @@ +/* + * Licensed to th

Re: [PR] KAFKA-19042: [5/N] Move PlaintextConsumerCommitTest to client-integration-tests module [kafka]

2025-04-06 Thread via GitHub
FrankYang0529 commented on code in PR #19389: URL: https://github.com/apache/kafka/pull/19389#discussion_r2030193847 ## clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/consumer/PlaintextConsumerCommitTest.java: ## @@ -0,0 +1,680 @@ +/* + * Licensed to th

Re: [PR] KAFKA-19030: Remove metricNamePrefix from RequestChannel [kafka]

2025-04-06 Thread via GitHub
Parkerhiphop commented on code in PR #19374: URL: https://github.com/apache/kafka/pull/19374#discussion_r2030194156 ## core/src/main/scala/kafka/network/SocketServer.scala: ## @@ -97,7 +97,7 @@ class SocketServer( private val memoryPool = if (config.queuedMaxBytes > 0) new S

Re: [PR] MINOR: small optimization by judgment [kafka]

2025-04-06 Thread via GitHub
chia7712 commented on PR #19386: URL: https://github.com/apache/kafka/pull/19386#issuecomment-2781503458 > I will backport this PR to 4.0 done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Resolved] (KAFKA-19076) UnifiedLog#maybeHandleIOException should replace `String` by `Supplier`

2025-04-06 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19076?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-19076. Fix Version/s: 4.1.0 Resolution: Fixed > UnifiedLog#maybeHandleIOException should r

[jira] [Updated] (KAFKA-17722) Fix "this-escape" compiler warnings (BrokerTopicMetrics) for JDK 23

2025-04-06 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-17722: --- Fix Version/s: 3.9.1 > Fix "this-escape" compiler warnings (BrokerTopicMetrics) for JDK 23 >

Re: [PR] KAFKA-17722 Fix "this-escape" compiler warnings (BrokerTopicMetrics) … [kafka]

2025-04-06 Thread via GitHub
chia7712 merged PR #19308: URL: https://github.com/apache/kafka/pull/19308 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Commented] (KAFKA-17722) Fix "this-escape" compiler warnings (BrokerTopicMetrics) for JDK 23

2025-04-06 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17941397#comment-17941397 ] Chia-Ping Tsai commented on KAFKA-17722: backport to 3.9 (https://github.com/ap

Re: [PR] KAFKA-19076: replace `String` by `Supplier` for UnifiedLog#maybeHandleIOException [kafka]

2025-04-06 Thread via GitHub
chia7712 merged PR #19392: URL: https://github.com/apache/kafka/pull/19392 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Commented] (KAFKA-17723) Fix "this-escape" compiler warnings (MultiThreadedEventProcessor and DistributedHerder) for JDK 23

2025-04-06 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17941398#comment-17941398 ] Chia-Ping Tsai commented on KAFKA-17723: backport to 3.9 https://github.com/apa

[jira] [Updated] (KAFKA-17723) Fix "this-escape" compiler warnings (MultiThreadedEventProcessor and DistributedHerder) for JDK 23

2025-04-06 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-17723: --- Fix Version/s: 3.9.1 > Fix "this-escape" compiler warnings (MultiThreadedEventProcessor and

Re: [PR] KAFKA-17723 Fix "this-escape" compiler warnings (MultiThreadedEventPr… [kafka]

2025-04-06 Thread via GitHub
chia7712 merged PR #19309: URL: https://github.com/apache/kafka/pull/19309 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] [MINOR] Cleanup Core Module [kafka]

2025-04-06 Thread via GitHub
sjhajharia commented on code in PR #19372: URL: https://github.com/apache/kafka/pull/19372#discussion_r2030211767 ## core/src/main/java/kafka/server/share/SharePartition.java: ## @@ -2284,22 +2273,15 @@ CompletableFuture writeShareGroupState(List stateBatc private KafkaE

Re: [PR] MINOR: Small cleanups in server's tests [kafka]

2025-04-06 Thread via GitHub
wernerdv commented on PR #19395: URL: https://github.com/apache/kafka/pull/19395#issuecomment-2781641623 @chia7712 Please review this small PR when you get a chance. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] MINOR: Modify KafkaEventQueue VoidEvent to as singleton and use more proper function interface [kafka]

2025-04-06 Thread via GitHub
gongxuanzhang commented on code in PR #19356: URL: https://github.com/apache/kafka/pull/19356#discussion_r2030369156 ## server-common/src/main/java/org/apache/kafka/queue/KafkaEventQueue.java: ## @@ -444,7 +445,7 @@ public KafkaEventQueue( LogContext logContext,

Re: [PR] KAFKA-17653 Update Scala version to 2.13.15 for support Java 23 (3.9 backport) [kafka]

2025-04-06 Thread via GitHub
showuon merged PR #19307: URL: https://github.com/apache/kafka/pull/19307 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

Re: [PR] KAFKA-19042 Move ProducerCompressionTest, ProducerFailureHandlingTest, and ProducerIdExpirationTest to client-integration-tests module [kafka]

2025-04-06 Thread via GitHub
gongxuanzhang commented on PR #19319: URL: https://github.com/apache/kafka/pull/19319#issuecomment-2782119102 @chia7712 PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] KAFKA-14523: Decouple RemoteLogManager and Partition [kafka]

2025-04-06 Thread via GitHub
FrankYang0529 commented on code in PR #19391: URL: https://github.com/apache/kafka/pull/19391#discussion_r2030535364 ## storage/src/main/java/org/apache/kafka/server/log/remote/TopicPartitionLog.java: ## @@ -0,0 +1,40 @@ +/* + * Licensed to the Apache Software Foundation (ASF) u

Re: [PR] KAFKA-18877: Add an mechanism to find cases where we accessed variables from the wrong thread. [kafka]

2025-04-06 Thread via GitHub
github-actions[bot] commented on PR #19231: URL: https://github.com/apache/kafka/pull/19231#issuecomment-2781923372 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] MINOR: use enum map for error counts map [kafka]

2025-04-06 Thread via GitHub
github-actions[bot] commented on PR #19314: URL: https://github.com/apache/kafka/pull/19314#issuecomment-2781923254 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] KAFKA-18379: Enforce resigned cannot transition to any other state in same epoch [kafka]

2025-04-06 Thread via GitHub
github-actions[bot] commented on PR #19236: URL: https://github.com/apache/kafka/pull/19236#issuecomment-2781923336 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] [WIP] KAFKA-16717 [2/N]: Add AdminClient.alterShareGroupOffsets [kafka]

2025-04-06 Thread via GitHub
JimmyWang6 commented on PR #18929: URL: https://github.com/apache/kafka/pull/18929#issuecomment-2781961477 Hi @AndrewJSchofield , I've begun to tackle this issue recently and have encountered some problems. Could I discuss them with you? 1. Do you think that we need a new method in int

[PR] KAFKA-17639 Add Java 23 to CI [kafka]

2025-04-06 Thread via GitHub
showuon opened a new pull request, #19396: URL: https://github.com/apache/kafka/pull/19396 KAFKA-17639 Add Java 23 to CI. Backported from Commit 76a9df4. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[jira] [Updated] (KAFKA-19048) Minimal Movement Replica Balancing algorithm

2025-04-06 Thread Jialun Peng (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jialun Peng updated KAFKA-19048: Component/s: tools > Minimal Movement Replica Balancing algorithm > --

Re: [PR] KAFKA-17259: Support to override serverProperties and restart cluster in ClusterTestExtensions [kafka]

2025-04-06 Thread via GitHub
github-actions[bot] commented on PR #16808: URL: https://github.com/apache/kafka/pull/16808#issuecomment-2781941324 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please leave a comment asking for a review. If the P

Re: [PR] KAFKA-18402: Optimise of comparison on org.apache.kafka.common.Uuid [kafka]

2025-04-06 Thread via GitHub
github-actions[bot] commented on PR #13627: URL: https://github.com/apache/kafka/pull/13627#issuecomment-2781941192 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please leave a comment asking for a review. If the P

[jira] [Updated] (KAFKA-19048) Minimal Movement Replica Balancing algorithm for reassignment

2025-04-06 Thread Jialun Peng (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jialun Peng updated KAFKA-19048: Summary: Minimal Movement Replica Balancing algorithm for reassignment (was: Minimal Movement Rep

[jira] (KAFKA-19048) Minimal Movement Replica Balancing algorithm

2025-04-06 Thread Jialun Peng (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19048 ] Jialun Peng deleted comment on KAFKA-19048: - was (Author: JIRAUSER303739): I’ve implemented the code and submitted a pull request : https://github.com/apache/kafka/pull/19297. Could anyone h

Re: [PR] KAFKA-19071: Fix doc for remote.storage.enable [kafka]

2025-04-06 Thread via GitHub
azhar2407 commented on code in PR #19345: URL: https://github.com/apache/kafka/pull/19345#discussion_r2030339979 ## core/src/test/scala/integration/kafka/admin/RemoteTopicCrudTest.scala: ## @@ -441,7 +441,29 @@ class RemoteTopicCrudTest extends IntegrationTestHarness {

[PR] KAFKA-18894: Add KIP-877 support for ConfigProvider [kafka]

2025-04-06 Thread via GitHub
Yunyung opened a new pull request, #19397: URL: https://github.com/apache/kafka/pull/19397 Add [KIP-877](https://cwiki.apache.org/confluence/x/lY3GDQ) support for ConfigProvider. Cleanup: Collections.singletonMap() -> Map.of() Jira: https://issues.apache.org/jira/browse/KAFKA-1

Re: [PR] [MINOR] Cleanup Core Module [kafka]

2025-04-06 Thread via GitHub
AndrewJSchofield commented on code in PR #19372: URL: https://github.com/apache/kafka/pull/19372#discussion_r2030206882 ## core/src/main/java/kafka/server/share/SharePartition.java: ## @@ -2284,22 +2273,15 @@ CompletableFuture writeShareGroupState(List stateBatc private

[PR] KAFKA-19054: StreamThread exception handling with SHUTDOWN_APPLICATION may trigger a tight loop with MANY logs [kafka]

2025-04-06 Thread via GitHub
apalan60 opened a new pull request, #19394: URL: https://github.com/apache/kafka/pull/19394 ## Summary [JIRA: KAFKA-19054](https://issues.apache.org/jira/browse/KAFKA-19054) Under the `SHUTDOWN_APPLICATION` configuration in Kafka Streams, a tight loop in the shutdown process ca

[jira] [Resolved] (KAFKA-19016) Update retention behaviour of share groups to retain them forever

2025-04-06 Thread Chirag Wadhwa (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19016?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chirag Wadhwa resolved KAFKA-19016. --- Resolution: Fixed > Update retention behaviour of share groups to retain them forever >

[PR] KAFKA-19098: Remove `lastOffset` from PartitionResponse [kafka]

2025-04-06 Thread via GitHub
Rancho-7 opened a new pull request, #19398: URL: https://github.com/apache/kafka/pull/19398 jira: https://issues.apache.org/jira/browse/KAFKA-19098 The `lastOffset` is not used actually, so it can be removed. -- This is an automated message from the Apache Git Service. To respond t

Re: [PR] KAFKA-19084: Port KAFKA-16224, KAFKA-16764 for ShareConsumers [kafka]

2025-04-06 Thread via GitHub
ShivsundarR commented on code in PR #19369: URL: https://github.com/apache/kafka/pull/19369#discussion_r2030220644 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ShareConsumerImpl.java: ## @@ -937,7 +938,7 @@ private void sendAcknowledgementsAndLeaveGroup(f

Re: [PR] KAFKA-19084: Port KAFKA-16224, KAFKA-16764 for ShareConsumers [kafka]

2025-04-06 Thread via GitHub
ShivsundarR commented on code in PR #19369: URL: https://github.com/apache/kafka/pull/19369#discussion_r2030220618 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ShareConsumeRequestManager.java: ## @@ -971,9 +971,11 @@ private void handlePartitionError(Sha

Re: [PR] KAFKA-19077: Propagate shutdownRequested field [kafka]

2025-04-06 Thread via GitHub
chia7712 commented on code in PR #19359: URL: https://github.com/apache/kafka/pull/19359#discussion_r2030221993 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -2226,6 +2224,16 @@ private CoordinatorResult stream

Re: [PR] MINOR: small optimization by judgment [kafka]

2025-04-06 Thread via GitHub
chia7712 commented on PR #19386: URL: https://github.com/apache/kafka/pull/19386#issuecomment-2781502257 > The original problem was introduced then, is that right? yes, that is related to https://github.com/apache/kafka/commit/6e88c10ed5628ff31c0aa3096d16a1c78ef3127f. I will backport

[jira] [Created] (KAFKA-19098) Remove lastOffset from PartitionResponse

2025-04-06 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-19098: -- Summary: Remove lastOffset from PartitionResponse Key: KAFKA-19098 URL: https://issues.apache.org/jira/browse/KAFKA-19098 Project: Kafka Issue Type: Impr

[jira] [Commented] (KAFKA-19098) Remove lastOffset from PartitionResponse

2025-04-06 Thread Nick Guo (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17941424#comment-17941424 ] Nick Guo commented on KAFKA-19098: -- Hi [~chia7712] ,I would like to take this.Thanks!

[jira] [Assigned] (KAFKA-19098) Remove lastOffset from PartitionResponse

2025-04-06 Thread Nick Guo (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19098?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Guo reassigned KAFKA-19098: Assignee: Nick Guo (was: Chia-Ping Tsai) > Remove lastOffset from PartitionResponse > --

Re: [PR] MINOR: Modify KafkaEventQueue VoidEvent to as singleton and use more proper function interface [kafka]

2025-04-06 Thread via GitHub
chia7712 commented on code in PR #19356: URL: https://github.com/apache/kafka/pull/19356#discussion_r2030311152 ## server-common/src/main/java/org/apache/kafka/queue/KafkaEventQueue.java: ## @@ -444,7 +445,7 @@ public KafkaEventQueue( LogContext logContext, Str

Re: [PR] KAFKA-19071: Fix doc for remote.storage.enable [kafka]

2025-04-06 Thread via GitHub
azhar2407 commented on code in PR #19345: URL: https://github.com/apache/kafka/pull/19345#discussion_r2030339041 ## clients/src/main/java/org/apache/kafka/common/config/TopicConfig.java: ## @@ -80,8 +80,9 @@ public class TopicConfig { "Moreover, it triggers the rolling

Re: [PR] KAFKA-19071: Fix doc for remote.storage.enable [kafka]

2025-04-06 Thread via GitHub
azhar2407 commented on code in PR #19345: URL: https://github.com/apache/kafka/pull/19345#discussion_r2030339979 ## core/src/test/scala/integration/kafka/admin/RemoteTopicCrudTest.scala: ## @@ -441,7 +441,29 @@ class RemoteTopicCrudTest extends IntegrationTestHarness {

Re: [PR] KAFKA-19071: Fix doc for remote.storage.enable [kafka]

2025-04-06 Thread via GitHub
FrankYang0529 commented on code in PR #19345: URL: https://github.com/apache/kafka/pull/19345#discussion_r2030345697 ## core/src/test/scala/integration/kafka/admin/RemoteTopicCrudTest.scala: ## @@ -441,7 +441,29 @@ class RemoteTopicCrudTest extends IntegrationTestHarness {

Re: [PR] MINOR: Modify KafkaEventQueue VoidEvent to as singleton and use more proper function interface [kafka]

2025-04-06 Thread via GitHub
gongxuanzhang commented on code in PR #19356: URL: https://github.com/apache/kafka/pull/19356#discussion_r2030367579 ## server-common/src/main/java/org/apache/kafka/queue/EventQueue.java: ## @@ -66,16 +66,20 @@ public String toString() { } } -class NoDeadline

Re: [PR] KAFKA-17773 Upgrade spotbug to work under java 23 (3.9 backport) [kafka]

2025-04-06 Thread via GitHub
showuon merged PR #19310: URL: https://github.com/apache/kafka/pull/19310 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

Re: [PR] KAFKA-17078: Add SecurityManagerCompatibility shim (#16522) [kafka]

2025-04-06 Thread via GitHub
showuon merged PR #19221: URL: https://github.com/apache/kafka/pull/19221 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

Re: [PR] KAFKA-16729: Support isolation level for share consumer [kafka]

2025-04-06 Thread via GitHub
junrao commented on code in PR #19261: URL: https://github.com/apache/kafka/pull/19261#discussion_r2029543043 ## core/src/main/java/kafka/server/share/SharePartition.java: ## @@ -2484,6 +2505,182 @@ private long startOffsetDuringInitialization(long partitionDataStartOffset) thr

Re: [PR] KAFKA-16729: Support isolation level for share consumer [kafka]

2025-04-06 Thread via GitHub
adixitconfluent commented on code in PR #19261: URL: https://github.com/apache/kafka/pull/19261#discussion_r2030219266 ## core/src/main/java/kafka/server/share/SharePartition.java: ## @@ -2484,6 +2505,182 @@ private long startOffsetDuringInitialization(long partitionDataStartOf

Re: [PR] KAFKA-16729: Support isolation level for share consumer [kafka]

2025-04-06 Thread via GitHub
adixitconfluent commented on code in PR #19261: URL: https://github.com/apache/kafka/pull/19261#discussion_r2030219266 ## core/src/main/java/kafka/server/share/SharePartition.java: ## @@ -2484,6 +2505,182 @@ private long startOffsetDuringInitialization(long partitionDataStartOf

Re: [PR] KAFKA-18913: Removing _state.updater.enabled_ flag through the Stream… [kafka]

2025-04-06 Thread via GitHub
janchilling commented on PR #19275: URL: https://github.com/apache/kafka/pull/19275#issuecomment-2781633364 Hi @cadonna , I have removed the stateUpdaterEnabled flag and the related code completely from the codebase, and only remaining part is to remove it from a readme file and a py

[PR] MINOR: Small cleanups in server's tests [kafka]

2025-04-06 Thread via GitHub
wernerdv opened a new pull request, #19395: URL: https://github.com/apache/kafka/pull/19395 - Used List/Map/Set.of() for immutable collections - Reduced code duplication - Fixed IDEA code inspection warnings -- This is an automated message from the Apache Git Service. To respond to t

Re: [PR] KAFKA-17662: config.providers configuration missing from the docs [kafka]

2025-04-06 Thread via GitHub
gharris1727 commented on PR #18930: URL: https://github.com/apache/kafka/pull/18930#issuecomment-2781615807 @mjsax This configuration was effectively added to _all subclasses of AbstractConfig_ in KIP-421 https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=100829515 back in 20

Re: [PR] MINOR: Move BrokerReconfigurable to the sever-common module [kafka]

2025-04-06 Thread via GitHub
chia7712 merged PR #19383: URL: https://github.com/apache/kafka/pull/19383 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-14485: Move LogCleaner to storage module [kafka]

2025-04-06 Thread via GitHub
chia7712 commented on PR #19387: URL: https://github.com/apache/kafka/pull/19387#issuecomment-2781729703 @wernerdv could you please fix the conflicts? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] KAFKA-17645: KIP-1052: Enable warmup in producer performance test [kafka]

2025-04-06 Thread via GitHub
chia7712 commented on code in PR #17340: URL: https://github.com/apache/kafka/pull/17340#discussion_r2030308912 ## tools/src/main/java/org/apache/kafka/tools/ProducerPerformance.java: ## @@ -51,6 +51,7 @@ public class ProducerPerformance { public static final String DEFAU

Re: [PR] MINOR: Clean up comments and remove unused code in RecordVersion and CreateTopicsRequestTest [kafka]

2025-04-06 Thread via GitHub
chia7712 merged PR #19342: URL: https://github.com/apache/kafka/pull/19342 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache