chia7712 commented on code in PR #19383:
URL: https://github.com/apache/kafka/pull/19383#discussion_r2030160837
##########
core/src/main/scala/kafka/server/ReplicaManager.scala:
##########
@@ -1038,9 +1039,10 @@ class ReplicaManager(val config: KafkaConfig,
callback: ((Map[TopicPartition, Errors], Map[TopicPartition,
VerificationGuard])) => Unit,
transactionSupportedOperation: TransactionSupportedOperation
): Unit = {
+ val transactionLogConfig = new TransactionLogConfig(config)
Review Comment:
this is the hot path, so could you please change the condition order to
avoid creating `TransactionLogConfig` too early.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
