[PR] KAFKA-15931: Reopen TransactionIndex if channel is closed (#15241) [kafka]

2025-03-07 Thread via GitHub
jeqo opened a new pull request, #19150: URL: https://github.com/apache/kafka/pull/19150 Backports to 3.9 Cached TransactionIndex may get closed if interrupted, causing following calls to always fail with ClosedChannelException, and forcing process to be restarted. In order to avoid t

Re: [PR] KAFKA-18736: Decide when a heartbeat should be sent [kafka]

2025-03-07 Thread via GitHub
lucasbru commented on code in PR #19121: URL: https://github.com/apache/kafka/pull/19121#discussion_r1985060504 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/StreamsGroupHeartbeatRequestManager.java: ## @@ -254,34 +284,131 @@ public StreamsGroupHeartbeatRe

Re: [PR] KAFKA-18932: Removed usage of partition max bytes from share fetch requests on the broker [kafka]

2025-03-07 Thread via GitHub
apoorvmittal10 commented on code in PR #19148: URL: https://github.com/apache/kafka/pull/19148#discussion_r1985008350 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -3139,15 +3135,15 @@ class KafkaApis(val requestChannel: RequestChannel, val erroneous = mutable.

Re: [PR] KAFKA-18024 ConcurrentModificationException in Kafka OffsetFetcher - Proposal for Thread-Safety Fix - Update OffsetFetcher.java [kafka]

2025-03-07 Thread via GitHub
kamil-adam-nowak commented on PR #17826: URL: https://github.com/apache/kafka/pull/17826#issuecomment-2706197467 @kamalcph @kirktrue @chia7712 I'm not entirely sure if my patch is the perfect solution, but it works for me and helps resolve the issue. As seen in the stacktrace, the er

[jira] [Updated] (KAFKA-18286) Add support for streams groups to kafka-group.sh

2025-03-07 Thread Lucas Brutschy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18286?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lucas Brutschy updated KAFKA-18286: --- Description: Add support for streams groups in kafka-group.sh. This is already present on t

Re: [PR] KAFKA-18929: Log a warning when time based segment delete is blocked by a future timestamp [kafka]

2025-03-07 Thread via GitHub
viktorsomogyi merged PR #19137: URL: https://github.com/apache/kafka/pull/19137 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.a

Re: [PR] KAFKA-18602: Incorrect FinalizedVersionLevel reported for dynamic KRaft quorum [kafka]

2025-03-07 Thread via GitHub
FrankYang0529 commented on code in PR #18685: URL: https://github.com/apache/kafka/pull/18685#discussion_r1985052075 ## core/src/main/scala/kafka/server/metadata/KRaftMetadataCache.scala: ## @@ -522,10 +522,14 @@ class KRaftMetadataCache( if (kraftVersionLevel > 0) {

Re: [PR] KAFKA-18932: Removed usage of partition max bytes from share fetch requests on the broker [kafka]

2025-03-07 Thread via GitHub
apoorvmittal10 commented on code in PR #19148: URL: https://github.com/apache/kafka/pull/19148#discussion_r1985062347 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -3139,15 +3135,15 @@ class KafkaApis(val requestChannel: RequestChannel, val erroneous = mutable.

[jira] [Assigned] (KAFKA-18939) kafka-site preview does not use the correct rewrite rules

2025-03-07 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18939?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai reassigned KAFKA-18939: -- Assignee: 黃竣陽 (was: Chia-Ping Tsai) > kafka-site preview does not use the correct re

[jira] [Resolved] (KAFKA-18939) kafka-site preview does not use the correct rewrite rules

2025-03-07 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18939?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-18939. Resolution: Fixed > kafka-site preview does not use the correct rewrite rules > --

[jira] [Commented] (KAFKA-18939) kafka-site preview does not use the correct rewrite rules

2025-03-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1796#comment-1796 ] ASF GitHub Bot commented on KAFKA-18939: chia7712 merged PR #665: URL: https://g

[PR] MINOR: Wrapping exceptions in usage for groups and metrics utility [kafka]

2025-03-07 Thread via GitHub
apoorvmittal10 opened a new pull request, #19151: URL: https://github.com/apache/kafka/pull/19151 If specified an invalid option then an exception trace appears with `kafka-client-metrics.sh` and `kafka-groups.sh` utilities. Then once has to explicitly remove the invalid argument and append

Re: [PR] KAFKA-18932: Removed usage of partition max bytes from share fetch requests on the broker [kafka]

2025-03-07 Thread via GitHub
apoorvmittal10 commented on code in PR #19148: URL: https://github.com/apache/kafka/pull/19148#discussion_r1985060904 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -3139,15 +3135,15 @@ class KafkaApis(val requestChannel: RequestChannel, val erroneous = mutable.

Re: [PR] KAFKA-18736: Decide when a heartbeat should be sent [kafka]

2025-03-07 Thread via GitHub
cadonna commented on code in PR #19121: URL: https://github.com/apache/kafka/pull/19121#discussion_r1982894114 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/StreamsGroupHeartbeatRequestManager.java: ## @@ -254,34 +284,131 @@ public StreamsGroupHeartbeatReq

[jira] [Commented] (KAFKA-18818) Significant delay in Metadata Update After Admin Client Operations in KRaft Mode

2025-03-07 Thread PoAn Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17933347#comment-17933347 ] PoAn Yang commented on KAFKA-18818: --- [~shubhamraj] , IIUC, in kraft mode, we need to w

[PR] MINOR remove legacy branch protections from asf.yaml [kafka]

2025-03-07 Thread via GitHub
mumrah opened a new pull request, #19152: URL: https://github.com/apache/kafka/pull/19152 Infra has manually setup rulesets for trunk and our release branches (INFRA-26603). We need to disable the legacy branch protections to avoid interfering with the new rulesets. -- This is an automat

Re: [PR] KAFKA-18932: Removed usage of partition max bytes from share fetch requests on the broker [kafka]

2025-03-07 Thread via GitHub
adixitconfluent commented on code in PR #19148: URL: https://github.com/apache/kafka/pull/19148#discussion_r1985179562 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -3139,15 +3135,15 @@ class KafkaApis(val requestChannel: RequestChannel, val erroneous = mutable

[PR] MINOR KIP link change to use immutable link [kafka]

2025-03-07 Thread via GitHub
m1a2st opened a new pull request, #19153: URL: https://github.com/apache/kafka/pull/19153 see discussion: https://github.com/apache/kafka/pull/19141#issuecomment-2705836234 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] KAFKA-18901: [1/N] Improved homogeneous SimpleAssignor [kafka]

2025-03-07 Thread via GitHub
AndrewJSchofield commented on code in PR #19142: URL: https://github.com/apache/kafka/pull/19142#discussion_r1984814955 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/SimpleAssignor.java: ## @@ -135,56 +148,68 @@ private GroupAssignment newAssignm

[jira] [Commented] (KAFKA-18938) Kraft version and metadata version wrongly showing

2025-03-07 Thread Rameshkanna N (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17933215#comment-17933215 ] Rameshkanna N commented on KAFKA-18938: --- Hi [~yangpoan] , while starting the {*}co

[jira] [Commented] (KAFKA-18818) Significant delay in Metadata Update After Admin Client Operations in KRaft Mode

2025-03-07 Thread Shubham Raj (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1793#comment-1793 ] Shubham Raj commented on KAFKA-18818: - [~junrao] [~yangpoan] [~dajac] [~cmccabe] Can

Re: [PR] KAFKA-18602: Incorrect FinalizedVersionLevel reported for dynamic KRaft quorum [kafka]

2025-03-07 Thread via GitHub
chia7712 commented on code in PR #18685: URL: https://github.com/apache/kafka/pull/18685#discussion_r1985095404 ## core/src/main/scala/kafka/server/metadata/KRaftMetadataCache.scala: ## @@ -522,10 +522,14 @@ class KRaftMetadataCache( if (kraftVersionLevel > 0) { fina

Re: [PR] KAFKA-15931: Reopen TransactionIndex if channel is closed [kafka]

2025-03-07 Thread via GitHub
showuon merged PR #15241: URL: https://github.com/apache/kafka/pull/15241 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[jira] [Commented] (KAFKA-18939) kafka-site preview does not use the correct rewrite rules

2025-03-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17933289#comment-17933289 ] ASF GitHub Bot commented on KAFKA-18939: m1a2st opened a new pull request, #665:

[jira] [Created] (KAFKA-18940) Fix uncleanLeaderElection metric due to ELR election

2025-03-07 Thread Calvin Liu (Jira)
Calvin Liu created KAFKA-18940: -- Summary: Fix uncleanLeaderElection metric due to ELR election Key: KAFKA-18940 URL: https://issues.apache.org/jira/browse/KAFKA-18940 Project: Kafka Issue Type:

[jira] [Updated] (KAFKA-18940) Fix uncleanLeaderElection metric due to ELR election

2025-03-07 Thread Calvin Liu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18940?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Calvin Liu updated KAFKA-18940: --- Fix Version/s: 4.0.1 (was: 4.0.0) > Fix uncleanLeaderElection metric due to E

[jira] [Updated] (KAFKA-18940) Fix uncleanLeaderElection metric due to ELR election

2025-03-07 Thread Calvin Liu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18940?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Calvin Liu updated KAFKA-18940: --- Affects Version/s: 4.0.0 > Fix uncleanLeaderElection metric due to ELR election > --

Re: [PR] MINOR: Improve grammar and clarity in upgrade.html [kafka]

2025-03-07 Thread via GitHub
chia7712 commented on PR #19141: URL: https://github.com/apache/kafka/pull/19141#issuecomment-2705836234 @m1a2st I agree that using the immutable URL is better. Could you please open a MINOR to fix all of them? -- This is an automated message from the Apache Git Service. To respond to th

Re: [PR] MINOR: Improve grammar and clarity in upgrade.html [kafka]

2025-03-07 Thread via GitHub
m1a2st commented on PR #19141: URL: https://github.com/apache/kafka/pull/19141#issuecomment-2705849823 sure, I will open another PR to address that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[jira] [Commented] (KAFKA-18938) Kraft version and metadata version wrongly showing

2025-03-07 Thread PoAn Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17933233#comment-17933233 ] PoAn Yang commented on KAFKA-18938: --- [~rameshkanna], could you try latest 3.9 branch?

[jira] [Commented] (KAFKA-18913) Consider removing state-updater feature flag

2025-03-07 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17933232#comment-17933232 ] Bruno Cadonna commented on KAFKA-18913: --- Thank you for your interest, [~janchillin

[PR] [WIP] MINOR: Adjust ToC of zk2kraft and fix wrong section number of docker [kafka]

2025-03-07 Thread via GitHub
frankvicky opened a new pull request, #19146: URL: https://github.com/apache/kafka/pull/19146 Delete this text and replace it with a detailed description of your change. The PR title and body will become the squashed commit message. If you would like to tag individuals, add some c

Re: [PR] MINOR: Improve grammar and clarity in upgrade.html [kafka]

2025-03-07 Thread via GitHub
mingdaoy commented on code in PR #19141: URL: https://github.com/apache/kafka/pull/19141#discussion_r1984388328 ## docs/upgrade.html: ## @@ -74,24 +74,24 @@ Notable changes in 4 The Next Generation of the Consumer Rebalance Protocol (https://cwiki.apache.o

Re: [PR] KAFKA-18046; High CPU usage when using Log4j2 [kafka]

2025-03-07 Thread via GitHub
dajac commented on PR #19138: URL: https://github.com/apache/kafka/pull/19138#issuecomment-2705797666 Cherry-picked it to 4.0 and 3.9. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Updated] (KAFKA-18871) KRaft migration rollback causes downtime

2025-03-07 Thread Daniel Urban (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18871?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Urban updated KAFKA-18871: - Attachment: zookeeper_logs.zip > KRaft migration rollback causes downtime >

[jira] [Assigned] (KAFKA-18046) High CPU usage when using Log4j2

2025-03-07 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18046?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot reassigned KAFKA-18046: --- Fix Version/s: 4.0.0 3.9.1 Assignee: David Jacot Resoluti

[jira] [Commented] (KAFKA-18046) High CPU usage when using Log4j2

2025-03-07 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17933222#comment-17933222 ] David Jacot commented on KAFKA-18046: - [~Anthony Maire] We merged to fix that I prop

Re: [PR] KAFKA-17607: Add CI step to verify LICENSE-binary [kafka]

2025-03-07 Thread via GitHub
xijiu commented on code in PR #18299: URL: https://github.com/apache/kafka/pull/18299#discussion_r1984638564 ## committer-tools/verify_license.py: ## @@ -77,14 +77,14 @@ def get_license_deps(license_text): def main(): # Argument parser parser = argparse.ArgumentParser

[jira] [Commented] (KAFKA-18871) KRaft migration rollback causes downtime

2025-03-07 Thread Daniel Urban (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17933223#comment-17933223 ] Daniel Urban commented on KAFKA-18871: -- [~showuon]  The controller logs are already

Re: [PR] MINOR: Improve grammar and clarity in upgrade.html [kafka]

2025-03-07 Thread via GitHub
m1a2st commented on code in PR #19141: URL: https://github.com/apache/kafka/pull/19141#discussion_r1984619995 ## docs/upgrade.html: ## @@ -74,24 +74,24 @@ Notable changes in 4 The Next Generation of the Consumer Rebalance Protocol (https://cwiki.apache.org

Re: [PR] HOTFIX: Do not use highest version when version is valid [kafka]

2025-03-07 Thread via GitHub
dengziming commented on PR #19109: URL: https://github.com/apache/kafka/pull/19109#issuecomment-2705871265 Hello @ijuma @chia7712 . The existing test cases are sufficient for spotting this bug, they didn't fail because we didn't bump the version in the previous PR. If we bump the vers

[jira] [Resolved] (KAFKA-18846) Flaky test QuorumControllerTest#testMinIsrUpdateWithElr

2025-03-07 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-18846?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] 黃竣陽 resolved KAFKA-18846. - Resolution: Won't Fix > Flaky test QuorumControllerTest#testMinIsrUpdateWithElr > --

[jira] [Commented] (KAFKA-18846) Flaky test QuorumControllerTest#testMinIsrUpdateWithElr

2025-03-07 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-18846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17933486#comment-17933486 ] 黃竣陽 commented on KAFKA-18846: - Thanks for the reminder. It looks like this flaky test never

Re: [PR] KAFKA-14484: Move UnifiedLog to storage module [kafka]

2025-03-07 Thread via GitHub
junrao commented on code in PR #19030: URL: https://github.com/apache/kafka/pull/19030#discussion_r1985886395 ## storage/src/main/java/org/apache/kafka/storage/internals/log/UnifiedLog.java: ## @@ -55,6 +113,2289 @@ public class UnifiedLog { public static final String STRAY

Re: [PR] KAFKA-18561: Remove withKip853Rpc and replace it with withRaftProtocol [kafka]

2025-03-07 Thread via GitHub
frankvicky commented on code in PR #18600: URL: https://github.com/apache/kafka/pull/18600#discussion_r1985957796 ## raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientTest.java: ## @@ -3256,24 +3268,25 @@ public void testDescribeQuorumWithOnlyStaticVoters(boolean withKip8

[jira] [Assigned] (KAFKA-15313) Delete remote log segments partition asynchronously when a partition is deleted.

2025-03-07 Thread Azhar Ahmed (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Azhar Ahmed reassigned KAFKA-15313: --- Assignee: Azhar Ahmed (was: Abhijeet Kumar) > Delete remote log segments partition asynchr

[jira] [Commented] (KAFKA-15313) Delete remote log segments partition asynchronously when a partition is deleted.

2025-03-07 Thread Azhar Ahmed (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17933491#comment-17933491 ] Azhar Ahmed commented on KAFKA-15313: - [~abhijeetkumar] Assigning this to myself for

Re: [PR] KAFKA-18379: Enforce resigned cannot transition to any other state in same epoch [kafka]

2025-03-07 Thread via GitHub
github-actions[bot] commented on PR #18789: URL: https://github.com/apache/kafka/pull/18789#issuecomment-2707966143 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] KAFKA-18576: Convert ConfigType to Enum [kafka]

2025-03-07 Thread via GitHub
github-actions[bot] commented on PR #18711: URL: https://github.com/apache/kafka/pull/18711#issuecomment-2707966161 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] MINOR KIP link change to use immutable link [kafka]

2025-03-07 Thread via GitHub
frankvicky commented on code in PR #19153: URL: https://github.com/apache/kafka/pull/19153#discussion_r1985979479 ## docs/streams/upgrade-guide.html: ## @@ -849,13 +849,13 @@ Streams API KeyQueryMetadata was introduced in Kafka Streams 2.5 release with getter methods h

[PR] KAFKA-18703: Remove unused class PayloadKeyType [kafka]

2025-03-07 Thread via GitHub
mingdaoy opened a new pull request, #19129: URL: https://github.com/apache/kafka/pull/19129 https://issues.apache.org/jira/browse/KAFKA-18703 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

Re: [PR] KAFKA-17171: Add test cases for `STATIC_BROKER_CONFIG`in kraft mode [kafka]

2025-03-07 Thread via GitHub
github-actions[bot] commented on PR #18463: URL: https://github.com/apache/kafka/pull/18463#issuecomment-2707966309 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] KAFKA-18940: fix electionWasClean [kafka]

2025-03-07 Thread via GitHub
junrao commented on PR #19156: URL: https://github.com/apache/kafka/pull/19156#issuecomment-2707203007 @dajac : Could you help cherry-pick this to the 4.0 branch? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Commented] (KAFKA-18846) Flaky test QuorumControllerTest#testMinIsrUpdateWithElr

2025-03-07 Thread Azhar Ahmed (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17933415#comment-17933415 ] Azhar Ahmed commented on KAFKA-18846: - Tried reproducing it by running this test a d

Re: [PR] MINOR: Small fit and finish changes to Producer config doc strings [kafka]

2025-03-07 Thread via GitHub
jolshan merged PR #19125: URL: https://github.com/apache/kafka/pull/19125 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

Re: [PR] KAFKA-18561: Remove withKip853Rpc and replace it with withRaftProtocol [kafka]

2025-03-07 Thread via GitHub
ahuang98 commented on code in PR #18600: URL: https://github.com/apache/kafka/pull/18600#discussion_r1985666059 ## raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientTest.java: ## @@ -4704,4 +4715,21 @@ static ReplicaKey replicaKey(int id, boolean withDirectoryId) { s

Re: [PR] KAFKA-18561: Remove withKip853Rpc and replace it with withRaftProtocol [kafka]

2025-03-07 Thread via GitHub
ahuang98 commented on code in PR #18600: URL: https://github.com/apache/kafka/pull/18600#discussion_r1985681042 ## raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientTest.java: ## @@ -3256,24 +3268,25 @@ public void testDescribeQuorumWithOnlyStaticVoters(boolean withKip853

Re: [PR] KAFKA-18929: Log a warning when time based segment delete is blocked by a future timestamp [kafka]

2025-03-07 Thread via GitHub
viktorsomogyi commented on PR #19137: URL: https://github.com/apache/kafka/pull/19137#issuecomment-2703861797 @urbandan please provide a description for your PR, at least a small justification for making the change. -- This is an automated message from the Apache Git Service. To respond t

[jira] [Comment Edited] (KAFKA-18871) KRaft migration rollback causes downtime

2025-03-07 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17932941#comment-17932941 ] Luke Chen edited comment on KAFKA-18871 at 3/6/25 11:03 AM:

[jira] [Commented] (KAFKA-18818) Significant delay in Metadata Update After Admin Client Operations in KRaft Mode

2025-03-07 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-18818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17933388#comment-17933388 ] José Armando García Sancio commented on KAFKA-18818: This may be rel

Re: [PR] KAFKA-18602: Incorrect FinalizedVersionLevel reported for dynamic KRaft quorum [kafka]

2025-03-07 Thread via GitHub
chia7712 commented on code in PR #18685: URL: https://github.com/apache/kafka/pull/18685#discussion_r1985530280 ## core/src/main/scala/kafka/server/metadata/KRaftMetadataCache.scala: ## @@ -522,10 +522,14 @@ class KRaftMetadataCache( if (kraftVersionLevel > 0) { fina

Re: [PR] KAFKA-18602: Incorrect FinalizedVersionLevel reported for dynamic KRaft quorum [kafka]

2025-03-07 Thread via GitHub
ijuma commented on code in PR #18685: URL: https://github.com/apache/kafka/pull/18685#discussion_r1985515760 ## core/src/main/scala/kafka/server/metadata/KRaftMetadataCache.scala: ## @@ -522,10 +522,14 @@ class KRaftMetadataCache( if (kraftVersionLevel > 0) { finaliz

Re: [PR] KAFKA-18927: Remove LATEST_0_11, LATEST_1_0, LATEST_1_1, LATEST_2_0 [kafka]

2025-03-07 Thread via GitHub
mjsax commented on PR #19134: URL: https://github.com/apache/kafka/pull/19134#issuecomment-2707092806 42 tests failed: http://ducktape-open-source-results.confluent.io.s3-website-us-west-2.amazonaws.com/confluent-open-source-kafka-branch-builder-system-test-results/?prefix=trunk/2025-

[PR] Minor: Fix missing argument in kafka-features.sh upgrade doc [kafka]

2025-03-07 Thread via GitHub
MahsaSeifikar opened a new pull request, #19160: URL: https://github.com/apache/kafka/pull/19160 Running `bin/kafka-features.sh upgrade --release-version 4.0` results in the followin error. This PR fixes the issue by adding the required argument. `kafka-features: error: one of the arg

Re: [PR] KAFKA-18788 Fix the inconsistent lastest supported version in StorageTool.scala and FutureCommand [kafka]

2025-03-07 Thread via GitHub
chia7712 commented on PR #19157: URL: https://github.com/apache/kafka/pull/19157#issuecomment-2707215822 @m1a2st please fix the title. `18788` -> `18778` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] MINOR: Improve grammar and clarity in upgrade.html [kafka]

2025-03-07 Thread via GitHub
mingdaoy commented on PR #19141: URL: https://github.com/apache/kafka/pull/19141#issuecomment-2705262631 https://github.com/apache/kafka/pull/19096/files#diff-439593088d083e21a92c1a0d89e4f299147740d123283a62cc7a303c2b5a7e0fL34 I noticed a previous PR and was curious about our docs' st

Re: [PR] KAFKA-18920: The kcontrollers must set kraft.version in ApiVersionsResponse [kafka]

2025-03-07 Thread via GitHub
cmccabe merged PR #19127: URL: https://github.com/apache/kafka/pull/19127 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[jira] [Commented] (KAFKA-15313) Delete remote log segments partition asynchronously when a partition is deleted.

2025-03-07 Thread Azhar Ahmed (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17933456#comment-17933456 ] Azhar Ahmed commented on KAFKA-15313: - Hi [~abhijeetkumar] we have run into this iss

[PR] MINOR: Use readable interface to parse requests [kafka]

2025-03-07 Thread via GitHub
soondenana opened a new pull request, #19163: URL: https://github.com/apache/kafka/pull/19163 The generated `*RequestData` java file constructors take `Readable` as an input. However, the `parse` method in the `AbstractRequest` takes a `ByteBuffer` as input. So to create the corresponding `

Re: [PR] MINOR: Adjust ToC of zk2kraft and fix wrong section number of docker [kafka]

2025-03-07 Thread via GitHub
chia7712 commented on code in PR #19146: URL: https://github.com/apache/kafka/pull/19146#discussion_r1985495650 ## docs/zk2kraft-summary.html: ## @@ -0,0 +1,27 @@ + + + + +

Re: [PR] KAFKA-18602: Incorrect FinalizedVersionLevel reported for dynamic KRaft quorum [kafka]

2025-03-07 Thread via GitHub
ijuma commented on code in PR #18685: URL: https://github.com/apache/kafka/pull/18685#discussion_r1985518686 ## core/src/main/scala/kafka/server/metadata/KRaftMetadataCache.scala: ## @@ -522,10 +522,14 @@ class KRaftMetadataCache( if (kraftVersionLevel > 0) { finaliz

Re: [PR] MINOR: fix: add missing @Test lost while rebasing [kafka]

2025-03-07 Thread via GitHub
chia7712 commented on code in PR #19149: URL: https://github.com/apache/kafka/pull/19149#discussion_r1985580616 ## storage/src/test/java/org/apache/kafka/storage/internals/log/TransactionIndexTest.java: ## @@ -272,7 +273,7 @@ void testAppendAndCollectAfterClose() throws IOExcept

Re: [PR] KAFKA-18613: Add StreamsGroupHeartbeat handler in the group coordinator [kafka]

2025-03-07 Thread via GitHub
cadonna commented on code in PR #19114: URL: https://github.com/apache/kafka/pull/19114#discussion_r1985465088 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/streams/TasksTuple.java: ## @@ -30,11 +34,11 @@ * An immutable tuple containing active, standby

Re: [PR] MINOR: Use readable interface to parse requests [kafka]

2025-03-07 Thread via GitHub
ijuma commented on code in PR #19163: URL: https://github.com/apache/kafka/pull/19163#discussion_r1985768753 ## clients/src/main/java/org/apache/kafka/common/protocol/MessageUtil.java: ## @@ -204,13 +204,17 @@ public static boolean compareRawTaggedFields(List first, }

Re: [PR] MINOR: Fix missing argument in kafka-features.sh upgrade doc [kafka]

2025-03-07 Thread via GitHub
cmccabe merged PR #19160: URL: https://github.com/apache/kafka/pull/19160 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[PR] Fix minor issues in ops doc [kafka]

2025-03-07 Thread via GitHub
MahsaSeifikar opened a new pull request, #19158: URL: https://github.com/apache/kafka/pull/19158 This PR adds the command related to starting the Kraft controller into the `Provisioning the Kraft Controller quorum` section. I think it's better to include it there instead of switching back a

[jira] [Created] (KAFKA-18941) Remove tests/docker/run_tests.sh

2025-03-07 Thread Jonah Hooper (Jira)
Jonah Hooper created KAFKA-18941: Summary: Remove tests/docker/run_tests.sh Key: KAFKA-18941 URL: https://issues.apache.org/jira/browse/KAFKA-18941 Project: Kafka Issue Type: Improvement

Re: [PR] MINOR: Disallow unused local variables [kafka]

2025-03-07 Thread via GitHub
mumrah commented on PR #18963: URL: https://github.com/apache/kafka/pull/18963#issuecomment-2707170074 @lucasbru yea, I think we gave enough time for any concerned parties to chime in :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[jira] [Created] (KAFKA-18942) Add reviewers to PR body with committer-tools

2025-03-07 Thread David Arthur (Jira)
David Arthur created KAFKA-18942: Summary: Add reviewers to PR body with committer-tools Key: KAFKA-18942 URL: https://issues.apache.org/jira/browse/KAFKA-18942 Project: Kafka Issue Type: Sub

Re: [PR] KAFKA-18561: Remove withKip853Rpc and replace it with withRaftProtocol [kafka]

2025-03-07 Thread via GitHub
ahuang98 commented on code in PR #18600: URL: https://github.com/apache/kafka/pull/18600#discussion_r1985705585 ## raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientSnapshotTest.java: ## @@ -276,16 +281,16 @@ public void testListenerRenotified(boolean withKip853Rpc) throw

Re: [PR] KAFKA-18561: Remove withKip853Rpc and replace it with withRaftProtocol [kafka]

2025-03-07 Thread via GitHub
ahuang98 commented on code in PR #18600: URL: https://github.com/apache/kafka/pull/18600#discussion_r1985681042 ## raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientTest.java: ## @@ -3256,24 +3268,25 @@ public void testDescribeQuorumWithOnlyStaticVoters(boolean withKip853

Re: [PR] KAFKA-18901: [1/N] Improved homogeneous SimpleAssignor [kafka]

2025-03-07 Thread via GitHub
mumrah commented on code in PR #19142: URL: https://github.com/apache/kafka/pull/19142#discussion_r1985507925 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/SimpleAssignor.java: ## @@ -135,56 +148,71 @@ private GroupAssignment newAssignmentHomogen

Re: [PR] KAFKA-18602: Incorrect FinalizedVersionLevel reported for dynamic KRaft quorum [kafka]

2025-03-07 Thread via GitHub
junrao commented on code in PR #18685: URL: https://github.com/apache/kafka/pull/18685#discussion_r1985500986 ## core/src/main/scala/kafka/server/metadata/KRaftMetadataCache.scala: ## @@ -522,10 +522,14 @@ class KRaftMetadataCache( if (kraftVersionLevel > 0) { finali

[PR] [KAFKA-18941] Removes unneeded tests from upgrade_tests.py [kafka]

2025-03-07 Thread via GitHub
josefk31 opened a new pull request, #19162: URL: https://github.com/apache/kafka/pull/19162 The upgrade test in question is not supported for AK 3.3.2 due to a [known issue](https://issues.apache.org/jira/browse/KAFKA-18941). Previous attempt at solving this left the `metadata.log.dir` empt

Re: [PR] [KAFKA-18941] Removes unneeded tests from upgrade_tests.py [kafka]

2025-03-07 Thread via GitHub
josefk31 commented on PR #19162: URL: https://github.com/apache/kafka/pull/19162#issuecomment-2707469189 I have tested this locally with the `ducker-ak` tool. The system tests work. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[jira] [Updated] (KAFKA-18943) Kafka Streams incorrectly commits TX during task revokation

2025-03-07 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18943?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-18943: Description: We found a very rare edge case in Kafka Streams commit logic, that may lead t

<    1   2