FrankYang0529 commented on code in PR #18685:
URL: https://github.com/apache/kafka/pull/18685#discussion_r1985052075
##########
core/src/main/scala/kafka/server/metadata/KRaftMetadataCache.scala:
##########
@@ -522,10 +522,14 @@ class KRaftMetadataCache(
if (kraftVersionLevel > 0) {
finalizedFeatures.put(KRaftVersion.FEATURE_NAME, kraftVersionLevel)
}
+ var metadataVersion = MetadataVersion.MINIMUM_VERSION
Review Comment:
@cmccabe I think `MetadataLoader#installPublishers` doesn't really wait for
publishers initialized, because it uses `scheduleInitializeNewPublishers` to
schedule another task and complete future immediately.
https://github.com/apache/kafka/blob/269e8892ad26904c82a3bff7b7d7a81c47619e4a/metadata/src/main/java/org/apache/kafka/image/loader/MetadataLoader.java#L486-L492
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
