Re: [PR] KAFKA-18757: Create full-function SimpleAssignor to match KIP-932 description [kafka]

2025-02-19 Thread via GitHub
adixitconfluent commented on code in PR #18864: URL: https://github.com/apache/kafka/pull/18864#discussion_r1961201931 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/SimpleAssignor.java: ## @@ -72,36 +77,178 @@ private GroupAssignment assignHomoge

[PR] [WIP] MINOR: Forbid unused locals [kafka]

2025-02-19 Thread via GitHub
lucasbru opened a new pull request, #18963: URL: https://github.com/apache/kafka/pull/18963 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of testin

[jira] [Updated] (KAFKA-18829) Can't use explicit ack when poll returns an empty batch

2025-02-19 Thread Gunnar Morling (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18829?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gunnar Morling updated KAFKA-18829: --- Description: I am getting the following exception when trying to acknowledge a message with

[jira] [Assigned] (KAFKA-18829) Can't use explicit ack when poll returns an empty batch

2025-02-19 Thread Andrew Schofield (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18829?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Schofield reassigned KAFKA-18829: Assignee: Shivsundar R > Can't use explicit ack when poll returns an empty batch

Re: [PR] KAFKA-18828: Update share group metrics per new init and call mechanism. [kafka]

2025-02-19 Thread via GitHub
apoorvmittal10 commented on PR #18962: URL: https://github.com/apache/kafka/pull/18962#issuecomment-2668125459 @smjn While you are fixing the group-count can you please also take at following conversation and add the minor change in the PR. We shall correct the KIP as well later. -- This

[jira] [Commented] (KAFKA-18829) Can't use explicit ack when poll returns an empty batch

2025-02-19 Thread Andrew Schofield (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17928376#comment-17928376 ] Andrew Schofield commented on KAFKA-18829: -- I expect the logic that figures out

[jira] [Created] (KAFKA-18829) Can't use explicit ack when poll returns an empty batch

2025-02-19 Thread Gunnar Morling (Jira)
Gunnar Morling created KAFKA-18829: -- Summary: Can't use explicit ack when poll returns an empty batch Key: KAFKA-18829 URL: https://issues.apache.org/jira/browse/KAFKA-18829 Project: Kafka I

Re: [PR] MINOR: disallow rawtypes and fail build [kafka]

2025-02-19 Thread via GitHub
AndrewJSchofield commented on code in PR #18877: URL: https://github.com/apache/kafka/pull/18877#discussion_r1961407894 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/SinkNode.java: ## @@ -56,18 +56,19 @@ public void addChild(final ProcessorNode child) {

[jira] [Resolved] (KAFKA-18198) Disallow piggyback acknowledgments on initial ShareFetchRequest.

2025-02-19 Thread Andrew Schofield (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Schofield resolved KAFKA-18198. -- Fix Version/s: 4.1.0 Resolution: Fixed > Disallow piggyback acknowledgments on

Re: [PR] KAFKA-18198: Added check to prevent acknowledgements on initial ShareFetchRequest. [kafka]

2025-02-19 Thread via GitHub
AndrewJSchofield merged PR #18944: URL: https://github.com/apache/kafka/pull/18944 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafk

Re: [PR] KAFKA-18779: Validate responses from broker in client for ShareFetch and ShareAcknowledge RPCs. [kafka]

2025-02-19 Thread via GitHub
AndrewJSchofield commented on code in PR #18939: URL: https://github.com/apache/kafka/pull/18939#discussion_r1961464616 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ShareConsumeRequestManager.java: ## @@ -851,59 +873,25 @@ private void handleShareAcknowle

Re: [PR] MINOR: Add a separate page for zk2kraft.html [kafka]

2025-02-19 Thread via GitHub
mingdaoy commented on code in PR #18961: URL: https://github.com/apache/kafka/pull/18961#discussion_r1960998479 ## docs/upgrade.html: ## @@ -48,7 +48,6 @@ Notable changes in 4 Before updating your Kafka cluster which build on Zookeeper to Kafka 4.0, you must unders

Re: [PR] MINOR: Add a separate page for zk2kraft.html [kafka]

2025-02-19 Thread via GitHub
mingdaoy commented on code in PR #18961: URL: https://github.com/apache/kafka/pull/18961#discussion_r1961512459 ## docs/upgrade.html: ## @@ -45,10 +45,8 @@ Notable changes in 4 https://cwiki.apache.org/confluence/display/KAFKA/KIP-896%3A+Remove+old+client+protocol+A

Re: [PR] KAFKA-18601: Assume a baseline of 3.3 for server protocol versions [kafka]

2025-02-19 Thread via GitHub
ijuma commented on PR #18845: URL: https://github.com/apache/kafka/pull/18845#issuecomment-2668661378 I will go ahead and merge this. If @junrao has any additional comments, I will submit a separate PR to address those. -- This is an automated message from the Apache Git Service. To respo

[jira] [Updated] (KAFKA-18601) Assume a baseline of 3.3 for server protocol versions

2025-02-19 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-18601: Description: 3.3.0 was the first KRaft release that was deemed production-ready and also when KIP-

Re: [PR] MINOR: Update upgrade notes for 4.0.0 [kafka]

2025-02-19 Thread via GitHub
ijuma commented on code in PR #18960: URL: https://github.com/apache/kafka/pull/18960#discussion_r1961774094 ## docs/upgrade.html: ## @@ -29,25 +29,39 @@ Notable changes in 4 -Upgrading to 4.0.0 from any version 0.8.x through 3.9.x +Upg

Re: [PR] KAFKA-18779: Validate responses from broker in client for ShareFetch and ShareAcknowledge RPCs. [kafka]

2025-02-19 Thread via GitHub
ShivsundarR commented on code in PR #18939: URL: https://github.com/apache/kafka/pull/18939#discussion_r1961579512 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ShareConsumeRequestManager.java: ## @@ -851,59 +873,25 @@ private void handleShareAcknowledgeSu

Re: [PR] KAFKA-18779: Validate responses from broker in client for ShareFetch and ShareAcknowledge RPCs. [kafka]

2025-02-19 Thread via GitHub
ShivsundarR commented on code in PR #18939: URL: https://github.com/apache/kafka/pull/18939#discussion_r1961580125 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ShareConsumeRequestManager.java: ## @@ -97,6 +99,7 @@ public class ShareConsumeRequestManager i

Re: [PR] KAFKA-18829: Added check before converting to IMPLICIT mode [kafka]

2025-02-19 Thread via GitHub
ShivsundarR commented on code in PR #18964: URL: https://github.com/apache/kafka/pull/18964#discussion_r1961771474 ## core/src/test/java/kafka/test/api/ShareConsumerTest.java: ## @@ -688,6 +688,41 @@ public void testExplicitAcknowledgementCommitAsync() throws InterruptedExcepti

Re: [PR] MIINOR: Remove redundant quorum parameter from *AdminIntegrationTest classes [kafka]

2025-02-19 Thread via GitHub
ijuma commented on PR #18965: URL: https://github.com/apache/kafka/pull/18965#issuecomment-2668857896 @lianetm Do you have cycles to review this mechanical PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[PR] Bump asf.yaml again [kafka-merge-queue-sandbox]

2025-02-19 Thread via GitHub
mumrah opened a new pull request, #59: URL: https://github.com/apache/kafka-merge-queue-sandbox/pull/59 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] Bump asf.yaml again [kafka-merge-queue-sandbox]

2025-02-19 Thread via GitHub
mumrah merged PR #59: URL: https://github.com/apache/kafka-merge-queue-sandbox/pull/59 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@

Re: [PR] KAFKA-18829: Added check before converting to IMPLICIT mode [kafka]

2025-02-19 Thread via GitHub
AndrewJSchofield commented on code in PR #18964: URL: https://github.com/apache/kafka/pull/18964#discussion_r1961700426 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ShareConsumerImpl.java: ## @@ -1018,7 +1018,7 @@ private void acknowledgeBatchIfImplicitA

Re: [PR] KAFKA-18601: Assume a baseline of 3.3 for server protocol versions [kafka]

2025-02-19 Thread via GitHub
mumrah commented on PR #18845: URL: https://github.com/apache/kafka/pull/18845#issuecomment-2668703940 Thanks for pushing this over the line @ijuma. It's great to see these cleanups and removals. "IBP" is all but a memory now :) -- This is an automated message from the Apache Git Service.

Re: [PR] KAFKA-18601: Assume a baseline of 3.3 for server protocol versions [kafka]

2025-02-19 Thread via GitHub
ijuma merged PR #18845: URL: https://github.com/apache/kafka/pull/18845 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

Re: [PR] KAFKA-18737: KafkaDockerWrapper setup functions fails due to storage format command [kafka]

2025-02-19 Thread via GitHub
chia7712 commented on code in PR #18844: URL: https://github.com/apache/kafka/pull/18844#discussion_r1961613921 ## docker/native/Dockerfile: ## @@ -31,13 +33,23 @@ COPY native_command.sh native_command.sh RUN mkdir $KAFKA_DIR; \ microdnf install wget; \ +if [ "$SKIP_

[jira] [Created] (KAFKA-18830) Enable parallel processing for transformation chain

2025-02-19 Thread Padmaprasad Aithal (Jira)
Padmaprasad Aithal created KAFKA-18830: -- Summary: Enable parallel processing for transformation chain Key: KAFKA-18830 URL: https://issues.apache.org/jira/browse/KAFKA-18830 Project: Kafka

[jira] [Resolved] (KAFKA-18601) Assume a baseline of 3.3 for server protocol versions

2025-02-19 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma resolved KAFKA-18601. - Resolution: Fixed > Assume a baseline of 3.3 for server protocol versions >

[jira] [Created] (KAFKA-18832) ShareFetch behaviour seems incorrect when MaxBytes is less than record d

2025-02-19 Thread Andrew Schofield (Jira)
Andrew Schofield created KAFKA-18832: Summary: ShareFetch behaviour seems incorrect when MaxBytes is less than record d Key: KAFKA-18832 URL: https://issues.apache.org/jira/browse/KAFKA-18832 Proj

[jira] [Commented] (KAFKA-18831) Document the behavior changes of adjusting logger level after migrating to log4j2

2025-02-19 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17928456#comment-17928456 ] Chia-Ping Tsai commented on KAFKA-18831: This is somewhat complex, as we need to

Re: [PR] Feb 19 test 2 [kafka-merge-queue-sandbox]

2025-02-19 Thread via GitHub
mumrah merged PR #60: URL: https://github.com/apache/kafka-merge-queue-sandbox/pull/60 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@

Re: [PR] KAFKA-18791 Enable new asf.yaml parser [1/N] [kafka]

2025-02-19 Thread via GitHub
mumrah merged PR #18955: URL: https://github.com/apache/kafka/pull/18955 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.o

[jira] [Updated] (KAFKA-18831) Migrating to log4j2 introduce behavior changes of adjusting level dynamically

2025-02-19 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18831?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-18831: --- Summary: Migrating to log4j2 introduce behavior changes of adjusting level dynamically (was

[jira] [Commented] (KAFKA-15636) Investigate FetcherTest's/FetchRequestManager's testFetchResponseMetrics

2025-02-19 Thread Shivsundar R (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17928493#comment-17928493 ] Shivsundar R commented on KAFKA-15636: -- Hi [~kirktrue] , I was looking into this. Y

[jira] [Comment Edited] (KAFKA-15636) Investigate FetcherTest's/FetchRequestManager's testFetchResponseMetrics

2025-02-19 Thread Shivsundar R (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17928493#comment-17928493 ] Shivsundar R edited comment on KAFKA-15636 at 2/19/25 4:30 PM: ---

[PR] KAFKA-18827: Initialize share state RPC, share coordinator impl. [1/N] [kafka]

2025-02-19 Thread via GitHub
smjn opened a new pull request, #18968: URL: https://github.com/apache/kafka/pull/18968 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of testing st

[jira] [Assigned] (KAFKA-15636) Investigate FetcherTest's/FetchRequestManager's testFetchResponseMetrics

2025-02-19 Thread Shivsundar R (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15636?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shivsundar R reassigned KAFKA-15636: Assignee: Shivsundar R > Investigate FetcherTest's/FetchRequestManager's testFetchRespons

[jira] [Created] (KAFKA-18833) Infinite loop on authenticcation error with AWS MSK AIM

2025-02-19 Thread Sergey Kadaner (Jira)
Sergey Kadaner created KAFKA-18833: -- Summary: Infinite loop on authenticcation error with AWS MSK AIM Key: KAFKA-18833 URL: https://issues.apache.org/jira/browse/KAFKA-18833 Project: Kafka I

[PR] [WIP]KAFKA-18331: Migrating to log4j2 introduce behavior changes of adjusting level dynamically [kafka]

2025-02-19 Thread via GitHub
frankvicky opened a new pull request, #18969: URL: https://github.com/apache/kafka/pull/18969 JIRA: KAFKA-18331 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify do

Re: [PR] MINOR: update truncation test [kafka]

2025-02-19 Thread via GitHub
dajac commented on code in PR #18952: URL: https://github.com/apache/kafka/pull/18952#discussion_r1962052021 ## tests/kafkatest/tests/client/truncation_test.py: ## @@ -112,7 +117,10 @@ def none_consumed(this, consumer): pre_truncation_pos = consumer.current_position(t

[jira] [Comment Edited] (KAFKA-15636) Investigate FetcherTest's/FetchRequestManager's testFetchResponseMetrics

2025-02-19 Thread Shivsundar R (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17928493#comment-17928493 ] Shivsundar R edited comment on KAFKA-15636 at 2/19/25 4:30 PM: ---

Re: [PR] MINOR: deflake EligibleLeaderReplicasIntegrationTest [kafka]

2025-02-19 Thread via GitHub
dajac commented on code in PR #18923: URL: https://github.com/apache/kafka/pull/18923#discussion_r1962047980 ## core/src/test/java/kafka/server/integration/EligibleLeaderReplicasIntegrationTest.java: ## @@ -417,11 +417,21 @@ public void testLastKnownLeaderShouldBeElectedIfEmpty

Re: [PR] KAFKA-17544: Fix for loading big files while performing load tests [kafka]

2025-02-19 Thread via GitHub
manoj-mathivanan commented on PR #18391: URL: https://github.com/apache/kafka/pull/18391#issuecomment-2669113214 > @manoj-mathivanan could you please merge trunk to run CI again? @chia7712 Thank you soo much for looking into this. The CI has completed. Can you help with the next st

Re: [PR] MINOR: Add a separate page for zk2kraft.html [kafka]

2025-02-19 Thread via GitHub
chia7712 commented on PR #18961: URL: https://github.com/apache/kafka/pull/18961#issuecomment-2669244820 > Create a page with a title: "Differences between kraft mode and zk mode". This page exists in trunk/4.0 and describes the differences between both. This is useful for anyone that is fa

Re: [PR] Add TransactionAbortableException and Timeout Exception handling instruction in docs [kafka]

2025-02-19 Thread via GitHub
jolshan merged PR #18942: URL: https://github.com/apache/kafka/pull/18942 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[jira] [Commented] (KAFKA-18831) Document the behavior changes of adjusting logger level after migrating to log4j2

2025-02-19 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17928461#comment-17928461 ] Ismael Juma commented on KAFKA-18831: - Interesting - this is a significant change in

[jira] [Assigned] (KAFKA-18832) ShareFetch behaviour seems incorrect when MaxBytes is less than record size

2025-02-19 Thread Andrew Schofield (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18832?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Schofield reassigned KAFKA-18832: Fix Version/s: 4.1.0 Affects Version/s: 4.1.0 Assignee: Apoor

Re: [PR] MINOR: Add a separate page for zk2kraft.html [kafka]

2025-02-19 Thread via GitHub
frankvicky commented on code in PR #18961: URL: https://github.com/apache/kafka/pull/18961#discussion_r1961913572 ## docs/toc.html: ## @@ -27,6 +27,9 @@ 1.3 Quick Start 1.4 Ecosystem 1.5 Upgrading + +

[jira] [Commented] (KAFKA-18607) Update jfreechart dependency

2025-02-19 Thread Jay Zhang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17928468#comment-17928468 ] Jay Zhang commented on KAFKA-18607: --- Hi [~divijvaidya], may I work on this one? if no

Re: [PR] KAFKA-18791 Set default commit to PR title and description [2/n] [kafka]

2025-02-19 Thread via GitHub
mumrah commented on PR #18967: URL: https://github.com/apache/kafka/pull/18967#issuecomment-2669054694 @chia7712 turns out these changes needed to come in two parts (enable the new parser #18955 and then adding new options) -- This is an automated message from the Apache Git Service. To r

[PR] KAFKA-18791 Set default commit to PR title and description [2/n] [kafka]

2025-02-19 Thread via GitHub
mumrah opened a new pull request, #18967: URL: https://github.com/apache/kafka/pull/18967 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mai

Re: [PR] MINOR: Add a separate page for zk2kraft.html [kafka]

2025-02-19 Thread via GitHub
mingdaoy commented on code in PR #18961: URL: https://github.com/apache/kafka/pull/18961#discussion_r1961903913 ## docs/upgrade.html: ## @@ -45,10 +45,8 @@ Notable changes in 4 https://cwiki.apache.org/confluence/display/KAFKA/KIP-896%3A+Remove+old+client+protocol+A

[PR] Feb 19 test 2 [kafka-merge-queue-sandbox]

2025-02-19 Thread via GitHub
mumrah opened a new pull request, #60: URL: https://github.com/apache/kafka-merge-queue-sandbox/pull/60 Hopefully we see this as the commit message Reviewers: David Arthur -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[jira] [Created] (KAFKA-18831) Document the behavior changes of adjusting logger level after migrating to log4j2

2025-02-19 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-18831: -- Summary: Document the behavior changes of adjusting logger level after migrating to log4j2 Key: KAFKA-18831 URL: https://issues.apache.org/jira/browse/KAFKA-18831

Re: [PR] MINOR: Add a separate page for zk2kraft.html [kafka]

2025-02-19 Thread via GitHub
chia7712 commented on PR #18961: URL: https://github.com/apache/kafka/pull/18961#issuecomment-2668975804 > Would we want to do the same with this? Do you mean the docs should be moved from 4.0 branch to 3.9 branch? If yes, we have to update the kafka-site too as 3.9.0 docs is on board

[jira] [Commented] (KAFKA-18831) Document the behavior changes of adjusting logger level after migrating to log4j2

2025-02-19 Thread TengYao Chi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17928457#comment-17928457 ] TengYao Chi commented on KAFKA-18831: - I will file a patch to add this to the 4.0 no

[jira] [Assigned] (KAFKA-18831) Document the behavior changes of adjusting logger level after migrating to log4j2

2025-02-19 Thread TengYao Chi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18831?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] TengYao Chi reassigned KAFKA-18831: --- Assignee: TengYao Chi (was: Chia-Ping Tsai) > Document the behavior changes of adjusting l

[PR] KAFKA-18808: add test to ensure the name= is not equal to default quota [kafka]

2025-02-19 Thread via GitHub
Rancho-7 opened a new pull request, #18966: URL: https://github.com/apache/kafka/pull/18966 jira: https://issues.apache.org/jira/browse/KAFKA-18808 As title. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test co

Re: [PR] MINOR: Add a separate page for zk2kraft.html [kafka]

2025-02-19 Thread via GitHub
mingdaoy commented on code in PR #18961: URL: https://github.com/apache/kafka/pull/18961#discussion_r1961963740 ## docs/zk2kraft.html: ## @@ -148,7 +145,7 @@ Removal Zookeeper configs -Removal metrics +Removal Zookeeper Metrics Review Comme

[jira] [Commented] (KAFKA-18831) Migrating to log4j2 introduce behavior changes of adjusting level dynamically

2025-02-19 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17928483#comment-17928483 ] Chia-Ping Tsai commented on KAFKA-18831: [~frankvicky] could you please file a P

[PR] MIINOR: Remove redundant quorum parameter from *AdminIntegrationTest classes [kafka]

2025-02-19 Thread via GitHub
ijuma opened a new pull request, #18965: URL: https://github.com/apache/kafka/pull/18965 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrade not

Re: [PR] MINOR: Add a separate page for zk2kraft.html [kafka]

2025-02-19 Thread via GitHub
mingdaoy commented on code in PR #18961: URL: https://github.com/apache/kafka/pull/18961#discussion_r1961961956 ## docs/zk2kraft.html: ## @@ -15,14 +15,11 @@ limitations under the License. --> - - - - + + + -Significant Cha

[jira] [Commented] (KAFKA-18831) Document the behavior changes of adjusting logger level after migrating to log4j2

2025-02-19 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17928480#comment-17928480 ] Chia-Ping Tsai commented on KAFKA-18831: After reconsidering the design and revi

Re: [PR] MINOR: Add a separate page for zk2kraft.html [kafka]

2025-02-19 Thread via GitHub
mingdaoy commented on code in PR #18961: URL: https://github.com/apache/kafka/pull/18961#discussion_r1961963740 ## docs/zk2kraft.html: ## @@ -148,7 +145,7 @@ Removal Zookeeper configs -Removal metrics +Removal Zookeeper Metrics Review Comme

[jira] [Updated] (KAFKA-18831) Migrating to log4j2 introduce behavior changes of adjusting level dynamically

2025-02-19 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18831?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-18831: --- Issue Type: Bug (was: Improvement) > Migrating to log4j2 introduce behavior changes of adju

Re: [PR] MINOR: Add a separate page for zk2kraft.html [kafka]

2025-02-19 Thread via GitHub
ijuma commented on PR #18961: URL: https://github.com/apache/kafka/pull/18961#issuecomment-2669081569 > Do you mean the docs should be moved from 4.0 branch to 3.9 branch? If yes, we have to update the kafka-site too as 3.9.0 docs is on board already. Yeah, I was thinking that we woul

Re: [PR] KAFKA-18829: Added check before converting to IMPLICIT mode [kafka]

2025-02-19 Thread via GitHub
AndrewJSchofield merged PR #18964: URL: https://github.com/apache/kafka/pull/18964 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafk

[PR] MINOR: Rearrange configs in GroupCoordinatorConfigs [kafka]

2025-02-19 Thread via GitHub
dajac opened a new pull request, #18970: URL: https://github.com/apache/kafka/pull/18970 I was looking into GroupCoordinatorConfigs to review configurations that we will ship with Apache Kafka 4.0. I found out that it was pretty disorganised. This patch cleans up the format and re-groups th

[jira] [Commented] (KAFKA-18834) Fix LoggingResourceTest#testSetLevelDefaultScope

2025-02-19 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17928510#comment-17928510 ] Chia-Ping Tsai commented on KAFKA-18834: {code:java} Gradle Test Run :connect:r

[jira] [Created] (KAFKA-18834) Fix LoggingResourceTest#testSetLevelDefaultScope

2025-02-19 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-18834: -- Summary: Fix LoggingResourceTest#testSetLevelDefaultScope Key: KAFKA-18834 URL: https://issues.apache.org/jira/browse/KAFKA-18834 Project: Kafka Issue Ty

[jira] [Commented] (KAFKA-18833) Infinite loop on authenticcation error with AWS MSK AIM

2025-02-19 Thread Greg Harris (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17928507#comment-17928507 ] Greg Harris commented on KAFKA-18833: - Hi [~sergeykad] Thanks for the ticket! Unfor

[jira] [Resolved] (KAFKA-18833) Infinite loop on authenticcation error with AWS MSK AIM

2025-02-19 Thread Greg Harris (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Harris resolved KAFKA-18833. - Resolution: Invalid > Infinite loop on authenticcation error with AWS MSK AIM >

Re: [PR] MINOR: Update upgrade notes for 4.0.0 [kafka]

2025-02-19 Thread via GitHub
ijuma merged PR #18960: URL: https://github.com/apache/kafka/pull/18960 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

Re: [PR] MINOR: Fix incorrect return value from upgradeFeatures [kafka]

2025-02-19 Thread via GitHub
cmccabe merged PR #18958: URL: https://github.com/apache/kafka/pull/18958 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

Re: [PR] KAFKA-18561: Remove withKip853Rpc and replace it with withRaftProtocol [kafka]

2025-02-19 Thread via GitHub
ahuang98 commented on PR #18600: URL: https://github.com/apache/kafka/pull/18600#issuecomment-2669365217 > the easiest way is to test all protocols since the key difference between these protocols is support re-config or not. WDYT? I don't disagree it would be easy/fine to test all

Re: [PR] KAFKA-18561: Remove withKip853Rpc and replace it with withRaftProtocol [kafka]

2025-02-19 Thread via GitHub
ahuang98 commented on PR #18600: URL: https://github.com/apache/kafka/pull/18600#issuecomment-2669367334 Perhaps we can leave my suggestions in https://github.com/apache/kafka/pull/18600#pullrequestreview-2587264814 as out of scope - I'll give another review today and see if @jsancio has ti

Re: [PR] MINOR: Move the ELR default version to 4.1 [kafka]

2025-02-19 Thread via GitHub
cmccabe commented on PR #18954: URL: https://github.com/apache/kafka/pull/18954#issuecomment-2669387382 @dajac I commented that this is probably not the right approach. We probably need some kind of custom logic for what you are trying to do since the framework treats the associated MV of

Re: [PR] MINOR: Add a separate page for zk2kraft.html [kafka]

2025-02-19 Thread via GitHub
ijuma commented on PR #18961: URL: https://github.com/apache/kafka/pull/18961#issuecomment-2668763269 I was thinking that this information is related to the migration from zk to kraft more so than the upgrade to 4.0. We removed the zk to kraft migration docs from trunk and instead, link to

Re: [PR] MINOR: Add a separate page for zk2kraft.html [kafka]

2025-02-19 Thread via GitHub
mingdaoy commented on code in PR #18961: URL: https://github.com/apache/kafka/pull/18961#discussion_r1961901627 ## docs/toc.html: ## @@ -27,6 +27,9 @@ 1.3 Quick Start 1.4 Ecosystem 1.5 Upgrading + +

Re: [PR] KIP-966 part 1 release doc [kafka]

2025-02-19 Thread via GitHub
cmccabe commented on code in PR #18898: URL: https://github.com/apache/kafka/pull/18898#discussion_r1962157974 ## docs/ops.html: ## @@ -4281,6 +4281,32 @@ 6.12 Eligible Leader Replicas + + Overview + + Starting from Apache Kafka 4.0, Eligible Leader Replicas (https://cwiki.ap

Re: [PR] MIINOR: Remove redundant quorum parameter from *AdminIntegrationTest classes [kafka]

2025-02-19 Thread via GitHub
lianetm commented on code in PR #18965: URL: https://github.com/apache/kafka/pull/18965#discussion_r1961868457 ## core/src/test/scala/integration/kafka/api/SaslSslAdminIntegrationTest.scala: ## @@ -131,10 +130,10 @@ class SaslSslAdminIntegrationTest extends BaseAdminIntegration

Re: [PR] KAFKA-18713: Fix left join bug by using DELETE_KEY_NO_PROPAGATE [kafka]

2025-02-19 Thread via GitHub
nilmadhab commented on PR #18887: URL: https://github.com/apache/kafka/pull/18887#issuecomment-2670380898 @mjsax it makes sense to me. 1. I can remove the` KTableKTableForeignKeyLeftJoinDistributedTest.java` in this MR. 2. I will check if I can reproduce the issue `KTableKTableFor

[jira] [Commented] (KAFKA-18836) Make ConsumerGroupMetadata an interface

2025-02-19 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17928643#comment-17928643 ] Matthias J. Sax commented on KAFKA-18836: - Sure. :)  > Make ConsumerGroupMetada

[jira] [Assigned] (KAFKA-18836) Make ConsumerGroupMetadata an interface

2025-02-19 Thread Ukpa Uchechi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ukpa Uchechi reassigned KAFKA-18836: Assignee: Ukpa Uchechi > Make ConsumerGroupMetadata an interface > --

Re: [PR] [WIP]KAFKA-18331: Migrating to log4j2 introduce behavior changes of adjusting level dynamically [kafka]

2025-02-19 Thread via GitHub
frankvicky commented on code in PR #18969: URL: https://github.com/apache/kafka/pull/18969#discussion_r1962907658 ## core/src/main/scala/kafka/utils/LoggingController.scala: ## @@ -112,24 +112,30 @@ private class Log4jCoreController extends LoggingControllerDelegate { val

[jira] [Commented] (KAFKA-18834) Fix LoggingResourceTest#testSetLevelDefaultScope

2025-02-19 Thread Mingdao Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17928553#comment-17928553 ] Mingdao Yang commented on KAFKA-18834: -- Hi Chia-Ping, I'd be interested in working

Re: [PR] Testing a PR with one commit [kafka]

2025-02-19 Thread via GitHub
mumrah closed pull request #18971: Testing a PR with one commit URL: https://github.com/apache/kafka/pull/18971 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] KAFKA-18791 Set default commit to PR title and description [2/n] [kafka]

2025-02-19 Thread via GitHub
mumrah commented on PR #18967: URL: https://github.com/apache/kafka/pull/18967#issuecomment-2669615504 Here is a PR with one commit: https://github.com/user-attachments/assets/02bb13d3-ef33-44c4-a0fe-c0f6ba6cdfd3"; /> And one with multiple commits: https://github.com/use

[PR] Test another PR with multiple commits [kafka]

2025-02-19 Thread via GitHub
mumrah opened a new pull request, #18973: URL: https://github.com/apache/kafka/pull/18973 Hopefully we see this message instead of the individual commits in a list. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[jira] [Updated] (KAFKA-18835) Remove redundant kraft quorum param from consumer integration tests

2025-02-19 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lianet Magrans updated KAFKA-18835: --- Component/s: consumer > Remove redundant kraft quorum param from consumer integration tests

[PR] KAFKA-18813: ConsumerGroupHeartbeat API and ConsumerGroupDescribe API must check topic describe [kafka]

2025-02-19 Thread via GitHub
dongnuo123 opened a new pull request, #18974: URL: https://github.com/apache/kafka/pull/18974 This patch filters out the topic describe unauthorized topics from the ConsumerGroupHeartbeat and ConsumerGroupDescribe response. ### Committer Checklist (excluded from commit message) - [

Re: [PR] MINOR: fix Kafka Streams "smoke test" pass criteria [kafka]

2025-02-19 Thread via GitHub
mjsax merged PR #18835: URL: https://github.com/apache/kafka/pull/18835 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

Re: [PR] KAFKA-18332: fix ClassDataAbstractionCoupling problem in KafkaRaftClientTest(1/2) [kafka]

2025-02-19 Thread via GitHub
leaf-soba commented on PR #18926: URL: https://github.com/apache/kafka/pull/18926#issuecomment-2670367999 Hi @ijuma, @chia7712, @gongxuanzhang, could you please take a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[jira] [Comment Edited] (KAFKA-18836) Make ConsumerGroupMetadata an interface

2025-02-19 Thread Ukpa Uchechi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17928629#comment-17928629 ] Ukpa Uchechi edited comment on KAFKA-18836 at 2/20/25 3:30 AM: ---

[jira] [Commented] (KAFKA-18836) Make ConsumerGroupMetadata an interface

2025-02-19 Thread Ukpa Uchechi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17928629#comment-17928629 ] Ukpa Uchechi commented on KAFKA-18836: -- Hi, @Matthias, can I pick this up? > Make

[jira] [Comment Edited] (KAFKA-18836) Make ConsumerGroupMetadata an interface

2025-02-19 Thread Ukpa Uchechi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17928629#comment-17928629 ] Ukpa Uchechi edited comment on KAFKA-18836 at 2/20/25 3:29 AM: ---

Re: [PR] KAFKA-10462: Add ability to pass headers to ProducerPerformance. [kafka]

2025-02-19 Thread via GitHub
github-actions[bot] commented on PR #17462: URL: https://github.com/apache/kafka/pull/17462#issuecomment-2670383789 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to

Re: [PR] KAFKA-17981:add Integration test for ConfigCommand to add config `key=[val1,val2]` [kafka]

2025-02-19 Thread via GitHub
github-actions[bot] commented on PR #17771: URL: https://github.com/apache/kafka/pull/17771#issuecomment-2670383859 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please leave a comment asking for a review. If the P

Re: [PR] [DO NOT MERGE] convert aggregate API to ProcessorSupplier#stores method [kafka]

2025-02-19 Thread via GitHub
github-actions[bot] commented on PR #17833: URL: https://github.com/apache/kafka/pull/17833#issuecomment-2670383936 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please leave a comment asking for a review. If the P

Re: [PR] KAFKA-10462: Add ability to pass headers to ProducerPerformance. [kafka]

2025-02-19 Thread via GitHub
github-actions[bot] closed pull request #17462: KAFKA-10462: Add ability to pass headers to ProducerPerformance. URL: https://github.com/apache/kafka/pull/17462 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

  1   2   >