nilmadhab commented on PR #18887:
URL: https://github.com/apache/kafka/pull/18887#issuecomment-2670380898
@mjsax it makes sense to me.
1. I can remove the` KTableKTableForeignKeyLeftJoinDistributedTest.java` in
this MR.
2. I will check if I can reproduce the issue
`KTableKTableFor
[
https://issues.apache.org/jira/browse/KAFKA-18836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17928643#comment-17928643
]
Matthias J. Sax commented on KAFKA-18836:
-
Sure. :)
> Make ConsumerGroupMetada
[
https://issues.apache.org/jira/browse/KAFKA-18836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ukpa Uchechi reassigned KAFKA-18836:
Assignee: Ukpa Uchechi
> Make ConsumerGroupMetadata an interface
> --
frankvicky commented on code in PR #18969:
URL: https://github.com/apache/kafka/pull/18969#discussion_r1962907658
##
core/src/main/scala/kafka/utils/LoggingController.scala:
##
@@ -112,24 +112,30 @@ private class Log4jCoreController extends
LoggingControllerDelegate {
val
[
https://issues.apache.org/jira/browse/KAFKA-18834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17928553#comment-17928553
]
Mingdao Yang commented on KAFKA-18834:
--
Hi Chia-Ping, I'd be interested in working
mumrah closed pull request #18971: Testing a PR with one commit
URL: https://github.com/apache/kafka/pull/18971
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
mumrah commented on PR #18967:
URL: https://github.com/apache/kafka/pull/18967#issuecomment-2669615504
Here is a PR with one commit:
https://github.com/user-attachments/assets/02bb13d3-ef33-44c4-a0fe-c0f6ba6cdfd3";
/>
And one with multiple commits:
https://github.com/use
mumrah opened a new pull request, #18973:
URL: https://github.com/apache/kafka/pull/18973
Hopefully we see this message instead of the individual commits in a list.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
U
[
https://issues.apache.org/jira/browse/KAFKA-18835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lianet Magrans updated KAFKA-18835:
---
Component/s: consumer
> Remove redundant kraft quorum param from consumer integration tests
dongnuo123 opened a new pull request, #18974:
URL: https://github.com/apache/kafka/pull/18974
This patch filters out the topic describe unauthorized topics from the
ConsumerGroupHeartbeat and ConsumerGroupDescribe response.
### Committer Checklist (excluded from commit message)
- [
mjsax merged PR #18835:
URL: https://github.com/apache/kafka/pull/18835
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
leaf-soba commented on PR #18926:
URL: https://github.com/apache/kafka/pull/18926#issuecomment-2670367999
Hi @ijuma, @chia7712, @gongxuanzhang, could you please take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
[
https://issues.apache.org/jira/browse/KAFKA-18836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17928629#comment-17928629
]
Ukpa Uchechi edited comment on KAFKA-18836 at 2/20/25 3:30 AM:
---
[
https://issues.apache.org/jira/browse/KAFKA-18836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17928629#comment-17928629
]
Ukpa Uchechi commented on KAFKA-18836:
--
Hi, @Matthias, can I pick this up?
> Make
[
https://issues.apache.org/jira/browse/KAFKA-18836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17928629#comment-17928629
]
Ukpa Uchechi edited comment on KAFKA-18836 at 2/20/25 3:29 AM:
---
github-actions[bot] commented on PR #17462:
URL: https://github.com/apache/kafka/pull/17462#issuecomment-2670383789
This PR has been closed since it has not had any activity in 120 days. If
you feel like this
was a mistake, or you would like to continue working on it, please feel free
to
github-actions[bot] commented on PR #17771:
URL: https://github.com/apache/kafka/pull/17771#issuecomment-2670383859
This PR is being marked as stale since it has not had any activity in 90
days. If you
would like to keep this PR alive, please leave a comment asking for a
review. If the P
github-actions[bot] commented on PR #17833:
URL: https://github.com/apache/kafka/pull/17833#issuecomment-2670383936
This PR is being marked as stale since it has not had any activity in 90
days. If you
would like to keep this PR alive, please leave a comment asking for a
review. If the P
github-actions[bot] closed pull request #17462: KAFKA-10462: Add ability to
pass headers to ProducerPerformance.
URL: https://github.com/apache/kafka/pull/17462
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
mumrah merged PR #18967:
URL: https://github.com/apache/kafka/pull/18967
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.o
mingdaoy opened a new pull request, #18972:
URL: https://github.com/apache/kafka/pull/18972
https://issues.apache.org/jira/browse/KAFKA-18834
```
./gradlew cleanTest connect:runtime:test --tests
LoggersTest.testSetLevelWithValidRootLoggerNames --tests
LoggingResourceTest.testSetLe
mjsax commented on code in PR #18877:
URL: https://github.com/apache/kafka/pull/18877#discussion_r1962363168
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/SinkNode.java:
##
@@ -56,18 +56,19 @@ public void addChild(final ProcessorNode
child) {
th
lianetm merged PR #18965:
URL: https://github.com/apache/kafka/pull/18965
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
CalvinConfluent commented on code in PR #18952:
URL: https://github.com/apache/kafka/pull/18952#discussion_r1962165856
##
tests/kafkatest/tests/client/truncation_test.py:
##
@@ -112,7 +117,10 @@ def none_consumed(this, consumer):
pre_truncation_pos = consumer.current_
ijuma commented on PR #18961:
URL: https://github.com/apache/kafka/pull/18961#issuecomment-2669547889
I merged a change to `upgrade.html`, it would be good to resolve the
conflicts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
[
https://issues.apache.org/jira/browse/KAFKA-18791?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Arthur resolved KAFKA-18791.
--
Resolution: Fixed
> Set default commit message to PR title + body
> --
Lianet Magrans created KAFKA-18835:
--
Summary: Remove redundant kraft quorum param from consumer
integration tests
Key: KAFKA-18835
URL: https://issues.apache.org/jira/browse/KAFKA-18835
Project: Kafk
chia7712 commented on code in PR #18972:
URL: https://github.com/apache/kafka/pull/18972#discussion_r1962485553
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/rest/resources/LoggingResourceTest.java:
##
@@ -113,7 +113,7 @@ public void setLevelWithInvalidArgTes
[
https://issues.apache.org/jira/browse/KAFKA-17420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17928582#comment-17928582
]
Matthias J. Sax commented on KAFKA-17420:
-
Just stumbled across this ticket. Loo
mjsax commented on PR #15607:
URL: https://github.com/apache/kafka/pull/15607#issuecomment-2670307552
@AyoubOm -- I am finally spending time on this. I am still muling over the
problem etc... Not sure if you are still interested to contribute a fix? If
not, also ok with me, and I can submit
mjsax commented on PR #15607:
URL: https://github.com/apache/kafka/pull/15607#issuecomment-2670309222
Btw, there is also https://github.com/apache/kafka/pull/18887 which fixes
something similar... We need to coordinate the two PRs.
--
This is an automated message from the Apache Git Servi
frankvicky commented on PR #18961:
URL: https://github.com/apache/kafka/pull/18961#issuecomment-2670312682
In order to the future section of `Kraft related-features`, I have slightly
modified the content of `zk2kraft`:
![Screenshot from 2025-02-20
10-27-52](https://github.com/user-attach
m1a2st commented on code in PR #18961:
URL: https://github.com/apache/kafka/pull/18961#discussion_r1962771254
##
docs/zk2kraft.html:
##
@@ -15,14 +15,17 @@
limitations under the License.
-->
-
-
-
-
+
+
+
-Significant Chang
mjsax commented on PR #18887:
URL: https://github.com/apache/kafka/pull/18887#issuecomment-2670317669
@nilmadhab -- I am actively working on my side to dig into FK join to
refresh my memory and to fully understand the problem and fix, and will cycle
back soon.
One thing I noticed is,
mumrah closed pull request #18973: Test another PR with multiple commits
URL: https://github.com/apache/kafka/pull/18973
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsu
mjsax merged PR #18877:
URL: https://github.com/apache/kafka/pull/18877
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
bbejeck commented on code in PR #18673:
URL: https://github.com/apache/kafka/pull/18673#discussion_r1962348788
##
docs/ops.html:
##
@@ -2888,6 +2898,21 @@
Review Comment:
```suggestion
The fraction of time the thread spends performing punctuating
actions on acti
[
https://issues.apache.org/jira/browse/KAFKA-18835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17928599#comment-17928599
]
Lianet Magrans commented on KAFKA-18835:
It's a dup indeed, I wasn't aware of th
[
https://issues.apache.org/jira/browse/KAFKA-18835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lianet Magrans resolved KAFKA-18835.
Resolution: Duplicate
> Remove redundant kraft quorum param from consumer integration test
chia7712 commented on PR #18961:
URL: https://github.com/apache/kafka/pull/18961#issuecomment-2670280840
> Create a page with a title: "Differences between kraft mode and zk mode".
This page exists in trunk/4.0 and describes the differences between both. This
is useful for anyone that is fa
[
https://issues.apache.org/jira/browse/KAFKA-18579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kaushik Raina resolved KAFKA-18579.
---
Resolution: Fixed
> Add TransactionAbortableException instruction in docs
>
jsancio commented on code in PR #18852:
URL: https://github.com/apache/kafka/pull/18852#discussion_r1960729769
##
core/src/main/scala/kafka/log/UnifiedLog.scala:
##
@@ -1159,6 +1177,25 @@ class UnifiedLog(@volatile var logStartOffset: Long,
validBytesCount, lastOffsetOfFi
mumrah opened a new pull request, #18971:
URL: https://github.com/apache/kafka/pull/18971
Hopefully this shows as the commit message and not "commit one"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
junrao commented on code in PR #18852:
URL: https://github.com/apache/kafka/pull/18852#discussion_r1962522903
##
raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java:
##
@@ -1817,14 +1839,15 @@ private void appendAsFollower(
partitionState.updateState();
mingdaoy commented on PR #18972:
URL: https://github.com/apache/kafka/pull/18972#issuecomment-2669615037
Hi maintainers, could you please approve this workflow when you have a
chance? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please lo
Matthias J. Sax created KAFKA-18836:
---
Summary: Make ConsumerGroupMetadata an interface
Key: KAFKA-18836
URL: https://issues.apache.org/jira/browse/KAFKA-18836
Project: Kafka
Issue Type: Imp
mjsax commented on PR #15615:
URL: https://github.com/apache/kafka/pull/15615#issuecomment-2670306856
@AyoubOm -- I am finally spending time on this. I am still muling over the
problem etc... Not sure if you are still interested to contribute a fix? If
not, also ok with me, and I can submit
junrao commented on code in PR #18737:
URL: https://github.com/apache/kafka/pull/18737#discussion_r1962213079
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerMembershipManager.java:
##
@@ -123,8 +123,7 @@ public class ConsumerMembershipManager extend
ahuang98 commented on code in PR #18852:
URL: https://github.com/apache/kafka/pull/18852#discussion_r1962415345
##
core/src/main/scala/kafka/log/UnifiedLog.scala:
##
@@ -1086,63 +1088,79 @@ class UnifiedLog(@volatile var logStartOffset: Long,
var shallowOffsetOfMaxTimestamp
[
https://issues.apache.org/jira/browse/KAFKA-10902?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-10902:
--
Component/s: clients
> IllegalMonitorStateException in KafkaProducer.waitOnMetadata
>
[
https://issues.apache.org/jira/browse/KAFKA-18791?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai reassigned KAFKA-18791:
--
Assignee: David Arthur
> Set default commit message to PR title + body
>
frankvicky commented on code in PR #18737:
URL: https://github.com/apache/kafka/pull/18737#discussion_r1962729391
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerMembershipManager.java:
##
@@ -123,8 +123,7 @@ public class ConsumerMembershipManager ex
[
https://issues.apache.org/jira/browse/KAFKA-18791?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai updated KAFKA-18791:
---
Fix Version/s: 4.1.0
> Set default commit message to PR title + body
> -
[
https://issues.apache.org/jira/browse/KAFKA-18834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17928509#comment-17928509
]
Chia-Ping Tsai commented on KAFKA-18834:
`testSetLevelDefaultScope` should set t
[
https://issues.apache.org/jira/browse/KAFKA-18579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kaushik Raina updated KAFKA-18579:
--
Fix Version/s: 4.0.0
(was: 4.1.0)
> Add TransactionAbortableException i
[
https://issues.apache.org/jira/browse/KAFKA-18834?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mingdao Yang reassigned KAFKA-18834:
Assignee: Mingdao Yang (was: Chia-Ping Tsai)
> Fix LoggingResourceTest#testSetLevelDefau
chia7712 commented on PR #18972:
URL: https://github.com/apache/kafka/pull/18972#issuecomment-2669837799
Personally, I prefer to adjust the level for the testSetLevelDefaultScope.
Please see my comment on the jira
--
This is an automated message from the Apache Git Service.
To respond to
ahuang98 commented on code in PR #18852:
URL: https://github.com/apache/kafka/pull/18852#discussion_r1962425394
##
core/src/main/scala/kafka/log/UnifiedLog.scala:
##
@@ -1159,6 +1180,25 @@ class UnifiedLog(@volatile var logStartOffset: Long,
validBytesCount, lastOffsetOfF
mumrah commented on PR #18770:
URL: https://github.com/apache/kafka/pull/18770#issuecomment-2669850896
@chia7712 can you take another look at this one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
[
https://issues.apache.org/jira/browse/KAFKA-17420?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai resolved KAFKA-17420.
Resolution: Duplicate
agree to close this ticket. loop it 500times on my local. all pass
mjsax commented on code in PR #18877:
URL: https://github.com/apache/kafka/pull/18877#discussion_r1962940507
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/SinkNode.java:
##
@@ -56,18 +56,19 @@ public void addChild(final ProcessorNode
child) {
th
mjsax opened a new pull request, #18975:
URL: https://github.com/apache/kafka/pull/18975
Follow up to
https://github.com/apache/kafka/pull/18877#discussion_r1961407894
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
[
https://issues.apache.org/jira/browse/KAFKA-18820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17928662#comment-17928662
]
Vishal edited comment on KAFKA-18820 at 2/20/25 7:01 AM:
-
Hi [~c
[
https://issues.apache.org/jira/browse/KAFKA-18820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17928662#comment-17928662
]
Vishal commented on KAFKA-18820:
Hi [~chia7712] , you had helped with a similar issue la
mjsax commented on code in PR #18975:
URL: https://github.com/apache/kafka/pull/18975#discussion_r1962942277
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/WrappingNullableUtils.java:
##
@@ -62,25 +62,25 @@ private static Serde prepareSerde(final Serde
spe
ijuma commented on PR #18965:
URL: https://github.com/apache/kafka/pull/18965#issuecomment-2669452444
> We could remove the quorum, and just update the check for isShareGroupTest
here
I pushed a commit that tries to address this - it's a bit odd, but aligned
with the current mechanis
[
https://issues.apache.org/jira/browse/KAFKA-18822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai resolved KAFKA-18822.
Resolution: Duplicate
see KAFKA-18834
> Fail test LoggingResourceTest#testSetLevelDefault
chia7712 commented on PR #18972:
URL: https://github.com/apache/kafka/pull/18972#issuecomment-2669973567
Another way is to reset the log level in
`testSetLevelWithValidRootLoggerNames`. It changes "all" loggers, so it may
impact other tests too.
--
This is an automated message from the A
chia7712 commented on code in PR #18970:
URL: https://github.com/apache/kafka/pull/18970#discussion_r1962493256
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupCoordinatorConfigTest.java:
##
@@ -46,8 +46,8 @@
public class GroupCoordinatorConfigTest
[
https://issues.apache.org/jira/browse/KAFKA-18835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17928589#comment-17928589
]
黃竣陽 commented on KAFKA-18835:
-
Hello [~lianetm], It is a dulpicate of KAFKA-18695? Or should
[
https://issues.apache.org/jira/browse/KAFKA-16918?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai resolved KAFKA-16918.
Fix Version/s: 4.1.0
Resolution: Fixed
> TestUtils#assertFutureThrows should use fu
chia7712 merged PR #18891:
URL: https://github.com/apache/kafka/pull/18891
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
github-actions[bot] commented on PR #17891:
URL: https://github.com/apache/kafka/pull/17891#issuecomment-2670383960
This PR is being marked as stale since it has not had any activity in 90
days. If you
would like to keep this PR alive, please leave a comment asking for a
review. If the P
chirag-wadhwa5 opened a new pull request, #18976:
URL: https://github.com/apache/kafka/pull/18976
This PR contains the implementation of KafkaAdminClient and GroupCoordinator
for DeleteShareGroupOffsets RPC. This PR is a followup on
[this](https://github.com/apache/kafka/pull/18927).
adixitconfluent commented on code in PR #18864:
URL: https://github.com/apache/kafka/pull/18864#discussion_r1961201931
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/SimpleAssignor.java:
##
@@ -72,36 +77,178 @@ private GroupAssignment assignHomoge
lucasbru opened a new pull request, #18963:
URL: https://github.com/apache/kafka/pull/18963
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of testin
[
https://issues.apache.org/jira/browse/KAFKA-18829?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gunnar Morling updated KAFKA-18829:
---
Description:
I am getting the following exception when trying to acknowledge a message with
[
https://issues.apache.org/jira/browse/KAFKA-18829?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Schofield reassigned KAFKA-18829:
Assignee: Shivsundar R
> Can't use explicit ack when poll returns an empty batch
apoorvmittal10 commented on PR #18962:
URL: https://github.com/apache/kafka/pull/18962#issuecomment-2668125459
@smjn While you are fixing the group-count can you please also take at
following conversation and add the minor change in the PR. We shall correct the
KIP as well later.
--
This
[
https://issues.apache.org/jira/browse/KAFKA-18829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17928376#comment-17928376
]
Andrew Schofield commented on KAFKA-18829:
--
I expect the logic that figures out
Gunnar Morling created KAFKA-18829:
--
Summary: Can't use explicit ack when poll returns an empty batch
Key: KAFKA-18829
URL: https://issues.apache.org/jira/browse/KAFKA-18829
Project: Kafka
I
AndrewJSchofield commented on code in PR #18877:
URL: https://github.com/apache/kafka/pull/18877#discussion_r1961407894
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/SinkNode.java:
##
@@ -56,18 +56,19 @@ public void addChild(final ProcessorNode
child) {
[
https://issues.apache.org/jira/browse/KAFKA-18198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Schofield resolved KAFKA-18198.
--
Fix Version/s: 4.1.0
Resolution: Fixed
> Disallow piggyback acknowledgments on
AndrewJSchofield merged PR #18944:
URL: https://github.com/apache/kafka/pull/18944
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafk
AndrewJSchofield commented on code in PR #18939:
URL: https://github.com/apache/kafka/pull/18939#discussion_r1961464616
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ShareConsumeRequestManager.java:
##
@@ -851,59 +873,25 @@ private void handleShareAcknowle
mingdaoy commented on code in PR #18961:
URL: https://github.com/apache/kafka/pull/18961#discussion_r1960998479
##
docs/upgrade.html:
##
@@ -48,7 +48,6 @@ Notable changes in 4
Before updating your Kafka cluster which build on Zookeeper to
Kafka 4.0, you must unders
mingdaoy commented on code in PR #18961:
URL: https://github.com/apache/kafka/pull/18961#discussion_r1961512459
##
docs/upgrade.html:
##
@@ -45,10 +45,8 @@ Notable changes in 4
https://cwiki.apache.org/confluence/display/KAFKA/KIP-896%3A+Remove+old+client+protocol+A
ijuma commented on PR #18845:
URL: https://github.com/apache/kafka/pull/18845#issuecomment-2668661378
I will go ahead and merge this. If @junrao has any additional comments, I
will submit a separate PR to address those.
--
This is an automated message from the Apache Git Service.
To respo
[
https://issues.apache.org/jira/browse/KAFKA-18601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ismael Juma updated KAFKA-18601:
Description: 3.3.0 was the first KRaft release that was deemed
production-ready and also when KIP-
ijuma commented on code in PR #18960:
URL: https://github.com/apache/kafka/pull/18960#discussion_r1961774094
##
docs/upgrade.html:
##
@@ -29,25 +29,39 @@ Notable changes in 4
-Upgrading to 4.0.0 from any
version 0.8.x through 3.9.x
+Upg
ShivsundarR commented on code in PR #18939:
URL: https://github.com/apache/kafka/pull/18939#discussion_r1961579512
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ShareConsumeRequestManager.java:
##
@@ -851,59 +873,25 @@ private void handleShareAcknowledgeSu
ShivsundarR commented on code in PR #18939:
URL: https://github.com/apache/kafka/pull/18939#discussion_r1961580125
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ShareConsumeRequestManager.java:
##
@@ -97,6 +99,7 @@ public class ShareConsumeRequestManager i
ShivsundarR commented on code in PR #18964:
URL: https://github.com/apache/kafka/pull/18964#discussion_r1961771474
##
core/src/test/java/kafka/test/api/ShareConsumerTest.java:
##
@@ -688,6 +688,41 @@ public void testExplicitAcknowledgementCommitAsync()
throws InterruptedExcepti
ijuma commented on PR #18965:
URL: https://github.com/apache/kafka/pull/18965#issuecomment-2668857896
@lianetm Do you have cycles to review this mechanical PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
mumrah opened a new pull request, #59:
URL: https://github.com/apache/kafka-merge-queue-sandbox/pull/59
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsu
mumrah merged PR #59:
URL: https://github.com/apache/kafka-merge-queue-sandbox/pull/59
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@
AndrewJSchofield commented on code in PR #18964:
URL: https://github.com/apache/kafka/pull/18964#discussion_r1961700426
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ShareConsumerImpl.java:
##
@@ -1018,7 +1018,7 @@ private void
acknowledgeBatchIfImplicitA
mumrah commented on PR #18845:
URL: https://github.com/apache/kafka/pull/18845#issuecomment-2668703940
Thanks for pushing this over the line @ijuma. It's great to see these
cleanups and removals. "IBP" is all but a memory now :)
--
This is an automated message from the Apache Git Service.
ijuma merged PR #18845:
URL: https://github.com/apache/kafka/pull/18845
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
chia7712 commented on code in PR #18844:
URL: https://github.com/apache/kafka/pull/18844#discussion_r1961613921
##
docker/native/Dockerfile:
##
@@ -31,13 +33,23 @@ COPY native_command.sh native_command.sh
RUN mkdir $KAFKA_DIR; \
microdnf install wget; \
+if [ "$SKIP_
1 - 100 of 155 matches
Mail list logo
