[PR] KAFKA-16718 [1/n]: Added DeleteShareGroupOffsets request and response schema [kafka]

2025-02-17 Thread via GitHub
chirag-wadhwa5 opened a new pull request, #18927: URL: https://github.com/apache/kafka/pull/18927 This PR is the first in a set to include the delete share group offsets functionality. This PR adds the request and response schemas for DeleteShareGroupOffsets. Reference: [JIRA](https

Re: [PR] KAFKA-14484: Decouple UnifiedLog and RemoteLogManager [kafka]

2025-02-17 Thread via GitHub
kamalcph commented on code in PR #18460: URL: https://github.com/apache/kafka/pull/18460#discussion_r1958040680 ## core/src/main/scala/kafka/log/UnifiedLog.scala: ## @@ -1293,16 +1292,16 @@ class UnifiedLog(@volatile var logStartOffset: Long, } else { // We need

Re: [PR] KAFKA-18798: The replica placement policy used by `ReassignPartitionsCommand` is not aligned with kraft controller [kafka]

2025-02-17 Thread via GitHub
chia7712 commented on code in PR #18914: URL: https://github.com/apache/kafka/pull/18914#discussion_r1957858536 ## tools/src/main/java/org/apache/kafka/tools/reassign/ReassignPartitionsCommand.java: ## @@ -582,10 +593,29 @@ private static Map> calculateAssignment(Map> proposedA

Re: [PR] KAFKA-18712: Move Endpoint to server module [kafka]

2025-02-17 Thread via GitHub
TaiJuWu commented on PR #18803: URL: https://github.com/apache/kafka/pull/18803#issuecomment-2662494491 > @TaiJuWu could you please rebase code? Done. Thanks for review! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[PR] KAFKA-18629: ShareGroupDeleteState admin client impl. [kafka]

2025-02-17 Thread via GitHub
smjn opened a new pull request, #18928: URL: https://github.com/apache/kafka/pull/18928 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-18754: Allow `PlainSaslServer` to pass client info through the negotiated properties. [kafka]

2025-02-17 Thread via GitHub
bachmanity1 commented on PR #18828: URL: https://github.com/apache/kafka/pull/18828#issuecomment-2662899012 Test failures seem not be related. All failed tests are marked as flaky. Java 23 ``` Found 7 flaky test failures: FLAKY ⚠️ RequestQuotaTest > initializationError FL

Re: [PR] KAFKA-18767: Add client side config check for shareConsumer [kafka]

2025-02-17 Thread via GitHub
AndrewJSchofield commented on code in PR #18850: URL: https://github.com/apache/kafka/pull/18850#discussion_r1958006044 ## clients/src/main/java/org/apache/kafka/clients/consumer/GroupProtocol.java: ## @@ -23,7 +23,10 @@ public enum GroupProtocol { CLASSIC("CLASSIC"),

Re: [PR] KAFKA-14484: Decouple UnifiedLog and RemoteLogManager [kafka]

2025-02-17 Thread via GitHub
mimaison commented on code in PR #18460: URL: https://github.com/apache/kafka/pull/18460#discussion_r1957917126 ## storage/src/main/java/org/apache/kafka/storage/internals/log/AsyncOffsetReader.java: ## @@ -0,0 +1,47 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

[jira] [Resolved] (KAFKA-18603) Maintain batch ordering in clients as per fetchBatchSize in ShareAcknowledgeRequests.

2025-02-17 Thread Shivsundar R (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18603?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shivsundar R resolved KAFKA-18603. -- Resolution: Won't Fix The broker changes introduced here - https://issues.apache.org/jira/bro

[jira] [Created] (KAFKA-18811) Allow passing the Consumer Configs to the AdminClientProperties for VerifiableShareConsumers

2025-02-17 Thread Sanskar Jhajharia (Jira)
Sanskar Jhajharia created KAFKA-18811: - Summary: Allow passing the Consumer Configs to the AdminClientProperties for VerifiableShareConsumers Key: KAFKA-18811 URL: https://issues.apache.org/jira/browse/KAFKA-1

[jira] [Updated] (KAFKA-18811) Allow passing the Consumer Configs to the AdminClientProperties for VerifiableShareConsumers

2025-02-17 Thread Sanskar Jhajharia (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18811?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sanskar Jhajharia updated KAFKA-18811: -- Description: The VerifiableShareConsumer currently allows the users to specify the {{{

Re: [PR] KAFKA-14484: Decouple UnifiedLog and RemoteLogManager [kafka]

2025-02-17 Thread via GitHub
kamalcph commented on code in PR #18460: URL: https://github.com/apache/kafka/pull/18460#discussion_r1958037086 ## storage/src/main/java/org/apache/kafka/storage/internals/log/AsyncOffsetReader.java: ## @@ -0,0 +1,47 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

Re: [PR] DRAFT KAFKA-18692: Consider to unify KStreamImpl "repartitionRequired" with GraphNode "keyChangingOperation" [kafka]

2025-02-17 Thread via GitHub
appchemist commented on PR #18800: URL: https://github.com/apache/kafka/pull/18800#issuecomment-2662914881 @mjsax After reuse `InternalStreamsBuilder#getKeyChangingParentNode()`. Some Tests are failed. So, I'll looking for these failed tests I haven't had much time lately, so I hav

Re: [PR] KAFKA-18784: Fix ConsumerWithLegacyMessageFormatIntegrationTest [kafka]

2025-02-17 Thread via GitHub
chia7712 merged PR #18889: URL: https://github.com/apache/kafka/pull/18889 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[PR] MINOR: Align share group admin authz with consumer group [kafka]

2025-02-17 Thread via GitHub
AndrewJSchofield opened a new pull request, #18936: URL: https://github.com/apache/kafka/pull/18936 As the share group admin operations are being implemented, I have noticed that consumer group operations and share group operations do not have the same authorisation requirements. This is no

Re: [PR] KAFKA-18773: Migrate the log4j1 config to log4j 2 for native image and README (wip) [kafka]

2025-02-17 Thread via GitHub
chia7712 commented on PR #18872: URL: https://github.com/apache/kafka/pull/18872#issuecomment-2663825547 the failure may be related to https://github.com/apache/logging-log4j2/issues/1539 - I will test the 2.25.0-SNAPSHOT locally. -- This is an automated message from the Apache Git Servi

Re: [PR] KAFKA-18733: Updating share group record acks metric (2/N) [kafka]

2025-02-17 Thread via GitHub
AndrewJSchofield merged PR #18924: URL: https://github.com/apache/kafka/pull/18924 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafk

Re: [PR] KAFKA-18730: Add replaying streams group state from offset topic [kafka]

2025-02-17 Thread via GitHub
lucasbru commented on code in PR #18809: URL: https://github.com/apache/kafka/pull/18809#discussion_r1958383366 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/metrics/GroupCoordinatorMetricsShard.java: ## @@ -410,66 +372,4 @@ public void onShareGroupStateT

Re: [PR] [WIP] KAFKA-16717 [2/N]: Add AdminClient.alterShareGroupOffsets [kafka]

2025-02-17 Thread via GitHub
AndrewJSchofield commented on code in PR #18929: URL: https://github.com/apache/kafka/pull/18929#discussion_r1958604469 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -3272,7 +3272,36 @@ class KafkaApis(val requestChannel: RequestChannel, def handleAlterShareGro

[jira] [Created] (KAFKA-18814) Add support for client-side plugins

2025-02-17 Thread Mickael Maison (Jira)
Mickael Maison created KAFKA-18814: -- Summary: Add support for client-side plugins Key: KAFKA-18814 URL: https://issues.apache.org/jira/browse/KAFKA-18814 Project: Kafka Issue Type: Sub-task

Re: [PR] KAFKA-18784: Fix ConsumerWithLegacyMessageFormatIntegrationTest [kafka]

2025-02-17 Thread via GitHub
chia7712 commented on PR #18889: URL: https://github.com/apache/kafka/pull/18889#issuecomment-2663020019 cherry-pick to 4.0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Updated] (KAFKA-15995) Mechanism for plugins and connectors to register metrics

2025-02-17 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15995?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison updated KAFKA-15995: --- Issue Type: Task (was: New Feature) > Mechanism for plugins and connectors to register metr

[PR] [WIP] KAFKA-16717 [2/N]: Add AdminClient.alterShareGroupOffsets [kafka]

2025-02-17 Thread via GitHub
JimmyWang6 opened a new pull request, #18929: URL: https://github.com/apache/kafka/pull/18929 [KAFKA-16720](https://issues.apache.org/jira/browse/KAFKA-16720) aims to finish the AlterShareGroupOffsets RPC. ### Committer Checklist (excluded from commit message) - [ ] Verify design a

Re: [PR] KAFKA-18737: KafkaDockerWrapper setup functions fails due to storage format command [kafka]

2025-02-17 Thread via GitHub
frankvicky commented on code in PR #18844: URL: https://github.com/apache/kafka/pull/18844#discussion_r1958425032 ## core/src/test/scala/unit/kafka/docker/KafkaDockerWrapperTest.scala: ## @@ -133,7 +133,7 @@ class KafkaDockerWrapperTest { val configsPath = Paths.get("/path/

[jira] [Updated] (KAFKA-18812) Improve new consumer API errors upon background thread failures

2025-02-17 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18812?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lianet Magrans updated KAFKA-18812: --- Description: The new consumer background thread could fail to start, in which case it will

Re: [PR] KAFKA-18641: AsyncKafkaConsumer could lose records with auto offset commit [kafka]

2025-02-17 Thread via GitHub
frankvicky commented on PR #18737: URL: https://github.com/apache/kafka/pull/18737#issuecomment-2663522390 Hi @lianetm I have just updated the patch based on the latest comments. PTAL 🙇🏼 -- This is an automated message from the Apache Git Service. To respond to the message, please

[jira] [Updated] (KAFKA-18812) Improve new consumer API errors upon background thread failures

2025-02-17 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18812?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lianet Magrans updated KAFKA-18812: --- Description: The new consumer background thread could fail to start, in which case it will

[PR] KAFKA-17662: config.providers configuration missing from the docs [kafka]

2025-02-17 Thread via GitHub
m1a2st opened a new pull request, #18930: URL: https://github.com/apache/kafka/pull/18930 Jira: https://issues.apache.org/jira/browse/KAFKA-17662 add all properties doc contain the `config.providers` section. ### Committer Checklist (excluded from commit message) - [ ] Verify

Re: [PR] KAFKA-18737: KafkaDockerWrapper setup functions fails due to storage format command [kafka]

2025-02-17 Thread via GitHub
chia7712 commented on code in PR #18844: URL: https://github.com/apache/kafka/pull/18844#discussion_r1958415198 ## core/src/test/scala/unit/kafka/docker/KafkaDockerWrapperTest.scala: ## @@ -133,7 +133,7 @@ class KafkaDockerWrapperTest { val configsPath = Paths.get("/path/to

[jira] [Resolved] (KAFKA-18784) Fix ConsumerWithLegacyMessageFormatIntegrationTest

2025-02-17 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18784?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-18784. Resolution: Fixed trunk: https://github.com/apache/kafka/commit/2b6e868538490837e4bc18c17

Re: [PR] KAFKA-16718 [1/n]: Added DeleteShareGroupOffsets request and response schema [kafka]

2025-02-17 Thread via GitHub
AndrewJSchofield commented on code in PR #18927: URL: https://github.com/apache/kafka/pull/18927#discussion_r1958205103 ## clients/src/main/resources/common/message/DeleteShareGroupOffsetsRequest.json: ## @@ -0,0 +1,32 @@ +// Licensed to the Apache Software Foundation (ASF) unde

Re: [PR] KAFKA-18767: Add client side config check for shareConsumer [kafka]

2025-02-17 Thread via GitHub
AndrewJSchofield commented on code in PR #18850: URL: https://github.com/apache/kafka/pull/18850#discussion_r1958018001 ## clients/src/main/java/org/apache/kafka/clients/consumer/ShareConsumerConfig.java: ## @@ -0,0 +1,71 @@ +/* + * Licensed to the Apache Software Foundation (AS

Re: [PR] KAFKA-18730: Add replaying streams group state from offset topic [kafka]

2025-02-17 Thread via GitHub
lucasbru commented on code in PR #18809: URL: https://github.com/apache/kafka/pull/18809#discussion_r1958385111 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/streams/StreamsGroupBuilder.java: ## @@ -0,0 +1,116 @@ +/* + * Licensed to the Apache Software Fo

[PR] MINOR: Add verify_license tool [kafka]

2025-02-17 Thread via GitHub
dajac opened a new pull request, #18931: URL: https://github.com/apache/kafka/pull/18931 This patch adds the verify_license.py tool. It compares the libraries shipped within the tarball to the LICENSE file, and vice versa, to ensure that they are aligned. It also slightly update the format

Re: [PR] KAFKA-18023: Enforcing Explicit Naming for Kafka Streams Internal Topics [kafka]

2025-02-17 Thread via GitHub
lucasbru commented on code in PR #18233: URL: https://github.com/apache/kafka/pull/18233#discussion_r1958184392 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopologyBuilder.java: ## @@ -2289,4 +2298,45 @@ public WrappedProcessorSupplier wra

[jira] [Commented] (KAFKA-18812) Improve new consumer API errors upon background thread failures

2025-02-17 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17927804#comment-17927804 ] Lianet Magrans commented on KAFKA-18812: Sure, thanks! > Improve new consumer A

Re: [PR] KAFKA-18641: AsyncKafkaConsumer could lose records with auto offset commit [kafka]

2025-02-17 Thread via GitHub
lianetm commented on code in PR #18737: URL: https://github.com/apache/kafka/pull/18737#discussion_r1958289291 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java: ## @@ -748,9 +748,14 @@ public ConsumerRecords poll(final Duration timeout

Re: [PR] [WIP] KAFKA-18562: standardize election/fetch timeout between Unattached and Followers [kafka]

2025-02-17 Thread via GitHub
frankvicky commented on code in PR #18921: URL: https://github.com/apache/kafka/pull/18921#discussion_r1958195310 ## raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java: ## @@ -3279,7 +3279,7 @@ private long pollUnattachedAsVoter(UnattachedState state, long currentTim

Re: [PR] KAFKA-18730: Add replaying streams group state from offset topic [kafka]

2025-02-17 Thread via GitHub
lucasbru commented on code in PR #18809: URL: https://github.com/apache/kafka/pull/18809#discussion_r1958380749 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/metrics/GroupCoordinatorMetricsShard.java: ## @@ -82,7 +82,7 @@ public TimelineGaugeCounter(Timel

[jira] [Commented] (KAFKA-16320) CreateTopics, DeleteTopics and CreatePartitions differences between Zookeeper and KRaft

2025-02-17 Thread Emanuele Sabellico (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17927789#comment-17927789 ] Emanuele Sabellico commented on KAFKA-16320: It seems it's not desired to br

[jira] [Resolved] (KAFKA-16320) CreateTopics, DeleteTopics and CreatePartitions differences between Zookeeper and KRaft

2025-02-17 Thread Emanuele Sabellico (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Emanuele Sabellico resolved KAFKA-16320. Resolution: Not A Problem > CreateTopics, DeleteTopics and CreatePartitions differ

Re: [PR] KAFKA-18757: Create full-function SimpleAssignor to match KIP-932 description [kafka]

2025-02-17 Thread via GitHub
AndrewJSchofield commented on code in PR #18864: URL: https://github.com/apache/kafka/pull/18864#discussion_r1958257137 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/SimpleAssignor.java: ## @@ -72,36 +77,178 @@ private GroupAssignment assignHomog

Re: [PR] KAFKA-18733: Updating share group record acks metric (2/N) [kafka]

2025-02-17 Thread via GitHub
AndrewJSchofield commented on code in PR #18924: URL: https://github.com/apache/kafka/pull/18924#discussion_r1958394081 ## core/src/test/java/kafka/server/share/SharePartitionManagerTest.java: ## @@ -1587,6 +1587,57 @@ public void testAcknowledgeMultiplePartition() throws Excep

Re: [PR] KAFKA-18730: Add replaying streams group state from offset topic [kafka]

2025-02-17 Thread via GitHub
lucasbru commented on code in PR #18809: URL: https://github.com/apache/kafka/pull/18809#discussion_r1958395986 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -760,6 +859,43 @@ ConsumerGroup getOrMaybeCreatePersistedConsume

Re: [PR] KAFKA-18730: Add replaying streams group state from offset topic [kafka]

2025-02-17 Thread via GitHub
lucasbru commented on PR #18809: URL: https://github.com/apache/kafka/pull/18809#issuecomment-2663403671 > I noticed that the tests in the group coordinator do not use the following tag > > ```java > @ExtendWith(MockitoExtension.class) > public class XTest { > ``` >

Re: [PR] KAFKA-14484: Decouple UnifiedLog and RemoteLogManager [kafka]

2025-02-17 Thread via GitHub
mimaison commented on code in PR #18460: URL: https://github.com/apache/kafka/pull/18460#discussion_r1958428791 ## core/src/main/scala/kafka/log/UnifiedLog.scala: ## @@ -1293,16 +1292,16 @@ class UnifiedLog(@volatile var logStartOffset: Long, } else { // We need

[jira] [Created] (KAFKA-18812) Improving new consumer API errors upon background thread failures

2025-02-17 Thread Lianet Magrans (Jira)
Lianet Magrans created KAFKA-18812: -- Summary: Improving new consumer API errors upon background thread failures Key: KAFKA-18812 URL: https://issues.apache.org/jira/browse/KAFKA-18812 Project: Kafka

[jira] [Commented] (KAFKA-18812) Improve new consumer API errors upon background thread failures

2025-02-17 Thread TengYao Chi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17927802#comment-17927802 ] TengYao Chi commented on KAFKA-18812: - Hi [~lianetm]  May I take over this issue?

[jira] [Updated] (KAFKA-18812) Improve new consumer API errors upon background thread failures

2025-02-17 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18812?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lianet Magrans updated KAFKA-18812: --- Description: The new consumer background thread could fail to start, in which case will log

Re: [PR] KAFKA-16718 [1/n]: Added DeleteShareGroupOffsets request and response schema [kafka]

2025-02-17 Thread via GitHub
AndrewJSchofield commented on code in PR #18927: URL: https://github.com/apache/kafka/pull/18927#discussion_r1958430956 ## server/src/main/java/org/apache/kafka/network/RequestConvertToJson.java: ## @@ -465,6 +469,8 @@ public static JsonNode request(AbstractRequest request) {

[jira] [Assigned] (KAFKA-18812) Improve new consumer API errors upon background thread failures

2025-02-17 Thread TengYao Chi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18812?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] TengYao Chi reassigned KAFKA-18812: --- Assignee: TengYao Chi > Improve new consumer API errors upon background thread failures > -

Re: [PR] KAFKA-18801 Remove ClusterGenerator and revise docs of ClusterTemplate [kafka]

2025-02-17 Thread via GitHub
JimmyWang6 commented on PR #18907: URL: https://github.com/apache/kafka/pull/18907#issuecomment-2663296809 @chia7712 @mumrah I have optimize the comments, PTAL. :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[PR] KAFKA-18807; Fix thread idle ratio metric [kafka]

2025-02-17 Thread via GitHub
squah-confluent opened a new pull request, #18934: URL: https://github.com/apache/kafka/pull/18934 When group.coordinator.threads is greater than 1, we lose track of thread idle time because of integer arithmetic. Use doubles instead. ### Committer Checklist (excluded from commit me

Re: [PR] KAFKA-14484: Decouple UnifiedLog and RemoteLogManager [kafka]

2025-02-17 Thread via GitHub
kamalcph commented on code in PR #18460: URL: https://github.com/apache/kafka/pull/18460#discussion_r1958517947 ## core/src/main/scala/kafka/log/UnifiedLog.scala: ## @@ -1293,16 +1292,16 @@ class UnifiedLog(@volatile var logStartOffset: Long, } else { // We need

Re: [PR] KAFKA-18807; Fix thread idle ratio metric [kafka]

2025-02-17 Thread via GitHub
squah-confluent commented on code in PR #18934: URL: https://github.com/apache/kafka/pull/18934#discussion_r1958519491 ## coordinator-common/src/main/java/org/apache/kafka/coordinator/common/runtime/CoordinatorRuntimeMetrics.java: ## @@ -71,7 +71,7 @@ public interface Coordinato

Re: [PR] KAFKA-18807; Fix thread idle ratio metric [kafka]

2025-02-17 Thread via GitHub
dajac commented on code in PR #18934: URL: https://github.com/apache/kafka/pull/18934#discussion_r1958527263 ## coordinator-common/src/main/java/org/apache/kafka/coordinator/common/runtime/CoordinatorRuntimeMetrics.java: ## @@ -71,7 +71,7 @@ public interface CoordinatorRuntimeMe

[jira] [Created] (KAFKA-18813) ConsumerGroupHeartbeat API and ConsumerGroupDescribe API must check topic describe

2025-02-17 Thread David Jacot (Jira)
David Jacot created KAFKA-18813: --- Summary: ConsumerGroupHeartbeat API and ConsumerGroupDescribe API must check topic describe Key: KAFKA-18813 URL: https://issues.apache.org/jira/browse/KAFKA-18813 Proj

[jira] [Resolved] (KAFKA-18815) Add support to Connect

2025-02-17 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18815?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison resolved KAFKA-18815. Fix Version/s: 4.1.0 Resolution: Fixed > Add support to Connect > -

[jira] [Resolved] (KAFKA-18814) Add support for client-side plugins

2025-02-17 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18814?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison resolved KAFKA-18814. Resolution: Fixed > Add support for client-side plugins >

[jira] [Created] (KAFKA-18815) Add support to Connect

2025-02-17 Thread Mickael Maison (Jira)
Mickael Maison created KAFKA-18815: -- Summary: Add support to Connect Key: KAFKA-18815 URL: https://issues.apache.org/jira/browse/KAFKA-18815 Project: Kafka Issue Type: Sub-task R

[jira] [Created] (KAFKA-18816) Add support for KafkaPrincipalBuilder

2025-02-17 Thread Mickael Maison (Jira)
Mickael Maison created KAFKA-18816: -- Summary: Add support for KafkaPrincipalBuilder Key: KAFKA-18816 URL: https://issues.apache.org/jira/browse/KAFKA-18816 Project: Kafka Issue Type: Sub-tas

Re: [PR] KAFKA-18641: AsyncKafkaConsumer could lose records with auto offset commit [kafka]

2025-02-17 Thread via GitHub
lianetm commented on code in PR #18737: URL: https://github.com/apache/kafka/pull/18737#discussion_r1958555476 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java: ## @@ -748,9 +748,14 @@ public ConsumerRecords poll(final Duration timeout

[jira] [Created] (KAFKA-18817) ShareGroupHeartbeat and ShareGroupDescribe API must check topic describe

2025-02-17 Thread Andrew Schofield (Jira)
Andrew Schofield created KAFKA-18817: Summary: ShareGroupHeartbeat and ShareGroupDescribe API must check topic describe Key: KAFKA-18817 URL: https://issues.apache.org/jira/browse/KAFKA-18817 Proj

Re: [PR] KAFKA-18641: AsyncKafkaConsumer could lose records with auto offset commit [kafka]

2025-02-17 Thread via GitHub
lianetm commented on code in PR #18737: URL: https://github.com/apache/kafka/pull/18737#discussion_r1958555476 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java: ## @@ -748,9 +748,14 @@ public ConsumerRecords poll(final Duration timeout

[PR] KAFKA-18816: Add KIP-877 support to KafkaPrincipalBuilder [kafka]

2025-02-17 Thread via GitHub
mimaison opened a new pull request, #18935: URL: https://github.com/apache/kafka/pull/18935 I'm starting adding KIP-877 support to broker plugins. Doing KafkaPrincipalBuilder separately as all the logic is in the clients module. It's also easier to review smaller PRs instead of having a sin

[jira] [Updated] (KAFKA-18812) Improve new consumer API errors upon background thread failures

2025-02-17 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18812?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-18812: -- Component/s: clients > Improve new consumer API errors upon background thread failures > -

Re: [PR] KAFKA-18773: Migrate the log4j1 config to log4j 2 for native image and README (wip) [kafka]

2025-02-17 Thread via GitHub
dajac commented on PR #18872: URL: https://github.com/apache/kafka/pull/18872#issuecomment-2662677705 @FrankYang0529 Thanks. Do you think that we could merge it this week? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

Re: [PR] KAFKA-18641: AsyncKafkaConsumer could lose records with auto offset commit [kafka]

2025-02-17 Thread via GitHub
lianetm commented on code in PR #18737: URL: https://github.com/apache/kafka/pull/18737#discussion_r1952918176 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractMembershipManager.java: ## @@ -818,6 +826,8 @@ void maybeReconcile() { return;

Re: [PR] Add integration test for IQv2 in KIP-1071 [kafka]

2025-02-17 Thread via GitHub
lucasbru commented on code in PR #18856: URL: https://github.com/apache/kafka/pull/18856#discussion_r1958320133 ## streams/integration-tests/src/test/java/org/apache/kafka/streams/integration/IQv2EndpointToPartitionsIntegrationTest.java: ## @@ -0,0 +1,229 @@ +/* + * Licensed to

Re: [PR] KAFKA-18733: Updating share group record acks metric (2/N) [kafka]

2025-02-17 Thread via GitHub
apoorvmittal10 commented on code in PR #18924: URL: https://github.com/apache/kafka/pull/18924#discussion_r1958406156 ## core/src/test/java/kafka/server/share/SharePartitionManagerTest.java: ## @@ -1587,6 +1587,57 @@ public void testAcknowledgeMultiplePartition() throws Excepti

Re: [PR] KAFKA-18730: Add replaying streams group state from offset topic [kafka]

2025-02-17 Thread via GitHub
lucasbru merged PR #18809: URL: https://github.com/apache/kafka/pull/18809 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[PR] MINOR: Remove dropwizard metrics dep [kafka]

2025-02-17 Thread via GitHub
dajac opened a new pull request, #18932: URL: https://github.com/apache/kafka/pull/18932 This patch removes dropwizard metrics in the dependency list as it is not used any more. It was introduced in https://github.com/apache/kafka/commit/4f5b4c868e72cc9d9a4f859c5bfe8364e9af9fff because it

[jira] [Updated] (KAFKA-18812) Improve new consumer API errors upon background thread failures

2025-02-17 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18812?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lianet Magrans updated KAFKA-18812: --- Summary: Improve new consumer API errors upon background thread failures (was: Improving ne

[PR] MINOR: Rename NoOpShareStatePersister for consistency [kafka]

2025-02-17 Thread via GitHub
AndrewJSchofield opened a new pull request, #18933: URL: https://github.com/apache/kafka/pull/18933 Rename the no-op share group state persister to `NoOpStatePersister` to be consistent with `DefaultStatePersister`. ### Committer Checklist (excluded from commit message) - [ ] Verif

Re: [PR] KAFKA-18641: AsyncKafkaConsumer could lose records with auto offset commit [kafka]

2025-02-17 Thread via GitHub
frankvicky commented on code in PR #18737: URL: https://github.com/apache/kafka/pull/18737#discussion_r1958983469 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java: ## @@ -748,9 +748,14 @@ public ConsumerRecords poll(final Duration time

Re: [PR] KAFKA-18461: Fix potential NPE in setDelta after map is erased [kafka]

2025-02-17 Thread via GitHub
github-actions[bot] commented on PR #18684: URL: https://github.com/apache/kafka/pull/18684#issuecomment-2664505879 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

[jira] [Commented] (KAFKA-17732) System test coverage for new consumer positions getting behind committed offsets

2025-02-17 Thread TaiJuWu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17927911#comment-17927911 ] TaiJuWu commented on KAFKA-17732: - Hi [~lianetm] , I have some questions about this issu

[jira] [Comment Edited] (KAFKA-17732) System test coverage for new consumer positions getting behind committed offsets

2025-02-17 Thread TaiJuWu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17927911#comment-17927911 ] TaiJuWu edited comment on KAFKA-17732 at 2/18/25 5:14 AM: -- Hi [

Re: [PR] KAFKA-18089: RemoteIndexCacheTest fails with caffeine > 3.1.1 [kafka]

2025-02-17 Thread via GitHub
showuon commented on code in PR #18004: URL: https://github.com/apache/kafka/pull/18004#discussion_r1959141446 ## core/src/test/scala/unit/kafka/log/remote/RemoteIndexCacheTest.scala: ## @@ -620,27 +638,29 @@ class RemoteIndexCacheTest { val entry0 = cache.getIndexEntry(m

Re: [PR] MINOR: add docs for "org.apache.kafka.sasl.oauthbearer.allowed.urls" [kafka]

2025-02-17 Thread via GitHub
showuon commented on code in PR #18938: URL: https://github.com/apache/kafka/pull/18938#discussion_r1959132518 ## docs/configuration.html: ## @@ -255,6 +255,16 @@ + + org.apache.kafka.sasl.oauthbearer.allowed.urls Review Comment: You're right! Updated. -- This

Re: [PR] HOTFIX: StoreChangelogReader should require stable consumer group [kafka]

2025-02-17 Thread via GitHub
mjsax commented on PR #18901: URL: https://github.com/apache/kafka/pull/18901#issuecomment-2664721099 Merged to `trunk` and cherry-picked to `4.0` branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

Re: [PR] KAFKA-18089: RemoteIndexCacheTest fails with caffeine > 3.1.1 [kafka]

2025-02-17 Thread via GitHub
showuon commented on code in PR #18004: URL: https://github.com/apache/kafka/pull/18004#discussion_r1959141446 ## core/src/test/scala/unit/kafka/log/remote/RemoteIndexCacheTest.scala: ## @@ -620,27 +638,29 @@ class RemoteIndexCacheTest { val entry0 = cache.getIndexEntry(m

Re: [PR] KAFKA-18798: The replica placement policy used by `ReassignPartitionsCommand` is not aligned with kraft controller [kafka]

2025-02-17 Thread via GitHub
xijiu commented on PR #18914: URL: https://github.com/apache/kafka/pull/18914#issuecomment-2664456604 @chia7712 Apologies, that was my mistake, but I have fixed it now. Below are my local test results: Before fix: `sh kafka-reassign-partitions.sh --bootstrap-server 10.25

Re: [PR] KAFKA-18787: RemoteIndexCache fails to delete invalid files on init [kafka]

2025-02-17 Thread via GitHub
showuon commented on code in PR #1: URL: https://github.com/apache/kafka/pull/1#discussion_r1958995928 ## storage/src/main/java/org/apache/kafka/storage/internals/log/RemoteIndexCache.java: ## @@ -267,8 +267,9 @@ private void init() throws IOException { // Delet

Re: [PR] KAFKA-18089: RemoteIndexCacheTest fails with caffeine > 3.1.1 [kafka]

2025-02-17 Thread via GitHub
TaiJuWu commented on code in PR #18004: URL: https://github.com/apache/kafka/pull/18004#discussion_r1959096371 ## core/src/test/scala/unit/kafka/log/remote/RemoteIndexCacheTest.scala: ## @@ -620,27 +638,29 @@ class RemoteIndexCacheTest { val entry0 = cache.getIndexEntry(m

Re: [PR] KAFKA-18089: RemoteIndexCacheTest fails with caffeine > 3.1.1 [kafka]

2025-02-17 Thread via GitHub
TaiJuWu commented on code in PR #18004: URL: https://github.com/apache/kafka/pull/18004#discussion_r1959096371 ## core/src/test/scala/unit/kafka/log/remote/RemoteIndexCacheTest.scala: ## @@ -620,27 +638,29 @@ class RemoteIndexCacheTest { val entry0 = cache.getIndexEntry(m

[jira] [Resolved] (KAFKA-18807) Group coordinator under-reports thread idle time

2025-02-17 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18807?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot resolved KAFKA-18807. - Fix Version/s: 4.0.0 Resolution: Fixed > Group coordinator under-reports thread idle time

Re: [PR] KAFKA-18396: Migrate log4j1 configuration to log4j2 in KafkaDockerWrapper [kafka]

2025-02-17 Thread via GitHub
chia7712 commented on code in PR #18394: URL: https://github.com/apache/kafka/pull/18394#discussion_r1959192770 ## core/src/main/scala/kafka/docker/KafkaDockerWrapper.scala: ## @@ -219,6 +231,68 @@ object KafkaDockerWrapper extends Logging { Files.write(filepath, properties

Re: [PR] KAFKA-18396: Migrate log4j1 configuration to log4j2 in KafkaDockerWrapper [kafka]

2025-02-17 Thread via GitHub
chia7712 commented on code in PR #18394: URL: https://github.com/apache/kafka/pull/18394#discussion_r1959193091 ## core/src/main/scala/kafka/docker/KafkaDockerWrapper.scala: ## @@ -219,6 +231,68 @@ object KafkaDockerWrapper extends Logging { Files.write(filepath, properties

Re: [PR] KAFKA-18773: Migrate the log4j1 config to log4j 2 for native image and README (wip) [kafka]

2025-02-17 Thread via GitHub
chia7712 commented on PR #18872: URL: https://github.com/apache/kafka/pull/18872#issuecomment-2664812516 ok, I run the native image successfully on my local. There are many issues we need to fix. @FrankYang0529 Could you please try following steps on your PR. 1. use following `

Re: [PR] KAFKA-18787: RemoteIndexCache fails to delete invalid files on init [kafka]

2025-02-17 Thread via GitHub
kamalcph merged PR #1: URL: https://github.com/apache/kafka/pull/1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-18089: RemoteIndexCacheTest fails with caffeine > 3.1.1 [kafka]

2025-02-17 Thread via GitHub
showuon commented on code in PR #18004: URL: https://github.com/apache/kafka/pull/18004#discussion_r1958981427 ## core/src/test/scala/unit/kafka/log/remote/RemoteIndexCacheTest.scala: ## @@ -620,27 +638,29 @@ class RemoteIndexCacheTest { val entry0 = cache.getIndexEntry(m

Re: [PR] MINOR: add docs for "org.apache.kafka.sasl.oauthbearer.allowed.urls" [kafka]

2025-02-17 Thread via GitHub
omkreddy commented on code in PR #18938: URL: https://github.com/apache/kafka/pull/18938#discussion_r1959079609 ## docs/configuration.html: ## @@ -255,6 +255,16 @@ + + org.apache.kafka.sasl.oauthbearer.allowed.urls Review Comment: Can we also update upgrade notes a

Re: [PR] KAFKA-18089: RemoteIndexCacheTest fails with caffeine > 3.1.1 [kafka]

2025-02-17 Thread via GitHub
TaiJuWu commented on PR #18004: URL: https://github.com/apache/kafka/pull/18004#issuecomment-2664677782 This PR also should fix https://issues.apache.org/jira/browse/KAFKA-18524 since evicted algorithm is non-determine. -- This is an automated message from the Apache Git Service. To respo

Re: [PR] MINOR: Add verify_license tool [kafka]

2025-02-17 Thread via GitHub
dajac commented on PR #18931: URL: https://github.com/apache/kafka/pull/18931#issuecomment-2664678707 @mimaison Would you have time for reviewing this one? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] MINOR: add output formatting options for DumpLogSegments [kafka]

2025-02-17 Thread via GitHub
jrmcclurg commented on PR #18910: URL: https://github.com/apache/kafka/pull/18910#issuecomment-2664592876 Thanks @mimaison, I will do that when I get a chance. Closing this PR for now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] MINOR: add output formatting options for DumpLogSegments [kafka]

2025-02-17 Thread via GitHub
jrmcclurg closed pull request #18910: MINOR: add output formatting options for DumpLogSegments URL: https://github.com/apache/kafka/pull/18910 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

Re: [PR] KAFKA-18787: RemoteIndexCache fails to delete invalid files on init [kafka]

2025-02-17 Thread via GitHub
kamalcph commented on code in PR #1: URL: https://github.com/apache/kafka/pull/1#discussion_r1959056977 ## storage/src/main/java/org/apache/kafka/storage/internals/log/RemoteIndexCache.java: ## @@ -267,8 +267,9 @@ private void init() throws IOException { // Dele

Re: [PR] KAFKA-18787: RemoteIndexCache fails to delete invalid files on init [kafka]

2025-02-17 Thread via GitHub
kamalcph commented on code in PR #1: URL: https://github.com/apache/kafka/pull/1#discussion_r1959056977 ## storage/src/main/java/org/apache/kafka/storage/internals/log/RemoteIndexCache.java: ## @@ -267,8 +267,9 @@ private void init() throws IOException { // Dele

Re: [PR] KAFKA-18787: RemoteIndexCache fails to delete invalid files on init [kafka]

2025-02-17 Thread via GitHub
kamalcph commented on code in PR #1: URL: https://github.com/apache/kafka/pull/1#discussion_r1959056977 ## storage/src/main/java/org/apache/kafka/storage/internals/log/RemoteIndexCache.java: ## @@ -267,8 +267,9 @@ private void init() throws IOException { // Dele

  1   2   >