Re: [PR] MINOR: Fix TestBounce sys test [kafka]

2025-02-04 Thread via GitHub
mingdaoy commented on code in PR #18798: URL: https://github.com/apache/kafka/pull/18798#discussion_r1941275249 ## tests/kafkatest/sanity_checks/test_bounce.py: ## @@ -46,13 +43,10 @@ def create_producer(self): # This will produce to source kafka cluster self.p

[jira] [Updated] (KAFKA-18216) High water mark or last stable offset aren't always updated after a fetch request is completed

2025-02-04 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18216?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lianet Magrans updated KAFKA-18216: --- Fix Version/s: 4.1.0 > High water mark or last stable offset aren't always updated after a f

Re: [PR] KAFKA-18494-3: solution for the bug relating to gaps in the share partition cachedStates post initialization [kafka]

2025-02-04 Thread via GitHub
chirag-wadhwa5 commented on code in PR #18696: URL: https://github.com/apache/kafka/pull/18696#discussion_r1941067497 ## core/src/test/java/kafka/server/share/SharePartitionTest.java: ## @@ -5845,6 +7002,46 @@ public void testAcquireWithWriteShareGroupStateDelay() { ass

[jira] [Created] (KAFKA-18725) Fix test_bounce.py sys test

2025-02-04 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-18725: -- Summary: Fix test_bounce.py sys test Key: KAFKA-18725 URL: https://issues.apache.org/jira/browse/KAFKA-18725 Project: Kafka Issue Type: Sub-task

Re: [PR] KAFKA-18530 Remove ZooKeeperInternals [kafka]

2025-02-04 Thread via GitHub
m1a2st commented on code in PR #18641: URL: https://github.com/apache/kafka/pull/18641#discussion_r1941076696 ## core/src/main/scala/kafka/server/DynamicBrokerConfig.scala: ## @@ -48,13 +48,6 @@ import scala.collection._ import scala.jdk.CollectionConverters._ /** - * Dynam

Re: [PR] KAFKA-18494-3: solution for the bug relating to gaps in the share partition cachedStates post initialization [kafka]

2025-02-04 Thread via GitHub
apoorvmittal10 commented on code in PR #18696: URL: https://github.com/apache/kafka/pull/18696#discussion_r1941077150 ## core/src/test/java/kafka/server/share/SharePartitionTest.java: ## @@ -1926,189 +2087,992 @@ public void testAcquireReleasedRecord() { expectedOffsetS

Re: [PR] KAFKA-17565: Move MetadataCache interface to metadata module (wip) [kafka]

2025-02-04 Thread via GitHub
FrankYang0529 commented on code in PR #18801: URL: https://github.com/apache/kafka/pull/18801#discussion_r1941434808 ## core/src/main/scala/kafka/server/metadata/KRaftMetadataCache.scala: ## @@ -345,68 +344,69 @@ class KRaftMetadataCache( Option(_currentImage.cluster.broke

Re: [PR] KAFKA-17565: Move MetadataCache interface to metadata module (wip) [kafka]

2025-02-04 Thread via GitHub
ijuma commented on PR #18801: URL: https://github.com/apache/kafka/pull/18801#issuecomment-2634364064 I realize your PR is still wip, so feel free to ignore the two comments if you were still working through that code. :) -- This is an automated message from the Apache Git Service. To res

Re: [PR] KAFKA-18675: Add tests for valid and invalid broker addresses [kafka]

2025-02-04 Thread via GitHub
mingyen066 commented on code in PR #18781: URL: https://github.com/apache/kafka/pull/18781#discussion_r1941420485 ## clients/src/test/java/org/apache/kafka/clients/ClientUtilsTest.java: ## @@ -95,6 +99,34 @@ public void testParseAndValidateAddressesWithReverseLookup() {

Re: [PR] KAFKA-18323: Add StreamsGroup class [kafka]

2025-02-04 Thread via GitHub
cadonna commented on code in PR #18729: URL: https://github.com/apache/kafka/pull/18729#discussion_r1941239557 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/streams/StreamsGroup.java: ## @@ -0,0 +1,1180 @@ +/* + * Licensed to the Apache Software Foundatio

Re: [PR] KAFKA-18230: handle not controller or not leader error in admin client [kafka]

2025-02-04 Thread via GitHub
mimaison merged PR #18165: URL: https://github.com/apache/kafka/pull/18165 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Assigned] (KAFKA-15900) Flaky test: testOutdatedCoordinatorAssignment() – org.apache.kafka.clients.consumer.internals.EagerConsumerCoordinatorTest

2025-02-04 Thread PoAn Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15900?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] PoAn Yang reassigned KAFKA-15900: - Assignee: PoAn Yang > Flaky test: testOutdatedCoordinatorAssignment() – > org.apache.kafka.cli

Re: [PR] KAFKA-18675: Add unit test to verify space separated brokers won't cause exception for 3.8 and 3.9 [kafka]

2025-02-04 Thread via GitHub
mingyen066 commented on code in PR #18767: URL: https://github.com/apache/kafka/pull/18767#discussion_r1941460260 ## clients/src/test/java/org/apache/kafka/clients/ClientUtilsTest.java: ## @@ -96,6 +100,34 @@ public void testParseAndValidateAddressesWithReverseLookup() {

[jira] [Commented] (KAFKA-15900) Flaky test: testOutdatedCoordinatorAssignment() – org.apache.kafka.clients.consumer.internals.EagerConsumerCoordinatorTest

2025-02-04 Thread PoAn Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17923759#comment-17923759 ] PoAn Yang commented on KAFKA-15900: --- The root cause of this Jira is similar to https:

Re: [PR] KAFKA-18206: EmbeddedKafkaCluster must set features [kafka]

2025-02-04 Thread via GitHub
brandboat commented on PR #18189: URL: https://github.com/apache/kafka/pull/18189#issuecomment-2635438344 > I'm also curious why the tests are returning 1 if there are just flaky tests. Has this always been the case? Hi @jolshan, pardon me, did you mean EagerConsumerCoordinatorTest.t

[jira] [Comment Edited] (KAFKA-18543) Strict validation of bootstrap.servers in Kafka Clients 3.8.x causing issues with multiline configurations

2025-02-04 Thread Ming-Yen Chung (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17923664#comment-17923664 ] Ming-Yen Chung edited comment on KAFKA-18543 at 2/5/25 12:23 AM: -

Re: [PR] KAFKA-18206: EmbeddedKafkaCluster must set features [kafka]

2025-02-04 Thread via GitHub
brandboat commented on code in PR #18189: URL: https://github.com/apache/kafka/pull/18189#discussion_r1942084278 ## core/src/test/scala/integration/kafka/server/KRaftClusterTest.scala: ## @@ -696,7 +696,8 @@ class KRaftClusterTest { new AlterConfigOp(new ConfigEntry

[jira] [Comment Edited] (KAFKA-18543) Strict validation of bootstrap.servers in Kafka Clients 3.8.x causing issues with multiline configurations

2025-02-04 Thread Ming-Yen Chung (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17923664#comment-17923664 ] Ming-Yen Chung edited comment on KAFKA-18543 at 2/5/25 12:31 AM: -

Re: [PR] KAFKA-18206: EmbeddedKafkaCluster must set features [kafka]

2025-02-04 Thread via GitHub
brandboat commented on code in PR #18189: URL: https://github.com/apache/kafka/pull/18189#discussion_r1942084278 ## core/src/test/scala/integration/kafka/server/KRaftClusterTest.scala: ## @@ -696,7 +696,8 @@ class KRaftClusterTest { new AlterConfigOp(new ConfigEntry

Re: [PR] KAFKA-18206: EmbeddedKafkaCluster must set features [kafka]

2025-02-04 Thread via GitHub
brandboat commented on code in PR #18189: URL: https://github.com/apache/kafka/pull/18189#discussion_r1942084278 ## core/src/test/scala/integration/kafka/server/KRaftClusterTest.scala: ## @@ -696,7 +696,8 @@ class KRaftClusterTest { new AlterConfigOp(new ConfigEntry

[jira] [Commented] (KAFKA-18729) Improve consumer check for assigned topics from regex

2025-02-04 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-18729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17923873#comment-17923873 ] 黃竣陽 commented on KAFKA-18729: - Thanks for information, I will take a look :) > Improve cons

Re: [PR] [KAFKA-18689] improve metric calculation to avoid NoSuchElementException [kafka]

2025-02-04 Thread via GitHub
mjsax commented on PR #18771: URL: https://github.com/apache/kafka/pull/18771#issuecomment-2635579959 @stevenschlansker -- can you update this PR so we can move forward with it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] KAFKA-18572: Update Kafka Streams metric documenation [kafka]

2025-02-04 Thread via GitHub
mjsax commented on PR #18673: URL: https://github.com/apache/kafka/pull/18673#issuecomment-2635582260 Did not forget about it. Just no time yet. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

Re: [PR] KAFKA-18168: Adding checkpointing for GlobalKTable during restoration… [kafka]

2025-02-04 Thread via GitHub
mjsax commented on PR #18752: URL: https://github.com/apache/kafka/pull/18752#issuecomment-2635581441 @aliehsaeedii for review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

Re: [PR] DRAFT KAFKA-18692: Consider to unify KStreamImpl "repartitionRequired" with GraphNode "keyChangingOperation" [kafka]

2025-02-04 Thread via GitHub
mjsax commented on PR #18800: URL: https://github.com/apache/kafka/pull/18800#issuecomment-2635584977 Thanks for this draft -- might take a few days until I find time to take a look. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

Re: [PR] MINOR: disable "processing threads" in SmokeTestDriverIntegrationTest [kafka]

2025-02-04 Thread via GitHub
mjsax merged PR #18773: URL: https://github.com/apache/kafka/pull/18773 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

Re: [PR] KAFKA-18690: Keep leader metadata for RE2J-assigned partitions [kafka]

2025-02-04 Thread via GitHub
lianetm commented on PR #18777: URL: https://github.com/apache/kafka/pull/18777#issuecomment-2634750090 Merged to trunk and 4.0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

Re: [PR] KAFKA-18225: ClientQuotaCallback#updateClusterMetadata is unsupported by kraft [kafka]

2025-02-04 Thread via GitHub
chia7712 commented on code in PR #18196: URL: https://github.com/apache/kafka/pull/18196#discussion_r1941715282 ## core/src/test/java/kafka/test/api/CustomQuotaCallbackTest.java: ## @@ -0,0 +1,140 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[PR] KAFKA-18522: Slice records for share fetch [kafka]

2025-02-04 Thread via GitHub
apoorvmittal10 opened a new pull request, #18804: URL: https://github.com/apache/kafka/pull/18804 The PR handles slicing of fetched records based on acquire response for share fetch. There could be additional bytes fetched from log but acquired offsets can be a subset, typically with `max f

Re: [PR] MINOR: cleanup KStream JavaDocs (7/N) - repartition/to/toTable [kafka]

2025-02-04 Thread via GitHub
mjsax commented on code in PR #18760: URL: https://github.com/apache/kafka/pull/18760#discussion_r1942246889 ## streams/src/main/java/org/apache/kafka/streams/kstream/KStream.java: ## @@ -758,185 +756,118 @@ KStream flatMapValues(final ValueMapperWithKey - * The created to

Re: [PR] KAFKA-18142 switch Kafka's Gradle build shadow plugin to `com.gradleup.shadow` (and upgrade plugin version) [kafka]

2025-02-04 Thread via GitHub
Goooler commented on code in PR #18018: URL: https://github.com/apache/kafka/pull/18018#discussion_r1942276633 ## build.gradle: ## @@ -41,7 +41,7 @@ plugins { id "com.github.spotbugs" version '6.0.25' apply false id 'org.scoverage' version '8.0.3' apply false - id 'io.g

Re: [PR] MINOR: cleanup KStream JavaDocs (7/N) - repartition/to/toTable [kafka]

2025-02-04 Thread via GitHub
mjsax commented on code in PR #18760: URL: https://github.com/apache/kafka/pull/18760#discussion_r1942246261 ## streams/src/main/java/org/apache/kafka/streams/kstream/KStream.java: ## @@ -758,185 +756,118 @@ KStream flatMapValues(final ValueMapperWithKey - * The created to

Re: [PR] KAFKA-18064: SASL mechanisms that do support neihter integrity nor co… [kafka]

2025-02-04 Thread via GitHub
stoty commented on PR #17901: URL: https://github.com/apache/kafka/pull/17901#issuecomment-2635861758 Third party code that uses the SASL mechanisms from the Kafka codebase / loads them from the same JVM. Without this change, buggy thirdparty code may think it is communicating on an

Re: [PR] DRAFT KAFKA-18692: Consider to unify KStreamImpl "repartitionRequired" with GraphNode "keyChangingOperation" [kafka]

2025-02-04 Thread via GitHub
appchemist commented on code in PR #18800: URL: https://github.com/apache/kafka/pull/18800#discussion_r1941275162 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamImpl.java: ## @@ -1250,6 +1237,7 @@ public KStream process( name,

Re: [PR] KAFKA-16758: Extend Consumer#close with an option to leave the group or not [kafka]

2025-02-04 Thread via GitHub
ableegoldman commented on code in PR #17614: URL: https://github.com/apache/kafka/pull/17614#discussion_r1942365317 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java: ## @@ -1187,6 +1183,21 @@ public synchronized RequestFuture maybeLe

Re: [PR] KAFKA-16758: Extend Consumer#close with an option to leave the group or not [kafka]

2025-02-04 Thread via GitHub
ableegoldman commented on code in PR #17614: URL: https://github.com/apache/kafka/pull/17614#discussion_r1942366854 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java: ## @@ -1187,6 +1183,21 @@ public synchronized RequestFuture maybeLe

Re: [PR] KAFKA-16758: Extend Consumer#close with an option to leave the group or not [kafka]

2025-02-04 Thread via GitHub
ableegoldman commented on code in PR #17614: URL: https://github.com/apache/kafka/pull/17614#discussion_r1942370387 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java: ## @@ -1236,10 +1237,11 @@ public void enforceRebalance(String reason

Re: [PR] KAFKA-16758: Extend Consumer#close with an option to leave the group or not [kafka]

2025-02-04 Thread via GitHub
ableegoldman commented on code in PR #17614: URL: https://github.com/apache/kafka/pull/17614#discussion_r1942370967 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ClassicKafkaConsumer.java: ## @@ -1102,10 +1103,11 @@ public void enforceRebalance() {

Re: [PR] KAFKA-16758: Extend Consumer#close with an option to leave the group or not [kafka]

2025-02-04 Thread via GitHub
ableegoldman commented on code in PR #17614: URL: https://github.com/apache/kafka/pull/17614#discussion_r1942372964 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/CloseOptionsInternal.java: ## @@ -0,0 +1,43 @@ +/* + * Licensed to the Apache Software Foundat

Re: [PR] KAFKA-16892: fix TopicsDelta generated from snapshot #localChanges return empty deletes [kafka]

2025-02-04 Thread via GitHub
showuon commented on PR #16206: URL: https://github.com/apache/kafka/pull/16206#issuecomment-2635984692 @superhx , sorry that I didn't see the PR. Are you still interested in this PR? Do you think this issue still exist in the trunk branch? -- This is an automated message from the Apa

Re: [PR] reuse LoginCallbackHandler on kerberos re-login [kafka]

2025-02-04 Thread via GitHub
sparkforreg commented on PR #18589: URL: https://github.com/apache/kafka/pull/18589#issuecomment-2635991215 Can you suggest what should be done to make this pr reviewed and merged? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

Re: [PR] MINOR: cleanup KStream JavaDocs (8/N) - stream-stream-inner-join [kafka]

2025-02-04 Thread via GitHub
lucasbru commented on code in PR #18761: URL: https://github.com/apache/kafka/pull/18761#discussion_r194082 ## streams/src/main/java/org/apache/kafka/streams/kstream/KStream.java: ## @@ -1005,23 +1005,25 @@ KGroupedStream groupBy(final KeyValueMapper grouped); /** -

[jira] [Commented] (KAFKA-18697) Migrate suitable classes to records in connect module

2025-02-04 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17923650#comment-17923650 ] Chia-Ping Tsai commented on KAFKA-18697: [~ijuma] Would you recommend applying t

Re: [PR] KAFKA-17379: Fix inexpected state transition from ERROR to PENDING_SHUTDOWN [kafka]

2025-02-04 Thread via GitHub
lucasbru commented on code in PR #18765: URL: https://github.com/apache/kafka/pull/18765#discussion_r1940838447 ## streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java: ## @@ -347,8 +347,9 @@ private boolean setState(final State newState) { } else if (st

Re: [PR] KAFKA-18494-3: solution for the bug relating to gaps in the share partition cachedStates post initialization [kafka]

2025-02-04 Thread via GitHub
chirag-wadhwa5 commented on code in PR #18696: URL: https://github.com/apache/kafka/pull/18696#discussion_r1940939932 ## core/src/test/java/kafka/server/share/SharePartitionTest.java: ## @@ -1951,164 +2112,1102 @@ public void testAcquireReleasedRecordMultipleBatches() {

[jira] [Created] (KAFKA-18727) Move RequestChannel to server module

2025-02-04 Thread Jira
黃竣陽 created KAFKA-18727: --- Summary: Move RequestChannel to server module Key: KAFKA-18727 URL: https://issues.apache.org/jira/browse/KAFKA-18727 Project: Kafka Issue Type: Sub-task Reporter:

Re: [PR] MINOR: Fix TestBounce sys test [kafka]

2025-02-04 Thread via GitHub
dajac merged PR #18798: URL: https://github.com/apache/kafka/pull/18798 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

Re: [PR] MINOR: Fix TestBounce sys test [kafka]

2025-02-04 Thread via GitHub
dajac commented on code in PR #18798: URL: https://github.com/apache/kafka/pull/18798#discussion_r1941202489 ## tests/kafkatest/sanity_checks/test_bounce.py: ## @@ -35,9 +35,8 @@ def __init__(self, test_context): if quorum_size < 1: raise Exception("Illegal

Re: [PR] MINOR: Fix TestBounce sys test [kafka]

2025-02-04 Thread via GitHub
dajac commented on PR #18798: URL: https://github.com/apache/kafka/pull/18798#issuecomment-2634024990 Tested the code locally. Merging it as the CI does not check it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[jira] [Created] (KAFKA-18728) Move ListOffsetsPartitionStatus to server module

2025-02-04 Thread Jira
黃竣陽 created KAFKA-18728: --- Summary: Move ListOffsetsPartitionStatus to server module Key: KAFKA-18728 URL: https://issues.apache.org/jira/browse/KAFKA-18728 Project: Kafka Issue Type: Sub-task

[jira] [Updated] (KAFKA-18217) Slow HWM/LSO update might have subtle effect on the consumer lag reporting

2025-02-04 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lianet Magrans updated KAFKA-18217: --- Fix Version/s: 4.1.0 > Slow HWM/LSO update might have subtle effect on the consumer lag repo

[jira] [Commented] (KAFKA-18697) Migrate suitable classes to records in connect module

2025-02-04 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17923731#comment-17923731 ] Chia-Ping Tsai commented on KAFKA-18697: {quote} What major impact would exposi

Re: [PR] KAFKA-18675: Add tests for valid and invalid broker addresses [kafka]

2025-02-04 Thread via GitHub
chia7712 commented on code in PR #18781: URL: https://github.com/apache/kafka/pull/18781#discussion_r1941309941 ## clients/src/test/java/org/apache/kafka/clients/ClientUtilsTest.java: ## @@ -95,10 +99,38 @@ public void testParseAndValidateAddressesWithReverseLookup() {

[PR] KAFKA-17565: Move MetadataCache interface to metadata module (wip) [kafka]

2025-02-04 Thread via GitHub
FrankYang0529 opened a new pull request, #18801: URL: https://github.com/apache/kafka/pull/18801 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including

Re: [PR] KAFKA-18225: ClientQuotaCallback#updateClusterMetadata is unsupported by kraft [kafka]

2025-02-04 Thread via GitHub
chia7712 commented on code in PR #18196: URL: https://github.com/apache/kafka/pull/18196#discussion_r1941342300 ## core/src/test/java/kafka/test/api/CustomQuotaCallbackTest.java: ## @@ -0,0 +1,140 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

Re: [PR] KAFKA-18645: New consumer should align close timeout handling with classic consumer [kafka]

2025-02-04 Thread via GitHub
lianetm commented on code in PR #18702: URL: https://github.com/apache/kafka/pull/18702#discussion_r1941349655 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java: ## @@ -1368,6 +1373,10 @@ private void close(Duration timeout, boolean sw

Re: [PR] KAFKA-18690: Keep leader metadata for RE2J-assigned partitions [kafka]

2025-02-04 Thread via GitHub
squah-confluent commented on code in PR #18777: URL: https://github.com/apache/kafka/pull/18777#discussion_r1941383728 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerMetadata.java: ## @@ -94,6 +95,15 @@ protected synchronized boolean retainTopic(Str

Re: [PR] KAFKA-18690: Keep leader metadata for RE2J-assigned partitions [kafka]

2025-02-04 Thread via GitHub
squah-confluent commented on code in PR #18777: URL: https://github.com/apache/kafka/pull/18777#discussion_r1941385873 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerMetadata.java: ## @@ -94,6 +95,15 @@ protected synchronized boolean retainTopic(Str

Re: [PR] KAFKA-18675: Add tests for valid and invalid broker addresses [kafka]

2025-02-04 Thread via GitHub
m1a2st commented on code in PR #18781: URL: https://github.com/apache/kafka/pull/18781#discussion_r1941397327 ## clients/src/test/java/org/apache/kafka/clients/ClientUtilsTest.java: ## @@ -95,6 +99,34 @@ public void testParseAndValidateAddressesWithReverseLookup() { }

[jira] [Updated] (KAFKA-18654) Transaction Version 2 performance regression due to early return

2025-02-04 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18654?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot updated KAFKA-18654: Fix Version/s: 4.0.0 > Transaction Version 2 performance regression due to early return >

Re: [PR] KAFKA-18645: New consumer should align close timeout handling with classic consumer [kafka]

2025-02-04 Thread via GitHub
frankvicky commented on code in PR #18702: URL: https://github.com/apache/kafka/pull/18702#discussion_r1941409678 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java: ## @@ -1368,6 +1373,10 @@ private void close(Duration timeout, boolean

Re: [PR] MINOR increase max flaky tests allowed [kafka]

2025-02-04 Thread via GitHub
mumrah merged PR #18792: URL: https://github.com/apache/kafka/pull/18792 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.o

Re: [PR] KAFKA-18675: Add unit test to verify space separated brokers won't cause exception for 3.8 and 3.9 [kafka]

2025-02-04 Thread via GitHub
m1a2st commented on code in PR #18767: URL: https://github.com/apache/kafka/pull/18767#discussion_r1941413877 ## clients/src/test/java/org/apache/kafka/clients/ClientUtilsTest.java: ## @@ -96,6 +100,34 @@ public void testParseAndValidateAddressesWithReverseLookup() { }

[PR] KAFKA-18706: Move AclPublisher to metadata module [kafka]

2025-02-04 Thread via GitHub
FrankYang0529 opened a new pull request, #18802: URL: https://github.com/apache/kafka/pull/18802 Move `AclPublisher` to `org.apache.kafka.metadata.publisher` package. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test

[jira] [Commented] (KAFKA-18396) Migrate log4j1 configuration to log4j2 in KafkaDockerWrapper

2025-02-04 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17923752#comment-17923752 ] Chia-Ping Tsai commented on KAFKA-18396: [~frankvicky] I think this is a blocker

Re: [PR] KAFKA-17565: Move MetadataCache interface to metadata module (wip) [kafka]

2025-02-04 Thread via GitHub
ijuma commented on code in PR #18801: URL: https://github.com/apache/kafka/pull/18801#discussion_r1941423335 ## core/src/main/scala/kafka/server/metadata/KRaftMetadataCache.scala: ## @@ -345,68 +344,69 @@ class KRaftMetadataCache( Option(_currentImage.cluster.broker(broker

[jira] [Commented] (KAFKA-18396) Migrate log4j1 configuration to log4j2 in KafkaDockerWrapper

2025-02-04 Thread TengYao Chi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17923753#comment-17923753 ] TengYao Chi commented on KAFKA-18396: - I will try to get this done before next week.

Re: [PR] KAFKA-17565: Move MetadataCache interface to metadata module (wip) [kafka]

2025-02-04 Thread via GitHub
ijuma commented on code in PR #18801: URL: https://github.com/apache/kafka/pull/18801#discussion_r1941425411 ## core/src/main/scala/kafka/server/metadata/KRaftMetadataCache.scala: ## @@ -345,68 +344,69 @@ class KRaftMetadataCache( Option(_currentImage.cluster.broker(broker

Re: [PR] KAFKA-18690: Keep leader metadata for RE2J-assigned partitions [kafka]

2025-02-04 Thread via GitHub
lianetm commented on code in PR #18777: URL: https://github.com/apache/kafka/pull/18777#discussion_r1941488787 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerMetadata.java: ## @@ -94,6 +95,15 @@ protected synchronized boolean retainTopic(String topi

[jira] [Commented] (KAFKA-18729) Improve consumer check for assigned topics from regex

2025-02-04 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17923770#comment-17923770 ] Lianet Magrans commented on KAFKA-18729: Sure, thanks! > Improve consumer check

[jira] [Created] (KAFKA-18729) Improve consumer check for assigned topics from regex

2025-02-04 Thread Lianet Magrans (Jira)
Lianet Magrans created KAFKA-18729: -- Summary: Improve consumer check for assigned topics from regex Key: KAFKA-18729 URL: https://issues.apache.org/jira/browse/KAFKA-18729 Project: Kafka Iss

Re: [PR] KAFKA-18690: Keep leader metadata for RE2J-assigned partitions [kafka]

2025-02-04 Thread via GitHub
lianetm commented on code in PR #18777: URL: https://github.com/apache/kafka/pull/18777#discussion_r1941488787 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerMetadata.java: ## @@ -94,6 +95,15 @@ protected synchronized boolean retainTopic(String topi

[jira] [Commented] (KAFKA-18729) Improve consumer check for assigned topics from regex

2025-02-04 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-18729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17923769#comment-17923769 ] 黃竣陽 commented on KAFKA-18729: - Hello [~lianetm], If you won't work on this, may I take this?

Re: [PR] KAFKA-18690: Keep leader metadata for RE2J-assigned partitions [kafka]

2025-02-04 Thread via GitHub
lianetm commented on code in PR #18777: URL: https://github.com/apache/kafka/pull/18777#discussion_r1941488787 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerMetadata.java: ## @@ -94,6 +95,15 @@ protected synchronized boolean retainTopic(String topi

Re: [PR] KAFKA-18641: AsyncKafkaConsumer could lose records with auto offset commit [kafka]

2025-02-04 Thread via GitHub
lianetm commented on code in PR #18737: URL: https://github.com/apache/kafka/pull/18737#discussion_r1941427147 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java: ## @@ -324,7 +323,7 @@ public CompletableFuture maybeAutoCommitSyncBefo

[jira] [Assigned] (KAFKA-18729) Improve consumer check for assigned topics from regex

2025-02-04 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-18729?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] 黃竣陽 reassigned KAFKA-18729: --- Assignee: 黃竣陽 > Improve consumer check for assigned topics from regex > ---

Re: [PR] KAFKA-18641: AsyncKafkaConsumer could lose records with auto offset commit [kafka]

2025-02-04 Thread via GitHub
frankvicky commented on code in PR #18737: URL: https://github.com/apache/kafka/pull/18737#discussion_r1941504728 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java: ## @@ -324,7 +323,7 @@ public CompletableFuture maybeAutoCommitSyncB

[jira] [Commented] (KAFKA-18729) Improve consumer check for assigned topics from regex

2025-02-04 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17923773#comment-17923773 ] Lianet Magrans commented on KAFKA-18729: [~m1a2st] more context: Initial PR dis

Re: [PR] KAFKA-18635: reenable the unclean shutdown detection [kafka]

2025-02-04 Thread via GitHub
CalvinConfluent commented on PR #18277: URL: https://github.com/apache/kafka/pull/18277#issuecomment-2634474193 @junrao Sure, will do. But it may take a while as there are other required PRs pending merging into 4.0 -- This is an automated message from the Apache Git Service. To respond t

Re: [PR] Add Integration tests for the the KIP-966 [kafka]

2025-02-04 Thread via GitHub
CalvinConfluent closed pull request #18709: Add Integration tests for the the KIP-966 URL: https://github.com/apache/kafka/pull/18709 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

Re: [PR] Add Integration tests for the the KIP-966 [kafka]

2025-02-04 Thread via GitHub
CalvinConfluent commented on PR #18709: URL: https://github.com/apache/kafka/pull/18709#issuecomment-2634476371 The tests are included in https://github.com/apache/kafka/pull/18277 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[jira] [Updated] (KAFKA-18634) Fix ELR metadata version issues

2025-02-04 Thread Calvin Liu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Calvin Liu updated KAFKA-18634: --- Fix Version/s: 4.0.0 > Fix ELR metadata version issues > --- > >

[jira] [Resolved] (KAFKA-18635) Re-enable the unclean shutdown detection when in ELR mode

2025-02-04 Thread Calvin Liu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18635?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Calvin Liu resolved KAFKA-18635. Resolution: Fixed > Re-enable the unclean shutdown detection when in ELR mode > --

Re: [PR] KAFKA-18538: Add Streams membership manager [kafka]

2025-02-04 Thread via GitHub
cadonna merged PR #18551: URL: https://github.com/apache/kafka/pull/18551 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

Re: [PR] KAFKA-18690: Keep leader metadata for RE2J-assigned partitions [kafka]

2025-02-04 Thread via GitHub
squah-confluent commented on code in PR #18777: URL: https://github.com/apache/kafka/pull/18777#discussion_r1941517469 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerMetadata.java: ## @@ -94,6 +95,15 @@ protected synchronized boolean retainTopic(Str

Re: [PR] KAFKA-18690: Keep leader metadata for RE2J-assigned partitions [kafka]

2025-02-04 Thread via GitHub
squah-confluent commented on PR #18777: URL: https://github.com/apache/kafka/pull/18777#issuecomment-2634490974 Thanks for reviewing! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Resolved] (KAFKA-18538) Add Streams membership manager

2025-02-04 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18538?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Cadonna resolved KAFKA-18538. --- Resolution: Fixed > Add Streams membership manager > -- > >

Re: [PR] MINOR: Add missing test tag to UnifiedLogTest.scala [kafka]

2025-02-04 Thread via GitHub
jolshan commented on PR #18794: URL: https://github.com/apache/kafka/pull/18794#issuecomment-2634506383 Wow so many missing on this file 😂 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

Re: [PR] KAFKA-18230: handle not controller or not leader error in admin client [kafka]

2025-02-04 Thread via GitHub
mimaison commented on PR #18165: URL: https://github.com/apache/kafka/pull/18165#issuecomment-2634418278 Applied to 4.0 too: https://github.com/apache/kafka/commit/8026d6b3e85a7f3cb5f29925ea1372ea68bc5842 -- This is an automated message from the Apache Git Service. To respond to the messa

Re: [PR] KAFKA-18691: Flaky test testFencingOnTransactionExpiration [kafka]

2025-02-04 Thread via GitHub
jolshan merged PR #18793: URL: https://github.com/apache/kafka/pull/18793 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[jira] [Reopened] (KAFKA-18649) Complete ClearElrRecord handling in topic delta

2025-02-04 Thread Calvin Liu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Calvin Liu reopened KAFKA-18649: > Complete ClearElrRecord handling in topic delta > --- >

[jira] [Reopened] (KAFKA-16540) Update partitions when the min isr config is updated.

2025-02-04 Thread Calvin Liu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Calvin Liu reopened KAFKA-16540: > Update partitions when the min isr config is updated. >

[jira] [Reopened] (KAFKA-18635) Re-enable the unclean shutdown detection when in ELR mode

2025-02-04 Thread Calvin Liu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18635?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Calvin Liu reopened KAFKA-18635: > Re-enable the unclean shutdown detection when in ELR mode >

Re: [PR] KAFKA-18698: Migrate suitable classes to records in server and server-common modules [kafka]

2025-02-04 Thread via GitHub
chia7712 commented on code in PR #18783: URL: https://github.com/apache/kafka/pull/18783#discussion_r1940701966 ## server-common/src/main/java/org/apache/kafka/server/common/TopicIdPartition.java: ## @@ -18,45 +18,15 @@ import org.apache.kafka.common.Uuid; -import java.util

Re: [PR] KAFKA-18698: Migrate suitable classes to records in server and server-common modules [kafka]

2025-02-04 Thread via GitHub
m1a2st commented on code in PR #18783: URL: https://github.com/apache/kafka/pull/18783#discussion_r1940704606 ## server-common/src/main/java/org/apache/kafka/server/common/TopicIdPartition.java: ## @@ -18,45 +18,15 @@ import org.apache.kafka.common.Uuid; -import java.util.O

Re: [PR] KAFKA-18698: Migrate suitable classes to records in server and server-common modules [kafka]

2025-02-04 Thread via GitHub
m1a2st commented on code in PR #18783: URL: https://github.com/apache/kafka/pull/18783#discussion_r1940704606 ## server-common/src/main/java/org/apache/kafka/server/common/TopicIdPartition.java: ## @@ -18,45 +18,15 @@ import org.apache.kafka.common.Uuid; -import java.util.O

Re: [PR] KAFKA-18379: Enforce resigned cannot transition to any other state in same epoch [kafka]

2025-02-04 Thread via GitHub
frankvicky commented on code in PR #18789: URL: https://github.com/apache/kafka/pull/18789#discussion_r1940619541 ## raft/src/main/java/org/apache/kafka/raft/QuorumState.java: ## @@ -621,13 +621,14 @@ public void transitionToProspective() { } int retries = is

Re: [PR] KAFKA-18323: Add StreamsGroup class [kafka]

2025-02-04 Thread via GitHub
lucasbru commented on PR #18729: URL: https://github.com/apache/kafka/pull/18729#issuecomment-2633276629 Rebased on latest trunk -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

Re: [PR] Unit tests for usage of incorrect RPCs / group type pairs [kafka]

2025-02-04 Thread via GitHub
lucasbru commented on PR #18383: URL: https://github.com/apache/kafka/pull/18383#issuecomment-2633278345 @bbejeck is this still on your list? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[PR] MINOR: Fix Benchmark sys tests [kafka]

2025-02-04 Thread via GitHub
dajac opened a new pull request, #18796: URL: https://github.com/apache/kafka/pull/18796 This patch fixes the Benchmark system tests. We misconfigured the quorum in https://github.com/apache/kafka/commit/bc7b87001bfd641f93105eaa1e0326bdaf15b55d. ``` ===

  1   2   3   >