m1a2st commented on code in PR #18767:
URL: https://github.com/apache/kafka/pull/18767#discussion_r1941413877
##########
clients/src/test/java/org/apache/kafka/clients/ClientUtilsTest.java:
##########
@@ -96,6 +100,34 @@ public void
testParseAndValidateAddressesWithReverseLookup() {
}
}
+ static Stream<List<String>> provideValidBrokerAddressTestCases() {
+ return Stream.of(
+ Arrays.asList("localhost:9997", "localhost:9998",
"localhost:9999"),
+ Arrays.asList("localhost:9997", "localhost:9998", "
localhost:9999"),
+ // Intentionally provide a single string, as users may provide
space-separated brokers, which will be parsed as a single string.
+ Arrays.asList("localhost:9997 localhost:9998 localhost:9999")
+ );
+ }
+
+ @ParameterizedTest
+ @MethodSource("provideValidBrokerAddressTestCases")
+ public void testValidBrokerAddress(List<String> addresses) {
+ assertDoesNotThrow(() ->
ClientUtils.parseAndValidateAddresses(addresses,
ClientDnsLookup.USE_ALL_DNS_IPS));
+ }
+
+ static Stream<List<String>> provideInvalidBrokerAddressTestCases() {
+ return Stream.of(
+
Collections.singletonList("localhost:9997\nlocalhost:9998\nlocalhost:9999")
+ );
+ }
+
+ @ParameterizedTest
+ @MethodSource("provideInvalidBrokerAddressTestCases")
+ public void testInvalidBrokerAddress(List<String> addresses) {
+ assertThrows(ConfigException.class,
+ () -> ClientUtils.parseAndValidateAddresses(addresses,
ClientDnsLookup.USE_ALL_DNS_IPS));
+ }
Review Comment:
Only test one case, why need to use `@ParameterizedTest`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
