Re: [PR] KAFKA-18494-3: solution for the bug relating to gaps in the share partition cachedStates post initialization [kafka]

2025-02-03 Thread via GitHub
chirag-wadhwa5 commented on code in PR #18696: URL: https://github.com/apache/kafka/pull/18696#discussion_r1940543756 ## core/src/test/java/kafka/server/share/SharePartitionTest.java: ## @@ -896,6 +896,170 @@ public void testMaybeInitializeWithReadException() { assertTh

Re: [PR] KAFKA-18494-3: solution for the bug relating to gaps in the share partition cachedStates post initialization [kafka]

2025-02-03 Thread via GitHub
chirag-wadhwa5 commented on code in PR #18696: URL: https://github.com/apache/kafka/pull/18696#discussion_r1940543756 ## core/src/test/java/kafka/server/share/SharePartitionTest.java: ## @@ -896,6 +896,170 @@ public void testMaybeInitializeWithReadException() { assertTh

Re: [PR] KAFKA-18494-3: solution for the bug relating to gaps in the share partition cachedStates post initialization [kafka]

2025-02-03 Thread via GitHub
chirag-wadhwa5 commented on code in PR #18696: URL: https://github.com/apache/kafka/pull/18696#discussion_r1940544007 ## core/src/test/java/kafka/server/share/SharePartitionTest.java: ## @@ -896,6 +896,170 @@ public void testMaybeInitializeWithReadException() { assertTh

Re: [PR] KAFKA-18494-3: solution for the bug relating to gaps in the share partition cachedStates post initialization [kafka]

2025-02-03 Thread via GitHub
chirag-wadhwa5 commented on code in PR #18696: URL: https://github.com/apache/kafka/pull/18696#discussion_r1940544007 ## core/src/test/java/kafka/server/share/SharePartitionTest.java: ## @@ -896,6 +896,170 @@ public void testMaybeInitializeWithReadException() { assertTh

Re: [PR] KAFKA-18494-3: solution for the bug relating to gaps in the share partition cachedStates post initialization [kafka]

2025-02-03 Thread via GitHub
chirag-wadhwa5 commented on code in PR #18696: URL: https://github.com/apache/kafka/pull/18696#discussion_r1940546264 ## core/src/test/java/kafka/server/share/SharePartitionTest.java: ## @@ -896,6 +896,170 @@ public void testMaybeInitializeWithReadException() { assertTh

Re: [PR] MINOR: update Kafka Streams `Topology` JavaDocs [kafka]

2025-02-03 Thread via GitHub
mjsax commented on code in PR #18778: URL: https://github.com/apache/kafka/pull/18778#discussion_r1940548959 ## streams/src/main/java/org/apache/kafka/streams/Topology.java: ## @@ -119,10 +119,14 @@ private static AutoOffsetResetInternal convertOldToNew(final Topology.AutoOffse

Re: [PR] MINOR: update Kafka Streams `Topology` JavaDocs [kafka]

2025-02-03 Thread via GitHub
mjsax commented on code in PR #18778: URL: https://github.com/apache/kafka/pull/18778#discussion_r1940549926 ## streams/src/main/java/org/apache/kafka/streams/Topology.java: ## @@ -476,22 +483,22 @@ public synchronized Topology addSink(final String name, /** * See {@l

Re: [PR] KAFKA-18655: Implement the consumer group size counter with scheduled task [kafka]

2025-02-03 Thread via GitHub
jeffkbkim merged PR #18717: URL: https://github.com/apache/kafka/pull/18717 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apach

[jira] [Resolved] (KAFKA-17984) Move MetadataSupport to server module

2025-02-03 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-17984?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] 黃竣陽 resolved KAFKA-17984. - Resolution: Won't Fix > Move MetadataSupport to server module > - > >

[jira] [Resolved] (KAFKA-18655) Implement the consumer group size counter with scheduled task

2025-02-03 Thread Jeff Kim (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18655?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeff Kim resolved KAFKA-18655. -- Resolution: Fixed > Implement the consumer group size counter with scheduled task > --

Re: [PR] KAFKA-18655: Implement the consumer group size counter with scheduled task [kafka]

2025-02-03 Thread via GitHub
jeffkbkim commented on PR #18717: URL: https://github.com/apache/kafka/pull/18717#issuecomment-2631400918 Picked to 4.0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

Re: [PR] (Draft) Run new tests separately in PRs [kafka]

2025-02-03 Thread via GitHub
mumrah commented on PR #18770: URL: https://github.com/apache/kafka/pull/18770#issuecomment-2631413304 @ijuma @chia7712: Looking more closely, I don't think we can repeat the unit tests within the JUnit framework. To repeat those tests, we would need to generate additional test invocation c

[jira] [Commented] (KAFKA-18147) kraft version of standalone KIP-853. controller should be 1 not 0

2025-02-03 Thread PoAn Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17923347#comment-17923347 ] PoAn Yang commented on KAFKA-18147: --- It looks like the issue is similar to https://is

[jira] [Created] (KAFKA-18714) Unclean Recovery: Balanced strategy

2025-02-03 Thread Jonah Hooper (Jira)
Jonah Hooper created KAFKA-18714: Summary: Unclean Recovery: Balanced strategy Key: KAFKA-18714 URL: https://issues.apache.org/jira/browse/KAFKA-18714 Project: Kafka Issue Type: Sub-task

Re: [PR] KAFKA-18672; CoordinatorRecordSerde must validate value version (4.0) [kafka]

2025-02-03 Thread via GitHub
dajac merged PR #18786: URL: https://github.com/apache/kafka/pull/18786 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

[jira] [Updated] (KAFKA-18680) Design unclean recovery elections subsystem

2025-02-03 Thread Jonah Hooper (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18680?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonah Hooper updated KAFKA-18680: - Remaining Estimate: 168h Original Estimate: 168h > Design unclean recovery elections subsys

[jira] [Resolved] (KAFKA-18672) CoordinatorRecordSerde must validate value versions

2025-02-03 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18672?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot resolved KAFKA-18672. - Fix Version/s: 4.0.0 Resolution: Fixed > CoordinatorRecordSerde must validate value versi

[jira] [Updated] (KAFKA-18681) GetReplicaLogInfo request

2025-02-03 Thread Jonah Hooper (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18681?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonah Hooper updated KAFKA-18681: - Remaining Estimate: 168h Original Estimate: 168h > GetReplicaLogInfo request >

[jira] [Updated] (KAFKA-18682) Designated Leadership Elections

2025-02-03 Thread Jonah Hooper (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18682?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonah Hooper updated KAFKA-18682: - Remaining Estimate: 168h Original Estimate: 168h > Designated Leadership Elections > --

[jira] [Created] (KAFKA-18717) Unclean Recovery: thread-pool

2025-02-03 Thread Jonah Hooper (Jira)
Jonah Hooper created KAFKA-18717: Summary: Unclean Recovery: thread-pool Key: KAFKA-18717 URL: https://issues.apache.org/jira/browse/KAFKA-18717 Project: Kafka Issue Type: Sub-task

Re: [PR] Code optimization: Supplement the missing Override tag on the override method [kafka]

2025-02-03 Thread via GitHub
mimaison commented on PR #11399: URL: https://github.com/apache/kafka/pull/11399#issuecomment-2631477130 Your branch `optimization_missing_Override_tag` is completely out of sync with `apache/trunk`. You see it's over 5000 commits behind: https://github.com/lordcheng10/kafka/tree/optimizati

[jira] [Created] (KAFKA-18718) Unclean recovery configs

2025-02-03 Thread Jonah Hooper (Jira)
Jonah Hooper created KAFKA-18718: Summary: Unclean recovery configs Key: KAFKA-18718 URL: https://issues.apache.org/jira/browse/KAFKA-18718 Project: Kafka Issue Type: Sub-task Rep

[jira] [Created] (KAFKA-18719) kafka-leadership-election.sh should contain new unclean election strategies

2025-02-03 Thread Jonah Hooper (Jira)
Jonah Hooper created KAFKA-18719: Summary: kafka-leadership-election.sh should contain new unclean election strategies Key: KAFKA-18719 URL: https://issues.apache.org/jira/browse/KAFKA-18719 Project:

Re: [PR] KAFKA-17298: Update upgrade notes for 4.0 KIP-848 [kafka]

2025-02-03 Thread via GitHub
m1a2st commented on code in PR #18756: URL: https://github.com/apache/kafka/pull/18756#discussion_r1939685544 ## docs/upgrade.html: ## @@ -207,6 +228,38 @@ Notable changes in 4 Consumer +New Consume

Re: [PR] MINOR: add MirrorMaker2 missing metrics and mbean filters [kafka]

2025-02-03 Thread via GitHub
mimaison commented on code in PR #18691: URL: https://github.com/apache/kafka/pull/18691#discussion_r1939686629 ## docs/ops.html: ## @@ -1044,8 +1045,9 @@ target -# MBean: kafka.connect.mirror:type=MirrorCheckpointConnector,source=([-.w]+),target=([-.w]+) +# MBean: kafka.co

[jira] [Updated] (KAFKA-18719) kafka-leadership-election.sh should contain new unclean election strategies

2025-02-03 Thread Jonah Hooper (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonah Hooper updated KAFKA-18719: - Description: This work involves updating both the: kafka-leadership-election.sh shell script as

Re: [PR] MINOR: update Kafka Streams `Topology` JavaDocs [kafka]

2025-02-03 Thread via GitHub
mjsax commented on code in PR #18778: URL: https://github.com/apache/kafka/pull/18778#discussion_r1940552054 ## streams/src/main/java/org/apache/kafka/streams/Topology.java: ## @@ -677,10 +662,10 @@ public synchronized Topology addProcessor(final String na * * @thr

Re: [PR] MINOR: update Kafka Streams `Topology` JavaDocs [kafka]

2025-02-03 Thread via GitHub
mjsax commented on code in PR #18778: URL: https://github.com/apache/kafka/pull/18778#discussion_r1940550708 ## streams/src/main/java/org/apache/kafka/streams/Topology.java: ## @@ -510,62 +517,38 @@ public synchronized Topology addSink(final String name, } /** -

Re: [PR] MINOR: update Kafka Streams `Topology` JavaDocs [kafka]

2025-02-03 Thread via GitHub
mjsax commented on code in PR #18778: URL: https://github.com/apache/kafka/pull/18778#discussion_r1940551476 ## streams/src/main/java/org/apache/kafka/streams/Topology.java: ## @@ -617,7 +600,9 @@ public synchronized Topology addSink(final String name, * * @throws

Re: [PR] MINOR: update Kafka Streams `Topology` JavaDocs [kafka]

2025-02-03 Thread via GitHub
mjsax commented on code in PR #18778: URL: https://github.com/apache/kafka/pull/18778#discussion_r1940553477 ## streams/src/main/java/org/apache/kafka/streams/Topology.java: ## @@ -677,10 +662,10 @@ public synchronized Topology addProcessor(final String na * * @thr

Re: [PR] MINOR: update Kafka Streams `Topology` JavaDocs [kafka]

2025-02-03 Thread via GitHub
mjsax commented on code in PR #18778: URL: https://github.com/apache/kafka/pull/18778#discussion_r1940554151 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopologyBuilder.java: ## @@ -74,6 +74,8 @@ public InternalTopologyBuilder() { }

Re: [PR] MINOR: update Kafka Streams `Topology` JavaDocs [kafka]

2025-02-03 Thread via GitHub
mjsax commented on code in PR #18778: URL: https://github.com/apache/kafka/pull/18778#discussion_r1940549273 ## streams/src/main/java/org/apache/kafka/streams/Topology.java: ## @@ -135,7 +139,7 @@ public synchronized Topology addSource(final String name, /** * See {@l

Re: [PR] MINOR: update Kafka Streams `Topology` JavaDocs [kafka]

2025-02-03 Thread via GitHub
mjsax commented on code in PR #18778: URL: https://github.com/apache/kafka/pull/18778#discussion_r1940553801 ## streams/src/main/java/org/apache/kafka/streams/internals/ApiUtils.java: ## @@ -81,6 +82,8 @@ public static String prepareMillisCheckFailMsgPrefix(final Object value,

Re: [PR] MINOR: update Kafka Streams `Topology` JavaDocs [kafka]

2025-02-03 Thread via GitHub
mjsax commented on code in PR #18778: URL: https://github.com/apache/kafka/pull/18778#discussion_r1940554541 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopologyBuilder.java: ## @@ -368,7 +370,7 @@ private SinkNodeFactory(final String name,

Re: [PR] MINOR: update Kafka Streams `Topology` JavaDocs [kafka]

2025-02-03 Thread via GitHub
mjsax commented on code in PR #18778: URL: https://github.com/apache/kafka/pull/18778#discussion_r1940554776 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopologyBuilder.java: ## @@ -447,18 +449,23 @@ public final synchronized InternalTopologyBui

Re: [PR] MINOR: update Kafka Streams `Topology` JavaDocs [kafka]

2025-02-03 Thread via GitHub
mjsax commented on code in PR #18778: URL: https://github.com/apache/kafka/pull/18778#discussion_r1940558829 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopologyBuilder.java: ## @@ -507,46 +510,23 @@ public final void addSink(final String name,

Re: [PR] MINOR: update Kafka Streams `Topology` JavaDocs [kafka]

2025-02-03 Thread via GitHub
mjsax commented on code in PR #18778: URL: https://github.com/apache/kafka/pull/18778#discussion_r1940554776 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopologyBuilder.java: ## @@ -447,18 +449,23 @@ public final synchronized InternalTopologyBui

Re: [PR] MINOR: update Kafka Streams `Topology` JavaDocs [kafka]

2025-02-03 Thread via GitHub
mjsax commented on code in PR #18778: URL: https://github.com/apache/kafka/pull/18778#discussion_r1940561921 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopologyBuilder.java: ## @@ -587,31 +550,34 @@ public final void addProcessor(final String n

Re: [PR] MINOR: update Kafka Streams `Topology` JavaDocs [kafka]

2025-02-03 Thread via GitHub
mjsax commented on code in PR #18778: URL: https://github.com/apache/kafka/pull/18778#discussion_r1940563422 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopologyBuilder.java: ## @@ -507,46 +510,23 @@ public final void addSink(final String name,

Re: [PR] MINOR: update Kafka Streams `Topology` JavaDocs [kafka]

2025-02-03 Thread via GitHub
mjsax commented on code in PR #18778: URL: https://github.com/apache/kafka/pull/18778#discussion_r1940564999 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopologyBuilder.java: ## @@ -655,21 +622,32 @@ public final void addGlobalStore(final Strin

Re: [PR] MINOR: update Kafka Streams `Topology` JavaDocs [kafka]

2025-02-03 Thread via GitHub
mjsax commented on code in PR #18778: URL: https://github.com/apache/kafka/pull/18778#discussion_r1940563796 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopologyBuilder.java: ## @@ -655,21 +622,32 @@ public final void addGlobalStore(final Strin

Re: [PR] MINOR: update Kafka Streams `Topology` JavaDocs [kafka]

2025-02-03 Thread via GitHub
mjsax commented on code in PR #18778: URL: https://github.com/apache/kafka/pull/18778#discussion_r1940564189 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopologyBuilder.java: ## @@ -655,21 +622,32 @@ public final void addGlobalStore(final Strin

Re: [PR] MINOR: update Kafka Streams `Topology` JavaDocs [kafka]

2025-02-03 Thread via GitHub
mjsax commented on code in PR #18778: URL: https://github.com/apache/kafka/pull/18778#discussion_r1940565584 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopologyBuilder.java: ## @@ -729,13 +707,21 @@ public boolean isStoreVersioned(final String

Re: [PR] MINOR: update Kafka Streams `Topology` JavaDocs [kafka]

2025-02-03 Thread via GitHub
mjsax commented on code in PR #18778: URL: https://github.com/apache/kafka/pull/18778#discussion_r1940566642 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopologyBuilder.java: ## @@ -1963,7 +1924,6 @@ public String toString() { +

Re: [PR] MINOR: update Kafka Streams `Topology` JavaDocs [kafka]

2025-02-03 Thread via GitHub
mjsax commented on code in PR #18778: URL: https://github.com/apache/kafka/pull/18778#discussion_r1940567798 ## streams/src/test/java/org/apache/kafka/streams/TopologyTest.java: ## @@ -423,10 +423,8 @@ public void process(final Record record) { } } } -@Depre

Re: [PR] MINOR: update Kafka Streams `Topology` JavaDocs [kafka]

2025-02-03 Thread via GitHub
mjsax commented on code in PR #18778: URL: https://github.com/apache/kafka/pull/18778#discussion_r1940549926 ## streams/src/main/java/org/apache/kafka/streams/Topology.java: ## @@ -476,22 +483,22 @@ public synchronized Topology addSink(final String name, /** * See {@l

Re: [PR] MINOR: update Kafka Streams `Topology` JavaDocs [kafka]

2025-02-03 Thread via GitHub
mjsax commented on code in PR #18778: URL: https://github.com/apache/kafka/pull/18778#discussion_r1940567499 ## streams/src/test/java/org/apache/kafka/streams/TopologyTest.java: ## @@ -423,10 +423,8 @@ public void process(final Record record) { } } } -@Depre

Re: [PR] KAFKA-17379: Fix inexpected state transition from ERROR to PENDING_SHUTDOWN [kafka]

2025-02-03 Thread via GitHub
mjsax commented on code in PR #18765: URL: https://github.com/apache/kafka/pull/18765#discussion_r1938064632 ## streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java: ## @@ -347,8 +347,9 @@ private boolean setState(final State newState) { } else if (state

[PR] KAFKA-17182: Consumer fetch sessions are evicted too quickly with AsyncKafkaConsumer [kafka]

2025-02-03 Thread via GitHub
kirktrue opened a new pull request, #18795: URL: https://github.com/apache/kafka/pull/18795 This change reduces fetch session cache evictions on the broker for `AsyncKafkaConsumer` by altering its logic to determine which partitions it includes in fetch requests. # Background

Re: [PR] KAFKA-17182: Consumer fetch sessions are evicted too quickly with AsyncKafkaConsumer [kafka]

2025-02-03 Thread via GitHub
kirktrue commented on code in PR #18795: URL: https://github.com/apache/kafka/pull/18795#discussion_r1940312912 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractFetch.java: ## @@ -408,22 +407,52 @@ protected Map prepareFetchRequests() long c

Re: [PR] KAFKA-18693: Remove PasswordEncoder [kafka]

2025-02-03 Thread via GitHub
chia7712 commented on PR #18790: URL: https://github.com/apache/kafka/pull/18790#issuecomment-2632902763 testFencingOnTransactionExpiration is traced by #18793 testOutdatedCoordinatorAssignment -> https://issues.apache.org/jira/browse/KAFKA-15900 testUnmuteChannelWithBufferedR

[jira] [Updated] (KAFKA-18724) fix flaky SocketServerTest#testUnmuteChannelWithBufferedReceives

2025-02-03 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-18724: --- Issue Type: Test (was: Improvement) > fix flaky SocketServerTest#testUnmuteChannelWithBuffe

[jira] [Created] (KAFKA-18724) fix flaky SocketServerTest#testUnmuteChannelWithBufferedReceives

2025-02-03 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-18724: -- Summary: fix flaky SocketServerTest#testUnmuteChannelWithBufferedReceives Key: KAFKA-18724 URL: https://issues.apache.org/jira/browse/KAFKA-18724 Project: Kafka

Re: [PR] KAFKA-18693: Remove PasswordEncoder [kafka]

2025-02-03 Thread via GitHub
chia7712 merged PR #18790: URL: https://github.com/apache/kafka/pull/18790 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Resolved] (KAFKA-18693) Remove PasswordEncoder

2025-02-03 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18693?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-18693. Fix Version/s: 4.1.0 Resolution: Fixed > Remove PasswordEncoder > -

Re: [PR] KAFKA-18654: Transaction Version 2 performance regression due to early return [kafka]

2025-02-03 Thread via GitHub
jeffkbkim commented on PR #18720: URL: https://github.com/apache/kafka/pull/18720#issuecomment-2632038120 Can we add a bit more information as to what is the nature of the perf regression? And the PR description indicates that we are planning to add a producer bench result? -- This is an

Re: [PR] KAFKA-12481: Add socket.nagle.disable config property [kafka]

2025-02-03 Thread via GitHub
iatsuk commented on PR #10333: URL: https://github.com/apache/kafka/pull/10333#issuecomment-2631829391 Unfortunately, I can't remember. Actually, it could be a good idea to finish the merge request, but for now, I don't have a suitable demo stand with metrics to measure the final effect of

Re: [PR] MINOR: fix NPE in KS `Topology` for new `AutoOffsetReset` [kafka]

2025-02-03 Thread via GitHub
mjsax merged PR #18780: URL: https://github.com/apache/kafka/pull/18780 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

[jira] [Comment Edited] (KAFKA-18459) Use ZooKeeper 3.4 in ducktape in order to support AK 2.1

2025-02-03 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17923539#comment-17923539 ] Colin McCabe edited comment on KAFKA-18459 at 2/4/25 1:35 AM:

[jira] [Commented] (KAFKA-18459) Use ZooKeeper 3.4 in ducktape in order to support AK 2.1

2025-02-03 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17923539#comment-17923539 ] Colin McCabe commented on KAFKA-18459: -- [~chia7712] thanks for commenting. I wasn't

[jira] [Updated] (KAFKA-18459) Support multiple JDKs in ducktape

2025-02-03 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin McCabe updated KAFKA-18459: - Description: Eventually we will need to support multiple JDKs in ducktape. One example of why w

[jira] [Updated] (KAFKA-18459) Support multiple JDKs in ducktape

2025-02-03 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin McCabe updated KAFKA-18459: - Description: Eventually we will need to support multiple JDKs in ducktape. One example of why w

Re: [PR] KAFKA-18635: reenable the unclean shutdown detection [kafka]

2025-02-03 Thread via GitHub
CalvinConfluent commented on PR #18277: URL: https://github.com/apache/kafka/pull/18277#issuecomment-2632212123 @junrao Thanks for the review, now the tests look good. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

Re: [PR] KAFKA-18634: Fix ELR metadata version issues [kafka]

2025-02-03 Thread via GitHub
CalvinConfluent commented on code in PR #18680: URL: https://github.com/apache/kafka/pull/18680#discussion_r1940117855 ## server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java: ## @@ -113,15 +113,15 @@ public enum MetadataVersion { // Bootstrap met

[PR] MINOR: Add missing test tag to UnifiedLogTest.scala [kafka]

2025-02-03 Thread via GitHub
jolshan opened a new pull request, #18794: URL: https://github.com/apache/kafka/pull/18794 Noticed this while working on other bugfixes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

Re: [PR] KAFKA-17171: Add test cases for `STATIC_BROKER_CONFIG`in kraft mode [kafka]

2025-02-03 Thread via GitHub
github-actions[bot] commented on PR #18463: URL: https://github.com/apache/kafka/pull/18463#issuecomment-2632718000 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] KAFKA-18647: Clarify Windows support in Quick Start Guide [kafka]

2025-02-03 Thread via GitHub
github-actions[bot] commented on PR #18715: URL: https://github.com/apache/kafka/pull/18715#issuecomment-2632717898 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] KAFKA-18576: Convert ConfigType to Enum [kafka]

2025-02-03 Thread via GitHub
github-actions[bot] commented on PR #18711: URL: https://github.com/apache/kafka/pull/18711#issuecomment-2632717925 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] KAFKA-16123: KStreamKStreamJoinProcessor does not drop late records. [kafka]

2025-02-03 Thread via GitHub
github-actions[bot] commented on PR #15189: URL: https://github.com/apache/kafka/pull/15189#issuecomment-2632742391 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to

Re: [PR] KAFKA-16102: fix the dynamic modification of listeners' IP or port no… [kafka]

2025-02-03 Thread via GitHub
github-actions[bot] commented on PR #15321: URL: https://github.com/apache/kafka/pull/15321#issuecomment-2632742459 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to

Re: [PR] KAFKA-16066: Upgrade apacheds to 2.0.0.AM27 With apache kerby [kafka]

2025-02-03 Thread via GitHub
github-actions[bot] commented on PR #15277: URL: https://github.com/apache/kafka/pull/15277#issuecomment-2632742417 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to

Re: [PR] KAFKA-16066: Upgrade apacheds to 2.0.0.AM27 With apache kerby [kafka]

2025-02-03 Thread via GitHub
github-actions[bot] closed pull request #15277: KAFKA-16066: Upgrade apacheds to 2.0.0.AM27 With apache kerby URL: https://github.com/apache/kafka/pull/15277 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

Re: [PR] KAFKA-16123: KStreamKStreamJoinProcessor does not drop late records. [kafka]

2025-02-03 Thread via GitHub
github-actions[bot] closed pull request #15189: KAFKA-16123: KStreamKStreamJoinProcessor does not drop late records. URL: https://github.com/apache/kafka/pull/15189 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] Update subscriptions at the end. [kafka]

2025-02-03 Thread via GitHub
github-actions[bot] commented on PR #14720: URL: https://github.com/apache/kafka/pull/14720#issuecomment-2632742350 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to

Re: [PR] Update subscriptions at the end. [kafka]

2025-02-03 Thread via GitHub
github-actions[bot] closed pull request #14720: Update subscriptions at the end. URL: https://github.com/apache/kafka/pull/14720 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] KAFKA-17552: Handle LIST_OFFSETS request for max_timestamp when remote storage is enabled [kafka]

2025-02-03 Thread via GitHub
github-actions[bot] commented on PR #17248: URL: https://github.com/apache/kafka/pull/17248#issuecomment-2632742883 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please leave a comment asking for a review. If the P

Re: [PR] IGNORE: Test PR for KAFKA-15062 [kafka]

2025-02-03 Thread via GitHub
github-actions[bot] commented on PR #14717: URL: https://github.com/apache/kafka/pull/14717#issuecomment-2632742313 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to

Re: [PR] KAFKA-16102: fix the dynamic modification of listeners' IP or port no… [kafka]

2025-02-03 Thread via GitHub
github-actions[bot] closed pull request #15321: KAFKA-16102: fix the dynamic modification of listeners' IP or port no… URL: https://github.com/apache/kafka/pull/15321 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] IGNORE: Test PR for KAFKA-15062 [kafka]

2025-02-03 Thread via GitHub
github-actions[bot] closed pull request #14717: IGNORE: Test PR for KAFKA-15062 URL: https://github.com/apache/kafka/pull/14717 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] (Draft) Run new tests separately in PRs [kafka]

2025-02-03 Thread via GitHub
chia7712 commented on PR #18770: URL: https://github.com/apache/kafka/pull/18770#issuecomment-2632790573 > I think that could be done separately from this PR yes, that can be a follow-up Additionally, could you please check the license of `AutoRepeatTestExtension.java` and plea

Re: [PR] KAFKA-18530 Remove ZooKeeperInternals [kafka]

2025-02-03 Thread via GitHub
chia7712 commented on code in PR #18641: URL: https://github.com/apache/kafka/pull/18641#discussion_r1940475710 ## core/src/main/scala/kafka/server/DynamicBrokerConfig.scala: ## @@ -48,13 +48,6 @@ import scala.collection._ import scala.jdk.CollectionConverters._ /** - * Dyn

Re: [PR] MINOR: update Kafka Streams `Topology` JavaDocs [kafka]

2025-02-03 Thread via GitHub
bbejeck commented on code in PR #18778: URL: https://github.com/apache/kafka/pull/18778#discussion_r1940199139 ## streams/src/main/java/org/apache/kafka/streams/Topology.java: ## @@ -662,87 +418,30 @@ public synchronized Topology addSink(final String name, } /** -

[jira] [Commented] (KAFKA-17345) X

2025-02-03 Thread Ukpa Uchechi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17923551#comment-17923551 ] Ukpa Uchechi commented on KAFKA-17345: -- oh sorry, I didn't see the security tag the

[jira] [Comment Edited] (KAFKA-17345) X

2025-02-03 Thread Ukpa Uchechi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17923298#comment-17923298 ] Ukpa Uchechi edited comment on KAFKA-17345 at 2/4/25 3:49 AM:

Re: [PR] KAFKA-17182: Consumer fetch sessions are evicted too quickly with AsyncKafkaConsumer [kafka]

2025-02-03 Thread via GitHub
kirktrue commented on PR #18795: URL: https://github.com/apache/kafka/pull/18795#issuecomment-2632512270 @jeffkbkim @junrao @lianetm-this is the second attempt at fixing the fix session eviction bug (#17700). I've highlight the differences between the two PRs. It really boils down to the ad

Re: [PR] KAFKA-17182: Consumer fetch sessions are evicted too quickly with AsyncKafkaConsumer [kafka]

2025-02-03 Thread via GitHub
kirktrue commented on code in PR #18795: URL: https://github.com/apache/kafka/pull/18795#discussion_r1940329129 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractFetch.java: ## @@ -408,22 +407,52 @@ protected Map prepareFetchRequests() long c

[PR] KAFKA-18691: Flaky test testFencingOnTransactionExpiration [kafka]

2025-02-03 Thread via GitHub
jolshan opened a new pull request, #18793: URL: https://github.com/apache/kafka/pull/18793 It appears this test was failing because the transaction was never aborting and the concurrent transactions errors would not go away. https://github.com/apache/kafka/commit/ccab9eb8b4781eb4b8e

Re: [PR] KAFKA-18654 [1/2]: Transaction Version 2 performance regression due to early return [kafka]

2025-02-03 Thread via GitHub
jolshan merged PR #18720: URL: https://github.com/apache/kafka/pull/18720 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

Re: [PR] KAFKA-18705: Move ConfigRepository to metadata module [kafka]

2025-02-03 Thread via GitHub
FrankYang0529 commented on code in PR #18784: URL: https://github.com/apache/kafka/pull/18784#discussion_r1940340298 ## metadata/src/test/java/org/apache/kafka/metadata/MockConfigRepository.java: ## @@ -0,0 +1,67 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] KAFKA-17379: Fix inexpected state transition from ERROR to PENDING_SHUTDOWN [kafka]

2025-02-03 Thread via GitHub
mjsax commented on code in PR #18765: URL: https://github.com/apache/kafka/pull/18765#discussion_r1940327370 ## streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java: ## @@ -1543,38 +1547,30 @@ private boolean close(final Optional timeout, final boolean leaveGroup) {

[jira] [Commented] (KAFKA-18168) GlobalKTable does not checkpoint restored offsets until next 10K events

2025-02-03 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17923475#comment-17923475 ] Matthias J. Sax commented on KAFKA-18168: - Yeah I know... It's in our review bac

[jira] [Created] (KAFKA-18723) KRaft must handle corrupted records in the fetch response

2025-02-03 Thread Jira
José Armando García Sancio created KAFKA-18723: -- Summary: KRaft must handle corrupted records in the fetch response Key: KAFKA-18723 URL: https://issues.apache.org/jira/browse/KAFKA-18723

Re: [PR] KAFKA-18209 Cleanup `__transaction_state` config logic [kafka]

2025-02-03 Thread via GitHub
mimaison commented on code in PR #18201: URL: https://github.com/apache/kafka/pull/18201#discussion_r1940016513 ## core/src/main/scala/kafka/coordinator/transaction/TransactionStateManager.scala: ## @@ -37,14 +38,17 @@ import org.apache.kafka.common.{KafkaException, TopicPartit

Re: [PR] KAFKA-18538: Add Streams membership manager [kafka]

2025-02-03 Thread via GitHub
bbejeck commented on code in PR #18551: URL: https://github.com/apache/kafka/pull/18551#discussion_r1940245490 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/StreamsMembershipManager.java: ## @@ -0,0 +1,1284 @@ +/* + * Licensed to the Apache Software Founda

Re: [PR] KAFKA-18654: Transaction Version 2 performance regression due to early return [kafka]

2025-02-03 Thread via GitHub
jolshan commented on PR #18720: URL: https://github.com/apache/kafka/pull/18720#issuecomment-2632380819 > Can we add a bit more information as to what is the nature of the perf regression? And the PR description indicates that we are planning to add a producer bench result? I will ad

Re: [PR] MINOR: cleanup KStream JavaDocs (4/N) - stream-table-inner-join [kafka]

2025-02-03 Thread via GitHub
mjsax merged PR #18721: URL: https://github.com/apache/kafka/pull/18721 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

Re: [PR] MINOR: Session windows should accept zero as session gap [kafka]

2025-02-03 Thread via GitHub
mjsax merged PR #18734: URL: https://github.com/apache/kafka/pull/18734 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

Re: [PR] MINOR: fix NPE in KS `Topology` for new `AutoOffsetReset` [kafka]

2025-02-03 Thread via GitHub
mjsax commented on PR #18780: URL: https://github.com/apache/kafka/pull/18780#issuecomment-2632569081 Merged to `trunk` and cherry-picked to `4.0` branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

Re: [PR] KAFKA-18209 Cleanup `__transaction_state` config logic [kafka]

2025-02-03 Thread via GitHub
wernerdv commented on code in PR #18201: URL: https://github.com/apache/kafka/pull/18201#discussion_r1939992923 ## core/src/main/scala/kafka/coordinator/transaction/TransactionStateManager.scala: ## @@ -45,6 +46,15 @@ import org.apache.kafka.storage.internals.log.AppendOrigin i

Re: [PR] KAFKA-18538: Add Streams membership manager [kafka]

2025-02-03 Thread via GitHub
cadonna commented on PR #18551: URL: https://github.com/apache/kafka/pull/18551#issuecomment-2632069474 > Thanks for the updates @cadonna. Just nits. Any fixes to port from the last changes to consumer/abstract membership manager? Thanks a lot for this comment, @lucasbru ! I indeed fo

  1   2   3   >