[jira] [Commented] (KAFKA-16719) Add AdminClient.deleteShareGroups

2025-01-22 Thread Jimmy Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17915995#comment-17915995 ] Jimmy Wang commented on KAFKA-16719: Hi [~schofielaj] , can I pick this issue? > Ad

Re: [PR] KAFKA-18533: Remove KafkaConfig zookeeper related logic [kafka]

2025-01-22 Thread via GitHub
ijuma commented on code in PR #18547: URL: https://github.com/apache/kafka/pull/18547#discussion_r1925448634 ## core/src/main/scala/kafka/server/KafkaConfig.scala: ## @@ -734,7 +723,7 @@ class KafkaConfig private(doLog: Boolean, val props: util.Map[_, _]) val listenerNam

Re: [PR] KAFKA-18592: Cleanup ReplicaManager [kafka]

2025-01-22 Thread via GitHub
ijuma commented on code in PR #18621: URL: https://github.com/apache/kafka/pull/18621#discussion_r1925445020 ## docs/zk2kraft.html: ## @@ -176,5 +176,14 @@ Removal metrics Kafka remove all zookeeper dependencies, so the metrics is removed.

Re: [PR] MINOR: fix `LogCleanerManagerTest.testLogsUnderCleanupIneligibleForCompaction()` for `Defaults.LogMessageTimestampType = "LogAppendTime"` [kafka]

2025-01-22 Thread via GitHub
divijvaidya commented on PR #12333: URL: https://github.com/apache/kafka/pull/12333#issuecomment-2607440088 Yes @ijuma , I will take a look at this today -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] KAFKA-18555: Avoid casting MetadataCache to KRaftMetadataCache [kafka]

2025-01-22 Thread via GitHub
ijuma commented on code in PR #18632: URL: https://github.com/apache/kafka/pull/18632#discussion_r1925424534 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -113,11 +113,8 @@ class KafkaApis(val requestChannel: RequestChannel, val requestHelper = new RequestHandler

Re: [PR] KAFKA-18229: Move configs out of "kraft" directory [kafka]

2025-01-22 Thread via GitHub
mimaison merged PR #18389: URL: https://github.com/apache/kafka/pull/18389 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-18599: Remove Optional wrapping for forwardingManager in ApiVersionManager [kafka]

2025-01-22 Thread via GitHub
ijuma merged PR #18630: URL: https://github.com/apache/kafka/pull/18630 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

[jira] [Resolved] (KAFKA-18599) Remove optional ForwardingManager in ApiVersionManager

2025-01-22 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18599?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma resolved KAFKA-18599. - Resolution: Fixed > Remove optional ForwardingManager in ApiVersionManager > ---

[jira] [Updated] (KAFKA-18599) Remove optional ForwardingManager in ApiVersionManager

2025-01-22 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18599?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-18599: Fix Version/s: 4.1.0 > Remove optional ForwardingManager in ApiVersionManager > --

Re: [PR] KAFKA-18592: Cleanup ReplicaManager [kafka]

2025-01-22 Thread via GitHub
frankvicky commented on code in PR #18621: URL: https://github.com/apache/kafka/pull/18621#discussion_r1925459281 ## core/src/main/scala/kafka/cluster/Partition.scala: ## @@ -1635,24 +1635,6 @@ class Partition(val topicPartition: TopicPartition, localLog.fetchOffsetSnapshot

[jira] [Created] (KAFKA-18619) New consumer topic metadata events should set requireMetadata flag

2025-01-22 Thread Lianet Magrans (Jira)
Lianet Magrans created KAFKA-18619: -- Summary: New consumer topic metadata events should set requireMetadata flag Key: KAFKA-18619 URL: https://issues.apache.org/jira/browse/KAFKA-18619 Project: Kafka

[jira] [Commented] (KAFKA-18527) SaslClientsWithInvalidCredentialsTest.java and SaslClientsWithInvalidCredentialsTest.scala should run for async consumer

2025-01-22 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17916074#comment-17916074 ] Lianet Magrans commented on KAFKA-18527: Hey, looking into it I found a bug htt

[jira] [Resolved] (KAFKA-18229) Move configs out of "kraft" directory

2025-01-22 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison resolved KAFKA-18229. Resolution: Fixed > Move configs out of "kraft" directory > --

Re: [PR] KAFKA-18229: Move configs out of "kraft" directory [kafka]

2025-01-22 Thread via GitHub
mimaison commented on PR #18389: URL: https://github.com/apache/kafka/pull/18389#issuecomment-2607475721 Applied to 4.0 too: https://github.com/apache/kafka/commit/ac87155ba46d3135256ea00c34e80df3e00c4575 -- This is an automated message from the Apache Git Service. To respond to the messa

Re: [PR] KAFKA-18592: Cleanup ReplicaManager [kafka]

2025-01-22 Thread via GitHub
frankvicky commented on code in PR #18621: URL: https://github.com/apache/kafka/pull/18621#discussion_r1925470433 ## docs/zk2kraft.html: ## @@ -176,5 +176,14 @@ Removal metrics Kafka remove all zookeeper dependencies, so the metrics is removed.

[jira] [Commented] (KAFKA-18619) New consumer topic metadata events should set requireMetadata flag

2025-01-22 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17916075#comment-17916075 ] Lianet Magrans commented on KAFKA-18619: Hey [~frankvicky] , I believe this is w

[jira] [Assigned] (KAFKA-18619) New consumer topic metadata events should set requireMetadata flag

2025-01-22 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lianet Magrans reassigned KAFKA-18619: -- Assignee: TengYao Chi > New consumer topic metadata events should set requireMetadata

[jira] [Created] (KAFKA-18620) Remove UnifiedLog#legacyFetchOffsetsBefore

2025-01-22 Thread TengYao Chi (Jira)
TengYao Chi created KAFKA-18620: --- Summary: Remove UnifiedLog#legacyFetchOffsetsBefore Key: KAFKA-18620 URL: https://issues.apache.org/jira/browse/KAFKA-18620 Project: Kafka Issue Type: Sub-task

[jira] [Updated] (KAFKA-18619) New consumer topic metadata events should set requireMetadata flag

2025-01-22 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lianet Magrans updated KAFKA-18619: --- Description: In the new asyn consumer, application events that require topic metadata should

[jira] [Commented] (KAFKA-18619) New consumer topic metadata events should set requireMetadata flag

2025-01-22 Thread TengYao Chi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17916077#comment-17916077 ] TengYao Chi commented on KAFKA-18619: - Hi [~lianetm]  Thanks for the information. I

[jira] [Updated] (KAFKA-18611) Update MV to enable transaction version 2 by default for 4.0

2025-01-22 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot updated KAFKA-18611: Fix Version/s: 4.0.0 > Update MV to enable transaction version 2 by default for 4.0 >

Re: [PR] KAFKA-18527: SaslClientsWithInvalidCredentialsTest.java should run for async consumer [kafka]

2025-01-22 Thread via GitHub
frankvicky commented on code in PR #18609: URL: https://github.com/apache/kafka/pull/18609#discussion_r1925314542 ## tools/src/test/java/org/apache/kafka/tools/consumer/group/SaslClientsWithInvalidCredentialsTest.java: ## @@ -149,7 +149,7 @@ public void testConsumerGroupService

Re: [PR] KAFKA-18484 [1/N]; Handle exceptions from deferred events in coordinator [kafka]

2025-01-22 Thread via GitHub
dajac merged PR #18661: URL: https://github.com/apache/kafka/pull/18661 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

Re: [PR] KAFKA-18484 [1/N]; Handle exceptions from deferred events in coordinator [kafka]

2025-01-22 Thread via GitHub
dajac commented on PR #18661: URL: https://github.com/apache/kafka/pull/18661#issuecomment-2607297343 Merged to trunk and 4.0. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

Re: [PR] MINOR: add the removed topic metrics to zk2kraft [kafka]

2025-01-22 Thread via GitHub
clolov commented on code in PR #18658: URL: https://github.com/apache/kafka/pull/18658#discussion_r1925366015 ## docs/zk2kraft.html: ## @@ -176,5 +176,16 @@ Removal metrics Kafka remove all zookeeper dependencies, so the metrics is removed.

[jira] [Created] (KAFKA-18621) Add StreamsCoordinatorRecordHelpers

2025-01-22 Thread Lucas Brutschy (Jira)
Lucas Brutschy created KAFKA-18621: -- Summary: Add StreamsCoordinatorRecordHelpers Key: KAFKA-18621 URL: https://issues.apache.org/jira/browse/KAFKA-18621 Project: Kafka Issue Type: Sub-task

[PR] KAFKA-18621: Add StreamsCoordinatorRecordHelpers [kafka]

2025-01-22 Thread via GitHub
lucasbru opened a new pull request, #18669: URL: https://github.com/apache/kafka/pull/18669 A class with helper methods to create records stored in the __consumer_offsets topic. Compared to the feature branch, I added unit tests (most functions were not tested) and adopted the new in

Re: [PR] KAFKA-18517: Enable ConsumerBounceTest to run for new async consumer [kafka]

2025-01-22 Thread via GitHub
lianetm commented on code in PR #18532: URL: https://github.com/apache/kafka/pull/18532#discussion_r1925611447 ## core/src/test/scala/integration/kafka/api/ConsumerBounceTest.scala: ## @@ -319,17 +327,20 @@ class ConsumerBounceTest extends AbstractConsumerTest with Logging {

Re: [PR] KAFKA-18324: Add CurrentAssignmentBuilder [kafka]

2025-01-22 Thread via GitHub
cadonna commented on code in PR #18476: URL: https://github.com/apache/kafka/pull/18476#discussion_r1925612798 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/streams/CurrentAssignmentBuilderTest.java: ## @@ -0,0 +1,744 @@ +/* + * Licensed to the Apache Sof

Re: [PR] KAFKA-18488: Additional protocol tests for share consumption [kafka]

2025-01-22 Thread via GitHub
lianetm commented on code in PR #18601: URL: https://github.com/apache/kafka/pull/18601#discussion_r1925525533 ## clients/src/test/java/org/apache/kafka/clients/consumer/KafkaShareConsumerTest.java: ## @@ -0,0 +1,342 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

Re: [PR] Cherry-pick KAFKA-18583 fix (#18635) to 3.9 [kafka]

2025-01-22 Thread via GitHub
dimitarndimitrov commented on code in PR #18657: URL: https://github.com/apache/kafka/pull/18657#discussion_r1925019540 ## core/src/test/scala/unit/kafka/server/MetadataCacheTest.scala: ## @@ -645,6 +646,114 @@ class MetadataCacheTest { assertEquals(Seq(expectedNode1), part

[jira] [Commented] (KAFKA-17853) Console share consumer is not terminated immediately

2025-01-22 Thread Apoorv Mittal (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17915991#comment-17915991 ] Apoorv Mittal commented on KAFKA-17853: --- [~jimmywang611] Thanks for looking into i

Re: [PR] KAFKA-18569: New consumer close may wait on unneeded FindCoordinator [kafka]

2025-01-22 Thread via GitHub
frankvicky commented on PR #18590: URL: https://github.com/apache/kafka/pull/18590#issuecomment-2607580841 Hi @kirktrue, Thanks for the review. It's tricky to have `NetworkClientDelegate` ignore the `FindCoordinatorRequest` since the request is stored in `NetworkClient#inFlightReq

[jira] [Commented] (KAFKA-15402) Performance regression on close consumer after upgrading to 3.5.0

2025-01-22 Thread Benoit Delbosc (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17916037#comment-17916037 ] Benoit Delbosc commented on KAFKA-15402: Hi David, thanks for your response, I

[jira] [Comment Edited] (KAFKA-15402) Performance regression on close consumer after upgrading to 3.5.0

2025-01-22 Thread Benoit Delbosc (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17916037#comment-17916037 ] Benoit Delbosc edited comment on KAFKA-15402 at 1/22/25 12:15 PM:

[jira] [Comment Edited] (KAFKA-15402) Performance regression on close consumer after upgrading to 3.5.0

2025-01-22 Thread Benoit Delbosc (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17916037#comment-17916037 ] Benoit Delbosc edited comment on KAFKA-15402 at 1/22/25 12:18 PM:

[PR] KAFKA-18619: New consumer topic metadata events should set requireMetadata flag [kafka]

2025-01-22 Thread via GitHub
frankvicky opened a new pull request, #18668: URL: https://github.com/apache/kafka/pull/18668 JIRA: KAFKA-18619 In short, the new async consumer's topic metadata operations are unwared of metadata errors because of not overriding `requireSubscriptionMetadata`. For further details, plea

Re: [PR] KAFKA-18519: Remove Json.scala, cleanup AclEntry.scala [kafka]

2025-01-22 Thread via GitHub
mimaison commented on PR #18614: URL: https://github.com/apache/kafka/pull/18614#issuecomment-2607544066 Applied to 4.0 too: https://github.com/apache/kafka/commit/7fc59b0ce96d83b287d299e3bd07e9dfede2ec1f -- This is an automated message from the Apache Git Service. To respond to the messa

[jira] [Resolved] (KAFKA-18519) Remove Json.scala , cleanup AclEntry.scala

2025-01-22 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison resolved KAFKA-18519. Fix Version/s: 4.0.0 Resolution: Fixed > Remove Json.scala , cleanup AclEntry.scala

Re: [PR] KAFKA-18619: New consumer topic metadata events should set requireMetadata flag [kafka]

2025-01-22 Thread via GitHub
frankvicky commented on PR #18668: URL: https://github.com/apache/kafka/pull/18668#issuecomment-2607551043 Hi @lianetm, I have enabled the `SaslClientsWithInvalidCredentialsTest.scala` for the new consumer with this patch. Most of the tests pass, except for `testConsumerWithAuthentic

[jira] [Updated] (KAFKA-18146) tests/kafkatest/tests/core/upgrade_test.py needs to be re-added as KRaft

2025-01-22 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot updated KAFKA-18146: Fix Version/s: 4.0.0 > tests/kafkatest/tests/core/upgrade_test.py needs to be re-added as KRaft >

[jira] [Updated] (KAFKA-18146) tests/kafkatest/tests/core/upgrade_test.py needs to be re-added as KRaft

2025-01-22 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot updated KAFKA-18146: Priority: Blocker (was: Major) > tests/kafkatest/tests/core/upgrade_test.py needs to be re-added

[jira] [Resolved] (KAFKA-17853) Console share consumer is not terminated immediately

2025-01-22 Thread Apoorv Mittal (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17853?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Mittal resolved KAFKA-17853. --- Resolution: Cannot Reproduce > Console share consumer is not terminated immediately > --

[jira] [Updated] (KAFKA-18620) Remove UnifiedLog#legacyFetchOffsetsBefore

2025-01-22 Thread TengYao Chi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18620?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] TengYao Chi updated KAFKA-18620: Description: See discussion: https://github.com/apache/kafka/pull/18621?notification_referrer_id=

Re: [PR] KAFKA-18519: Remove Json.scala, cleanup AclEntry.scala [kafka]

2025-01-22 Thread via GitHub
mimaison merged PR #18614: URL: https://github.com/apache/kafka/pull/18614 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Commented] (KAFKA-17853) Console share consumer is not terminated immediately

2025-01-22 Thread Jimmy Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17915988#comment-17915988 ] Jimmy Wang commented on KAFKA-17853: In the lastest trunk branch: !image-2025-01-22

[jira] (KAFKA-17853) Console share consumer is not terminated immediately

2025-01-22 Thread Jimmy Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17853 ] Jimmy Wang deleted comment on KAFKA-17853: was (Author: JIRAUSER300327): In the lastest trunk branch: !image-2025-01-22-17-43-23-902.png! > Console share consumer is not terminated immediat

Re: [PR] KAFKA-18484 [2/N]; Handle exceptions during coordinator unload [kafka]

2025-01-22 Thread via GitHub
dajac commented on PR #18667: URL: https://github.com/apache/kafka/pull/18667#issuecomment-2607370076 Should we still change this [line](https://github.com/apache/kafka/blob/32f0dbbbfd9aa079bfbaa21280563bf62b56a5f4/coordinator-common/src/main/java/org/apache/kafka/coordinator/common/runtime/

Re: [PR] KAFKA-18486; [1/2] Update LocalLeaderEndPointTest [kafka]

2025-01-22 Thread via GitHub
ijuma commented on code in PR #18666: URL: https://github.com/apache/kafka/pull/18666#discussion_r1925415870 ## core/src/test/scala/kafka/server/LocalLeaderEndPointTest.scala: ## @@ -106,12 +125,11 @@ class LocalLeaderEndPointTest extends Logging { .onFire(response => ass

Re: [PR] KAFKA-18474: Remove zkBroker tag [kafka]

2025-01-22 Thread via GitHub
ijuma commented on code in PR #18477: URL: https://github.com/apache/kafka/pull/18477#discussion_r1925409662 ## clients/src/test/java/org/apache/kafka/common/requests/ApiVersionsResponseTest.java: ## @@ -160,25 +160,24 @@ public void shouldNotCreateApiResponseWithTelemetryWhenD

Re: [PR] MINOR: fix `LogCleanerManagerTest.testLogsUnderCleanupIneligibleForCompaction()` for `Defaults.LogMessageTimestampType = "LogAppendTime"` [kafka]

2025-01-22 Thread via GitHub
ijuma commented on PR #12333: URL: https://github.com/apache/kafka/pull/12333#issuecomment-2607401941 @divijvaidya do you want to merge this PR? You had reviewed it previously. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

Re: [PR] KAFKA-18486; [1/2] Update LocalLeaderEndPointTest [kafka]

2025-01-22 Thread via GitHub
dajac commented on code in PR #18666: URL: https://github.com/apache/kafka/pull/18666#discussion_r1925424095 ## core/src/test/scala/kafka/server/LocalLeaderEndPointTest.scala: ## @@ -106,12 +125,11 @@ class LocalLeaderEndPointTest extends Logging { .onFire(response => ass

Re: [PR] KAFKA-18360: Remove zookeeper configurations [kafka]

2025-01-22 Thread via GitHub
ijuma commented on code in PR #18566: URL: https://github.com/apache/kafka/pull/18566#discussion_r1925435965 ## core/src/main/scala/kafka/server/KafkaConfig.scala: ## @@ -221,8 +213,6 @@ class KafkaConfig private(doLog: Boolean, val props: util.Map[_, _]) def quotaConfig: Qu

Re: [PR] KAFKA-18360: Remove zookeeper configurations [kafka]

2025-01-22 Thread via GitHub
ijuma commented on code in PR #18566: URL: https://github.com/apache/kafka/pull/18566#discussion_r1925435965 ## core/src/main/scala/kafka/server/KafkaConfig.scala: ## @@ -221,8 +213,6 @@ class KafkaConfig private(doLog: Boolean, val props: util.Map[_, _]) def quotaConfig: Qu

[jira] [Commented] (KAFKA-17853) Console share consumer is not terminated immediately

2025-01-22 Thread Jimmy Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17915985#comment-17915985 ] Jimmy Wang commented on KAFKA-17853: [~apoorvmittal10] It seems that the consumer wi

[PR] KAFKA-18486; [1/2] Update LocalLeaderEndPointTest [kafka]

2025-01-22 Thread via GitHub
dajac opened a new pull request, #18666: URL: https://github.com/apache/kafka/pull/18666 This patch is a first step towards removing `ReplicaManager#becomeLeaderOrFollower`. It updates the `LocalLeaderEndPointTest` tests. ### Committer Checklist (excluded from commit message) - [

[jira] [Resolved] (KAFKA-18598) Remove ControllerMetadataMetrics zk related Metrics

2025-01-22 Thread Christo Lolov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christo Lolov resolved KAFKA-18598. --- Resolution: Fixed The PR has been reviewed and merged both in trunk and in 4.0 > Remove Con

[PR] KAFKA-18484 [2/N]; Handle exceptions during coordinator unload [kafka]

2025-01-22 Thread via GitHub
squah-confluent opened a new pull request, #18667: URL: https://github.com/apache/kafka/pull/18667 Ensure that unloading a coordinator always succeeds. Previously, we have guarded against exceptions from DeferredEvent completions. All that remains is handling exceptions from the onUnloa

[jira] [Resolved] (KAFKA-18595) Remove AuthorizerUtils#sessionToRequestContext

2025-01-22 Thread Christo Lolov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christo Lolov resolved KAFKA-18595. --- Resolution: Fixed The PR has been reviewed and merged both in trunk and 4.0 > Remove Author

Re: [PR] KAFKA-18575: Transaction Version 2 doesn't correctly handle race condition with completing and new transaction [kafka]

2025-01-22 Thread via GitHub
jolshan commented on code in PR #18604: URL: https://github.com/apache/kafka/pull/18604#discussion_r1925643328 ## core/src/main/scala/kafka/log/UnifiedLog.scala: ## @@ -1052,7 +1057,7 @@ class UnifiedLog(@volatile var logStartOffset: Long, } private def batchMissingRequi

Re: [PR] MINOR: fix `LogCleanerManagerTest.testLogsUnderCleanupIneligibleForCompaction()` for `Defaults.LogMessageTimestampType = "LogAppendTime"` [kafka]

2025-01-22 Thread via GitHub
divijvaidya commented on PR #12333: URL: https://github.com/apache/kafka/pull/12333#issuecomment-2607750751 I am not running the CI on this PR since it will require author to rebase from trunk unnecessarily. Instead, I have made this single one line change locally on HEAD of trunk and verif

Re: [PR] MINOR: fix `LogCleanerManagerTest.testLogsUnderCleanupIneligibleForCompaction()` for `Defaults.LogMessageTimestampType = "LogAppendTime"` [kafka]

2025-01-22 Thread via GitHub
divijvaidya merged PR #12333: URL: https://github.com/apache/kafka/pull/12333 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apa

Re: [PR] KAFKA-18517: Enable ConsumerBounceTest to run for new async consumer [kafka]

2025-01-22 Thread via GitHub
lianetm commented on PR #18532: URL: https://github.com/apache/kafka/pull/18532#issuecomment-2607764071 > Any reason why testClose is not enabled too? The reason is the open bug https://issues.apache.org/jira/browse/KAFKA-18569 but good catch, that test wasn't explicitly called out in

Re: [PR] KAFKA-18575: Transaction Version 2 doesn't correctly handle race condition with completing and new transaction [kafka]

2025-01-22 Thread via GitHub
jeffkbkim commented on code in PR #18604: URL: https://github.com/apache/kafka/pull/18604#discussion_r1925769791 ## core/src/main/scala/kafka/log/UnifiedLog.scala: ## @@ -600,6 +600,11 @@ class UnifiedLog(@volatile var logStartOffset: Long, */ def hasOngoingTransaction(pr

Re: [PR] KAFKA-12249: KIP-500 - Add client-side Decommission Broker RPC [kafka]

2025-01-22 Thread via GitHub
Aatirhassanpir commented on PR #9996: URL: https://github.com/apache/kafka/pull/9996#issuecomment-2608039403 Title [FEATURE] Add client-side Decommission Broker RPC for KIP-500 Repository Version Apache Kafka 2.x.x Key Words / Search Terms Decommission Broker, RPC, KIP-

Re: [PR] KAFKA-17182: Consumer fetch sessions are evicted too quickly with AsyncKafkaConsumer [kafka]

2025-01-22 Thread via GitHub
junrao commented on code in PR #17700: URL: https://github.com/apache/kafka/pull/17700#discussion_r1925757185 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractFetch.java: ## @@ -456,6 +484,44 @@ protected Map prepareFetchRequests() return f

[jira] [Updated] (KAFKA-18395) Initialize KafkaRaftMetrics without QuorumState to prevent circularity

2025-01-22 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-18395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] José Armando García Sancio updated KAFKA-18395: --- Component/s: kraft > Initialize KafkaRaftMetrics without QuorumState

[PR] MINOR: prevent exception from HdrHistogram [kafka]

2025-01-22 Thread via GitHub
jeffkbkim opened a new pull request, #18674: URL: https://github.com/apache/kafka/pull/18674 HdrHistogram can throw an exception if the recorded value is greater than a configured limit. Expand the ceiling from per-metric to all invocations. Using [existing test](https://github.com/apache/

Re: [PR] KAFKA-18575: Transaction Version 2 doesn't correctly handle race condition with completing and new transaction [kafka]

2025-01-22 Thread via GitHub
jeffkbkim commented on code in PR #18604: URL: https://github.com/apache/kafka/pull/18604#discussion_r1925819493 ## core/src/main/scala/kafka/log/UnifiedLog.scala: ## @@ -600,6 +600,11 @@ class UnifiedLog(@volatile var logStartOffset: Long, */ def hasOngoingTransaction(pr

Re: [PR] [WIP]KAFKA-18034: CommitRequestManager should fail pending requests on fatal coordinator errors [kafka]

2025-01-22 Thread via GitHub
lianetm commented on code in PR #18548: URL: https://github.com/apache/kafka/pull/18548#discussion_r1925927331 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractHeartbeatRequestManager.java: ## @@ -263,6 +264,12 @@ public void resetPollTimer(final long

Re: [PR] KAFKA-18617 Allow use of ClusterInstance inside BeforeEach [kafka]

2025-01-22 Thread via GitHub
mumrah commented on PR #18662: URL: https://github.com/apache/kafka/pull/18662#issuecomment-2608493104 @cmccabe can you take a quick look at this one? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] KAFKA-18517: Enable ConsumerBounceTest to run for new async consumer [kafka]

2025-01-22 Thread via GitHub
lianetm merged PR #18532: URL: https://github.com/apache/kafka/pull/18532 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[jira] [Commented] (KAFKA-17351) Validate compacted topics start offset handling in Share Partition

2025-01-22 Thread Apoorv Mittal (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17916127#comment-17916127 ] Apoorv Mittal commented on KAFKA-17351: --- [~jimmywang611] Thanks for the help, this

[jira] [Assigned] (KAFKA-17942) Fix testAcknowledgementCommitCallbackInvalidRecordStateException

2025-01-22 Thread Apoorv Mittal (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17942?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Mittal reassigned KAFKA-17942: - Assignee: Jimmy Wang (was: Shivsundar R) > Fix testAcknowledgementCommitCallbackInvali

[PR] KAFKA-18572: Update Kafka Streams metric documenation [kafka]

2025-01-22 Thread via GitHub
ukpagrace opened a new pull request, #18673: URL: https://github.com/apache/kafka/pull/18673 Updated the Kafka Streams documentation to include metrics for tasks, process nodes, and threads that were missing. I was unable to find metrics such as stream-state-metrics, client-metrics, state-s

[jira] [Created] (KAFKA-18625) consumer client could get duplicated records if assigned partitions change quickly

2025-01-22 Thread Jun Rao (Jira)
Jun Rao created KAFKA-18625: --- Summary: consumer client could get duplicated records if assigned partitions change quickly Key: KAFKA-18625 URL: https://issues.apache.org/jira/browse/KAFKA-18625 Project: Kaf

Re: [PR] KAFKA-17182: Consumer fetch sessions are evicted too quickly with AsyncKafkaConsumer [kafka]

2025-01-22 Thread via GitHub
junrao commented on code in PR #17700: URL: https://github.com/apache/kafka/pull/17700#discussion_r1925868037 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractFetch.java: ## @@ -408,22 +407,44 @@ protected Map prepareFetchRequests() long cur

[jira] [Commented] (KAFKA-18625) consumer client could get duplicated records if assigned partitions change quickly

2025-01-22 Thread Jun Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17916172#comment-17916172 ] Jun Rao commented on KAFKA-18625: - [~hachikuji] : Do you think this is a real issue? Tha

Re: [PR] KAFKA-17587 Refactor test infrastructure [kafka]

2025-01-22 Thread via GitHub
mumrah commented on PR #18602: URL: https://github.com/apache/kafka/pull/18602#issuecomment-2608120440 @ijuma @chia7712 did you have any further comments on this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] KAFKA-16524: Metrics for KIP-853 [kafka]

2025-01-22 Thread via GitHub
jsancio commented on code in PR #18304: URL: https://github.com/apache/kafka/pull/18304#discussion_r1902195918 ## raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientTest.java: ## @@ -3842,6 +3842,7 @@ public void testMetrics(boolean withKip853Rpc) throws Exception {

Re: [PR] KAFKA-18575: Transaction Version 2 doesn't correctly handle race condition with completing and new transaction [kafka]

2025-01-22 Thread via GitHub
jolshan commented on code in PR #18604: URL: https://github.com/apache/kafka/pull/18604#discussion_r1925843856 ## core/src/main/scala/kafka/log/UnifiedLog.scala: ## @@ -600,6 +600,11 @@ class UnifiedLog(@volatile var logStartOffset: Long, */ def hasOngoingTransaction(prod

Re: [PR] KAFKA-18575: Transaction Version 2 doesn't correctly handle race condition with completing and new transaction [kafka]

2025-01-22 Thread via GitHub
jolshan commented on code in PR #18604: URL: https://github.com/apache/kafka/pull/18604#discussion_r1925843856 ## core/src/main/scala/kafka/log/UnifiedLog.scala: ## @@ -600,6 +600,11 @@ class UnifiedLog(@volatile var logStartOffset: Long, */ def hasOngoingTransaction(prod

[jira] [Created] (KAFKA-18624) Add validation for advertised listeners

2025-01-22 Thread Divij Vaidya (Jira)
Divij Vaidya created KAFKA-18624: Summary: Add validation for advertised listeners Key: KAFKA-18624 URL: https://issues.apache.org/jira/browse/KAFKA-18624 Project: Kafka Issue Type: Improveme

Re: [PR] KAFKA-9955: Prevent SinkTask::close from shadowing other exceptions [kafka]

2025-01-22 Thread via GitHub
Aatirhassanpir commented on PR #8618: URL: https://github.com/apache/kafka/pull/8618#issuecomment-2608080365 # Title: Kafka Consumer Lag When Processing Large Messages ## Repository Version: 2.8.0 ## Key Words / Search Terms Kafka, consumer lag, large messages, message

[jira] [Assigned] (KAFKA-16717) Add AdminClient.alterShareGroupOffsets

2025-01-22 Thread Jimmy Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16717?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jimmy Wang reassigned KAFKA-16717: -- Assignee: Jimmy Wang (was: Andrew Schofield) > Add AdminClient.alterShareGroupOffsets >

[PR] KAFKA-18618: Improve leader change handling of acknowledgements [kafka]

2025-01-22 Thread via GitHub
AndrewJSchofield opened a new pull request, #18672: URL: https://github.com/apache/kafka/pull/18672 There is a problem in the share consumer where records fetched from node A might be acknowledged with node B, if node B used to be the leader of the topic-partition and A becomes unavailable.

[jira] [Commented] (KAFKA-17351) Validate compacted topics start offset handling in Share Partition

2025-01-22 Thread Jimmy Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17916128#comment-17916128 ] Jimmy Wang commented on KAFKA-17351: [~apoorvmittal10] Sure! If you might have any s

[jira] [Commented] (KAFKA-18517) ConsumerBounceTest should run for async consumer

2025-01-22 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17916120#comment-17916120 ] Lianet Magrans commented on KAFKA-18517: Merged to trunk and cherry-picked to 4.

[jira] [Commented] (KAFKA-17351) Validate compacted topics start offset handling in Share Partition

2025-01-22 Thread Apoorv Mittal (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17916129#comment-17916129 ] Apoorv Mittal commented on KAFKA-17351: --- [~jimmywang611] Do you want to pick any o

Re: [PR] KAFKA-16524: Metrics for KIP-853 [kafka]

2025-01-22 Thread via GitHub
kevin-wu24 commented on code in PR #18304: URL: https://github.com/apache/kafka/pull/18304#discussion_r1926140480 ## raft/src/main/java/org/apache/kafka/raft/internals/KRaftControlRecordStateMachine.java: ## @@ -87,14 +91,21 @@ public KRaftControlRecordStateMachine( Rec

Re: [PR] KAFKA-16524: Metrics for KIP-853 [kafka]

2025-01-22 Thread via GitHub
kevin-wu24 commented on code in PR #18304: URL: https://github.com/apache/kafka/pull/18304#discussion_r1926140480 ## raft/src/main/java/org/apache/kafka/raft/internals/KRaftControlRecordStateMachine.java: ## @@ -87,14 +91,21 @@ public KRaftControlRecordStateMachine( Rec

[jira] [Commented] (KAFKA-18625) consumer client could get duplicated records if assigned partitions change quickly

2025-01-22 Thread Jun Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17916232#comment-17916232 ] Jun Rao commented on KAFKA-18625: - [~frankvicky] : Thanks for your interest. Feel free t

[jira] [Commented] (KAFKA-17942) Fix testAcknowledgementCommitCallbackInvalidRecordStateException

2025-01-22 Thread Jimmy Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17916225#comment-17916225 ] Jimmy Wang commented on KAFKA-17942: Hi [~apoorvmittal10], do you have any ideas for

Re: [PR] KAFKA-18619: New consumer topic metadata events should set requireMetadata flag [kafka]

2025-01-22 Thread via GitHub
frankvicky commented on code in PR #18668: URL: https://github.com/apache/kafka/pull/18668#discussion_r1926153407 ## core/src/test/scala/integration/kafka/api/SaslClientsWithInvalidCredentialsTest.scala: ## @@ -222,6 +222,18 @@ class SaslClientsWithInvalidCredentialsTest extends

Re: [PR] KAFKA-18619: New consumer topic metadata events should set requireMetadata flag [kafka]

2025-01-22 Thread via GitHub
frankvicky commented on code in PR #18668: URL: https://github.com/apache/kafka/pull/18668#discussion_r1926153407 ## core/src/test/scala/integration/kafka/api/SaslClientsWithInvalidCredentialsTest.scala: ## @@ -222,6 +222,18 @@ class SaslClientsWithInvalidCredentialsTest extends

[jira] [Assigned] (KAFKA-18625) consumer client could get duplicated records if assigned partitions change quickly

2025-01-22 Thread TengYao Chi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] TengYao Chi reassigned KAFKA-18625: --- Assignee: TengYao Chi > consumer client could get duplicated records if assigned partitions

[jira] [Commented] (KAFKA-8202) StackOverflowError on producer when splitting batches

2025-01-22 Thread Luke Kirby (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17916235#comment-17916235 ] Luke Kirby commented on KAFKA-8202: --- Following the PR trail there, it appears that ther

Re: [PR] KAFKA-10532: Handle state updater failed tasks [kafka]

2025-01-22 Thread via GitHub
ableegoldman commented on code in PR #17761: URL: https://github.com/apache/kafka/pull/17761#discussion_r1926229352 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -731,15 +732,20 @@ private void addToTasksToClose(final Map tasksToC

Re: [PR] [DO NOT MERGE -- WIP] KAFKA-13722: remove usage of old ProcessorContext [kafka]

2025-01-22 Thread via GitHub
bbejeck commented on code in PR #18292: URL: https://github.com/apache/kafka/pull/18292#discussion_r1925933969 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorNode.java: ## @@ -209,13 +209,14 @@ public void process(final Record record) {

Re: [PR] KAFKA-18488: Additional protocol tests for share consumption [kafka]

2025-01-22 Thread via GitHub
AndrewJSchofield commented on code in PR #18601: URL: https://github.com/apache/kafka/pull/18601#discussion_r1925981744 ## clients/src/test/java/org/apache/kafka/clients/consumer/KafkaShareConsumerTest.java: ## @@ -0,0 +1,342 @@ +/* + * Licensed to the Apache Software Foundation

  1   2   >