frankvicky commented on code in PR #18621:
URL: https://github.com/apache/kafka/pull/18621#discussion_r1925459281
##########
core/src/main/scala/kafka/cluster/Partition.scala:
##########
@@ -1635,24 +1635,6 @@ class Partition(val topicPartition: TopicPartition,
localLog.fetchOffsetSnapshot
}
- def legacyFetchOffsetsForTimestamp(timestamp: Long,
- maxNumOffsets: Int,
- isFromConsumer: Boolean,
- fetchOnlyFromLeader: Boolean): Seq[Long]
= inReadLock(leaderIsrUpdateLock) {
- val localLog = localLogWithEpochOrThrow(Optional.empty(),
fetchOnlyFromLeader)
- val allOffsets = localLog.legacyFetchOffsetsBefore(timestamp,
maxNumOffsets)
Review Comment:
You are right.
If this PR gets merged, this method would only be invoked in tests.
I will file a JIRA for this one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
