apoorvmittal10 commented on code in PR #18571:
URL: https://github.com/apache/kafka/pull/18571#discussion_r1918186242
##
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java:
##
@@ -3796,6 +3796,13 @@ public DescribeShareGroupsResult
describeShareGroups(fi
chia7712 commented on code in PR #18508:
URL: https://github.com/apache/kafka/pull/18508#discussion_r1918279278
##
core/src/main/scala/kafka/server/DynamicBrokerConfig.scala:
##
@@ -900,7 +881,6 @@ object DynamicListenerConfig {
*/
val ReconfigurableConfigs = Set(
//
FrankYang0529 commented on code in PR #18508:
URL: https://github.com/apache/kafka/pull/18508#discussion_r1918281528
##
core/src/main/scala/kafka/server/DynamicBrokerConfig.scala:
##
@@ -900,7 +881,6 @@ object DynamicListenerConfig {
*/
val ReconfigurableConfigs = Set(
chia7712 merged PR #18508:
URL: https://github.com/apache/kafka/pull/18508
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
FrankYang0529 commented on PR #18414:
URL: https://github.com/apache/kafka/pull/18414#issuecomment-2594769953
Thanks for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comme
TengYao Chi created KAFKA-18565:
---
Summary: Cleanup SaslSetup
Key: KAFKA-18565
URL: https://issues.apache.org/jira/browse/KAFKA-18565
Project: Kafka
Issue Type: Sub-task
Reporter: Te
[
https://issues.apache.org/jira/browse/KAFKA-17244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17913623#comment-17913623
]
Junho, Kim commented on KAFKA-17244:
Hi, everyone.
Are there any updates?
My API se
divijvaidya commented on code in PR #18140:
URL: https://github.com/apache/kafka/pull/18140#discussion_r1918156206
##
core/src/test/java/kafka/admin/DeleteTopicTest.java:
##
@@ -239,7 +239,7 @@ public void testDeleteNonExistingTopic(ClusterInstance
cluster) throws Exception
showuon commented on PR #18165:
URL: https://github.com/apache/kafka/pull/18165#issuecomment-2595073407
@chia7712 @cmccabe , could you help take a look? Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
AndrewJSchofield commented on code in PR #18562:
URL: https://github.com/apache/kafka/pull/18562#discussion_r1918162932
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/ShareConsumeRequestManagerTest.java:
##
@@ -881,6 +889,116 @@ public void testShareFetchWi
m1a2st opened a new pull request, #18574:
URL: https://github.com/apache/kafka/pull/18574
Jira: https://issues.apache.org/jira/browse/KAFKA-18407
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build
jayteej commented on code in PR #18140:
URL: https://github.com/apache/kafka/pull/18140#discussion_r1918186537
##
core/src/test/java/kafka/admin/DeleteTopicTest.java:
##
@@ -239,7 +239,7 @@ public void testDeleteNonExistingTopic(ClusterInstance
cluster) throws Exception
@C
FrankYang0529 opened a new pull request, #18573:
URL: https://github.com/apache/kafka/pull/18573
Remove KafkaController and related unused references:
* ControllerChannelContext
* ControllerChannelManager
* ControllerEventManager
* ControllerState
* PartitionStateMachine
ShivsundarR commented on code in PR #18562:
URL: https://github.com/apache/kafka/pull/18562#discussion_r1918191044
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/ShareConsumeRequestManagerTest.java:
##
@@ -881,6 +889,116 @@ public void testShareFetchWithSub
ShivsundarR commented on code in PR #18562:
URL: https://github.com/apache/kafka/pull/18562#discussion_r1918191601
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/ShareConsumeRequestManagerTest.java:
##
@@ -881,6 +889,116 @@ public void testShareFetchWithSub
[
https://issues.apache.org/jira/browse/KAFKA-18407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
黃竣陽 updated KAFKA-18407:
Summary: Remove ZkAdminManager, DelayedCreatePartitions,
CreatePartitionsMetadata, ZkConfigRepository, DelayedDele
[
https://issues.apache.org/jira/browse/KAFKA-18473?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
黃竣陽 resolved KAFKA-18473.
-
Resolution: Won't Fix
merge into KAFKA-18407
> Remove DelayedDeleteTopics
> --
>
>
mlowicki created KAFKA-18566:
Summary: Document behaviour on committing metadata with invalid
UTF-8 sequence
Key: KAFKA-18566
URL: https://issues.apache.org/jira/browse/KAFKA-18566
Project: Kafka
mimaison merged PR #18523:
URL: https://github.com/apache/kafka/pull/18523
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
cadonna commented on PR #18565:
URL: https://github.com/apache/kafka/pull/18565#issuecomment-2594939036
Thanks @FrankYang0529 for the ticket!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
[
https://issues.apache.org/jira/browse/KAFKA-18546?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bruno Cadonna reassigned KAFKA-18546:
-
Assignee: Bruno Cadonna
> Change ClientUtilsTest#testParseAndValidateAddressesWithRever
[
https://issues.apache.org/jira/browse/KAFKA-18405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai resolved KAFKA-18405.
Fix Version/s: 4.0.0
Resolution: Fixed
trunk:
[https://github.com/apache/kafka/com
chia7712 merged PR #18561:
URL: https://github.com/apache/kafka/pull/18561
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
frankvicky commented on PR #18545:
URL: https://github.com/apache/kafka/pull/18545#issuecomment-2595281208
Hi @AndrewJSchofield
I think we need to backport this patch to 4.0.
WDYT ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
[
https://issues.apache.org/jira/browse/KAFKA-18406?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai resolved KAFKA-18406.
Fix Version/s: 4.0.0
Resolution: Fixed
trunk:
[https://github.com/apache/kafka/com
chia7712 commented on code in PR #18490:
URL: https://github.com/apache/kafka/pull/18490#discussion_r1918297205
##
streams/src/test/java/org/apache/kafka/streams/state/internals/RocksDBTimeOrderedKeyValueBufferTest.java:
##
@@ -62,18 +62,16 @@ public class RocksDBTimeOrderedKeyV
jkt628 commented on PR #16492:
URL: https://github.com/apache/kafka/pull/16492#issuecomment-2595302088
unstale
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscrib
chia7712 merged PR #18552:
URL: https://github.com/apache/kafka/pull/18552
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
chia7712 commented on PR #18552:
URL: https://github.com/apache/kafka/pull/18552#issuecomment-2595312432
the failed test is traced by https://issues.apache.org/jira/browse/KAFKA-4184
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
[
https://issues.apache.org/jira/browse/KAFKA-16338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17913693#comment-17913693
]
Ukpa Uchechi commented on KAFKA-16338:
--
Hi [~mjsax] , I would like to work on this.
[
https://issues.apache.org/jira/browse/KAFKA-16338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ukpa Uchechi reassigned KAFKA-16338:
Assignee: Ukpa Uchechi
> Removed Deprecated configs from StreamsConfig
>
[
https://issues.apache.org/jira/browse/KAFKA-18542?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai resolved KAFKA-18542.
Fix Version/s: 4.0.0
Resolution: Fixed
trunk:
[https://github.com/apache/kafka/com
FrankYang0529 opened a new pull request, #18575:
URL: https://github.com/apache/kafka/pull/18575
Followup: https://github.com/apache/kafka/pull/18508#discussion_r1918279278
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify
m1a2st commented on code in PR #18554:
URL: https://github.com/apache/kafka/pull/18554#discussion_r1918331389
##
core/src/test/scala/integration/kafka/api/ConsumerRebootstrapTest.scala:
##
@@ -135,12 +135,13 @@ object ConsumerRebootstrapTest {
final val RebootstrapTestName
[
https://issues.apache.org/jira/browse/KAFKA-18287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17913706#comment-17913706
]
Alieh Saeedi commented on KAFKA-18287:
--
BLOCKED for now!
> Add support for kafka-s
squah-confluent commented on code in PR #18499:
URL: https://github.com/apache/kafka/pull/18499#discussion_r1918412113
##
coordinator-common/src/main/java/org/apache/kafka/coordinator/common/runtime/CoordinatorRuntime.java:
##
@@ -670,23 +671,30 @@ private void transitionTo(
squah-confluent commented on code in PR #18499:
URL: https://github.com/apache/kafka/pull/18499#discussion_r1918419791
##
coordinator-common/src/main/java/org/apache/kafka/coordinator/common/runtime/CoordinatorRuntime.java:
##
@@ -670,23 +671,30 @@ private void transitionTo(
TaiJuWu commented on code in PR #18389:
URL: https://github.com/apache/kafka/pull/18389#discussion_r1918483228
##
docker/docker_official_images/3.7.0/jvm/Dockerfile:
##
@@ -78,7 +78,7 @@ RUN set -eux ; \
chmod -R ug+w /etc/kafka /var/lib/kafka /etc/kafka/secrets; \
cp
frankvicky commented on code in PR #18389:
URL: https://github.com/apache/kafka/pull/18389#discussion_r1918491119
##
docker/docker_official_images/3.7.0/jvm/Dockerfile:
##
@@ -78,7 +78,7 @@ RUN set -eux ; \
chmod -R ug+w /etc/kafka /var/lib/kafka /etc/kafka/secrets; \
sjhajharia commented on code in PR #18571:
URL: https://github.com/apache/kafka/pull/18571#discussion_r1918494836
##
clients/src/main/java/org/apache/kafka/clients/admin/ListShareGroupOffsetsOptions.java:
##
@@ -0,0 +1,31 @@
+/*
+ * Licensed to the Apache Software Foundation (AS
mimaison merged PR #18522:
URL: https://github.com/apache/kafka/pull/18522
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
TaiJuWu commented on code in PR #18389:
URL: https://github.com/apache/kafka/pull/18389#discussion_r1918483228
##
docker/docker_official_images/3.7.0/jvm/Dockerfile:
##
@@ -78,7 +78,7 @@ RUN set -eux ; \
chmod -R ug+w /etc/kafka /var/lib/kafka /etc/kafka/secrets; \
cp
TaiJuWu commented on code in PR #18389:
URL: https://github.com/apache/kafka/pull/18389#discussion_r1918483228
##
docker/docker_official_images/3.7.0/jvm/Dockerfile:
##
@@ -78,7 +78,7 @@ RUN set -eux ; \
chmod -R ug+w /etc/kafka /var/lib/kafka /etc/kafka/secrets; \
cp
[
https://issues.apache.org/jira/browse/KAFKA-18521?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai resolved KAFKA-18521.
Resolution: Fixed
trunk:
[https://github.com/apache/kafka/commit/3c1f965c60789dcc8ee14eba
[
https://issues.apache.org/jira/browse/KAFKA-18521?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai updated KAFKA-18521:
---
Fix Version/s: 4.0.0
> Cleanup NodeApiVersions zkMigrationEnabled field
> --
FrankYang0529 commented on PR #18198:
URL: https://github.com/apache/kafka/pull/18198#issuecomment-2595410633
Hi @lianetm, could you help me review this when you have time? Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
chia7712 merged PR #18535:
URL: https://github.com/apache/kafka/pull/18535
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
AndrewJSchofield merged PR #18562:
URL: https://github.com/apache/kafka/pull/18562
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafk
sjhajharia commented on code in PR #18571:
URL: https://github.com/apache/kafka/pull/18571#discussion_r1918531681
##
server-common/src/main/java/org/apache/kafka/server/share/persister/DefaultStatePersister.java:
##
@@ -288,7 +291,96 @@ public CompletableFuture
deleteState(Dele
[
https://issues.apache.org/jira/browse/KAFKA-18558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Schofield resolved KAFKA-18558.
--
Resolution: Fixed
> Include partitions from previous subscription in ShareFetchRequest
[
https://issues.apache.org/jira/browse/KAFKA-18558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Schofield updated KAFKA-18558:
-
Fix Version/s: 4.1.0
> Include partitions from previous subscription in ShareFetchReques
showuon commented on code in PR #18519:
URL: https://github.com/apache/kafka/pull/18519#discussion_r1918333787
##
clients/src/main/java/org/apache/kafka/common/security/oauthbearer/internals/secured/ConfigurationUtils.java:
##
@@ -228,4 +233,16 @@ public T get(String name) {
showuon opened a new pull request, #18576:
URL: https://github.com/apache/kafka/pull/18576
Some clean up for sasl endpoints for v3.x.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
-
showuon commented on code in PR #18576:
URL: https://github.com/apache/kafka/pull/18576#discussion_r1918356329
##
clients/src/main/java/org/apache/kafka/common/security/oauthbearer/internals/secured/ConfigurationUtils.java:
##
@@ -228,4 +233,21 @@ public T get(String name) {
squah-confluent commented on code in PR #18499:
URL: https://github.com/apache/kafka/pull/18499#discussion_r1918440313
##
server-common/src/main/java/org/apache/kafka/deferred/DeferredEventQueue.java:
##
@@ -82,7 +85,11 @@ public void failAll(Exception exception) {
squah-confluent commented on code in PR #18499:
URL: https://github.com/apache/kafka/pull/18499#discussion_r1918440313
##
server-common/src/main/java/org/apache/kafka/deferred/DeferredEventQueue.java:
##
@@ -82,7 +85,11 @@ public void failAll(Exception exception) {
sjhajharia commented on code in PR #18571:
URL: https://github.com/apache/kafka/pull/18571#discussion_r1918501064
##
clients/src/main/java/org/apache/kafka/clients/admin/ListShareGroupOffsetsResult.java:
##
@@ -0,0 +1,74 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
sjhajharia commented on code in PR #18571:
URL: https://github.com/apache/kafka/pull/18571#discussion_r1918508482
##
clients/src/main/java/org/apache/kafka/clients/admin/ListShareGroupOffsetsSpec.java:
##
@@ -0,0 +1,80 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
sjhajharia commented on code in PR #18571:
URL: https://github.com/apache/kafka/pull/18571#discussion_r1918539274
##
server-common/src/main/java/org/apache/kafka/server/share/persister/PersisterStateManager.java:
##
@@ -730,6 +734,147 @@ protected RPCType rpcType() {
}
sjhajharia commented on code in PR #18571:
URL: https://github.com/apache/kafka/pull/18571#discussion_r1918540660
##
server-common/src/main/java/org/apache/kafka/server/share/persister/PersisterStateManager.java:
##
@@ -730,6 +734,147 @@ protected RPCType rpcType() {
}
jkt628 commented on PR #16492:
URL: https://github.com/apache/kafka/pull/16492#issuecomment-2595713588
`./gradlew clients:test -PmaxParallelForks=2` passes but i cannot run the
full suite due to OOM.
--
This is an automated message from the Apache Git Service.
To respond to the message, p
sjhajharia commented on code in PR #18571:
URL: https://github.com/apache/kafka/pull/18571#discussion_r1918529558
##
server-common/src/main/java/org/apache/kafka/server/share/persister/DefaultStatePersister.java:
##
@@ -288,7 +291,96 @@ public CompletableFuture
deleteState(Dele
ijuma commented on code in PR #18573:
URL: https://github.com/apache/kafka/pull/18573#discussion_r1918633148
##
core/src/test/scala/unit/kafka/cluster/BrokerEndPointTest.scala:
##
@@ -1,204 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * co
ijuma opened a new pull request, #18577:
URL: https://github.com/apache/kafka/pull/18577
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade not
FrankYang0529 commented on PR #18508:
URL: https://github.com/apache/kafka/pull/18508#issuecomment-2594771435
Hi @chia7712, I address all comments. Could you take a look when you have
time? Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message,
[
https://issues.apache.org/jira/browse/KAFKA-18546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17913598#comment-17913598
]
PoAn Yang commented on KAFKA-18546:
---
PR: https://github.com/apache/kafka/pull/18565
>
[
https://issues.apache.org/jira/browse/KAFKA-18546?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
PoAn Yang reassigned KAFKA-18546:
-
Assignee: (was: PoAn Yang)
> Change ClientUtilsTest#testParseAndValidateAddressesWithRevers
[
https://issues.apache.org/jira/browse/KAFKA-18331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ismael Juma resolved KAFKA-18331.
-
Resolution: Fixed
> Update process.roles to required configuration
> ---
[
https://issues.apache.org/jira/browse/KAFKA-18552?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ismael Juma updated KAFKA-18552:
Fix Version/s: 4.1.0
> Remove unnecessary version check from KafkaApisTest
> -
ijuma merged PR #18524:
URL: https://github.com/apache/kafka/pull/18524
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
ijuma commented on PR #18524:
URL: https://github.com/apache/kafka/pull/18524#issuecomment-2594792788
Merged to trunk. There were some conflicts when I cherry-picked to 4.0 -
I'll take another look at that tomorrow.
--
This is an automated message from the Apache Git Service.
To respond t
[
https://issues.apache.org/jira/browse/KAFKA-18552?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ismael Juma resolved KAFKA-18552.
-
Resolution: Fixed
> Remove unnecessary version check from KafkaApisTest
> --
[
https://issues.apache.org/jira/browse/KAFKA-18514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ismael Juma updated KAFKA-18514:
Fix Version/s: 4.0.0
> Refactor share module to server and server-common
> ---
[
https://issues.apache.org/jira/browse/KAFKA-18472?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ismael Juma resolved KAFKA-18472.
-
Fix Version/s: 4.0.0
Resolution: Fixed
> Remove MetadataSupport
> --
smjn opened a new pull request, #18572:
URL: https://github.com/apache/kafka/pull/18572
* The default append linger ms for group coord was recently changed from 10
-> 5.
* This PR aims to bring share coord in line with the same.
--
This is an automated message from the Apache Git Servi
divijvaidya merged PR #18080:
URL: https://github.com/apache/kafka/pull/18080
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apa
lianetm commented on code in PR #18554:
URL: https://github.com/apache/kafka/pull/18554#discussion_r1918791042
##
core/src/test/scala/integration/kafka/api/ConsumerRebootstrapTest.scala:
##
@@ -135,12 +135,13 @@ object ConsumerRebootstrapTest {
final val RebootstrapTestName
FrankYang0529 commented on code in PR #18553:
URL: https://github.com/apache/kafka/pull/18553#discussion_r1918803822
##
core/src/test/scala/unit/kafka/server/FinalizedFeatureCacheTest.scala:
##
@@ -1,109 +0,0 @@
-/**
- * Licensed to the Apache Software Foundation (ASF) under one
TaiJuWu opened a new pull request, #18578:
URL: https://github.com/apache/kafka/pull/18578
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgra
TaiJuWu commented on code in PR #18542:
URL: https://github.com/apache/kafka/pull/18542#discussion_r1918818927
##
core/src/test/scala/unit/kafka/server/KafkaApisTest.scala:
##
@@ -3612,175 +3569,6 @@ class KafkaApisTest extends Logging {
assertEquals(Set(0), response.broker
chirag-wadhwa5 commented on code in PR #18209:
URL: https://github.com/apache/kafka/pull/18209#discussion_r1918820386
##
tests/kafkatest/tests/verifiable_share_consumer_test.py:
##
@@ -0,0 +1,106 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contrib
chirag-wadhwa5 commented on code in PR #18209:
URL: https://github.com/apache/kafka/pull/18209#discussion_r1918822174
##
tests/kafkatest/services/verifiable_share_consumer.py:
##
@@ -0,0 +1,337 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contribut
TaiJuWu commented on code in PR #18554:
URL: https://github.com/apache/kafka/pull/18554#discussion_r1918826202
##
core/src/test/scala/integration/kafka/api/ConsumerRebootstrapTest.scala:
##
@@ -135,12 +135,13 @@ object ConsumerRebootstrapTest {
final val RebootstrapTestName
frankvicky commented on code in PR #18389:
URL: https://github.com/apache/kafka/pull/18389#discussion_r1918784490
##
bin/kafka-server-start.sh:
##
@@ -19,6 +19,14 @@ then
echo "USAGE: $0 [-daemon] server.properties [--override
property=value]*"
exit 1
fi
+
+for
cadonna commented on PR #18565:
URL: https://github.com/apache/kafka/pull/18565#issuecomment-2596088999
Yeah, I agree with you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific commen
cadonna commented on PR #18565:
URL: https://github.com/apache/kafka/pull/18565#issuecomment-2596070101
Cherry-picked to `3.9` and `3.8`.
@dajac May I cherry-pick this commit also to `4.0`
--
This is an automated message from the Apache Git Service.
To respond to the message, please lo
chia7712 commented on code in PR #18567:
URL: https://github.com/apache/kafka/pull/18567#discussion_r1918794057
##
server-common/src/main/java/org/apache/kafka/server/config/ConfigType.java:
##
@@ -31,6 +31,5 @@ public class ConfigType {
public static final String CLIENT_ME
lianetm commented on PR #18565:
URL: https://github.com/apache/kafka/pull/18565#issuecomment-2596085100
Will let David say but my take is that we should definitely cherry-pick it
to 4.0. Low risk (test change), and the fix avoids the test breaking
unexpectedly again as it has happened sever
ijuma commented on code in PR #18553:
URL: https://github.com/apache/kafka/pull/18553#discussion_r1918847276
##
core/src/test/scala/unit/kafka/server/FinalizedFeatureCacheTest.scala:
##
@@ -1,109 +0,0 @@
-/**
- * Licensed to the Apache Software Foundation (ASF) under one or more
mimaison merged PR #18534:
URL: https://github.com/apache/kafka/pull/18534
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
apoorvmittal10 commented on code in PR #18567:
URL: https://github.com/apache/kafka/pull/18567#discussion_r1918856970
##
server-common/src/main/java/org/apache/kafka/server/config/ConfigType.java:
##
@@ -31,6 +31,5 @@ public class ConfigType {
public static final String CLI
[
https://issues.apache.org/jira/browse/KAFKA-18569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17913792#comment-17913792
]
Lianet Magrans commented on KAFKA-18569:
Hey [~chia7712] , we've worked together
[
https://issues.apache.org/jira/browse/KAFKA-18569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lianet Magrans reassigned KAFKA-18569:
--
Assignee: TengYao Chi
> New consumer close may wait on unneeded FindCoordinator
> ---
chia7712 commented on code in PR #18578:
URL: https://github.com/apache/kafka/pull/18578#discussion_r1918907903
##
core/src/test/scala/unit/kafka/server/KafkaApisTest.scala:
##
@@ -3561,6 +3561,115 @@ class KafkaApisTest extends Logging {
assertEquals(Set(0), response.broke
apoorvmittal10 commented on code in PR #18444:
URL: https://github.com/apache/kafka/pull/18444#discussion_r1918923958
##
core/src/main/java/kafka/server/share/SharePartitionManager.java:
##
@@ -693,6 +717,38 @@ private static void removeSharePartitionFromCache(
}
}
apoorvmittal10 commented on code in PR #18444:
URL: https://github.com/apache/kafka/pull/18444#discussion_r1918926272
##
core/src/main/java/kafka/server/share/SharePartitionManager.java:
##
@@ -361,24 +376,31 @@ public CompletableFuture>
mapAcknowledgementFutures(Map>
futuresM
apoorvmittal10 commented on PR #18444:
URL: https://github.com/apache/kafka/pull/18444#issuecomment-2596292052
I have addressed the comments, the PR is ready for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
[
https://issues.apache.org/jira/browse/KAFKA-18556?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mickael Maison resolved KAFKA-18556.
Resolution: Fixed
> Remove JaasModule#zkDigestModule, JaasTestUtils#zkSections and its usa
jsancio commented on code in PR #18240:
URL: https://github.com/apache/kafka/pull/18240#discussion_r1918761915
##
raft/src/main/java/org/apache/kafka/raft/QuorumState.java:
##
@@ -562,6 +656,25 @@ public void transitionToCandidate() {
));
}
+private void chec
junrao commented on code in PR #18012:
URL: https://github.com/apache/kafka/pull/18012#discussion_r1918939953
##
storage/src/main/java/org/apache/kafka/storage/internals/log/LogValidator.java:
##
@@ -239,7 +233,6 @@ public ValidationResult assignOffsetsNonCompressed(LongRef
off
1 - 100 of 296 matches
Mail list logo
