junrao commented on code in PR #18012:
URL: https://github.com/apache/kafka/pull/18012#discussion_r1918939953


##########
storage/src/main/java/org/apache/kafka/storage/internals/log/LogValidator.java:
##########
@@ -239,7 +233,6 @@ public ValidationResult assignOffsetsNonCompressed(LongRef 
offsetCounter,
                                                        MetricsRecorder 
metricsRecorder) {
         long now = time.milliseconds();
         long maxTimestamp = RecordBatch.NO_TIMESTAMP;
-        long shallowOffsetOfMaxTimestamp = -1L;

Review Comment:
   Could we also remove `initialOffset`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to