[jira] [Assigned] (KAFKA-17777) Flaky KafkaConsumerTest testReturnRecordsDuringRebalance

2025-01-10 Thread TengYao Chi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-1?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] TengYao Chi reassigned KAFKA-1: --- Assignee: (was: TengYao Chi) > Flaky KafkaConsumerTest testReturnRecordsDuringRebalance

Re: [PR] KAFKA-18346: Fix e2e TestKRaftUpgrade from v3.3.2 [kafka]

2025-01-10 Thread via GitHub
TaiJuWu commented on PR #18386: URL: https://github.com/apache/kafka/pull/18386#issuecomment-2585133619 reopen for discussion. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[jira] [Commented] (KAFKA-17777) Flaky KafkaConsumerTest testReturnRecordsDuringRebalance

2025-01-10 Thread TengYao Chi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-1?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17912171#comment-17912171 ] TengYao Chi commented on KAFKA-1: - Hi [~kirktrue]  Ideally, it would be fine if

Re: [PR] KAFKA-18465: Remove MetadataVersions older than 3.0-IV1 [kafka]

2025-01-10 Thread via GitHub
junrao commented on code in PR #18468: URL: https://github.com/apache/kafka/pull/18468#discussion_r1911519969 ## core/src/test/scala/unit/kafka/server/ReplicaFetcherThreadTest.scala: ## @@ -130,96 +128,12 @@ class ReplicaFetcherThreadTest { ApiKeys.FETCH.latestVersion(tru

Re: [PR] KAFKA-18464: Empty Abort Transaction can fence producer incorrectly with Transactions V2 [kafka]

2025-01-10 Thread via GitHub
jeffkbkim commented on code in PR #18467: URL: https://github.com/apache/kafka/pull/18467#discussion_r1911570487 ## core/src/main/scala/kafka/coordinator/transaction/TransactionCoordinator.scala: ## @@ -814,10 +814,10 @@ class TransactionCoordinator(txnConfig: TransactionConfig,

Re: [PR] KAFKA-18465: Remove MetadataVersions older than 3.0-IV1 [kafka]

2025-01-10 Thread via GitHub
ijuma commented on code in PR #18468: URL: https://github.com/apache/kafka/pull/18468#discussion_r1911740743 ## clients/src/main/java/org/apache/kafka/common/requests/AlterPartitionRequest.java: ## @@ -68,14 +68,12 @@ public static class Builder extends AbstractRequest.Builder

Re: [PR] KAFKA-8116: Update Kafka Streams archetype for Java 11 [kafka]

2025-01-10 Thread via GitHub
mjsax commented on PR #18471: URL: https://github.com/apache/kafka/pull/18471#issuecomment-2584916779 Merged to `trunk` and cherry-picked to `4.0` branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[PR] MINOR: Kafka Streams doc updates for 4.0 release [kafka]

2025-01-10 Thread via GitHub
mjsax opened a new pull request, #18488: URL: https://github.com/apache/kafka/pull/18488 Docs and JavaDocs updates for 4.0 release KIPs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

Re: [PR] KAFKA-18034: CommitRequestManager should fail pending requests on fatal coordinator errors [kafka]

2025-01-10 Thread via GitHub
m1a2st commented on code in PR #18050: URL: https://github.com/apache/kafka/pull/18050#discussion_r1911784734 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/CoordinatorRequestManagerTest.java: ## @@ -253,6 +236,21 @@ public void testNetworkTimeout() {

Re: [PR] MINOR: Kafka Streams doc updates for 4.0 release [kafka]

2025-01-10 Thread via GitHub
mjsax commented on code in PR #18488: URL: https://github.com/apache/kafka/pull/18488#discussion_r1911785250 ## docs/streams/developer-guide/testing.html: ## @@ -276,15 +276,15 @@ To begin with, instantiate your processor and initialize it with t

Re: [PR] [DO NOT MERGE] KAFKA-18206: EmbeddedKafkaCluster must set features [kafka]

2025-01-10 Thread via GitHub
brandboat commented on PR #18189: URL: https://github.com/apache/kafka/pull/18189#issuecomment-2585057503 > Should we split this into it's own PR? Hi @mjsax, sorry I forgot to mention that this was handling in a different issue, here is the PR: https://github.com/apache/kafka/pull/184

Re: [PR] KAFKA-18479: RocksDBTimeOrderedKeyValueBuffer not initialized correctly [kafka]

2025-01-10 Thread via GitHub
mjsax commented on code in PR #18490: URL: https://github.com/apache/kafka/pull/18490#discussion_r1911865335 ## streams/integration-tests/src/test/java/org/apache/kafka/streams/integration/StreamTableJoinWithGraceIntegrationTest.java: ## @@ -52,13 +54,13 @@ public class StreamTa

Re: [PR] KAFKA-18479: RocksDBTimeOrderedKeyValueBuffer not initialized correctly [kafka]

2025-01-10 Thread via GitHub
mjsax commented on code in PR #18490: URL: https://github.com/apache/kafka/pull/18490#discussion_r1911865297 ## streams/integration-tests/src/test/java/org/apache/kafka/streams/integration/AbstractJoinIntegrationTest.java: ## @@ -260,16 +266,13 @@ void runSelfJoinTestWithDriver(

Re: [PR] KAFKA-18479: RocksDBTimeOrderedKeyValueBuffer not initialized correctly [kafka]

2025-01-10 Thread via GitHub
mjsax commented on code in PR #18490: URL: https://github.com/apache/kafka/pull/18490#discussion_r1911865599 ## streams/integration-tests/src/test/java/org/apache/kafka/streams/integration/StreamTableJoinWithGraceIntegrationTest.java: ## @@ -96,7 +98,7 @@ public void testLeftWit

Re: [PR] KAFKA-18479: RocksDBTimeOrderedKeyValueBuffer not initialized correctly [kafka]

2025-01-10 Thread via GitHub
mjsax commented on code in PR #18490: URL: https://github.com/apache/kafka/pull/18490#discussion_r1911865862 ## streams/src/test/java/org/apache/kafka/streams/state/internals/RocksDBTimeOrderedKeyValueBufferTest.java: ## @@ -62,18 +62,16 @@ public class RocksDBTimeOrderedKeyValu

Re: [PR] MINOR: Removed unused local variable in method DefaultStateUpdater.drainRestoredActiveTasks [kafka]

2025-01-10 Thread via GitHub
github-actions[bot] commented on PR #18385: URL: https://github.com/apache/kafka/pull/18385#issuecomment-2585039671 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

[jira] [Updated] (KAFKA-14567) Kafka Streams crashes after ProducerFencedException

2025-01-10 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-14567: Fix Version/s: 4.1.0 (was: 4.0.0) > Kafka Streams crashes after Pro

Re: [PR] [DO NOT MERGE] KAFKA-18206: EmbeddedKafkaCluster must set features [kafka]

2025-01-10 Thread via GitHub
mjsax commented on PR #18189: URL: https://github.com/apache/kafka/pull/18189#issuecomment-2585045515 > note that this PR also fix potential transaction with empty records in sendPrivileged method as transaction version 2 doesn't allow this kind of scenario. Should we split this into

Re: [PR] KAFKA-18465: Remove MetadataVersions older than 3.0-IV1 [kafka]

2025-01-10 Thread via GitHub
ijuma commented on code in PR #18468: URL: https://github.com/apache/kafka/pull/18468#discussion_r1911671034 ## core/src/test/scala/unit/kafka/server/ReplicaFetcherThreadTest.scala: ## @@ -130,96 +128,12 @@ class ReplicaFetcherThreadTest { ApiKeys.FETCH.latestVersion(true

[PR] KAFKA-18476: KafkaStreams should swallow TransactionAbortedException [kafka]

2025-01-10 Thread via GitHub
mjsax opened a new pull request, #18487: URL: https://github.com/apache/kafka/pull/18487 TransactionAbortedException is a follow up error to a previous error, and such a previous error would already be handled when `producer.abortTransaction()` is called. Thus, a TransactionAbortedEx

Re: [PR] KAFKA-18464: Empty Abort Transaction can fence producer incorrectly with Transactions V2 [kafka]

2025-01-10 Thread via GitHub
jolshan commented on code in PR #18467: URL: https://github.com/apache/kafka/pull/18467#discussion_r1911701912 ## core/src/main/scala/kafka/coordinator/transaction/TransactionCoordinator.scala: ## @@ -814,10 +814,10 @@ class TransactionCoordinator(txnConfig: TransactionConfig,

Re: [PR] KAFKA-17825: Update docs for ByteBufferDeserializer changes in 3.6 release [kafka]

2025-01-10 Thread via GitHub
mjsax merged PR #18466: URL: https://github.com/apache/kafka/pull/18466 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

[jira] [Commented] (KAFKA-17825) ByteBufferDeserializaer's array size can be inconsistent with the older version

2025-01-10 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17912150#comment-17912150 ] ASF GitHub Bot commented on KAFKA-17825: mjsax merged PR #660: URL: https://gith

Re: [PR] KAFKA-18465: Remove MetadataVersions older than 3.0-IV1 [kafka]

2025-01-10 Thread via GitHub
ijuma commented on code in PR #18468: URL: https://github.com/apache/kafka/pull/18468#discussion_r1911713019 ## core/src/test/scala/unit/kafka/server/ReplicaFetcherThreadTest.scala: ## @@ -130,96 +128,12 @@ class ReplicaFetcherThreadTest { ApiKeys.FETCH.latestVersion(true

Re: [PR] KAFKA-18465: Remove MetadataVersions older than 3.0-IV1 [kafka]

2025-01-10 Thread via GitHub
ijuma commented on code in PR #18468: URL: https://github.com/apache/kafka/pull/18468#discussion_r1911723432 ## clients/src/main/java/org/apache/kafka/common/requests/AlterPartitionRequest.java: ## @@ -68,14 +68,12 @@ public static class Builder extends AbstractRequest.Builder

Re: [PR] KAFKA-17825: Update docs for ByteBufferDeserializer changes in 3.6 release [kafka]

2025-01-10 Thread via GitHub
mjsax commented on PR #18466: URL: https://github.com/apache/kafka/pull/18466#issuecomment-2584874328 Merged to `trunk` and cherry-picked to `4.0`, `3.9`, `3.8`, `3.7`, and `3.6` branches. -- This is an automated message from the Apache Git Service. To respond to the message, please log o

Re: [PR] KAFKA-17182: Consumer fetch sessions are evicted too quickly with AsyncKafkaConsumer [kafka]

2025-01-10 Thread via GitHub
junrao commented on PR #17700: URL: https://github.com/apache/kafka/pull/17700#issuecomment-2584468565 @kirktrue : Thanks for sharing the test result. Given that there is little impact on end-to-end latency, I'd go with option 4. -- This is an automated message from the Apache Git Service

[jira] [Assigned] (KAFKA-18476) KafkaStreams should swallow TransactionAbortedException

2025-01-10 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax reassigned KAFKA-18476: --- Assignee: Matthias J. Sax > KafkaStreams should swallow TransactionAbortedException

[jira] [Created] (KAFKA-18476) KafkaStreams should swallow TransactionAbortedException

2025-01-10 Thread Matthias J. Sax (Jira)
Matthias J. Sax created KAFKA-18476: --- Summary: KafkaStreams should swallow TransactionAbortedException Key: KAFKA-18476 URL: https://issues.apache.org/jira/browse/KAFKA-18476 Project: Kafka

[PR] MINOR: simplify producer code [kafka]

2025-01-10 Thread via GitHub
mjsax opened a new pull request, #18486: URL: https://github.com/apache/kafka/pull/18486 Call for review @jolshan @hachikuji -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] KAFKA-17607: Add CI step to verify LICENSE-binary [kafka]

2025-01-10 Thread via GitHub
fonsdant commented on PR #18299: URL: https://github.com/apache/kafka/pull/18299#issuecomment-2585007385 Hi, @mumrah! I have noted this task is very similiar to another old one I have picked up. This is my PR: #17888. Are they the same? https://issues.apache.org/jira/browse/KAFKA-1262

Re: [PR] MINOR: Kafka Streams doc updates for 4.0 release [kafka]

2025-01-10 Thread via GitHub
mjsax commented on code in PR #18488: URL: https://github.com/apache/kafka/pull/18488#discussion_r1911784754 ## docs/streams/developer-guide/processor-api.html: ## @@ -67,42 +67,40 @@ OverviewCombining the DSL and the Processor API: You can combine the conv

Re: [PR] KAFKA-18465: Remove MetadataVersions older than 3.0-IV1 [kafka]

2025-01-10 Thread via GitHub
ijuma commented on PR #18468: URL: https://github.com/apache/kafka/pull/18468#issuecomment-2584989360 @junrao I have addressed your comments. Let me know if you have any other comments or if this looks good. Thanks! -- This is an automated message from the Apache Git Service. To respond t

Re: [PR] MINOR: simplify producer TX abort error handling [kafka]

2025-01-10 Thread via GitHub
mjsax merged PR #18486: URL: https://github.com/apache/kafka/pull/18486 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

Re: [PR] MINOR: simplify producer code [kafka]

2025-01-10 Thread via GitHub
mjsax commented on code in PR #18486: URL: https://github.com/apache/kafka/pull/18486#discussion_r1911759131 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java: ## @@ -462,17 +462,10 @@ private boolean maybeSendAndPollTransactionalRequest() {

Re: [PR] KAFKA-8116: Update Kafka Streams archetype for Java 11 [kafka]

2025-01-10 Thread via GitHub
mjsax merged PR #18471: URL: https://github.com/apache/kafka/pull/18471 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

[jira] [Resolved] (KAFKA-14408) Consider enabling DEBUG log level on tests for Streams

2025-01-10 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax resolved KAFKA-14408. - Resolution: Won't Fix I don't think we should do this – it would produce way too many lo

Re: [PR] KAFKA-16339: [Docs] Add migrating from transform to process [kafka]

2025-01-10 Thread via GitHub
fonsdant commented on PR #18314: URL: https://github.com/apache/kafka/pull/18314#issuecomment-2585000776 @mjsax, I removed the "migration process" section to simplify the guide, unified the method reference, added the remaining `to`, fixed the `flatTransformValues`-`processValues` behavior,

Re: [PR] Add and distribute IQv2 information in KIP-1071 [kafka]

2025-01-10 Thread via GitHub
bbejeck commented on code in PR #18278: URL: https://github.com/apache/kafka/pull/18278#discussion_r1911573303 ## streams/integration-tests/src/test/java/org/apache/kafka/streams/integration/OptimizedKTableIntegrationTest.java: ## @@ -78,24 +80,28 @@ public class OptimizedKTable

[jira] [Commented] (KAFKA-15900) Flaky test: testOutdatedCoordinatorAssignment() – org.apache.kafka.clients.consumer.internals.EagerConsumerCoordinatorTest

2025-01-10 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17912123#comment-17912123 ] Lianet Magrans commented on KAFKA-15900: This one seems very flaky on trunk htt

Re: [PR] KAFKA-8116: Update Kafka Streams archetype for Java 11 [kafka]

2025-01-10 Thread via GitHub
lianetm commented on PR #18471: URL: https://github.com/apache/kafka/pull/18471#issuecomment-2584372556 Yeap, the flaky `EagerConsumerCoordinatorTest.testOutdatedCoordinatorAssignment` is tracked already https://issues.apache.org/jira/browse/KAFKA-15900 , and is indeed very flaky in trunk

Re: [PR] KAFKA-18465: Remove MetadataVersions older than 3.0-IV1 [kafka]

2025-01-10 Thread via GitHub
junrao commented on code in PR #18468: URL: https://github.com/apache/kafka/pull/18468#discussion_r1911522823 ## core/src/main/scala/kafka/server/ApiVersionManager.scala: ## @@ -150,14 +150,12 @@ class DefaultApiVersionManager( } val apiVersions = if (controllerApiVers

Re: [PR] Add and distribute IQv2 information in KIP-1071 [kafka]

2025-01-10 Thread via GitHub
bbejeck commented on code in PR #18278: URL: https://github.com/apache/kafka/pull/18278#discussion_r1911583193 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -2378,6 +2400,32 @@ private CoordinatorResult stream ret

Re: [PR] Kafka-16540: Update partitions if min isr config is changed. [kafka]

2025-01-10 Thread via GitHub
cmccabe commented on code in PR #18148: URL: https://github.com/apache/kafka/pull/18148#discussion_r1911567192 ## metadata/src/main/java/org/apache/kafka/controller/BrokersToElrs.java: ## @@ -158,4 +158,9 @@ BrokersToIsrs.PartitionsOnReplicaIterator partitionsWithBrokerInElr(in

[jira] [Commented] (KAFKA-17623) Flaky testSeekPositionAndPauseNewlyAssignedPartitionOnPartitionsAssignedCallback

2025-01-10 Thread PoAn Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17912158#comment-17912158 ] PoAn Yang commented on KAFKA-17623: --- Hi [~kirktrue], sorry for late and block the prog

[jira] [Assigned] (KAFKA-17623) Flaky testSeekPositionAndPauseNewlyAssignedPartitionOnPartitionsAssignedCallback

2025-01-10 Thread PoAn Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] PoAn Yang reassigned KAFKA-17623: - Assignee: Kirk True (was: PoAn Yang) > Flaky > testSeekPositionAndPauseNewlyAssignedPartition

Re: [PR] Kafka-16540: Update partitions if min isr config is changed. [kafka]

2025-01-10 Thread via GitHub
CalvinConfluent commented on code in PR #18148: URL: https://github.com/apache/kafka/pull/18148#discussion_r1911783684 ## metadata/src/main/java/org/apache/kafka/controller/BrokersToElrs.java: ## @@ -158,4 +158,9 @@ BrokersToIsrs.PartitionsOnReplicaIterator partitionsWithBroker

[jira] [Updated] (KAFKA-18464) Empty Abort Transaction can fence producer incorrectly with Transactions V2

2025-01-10 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18464?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justine Olshan updated KAFKA-18464: --- Fix Version/s: 4.0.0 > Empty Abort Transaction can fence producer incorrectly with Transacti

[jira] [Resolved] (KAFKA-18464) Empty Abort Transaction can fence producer incorrectly with Transactions V2

2025-01-10 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18464?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justine Olshan resolved KAFKA-18464. Resolution: Fixed > Empty Abort Transaction can fence producer incorrectly with Transactio

[jira] [Commented] (KAFKA-18477) remove usage of OffsetForLeaderEpochRequest in AbstractFetcherThread

2025-01-10 Thread Jun Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17912160#comment-17912160 ] Jun Rao commented on KAFKA-18477: - [~m1a2st] : Thanks for helping out. Feel free to take

[jira] [Assigned] (KAFKA-18477) remove usage of OffsetForLeaderEpochRequest in AbstractFetcherThread

2025-01-10 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-18477?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] 黃竣陽 reassigned KAFKA-18477: --- Assignee: 黃竣陽 > remove usage of OffsetForLeaderEpochRequest in AbstractFetcherThread >

[PR] KAFKA-18477 remove usage of OffsetForLeaderEpochRequest in AbstractFetcherThread [kafka]

2025-01-10 Thread via GitHub
m1a2st opened a new pull request, #18489: URL: https://github.com/apache/kafka/pull/18489 Jira: https://issues.apache.org/jira/browse/KAFKA-18477 as title ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test cover

Re: [PR] HOTFIX: fix failed case RemoteLogManagerTest#testStopPartitionsWithDeletion [kafka]

2025-01-10 Thread via GitHub
ijuma commented on PR #18474: URL: https://github.com/apache/kafka/pull/18474#issuecomment-2582059742 The PR you referenced was green when I merged it: ![Screenshot_20250110-003435](https://github.com/user-attachments/assets/33a0d5e6-5a91-4201-992e-1d696ad86f54) -- This is an autom

Re: [PR] KAFKA-18399 Remove ZooKeeper from KafkaApis (3/N): `handleCreateTokenRequest`, `handleRenewTokenRequestZk`, `handleExpireTokenRequestZk` [kafka]

2025-01-10 Thread via GitHub
m1a2st commented on code in PR #18447: URL: https://github.com/apache/kafka/pull/18447#discussion_r1910011770 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -3071,36 +3042,7 @@ class KafkaApis(val requestChannel: RequestChannel, } def handleExpireTokenRequest

[jira] [Created] (KAFKA-18469) AsyncConsumer fails to retry ListOffsetRequest on ReplicaNotAvailable error without metadata update

2025-01-10 Thread Yu-Lin Chen (Jira)
Yu-Lin Chen created KAFKA-18469: --- Summary: AsyncConsumer fails to retry ListOffsetRequest on ReplicaNotAvailable error without metadata update Key: KAFKA-18469 URL: https://issues.apache.org/jira/browse/KAFKA-18469

Re: [PR] HOTFIX: fix failed case RemoteLogManagerTest#testStopPartitionsWithDeletion [kafka]

2025-01-10 Thread via GitHub
FrankYang0529 commented on PR #18474: URL: https://github.com/apache/kafka/pull/18474#issuecomment-2582275763 The failed case `AbstractCoordinatorTest#testWakeupAfterSyncGroupReceivedExternalCompletion ` is not related to this PR and already filed an issue https://issues.apache.org/jira/br

Re: [PR] KAFKA-18440: Admin does not convert the AuthorizationException to fatal error in using bootstrap controllers [kafka]

2025-01-10 Thread via GitHub
divijvaidya merged PR #18435: URL: https://github.com/apache/kafka/pull/18435 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apa

Re: [PR] HOTFIX: fix failed case RemoteLogManagerTest#testStopPartitionsWithDeletion [kafka]

2025-01-10 Thread via GitHub
TaiJuWu commented on PR #18474: URL: https://github.com/apache/kafka/pull/18474#issuecomment-2582012408 https://github.com/apache/kafka/pull/18321 make this CI fail. @ijuma Could you take a look? -- This is an automated message from the Apache Git Service. To respond to the message, ple

Re: [PR] KAFKA-18466: Remove log4j-1.2-api from runtime scope while keeping it in distribution package [kafka]

2025-01-10 Thread via GitHub
ppkarwasz commented on PR #18472: URL: https://github.com/apache/kafka/pull/18472#issuecomment-2582098975 Similarly to apache/eventmesh#4700, I think that: - Not only `log4j-1.2-api`, but also `log4j-slf4j-impl` should be removed from the runtime dependencies of all artifacts. - `l

Re: [PR] HOTFIX: fix failed case RemoteLogManagerTest#testStopPartitionsWithDeletion [kafka]

2025-01-10 Thread via GitHub
TaiJuWu commented on PR #18474: URL: https://github.com/apache/kafka/pull/18474#issuecomment-2582103639 > The PR you referenced was green when I merged it: > Yes, you're correct, but I used the following script to identify the commit that caused this test to fail, and it points to

Re: [PR] KAFKA-18308; Update CoordinatorSerde [kafka]

2025-01-10 Thread via GitHub
dajac merged PR #18455: URL: https://github.com/apache/kafka/pull/18455 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

[jira] [Updated] (KAFKA-18331) Update process.roles to required configuration

2025-01-10 Thread PoAn Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] PoAn Yang updated KAFKA-18331: -- Description: In Kafka 4.0, the ZK will be removed. We should update process.roles as required configur

[jira] [Updated] (KAFKA-18331) Update process.roles to required configuration

2025-01-10 Thread PoAn Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] PoAn Yang updated KAFKA-18331: -- Summary: Update process.roles to required configuration (was: Consider to update process.roles defaul

Re: [PR] KAFKA-18331: Update process.roles to required configuration [kafka]

2025-01-10 Thread via GitHub
FrankYang0529 commented on code in PR #18414: URL: https://github.com/apache/kafka/pull/18414#discussion_r1910155126 ## server/src/main/java/org/apache/kafka/server/config/KRaftConfigs.java: ## @@ -125,7 +124,7 @@ public class KRaftConfigs { public static final ConfigDef CO

[jira] [Updated] (KAFKA-17671) Create better documentation for transactions

2025-01-10 Thread Andrew Schofield (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17671?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Schofield updated KAFKA-17671: - Fix Version/s: 4.0.0 4.1.0 > Create better documentation for transact

[jira] [Resolved] (KAFKA-18308) Update CoordinatorSerde

2025-01-10 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18308?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot resolved KAFKA-18308. - Fix Version/s: 4.1.0 Resolution: Fixed > Update CoordinatorSerde > --

[PR] KAFKA-18469;KAFKA-18036: Make ListOffsetReqeust retriable without metadata update [kafka]

2025-01-10 Thread via GitHub
chenyulin0719 opened a new pull request, #18475: URL: https://github.com/apache/kafka/pull/18475 This is related to KAFKA-18469. Move the retry of ListOffsetReqeust to `ListOffsetRequest.poll()` except the retry of `StaleMetadataException` Create a new set `requestsToRetryOnMet

[jira] [Commented] (KAFKA-18036) TransactionsWithTieredStoreTest testReadCommittedConsumerShouldNotSeeUndecidedData is flaky

2025-01-10 Thread Yu-Lin Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17911912#comment-17911912 ] Yu-Lin Chen commented on KAFKA-18036: - The root cause is that the AsyncConsumer does

[jira] [Assigned] (KAFKA-18036) TransactionsWithTieredStoreTest testReadCommittedConsumerShouldNotSeeUndecidedData is flaky

2025-01-10 Thread Yu-Lin Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18036?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yu-Lin Chen reassigned KAFKA-18036: --- Assignee: Yu-Lin Chen (was: Chia-Ping Tsai) > TransactionsWithTieredStoreTest > testReadC

Re: [PR] KAFKA-17671: Create better documentation for transactions [kafka]

2025-01-10 Thread via GitHub
AndrewJSchofield merged PR #17454: URL: https://github.com/apache/kafka/pull/17454 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafk

Re: [PR] KAFKA-17894: Implemented broker topic metrics for Share Group 1/N (KIP-1103) [kafka]

2025-01-10 Thread via GitHub
AndrewJSchofield commented on code in PR #18444: URL: https://github.com/apache/kafka/pull/18444#discussion_r1910124501 ## core/src/main/java/kafka/server/share/SharePartitionManager.java: ## @@ -693,6 +717,38 @@ private static void removeSharePartitionFromCache( }

Re: [PR] KAFKA-18465: Remove MetadataVersions older than 3.0-IV1 [kafka]

2025-01-10 Thread via GitHub
ijuma commented on code in PR #18468: URL: https://github.com/apache/kafka/pull/18468#discussion_r1909975001 ## clients/src/test/java/org/apache/kafka/common/requests/OffsetsForLeaderEpochRequestTest.java: ## @@ -40,20 +40,4 @@ public void testForConsumerRequiresVersion3() {

Re: [PR] KAFKA-18308; Update CoordinatorSerde [kafka]

2025-01-10 Thread via GitHub
AndrewJSchofield commented on code in PR #18455: URL: https://github.com/apache/kafka/pull/18455#discussion_r1909976659 ## coordinator-common/src/main/java/org/apache/kafka/coordinator/common/runtime/CoordinatorRecordSerde.java: ## @@ -43,7 +43,7 @@ public abstract class Coordin

Re: [PR] KAFKA-18465: Remove MetadataVersions older than 3.0-IV1 [kafka]

2025-01-10 Thread via GitHub
ijuma commented on code in PR #18468: URL: https://github.com/apache/kafka/pull/18468#discussion_r1909977316 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorShard.java: ## @@ -731,7 +731,6 @@ private void cancelClassicGroupSizeCounter() {

Re: [PR] KAFKA-18465: Remove MetadataVersions older than 3.0-IV1 [kafka]

2025-01-10 Thread via GitHub
ijuma commented on code in PR #18468: URL: https://github.com/apache/kafka/pull/18468#discussion_r1909982724 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTestContext.java: ## @@ -238,7 +238,7 @@ public static CoordinatorRecord newGrou

Re: [PR] KAFKA-18311: Enforcing copartitioned topics (4/N) [kafka]

2025-01-10 Thread via GitHub
lucasbru commented on PR #18397: URL: https://github.com/apache/kafka/pull/18397#issuecomment-2582449912 @cadonna As discussed offline, I can add a third validation for source topics in a different place and throw IllegalStateException here. I will do these changes as I rebase `InternalTopi

[jira] [Commented] (KAFKA-18036) TransactionsWithTieredStoreTest testReadCommittedConsumerShouldNotSeeUndecidedData is flaky

2025-01-10 Thread Yu-Lin Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17911928#comment-17911928 ] Yu-Lin Chen commented on KAFKA-18036: - This issue can 100% reproduced by add 2 sec s

[jira] [Updated] (KAFKA-18036) TransactionsWithTieredStoreTest testReadCommittedConsumerShouldNotSeeUndecidedData is flaky

2025-01-10 Thread Yu-Lin Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18036?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yu-Lin Chen updated KAFKA-18036: Attachment: 0001-Reproduce-Kafka-18036.patch > TransactionsWithTieredStoreTest > testReadCommitte

[jira] [Comment Edited] (KAFKA-18036) TransactionsWithTieredStoreTest testReadCommittedConsumerShouldNotSeeUndecidedData is flaky

2025-01-10 Thread Yu-Lin Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17911928#comment-17911928 ] Yu-Lin Chen edited comment on KAFKA-18036 at 1/10/25 11:09 AM: ---

[jira] [Created] (KAFKA-18477) remove usage of OffsetForLeaderEpochRequest in AbstractFetcherThread

2025-01-10 Thread Jun Rao (Jira)
Jun Rao created KAFKA-18477: --- Summary: remove usage of OffsetForLeaderEpochRequest in AbstractFetcherThread Key: KAFKA-18477 URL: https://issues.apache.org/jira/browse/KAFKA-18477 Project: Kafka I

Re: [PR] KAFKA-18465: Remove MetadataVersions older than 3.0-IV1 [kafka]

2025-01-10 Thread via GitHub
junrao commented on code in PR #18468: URL: https://github.com/apache/kafka/pull/18468#discussion_r1911773729 ## core/src/test/scala/unit/kafka/server/ReplicaFetcherThreadTest.scala: ## @@ -130,96 +128,12 @@ class ReplicaFetcherThreadTest { ApiKeys.FETCH.latestVersion(tru

Re: [PR] KAFKA-18465: Remove MetadataVersions older than 3.0-IV1 [kafka]

2025-01-10 Thread via GitHub
junrao commented on code in PR #18468: URL: https://github.com/apache/kafka/pull/18468#discussion_r1911773904 ## clients/src/main/java/org/apache/kafka/common/requests/AlterPartitionRequest.java: ## @@ -68,14 +68,12 @@ public static class Builder extends AbstractRequest.Builder

[jira] [Commented] (KAFKA-18477) remove usage of OffsetForLeaderEpochRequest in AbstractFetcherThread

2025-01-10 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-18477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17912156#comment-17912156 ] 黃竣陽 commented on KAFKA-18477: - Hello [~junrao], If you wont work on this, may I take it? >

Re: [PR] Kafka-16540: Update partitions if min isr config is changed. [kafka]

2025-01-10 Thread via GitHub
cmccabe commented on code in PR #18148: URL: https://github.com/apache/kafka/pull/18148#discussion_r1911575014 ## metadata/src/main/java/org/apache/kafka/controller/ConfigurationControlManager.java: ## @@ -352,6 +367,71 @@ private ApiError validateAlterConfig( return Ap

Re: [PR] MINOR: simplify producer code [kafka]

2025-01-10 Thread via GitHub
jolshan commented on PR #18486: URL: https://github.com/apache/kafka/pull/18486#issuecomment-2584693166 Long time no see @hachikuji 😉 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] MINOR: simplify producer code [kafka]

2025-01-10 Thread via GitHub
jolshan commented on code in PR #18486: URL: https://github.com/apache/kafka/pull/18486#discussion_r1911633047 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java: ## @@ -462,17 +462,10 @@ private boolean maybeSendAndPollTransactionalRequest() {

Re: [PR] MINOR: simplify producer code [kafka]

2025-01-10 Thread via GitHub
jolshan commented on code in PR #18486: URL: https://github.com/apache/kafka/pull/18486#discussion_r1911633047 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java: ## @@ -462,17 +462,10 @@ private boolean maybeSendAndPollTransactionalRequest() {

Re: [PR] MINOR: simplify producer code [kafka]

2025-01-10 Thread via GitHub
jolshan commented on PR #18486: URL: https://github.com/apache/kafka/pull/18486#issuecomment-2584705999 @mjsax can you make the title a bit more descriptive -- ie "simplifying producer abort error handling" -- This is an automated message from the Apache Git Service. To respond to the mes

Re: [PR] KAFKA-18464: Empty Abort Transaction can fence producer incorrectly with Transactions V2 [kafka]

2025-01-10 Thread via GitHub
jolshan merged PR #18467: URL: https://github.com/apache/kafka/pull/18467 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

Re: [PR] KAFKA-17182: Consumer fetch sessions are evicted too quickly with AsyncKafkaConsumer [kafka]

2025-01-10 Thread via GitHub
junrao commented on code in PR #17700: URL: https://github.com/apache/kafka/pull/17700#discussion_r1911759105 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/FetchRequestManagerTest.java: ## @@ -3437,6 +3441,72 @@ public void testPollWithRedundantCreateFetch

[jira] [Assigned] (KAFKA-18478) RocksDBTimeOrderedKeyValueBuffer does only use serdes from config

2025-01-10 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18478?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax reassigned KAFKA-18478: --- Assignee: Matthias J. Sax > RocksDBTimeOrderedKeyValueBuffer does only use serdes f

[jira] [Created] (KAFKA-18478) RocksDBTimeOrderedKeyValueBuffer does only use serdes from config

2025-01-10 Thread Matthias J. Sax (Jira)
Matthias J. Sax created KAFKA-18478: --- Summary: RocksDBTimeOrderedKeyValueBuffer does only use serdes from config Key: KAFKA-18478 URL: https://issues.apache.org/jira/browse/KAFKA-18478 Project: Kafk

Re: [PR] KAFKA-18466: Remove log4j-1.2-api from runtime scope while keeping it in distribution package [kafka]

2025-01-10 Thread via GitHub
frankvicky commented on PR #18472: URL: https://github.com/apache/kafka/pull/18472#issuecomment-2585127605 I have adopted the feature variant at the latest commit. generated pom: ![Screenshot from 2025-01-11 15-06-52](https://github.com/user-attachments/assets/073f9268-5e67-41f7-95

[jira] [Updated] (KAFKA-18370) Fix to Kraft or remove tests associate with Zk Broker config in ReplicaFetcherThreadTest

2025-01-10 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18370?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-18370: --- Fix Version/s: (was: 4.0.0) > Fix to Kraft or remove tests associate with Zk Broker conf

Re: [PR] KAFKA-18346: Fix e2e TestKRaftUpgrade from v3.3.2 [kafka]

2025-01-10 Thread via GitHub
TaiJuWu commented on PR #18386: URL: https://github.com/apache/kafka/pull/18386#issuecomment-2585133231 > To mitigate the 3.3 issue, we could add a flag to the `KafkaService` class to indicate whether different log directories have been used. During node restarts, this flag can be checked w

[PR] KAFKA-18324: Add CurrentAssignmentBuilder [kafka]

2025-01-10 Thread via GitHub
lucasbru opened a new pull request, #18476: URL: https://github.com/apache/kafka/pull/18476 Implements the current assignment builder, analogous to the current assignment builder of consumer groups. The main difference is the underlying assigned resource, and slightly different logic around

Re: [PR] KAFKA-18311: Enforcing copartitioned topics (4/N) [kafka]

2025-01-10 Thread via GitHub
lucasbru merged PR #18397: URL: https://github.com/apache/kafka/pull/18397 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Resolved] (KAFKA-9333) Shim `core` module that targets default scala version (KIP-531)

2025-01-10 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9333?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma resolved KAFKA-9333. Resolution: Won't Fix We'll instead rely on the `kafka-server` module for Java code and eventually

[jira] [Resolved] (KAFKA-4487) Tests should be run in Jenkins with INFO or DEBUG level

2025-01-10 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-4487?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma resolved KAFKA-4487. Resolution: Won't Fix Marking as "Won't fix" since it's been a long time and we have moved away fro

[jira] [Resolved] (KAFKA-12941) Remove excluded Streams tests when running with JDK 16

2025-01-10 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12941?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma resolved KAFKA-12941. - Resolution: Fixed This was resolved a while back. > Remove excluded Streams tests when running

  1   2   3   >