mjsax commented on code in PR #18490:
URL: https://github.com/apache/kafka/pull/18490#discussion_r1911865335
##########
streams/integration-tests/src/test/java/org/apache/kafka/streams/integration/StreamTableJoinWithGraceIntegrationTest.java:
##########
@@ -52,13 +54,13 @@ public class StreamTableJoinWithGraceIntegrationTest
extends AbstractJoinIntegra
@ValueSource(booleans = {true, false})
public void testInnerWithVersionedStore(final boolean cacheEnabled) {
final StreamsBuilder builder = new StreamsBuilder();
- final KStream<Long, String> leftStream =
builder.stream(INPUT_TOPIC_LEFT);
- final KTable<Long, String> rightTable =
builder.table(INPUT_TOPIC_RIGHT, Materialized.as(
+ final KStream<Long, String> leftStream =
builder.stream(INPUT_TOPIC_LEFT, Consumed.with(Serdes.Long(), Serdes.String()));
+ final KTable<Long, String> rightTable =
builder.table(INPUT_TOPIC_RIGHT, Consumed.with(Serdes.Long(), Serdes.String()),
Materialized.as(
Stores.persistentVersionedKeyValueStore(STORE_NAME,
Duration.ofMinutes(5))));
- final Properties streamsConfig = setupConfigsAndUtils(cacheEnabled);
+ final Properties streamsConfig = setupConfigsAndUtils(cacheEnabled,
false);
Review Comment:
To test `Joined` we use `false` here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
