[jira] [Commented] (KAFKA-17768) Update protobuf and commons-io dependencies in 3.7.2

2024-10-11 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1709#comment-1709 ] Chia-Ping Tsai commented on KAFKA-17768: [~frankvicky] 3.8 branch has the fix, s

[jira] [Assigned] (KAFKA-17768) Update protobuf and commons-io dependencies in 3.7.2

2024-10-11 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai reassigned KAFKA-17768: -- Assignee: TengYao Chi > Update protobuf and commons-io dependencies in 3.7.2 > --

[jira] [Commented] (KAFKA-17462) Removes intermediateTopicsOption from StreamsResetter

2024-10-11 Thread Peter Lee (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1719#comment-1719 ] Peter Lee commented on KAFKA-17462: --- Hi [~ardada2468], May I take this ticket? > Remo

Re: [PR] KAFKA-15859: Make RemoteListOffsets call an async operation [kafka]

2024-10-11 Thread via GitHub
kamalcph commented on PR #16602: URL: https://github.com/apache/kafka/pull/16602#issuecomment-2406984383 Thanks @junrao for the review comments! I will follow-up on them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[jira] [Resolved] (KAFKA-17764) Remove unnecessary ignorable annotations from RPC schemas

2024-10-11 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17764?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-17764. Resolution: Fixed > Remove unnecessary ignorable annotations from RPC schemas > --

Re: [PR] KAFKA-16985: Ensure consumer sends leave request on close even if interrupted [kafka]

2024-10-11 Thread via GitHub
dajac commented on PR #16686: URL: https://github.com/apache/kafka/pull/16686#issuecomment-2406678241 I like Jason's suggestion. I think that we could take this idea further and also have the background thread send a CloseCompleted event to the foreground thread when it is done with its cle

Re: [PR] KAFKA-17764: Remove unnecessary ignorable annotations [kafka]

2024-10-11 Thread via GitHub
chia7712 merged PR #17452: URL: https://github.com/apache/kafka/pull/17452 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[PR] KAFKA-17772: Remove `inControlledShutdownBrokers(Set)` and `unfenceBrokers(Set)` from `ReplicationControlManagerTest` [kafka]

2024-10-11 Thread via GitHub
chiacyu opened a new pull request, #17466: URL: https://github.com/apache/kafka/pull/17466 As titled, please check [KAFKA-17772](https://issues.apache.org/jira/browse/KAFKA-17772) for further details, thanks! ### Committer Checklist (excluded from commit message) - [ ] Verify desi

Re: [PR] Refactor: Improve code consistency and readability [kafka]

2024-10-11 Thread via GitHub
m1a2st commented on code in PR #17464: URL: https://github.com/apache/kafka/pull/17464#discussion_r1796525709 ## core/src/test/java/kafka/server/share/SharePartitionTest.java: ## @@ -87,10 +87,11 @@ public class SharePartitionTest { +public static final String ACQUISITI

Re: [PR] KAFKA-17747: Trigger rebalance on rack topology changes [kafka]

2024-10-11 Thread via GitHub
dajac commented on PR #17444: URL: https://github.com/apache/kafka/pull/17444#issuecomment-2406743415 Hi @FrankYang0529. Thanks for working on this. I have a few high level comments/questions to start with. 1. I am not convinced that using `hashCode()` is the right approach. Are we s

Re: [PR] Refactor: Improve code consistency and readability [kafka]

2024-10-11 Thread via GitHub
kwonyonghyun commented on PR #17464: URL: https://github.com/apache/kafka/pull/17464#issuecomment-2406762337 Thank you for the review @m1a2st ! I fixed the problems you mentioned -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[jira] [Commented] (KAFKA-17769) Fix flaky PlaintextConsumerSubscriptionTest.testSubscribeInvalidTopicCanUnsubscribe

2024-10-11 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17888553#comment-17888553 ] Chia-Ping Tsai commented on KAFKA-17769: That is a trade off. If we don’t allow

[PR] KAFKA-17633: Add share group record formatters and parsers. [kafka]

2024-10-11 Thread via GitHub
smjn opened a new pull request, #17467: URL: https://github.com/apache/kafka/pull/17467 As part of KIP-932, a new internal topic `__share_group_state` was introduced. There are 2 types of records which are currently being added in this topic. In light of this, we must make the existing t

Re: [PR] KAFKA-17772: Remove `inControlledShutdownBrokers(Set)` and `unfenceBrokers(Set)` from `ReplicationControlManagerTest` [kafka]

2024-10-11 Thread via GitHub
chia7712 merged PR #17466: URL: https://github.com/apache/kafka/pull/17466 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-17759: Remove Utils.mkSet [kafka]

2024-10-11 Thread via GitHub
chia7712 commented on PR #17460: URL: https://github.com/apache/kafka/pull/17460#issuecomment-2406987680 @gaurav-narula Could you please fix the conflicts and import errors? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[jira] [Resolved] (KAFKA-17772) Remove inControlledShutdownBrokers(Set) and unfenceBrokers(Set) from ReplicationControlManagerTest

2024-10-11 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17772?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-17772. Fix Version/s: 4.0.0 Resolution: Fixed > Remove inControlledShutdownBrokers(Set) an

[jira] [Commented] (KAFKA-17777) Flaky KafkaConsumerTest testReturnRecordsDuringRebalance

2024-10-11 Thread TengYao Chi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-1?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17888788#comment-17888788 ] TengYao Chi commented on KAFKA-1: - Hi [~lianetm]  I would like to investigate t

[jira] [Assigned] (KAFKA-17777) Flaky KafkaConsumerTest testReturnRecordsDuringRebalance

2024-10-11 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-1?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lianet Magrans reassigned KAFKA-1: -- Assignee: TengYao Chi > Flaky KafkaConsumerTest testReturnRecordsDuringRebalance > --

[jira] [Commented] (KAFKA-17777) Flaky KafkaConsumerTest testReturnRecordsDuringRebalance

2024-10-11 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-1?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17888792#comment-17888792 ] Lianet Magrans commented on KAFKA-1: Sure, let me know if I can help with re

[PR] KAFKA-17778: Add listener to remove client instances on connection disconnect [kafka]

2024-10-11 Thread via GitHub
apoorvmittal10 opened a new pull request, #17474: URL: https://github.com/apache/kafka/pull/17474 The PR uses the capability added in PR: https://github.com/apache/kafka/pull/17473, which allows to attach listener for client instances cleanup on client disconnection. The ClientsMetri

Re: [PR] KAFKA-17778: Add listener to remove client instances on connection disconnect [kafka]

2024-10-11 Thread via GitHub
apoorvmittal10 commented on PR #17474: URL: https://github.com/apache/kafka/pull/17474#issuecomment-2408242643 Build will pass once this PR is rebased over dependent PR: https://github.com/apache/kafka/pull/17473 -- This is an automated message from the Apache Git Service. To respond to t

[jira] [Resolved] (KAFKA-17775) Remove Java#IS_JAVA9_COMPATIBLE property

2024-10-11 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-17775?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] 黃竣陽 resolved KAFKA-17775. - Resolution: Duplicate > Remove Java#IS_JAVA9_COMPATIBLE property > > >

[jira] [Created] (KAFKA-17779) Fix flaky RemoteLogManagerTest#testFetchOffsetByTimestampWithTieredStorageDoesNotFetchIndexWhenExistsLocally

2024-10-11 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-17779: -- Summary: Fix flaky RemoteLogManagerTest#testFetchOffsetByTimestampWithTieredStorageDoesNotFetchIndexWhenExistsLocally Key: KAFKA-17779 URL: https://issues.apache.org/jira/brow

Re: [PR] MINOR: fix some GHA `run` syntax [kafka]

2024-10-11 Thread via GitHub
chia7712 merged PR #17471: URL: https://github.com/apache/kafka/pull/17471 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[PR] KAFKA-17099: Print the origin processor node in logs for processing exceptions [kafka]

2024-10-11 Thread via GitHub
loicgreffier opened a new pull request, #17475: URL: https://github.com/apache/kafka/pull/17475 This PR leverages the updates brought by [KIP-1033](https://cwiki.apache.org/confluence/display/KAFKA/KIP-1033%3A+Add+Kafka+Streams+exception+handler+for+exceptions+occurring+during+processing) t

Re: [PR] Adjust maximum value of group.share.record.lock.duration.ms [kafka]

2024-10-11 Thread via GitHub
chia7712 merged PR #17472: URL: https://github.com/apache/kafka/pull/17472 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-17407: Fix flaky ShareGroupHeartbeatRequestTest.testPartitionAssignmentWithChangingTopics [kafka]

2024-10-11 Thread via GitHub
m1a2st commented on PR #16994: URL: https://github.com/apache/kafka/pull/16994#issuecomment-2408279705 @chia7712, @AndrewJSchofield Thanks for your review, it seens pass the ci, and flaky anymore. -- This is an automated message from the Apache Git Service. To respond to the message, plea

[jira] [Updated] (KAFKA-17713) Ensure snapshots are aligned to batch boundaries

2024-10-11 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-17713: --- Fix Version/s: 4.0.0 > Ensure snapshots are aligned to batch boundaries > --

[jira] [Commented] (KAFKA-17704) possible race condition in TTL credentials when connectors recycled on single node instance

2024-10-11 Thread Dmitri Pavlov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17888555#comment-17888555 ] Dmitri Pavlov commented on KAFKA-17704: --- Sorry one more question -> could you, ple

[PR] KAFKA-17776: Capability for connection disconnect listeners in socket server [kafka]

2024-10-11 Thread via GitHub
apoorvmittal10 opened a new pull request, #17473: URL: https://github.com/apache/kafka/pull/17473 As of now, there isn't any way that resources can be cleaned in Kafka when client disconnects the connections. Generally time bound clean up happens which keep the resources occupied. Th

[jira] [Created] (KAFKA-17778) Clean up client instance cache on connection close

2024-10-11 Thread Apoorv Mittal (Jira)
Apoorv Mittal created KAFKA-17778: - Summary: Clean up client instance cache on connection close Key: KAFKA-17778 URL: https://issues.apache.org/jira/browse/KAFKA-17778 Project: Kafka Issue Ty

[jira] [Comment Edited] (KAFKA-15485) Support building with Java 21 (LTS release)

2024-10-11 Thread Sergio Troiano (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17888516#comment-17888516 ] Sergio Troiano edited comment on KAFKA-15485 at 10/11/24 10:05 PM: ---

Re: [PR] KAFKA-17746 Replace JavaConverters with CollectionConverters [kafka]

2024-10-11 Thread via GitHub
chia7712 commented on code in PR #17451: URL: https://github.com/apache/kafka/pull/17451#discussion_r1797521277 ## core/src/test/java/kafka/test/api/ShareConsumerTest.java: ## @@ -1635,7 +1636,7 @@ private KafkaShareConsumer createShareConsumer(Deserializer keyD private v

Re: [PR] KAFKA-17741: cleanup code base for JDK 11 [kafka]

2024-10-11 Thread via GitHub
chia7712 commented on code in PR #17441: URL: https://github.com/apache/kafka/pull/17441#discussion_r1797523298 ## clients/src/main/java/org/apache/kafka/common/utils/ByteBufferUnmapper.java: ## @@ -87,10 +87,7 @@ public static void unmap(String resourceDescription, ByteBuffer

Re: [PR] KAFKA-17199: Add UT for TransactionLogConfig and TransactionStateManagerConfig [kafka]

2024-10-11 Thread via GitHub
chia7712 merged PR #17442: URL: https://github.com/apache/kafka/pull/17442 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Resolved] (KAFKA-17199) add unit tests for TransactionLogConfig and TransactionStateManagerConfig

2024-10-11 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-17199. Fix Version/s: 4.0.0 Resolution: Fixed > add unit tests for TransactionLogConfig an

Re: [PR] KAFKA-17746 Replace JavaConverters with CollectionConverters [kafka]

2024-10-11 Thread via GitHub
Linsiyuan9 commented on code in PR #17451: URL: https://github.com/apache/kafka/pull/17451#discussion_r1797530783 ## core/src/test/java/kafka/test/api/ShareConsumerTest.java: ## @@ -1635,7 +1636,7 @@ private KafkaShareConsumer createShareConsumer(Deserializer keyD private

[jira] [Updated] (KAFKA-17723) Fix "this-escape" compiler warnings (MultiThreadedEventProcessor and DistributedHerder) introduced by JDK 23

2024-10-11 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-17723: --- Summary: Fix "this-escape" compiler warnings (MultiThreadedEventProcessor and DistributedHer

Re: [PR] KAFKA-17763: Remove `Utils.covariantCast` and use `var` for type inference [kafka]

2024-10-11 Thread via GitHub
LoganZhuZzz commented on PR #17468: URL: https://github.com/apache/kafka/pull/17468#issuecomment-2407037857 https://github.com/user-attachments/assets/53a0db7f-991c-41a0-9446-758485d389a9";> All relevant tests affected by the changes have passed successfully. @chia7712 -- This is an a

[jira] [Updated] (KAFKA-17639) Add Java 23 to CI build matrix

2024-10-11 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17639?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-17639: --- Parent: KAFKA-17638 Issue Type: Sub-task (was: Task) > Add Java 23 to CI build matr

[jira] [Created] (KAFKA-17773) Upgrade spotbug to work under java 23

2024-10-11 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-17773: -- Summary: Upgrade spotbug to work under java 23 Key: KAFKA-17773 URL: https://issues.apache.org/jira/browse/KAFKA-17773 Project: Kafka Issue Type: Sub-tas

Re: [PR] KAFKA-17724: Move SubscriptionState changes to background thread [kafka]

2024-10-11 Thread via GitHub
chia7712 commented on code in PR #17418: URL: https://github.com/apache/kafka/pull/17418#discussion_r1796911312 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/ApplicationEventProcessor.java: ## @@ -358,12 +358,19 @@ private void process(final ShareAc

Re: [PR] KAFKA-17767 Extract test catalog from JUnit output [1/n] [kafka]

2024-10-11 Thread via GitHub
chia7712 commented on code in PR #17397: URL: https://github.com/apache/kafka/pull/17397#discussion_r1797031847 ## build.gradle: ## @@ -503,7 +518,8 @@ subprojects { // were not run, but instead were restored via FROM-CACHE. See KAFKA-17479 for more details. doLast {

Re: [PR] KAFKA-17715 remove force_use_zk_connection from e2e [kafka]

2024-10-11 Thread via GitHub
mimaison commented on code in PR #17465: URL: https://github.com/apache/kafka/pull/17465#discussion_r1797199822 ## tests/kafkatest/services/kafka/kafka.py: ## @@ -1010,84 +1010,68 @@ def kafka_metadata_quorum_cmd(self, node, kafka_security_protocol=None, use_cont kafka

Re: [PR] KAFKA-17600: Add nextOffsets to the ConsumerRecords [kafka]

2024-10-11 Thread via GitHub
AndrewJSchofield commented on code in PR #17414: URL: https://github.com/apache/kafka/pull/17414#discussion_r1797182983 ## clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerRecords.java: ## @@ -32,12 +32,19 @@ * partition returned by a {@link Consumer#poll(java.t

Re: [PR] KAFKA-10551: Add topic id support to produce request and response [kafka]

2024-10-11 Thread via GitHub
junrao commented on code in PR #15968: URL: https://github.com/apache/kafka/pull/15968#discussion_r1785440699 ## core/src/test/scala/integration/kafka/api/ProducerSendWhileDeletionTest.scala: ## @@ -84,4 +84,94 @@ class ProducerSendWhileDeletionTest extends IntegrationTestHarne

[jira] [Created] (KAFKA-17777) Flaky KafkaConsumerTest testReturnRecordsDuringRebalance

2024-10-11 Thread Lianet Magrans (Jira)
Lianet Magrans created KAFKA-1: -- Summary: Flaky KafkaConsumerTest testReturnRecordsDuringRebalance Key: KAFKA-1 URL: https://issues.apache.org/jira/browse/KAFKA-1 Project: Kafka

[jira] [Updated] (KAFKA-17777) Flaky KafkaConsumerTest testReturnRecordsDuringRebalance

2024-10-11 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-1?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lianet Magrans updated KAFKA-1: --- Component/s: consumer > Flaky KafkaConsumerTest testReturnRecordsDuringRebalance > -

[jira] [Updated] (KAFKA-17776) Add connection disconnect listener in socket server

2024-10-11 Thread Apoorv Mittal (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17776?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Mittal updated KAFKA-17776: -- Fix Version/s: 4.0.0 > Add connection disconnect listener in socket server > -

[jira] [Updated] (KAFKA-17776) Add connection disconnect listener in socket server

2024-10-11 Thread Apoorv Mittal (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17776?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Mittal updated KAFKA-17776: -- Affects Version/s: 4.0.0 > Add connection disconnect listener in socket server > -

[jira] [Updated] (KAFKA-17776) Add connection disconnect listener in socket server

2024-10-11 Thread Apoorv Mittal (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17776?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Mittal updated KAFKA-17776: -- Component/s: core > Add connection disconnect listener in socket server >

[jira] [Created] (KAFKA-17774) Add capability for max fetch records in share fetch

2024-10-11 Thread Apoorv Mittal (Jira)
Apoorv Mittal created KAFKA-17774: - Summary: Add capability for max fetch records in share fetch Key: KAFKA-17774 URL: https://issues.apache.org/jira/browse/KAFKA-17774 Project: Kafka Issue T

Re: [PR] KAFKA-17600: Add nextOffsets to the ConsumerRecords [kafka]

2024-10-11 Thread via GitHub
aliehsaeedii commented on PR #17414: URL: https://github.com/apache/kafka/pull/17414#issuecomment-2407470969 @lucasbru >I suppose (without checking further) that this would mean that partRecords is empty here. I assume when control records are returned, `partRecords` is empty whil

[jira] [Resolved] (KAFKA-17717) Remove ConfigUtils#translateDeprecatedConfigs

2024-10-11 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17717?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-17717. Fix Version/s: 4.0.0 Resolution: Fixed > Remove ConfigUtils#translateDeprecatedConf

[jira] [Assigned] (KAFKA-17717) Remove ConfigUtils#translateDeprecatedConfigs

2024-10-11 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17717?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai reassigned KAFKA-17717: -- Assignee: Mingdao Yang (was: Chia-Ping Tsai) > Remove ConfigUtils#translateDeprecate

Re: [PR] KAFKA-17767 Extract test catalog from JUnit output [1/n] [kafka]

2024-10-11 Thread via GitHub
mumrah commented on code in PR #17397: URL: https://github.com/apache/kafka/pull/17397#discussion_r1797000223 ## build.gradle: ## @@ -212,7 +212,22 @@ def determineCommitId() { } } - +/** + * For a given Project, compute a nice dash separated directory name + * to store th

Re: [PR] KAFKA-17717 Remove ConfigUtils#translateDeprecatedConfigs and tests [kafka]

2024-10-11 Thread via GitHub
chia7712 merged PR #17458: URL: https://github.com/apache/kafka/pull/17458 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-17724: Move SubscriptionState changes to background thread [kafka]

2024-10-11 Thread via GitHub
lianetm commented on code in PR #17418: URL: https://github.com/apache/kafka/pull/17418#discussion_r1797011447 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ShareConsumerImpl.java: ## @@ -519,12 +518,10 @@ public void subscribe(final Collection topics) {

Re: [PR] KAFKA-17724: Move SubscriptionState changes to background thread [kafka]

2024-10-11 Thread via GitHub
lianetm commented on code in PR #17418: URL: https://github.com/apache/kafka/pull/17418#discussion_r1797011447 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ShareConsumerImpl.java: ## @@ -519,12 +518,10 @@ public void subscribe(final Collection topics) {

Re: [PR] KAFKA-17661: Fix flaky BufferPoolTest.testBlockTimeout [kafka]

2024-10-11 Thread via GitHub
chia7712 merged PR #17319: URL: https://github.com/apache/kafka/pull/17319 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Resolved] (KAFKA-17661) Fix flaky BufferPoolTest.testBlockTimeout

2024-10-11 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17661?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-17661. Fix Version/s: 4.0.0 Resolution: Fixed > Fix flaky BufferPoolTest.testBlockTimeout

Re: [PR] KAFKA-17671: Create better documentation for transactions [kafka]

2024-10-11 Thread via GitHub
AndrewJSchofield commented on code in PR #17454: URL: https://github.com/apache/kafka/pull/17454#discussion_r1796727208 ## docs/design.html: ## @@ -160,7 +160,7 @@ -Details on configuration and the https://kafka.apache.org/{{version}}/javadoc/org/apache/kafka/clients/produc

[jira] [Assigned] (KAFKA-17766) TopicBasedRemoteLogMetadataManager stuck in close

2024-10-11 Thread Satish Duggana (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17766?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Satish Duggana reassigned KAFKA-17766: -- Assignee: Anshul Goyal > TopicBasedRemoteLogMetadataManager stuck in close >

[jira] [Commented] (KAFKA-17766) TopicBasedRemoteLogMetadataManager stuck in close

2024-10-11 Thread Satish Duggana (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17888596#comment-17888596 ] Satish Duggana commented on KAFKA-17766: [~anshul35] You can try looking into it

Re: [PR] KAFKA-17600: Add nextOffsets to the ConsumerRecords [kafka]

2024-10-11 Thread via GitHub
lucasbru commented on PR #17414: URL: https://github.com/apache/kafka/pull/17414#issuecomment-2407529164 > I assume when control records are returned, partRecords is empty while the position is advanced. You are right. Anyway, I'd assume we add a TP to `nextOffsets` if the position a

Re: [PR] KAFKA-17724: Move SubscriptionState changes to background thread [kafka]

2024-10-11 Thread via GitHub
lianetm commented on code in PR #17418: URL: https://github.com/apache/kafka/pull/17418#discussion_r1797021034 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ShareConsumerImplTest.java: ## @@ -306,32 +344,49 @@ public void testCompleteQuietly() { @Te

[jira] [Updated] (KAFKA-17640) Document Java 23 support and include release note

2024-10-11 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17640?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-17640: --- Parent: KAFKA-17638 Issue Type: Sub-task (was: Task) > Document Java 23 support and

[jira] [Updated] (KAFKA-17722) Fix "this-escape" compiler warnings (BrokerTopicMetrics) introduced by JDK 23

2024-10-11 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-17722: --- Summary: Fix "this-escape" compiler warnings (BrokerTopicMetrics) introduced by JDK 23 (was

[jira] [Updated] (KAFKA-17722) Fix "this-escape" compiler warnings (MultiThreadedEventProcessor and DistributedHerder) introduced by JDK 23

2024-10-11 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-17722: --- Summary: Fix "this-escape" compiler warnings (MultiThreadedEventProcessor and DistributedHer

[jira] [Updated] (KAFKA-17723) Fix "this-escape" compiler warnings (MultiThreadedEventProcessor and DistributedHerder) introduced by JDK 23

2024-10-11 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-17723: --- Parent: KAFKA-17638 Issue Type: Sub-task (was: Improvement) > Fix "this-escape" com

[jira] [Updated] (KAFKA-17722) Fix 'this' escape of BrokerTopicMetrics

2024-10-11 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-17722: --- Parent: KAFKA-17638 Issue Type: Sub-task (was: Improvement) > Fix 'this' escape of

Re: [PR] KAFKA-17633: Add share group record formatter and parser. [kafka]

2024-10-11 Thread via GitHub
AndrewJSchofield commented on code in PR #17467: URL: https://github.com/apache/kafka/pull/17467#discussion_r1796689795 ## core/src/main/scala/kafka/tools/DumpLogSegments.scala: ## @@ -628,6 +630,68 @@ object DumpLogSegments { } } + // for test visibility + class Sha

Re: [PR] KAFKA-17633: Add share group record formatter and parser. [kafka]

2024-10-11 Thread via GitHub
smjn commented on code in PR #17467: URL: https://github.com/apache/kafka/pull/17467#discussion_r1796706353 ## core/src/main/scala/kafka/tools/DumpLogSegments.scala: ## @@ -628,6 +630,68 @@ object DumpLogSegments { } } + // for test visibility + class ShareGroupState

Re: [PR] KAFKA-17671: Create better documentation for transactions [kafka]

2024-10-11 Thread via GitHub
AndrewJSchofield commented on code in PR #17454: URL: https://github.com/apache/kafka/pull/17454#discussion_r1796713363 ## docs/design.html: ## @@ -290,24 +290,56 @@ https://kafka.apache.org/documentation/streams";>Kafka Streams -application), we can leverage the new transac

Re: [PR] KAFKA-17600: Add nextOffsets to the ConsumerRecords [kafka]

2024-10-11 Thread via GitHub
aliehsaeedii commented on code in PR #17414: URL: https://github.com/apache/kafka/pull/17414#discussion_r1796969771 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/FetchCollector.java: ## @@ -195,7 +196,7 @@ private Fetch fetchRecords(final CompletedFetch n

Re: [PR] MINOR: remove unused method in IntegrationTestUtils [kafka]

2024-10-11 Thread via GitHub
m1a2st commented on PR #17469: URL: https://github.com/apache/kafka/pull/17469#issuecomment-2407441896 This method not used in any test, but it have a todo tag, Im not sure we should remove it ``` def clientSecurityProps(certAlias: String): Properties = { JaasTestUtils.securi

[PR] MINOR: remove unused method in IntegrationTestUtils [kafka]

2024-10-11 Thread via GitHub
m1a2st opened a new pull request, #17469: URL: https://github.com/apache/kafka/pull/17469 I found some method already not used in test, we should remove it. *Summary of testing strategy (including rationale) for the feature or bug fix. Unit and/or integration tests are expected f

Re: [PR] KAFKA-17600: Add nextOffsets to the ConsumerRecords [kafka]

2024-10-11 Thread via GitHub
lucasbru commented on code in PR #17414: URL: https://github.com/apache/kafka/pull/17414#discussion_r1796868931 ## clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerRecords.java: ## @@ -53,6 +60,14 @@ public List> records(TopicPartition partition) { r

[jira] [Comment Edited] (KAFKA-17769) Fix flaky PlaintextConsumerSubscriptionTest.testSubscribeInvalidTopicCanUnsubscribe

2024-10-11 Thread Yu-Lin Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17888621#comment-17888621 ] Yu-Lin Chen edited comment on KAFKA-17769 at 10/11/24 12:12 PM: --

[jira] [Commented] (KAFKA-17769) Fix flaky PlaintextConsumerSubscriptionTest.testSubscribeInvalidTopicCanUnsubscribe

2024-10-11 Thread Yu-Lin Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17888621#comment-17888621 ] Yu-Lin Chen commented on KAFKA-17769: - Hi [~chia7712] , Thanks for the explanation,

Re: [PR] KAFKA-17759: Remove Utils.mkSet [kafka]

2024-10-11 Thread via GitHub
gaurav-narula commented on PR #17460: URL: https://github.com/apache/kafka/pull/17460#issuecomment-2407358268 @chia7712 Please have a look now -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] KAFKA-17724: Move SubscriptionState changes to background thread [kafka]

2024-10-11 Thread via GitHub
AndrewJSchofield commented on code in PR #17418: URL: https://github.com/apache/kafka/pull/17418#discussion_r1797137085 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/ShareSubscriptionChangeEvent.java: ## @@ -17,14 +17,31 @@ package org.apache.kaf

Re: [PR] KAFKA-17532-2: Moved ShareGroupConfig and added share.record.lock.duration.ms to dynamic configs [kafka]

2024-10-11 Thread via GitHub
AndrewJSchofield commented on code in PR #17331: URL: https://github.com/apache/kafka/pull/17331#discussion_r1797213556 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupConfig.java: ## @@ -57,13 +62,20 @@ public class GroupConfig extends AbstractConfig

Re: [PR] KAFKA-17767 Extract test catalog from JUnit output [1/n] [kafka]

2024-10-11 Thread via GitHub
mumrah commented on PR #17397: URL: https://github.com/apache/kafka/pull/17397#issuecomment-2407829283 With latest changes, the files in the test catalog: ``` ./clients ./clients/tests.yaml ./tools ./tools/tests.yaml ./tools/tools-api ./tools/tools-api/tests.yaml .

[PR] MINOR: fix some run syntax [kafka]

2024-10-11 Thread via GitHub
mumrah opened a new pull request, #17471: URL: https://github.com/apache/kafka/pull/17471 This fixes some of our `run` steps in our workflows to follow best practices. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[PR] MINOR: clean up job names [kafka]

2024-10-11 Thread via GitHub
mumrah opened a new pull request, #17470: URL: https://github.com/apache/kafka/pull/17470 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of testing

Re: [PR] KAFKA-17741: cleanup code base for JDK 11 [kafka]

2024-10-11 Thread via GitHub
frankvicky commented on PR #17441: URL: https://github.com/apache/kafka/pull/17441#issuecomment-2407687562 Hi @chia7712 I have fixed the conflicts, PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[PR] Adjust maximum value of group.share.record.lock.duration.ms [kafka]

2024-10-11 Thread via GitHub
AndrewJSchofield opened a new pull request, #17472: URL: https://github.com/apache/kafka/pull/17472 As discussed in https://github.com/apache/kafka/pull/17331#discussion_r1795008371, people were confused that the broker config `group.sh.record.lock.duration.ms` had a maximum value less tha

[jira] [Created] (KAFKA-17776) Add connection disconnect listener in socket server

2024-10-11 Thread Apoorv Mittal (Jira)
Apoorv Mittal created KAFKA-17776: - Summary: Add connection disconnect listener in socket server Key: KAFKA-17776 URL: https://issues.apache.org/jira/browse/KAFKA-17776 Project: Kafka Issue T

Re: [PR] Enable pending reassignments cancellation/rollback [kafka]

2024-10-11 Thread via GitHub
georgeli-roblox commented on PR #6296: URL: https://github.com/apache/kafka/pull/6296#issuecomment-2407866659 > Any progress ? @sql888 oh, the new reassignment (since version`2.8.2`) supports Adding/Removing replicas in the topic metadata, so it's easy to rollback. -- This is

[jira] [Created] (KAFKA-17775) Remove Java#IS_JAVA9_COMPATIBLE property

2024-10-11 Thread Jira
黃竣陽 created KAFKA-17775: --- Summary: Remove Java#IS_JAVA9_COMPATIBLE property Key: KAFKA-17775 URL: https://issues.apache.org/jira/browse/KAFKA-17775 Project: Kafka Issue Type: Improvement Re

[jira] [Updated] (KAFKA-17775) Remove Java#IS_JAVA9_COMPATIBLE property

2024-10-11 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-17775?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] 黃竣陽 updated KAFKA-17775: Parent: KAFKA-17757 Issue Type: Sub-task (was: Improvement) > Remove Java#IS_JAVA9_COMPATIBLE property >

Re: [PR] KAFKA-17536: Ensure clear error message when new consumer used with incompatible cluster [kafka]

2024-10-11 Thread via GitHub
lianetm commented on PR #17411: URL: https://github.com/apache/kafka/pull/17411#issuecomment-2407977107 Hey folks, aligned with @dajac 's comment on the approach, I think we should keep the solution scoped to the client and the HB RPC specifically (which is what will fail in this scenario w

Re: [PR] KAFKA-17753: Update protobuf and commons-io dependencies [kafka]

2024-10-11 Thread via GitHub
chia7712 merged PR #17453: URL: https://github.com/apache/kafka/pull/17453 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Updated] (KAFKA-17753) Update protobuf and commons-io dependencies

2024-10-11 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17753?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-17753: --- Fix Version/s: 3.8.1 > Update protobuf and commons-io dependencies > ---

[jira] [Commented] (KAFKA-17768) Update protobuf and commons-io dependencies in 3.7.2

2024-10-11 Thread TengYao Chi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1708#comment-1708 ] TengYao Chi commented on KAFKA-17768: - Hi [~cmccabe]  I would like to handle this is

[PR] MINOR: Fix transactionPartitionVerificationEnable return type [kafka]

2024-10-11 Thread via GitHub
clarkwtc opened a new pull request, #17476: URL: https://github.com/apache/kafka/pull/17476 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of testin

Re: [PR] MINOR: clean up GHA names [kafka]

2024-10-11 Thread via GitHub
chia7712 commented on PR #17470: URL: https://github.com/apache/kafka/pull/17470#issuecomment-2408328375 see https://github.com/apache/kafka/pull/17476/checks and the name LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[PR] KAFKA-17768: Update protobuf and commons-io dependencies in 3.7.2 [kafka]

2024-10-11 Thread via GitHub
frankvicky opened a new pull request, #17477: URL: https://github.com/apache/kafka/pull/17477 JIRA: KAFKA-17768(https://issues.apache.org/jira/browse/KAFKA-17768) Update protobuf and Apache commons-io because earlier versions are vulnerable. protobuf: [CVE-2024-7254](https://github.com

Re: [PR] KAFKA-3494: add metric id to client mbeans [kafka]

2024-10-11 Thread via GitHub
github-actions[bot] closed pull request #1323: KAFKA-3494: add metric id to client mbeans URL: https://github.com/apache/kafka/pull/1323 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

  1   2   >