dajac commented on PR #17444: URL: https://github.com/apache/kafka/pull/17444#issuecomment-2406743415
Hi @FrankYang0529. Thanks for working on this. I have a few high level comments/questions to start with. 1. I am not convinced that using `hashCode()` is the right approach. Are we sure that we won't have collision with it? Another thing is that the `hashCode` implementation may differ between versions of the JVM. An alternative would be use to MurmurHash for instance. What do you think? 2. With this approach, I was hoping that we could actually get rid of the `Map<String, TopicMetadata>` data structure and have a hash which replaces all of it. The idea would be to rely on the MetadataImage instead and to have a hash to detect when the metadata that we rely one has changed in the image. Have you considered something like this? Regarding option 1) in https://issues.apache.org/jira/browse/KAFKA-17747, have you discarded it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
