Re: [PR] KAFKA-16379: Coordinator event queue, processing, flush, purgatory time histograms [kafka]

2024-09-11 Thread via GitHub
dimitarndimitrov commented on code in PR #16949: URL: https://github.com/apache/kafka/pull/16949#discussion_r1753395793 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/metrics/HdrHistogram.java: ## @@ -0,0 +1,145 @@ +/* + * Licensed to the Apache Software F

[jira] [Created] (KAFKA-17520) align the low bound of ducktape version

2024-09-11 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-17520: -- Summary: align the low bound of ducktape version Key: KAFKA-17520 URL: https://issues.apache.org/jira/browse/KAFKA-17520 Project: Kafka Issue Type: Impr

Re: [PR] KAFKA-15319: Upgrade rocksdb to fix CVE-2022-37434 [kafka]

2024-09-11 Thread via GitHub
chia7712 commented on PR #14216: URL: https://github.com/apache/kafka/pull/14216#issuecomment-2342917872 @lucasbru I open https://issues.apache.org/jira/browse/KAFKA-17520 for bumping the version. Please let me know if you have any concerns -- This is an automated message from the Apache

[jira] [Commented] (KAFKA-17520) align the low bound of ducktape version

2024-09-11 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17880888#comment-17880888 ] Chia-Ping Tsai commented on KAFKA-17520: the required version in https://github

[jira] [Commented] (KAFKA-17520) align the low bound of ducktape version

2024-09-11 Thread Eric Chang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17880890#comment-17880890 ] Eric Chang commented on KAFKA-17520: May I take this issue ? > align the low bound

Re: [PR] KAFKA-17290: Added Integration tests for ShareFetch and ShareAcknowledge APIs [kafka]

2024-09-11 Thread via GitHub
omkreddy merged PR #16916: URL: https://github.com/apache/kafka/pull/16916 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-17347: Add missing client-metrics option to kafka-configs.sh [kafka]

2024-09-11 Thread via GitHub
AndrewJSchofield commented on code in PR #17046: URL: https://github.com/apache/kafka/pull/17046#discussion_r1753746159 ## core/src/test/java/kafka/admin/ConfigCommandIntegrationTest.java: ## @@ -620,6 +699,17 @@ private void deleteAndVerifyGroupConfigValue(Admin client,

Re: [PR] KAFKA-17048; Add docs for KIP-853 [kafka]

2024-09-11 Thread via GitHub
mimaison commented on code in PR #17076: URL: https://github.com/apache/kafka/pull/17076#discussion_r1753754828 ## docs/quickstart.html: ## @@ -32,8 +32,8 @@ the latest Kafka release and extract it: -$ tar -xzf kafka_{{scalaVersion}}-{{fullDotV

Re: [PR] KAFKA-17048; Add docs for KIP-853 [kafka]

2024-09-11 Thread via GitHub
mimaison commented on code in PR #17076: URL: https://github.com/apache/kafka/pull/17076#discussion_r1753776432 ## docs/ops.html: ## @@ -3776,25 +3776,71 @@ controller.quorum.voters=id1@host1:port1,id2@host2:port2,id3@host3:port3 + controller.quorum.bootstrap.servers=host1:port

Re: [PR] KAFKA-17048; Add docs for KIP-853 [kafka]

2024-09-11 Thread via GitHub
mimaison commented on code in PR #17076: URL: https://github.com/apache/kafka/pull/17076#discussion_r1753780968 ## docs/ops.html: ## @@ -3776,25 +3776,77 @@ controller.quorum.voters=id1@host1:port1,id2@host2:port2,id3@host3:port3 + controller.quorum.bootstrap.servers=host1:port

Re: [PR] KAFKA-17048; Add docs for KIP-853 [kafka]

2024-09-11 Thread via GitHub
mimaison commented on code in PR #17076: URL: https://github.com/apache/kafka/pull/17076#discussion_r1753837295 ## docs/ops.html: ## @@ -3776,25 +3776,77 @@ controller.quorum.voters=id1@host1:port1,id2@host2:port2,id3@host3:port3 + controller.quorum.bootstrap.servers=host1:port

Re: [PR] KAFKA-17048; Add docs for KIP-853 [kafka]

2024-09-11 Thread via GitHub
mimaison commented on code in PR #17076: URL: https://github.com/apache/kafka/pull/17076#discussion_r1753841794 ## docs/ops.html: ## @@ -3776,25 +3776,77 @@ controller.quorum.voters=id1@host1:port1,id2@host2:port2,id3@host3:port3 + controller.quorum.bootstrap.servers=host1:port

Re: [PR] KAFKA-17048; Add docs for KIP-853 [kafka]

2024-09-11 Thread via GitHub
mimaison commented on code in PR #17076: URL: https://github.com/apache/kafka/pull/17076#discussion_r1753849319 ## config/kraft/reconfig-server.properties: ## @@ -0,0 +1,132 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more Review Comment: It's unclear

Re: [PR] KAFKA-17448: New consumer seek should update positions in background thread [kafka]

2024-09-11 Thread via GitHub
FrankYang0529 commented on code in PR #17075: URL: https://github.com/apache/kafka/pull/17075#discussion_r1753881144 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/SeekUnvalidatedEvent.java: ## @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache Software

[jira] [Created] (KAFKA-17521) bootstrap-controller option buggy behavior

2024-09-11 Thread Michal Medvecky (Jira)
Michal Medvecky created KAFKA-17521: --- Summary: bootstrap-controller option buggy behavior Key: KAFKA-17521 URL: https://issues.apache.org/jira/browse/KAFKA-17521 Project: Kafka Issue Type:

Re: [PR] KAFKA-12829: Remove deprecated StreamsBuilder#addGlobalStore of old Processor API [kafka]

2024-09-11 Thread via GitHub
pegasas commented on PR #17059: URL: https://github.com/apache/kafka/pull/17059#issuecomment-2343272830 ![image](https://github.com/user-attachments/assets/c511e96c-9192-4c2c-bdb5-2141dc4f509f) ![image](https://github.com/user-attachments/assets/6a350d14-57b4-4130-8a79-4175533288fa) f

Re: [PR] KAFKA-17347: Add missing client-metrics option to kafka-configs.sh [kafka]

2024-09-11 Thread via GitHub
chia7712 commented on code in PR #17046: URL: https://github.com/apache/kafka/pull/17046#discussion_r1754016599 ## core/src/test/java/kafka/admin/ConfigCommandIntegrationTest.java: ## @@ -620,6 +699,17 @@ private void deleteAndVerifyGroupConfigValue(Admin client, verify

Re: [PR] KAFKA-17439: Make polling for new records an explicit action/event in the new consumer [kafka]

2024-09-11 Thread via GitHub
AndrewJSchofield commented on code in PR #17035: URL: https://github.com/apache/kafka/pull/17035#discussion_r1754077572 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/FetchRequestManager.java: ## @@ -65,16 +67,59 @@ protected void maybeThrowAuthFailure(Node

Re: [PR] KAFKA-17287: Added integration tests for ShareConsumer [kafka]

2024-09-11 Thread via GitHub
AndrewJSchofield commented on PR #17009: URL: https://github.com/apache/kafka/pull/17009#issuecomment-234165 While the tests seem generally quite reliable, I see very occasional failures. Please chase them down. -- This is an automated message from the Apache Git Service. To respond t

Re: [PR] KAFKA-17109: implement exponential backoff for state directory lock [kafka]

2024-09-11 Thread via GitHub
lucasbru merged PR #17116: URL: https://github.com/apache/kafka/pull/17116 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] MINOR: Bump zstd-jni from 1.5.6-4 to 1.5.6-5 [kafka]

2024-09-11 Thread via GitHub
olegbonar commented on PR #17151: URL: https://github.com/apache/kafka/pull/17151#issuecomment-2343373691 Looks like some flaky tests failed, probably not related to the PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

Re: [PR] KAFKA-17508: Adding some guard for fallback deletion logic [kafka]

2024-09-11 Thread via GitHub
FrankYang0529 commented on code in PR #17154: URL: https://github.com/apache/kafka/pull/17154#discussion_r1754278310 ## storage/src/main/java/org/apache/kafka/storage/internals/log/LogSegment.java: ## @@ -805,6 +805,10 @@ private Void deleteTypeIfExists(StorageAction delete, Str

Re: [PR] KAFKA-17400: Added share fetch purgatory for delaying share fetch requests [kafka]

2024-09-11 Thread via GitHub
adixitconfluent commented on code in PR #16969: URL: https://github.com/apache/kafka/pull/16969#discussion_r1754336687 ## core/src/main/java/kafka/server/share/SharePartition.java: ## @@ -995,6 +1004,9 @@ boolean canAcquireRecords() { * @return A boolean which indicates wh

Re: [PR] KAFKA-16792: Enable consumer unit tests that fail to fetch offsets only for new consumer with poll(0) [kafka]

2024-09-11 Thread via GitHub
FrankYang0529 commented on code in PR #16982: URL: https://github.com/apache/kafka/pull/16982#discussion_r1754351703 ## clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java: ## @@ -2479,23 +2487,29 @@ public void testCurrentLag(GroupProtocol groupProtoc

Re: [PR] KAFKA-17400: Added share fetch purgatory for delaying share fetch requests [kafka]

2024-09-11 Thread via GitHub
apoorvmittal10 commented on code in PR #16969: URL: https://github.com/apache/kafka/pull/16969#discussion_r1754417489 ## core/src/main/java/kafka/server/share/SharePartition.java: ## @@ -995,6 +1004,9 @@ boolean canAcquireRecords() { * @return A boolean which indicates whe

Re: [PR] KAFKA-17502: Modified commitSync() and close() handling in clients [kafka]

2024-09-11 Thread via GitHub
AndrewJSchofield commented on code in PR #17136: URL: https://github.com/apache/kafka/pull/17136#discussion_r1754436434 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ShareConsumeRequestManager.java: ## @@ -84,10 +86,9 @@ public class ShareConsumeRequestMan

[jira] [Created] (KAFKA-17522) Share partition acquire() need not return a future

2024-09-11 Thread Abhinav Dixit (Jira)
Abhinav Dixit created KAFKA-17522: - Summary: Share partition acquire() need not return a future Key: KAFKA-17522 URL: https://issues.apache.org/jira/browse/KAFKA-17522 Project: Kafka Issue Ty

Re: [PR] KAFKA-17400: Added share fetch purgatory for delaying share fetch requests [kafka]

2024-09-11 Thread via GitHub
adixitconfluent commented on code in PR #16969: URL: https://github.com/apache/kafka/pull/16969#discussion_r1754440143 ## core/src/main/java/kafka/server/share/ShareFetchUtils.java: ## @@ -0,0 +1,113 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more +

Re: [PR] KAFKA-17347: Add missing client-metrics option to kafka-configs.sh [kafka]

2024-09-11 Thread via GitHub
chia7712 commented on code in PR #17046: URL: https://github.com/apache/kafka/pull/17046#discussion_r1754462594 ## core/src/test/java/kafka/admin/ConfigCommandIntegrationTest.java: ## @@ -620,6 +699,17 @@ private void deleteAndVerifyGroupConfigValue(Admin client, verify

[jira] [Created] (KAFKA-17523) Connectors should be able to override offset.flush.interval.ms

2024-09-11 Thread Viktor Somogyi-Vass (Jira)
Viktor Somogyi-Vass created KAFKA-17523: --- Summary: Connectors should be able to override offset.flush.interval.ms Key: KAFKA-17523 URL: https://issues.apache.org/jira/browse/KAFKA-17523 Project:

Re: [PR] KAFKA-17347: Add missing client-metrics option to kafka-configs.sh [kafka]

2024-09-11 Thread via GitHub
AndrewJSchofield commented on code in PR #17046: URL: https://github.com/apache/kafka/pull/17046#discussion_r1754598635 ## core/src/test/java/kafka/admin/ConfigCommandIntegrationTest.java: ## @@ -620,6 +699,17 @@ private void deleteAndVerifyGroupConfigValue(Admin client,

Re: [PR] KAFKA-16332 Remove Deprecated builder methods for Time/Session/Join/SlidingWindows [kafka]

2024-09-11 Thread via GitHub
brandboat commented on code in PR #17126: URL: https://github.com/apache/kafka/pull/17126#discussion_r1754695410 ## streams/src/test/java/org/apache/kafka/streams/integration/KStreamAggregationDedupIntegrationTest.java: ## @@ -193,7 +193,7 @@ public void shouldGroupByKey(final T

Re: [PR] KAFKA-16332 Remove Deprecated builder methods for Time/Session/Join/SlidingWindows [kafka]

2024-09-11 Thread via GitHub
brandboat commented on code in PR #17126: URL: https://github.com/apache/kafka/pull/17126#discussion_r1754695466 ## streams/src/test/java/org/apache/kafka/streams/integration/KStreamAggregationDedupIntegrationTest.java: ## @@ -157,7 +157,7 @@ public void shouldReduceWindowed(fin

[jira] [Created] (KAFKA-17524) StreamThreadTest shouldReturnErrorIfProducerInstanceIdNotInitialized hanging

2024-09-11 Thread David Arthur (Jira)
David Arthur created KAFKA-17524: Summary: StreamThreadTest shouldReturnErrorIfProducerInstanceIdNotInitialized hanging Key: KAFKA-17524 URL: https://issues.apache.org/jira/browse/KAFKA-17524 Project:

Re: [PR] MINOR Move some things into committer-tools [kafka]

2024-09-11 Thread via GitHub
mumrah commented on PR #17162: URL: https://github.com/apache/kafka/pull/17162#issuecomment-2343835120 I've also included a new find-unfinished-test.py which I've used in the past to find hanging tests -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] KAFKA-17506 KRaftMigrationDriver initialization race [kafka]

2024-09-11 Thread via GitHub
mumrah commented on code in PR #17147: URL: https://github.com/apache/kafka/pull/17147#discussion_r1754786855 ## metadata/src/test/java/org/apache/kafka/metadata/migration/KRaftMigrationDriverTest.java: ## @@ -232,6 +232,32 @@ CompletableFuture enqueueMetadataChangeEventWithFut

[jira] [Commented] (KAFKA-17493) Sink connector-related OffsetsApiIntegrationTest suite test cases failing more frequently with new consumer/group coordinator

2024-09-11 Thread Sagar Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17881001#comment-17881001 ] Sagar Rao commented on KAFKA-17493: --- [~dajac] , [~ChrisEgerton] I took a look at the l

Re: [PR] KAFKA-17506 KRaftMigrationDriver initialization race [kafka]

2024-09-11 Thread via GitHub
mumrah merged PR #17147: URL: https://github.com/apache/kafka/pull/17147 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.o

Re: [PR] KAFKA-17506 KRaftMigrationDriver initialization race [kafka]

2024-09-11 Thread via GitHub
mumrah commented on code in PR #17147: URL: https://github.com/apache/kafka/pull/17147#discussion_r1754786855 ## metadata/src/test/java/org/apache/kafka/metadata/migration/KRaftMigrationDriverTest.java: ## @@ -232,6 +232,32 @@ CompletableFuture enqueueMetadataChangeEventWithFut

[PR] KAFKA-17154: New consumer subscribe may join group without a call to consumer.poll [kafka]

2024-09-11 Thread via GitHub
FrankYang0529 opened a new pull request, #17165: URL: https://github.com/apache/kafka/pull/17165 To fulfill "rebalances will only occur during an active call to KafkaConsumer#poll(Duration)", we should not send `JoinRequest` after `AsyncKafkaConsumer#subscribe`. Add a flag `subscriptionUpda

Re: [PR] KAFKA-16792: Enable consumer unit tests that fail to fetch offsets only for new consumer with poll(0) [kafka]

2024-09-11 Thread via GitHub
lianetm commented on code in PR #16982: URL: https://github.com/apache/kafka/pull/16982#discussion_r1754814823 ## clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java: ## @@ -2479,23 +2487,29 @@ public void testCurrentLag(GroupProtocol groupProtocol) {

[jira] [Commented] (KAFKA-17493) Sink connector-related OffsetsApiIntegrationTest suite test cases failing more frequently with new consumer/group coordinator

2024-09-11 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17881010#comment-17881010 ] Chris Egerton commented on KAFKA-17493: --- [~sagarrao] I don't think our attempts to

Re: [PR] KAFKA-17502: Modified commitSync() and close() handling in clients [kafka]

2024-09-11 Thread via GitHub
ShivsundarR commented on code in PR #17136: URL: https://github.com/apache/kafka/pull/17136#discussion_r1754897975 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ShareConsumeRequestManager.java: ## @@ -1011,33 +1036,47 @@ public void completeIfEmpty() {

Re: [PR] KAFKA-14995: Automate asf.yaml collaborators refresh [kafka]

2024-09-11 Thread via GitHub
mumrah commented on PR #17124: URL: https://github.com/apache/kafka/pull/17124#issuecomment-2343953520 @fonsdant thanks for your contribution -- hope to see more in the future 😄 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[jira] [Resolved] (KAFKA-17506) KRaftMigrationDriver initialization race condition

2024-09-11 Thread David Arthur (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur resolved KAFKA-17506. -- Resolution: Fixed > KRaftMigrationDriver initialization race condition > -

Re: [PR] KAFKA-17502: Modified commitSync() and close() handling in clients [kafka]

2024-09-11 Thread via GitHub
ShivsundarR commented on code in PR #17136: URL: https://github.com/apache/kafka/pull/17136#discussion_r1754905117 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ShareConsumeRequestManager.java: ## @@ -84,10 +86,9 @@ public class ShareConsumeRequestManager

Re: [PR] KAFKA-17057: Add RETRY option to ProductionExceptionHanlder [kafka]

2024-09-11 Thread via GitHub
aliehsaeedii commented on code in PR #17163: URL: https://github.com/apache/kafka/pull/17163#discussion_r1754976225 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/RecordCollectorImpl.java: ## @@ -393,39 +393,41 @@ private void recordSendError(final String

[jira] [Comment Edited] (KAFKA-17493) Sink connector-related OffsetsApiIntegrationTest suite test cases failing more frequently with new consumer/group coordinator

2024-09-11 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17881001#comment-17881001 ] David Jacot edited comment on KAFKA-17493 at 9/11/24 3:35 PM:

[jira] [Created] (KAFKA-17525) Convert the UnknownServerException to InvalidRequestException when altering client-metrics config at runtime

2024-09-11 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-17525: -- Summary: Convert the UnknownServerException to InvalidRequestException when altering client-metrics config at runtime Key: KAFKA-17525 URL: https://issues.apache.org/jira/brow

[jira] [Updated] (KAFKA-17525) Convert the UnknownServerException to InvalidRequestException when altering client-metrics config at runtime

2024-09-11 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17525?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-17525: --- Description: see following test: {code:bash} chia7712@fedora:~/project/kafka$ bin/kafka-con

[jira] [Commented] (KAFKA-17525) Convert the UnknownServerException to InvalidRequestException when altering client-metrics config at runtime

2024-09-11 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17881030#comment-17881030 ] Chia-Ping Tsai commented on KAFKA-17525: `ClientMetricsConfigs#validatePropertie

[jira] [Comment Edited] (KAFKA-17493) Sink connector-related OffsetsApiIntegrationTest suite test cases failing more frequently with new consumer/group coordinator

2024-09-11 Thread Sagar Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17881001#comment-17881001 ] Sagar Rao edited comment on KAFKA-17493 at 9/11/24 3:47 PM:

[jira] [Comment Edited] (KAFKA-17493) Sink connector-related OffsetsApiIntegrationTest suite test cases failing more frequently with new consumer/group coordinator

2024-09-11 Thread Sagar Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17881001#comment-17881001 ] Sagar Rao edited comment on KAFKA-17493 at 9/11/24 3:48 PM:

[jira] [Comment Edited] (KAFKA-17493) Sink connector-related OffsetsApiIntegrationTest suite test cases failing more frequently with new consumer/group coordinator

2024-09-11 Thread Sagar Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17881001#comment-17881001 ] Sagar Rao edited comment on KAFKA-17493 at 9/11/24 3:49 PM:

[jira] [Comment Edited] (KAFKA-17493) Sink connector-related OffsetsApiIntegrationTest suite test cases failing more frequently with new consumer/group coordinator

2024-09-11 Thread Sagar Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17881001#comment-17881001 ] Sagar Rao edited comment on KAFKA-17493 at 9/11/24 3:49 PM:

[jira] [Comment Edited] (KAFKA-17493) Sink connector-related OffsetsApiIntegrationTest suite test cases failing more frequently with new consumer/group coordinator

2024-09-11 Thread Sagar Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17881001#comment-17881001 ] Sagar Rao edited comment on KAFKA-17493 at 9/11/24 3:51 PM:

[jira] [Commented] (KAFKA-17410) Flaky test testPollThrowsInterruptExceptionIfInterrupted for new consumer

2024-09-11 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17881034#comment-17881034 ] Lianet Magrans commented on KAFKA-17410: [~frankvicky] this test is very noisy/f

Re: [PR] KAFKA-17502: Modified commitSync() and close() handling in clients [kafka]

2024-09-11 Thread via GitHub
ShivsundarR commented on code in PR #17136: URL: https://github.com/apache/kafka/pull/17136#discussion_r1754897975 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ShareConsumeRequestManager.java: ## @@ -1011,33 +1036,47 @@ public void completeIfEmpty() {

Re: [PR] KAFKA-17347: Add missing client-metrics option to kafka-configs.sh [kafka]

2024-09-11 Thread via GitHub
chia7712 commented on code in PR #17046: URL: https://github.com/apache/kafka/pull/17046#discussion_r1755095302 ## core/src/test/java/kafka/admin/ConfigCommandIntegrationTest.java: ## @@ -325,6 +358,35 @@ private void verifyGroupConfigUpdate() throws Exception { }

Re: [PR] KAFKA-17502: Modified commitSync() and close() handling in clients [kafka]

2024-09-11 Thread via GitHub
AndrewJSchofield commented on code in PR #17136: URL: https://github.com/apache/kafka/pull/17136#discussion_r1755099465 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ShareConsumeRequestManager.java: ## @@ -1011,33 +1036,47 @@ public void completeIfEmpty()

Re: [PR] KAFKA-16727: Added share group record lock duration ms to dynamic configurations [kafka]

2024-09-11 Thread via GitHub
apoorvmittal10 commented on code in PR #17070: URL: https://github.com/apache/kafka/pull/17070#discussion_r1754670964 ## coordinator-common/src/main/java/org/apache/kafka/coordinator/common/runtime/GroupType.java: ## @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache Software Found

[jira] [Commented] (KAFKA-17410) Flaky test testPollThrowsInterruptExceptionIfInterrupted for new consumer

2024-09-11 Thread TengYao Chi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17881040#comment-17881040 ] TengYao Chi commented on KAFKA-17410: - Hi [~lianetm]  Apologies for the late respon

[jira] [Commented] (KAFKA-17525) Convert the UnknownServerException to InvalidRequestException when altering client-metrics config at runtime

2024-09-11 Thread TaiJuWu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17881042#comment-17881042 ] TaiJuWu commented on KAFKA-17525: - Hi[~chia7712] , if you are not working on this, may I

Re: [PR] KAFKA-17316: Standard authorizer refactor [kafka]

2024-09-11 Thread via GitHub
Claudenw commented on PR #16779: URL: https://github.com/apache/kafka/pull/16779#issuecomment-2344112120 @cmccabe You asked about why the StandardAuthorizerData was easier to test than the StandardAuthorizer. It is not that the StandardAuthorizerData is easier to test, it is that

Re: [PR] KAFKA-8666: Improve Documentation on usage of Materialized config object [kafka]

2024-09-11 Thread via GitHub
fonsdant commented on PR #17145: URL: https://github.com/apache/kafka/pull/17145#issuecomment-2344112932 Thanks, @mjsax! I have committed you suggestions. It looks even better now! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

Re: [PR] KAFKA-17400: Added share fetch purgatory for delaying share fetch requests [kafka]

2024-09-11 Thread via GitHub
junrao commented on code in PR #16969: URL: https://github.com/apache/kafka/pull/16969#discussion_r1755130741 ## core/src/main/java/kafka/server/share/SharePartition.java: ## @@ -995,6 +1004,9 @@ boolean canAcquireRecords() { * @return A boolean which indicates whether the

[jira] [Commented] (KAFKA-14995) Automate asf.yaml collaborators refresh

2024-09-11 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-14995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17881043#comment-17881043 ] João Pedro Fonseca commented on KAFKA-14995: [~vvcephei], [~jlprat], could I

Re: [PR] KAFKA-17233: MirrorCheckpointConnector should use batched listConsumerGroupOffsets [kafka]

2024-09-11 Thread via GitHub
fonsdant commented on PR #17038: URL: https://github.com/apache/kafka/pull/17038#issuecomment-2344125595 Hi, @gharris1727! Could you review it, please? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

Re: [PR] KAFKA-16379: Coordinator event queue, processing, flush, purgatory time histograms [kafka]

2024-09-11 Thread via GitHub
junrao commented on code in PR #16949: URL: https://github.com/apache/kafka/pull/16949#discussion_r1755140820 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/metrics/HdrHistogram.java: ## @@ -0,0 +1,145 @@ +/* + * Licensed to the Apache Software Foundation

[jira] [Commented] (KAFKA-14995) Automate asf.yaml collaborators refresh

2024-09-11 Thread Josep Prat (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17881044#comment-17881044 ] Josep Prat commented on KAFKA-14995: Yes sure, go ahead! > Automate asf.yaml collab

[jira] [Updated] (KAFKA-14995) Automate asf.yaml collaborators refresh

2024-09-11 Thread Josep Prat (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14995?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josep Prat updated KAFKA-14995: --- Fix Version/s: 4.0.0 > Automate asf.yaml collaborators refresh > ---

[jira] [Assigned] (KAFKA-17525) Convert the UnknownServerException to InvalidRequestException when altering client-metrics config at runtime

2024-09-11 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17525?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai reassigned KAFKA-17525: -- Assignee: TaiJuWu (was: Chia-Ping Tsai) > Convert the UnknownServerException to Inva

[jira] [Created] (KAFKA-17526) make ConfigCommandIntegrationTest.java test use correct arguments in testing alias

2024-09-11 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-17526: -- Summary: make ConfigCommandIntegrationTest.java test use correct arguments in testing alias Key: KAFKA-17526 URL: https://issues.apache.org/jira/browse/KAFKA-17526

Re: [PR] KAFKA-17347: Add missing client-metrics option to kafka-configs.sh [kafka]

2024-09-11 Thread via GitHub
chia7712 commented on code in PR #17046: URL: https://github.com/apache/kafka/pull/17046#discussion_r1755161862 ## core/src/test/java/kafka/admin/ConfigCommandIntegrationTest.java: ## @@ -325,6 +358,35 @@ private void verifyGroupConfigUpdate() throws Exception { }

[jira] [Created] (KAFKA-17527) Kafka Streams fails with NPE for missing RecordContext

2024-09-11 Thread Matthias J. Sax (Jira)
Matthias J. Sax created KAFKA-17527: --- Summary: Kafka Streams fails with NPE for missing RecordContext Key: KAFKA-17527 URL: https://issues.apache.org/jira/browse/KAFKA-17527 Project: Kafka

Re: [PR] KAFKA-17347: Add missing client-metrics option to kafka-configs.sh [kafka]

2024-09-11 Thread via GitHub
chia7712 merged PR #17046: URL: https://github.com/apache/kafka/pull/17046 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Resolved] (KAFKA-17347) Add omitted --client-metrics option to kafka-configs.sh

2024-09-11 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17347?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-17347. Resolution: Fixed > Add omitted --client-metrics option to kafka-configs.sh >

[jira] [Assigned] (KAFKA-17527) Kafka Streams fails with NPE for missing RecordContext

2024-09-11 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax reassigned KAFKA-17527: --- Assignee: Matthias J. Sax > Kafka Streams fails with NPE for missing RecordContext

[jira] [Updated] (KAFKA-17524) StreamThreadTest shouldReturnErrorIfProducerInstanceIdNotInitialized hanging

2024-09-11 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-17524: Component/s: streams unit tests > StreamThreadTest shouldReturnErrorIfPro

Re: [PR] KAFKA-17400: Added share fetch purgatory for delaying share fetch requests [kafka]

2024-09-11 Thread via GitHub
adixitconfluent commented on PR #16969: URL: https://github.com/apache/kafka/pull/16969#issuecomment-2344243078 The tests failing for JDK 21 and Scala 2.13 are unrelated to the PR. I ran the four of them locally and they all passed. -- This is an automated message from the Apache Git Serv

Re: [PR] MINOR: follow up KAFKA-17477 comments [kafka]

2024-09-11 Thread via GitHub
chia7712 merged PR #17161: URL: https://github.com/apache/kafka/pull/17161 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Commented] (KAFKA-17518) AsyncKafkaConsumer cannot reliably leave group when closed with small timeout

2024-09-11 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17881068#comment-17881068 ] Lianet Magrans commented on KAFKA-17518: I would add to this Jira, that it would

Re: [PR] KAFKA-16985: Ensure consumer sends leave request on close even if interrupted [kafka]

2024-09-11 Thread via GitHub
lianetm commented on code in PR #16686: URL: https://github.com/apache/kafka/pull/16686#discussion_r1755201808 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java: ## @@ -1291,6 +1294,10 @@ private void releaseAssignmentAndLeaveGroup(fina

Re: [PR] KAFKA-17400: Added share fetch purgatory for delaying share fetch requests [kafka]

2024-09-11 Thread via GitHub
apoorvmittal10 commented on code in PR #16969: URL: https://github.com/apache/kafka/pull/16969#discussion_r1755202301 ## core/src/main/java/kafka/server/share/SharePartition.java: ## @@ -995,6 +1004,9 @@ boolean canAcquireRecords() { * @return A boolean which indicates whe

Re: [PR] KAFKA-17400: Added share fetch purgatory for delaying share fetch requests [kafka]

2024-09-11 Thread via GitHub
apoorvmittal10 commented on code in PR #16969: URL: https://github.com/apache/kafka/pull/16969#discussion_r1755202301 ## core/src/main/java/kafka/server/share/SharePartition.java: ## @@ -995,6 +1004,9 @@ boolean canAcquireRecords() { * @return A boolean which indicates whe

[jira] [Commented] (KAFKA-17524) StreamThreadTest shouldReturnErrorIfProducerInstanceIdNotInitialized hanging

2024-09-11 Thread David Arthur (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17881072#comment-17881072 ] David Arthur commented on KAFKA-17524: -- Here's another from the same test class, di

[jira] [Created] (KAFKA-17528) Remove whitelist/blacklist from JMXReporter

2024-09-11 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-17528: -- Summary: Remove whitelist/blacklist from JMXReporter Key: KAFKA-17528 URL: https://issues.apache.org/jira/browse/KAFKA-17528 Project: Kafka Issue Type: S

[jira] [Created] (KAFKA-17529) Remove blacklist from MM2

2024-09-11 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-17529: -- Summary: Remove blacklist from MM2 Key: KAFKA-17529 URL: https://issues.apache.org/jira/browse/KAFKA-17529 Project: Kafka Issue Type: Sub-task

[jira] [Created] (KAFKA-17530) Remove blacklist/whitelist from ReplaceField

2024-09-11 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-17530: -- Summary: Remove blacklist/whitelist from ReplaceField Key: KAFKA-17530 URL: https://issues.apache.org/jira/browse/KAFKA-17530 Project: Kafka Issue Type:

[jira] [Updated] (KAFKA-12601) Remove deprecated `delegation.token.master.key`

2024-09-11 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-12601: --- Parent: KAFKA-17384 Issue Type: Sub-task (was: Task) > Remove deprecated `delegatio

Re: [PR] KAFKA-17392: Remove whitelist option in ConsoleConsumerOptions [kafka]

2024-09-11 Thread via GitHub
chia7712 merged PR #17138: URL: https://github.com/apache/kafka/pull/17138 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Resolved] (KAFKA-17392) Remove whitelist in ConsoleConsumerOptions

2024-09-11 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-17392. Fix Version/s: 4.0.0 Resolution: Fixed > Remove whitelist in ConsoleConsumerOptions

Re: [PR] KAFKA-17231: Add missing node latency metrics [kafka]

2024-09-11 Thread via GitHub
chia7712 merged PR #17137: URL: https://github.com/apache/kafka/pull/17137 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Resolved] (KAFKA-17231) Share consumer node latency metrics

2024-09-11 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-17231. Fix Version/s: 4.0.0 Resolution: Fixed > Share consumer node latency metrics >

Re: [PR] Testing PR [kafka]

2024-09-11 Thread via GitHub
mumrah closed pull request #17141: Testing PR URL: https://github.com/apache/kafka/pull/17141 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsub

[PR] KAFKA-17524: Add timeout to StreamThreadTest.shouldReturnErrorIfProducerInstanceIdNotInitialized [kafka]

2024-09-11 Thread via GitHub
mjsax opened a new pull request, #17167: URL: https://github.com/apache/kafka/pull/17167 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail

Re: [PR] KAFKA-15073 Close stale PRs [2/n] [kafka]

2024-09-11 Thread via GitHub
chia7712 commented on code in PR #17166: URL: https://github.com/apache/kafka/pull/17166#discussion_r1755260902 ## .github/workflows/stale.yml: ## @@ -42,14 +42,17 @@ jobs: with: debug-only: ${{ inputs.dryRun || false }} operations-per-run: ${{ inp

Re: [PR] KAFKA-17448: New consumer seek should update positions in background thread [kafka]

2024-09-11 Thread via GitHub
lianetm merged PR #17075: URL: https://github.com/apache/kafka/pull/17075 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

Re: [PR] KAFKA-15073 Close stale PRs [2/n] [kafka]

2024-09-11 Thread via GitHub
mumrah commented on code in PR #17166: URL: https://github.com/apache/kafka/pull/17166#discussion_r1755279325 ## .github/workflows/stale.yml: ## @@ -42,14 +42,17 @@ jobs: with: debug-only: ${{ inputs.dryRun || false }} operations-per-run: ${{ input

Re: [PR] KAFKA-15073 Close stale PRs [2/n] [kafka]

2024-09-11 Thread via GitHub
jlprat commented on code in PR #17166: URL: https://github.com/apache/kafka/pull/17166#discussion_r1755293831 ## .github/workflows/stale.yml: ## @@ -42,14 +42,21 @@ jobs: with: debug-only: ${{ inputs.dryRun || false }} operations-per-run: ${{ input

  1   2   3   >