AndrewJSchofield commented on code in PR #17136:
URL: https://github.com/apache/kafka/pull/17136#discussion_r1755099465
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ShareConsumeRequestManager.java:
##########
@@ -1011,33 +1036,47 @@ public void completeIfEmpty() {
}
}
- static class Pair<V> {
+ static class Tuple<V> {
private V asyncRequest;
- private V syncRequest;
+ private Queue<V> syncRequestQueue;
+ private V closeRequest;
- public Pair(V asyncRequest, V syncRequest) {
+ public Tuple(V asyncRequest, Queue<V> syncRequestQueue, V
closeRequest) {
this.asyncRequest = asyncRequest;
- this.syncRequest = syncRequest;
+ this.syncRequestQueue = syncRequestQueue;
+ this.closeRequest = closeRequest;
}
public void setAsyncRequest(V asyncRequest) {
this.asyncRequest = asyncRequest;
}
- public void setSyncRequest(V second) {
- this.syncRequest = second;
+ public void setSyncRequestQueue(Queue<V> syncRequestQueue) {
Review Comment:
That's fine. It just seemed weird forcing the caller to make and set the
queue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
