[jira] [Commented] (KAFKA-17395) Flaky test testMissingOffsetNoResetPolicy for new consumer

2024-08-30 Thread PoAn Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17877989#comment-17877989 ] PoAn Yang commented on KAFKA-17395: --- Hi [~taijuwu], yeah, like you said, if {{Coordina

[jira] [Assigned] (KAFKA-17395) Flaky test testMissingOffsetNoResetPolicy for new consumer

2024-08-30 Thread PoAn Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] PoAn Yang reassigned KAFKA-17395: - Assignee: PoAn Yang > Flaky test testMissingOffsetNoResetPolicy for new consumer >

Re: [PR] Kafka 8850: Updated documentation to clarify fetch.min.bytes behaviour. [kafka]

2024-08-30 Thread via GitHub
abhi-ksolves commented on PR #16749: URL: https://github.com/apache/kafka/pull/16749#issuecomment-2320311037 Hi @mjsax, Can you review this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Commented] (KAFKA-17041) Add pagination when describe large set of metadata via Admin API

2024-08-30 Thread Lin Siyuan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17877992#comment-17877992 ] Lin Siyuan commented on KAFKA-17041: hi [~omnia_h_ibrahim] , I have been following t

[jira] [Commented] (KAFKA-17445) Kafka streams keeps rebalancing with the following reasons

2024-08-30 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17878006#comment-17878006 ] Bruno Cadonna commented on KAFKA-17445: --- [~rohitbobade] It is not clear to me what

[jira] [Commented] (KAFKA-17395) Flaky test testMissingOffsetNoResetPolicy for new consumer

2024-08-30 Thread TaiJuWu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17878014#comment-17878014 ] TaiJuWu commented on KAFKA-17395: - Hi [~yangpoan] , You always have better solution:) >

[PR] KAFKA-16448 Add timestamp to error handler context [kafka]

2024-08-30 Thread via GitHub
sebastienviale opened a new pull request, #17054: URL: https://github.com/apache/kafka/pull/17054 This PR is part of [KAFKA-16448](https://issues.apache.org/jira/browse/KAFKA-16448) which aims to bring a ProcessingExceptionHandler to Kafka Streams in order to deal with exceptions that occu

[PR] Changed fetch queue processing to reduce the no. of locking and unlocking activity [kafka]

2024-08-30 Thread via GitHub
adixitconfluent opened a new pull request, #17055: URL: https://github.com/apache/kafka/pull/17055 ### About For the share groups fetch request processing, we have an recursive approach of dealing with individual fetch requests. While it works fine with less no. of records (< 1,000,000)

[jira] [Commented] (KAFKA-16792) Enable consumer unit tests that fail to fetch offsets only for new consumer with poll(0)

2024-08-30 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17878022#comment-17878022 ] Chia-Ping Tsai commented on KAFKA-16792: AsyncConsumer close(0) has similar issu

Re: [PR] KAFKA-17424: Memory optimisation for Kafka-connect [kafka]

2024-08-30 Thread via GitHub
ajit97singh closed pull request #17002: KAFKA-17424: Memory optimisation for Kafka-connect URL: https://github.com/apache/kafka/pull/17002 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

Re: [PR] KAFKA-14572: Migrate EmbeddedKafkaCluster used by Streams integration tests from EmbeddedZookeeper to KRaft [kafka]

2024-08-30 Thread via GitHub
lucasbru commented on PR #17016: URL: https://github.com/apache/kafka/pull/17016#issuecomment-2320694184 @OmniaGM Looks like something in kraft is just taking longer? Have we not observed this problem with the connect unit tests? I wonder if there are some settings that we could use to spee

[jira] [Created] (KAFKA-17447) Changed fetch queue processing to reduce the no. of locking and unlocking activity

2024-08-30 Thread Abhinav Dixit (Jira)
Abhinav Dixit created KAFKA-17447: - Summary: Changed fetch queue processing to reduce the no. of locking and unlocking activity Key: KAFKA-17447 URL: https://issues.apache.org/jira/browse/KAFKA-17447

[jira] [Resolved] (KAFKA-16968) Make 3.8-IV0 a stable MetadataVersion and create 3.9-IV0

2024-08-30 Thread TaiJuWu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16968?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] TaiJuWu resolved KAFKA-16968. - Resolution: Fixed > Make 3.8-IV0 a stable MetadataVersion and create 3.9-IV0 > -

[jira] [Commented] (KAFKA-17446) Kafka streams stuck in rebalancing

2024-08-30 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17878040#comment-17878040 ] Bruno Cadonna commented on KAFKA-17446: --- [~rohitbobade] Could you please share som

Re: [PR] KAFKA-17293: New consumer HeartbeatRequestManager should rediscover disconnected coordinator [kafka]

2024-08-30 Thread via GitHub
lianetm commented on code in PR #16844: URL: https://github.com/apache/kafka/pull/16844#discussion_r1738389019 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/CoordinatorRequestManager.java: ## @@ -122,6 +123,23 @@ NetworkClientDelegate.UnsentRequest makeFi

Re: [PR] KAFKA-17293: New consumer HeartbeatRequestManager should rediscover disconnected coordinator [kafka]

2024-08-30 Thread via GitHub
frankvicky commented on code in PR #16844: URL: https://github.com/apache/kafka/pull/16844#discussion_r1738393452 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/CoordinatorRequestManager.java: ## @@ -122,6 +123,23 @@ NetworkClientDelegate.UnsentRequest mak

[jira] [Commented] (KAFKA-16792) Enable consumer unit tests that fail to fetch offsets only for new consumer with poll(0)

2024-08-30 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17878054#comment-17878054 ] Lianet Magrans commented on KAFKA-16792: Agree with [~chia7712] 's point, we've

Re: [PR] KAFKA-17442: Handled persister errors with write async calls (KIP-932) [kafka]

2024-08-30 Thread via GitHub
apoorvmittal10 commented on PR #16956: URL: https://github.com/apache/kafka/pull/16956#issuecomment-2320893368 @junrao Can I please get review on this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

Re: [PR] KAFKA-17442: Handled persister errors with write async calls (KIP-932) [kafka]

2024-08-30 Thread via GitHub
apoorvmittal10 commented on PR #16956: URL: https://github.com/apache/kafka/pull/16956#issuecomment-2320892038 > Thanks for the PR. I had a query, what will happen to the ongoing write state requests to the persister when you close a share partition. I understand that it is fine if some wri

[PR] KAFKA-17395: Flaky test testMissingOffsetNoResetPolicy for new consumer [kafka]

2024-08-30 Thread via GitHub
FrankYang0529 opened a new pull request, #17056: URL: https://github.com/apache/kafka/pull/17056 In `AsyncKafkaConsumer`, `FindCoordinatorRequest` is sent by background thread. In `MockClient#prepareResponseFrom`, it only matches the response to a future request. If there is some race condi

[jira] [Created] (KAFKA-17448) New consumer seek should update positions in background thread

2024-08-30 Thread Lianet Magrans (Jira)
Lianet Magrans created KAFKA-17448: -- Summary: New consumer seek should update positions in background thread Key: KAFKA-17448 URL: https://issues.apache.org/jira/browse/KAFKA-17448 Project: Kafka

[jira] [Commented] (KAFKA-17448) New consumer seek should update positions in background thread

2024-08-30 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17878065#comment-17878065 ] Lianet Magrans commented on KAFKA-17448: Hey [~payang] , this issue is very simi

[jira] [Updated] (KAFKA-17448) New consumer seek should update positions in background thread

2024-08-30 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lianet Magrans updated KAFKA-17448: --- Fix Version/s: 4.0.0 > New consumer seek should update positions in background thread >

[jira] [Updated] (KAFKA-17448) New consumer seek should update positions in background thread

2024-08-30 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lianet Magrans updated KAFKA-17448: --- Component/s: clients > New consumer seek should update positions in background thread >

Re: [PR] MINOR Handle test re-runs in junit.py [kafka]

2024-08-30 Thread via GitHub
chia7712 commented on code in PR #17034: URL: https://github.com/apache/kafka/pull/17034#discussion_r1738517170 ## .github/scripts/junit.py: ## @@ -148,29 +168,73 @@ def pretty_time_duration(seconds: float) -> str: total_failures += suite.failures

[PR] MINOR: Set `group.coordinator.rebalance.protocols` to `classic,consumer` by default [kafka]

2024-08-30 Thread via GitHub
dajac opened a new pull request, #17057: URL: https://github.com/apache/kafka/pull/17057 This patch changes the default configuration of `group.coordinator.rebalance.protocols` to `classic,consumer`. It also updates various tests that were specifying the new default value. ### Co

Re: [PR] MINOR: Set `group.coordinator.rebalance.protocols` to `classic,consumer` by default [kafka]

2024-08-30 Thread via GitHub
dajac commented on code in PR #17057: URL: https://github.com/apache/kafka/pull/17057#discussion_r1738523290 ## core/src/main/scala/kafka/server/KafkaConfig.scala: ## @@ -576,19 +576,13 @@ class KafkaConfig private(doLog: Boolean, val props: util.Map[_, _]) throw new Con

[PR] MINOR: Fix broken output layout of kafka-consumer-groups.sh [kafka]

2024-08-30 Thread via GitHub
sasakitoa opened a new pull request, #17058: URL: https://github.com/apache/kafka/pull/17058 Output format of `kafka-consumer-groups.sh` with `--delete-offsets` or `--reset-offsets` has been broken since line separators are missing. This PR will fix the problem. -- Current:

Re: [PR] KAFKA-17433 Add a deflake Github action [kafka]

2024-08-30 Thread via GitHub
chia7712 commented on code in PR #17019: URL: https://github.com/apache/kafka/pull/17019#discussion_r1738533619 ## core/src/test/java/kafka/test/junit/ClusterTestExtensions.java: ## @@ -199,46 +239,53 @@ private List processClusterTests(ExtensionContext return ret;

Re: [PR] MINOR: Set `group.coordinator.rebalance.protocols` to `classic,consumer` by default [kafka]

2024-08-30 Thread via GitHub
chia7712 commented on code in PR #17057: URL: https://github.com/apache/kafka/pull/17057#discussion_r1738568876 ## core/src/test/java/kafka/test/ClusterInstance.java: ## @@ -160,15 +159,11 @@ default Admin createAdminClient() { } default Set supportedGroupProtocols()

Re: [PR] MINOR: add helper function for clusterInstance [kafka]

2024-08-30 Thread via GitHub
chia7712 commented on code in PR #16852: URL: https://github.com/apache/kafka/pull/16852#discussion_r1738595734 ## core/src/test/java/kafka/test/ClusterTestExtensionsTest.java: ## @@ -236,6 +236,20 @@ public void testNotSupportedNewGroupProtocols(ClusterInstance clusterInstance

Re: [PR] MINOR: Set `group.coordinator.rebalance.protocols` to `classic,consumer` by default [kafka]

2024-08-30 Thread via GitHub
dajac commented on code in PR #17057: URL: https://github.com/apache/kafka/pull/17057#discussion_r1738609128 ## core/src/test/java/kafka/test/ClusterInstance.java: ## @@ -160,15 +159,11 @@ default Admin createAdminClient() { } default Set supportedGroupProtocols() {

Re: [PR] MINOR: Set `group.coordinator.rebalance.protocols` to `classic,consumer` by default [kafka]

2024-08-30 Thread via GitHub
dajac commented on code in PR #17057: URL: https://github.com/apache/kafka/pull/17057#discussion_r1738610295 ## core/src/test/java/kafka/test/ClusterTestExtensionsTest.java: ## @@ -191,45 +189,17 @@ public void testDefaults(ClusterInstance clusterInstance) { Assertions

Re: [PR] MINOR: Set `group.coordinator.rebalance.protocols` to `classic,consumer` by default [kafka]

2024-08-30 Thread via GitHub
dajac commented on code in PR #17057: URL: https://github.com/apache/kafka/pull/17057#discussion_r1738610851 ## tools/src/test/java/org/apache/kafka/tools/consumer/group/ConsumerGroupCommandTestUtils.java: ## @@ -79,34 +77,34 @@ private ConsumerGroupCommandTestUtils() { }

Re: [PR] MINOR: Set `group.coordinator.rebalance.protocols` to `classic,consumer` by default [kafka]

2024-08-30 Thread via GitHub
dajac commented on code in PR #17057: URL: https://github.com/apache/kafka/pull/17057#discussion_r1738612665 ## core/src/main/scala/kafka/server/KafkaConfig.scala: ## @@ -576,19 +576,13 @@ class KafkaConfig private(doLog: Boolean, val props: util.Map[_, _]) throw new Con

[jira] [Updated] (KAFKA-17428) remote segments deleted in RLMCopyTask stays `COPY_SEGMENT_START` state

2024-08-30 Thread Federico Valeri (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17428?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Federico Valeri updated KAFKA-17428: Labels: kip-required (was: ) > remote segments deleted in RLMCopyTask stays `COPY_SEGMENT

[PR] Kafka 12822 2 [kafka]

2024-08-30 Thread via GitHub
pegasas opened a new pull request, #17059: URL: https://github.com/apache/kafka/pull/17059 KAFKA-12829: Remove deprecated StreamsBuilder#addGlobalStore of old Processor API ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verif

[jira] [Created] (KAFKA-17449) Move Quota classes to server module

2024-08-30 Thread Mickael Maison (Jira)
Mickael Maison created KAFKA-17449: -- Summary: Move Quota classes to server module Key: KAFKA-17449 URL: https://issues.apache.org/jira/browse/KAFKA-17449 Project: Kafka Issue Type: Sub-task

Re: [PR] Kafka 12822 2 [kafka]

2024-08-30 Thread via GitHub
pegasas commented on PR #17059: URL: https://github.com/apache/kafka/pull/17059#issuecomment-2321259947 ![image](https://github.com/user-attachments/assets/37b1c76a-11c6-4d19-bd77-3c55f00904c2) CI passed. -- This is an automated message from the Apache Git Service. To respond to th

Re: [PR] KAFKA-16379: Coordinator event queue, processing, flush, purgatory time histograms [kafka]

2024-08-30 Thread via GitHub
jeffkbkim commented on PR #16949: URL: https://github.com/apache/kafka/pull/16949#issuecomment-2321260689 The HdrHistogram wrapper implementation (HdrHistogram, KafkaMetricHistogram) was authored by @dimitarndimitrov -- This is an automated message from the Apache Git Service. To respon

[jira] [Assigned] (KAFKA-17450) Optimise the handler methods in ShareConsumeRequestManager.

2024-08-30 Thread Shivsundar R (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shivsundar R reassigned KAFKA-17450: Assignee: Shivsundar R > Optimise the handler methods in ShareConsumeRequestManager. > --

[jira] [Created] (KAFKA-17450) Optimise the handler methods in ShareConsumeRequestManager.

2024-08-30 Thread Shivsundar R (Jira)
Shivsundar R created KAFKA-17450: Summary: Optimise the handler methods in ShareConsumeRequestManager. Key: KAFKA-17450 URL: https://issues.apache.org/jira/browse/KAFKA-17450 Project: Kafka

[jira] [Commented] (KAFKA-17448) New consumer seek should update positions in background thread

2024-08-30 Thread PoAn Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17878122#comment-17878122 ] PoAn Yang commented on KAFKA-17448: --- Hi [~lianetm], thank you. I can handle it. 👍 > N

[jira] [Assigned] (KAFKA-17448) New consumer seek should update positions in background thread

2024-08-30 Thread PoAn Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] PoAn Yang reassigned KAFKA-17448: - Assignee: PoAn Yang > New consumer seek should update positions in background thread >

[jira] [Commented] (KAFKA-17448) New consumer seek should update positions in background thread

2024-08-30 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17878124#comment-17878124 ] Lianet Magrans commented on KAFKA-17448: Thanks! Let me know if you have questio

Re: [PR] MINOR: add ReconfigurableQuorumIntegrationTest [kafka]

2024-08-30 Thread via GitHub
chia7712 commented on code in PR #16991: URL: https://github.com/apache/kafka/pull/16991#discussion_r1738650234 ## metadata/src/main/java/org/apache/kafka/metadata/storage/Formatter.java: ## @@ -401,7 +409,7 @@ void doFormat(BootstrapMetadata bootstrapMetadata) throws Exception

Re: [PR] MINOR: Set `group.coordinator.rebalance.protocols` to `classic,consumer` by default [kafka]

2024-08-30 Thread via GitHub
chia7712 commented on code in PR #17057: URL: https://github.com/apache/kafka/pull/17057#discussion_r1738713919 ## core/src/main/scala/kafka/server/KafkaConfig.scala: ## @@ -576,19 +576,13 @@ class KafkaConfig private(doLog: Boolean, val props: util.Map[_, _]) throw new

[PR] KAFKA-17449: Move Quota classes to server module [kafka]

2024-08-30 Thread via GitHub
mimaison opened a new pull request, #17060: URL: https://github.com/apache/kafka/pull/17060 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgr

[PR] KAFKA-17450: Reduced the handlers for handling ShareAcknowledgeResponse. [kafka]

2024-08-30 Thread via GitHub
ShivsundarR opened a new pull request, #17061: URL: https://github.com/apache/kafka/pull/17061 *What* Currently there are 4 handler functions present for handling ShareAcknowledge responses. ShareConsumeRequestManager had an interface and the respective handlers would implement it. Inste

Re: [PR] KAFKA-17347: Add missing client-metrics option to kafka-configs.sh [kafka]

2024-08-30 Thread via GitHub
AndrewJSchofield commented on PR #17046: URL: https://github.com/apache/kafka/pull/17046#issuecomment-2321352952 Only 3 unit test failures, unrelated to this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Updated] (KAFKA-17449) Move Quota classes to server-common module

2024-08-30 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison updated KAFKA-17449: --- Summary: Move Quota classes to server-common module (was: Move Quota classes to server modu

[jira] [Updated] (KAFKA-17449) Move Quota classes to server-common module

2024-08-30 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison updated KAFKA-17449: --- Description: RLMQuotaManager which will utlimately move to storage depends on the QuotaType

Re: [PR] KAFKA-17386: Remove broker-list, threads, num-fetch-threads in ConsumerPerformance [kafka]

2024-08-30 Thread via GitHub
chia7712 merged PR #16983: URL: https://github.com/apache/kafka/pull/16983 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Resolved] (KAFKA-17386) Remove broker-list, threads, num-fetch-threads in ConsumerPerformance

2024-08-30 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-17386. Fix Version/s: 4.0.0 Resolution: Fixed > Remove broker-list, threads, num-fetch-thr

Re: [PR] KAFKA-17450: Reduced the handlers for handling ShareAcknowledgeResponse. [kafka]

2024-08-30 Thread via GitHub
AndrewJSchofield commented on code in PR #17061: URL: https://github.com/apache/kafka/pull/17061#discussion_r1738762496 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ShareConsumeRequestManager.java: ## @@ -613,74 +607,100 @@ private void handleShareAcknowl

Re: [PR] KAFKA-16863 : Deprecate default exception handlers [kafka]

2024-08-30 Thread via GitHub
muralibasani commented on PR #17005: URL: https://github.com/apache/kafka/pull/17005#issuecomment-2321425276 > Committed the fix. > > LGTM now, assuming build passes... Great, thanks. -- This is an automated message from the Apache Git Service. To respond to the message, plea

Re: [PR] KAFKA-16863 : Deprecate default exception handlers [kafka]

2024-08-30 Thread via GitHub
muralibasani commented on PR #17005: URL: https://github.com/apache/kafka/pull/17005#issuecomment-2321453957 there are failing tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] KAFKA-17137[part-5]: Ensure Admin APIs are properly tested [kafka]

2024-08-30 Thread via GitHub
m1a2st commented on code in PR #16905: URL: https://github.com/apache/kafka/pull/16905#discussion_r1738862139 ## core/src/test/scala/integration/kafka/api/SaslSslAdminIntegrationTest.scala: ## @@ -337,6 +338,53 @@ class SaslSslAdminIntegrationTest extends BaseAdminIntegrationTe

Re: [PR] KAFKA-17449: Move Quota classes to server-common module [kafka]

2024-08-30 Thread via GitHub
chia7712 commented on code in PR #17060: URL: https://github.com/apache/kafka/pull/17060#discussion_r1738763455 ## server-common/src/main/java/org/apache/kafka/server/quota/QuotaUtils.java: ## @@ -0,0 +1,79 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

Re: [PR] MINOR: add concurrent test for consumer.poll [kafka]

2024-08-30 Thread via GitHub
chia7712 commented on code in PR #17047: URL: https://github.com/apache/kafka/pull/17047#discussion_r1738898118 ## clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java: ## @@ -3382,7 +3382,43 @@ public void testCommittedThrowsTimeoutExceptionForNoRespo

Re: [PR] KAFKA-17374: add bootstrap.controller to kafka-reassign-partitions.sh [kafka]

2024-08-30 Thread via GitHub
chia7712 commented on PR #16964: URL: https://github.com/apache/kafka/pull/16964#issuecomment-2321570487 @m1a2st Could you please rebase code to include #16644? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

Re: [PR] KAFKA-17449: Move Quota classes to server-common module [kafka]

2024-08-30 Thread via GitHub
mimaison commented on code in PR #17060: URL: https://github.com/apache/kafka/pull/17060#discussion_r1738925546 ## server-common/src/main/java/org/apache/kafka/server/quota/QuotaUtils.java: ## @@ -0,0 +1,79 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

Re: [PR] KAFKA-15909: Throw error when consumer configured with empty/whitespace-only group.id for LegacyKafkaConsumer [kafka]

2024-08-30 Thread via GitHub
chia7712 merged PR #16933: URL: https://github.com/apache/kafka/pull/16933 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Resolved] (KAFKA-15909) Throw error when consumer configured with empty/whitespace-only group.id for LegacyKafkaConsumer

2024-08-30 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-15909. Resolution: Fixed > Throw error when consumer configured with empty/whitespace-only group.

[jira] [Updated] (KAFKA-17428) remote segments deleted in RLMCopyTask stays DELETE_SEGMENT_STARTED state

2024-08-30 Thread Federico Valeri (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17428?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Federico Valeri updated KAFKA-17428: Summary: remote segments deleted in RLMCopyTask stays DELETE_SEGMENT_STARTED state (was:

[jira] [Updated] (KAFKA-17428) Remote segments stay in COPY_SEGMENT_STARTED state after RLMCopyTask fails to upload

2024-08-30 Thread Federico Valeri (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17428?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Federico Valeri updated KAFKA-17428: Summary: Remote segments stay in COPY_SEGMENT_STARTED state after RLMCopyTask fails to upl

[jira] [Updated] (KAFKA-17428) Remote segments stay in DELETE_SEGMENT_STARTED state after RLMCopyTask fails to upload

2024-08-30 Thread Federico Valeri (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17428?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Federico Valeri updated KAFKA-17428: Summary: Remote segments stay in DELETE_SEGMENT_STARTED state after RLMCopyTask fails to u

[jira] [Created] (KAFKA-17451) Remove deprecated Consumer#committed

2024-08-30 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-17451: -- Summary: Remove deprecated Consumer#committed Key: KAFKA-17451 URL: https://issues.apache.org/jira/browse/KAFKA-17451 Project: Kafka Issue Type: Sub-task

Re: [PR] KAFKA-17449: Move Quota classes to server-common module [kafka]

2024-08-30 Thread via GitHub
chia7712 commented on PR #17060: URL: https://github.com/apache/kafka/pull/17060#issuecomment-2321633915 @mimaison Could you please fix the conflicts :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] Back-port KAFKA-16230 to 3.7 branch [kafka]

2024-08-30 Thread via GitHub
lianetm commented on PR #16951: URL: https://github.com/apache/kafka/pull/16951#issuecomment-2321721217 Hey @kirktrue , took a first look and overall it looks good. Is there a run of the system tests with this change? (agree that failures in PlainTextConsumer are unrelated to this PR). Than

Re: [PR] KAFKA-17449: Move Quota classes to server-common module [kafka]

2024-08-30 Thread via GitHub
mimaison commented on PR #17060: URL: https://github.com/apache/kafka/pull/17060#issuecomment-2321731110 Yup, just rebased. Let's wait for the CI to run again -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[jira] [Commented] (KAFKA-17451) Remove deprecated Consumer#committed

2024-08-30 Thread Dmitry Werner (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17878173#comment-17878173 ] Dmitry Werner commented on KAFKA-17451: --- [~chia7712] Hello, can I take it? > Remo

Re: [PR] KAFKA-17137: Feat admin client it acl configs [kafka]

2024-08-30 Thread via GitHub
chia7712 commented on code in PR #16648: URL: https://github.com/apache/kafka/pull/16648#discussion_r1739046762 ## core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala: ## @@ -96,6 +96,50 @@ class PlaintextAdminIntegrationTest extends BaseAdminIntegrati

[jira] [Commented] (KAFKA-17451) Remove deprecated Consumer#committed

2024-08-30 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17878180#comment-17878180 ] Chia-Ping Tsai commented on KAFKA-17451: [~javakillah] oh, sorry that my team me

Re: [PR] KAFKA-16863 : Deprecate default exception handlers [kafka]

2024-08-30 Thread via GitHub
mjsax commented on PR #17005: URL: https://github.com/apache/kafka/pull/17005#issuecomment-2321839005 Yeah. Looks related. Can you take a look and push a fix? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[jira] [Created] (KAFKA-17452) Fix flaky QuorumControllerTest#testUncleanShutdownBroker

2024-08-30 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-17452: -- Summary: Fix flaky QuorumControllerTest#testUncleanShutdownBroker Key: KAFKA-17452 URL: https://issues.apache.org/jira/browse/KAFKA-17452 Project: Kafka

[jira] [Created] (KAFKA-17453) Fix flaky PlaintextConsumerFetchTest#testFetchOutOfRangeOffsetResetConfigLatest

2024-08-30 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-17453: -- Summary: Fix flaky PlaintextConsumerFetchTest#testFetchOutOfRangeOffsetResetConfigLatest Key: KAFKA-17453 URL: https://issues.apache.org/jira/browse/KAFKA-17453 P

[jira] [Updated] (KAFKA-17453) Fix flaky PlaintextConsumerFetchTest#testFetchOutOfRangeOffsetResetConfigLatest

2024-08-30 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17453?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-17453: --- Description: {code:java} Errorjava.util.NoSuchElementExceptionStacktracejava.util.NoSuchElem

Re: [PR] KAFKA-17331: Throw unsupported version exception if the server does NOT support EarliestLocalSpec and LatestTieredSpec [kafka]

2024-08-30 Thread via GitHub
chia7712 commented on PR #16873: URL: https://github.com/apache/kafka/pull/16873#issuecomment-2321891055 The failed tests are flaky. the related jira are shown below. https://issues.apache.org/jira/browse/KAFKA-17265 https://issues.apache.org/jira/browse/KAFKA-16174 https://issues.ap

Re: [PR] KAFKA-17331: Throw unsupported version exception if the server does NOT support EarliestLocalSpec and LatestTieredSpec [kafka]

2024-08-30 Thread via GitHub
chia7712 commented on PR #16873: URL: https://github.com/apache/kafka/pull/16873#issuecomment-2321894140 I will merge this PR to trunk and 3.9 tomorrow if no objection -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

Re: [PR] KAFKA-17331: Throw unsupported version exception if the server does NOT support EarliestLocalSpec and LatestTieredSpec [kafka]

2024-08-30 Thread via GitHub
junrao commented on code in PR #16873: URL: https://github.com/apache/kafka/pull/16873#discussion_r1739140459 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -1104,35 +1104,43 @@ class KafkaApis(val requestChannel: RequestChannel, val responseTopics = authorize

Re: [PR] KAFKA-16792: Enable consumer unit tests that fail to fetch offsets only for new consumer with poll(0) [kafka]

2024-08-30 Thread via GitHub
lianetm commented on code in PR #16982: URL: https://github.com/apache/kafka/pull/16982#discussion_r1739141821 ## clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java: ## @@ -1053,12 +1053,20 @@ public void testFetchStableOffsetThrowInCommitted(GroupPr

[jira] [Commented] (KAFKA-16792) Enable consumer unit tests that fail to fetch offsets only for new consumer with poll(0)

2024-08-30 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17878191#comment-17878191 ] Lianet Magrans commented on KAFKA-16792: Thinking more about this, I wonder if w

[jira] [Commented] (KAFKA-16758) Extend Consumer#close with option to leave the group or not

2024-08-30 Thread Lucas Brutschy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17878220#comment-17878220 ] Lucas Brutschy commented on KAFKA-16758: Hey lianet, are you still planning to d

[jira] [Comment Edited] (KAFKA-16758) Extend Consumer#close with option to leave the group or not

2024-08-30 Thread Lucas Brutschy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17878220#comment-17878220 ] Lucas Brutschy edited comment on KAFKA-16758 at 8/30/24 6:19 PM: -

Re: [PR] KAFKA-17400: Added share fetch purgatory for delaying share fetch requests which cannot be completed because of reaching record lock partition limit [kafka]

2024-08-30 Thread via GitHub
junrao commented on code in PR #16969: URL: https://github.com/apache/kafka/pull/16969#discussion_r1739168653 ## core/src/main/java/kafka/server/share/DelayedShareFetch.java: ## @@ -0,0 +1,222 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * cont

[jira] [Created] (KAFKA-17454) Fix failed transactions_mixed_versions_test.py when running with 3.2

2024-08-30 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-17454: -- Summary: Fix failed transactions_mixed_versions_test.py when running with 3.2 Key: KAFKA-17454 URL: https://issues.apache.org/jira/browse/KAFKA-17454 Project: Kaf

Re: [PR] ISSUE-1014 Should fail in the queue [kafka-merge-queue-sandbox]

2024-08-30 Thread via GitHub
mumrah closed pull request #21: ISSUE-1014 Should fail in the queue URL: https://github.com/apache/kafka-merge-queue-sandbox/pull/21 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[PR] Update README.md [kafka-merge-queue-sandbox]

2024-08-30 Thread via GitHub
mumrah opened a new pull request, #43: URL: https://github.com/apache/kafka-merge-queue-sandbox/pull/43 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[jira] [Updated] (KAFKA-17454) Fix failed transactions_mixed_versions_test.py when running with 3.2

2024-08-30 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17454?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-17454: --- Fix Version/s: 4.0.0 3.9.0 > Fix failed transactions_mixed_versions_test.

[jira] [Commented] (KAFKA-17454) Fix failed transactions_mixed_versions_test.py when running with 3.2

2024-08-30 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17878223#comment-17878223 ] Chia-Ping Tsai commented on KAFKA-17454: noted: the error happens only if the si

[jira] [Updated] (KAFKA-17454) Fix failed transactions_mixed_versions_test.py when running with 3.2

2024-08-30 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17454?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-17454: --- Priority: Blocker (was: Major) > Fix failed transactions_mixed_versions_test.py when runnin

Re: [PR] Update README.md [kafka-merge-queue-sandbox]

2024-08-30 Thread via GitHub
mumrah merged PR #43: URL: https://github.com/apache/kafka-merge-queue-sandbox/pull/43 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@

[jira] [Updated] (KAFKA-17454) Fix failed transactions_mixed_versions_test.py when running with 3.2

2024-08-30 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17454?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-17454: --- Fix Version/s: (was: 3.9.0) > Fix failed transactions_mixed_versions_test.py when runnin

[jira] [Updated] (KAFKA-17454) Fix failed transactions_mixed_versions_test.py when running with 3.2

2024-08-30 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17454?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-17454: --- Fix Version/s: 3.9.0 > Fix failed transactions_mixed_versions_test.py when running with 3.2

Re: [PR] MINOR Handle test re-runs in junit.py [kafka]

2024-08-30 Thread via GitHub
mumrah commented on code in PR #17034: URL: https://github.com/apache/kafka/pull/17034#discussion_r1739299366 ## .github/scripts/junit.py: ## @@ -148,29 +168,73 @@ def pretty_time_duration(seconds: float) -> str: total_failures += suite.failures

[PR] Testing 2 [kafka]

2024-08-30 Thread via GitHub
mumrah opened a new pull request, #17062: URL: https://github.com/apache/kafka/pull/17062 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mai

Re: [PR] KAFKA-17442: Handled persister errors with write async calls (KIP-932) [kafka]

2024-08-30 Thread via GitHub
junrao commented on code in PR #16956: URL: https://github.com/apache/kafka/pull/16956#discussion_r1739379496 ## core/src/test/java/kafka/server/share/SharePartitionTest.java: ## @@ -4191,11 +4337,11 @@ public void testAcknowledgeSubsetWithAnotherMember() { Coll

Re: [PR] KAFKA-17400: Added share fetch purgatory for delaying share fetch requests which cannot be completed because of reaching record lock partition limit [kafka]

2024-08-30 Thread via GitHub
junrao commented on code in PR #16969: URL: https://github.com/apache/kafka/pull/16969#discussion_r1739387577 ## core/src/main/java/kafka/server/share/SharePartitionManager.java: ## @@ -498,10 +519,17 @@ List cachedTopicIdPartitionsInShareSession(String groupId, Uui re

Re: [PR] Kafka 8850: Updated documentation to clarify fetch.min.bytes behaviour. [kafka]

2024-08-30 Thread via GitHub
mjsax commented on PR #16749: URL: https://github.com/apache/kafka/pull/16749#issuecomment-2322298335 \cc @lianetm for review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

  1   2   >