dajac commented on code in PR #17057:
URL: https://github.com/apache/kafka/pull/17057#discussion_r1738610851
##########
tools/src/test/java/org/apache/kafka/tools/consumer/group/ConsumerGroupCommandTestUtils.java:
##########
@@ -79,34 +77,34 @@ private ConsumerGroupCommandTestUtils() {
}
static List<ClusterConfig> generator() {
- return Stream.concat(forConsumerGroupCoordinator().stream(),
forClassicGroupCoordinator().stream())
- .collect(Collectors.toList());
+ return Stream
+ .concat(forKRaftGroupCoordinator().stream(),
forZkGroupCoordinator().stream())
+ .collect(Collectors.toList());
}
- static List<ClusterConfig> forConsumerGroupCoordinator() {
+ static List<ClusterConfig> forKRaftGroupCoordinator() {
Map<String, String> serverProperties = new HashMap<>();
serverProperties.put(OFFSETS_TOPIC_PARTITIONS_CONFIG, "1");
serverProperties.put(OFFSETS_TOPIC_REPLICATION_FACTOR_CONFIG, "1");
serverProperties.put(NEW_GROUP_COORDINATOR_ENABLE_CONFIG, "true");
Review Comment:
I was debating whether I should remove those in this PR. I can do it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
