chia7712 commented on code in PR #15821:
URL: https://github.com/apache/kafka/pull/15821#discussion_r1612965039
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/ConsumerGroupCommandTestUtils.java:
##
@@ -68,15 +68,31 @@ static List generator() {
ClusterConfi
[
https://issues.apache.org/jira/browse/KAFKA-16520?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nikolay Izhikov reassigned KAFKA-16520:
---
Assignee: Nikolay Izhikov (was: José Armando García Sancio)
> Changes to DescribeQ
[
https://issues.apache.org/jira/browse/KAFKA-16798?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thanos Athanasopoulos resolved KAFKA-16798.
---
Resolution: Not A Bug
This issue was resolved after input stated in the prev
dajac commented on code in PR #16054:
URL: https://github.com/apache/kafka/pull/16054#discussion_r1613013960
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/AbstractGroup.java:
##
@@ -0,0 +1,625 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) un
dajac commented on PR #15970:
URL: https://github.com/apache/kafka/pull/15970#issuecomment-2128833459
The failed tests are related to https://github.com/apache/kafka/pull/15972.
Merging to trunk.
--
This is an automated message from the Apache Git Service.
To respond to the message, pleas
dajac merged PR #15970:
URL: https://github.com/apache/kafka/pull/15970
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
[
https://issues.apache.org/jira/browse/KAFKA-16626?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Jacot resolved KAFKA-16626.
-
Fix Version/s: 3.8.0
Resolution: Fixed
> Uuid to String for subscribed topic names in ass
abhijeetk88 commented on code in PR #15625:
URL: https://github.com/apache/kafka/pull/15625#discussion_r1613033249
##
storage/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogManagerConfig.java:
##
@@ -143,6 +143,38 @@ public final class RemoteLogManagerConfig {
dajac commented on code in PR #16059:
URL: https://github.com/apache/kafka/pull/16059#discussion_r1613028497
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntime.java:
##
@@ -1365,6 +1368,11 @@ public void onHighWatermarkUpdated(
rreddy-22 opened a new pull request, #16068:
URL: https://github.com/apache/kafka/pull/16068
Create a new interface called MemberSubscriptionSpec to hold the members
subscription information.
The assignment member spec is replaced by the MemberSubscriptionSpecImpl
class.
Eventually we
ableegoldman commented on code in PR #16052:
URL: https://github.com/apache/kafka/pull/16052#discussion_r1613071356
##
streams/src/main/java/org/apache/kafka/streams/processor/assignment/assignors/StickyTaskAssignor.java:
##
@@ -0,0 +1,478 @@
+/*
+ * Licensed to the Apache Softw
AndrewJSchofield commented on PR #16022:
URL: https://github.com/apache/kafka/pull/16022#issuecomment-2128913832
There are 2 test failures introduced by this PR. I'll get them fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
ableegoldman commented on code in PR #16052:
URL: https://github.com/apache/kafka/pull/16052#discussion_r1613071356
##
streams/src/main/java/org/apache/kafka/streams/processor/assignment/assignors/StickyTaskAssignor.java:
##
@@ -0,0 +1,478 @@
+/*
+ * Licensed to the Apache Softw
ableegoldman commented on code in PR #16033:
URL: https://github.com/apache/kafka/pull/16033#discussion_r1613111098
##
streams/src/main/java/org/apache/kafka/streams/processor/assignment/TaskAssignmentUtils.java:
##
@@ -74,20 +209,240 @@ public static Map
optimizeRackAwareStand
nicktelford commented on code in PR #16041:
URL: https://github.com/apache/kafka/pull/16041#discussion_r1613112730
##
streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredKeyValueStore.java:
##
@@ -169,6 +172,10 @@ private void registerMetrics() {
itera
nicktelford commented on code in PR #16041:
URL: https://github.com/apache/kafka/pull/16041#discussion_r1613112730
##
streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredKeyValueStore.java:
##
@@ -169,6 +172,10 @@ private void registerMetrics() {
itera
frankvicky commented on PR #16017:
URL: https://github.com/apache/kafka/pull/16017#issuecomment-2129009977
Hi @lianetm,
I really appreciate your suggestion. These suggestions are very helpful to
me. I will give them a try. 😸
--
This is an automated message from the Apache Git Service.
[
https://issues.apache.org/jira/browse/KAFKA-16835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Manjunath updated KAFKA-16835:
--
Language: java C++ (was: Java java)
> Add Support for consumer to read in commit order.
> ---
dajac commented on code in PR #16057:
URL: https://github.com/apache/kafka/pull/16057#discussion_r1613089003
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -2041,6 +2027,36 @@ private CoordinatorResult
consumerGroupFenceM
muralibasani opened a new pull request, #16069:
URL: https://github.com/apache/kafka/pull/16069
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
- kafka-storag
[
https://issues.apache.org/jira/browse/KAFKA-16518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17849236#comment-17849236
]
Muralidhar Basani commented on KAFKA-16518:
---
[~jsancio] have a draft pr opened
nicktelford commented on code in PR #16041:
URL: https://github.com/apache/kafka/pull/16041#discussion_r1613112730
##
streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredKeyValueStore.java:
##
@@ -169,6 +172,10 @@ private void registerMetrics() {
itera
nicktelford commented on code in PR #16041:
URL: https://github.com/apache/kafka/pull/16041#discussion_r1613112730
##
streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredKeyValueStore.java:
##
@@ -169,6 +172,10 @@ private void registerMetrics() {
itera
nicktelford commented on code in PR #16041:
URL: https://github.com/apache/kafka/pull/16041#discussion_r1613112730
##
streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredKeyValueStore.java:
##
@@ -169,6 +172,10 @@ private void registerMetrics() {
itera
nicktelford commented on code in PR #16041:
URL: https://github.com/apache/kafka/pull/16041#discussion_r1613112730
##
streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredKeyValueStore.java:
##
@@ -169,6 +172,10 @@ private void registerMetrics() {
itera
nikramakrishnan commented on PR #16005:
URL: https://github.com/apache/kafka/pull/16005#issuecomment-2129187298
> Instead we should throw an exception (or stateChangeLogger.error) like
mentioned below here, and write a unit test just for this class
Do you mean we mock `onPartitionLead
omkreddy commented on PR #16027:
URL: https://github.com/apache/kafka/pull/16027#issuecomment-2129194429
There is an failure due to missing license:
```
[2024-05-23T07:39:35.270Z] Execution failed for task ':rat'.
[2024-05-23T07:39:35.270Z] > A failure occurred while executin
mimaison merged PR #15377:
URL: https://github.com/apache/kafka/pull/15377
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
edoardocomar opened a new pull request, #16070:
URL: https://github.com/apache/kafka/pull/16070
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade
edoardocomar commented on PR #15910:
URL: https://github.com/apache/kafka/pull/15910#issuecomment-2129247940
@gharris1727 please see https://github.com/apache/kafka/pull/16070
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
edoardocomar commented on PR #16070:
URL: https://github.com/apache/kafka/pull/16070#issuecomment-2129249297
As discussed in
https://github.com/apache/kafka/pull/15910#issuecomment-2127588361
--
This is an automated message from the Apache Git Service.
To respond to the message, please lo
nicktelford commented on code in PR #16041:
URL: https://github.com/apache/kafka/pull/16041#discussion_r1613293262
##
streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredKeyValueStore.java:
##
@@ -169,6 +172,10 @@ private void registerMetrics() {
itera
AndrewJSchofield commented on PR #16058:
URL: https://github.com/apache/kafka/pull/16058#issuecomment-2129297575
LGTM apart from a few test failures related to the new RPCs, such as
RequestConvertToJsonTest.
--
This is an automated message from the Apache Git Service.
To respond to the me
AndrewJSchofield commented on code in PR #16054:
URL: https://github.com/apache/kafka/pull/16054#discussion_r1613325546
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/AbstractGroup.java:
##
@@ -0,0 +1,625 @@
+/*
+ * Licensed to the Apache Software Foundati
dajac merged PR #16047:
URL: https://github.com/apache/kafka/pull/16047
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
[
https://issues.apache.org/jira/browse/KAFKA-16815?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Jacot resolved KAFKA-16815.
-
Fix Version/s: 3.8.0
Reviewer: David Jacot
Resolution: Fixed
> Handle FencedInst
Sergey Ivanov created KAFKA-16837:
-
Summary: Kafka Connect fails on update connector for incorrect
previous Config Provider tasks
Key: KAFKA-16837
URL: https://issues.apache.org/jira/browse/KAFKA-16837
[
https://issues.apache.org/jira/browse/KAFKA-16837?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sergey Ivanov updated KAFKA-16837:
--
Attachment: kafka_connect_config.png
> Kafka Connect fails on update connector for incorrect p
abhijeetk88 opened a new pull request, #16071:
URL: https://github.com/apache/kafka/pull/16071
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of tes
Sergey Ivanov created KAFKA-16838:
-
Summary: Kafka Connect loads old tasks from removed connectors
Key: KAFKA-16838
URL: https://issues.apache.org/jira/browse/KAFKA-16838
Project: Kafka
Issue
dajac opened a new pull request, #16072:
URL: https://github.com/apache/kafka/pull/16072
This patch was initially created in
https://github.com/apache/kafka/pull/15536.
When there is a commit for multiple topic partitions and some, but not all,
exceed the offset metadata limit, the p
[
https://issues.apache.org/jira/browse/KAFKA-16837?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sergey Ivanov updated KAFKA-16837:
--
Description:
Hello,
We faced an issue when is not possible to update Connector config if the
[
https://issues.apache.org/jira/browse/KAFKA-16838?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sergey Ivanov updated KAFKA-16838:
--
Description:
Hello,
When creating connector we faced an error from one of our ConfigProviders
chia7712 commented on code in PR #16062:
URL: https://github.com/apache/kafka/pull/16062#discussion_r1613444662
##
clients/src/main/java/org/apache/kafka/common/PartitionInfo.java:
##
@@ -88,6 +90,28 @@ public Node[] offlineReplicas() {
return offlineReplicas;
}
[
https://issues.apache.org/jira/browse/KAFKA-10234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai resolved KAFKA-10234.
Resolution: Invalid
> The key/value deserializer used by ConsoleConsumer is not closed
> -
dajac commented on code in PR #16068:
URL: https://github.com/apache/kafka/pull/16068#discussion_r1613460654
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/TargetAssignmentBuilder.java:
##
@@ -277,13 +277,22 @@ public TargetAssignmentBuilder remov
muralibasani commented on PR #16005:
URL: https://github.com/apache/kafka/pull/16005#issuecomment-2129528563
@nikramakrishnan I have pushed a few changes. Please review.
We explicitly throw a KafkaException now if rlm is not configured and remote
storage is enabled
--
This is an automa
[
https://issues.apache.org/jira/browse/KAFKA-16838?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sergey Ivanov updated KAFKA-16838:
--
Description:
Hello,
When creating connector we faced an error from one of our ConfigProviders
[
https://issues.apache.org/jira/browse/KAFKA-16837?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sergey Ivanov updated KAFKA-16837:
--
Description:
Hello,
We faced an issue when is not possible to update Connector config if the
m1a2st commented on code in PR #16042:
URL: https://github.com/apache/kafka/pull/16042#discussion_r1613525989
##
core/src/main/scala/kafka/server/ReplicaManager.scala:
##
@@ -1247,7 +1247,8 @@ class ReplicaManager(val config: KafkaConfig,
val usableBytes = adjustForLarg
[
https://issues.apache.org/jira/browse/KAFKA-16838?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sergey Ivanov updated KAFKA-16838:
--
Description:
Hello,
When creating connector we faced an error from one of our ConfigProviders
m1a2st commented on code in PR #16042:
URL: https://github.com/apache/kafka/pull/16042#discussion_r1613531701
##
core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala:
##
@@ -6594,6 +6594,64 @@ class ReplicaManagerTest {
))
}
}
+
+ @Test
+ def testRepli
nicktelford commented on code in PR #16041:
URL: https://github.com/apache/kafka/pull/16041#discussion_r1613568734
##
streams/src/test/java/org/apache/kafka/streams/state/internals/MeteredKeyValueStoreTest.java:
##
@@ -490,6 +490,31 @@ public void shouldTimeIteratorDuration() {
[
https://issues.apache.org/jira/browse/KAFKA-16503?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Jacot reassigned KAFKA-16503:
---
Assignee: David Jacot
> getOrMaybeCreateClassicGroup should not thrown GroupIdNotFoundExcep
lianetm commented on code in PR #16054:
URL: https://github.com/apache/kafka/pull/16054#discussion_r1613579324
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/AbstractGroup.java:
##
@@ -0,0 +1,625 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
lianetm commented on code in PR #16054:
URL: https://github.com/apache/kafka/pull/16054#discussion_r1613579324
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/AbstractGroup.java:
##
@@ -0,0 +1,625 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
lianetm commented on code in PR #16054:
URL: https://github.com/apache/kafka/pull/16054#discussion_r1613579324
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/AbstractGroup.java:
##
@@ -0,0 +1,625 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
lianetm commented on code in PR #16054:
URL: https://github.com/apache/kafka/pull/16054#discussion_r1613579324
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/AbstractGroup.java:
##
@@ -0,0 +1,625 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
apoorvmittal10 commented on code in PR #16054:
URL: https://github.com/apache/kafka/pull/16054#discussion_r1613594739
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/AbstractGroup.java:
##
@@ -0,0 +1,625 @@
+/*
+ * Licensed to the Apache Software Foundation
jeffkbkim commented on code in PR #16057:
URL: https://github.com/apache/kafka/pull/16057#discussion_r1613555271
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -4424,14 +4441,113 @@ private ConsumerGroupMember
validateCons
dajac opened a new pull request, #16073:
URL: https://github.com/apache/kafka/pull/16073
`getOrMaybeCreateClassicGroup` is mainly used by old APIs which expects
UnknownMemberIdException when the group does not exist.
### Committer Checklist (excluded from commit message)
- [ ] Veri
junrao commented on code in PR #15685:
URL: https://github.com/apache/kafka/pull/15685#discussion_r1612454534
##
server-common/src/main/java/org/apache/kafka/server/common/FinalizedFeatures.java:
##
@@ -0,0 +1,87 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
lianetm commented on PR #16032:
URL: https://github.com/apache/kafka/pull/16032#issuecomment-2129757705
Follow-up task
[KAFKA-16823](https://issues.apache.org/jira/browse/KAFKA-16823) to refactor
the test common functionality, and move out the unit tests that apply to the`
LegacyConsumer`
gaurav-narula commented on code in PR #15863:
URL: https://github.com/apache/kafka/pull/15863#discussion_r1613630123
##
core/src/main/scala/kafka/log/LogCleaner.scala:
##
@@ -223,8 +230,8 @@ class LogCleaner(initialConfig: CleanerConfig,
info(s"Updating logCleanerIoMaxByt
jolshan commented on code in PR #15685:
URL: https://github.com/apache/kafka/pull/15685#discussion_r1613634445
##
server-common/src/main/java/org/apache/kafka/server/common/TestFeatureVersion.java:
##
@@ -21,16 +21,17 @@
public enum TestFeatureVersion implements FeatureVersio
dajac commented on code in PR #16054:
URL: https://github.com/apache/kafka/pull/16054#discussion_r1613638293
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/AbstractGroup.java:
##
@@ -0,0 +1,625 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) un
jolshan commented on code in PR #15685:
URL: https://github.com/apache/kafka/pull/15685#discussion_r1613639487
##
core/src/main/scala/kafka/tools/StorageTool.scala:
##
@@ -109,6 +111,52 @@ object StorageTool extends Logging {
}
}
+ private def validateMetadataVersion(
jolshan commented on code in PR #15685:
URL: https://github.com/apache/kafka/pull/15685#discussion_r1613639487
##
core/src/main/scala/kafka/tools/StorageTool.scala:
##
@@ -109,6 +111,52 @@ object StorageTool extends Logging {
}
}
+ private def validateMetadataVersion(
jolshan commented on code in PR #15685:
URL: https://github.com/apache/kafka/pull/15685#discussion_r1613656338
##
server-common/src/main/java/org/apache/kafka/server/common/TestFeatureVersion.java:
##
@@ -21,16 +21,17 @@
public enum TestFeatureVersion implements FeatureVersio
[
https://issues.apache.org/jira/browse/KAFKA-16518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17849332#comment-17849332
]
José Armando García Sancio commented on KAFKA-16518:
HI [~muralibasa
apourchet commented on code in PR #16052:
URL: https://github.com/apache/kafka/pull/16052#discussion_r1613682502
##
streams/src/main/java/org/apache/kafka/streams/processor/assignment/assignors/StickyTaskAssignor.java:
##
@@ -0,0 +1,478 @@
+/*
+ * Licensed to the Apache Software
[
https://issues.apache.org/jira/browse/KAFKA-16530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17849334#comment-17849334
]
José Armando García Sancio commented on KAFKA-16530:
{quote}Perhaps
dajac commented on code in PR #16054:
URL: https://github.com/apache/kafka/pull/16054#discussion_r1613686172
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/AbstractGroup.java:
##
@@ -0,0 +1,625 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) un
apourchet opened a new pull request, #16074:
URL: https://github.com/apache/kafka/pull/16074
This PR creates the new public config of KIP-924 in StreamsConfig and uses
it to instantiate user-created TaskAssignors. If such a TaskAssignor is found
and successfully created we then use that ass
dongnuo123 commented on code in PR #16057:
URL: https://github.com/apache/kafka/pull/16057#discussion_r1613724622
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -4424,14 +4441,113 @@ private ConsumerGroupMember
validateCon
junrao commented on code in PR #15685:
URL: https://github.com/apache/kafka/pull/15685#discussion_r1613728690
##
core/src/main/scala/kafka/tools/StorageTool.scala:
##
@@ -109,6 +111,52 @@ object StorageTool extends Logging {
}
}
+ private def validateMetadataVersion(m
agavra commented on code in PR #16074:
URL: https://github.com/apache/kafka/pull/16074#discussion_r1613728858
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/AssignorConfiguration.java:
##
@@ -253,6 +253,21 @@ public TaskAssignor taskAssignor() {
chia7712 commented on code in PR #16072:
URL: https://github.com/apache/kafka/pull/16072#discussion_r1613735230
##
core/src/test/scala/unit/kafka/coordinator/group/GroupMetadataManagerTest.scala:
##
@@ -1664,6 +1664,134 @@ class GroupMetadataManagerTest {
assertEquals(0, Te
dajac commented on code in PR #16072:
URL: https://github.com/apache/kafka/pull/16072#discussion_r1613744158
##
core/src/test/scala/unit/kafka/coordinator/group/GroupMetadataManagerTest.scala:
##
@@ -1664,6 +1664,134 @@ class GroupMetadataManagerTest {
assertEquals(0, TestU
dajac commented on PR #16072:
URL: https://github.com/apache/kafka/pull/16072#issuecomment-2129955822
> BTW, I notice that createPutCacheCallback has a input argument
preAppendErrors which is never defined. Is it a unfinished feature or a stuff
we can remove.
Hum... I am not sure abo
dongnuo123 commented on code in PR #16057:
URL: https://github.com/apache/kafka/pull/16057#discussion_r1613748822
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -4424,14 +4441,113 @@ private ConsumerGroupMember
validateCon
[
https://issues.apache.org/jira/browse/KAFKA-16530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17849342#comment-17849342
]
Alyssa Huang commented on KAFKA-16530:
--
[~jsancio]
> This is not correct because t
kamalcph commented on PR #15825:
URL: https://github.com/apache/kafka/pull/15825#issuecomment-2129976827
Test failures are unrelated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
jolshan commented on code in PR #15685:
URL: https://github.com/apache/kafka/pull/15685#discussion_r1613761681
##
core/src/main/scala/kafka/tools/StorageTool.scala:
##
@@ -109,6 +111,52 @@ object StorageTool extends Logging {
}
}
+ private def validateMetadataVersion(
omkreddy merged PR #16027:
URL: https://github.com/apache/kafka/pull/16027
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
cmccabe closed pull request #16008: KAFKA-16516: Fix the controller node
provider for broker to control channel
URL: https://github.com/apache/kafka/pull/16008
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
cmccabe commented on PR #16008:
URL: https://github.com/apache/kafka/pull/16008#issuecomment-2129992325
merged (from CLI, since GH is acting flaky)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
gharris1727 commented on PR #16051:
URL: https://github.com/apache/kafka/pull/16051#issuecomment-2129998314
Hey @jolshan @mumrah @ijuma PTAL at the build to see the effect, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitH
dajac commented on code in PR #16057:
URL: https://github.com/apache/kafka/pull/16057#discussion_r1613785754
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -4424,14 +4441,113 @@ private ConsumerGroupMember
validateConsumer
CalvinConfluent opened a new pull request, #16075:
URL: https://github.com/apache/kafka/pull/16075
Skip using steam when expiring the producer ID. This can improve the
performance more than 30%
Before
```
Benchmark(numProducerIds) Mode Cnt
jolshan commented on PR #16075:
URL: https://github.com/apache/kafka/pull/16075#issuecomment-2130025720
Thanks Calvin -- similar to this PR
https://github.com/apache/kafka/pull/15969
I will take a look soon :)
--
This is an automated message from the Apache Git Service.
To respond to
cmccabe closed pull request #16006: KAFKA-16515: Fix the ZK Metadata cache
confusion between brokers and controllers
URL: https://github.com/apache/kafka/pull/16006
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
cmccabe commented on PR #16006:
URL: https://github.com/apache/kafka/pull/16006#issuecomment-2130026904
failures not related. committed, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
rishiraj88 commented on code in PR #15863:
URL: https://github.com/apache/kafka/pull/15863#discussion_r1613799763
##
core/src/main/scala/kafka/log/LogCleaner.scala:
##
@@ -223,8 +230,8 @@ class LogCleaner(initialConfig: CleanerConfig,
info(s"Updating logCleanerIoMaxBytesP
jolshan commented on PR #16072:
URL: https://github.com/apache/kafka/pull/16072#issuecomment-2130038593
> Hum... I am not sure about this one. @jolshan Would you know?
There was a lot of refactoring in this path so we may have just missed this.
It was originally intended for any verif
edoardocomar commented on PR #16070:
URL: https://github.com/apache/kafka/pull/16070#issuecomment-2130039173
Do you want an empty one? I’d assume what’s new for 3.7.1 is Included in 3.8
…
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
chia7712 commented on code in PR #16072:
URL: https://github.com/apache/kafka/pull/16072#discussion_r1613803124
##
core/src/test/scala/unit/kafka/coordinator/group/GroupMetadataManagerTest.scala:
##
@@ -1664,6 +1664,134 @@ class GroupMetadataManagerTest {
assertEquals(0, Te
jeffkbkim commented on code in PR #15974:
URL: https://github.com/apache/kafka/pull/15974#discussion_r1613806818
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/assignor/GroupSpecImplTest.java:
##
@@ -0,0 +1,83 @@
+/*
+ * Licensed to the Apache Software Fou
jeffkbkim commented on code in PR #15974:
URL: https://github.com/apache/kafka/pull/15974#discussion_r1613806818
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/assignor/GroupSpecImplTest.java:
##
@@ -0,0 +1,83 @@
+/*
+ * Licensed to the Apache Software Fou
gharris1727 commented on PR #16070:
URL: https://github.com/apache/kafka/pull/16070#issuecomment-2130052791
> I’d assume what’s new for 3.7.1 is Included in 3.8 …
I don't think everyone thinks this way. Someone can easily read the 3.8.0
release notes and never read the 3.7.1 notes. I'
1 - 100 of 187 matches
Mail list logo
