chia7712 commented on code in PR #16062:
URL: https://github.com/apache/kafka/pull/16062#discussion_r1613444662


##########
clients/src/main/java/org/apache/kafka/common/PartitionInfo.java:
##########
@@ -88,6 +90,28 @@ public Node[] offlineReplicas() {
         return offlineReplicas;
     }
 
+    @Override
+    public int hashCode() {
+        return Objects.hash(topic, partition, leader, replicas, 
inSyncReplicas, offlineReplicas);

Review Comment:
   Should we use `Arrays.hashCode(replicas)` to make sure the hash code is 
generated by "content" rather than reference?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to