Re: [PR] MINOR: Add a constructor to accept cause in ConfigException [kafka]

2024-05-21 Thread via GitHub
gaurav-narula closed pull request #15994: MINOR: Add a constructor to accept cause in ConfigException URL: https://github.com/apache/kafka/pull/15994 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[PR] [draft] Debug DynamicBrokerReconfigurationTest::testTrustStoreAlter flakyness [kafka]

2024-05-21 Thread via GitHub
gaurav-narula opened a new pull request, #16014: URL: https://github.com/apache/kafka/pull/16014 WIP -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-16362: Fix type-unsafety in KStreamKStreamJoin caused by isLeftSide [kafka]

2024-05-21 Thread via GitHub
raminqaf commented on code in PR #15601: URL: https://github.com/apache/kafka/pull/15601#discussion_r1607786468 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamJoin.java: ## @@ -187,17 +157,25 @@ public void process(final Record record) {

[jira] [Updated] (KAFKA-16798) Mirrormaker2 dedicated mode - sync.group.offsets.interval not working

2024-05-21 Thread Thanos Athanasopoulos (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16798?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thanos Athanasopoulos updated KAFKA-16798: -- Description: Single instance MirrorMaker2 in dedicated mode, active passive re

[jira] [Commented] (KAFKA-15242) FixedKeyProcessor testing is unusable

2024-05-21 Thread Matej Sprysl (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17848079#comment-17848079 ] Matej Sprysl commented on KAFKA-15242: -- Agreed, close this one and enrich the other

Re: [PR] KAFKA-16625: Reverse lookup map from topic partitions to members [kafka]

2024-05-21 Thread via GitHub
dajac commented on code in PR #15974: URL: https://github.com/apache/kafka/pull/15974#discussion_r1607787555 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java: ## @@ -516,16 +522,78 @@ public Assignment targetAssignment(String memb

Re: [PR] MINOR: Upgrade scala-logging to 3.9.5 [kafka]

2024-05-21 Thread via GitHub
sjhajharia commented on PR #15914: URL: https://github.com/apache/kafka/pull/15914#issuecomment-2122006555 @viktorsomogyi I see that both scala-logging 3.9.5 and 3.9.4 have the same vulnerability coming in from `[CVE-2023-6378]`. Is there a reason thus that we want this upgrade?

Re: [PR] KAFKA-16626: Lazily convert subscribed topic names to topic ids [kafka]

2024-05-21 Thread via GitHub
dajac commented on code in PR #15970: URL: https://github.com/apache/kafka/pull/15970#discussion_r1607805094 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/AssignmentMemberSpec.java: ## @@ -65,7 +64,7 @@ public Optional rackId() { /** *

Re: [PR] KAFKA-16757: Fix broker re-registration issues around MV 3.7-IV2 [kafka]

2024-05-21 Thread via GitHub
soarez commented on code in PR #15945: URL: https://github.com/apache/kafka/pull/15945#discussion_r1606964394 ## core/src/main/scala/kafka/server/BrokerLifecycleManager.scala: ## @@ -257,11 +257,11 @@ class BrokerLifecycleManager( eventQueue.append(new OfflineDirEvent(direc

[jira] [Updated] (KAFKA-16757) Fix broker re-registration issues around MV 3.7-IV2

2024-05-21 Thread Igor Soarez (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16757?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Soarez updated KAFKA-16757: Fix Version/s: 3.7.1 3.8 > Fix broker re-registration issues around MV 3.7-IV2

[jira] [Commented] (KAFKA-16757) Fix broker re-registration issues around MV 3.7-IV2

2024-05-21 Thread Igor Soarez (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17848093#comment-17848093 ] Igor Soarez commented on KAFKA-16757: - IIUC, this bug means that brokers can end up

Re: [PR] KAFKA-16709: abortAndPauseCleaning only when future log is not existed [kafka]

2024-05-21 Thread via GitHub
soarez commented on code in PR #15951: URL: https://github.com/apache/kafka/pull/15951#discussion_r1607884973 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -2114,19 +2114,16 @@ class ReplicaManager(val config: KafkaConfig, partition.log.foreach { _ =>

Re: [PR] KAFKA-14588 [4/N] ConfigCommandTest rewritten in java [kafka]

2024-05-21 Thread via GitHub
chia7712 merged PR #15839: URL: https://github.com/apache/kafka/pull/15839 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-16629: Add broker-related tests to ConfigCommandIntegrationTest [kafka]

2024-05-21 Thread via GitHub
chia7712 commented on PR #15840: URL: https://github.com/apache/kafka/pull/15840#issuecomment-2122085078 @m1a2st Could you please fix conflicts? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

Re: [PR] KAFKA-16675: Refactored and new rebalance callbacks integration tests [kafka]

2024-05-21 Thread via GitHub
lucasbru merged PR #15965: URL: https://github.com/apache/kafka/pull/15965 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Commented] (KAFKA-16800) Resolve Gradle 9.0 deprecations

2024-05-21 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17848106#comment-17848106 ] Chia-Ping Tsai commented on KAFKA-16800: oh, I do love this ticket!!! > Resolve

[jira] [Assigned] (KAFKA-16794) Can't open videos in streams documentation

2024-05-21 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16794?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai reassigned KAFKA-16794: -- Assignee: 黃竣陽 > Can't open videos in streams documentation >

Re: [PR] KAFKA-14588 [4/N] ConfigCommandTest rewritten in java [kafka]

2024-05-21 Thread via GitHub
nizhikov commented on PR #15839: URL: https://github.com/apache/kafka/pull/15839#issuecomment-2122099971 @chia7712 Thank you very much for review and merge! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[jira] [Commented] (KAFKA-16794) Can't open videos in streams documentation

2024-05-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17848108#comment-17848108 ] ASF GitHub Bot commented on KAFKA-16794: chia7712 merged PR #602: URL: https://g

[jira] [Commented] (KAFKA-16794) Can't open videos in streams documentation

2024-05-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17848110#comment-17848110 ] ASF GitHub Bot commented on KAFKA-16794: chia7712 commented on PR #602: URL: htt

[jira] [Commented] (KAFKA-16804) Replace gradle archivesBaseName with archivesName

2024-05-21 Thread TengYao Chi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17848109#comment-17848109 ] TengYao Chi commented on KAFKA-16804: - I will handle this one  > Replace gradle arc

[jira] [Resolved] (KAFKA-16794) Can't open videos in streams documentation

2024-05-21 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16794?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-16794. Fix Version/s: 3.8.0 Resolution: Fixed > Can't open videos in streams documentation

Re: [PR] KAFKA-15541: Add num-open-iterators metric [kafka]

2024-05-21 Thread via GitHub
nicktelford commented on code in PR #15975: URL: https://github.com/apache/kafka/pull/15975#discussion_r1607909252 ## streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredKeyValueStore.java: ## @@ -162,6 +165,8 @@ private void registerMetrics() { flushS

[PR] MINOR: fix streams_broker_compatibility test [kafka]

2024-05-21 Thread via GitHub
lucasbru opened a new pull request, #16015: URL: https://github.com/apache/kafka/pull/16015 The system test was broken in ccf4bd5f4621b80f5b1d3700df30e3b444381927 which failed to import the matrix symbol. The test was failing silently, not discovering any tests. ### Committer Che

Re: [PR] KAFKA-7632: Support Compression Levels (KIP-390) [kafka]

2024-05-21 Thread via GitHub
showuon commented on code in PR #15516: URL: https://github.com/apache/kafka/pull/15516#discussion_r1607919763 ## storage/src/main/java/org/apache/kafka/storage/internals/log/LogValidator.java: ## @@ -331,12 +332,12 @@ public ValidationResult assignOffsetsNonCompressed(LongRef

Re: [PR] Kafka-15444: Native docker image for Apache Kafka(KIP-974) [kafka]

2024-05-21 Thread via GitHub
VedarthConfluent commented on code in PR #15927: URL: https://github.com/apache/kafka/pull/15927#discussion_r1607922660 ## docker/native/Dockerfile: ## @@ -0,0 +1,84 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See

Re: [PR] Kafka-15444: Native docker image for Apache Kafka(KIP-974) [kafka]

2024-05-21 Thread via GitHub
VedarthConfluent commented on code in PR #15927: URL: https://github.com/apache/kafka/pull/15927#discussion_r1607922660 ## docker/native/Dockerfile: ## @@ -0,0 +1,84 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See

Re: [PR] KAFKA-7632: Support Compression Levels (KIP-390) [kafka]

2024-05-21 Thread via GitHub
showuon commented on code in PR #15516: URL: https://github.com/apache/kafka/pull/15516#discussion_r1607924069 ## clients/src/main/java/org/apache/kafka/common/config/TopicConfig.java: ## @@ -173,6 +173,14 @@ public class TopicConfig { "accepts 'uncompressed' which is e

Re: [PR] Kafka-15444: Native docker image for Apache Kafka(KIP-974) [kafka]

2024-05-21 Thread via GitHub
VedarthConfluent commented on code in PR #15927: URL: https://github.com/apache/kafka/pull/15927#discussion_r1607931858 ## docker/native/Dockerfile: ## @@ -0,0 +1,84 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See

Re: [PR] Kafka-15444: Native docker image for Apache Kafka(KIP-974) [kafka]

2024-05-21 Thread via GitHub
VedarthConfluent commented on code in PR #15927: URL: https://github.com/apache/kafka/pull/15927#discussion_r1607934286 ## docker/native/launch: ## @@ -0,0 +1,50 @@ +#!/bin/sh +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements

[jira] [Assigned] (KAFKA-16804) Replace gradle archivesBaseName with archivesName

2024-05-21 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai reassigned KAFKA-16804: -- Assignee: TengYao Chi > Replace gradle archivesBaseName with archivesName > -

[jira] [Assigned] (KAFKA-16666) Migrate `TransactionLogMessageFormatter`, GroupMetadataMessageFormatter` and `OffsetsMessageFormatter`to tools module

2024-05-21 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-1?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai reassigned KAFKA-1: -- Assignee: 黃竣陽 (was: Chia-Ping Tsai) > Migrate `TransactionLogMessageFormatter`, Grou

Re: [PR] KAFKA-16513: Add test for WriteTxnMarkers with AlterCluster permission [kafka]

2024-05-21 Thread via GitHub
clolov closed pull request #15952: KAFKA-16513: Add test for WriteTxnMarkers with AlterCluster permission URL: https://github.com/apache/kafka/pull/15952 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] KAFKA-16452: Don't throw OOORE when converting the offset to metadata [kafka]

2024-05-21 Thread via GitHub
showuon commented on code in PR #15825: URL: https://github.com/apache/kafka/pull/15825#discussion_r1608007659 ## core/src/main/scala/kafka/log/UnifiedLog.scala: ## @@ -1424,11 +1424,18 @@ class UnifiedLog(@volatile var logStartOffset: Long, /** * Given a message offse

Re: [PR] KAFKA-16452: Don't throw OOORE when converting the offset to metadata [kafka]

2024-05-21 Thread via GitHub
showuon commented on code in PR #15825: URL: https://github.com/apache/kafka/pull/15825#discussion_r1608007659 ## core/src/main/scala/kafka/log/UnifiedLog.scala: ## @@ -1424,11 +1424,18 @@ class UnifiedLog(@volatile var logStartOffset: Long, /** * Given a message offse

Re: [PR] KAFKA-16452: Don't throw OOORE when converting the offset to metadata [kafka]

2024-05-21 Thread via GitHub
showuon commented on code in PR #15825: URL: https://github.com/apache/kafka/pull/15825#discussion_r1608010033 ## core/src/test/scala/unit/kafka/log/UnifiedLogTest.scala: ## @@ -391,8 +398,10 @@ class UnifiedLogTest { assertNonEmptyFetch(log, offset, FetchIsolation.HIGH

Re: [PR] KAFKA-15905 Restarts of MirrorCheckpointTask should not permanently i… [kafka]

2024-05-21 Thread via GitHub
edoardocomar commented on code in PR #15910: URL: https://github.com/apache/kafka/pull/15910#discussion_r1608024060 ## connect/mirror/src/main/java/org/apache/kafka/connect/mirror/CheckpointsStore.java: ## @@ -0,0 +1,199 @@ +/* + * Licensed to the Apache Software Foundation (ASF

Re: [PR] KAFKA-15974: Enforce that event processing respects user-provided timeout [kafka]

2024-05-21 Thread via GitHub
cadonna commented on code in PR #15640: URL: https://github.com/apache/kafka/pull/15640#discussion_r1608024280 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumerTest.java: ## @@ -1835,7 +1849,31 @@ public void testPollThrowsInterruptExceptio

Re: [PR] KAFKA-16709: abortAndPauseCleaning only when future log is not existed [kafka]

2024-05-21 Thread via GitHub
showuon commented on code in PR #15951: URL: https://github.com/apache/kafka/pull/15951#discussion_r1608048789 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -2114,19 +2114,16 @@ class ReplicaManager(val config: KafkaConfig, partition.log.foreach { _ =>

Re: [PR] KAFKA-7632: Support Compression Levels (KIP-390) [kafka]

2024-05-21 Thread via GitHub
mimaison commented on PR #15516: URL: https://github.com/apache/kafka/pull/15516#issuecomment-2122361920 Thanks for the reviews! I had to rebase again so I'll wait for the CI to complete. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[jira] [Commented] (KAFKA-15258) Consider moving MockAdminClient to the public API

2024-05-21 Thread Muralidhar Basani (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17848158#comment-17848158 ] Muralidhar Basani commented on KAFKA-15258: --- [~mimaison]  I wanted to get you

Re: [PR] KAFKA-16709: abortAndPauseCleaning only when future log is not existed [kafka]

2024-05-21 Thread via GitHub
soarez commented on PR #15951: URL: https://github.com/apache/kafka/pull/15951#issuecomment-2122392557 Sorry, I clicked the wrong window, did not mean to approve, I'm still reviewing this -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[jira] [Commented] (KAFKA-16802) Move build.gradle java version information inside of a java block

2024-05-21 Thread Muralidhar Basani (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17848168#comment-17848168 ] Muralidhar Basani commented on KAFKA-16802: --- [~gharris1727] I can pick this up

Re: [PR] KAFKA-16709: abortAndPauseCleaning only when future log is not existed [kafka]

2024-05-21 Thread via GitHub
soarez commented on code in PR #15951: URL: https://github.com/apache/kafka/pull/15951#discussion_r1608164096 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -2114,19 +2114,16 @@ class ReplicaManager(val config: KafkaConfig, partition.log.foreach { _ =>

[jira] [Updated] (KAFKA-16798) Mirrormaker2 dedicated mode - sync.group.offsets.interval not working

2024-05-21 Thread Thanos Athanasopoulos (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16798?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thanos Athanasopoulos updated KAFKA-16798: -- Description: Single instance MirrorMaker2 in dedicated mode, active passive re

[jira] [Created] (KAFKA-16807) DescribeLogDirsResponseData#results#topics have unexpected topics having empty partitions

2024-05-21 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-16807: -- Summary: DescribeLogDirsResponseData#results#topics have unexpected topics having empty partitions Key: KAFKA-16807 URL: https://issues.apache.org/jira/browse/KAFKA-16807

Re: [PR] Update RemoteLogManager configuration in broker server - KAFKA-16790 [kafka]

2024-05-21 Thread via GitHub
clolov commented on PR #16005: URL: https://github.com/apache/kafka/pull/16005#issuecomment-2122438149 This approach makes sense to me. How easy would it be to code up the test which I did manually in the JIRA ticket? In other words, without this change I would expect the test to fail with

[jira] [Created] (KAFKA-16808) Consumer join Group requests response contains 2 different members

2024-05-21 Thread Badhusha Muhammed (Jira)
Badhusha Muhammed created KAFKA-16808: - Summary: Consumer join Group requests response contains 2 different members Key: KAFKA-16808 URL: https://issues.apache.org/jira/browse/KAFKA-16808 Project:

[jira] [Updated] (KAFKA-16808) Consumer join Group requests response contains 2 different members

2024-05-21 Thread Badhusha Muhammed (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16808?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Badhusha Muhammed updated KAFKA-16808: -- Description: Even though there is only one consumer running for a group.id, On group

[jira] [Updated] (KAFKA-16808) Consumer join Group response contains 2 different members

2024-05-21 Thread Badhusha Muhammed (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16808?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Badhusha Muhammed updated KAFKA-16808: -- Summary: Consumer join Group response contains 2 different members (was: Consumer joi

[jira] [Assigned] (KAFKA-16802) Move build.gradle java version information inside of a java block

2024-05-21 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai reassigned KAFKA-16802: -- Assignee: Muralidhar Basani > Move build.gradle java version information inside of a

[jira] [Updated] (KAFKA-16808) Consumer join Group response contains 2 different members

2024-05-21 Thread Badhusha Muhammed (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16808?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Badhusha Muhammed updated KAFKA-16808: -- Description: Even though there is only one consumer running for a group.id, On group

[jira] [Updated] (KAFKA-16808) Consumer join Group response contains 2 different members

2024-05-21 Thread Badhusha Muhammed (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16808?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Badhusha Muhammed updated KAFKA-16808: -- Description: Even though there is only one consumer running for a group.id, On group

Re: [PR] KAFKA-16308 [1/N]: Create FeatureVersion interface and add `--feature` flag and handling to StorageTool [kafka]

2024-05-21 Thread via GitHub
dajac commented on code in PR #15685: URL: https://github.com/apache/kafka/pull/15685#discussion_r1608208322 ## server-common/src/main/java/org/apache/kafka/server/common/FeatureVersion.java: ## @@ -0,0 +1,56 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[jira] [Commented] (KAFKA-15898) Flaky test: testFenceMultipleBrokers() – org.apache.kafka.controller.QuorumControllerTest

2024-05-21 Thread TaiJuWu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17848188#comment-17848188 ] TaiJuWu commented on KAFKA-15898: - Maybe there is a reason making this test fail. Can so

Re: [PR] KAFKA-7632: Support Compression Levels (KIP-390) [kafka]

2024-05-21 Thread via GitHub
mimaison commented on code in PR #15516: URL: https://github.com/apache/kafka/pull/15516#discussion_r1608274764 ## storage/src/main/java/org/apache/kafka/storage/internals/log/LogValidator.java: ## @@ -331,12 +332,12 @@ public ValidationResult assignOffsetsNonCompressed(LongRef

Re: [PR] KAFKA-15974: Enforce that event processing respects user-provided timeout [kafka]

2024-05-21 Thread via GitHub
cadonna commented on PR #15640: URL: https://github.com/apache/kafka/pull/15640#issuecomment-2122575967 > Hey @cadonna, the tricky bit is that, for some events, the request managers do expire requests too, so in this flow you described: > > > The event is processed in the ApplicationE

[PR] KAFKA-16804: Replace archivesBaseName with archivesName. [kafka]

2024-05-21 Thread via GitHub
frankvicky opened a new pull request, #16016: URL: https://github.com/apache/kafka/pull/16016 Due to deprecation of archivesBaseName, we need to replace it by archivesName. - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify docume

Re: [PR] MINOR: migrate ReassignPartitionsIntegrationTest to use ClusterTestExtensions [kafka]

2024-05-21 Thread via GitHub
FrankYang0529 commented on PR #15675: URL: https://github.com/apache/kafka/pull/15675#issuecomment-2122582976 Hi @chia7712, thanks for the review and suggestion. I addressed all comments. Thank you. -- This is an automated message from the Apache Git Service. To respond to the message, pl

Re: [PR] Update RemoteLogManager configuration in broker server - KAFKA-16790 [kafka]

2024-05-21 Thread via GitHub
muralibasani commented on PR #16005: URL: https://github.com/apache/kafka/pull/16005#issuecomment-2122602931 @clolov thanks for the tip. Would it be better to write the test in KRaftClusterTest.scala or RemoteLogManagerTest or in a different file ? As it's more of an integration test,

Re: [PR] Kafka-15444: Native docker image for Apache Kafka(KIP-974) [kafka]

2024-05-21 Thread via GitHub
kagarwal06 commented on code in PR #15927: URL: https://github.com/apache/kafka/pull/15927#discussion_r1608310290 ## docker/native/Dockerfile: ## @@ -0,0 +1,84 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NO

Re: [PR] KAFKA-16709: abortAndPauseCleaning only when future log is not existed [kafka]

2024-05-21 Thread via GitHub
chia7712 commented on code in PR #15951: URL: https://github.com/apache/kafka/pull/15951#discussion_r1608320628 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -2114,16 +2114,12 @@ class ReplicaManager(val config: KafkaConfig, partition.log.foreach { _ =

Re: [PR] KAFKA-16452: Don't throw OOORE when converting the offset to metadata [kafka]

2024-05-21 Thread via GitHub
kamalcph commented on PR #15825: URL: https://github.com/apache/kafka/pull/15825#issuecomment-2122625313 > @kamalcph , had another look, left some comments. Also, could we add an integration test for this case like you described in the PR description? `FetchFromFollowerIntegrationTest` shou

Re: [PR] KAFKA-16452: Don't throw OOORE when converting the offset to metadata [kafka]

2024-05-21 Thread via GitHub
kamalcph commented on code in PR #15825: URL: https://github.com/apache/kafka/pull/15825#discussion_r1608327384 ## core/src/main/scala/kafka/log/LocalLog.scala: ## @@ -370,11 +370,17 @@ class LocalLog(@volatile private var _dir: File, throw new OffsetOutOfRangeException

Re: [PR] KAFKA-16793: Heartbeat API for upgrading ConsumerGroup [kafka]

2024-05-21 Thread via GitHub
dajac commented on code in PR #15988: URL: https://github.com/apache/kafka/pull/15988#discussion_r1608287216 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -2180,36 +2202,58 @@ private void cancelConsumerGroupRebalanceTimeo

[jira] [Assigned] (KAFKA-16707) Kafka Kraft : adding Principal Type in StandardACL for matching with KafkaPrincipal of connected client in order to defined ACL with a notion of group

2024-05-21 Thread Franck LEDAY (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16707?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Franck LEDAY reassigned KAFKA-16707: Assignee: Franck LEDAY > Kafka Kraft : adding Principal Type in StandardACL for matching

Re: [PR] KAFKA-16705 the flag "started" of RaftClusterInstance is false even though the cluster is started [kafka]

2024-05-21 Thread via GitHub
chia7712 commented on code in PR #15946: URL: https://github.com/apache/kafka/pull/15946#discussion_r1608351377 ## core/src/test/java/kafka/test/junit/RaftClusterInvocationContext.java: ## @@ -86,67 +81,42 @@ public String getDisplayName(int invocationIndex) { @Override

Re: [PR] KAFKA-16629: Add broker-related tests to ConfigCommandIntegrationTest [kafka]

2024-05-21 Thread via GitHub
m1a2st commented on PR #15840: URL: https://github.com/apache/kafka/pull/15840#issuecomment-2122661694 @chia7712 , I have been resolve th conflict. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] Update RemoteLogManager configuration in broker server - KAFKA-16790 [kafka]

2024-05-21 Thread via GitHub
muralibasani commented on PR #16005: URL: https://github.com/apache/kafka/pull/16005#issuecomment-2122679508 And I tried testing with export INCLUDE_TEST_JARS=true, but still notice class not found err. Am I missing any ? -- This is an automated message from the Apache Git Service. To res

Re: [PR] MINOR: fix flaky testRecordThreadIdleRatio [kafka]

2024-05-21 Thread via GitHub
chia7712 commented on PR #15987: URL: https://github.com/apache/kafka/pull/15987#issuecomment-2122683021 I will merge it after QA complete -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [PR] KAFKA-14934: KafkaClusterTestKit makes FaultHandler accessible [kafka]

2024-05-21 Thread via GitHub
chia7712 commented on code in PR #16012: URL: https://github.com/apache/kafka/pull/16012#discussion_r1608386914 ## core/src/test/java/kafka/testkit/KafkaClusterTestKit.java: ## @@ -366,7 +366,13 @@ private KafkaClusterTestKit( this.baseDirectory = baseDirectory;

[PR] KAFKA-16639: AsyncKafkaConsumer#close dose not send heartbeat to leave group. [kafka]

2024-05-21 Thread via GitHub
frankvicky opened a new pull request, #16017: URL: https://github.com/apache/kafka/pull/16017 Fix the bug where the heartbeat is not sent when a newly created consumer is immediately closed. - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status -

Re: [PR] KAFKA-16625: Reverse lookup map from topic partitions to members [kafka]

2024-05-21 Thread via GitHub
jeffkbkim commented on code in PR #15974: URL: https://github.com/apache/kafka/pull/15974#discussion_r1608400727 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java: ## @@ -516,16 +522,78 @@ public Assignment targetAssignment(String

Re: [PR] MINOR: fix streams_broker_compatibility test [kafka]

2024-05-21 Thread via GitHub
lucasbru merged PR #16015: URL: https://github.com/apache/kafka/pull/16015 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-16793: Heartbeat API for upgrading ConsumerGroup [kafka]

2024-05-21 Thread via GitHub
jeffkbkim commented on code in PR #15988: URL: https://github.com/apache/kafka/pull/15988#discussion_r1608403874 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -4209,31 +4241,67 @@ private void removePendingSyncMember(

Re: [PR] KAFKA-16722: Introduce ConsumerGroupPartitionAssignor interface [kafka]

2024-05-21 Thread via GitHub
AndrewJSchofield commented on PR #15998: URL: https://github.com/apache/kafka/pull/15998#issuecomment-2122737192 @dajac I think this PR should suffice to get the ConsumerGroupPartitionAssignor interface in place for AK 3.8. -- This is an automated message from the Apache Git Service. To r

Re: [PR] KAFKA-15974: Enforce that event processing respects user-provided timeout [kafka]

2024-05-21 Thread via GitHub
lianetm commented on code in PR #15640: URL: https://github.com/apache/kafka/pull/15640#discussion_r1608418633 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumerTest.java: ## @@ -329,6 +334,17 @@ public void testCommitAsyncWithFencedException

Re: [PR] KAFKA-15974: Enforce that event processing respects user-provided timeout [kafka]

2024-05-21 Thread via GitHub
lianetm commented on code in PR #15640: URL: https://github.com/apache/kafka/pull/15640#discussion_r1608418633 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumerTest.java: ## @@ -329,6 +334,17 @@ public void testCommitAsyncWithFencedException

Re: [PR] KAFKA-15905 Restarts of MirrorCheckpointTask should not permanently i… [kafka]

2024-05-21 Thread via GitHub
edoardocomar commented on code in PR #15910: URL: https://github.com/apache/kafka/pull/15910#discussion_r1608024060 ## connect/mirror/src/main/java/org/apache/kafka/connect/mirror/CheckpointsStore.java: ## @@ -0,0 +1,199 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[jira] [Commented] (KAFKA-14517) Implement regex subscriptions

2024-05-21 Thread Phuc Hong Tran (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17848229#comment-17848229 ] Phuc Hong Tran commented on KAFKA-14517: [~lianetm] actually can you help me tak

Re: [PR] KAFKA-16654:Refactor kafka.test.annotation.Type and ClusterTestExtensions [kafka]

2024-05-21 Thread via GitHub
chia7712 merged PR #15916: URL: https://github.com/apache/kafka/pull/15916 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Resolved] (KAFKA-16654) Refactor kafka.test.annotation.Type and ClusterTestExtensions

2024-05-21 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16654?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-16654. Fix Version/s: 3.8.0 Resolution: Fixed > Refactor kafka.test.annotation.Type and Cl

Re: [PR] KAFKA-16373: KIP-1028: Adding code to support Apache Kafka Docker Official Images [kafka]

2024-05-21 Thread via GitHub
KrishVora01 closed pull request #15704: KAFKA-16373: KIP-1028: Adding code to support Apache Kafka Docker Official Images URL: https://github.com/apache/kafka/pull/15704 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] KAFKA-15974: Enforce that event processing respects user-provided timeout [kafka]

2024-05-21 Thread via GitHub
lianetm commented on code in PR #15640: URL: https://github.com/apache/kafka/pull/15640#discussion_r1608453186 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java: ## @@ -1295,21 +1268,21 @@ private void close(Duration timeout, boolean s

[PR] KAFKA-16373: KIP-1028: Adding code to support Apache Kafka Docker Official Images [kafka]

2024-05-21 Thread via GitHub
KrishVora01 opened a new pull request, #16018: URL: https://github.com/apache/kafka/pull/16018 This PR adds code to support Apache Kafka Docker Official Images. The files added include: 1. .github/workflows/prepare_docker_official_image_source.yml This adds github actions workflow t

Re: [PR] KAFKA-16784: Migrate TopicBasedRemoteLogMetadataManagerMultipleSubscriptionsTest to use ClusterTestExtensions [kafka]

2024-05-21 Thread via GitHub
chia7712 merged PR #15992: URL: https://github.com/apache/kafka/pull/15992 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-16722: Introduce ConsumerGroupPartitionAssignor interface [kafka]

2024-05-21 Thread via GitHub
dajac commented on PR #15998: URL: https://github.com/apache/kafka/pull/15998#issuecomment-2122799389 @AndrewJSchofield Thanks. I will review it this week. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Resolved] (KAFKA-16784) Migrate TopicBasedRemoteLogMetadataManagerMultipleSubscriptionsTest to new test infra

2024-05-21 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16784?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-16784. Fix Version/s: 3.8.0 Resolution: Fixed > Migrate TopicBasedRemoteLogMetadataManager

Re: [PR] KAFKA-16649: Remove lock from DynamicBrokerConfig.removeReconfigurable [kafka]

2024-05-21 Thread via GitHub
chia7712 commented on code in PR #15838: URL: https://github.com/apache/kafka/pull/15838#discussion_r1608469438 ## core/src/main/scala/kafka/server/DynamicBrokerConfig.scala: ## @@ -303,17 +303,17 @@ class DynamicBrokerConfig(private val kafkaConfig: KafkaConfig) extends Loggin

Re: [PR] KAFKA-15905 Restarts of MirrorCheckpointTask should not permanently i… [kafka]

2024-05-21 Thread via GitHub
edoardocomar commented on code in PR #15910: URL: https://github.com/apache/kafka/pull/15910#discussion_r1608471528 ## connect/mirror/src/test/java/org/apache/kafka/connect/mirror/MirrorCheckpointTaskTest.java: ## @@ -271,4 +284,102 @@ private Map assertCheckpointForTopic(

[jira] [Commented] (KAFKA-16807) DescribeLogDirsResponseData#results#topics have unexpected topics having empty partitions

2024-05-21 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-16807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17848241#comment-17848241 ] 黃竣陽 commented on KAFKA-16807: - I'm intersting in this issue,  Please assign to me, Thanks yo

Re: [PR] [WIP] KAFKA-14588 Tests for ConfigCommand of DynamicBrokerReconfigurationTest rewritten in java [kafka]

2024-05-21 Thread via GitHub
chia7712 commented on PR #15848: URL: https://github.com/apache/kafka/pull/15848#issuecomment-2122820472 Please ping me if this PR gets ready :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[jira] [Assigned] (KAFKA-16807) DescribeLogDirsResponseData#results#topics have unexpected topics having empty partitions

2024-05-21 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16807?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai reassigned KAFKA-16807: -- Assignee: 黃竣陽 (was: Chia-Ping Tsai) > DescribeLogDirsResponseData#results#topics hav

Re: [PR] [WIP] KAFKA-14588 Tests for ConfigCommand of DynamicBrokerReconfigurationTest rewritten in java [kafka]

2024-05-21 Thread via GitHub
nizhikov commented on PR #15848: URL: https://github.com/apache/kafka/pull/15848#issuecomment-2122822537 Yes. I'm working on it right now. Will be ready in a couple of hours. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] KAFKA-15974: Enforce that event processing respects user-provided timeout [kafka]

2024-05-21 Thread via GitHub
lianetm commented on code in PR #15640: URL: https://github.com/apache/kafka/pull/15640#discussion_r1608487528 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/CompletableEventReaper.java: ## @@ -0,0 +1,157 @@ +/* + * Licensed to the Apache Software Fo

Re: [PR] KAFKA-14588 Tests for ConfigCommand of DynamicBrokerReconfigurationTest rewritten in java [kafka]

2024-05-21 Thread via GitHub
nizhikov commented on PR #15848: URL: https://github.com/apache/kafka/pull/15848#issuecomment-2122859856 @chia7712 PR ready for review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

Re: [PR] KAFKA-15905 Restarts of MirrorCheckpointTask should not permanently i… [kafka]

2024-05-21 Thread via GitHub
edoardocomar commented on code in PR #15910: URL: https://github.com/apache/kafka/pull/15910#discussion_r1608507355 ## connect/mirror/src/test/java/org/apache/kafka/connect/mirror/OffsetSyncStoreTest.java: ## @@ -119,7 +118,7 @@ public void testPastOffsetTranslation() {

Re: [PR] KAFKA-15974: Enforce that event processing respects user-provided timeout [kafka]

2024-05-21 Thread via GitHub
lianetm commented on code in PR #15640: URL: https://github.com/apache/kafka/pull/15640#discussion_r1608516652 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java: ## @@ -1848,6 +1821,40 @@ private void subscribeInternal(Collection topic

Re: [PR] KAFKA-15974: Enforce that event processing respects user-provided timeout [kafka]

2024-05-21 Thread via GitHub
lianetm commented on code in PR #15640: URL: https://github.com/apache/kafka/pull/15640#discussion_r1608516652 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java: ## @@ -1848,6 +1821,40 @@ private void subscribeInternal(Collection topic

Re: [PR] KAFKA-16626: Lazily convert subscribed topic names to topic ids [kafka]

2024-05-21 Thread via GitHub
jeffkbkim commented on code in PR #15970: URL: https://github.com/apache/kafka/pull/15970#discussion_r1608522106 ## jmh-benchmarks/src/main/java/org/apache/kafka/jmh/assignor/ServerSideAssignorBenchmark.java: ## @@ -119,7 +123,13 @@ public enum AssignmentType { private Su

  1   2   3   >