jeffkbkim commented on code in PR #15970:
URL: https://github.com/apache/kafka/pull/15970#discussion_r1608522106
##########
jmh-benchmarks/src/main/java/org/apache/kafka/jmh/assignor/ServerSideAssignorBenchmark.java:
##########
@@ -119,7 +123,13 @@ public enum AssignmentType {
private SubscribedTopicDescriber subscribedTopicDescriber;
- private final List<Uuid> allTopicIds = new ArrayList<>();
+ private final List<String> allTopicNames = new ArrayList<>();
+
+ private ImmutableMap<Uuid, TopicImage> topicsById = ImmutableMap.empty();
+
+ private ImmutableMap<String, TopicImage> topicsByName =
ImmutableMap.empty();
+
+ private TopicsImage topicsImage = TopicsImage.EMPTY;
Review Comment:
I can't seem to use MetadataImageBuilder in jmh module as it is in the test
directory. Do you know whether we can go around that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
