dajac merged PR #15816:
URL: https://github.com/apache/kafka/pull/15816
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
dajac commented on code in PR #15818:
URL: https://github.com/apache/kafka/pull/15818#discussion_r1582660947
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorResult.java:
##
@@ -80,10 +86,28 @@ public CoordinatorResult(
List recor
nizhikov commented on PR #15645:
URL: https://github.com/apache/kafka/pull/15645#issuecomment-2082118117
@chia7712 Only 16 tests failing after CI rerun.
Please, take a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
showuon commented on code in PR #15732:
URL: https://github.com/apache/kafka/pull/15732#discussion_r1582700986
##
metadata/src/main/java/org/apache/kafka/metadata/migration/KRaftMigrationDriver.java:
##
@@ -786,12 +773,31 @@ public void run() throws Exception {
}
}
showuon commented on PR #15732:
URL: https://github.com/apache/kafka/pull/15732#issuecomment-2082153705
@akhileshchg , thanks for the review. We still have a question to you:
> However, I'm still not sure why https://github.com/apache/kafka/pull/12998
did not use event to recover migr
showuon merged PR #15804:
URL: https://github.com/apache/kafka/pull/15804
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
showuon commented on PR #15732:
URL: https://github.com/apache/kafka/pull/15732#issuecomment-2082204486
@soarez @chia7712 , since the original author @akhileshchg had reviewed and
approved, do you have any other comments?
--
This is an automated message from the Apache Git Service.
To re
dajac commented on code in PR #15785:
URL: https://github.com/apache/kafka/pull/15785#discussion_r1582678791
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -1307,13 +1307,14 @@ private
CoordinatorResult consumerGr
showuon merged PR #15732:
URL: https://github.com/apache/kafka/pull/15732
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
showuon commented on PR #15732:
URL: https://github.com/apache/kafka/pull/15732#issuecomment-2082297410
Thanks all for the review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
soarez commented on code in PR #15690:
URL: https://github.com/apache/kafka/pull/15690#discussion_r1582791175
##
core/src/main/java/kafka/server/TierStateMachine.java:
##
@@ -54,5 +180,109 @@ PartitionFetchState start(TopicPartition topicPartition,
* @return the new Partit
[
https://issues.apache.org/jira/browse/KAFKA-16563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luke Chen resolved KAFKA-16563.
---
Fix Version/s: 3.8.0
3.7.1
Resolution: Fixed
> migration to KRaft hanging
FrankYang0529 commented on code in PR #15745:
URL: https://github.com/apache/kafka/pull/15745#discussion_r1582795316
##
core/src/test/java/kafka/test/ClusterConfig.java:
##
@@ -160,6 +166,7 @@ public boolean equals(Object object) {
return Objects.equals(type, clusterCon
FrankYang0529 commented on code in PR #15745:
URL: https://github.com/apache/kafka/pull/15745#discussion_r1582797729
##
core/src/test/java/kafka/test/junit/ClusterTestExtensions.java:
##
@@ -162,32 +162,39 @@ private void processClusterTest(ExtensionContext context,
ClusterTest
FrankYang0529 commented on code in PR #15745:
URL: https://github.com/apache/kafka/pull/15745#discussion_r1582798251
##
core/src/test/java/kafka/test/ClusterConfig.java:
##
@@ -55,14 +56,15 @@ public class ClusterConfig {
private final Map>
perBrokerOverrideProperties;
FrankYang0529 commented on code in PR #15745:
URL: https://github.com/apache/kafka/pull/15745#discussion_r1582798499
##
core/src/test/java/kafka/test/ClusterTestExtensionsTest.java:
##
@@ -121,6 +124,26 @@ public void testClusterTests() {
}
}
+@ClusterTests({
lucasbru merged PR #15778:
URL: https://github.com/apache/kafka/pull/15778
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
[
https://issues.apache.org/jira/browse/KAFKA-16622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17841927#comment-17841927
]
Edoardo Comar commented on KAFKA-16622:
---
related issue https://issues.apache.org/j
m1a2st commented on code in PR #15808:
URL: https://github.com/apache/kafka/pull/15808#discussion_r1582841761
##
core/src/test/scala/unit/kafka/utils/TestUtils.scala:
##
@@ -1124,24 +933,18 @@ object TestUtils extends Logging {
}, msg = msg, pause = 0L, waitTimeMs = waitTim
m1a2st commented on code in PR #15808:
URL: https://github.com/apache/kafka/pull/15808#discussion_r1582842857
##
core/src/test/scala/unit/kafka/utils/TestUtils.scala:
##
@@ -1124,24 +933,18 @@ object TestUtils extends Logging {
}, msg = msg, pause = 0L, waitTimeMs = waitTim
FrankYang0529 commented on PR #15664:
URL: https://github.com/apache/kafka/pull/15664#issuecomment-2082466695
Hi @showuon, I update README to point to kafka-site. Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
FrankYang0529 commented on PR #15773:
URL: https://github.com/apache/kafka/pull/15773#issuecomment-2082506746
> @FrankYang0529 thanks for updated PR. BTW, could you please enhance the
docs of `log.segment.delete.delay.ms`? It seems the function of
`log.segment.delete.delay.ms` includes the
m1a2st commented on code in PR #15808:
URL: https://github.com/apache/kafka/pull/15808#discussion_r1582841761
##
core/src/test/scala/unit/kafka/utils/TestUtils.scala:
##
@@ -1124,24 +933,18 @@ object TestUtils extends Logging {
}, msg = msg, pause = 0L, waitTimeMs = waitTim
[
https://issues.apache.org/jira/browse/KAFKA-16506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17841978#comment-17841978
]
PoAn Yang commented on KAFKA-16506:
---
Hi [~chia7712], I compare command under core/src/
[
https://issues.apache.org/jira/browse/KAFKA-16514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17841986#comment-17841986
]
Lianet Magrans commented on KAFKA-16514:
If my understanding here is right, this
[
https://issues.apache.org/jira/browse/KAFKA-16459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lianet Magrans closed KAFKA-16459.
--
> New consumer times out joining group in consumer_test.py system test
> -
[
https://issues.apache.org/jira/browse/KAFKA-16465?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lianet Magrans closed KAFKA-16465.
--
> New consumer does not invoke rebalance callbacks as expected in
> consumer_test.py system test
dongnuo123 commented on code in PR #15818:
URL: https://github.com/apache/kafka/pull/15818#discussion_r1583125181
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorResult.java:
##
@@ -80,10 +86,28 @@ public CoordinatorResult(
List
dongnuo123 commented on code in PR #15818:
URL: https://github.com/apache/kafka/pull/15818#discussion_r1583125181
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorResult.java:
##
@@ -80,10 +86,28 @@ public CoordinatorResult(
List
[
https://issues.apache.org/jira/browse/KAFKA-16619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17841997#comment-17841997
]
David Arthur commented on KAFKA-16619:
--
Thanks for the report, [~fmethot]. I agree
[
https://issues.apache.org/jira/browse/KAFKA-15897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17841998#comment-17841998
]
Johnny Hsu commented on KAFKA-15897:
previously I thought that the poll should be fi
dajac commented on code in PR #15818:
URL: https://github.com/apache/kafka/pull/15818#discussion_r1583152183
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -3772,7 +3773,8 @@ public CoordinatorResult
classicGroupLeave(
dajac commented on code in PR #15818:
URL: https://github.com/apache/kafka/pull/15818#discussion_r1583152680
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -3497,7 +3498,7 @@ public CoordinatorResult classicGroupSync(
dajac commented on code in PR #15818:
URL: https://github.com/apache/kafka/pull/15818#discussion_r1583153766
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -2300,7 +2301,7 @@ public CoordinatorResult classicGroupJoin(
dajac commented on code in PR #15818:
URL: https://github.com/apache/kafka/pull/15818#discussion_r1583153282
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -3381,7 +3382,7 @@ private CoordinatorResult
updateStaticMemberThe
dajac commented on code in PR #15818:
URL: https://github.com/apache/kafka/pull/15818#discussion_r1583153537
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -2718,7 +2719,7 @@ private CoordinatorResult
completeClassicGroupJ
dajac commented on code in PR #15818:
URL: https://github.com/apache/kafka/pull/15818#discussion_r1583163477
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -1524,7 +1524,8 @@ private
CoordinatorResult consumerGr
chiacyu commented on code in PR #15823:
URL: https://github.com/apache/kafka/pull/15823#discussion_r1583157619
##
clients/src/main/java/org/apache/kafka/common/utils/Utils.java:
##
@@ -584,27 +584,6 @@ public static String formatBytes(long bytes) {
}
}
-/**
-
johnnychhsu opened a new pull request, #15828:
URL: https://github.com/apache/kafka/pull/15828
## Context
ControllerRegistrationManagerTest is flaky due to the poll in L221. The
potential root cause is a race condition between the first poll (L221) and the
second poll (L229). Before the
johnnychhsu commented on code in PR #15788:
URL: https://github.com/apache/kafka/pull/15788#discussion_r1583203145
##
core/src/main/scala/kafka/MetadataLogConfig.scala:
##
@@ -32,13 +32,13 @@ final case class MetadataLogConfig(
)
object MetadataLogConfig {
- def apply(confi
johnnychhsu commented on PR #15788:
URL: https://github.com/apache/kafka/pull/15788#issuecomment-2082935001
@chia7712
just updated, thanks for the review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
[
https://issues.apache.org/jira/browse/KAFKA-16553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17842011#comment-17842011
]
Johnny Hsu commented on KAFKA-16553:
hey [~chia7712] , I would like to address this
[
https://issues.apache.org/jira/browse/KAFKA-16514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17842014#comment-17842014
]
Sal Sorrentino commented on KAFKA-16514:
Less tacky is better. Looking at other
[
https://issues.apache.org/jira/browse/KAFKA-16514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17842014#comment-17842014
]
Sal Sorrentino edited comment on KAFKA-16514 at 4/29/24 2:49 PM:
-
[
https://issues.apache.org/jira/browse/KAFKA-16604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17842016#comment-17842016
]
Chris Egerton commented on KAFKA-16604:
---
I don't know if it's worth the breaking c
[
https://issues.apache.org/jira/browse/KAFKA-16514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17842014#comment-17842014
]
Sal Sorrentino edited comment on KAFKA-16514 at 4/29/24 2:55 PM:
-
dongnuo123 commented on code in PR #15818:
URL: https://github.com/apache/kafka/pull/15818#discussion_r1583231794
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorResult.java:
##
@@ -44,8 +44,8 @@ public class CoordinatorResult {
priv
[
https://issues.apache.org/jira/browse/KAFKA-16639?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-16639:
--
Component/s: clients
consumer
> AsyncKafkaConsumer#close does not send heartbeat to l
dajac commented on code in PR #15818:
URL: https://github.com/apache/kafka/pull/15818#discussion_r1583236338
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorResult.java:
##
@@ -44,8 +44,8 @@ public class CoordinatorResult {
private f
[
https://issues.apache.org/jira/browse/KAFKA-16603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17842020#comment-17842020
]
Chris Egerton commented on KAFKA-16603:
---
[~dasarianil] That's correct; {{Producer:
C0urante commented on code in PR #15379:
URL: https://github.com/apache/kafka/pull/15379#discussion_r1583247131
##
connect/transforms/src/test/java/org/apache/kafka/connect/transforms/field/FieldPathNotationTest.java:
##
@@ -0,0 +1,149 @@
+/*
+ * Licensed to the Apache Software
[
https://issues.apache.org/jira/browse/KAFKA-16460?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True resolved KAFKA-16460.
---
Resolution: Duplicate
> New consumer times out consuming records in consumer_test.py system test
> -
[
https://issues.apache.org/jira/browse/KAFKA-16603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17842023#comment-17842023
]
Anil Dasari commented on KAFKA-16603:
-
Thanks [~ChrisEgerton] . will look into exact
[
https://issues.apache.org/jira/browse/KAFKA-16603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17842023#comment-17842023
]
Anil Dasari edited comment on KAFKA-16603 at 4/29/24 3:10 PM:
mumrah commented on code in PR #15744:
URL: https://github.com/apache/kafka/pull/15744#discussion_r1583263129
##
core/src/test/scala/integration/kafka/zk/ZkMigrationIntegrationTest.scala:
##
@@ -950,16 +980,47 @@ class ZkMigrationIntegrationTest {
dataOpt.map(ProducerIdBloc
[
https://issues.apache.org/jira/browse/KAFKA-16604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17842031#comment-17842031
]
Chia-Ping Tsai commented on KAFKA-16604:
{quote}
If we want to prevent bugs like
[
https://issues.apache.org/jira/browse/KAFKA-16553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17842032#comment-17842032
]
Chia-Ping Tsai commented on KAFKA-16553:
{quote}
so that we can get this contro
[
https://issues.apache.org/jira/browse/KAFKA-16553?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai reassigned KAFKA-16553:
--
Assignee: Johnny Hsu (was: Chia-Ping Tsai)
> log controller configs when startup
> -
[
https://issues.apache.org/jira/browse/KAFKA-16506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17842039#comment-17842039
]
Chia-Ping Tsai commented on KAFKA-16506:
{quote}
I compare command under core/sr
dongnuo123 commented on code in PR #15818:
URL: https://github.com/apache/kafka/pull/15818#discussion_r1583293395
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -1524,7 +1524,8 @@ private
CoordinatorResult consumerGr
rreddy-22 commented on code in PR #15785:
URL: https://github.com/apache/kafka/pull/15785#discussion_r1583294148
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -1307,13 +1307,14 @@ private
CoordinatorResult consumerGr
dongnuo123 commented on code in PR #15818:
URL: https://github.com/apache/kafka/pull/15818#discussion_r1583297740
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorResult.java:
##
@@ -44,8 +44,8 @@ public class CoordinatorResult {
priv
rreddy-22 commented on code in PR #15785:
URL: https://github.com/apache/kafka/pull/15785#discussion_r1583294148
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -1307,13 +1307,14 @@ private
CoordinatorResult consumerGr
rreddy-22 commented on code in PR #15785:
URL: https://github.com/apache/kafka/pull/15785#discussion_r1583305142
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -1350,6 +1351,11 @@ private
CoordinatorResult consumerGr
rreddy-22 commented on code in PR #15785:
URL: https://github.com/apache/kafka/pull/15785#discussion_r1583305142
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -1350,6 +1351,11 @@ private
CoordinatorResult consumerGr
rreddy-22 commented on code in PR #15785:
URL: https://github.com/apache/kafka/pull/15785#discussion_r1583314465
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -1307,13 +1307,14 @@ private
CoordinatorResult consumerGr
[
https://issues.apache.org/jira/browse/KAFKA-16217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17842049#comment-17842049
]
Calvin Liu commented on KAFKA-16217:
Resolve the ticket for now. If we want to merge
[
https://issues.apache.org/jira/browse/KAFKA-16217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Calvin Liu resolved KAFKA-16217.
Fix Version/s: (was: 3.6.3)
Resolution: Fixed
> Transactional producer stuck in Illegal
chia7712 commented on code in PR #15823:
URL: https://github.com/apache/kafka/pull/15823#discussion_r1583327471
##
clients/src/main/java/org/apache/kafka/common/utils/Utils.java:
##
@@ -584,27 +584,6 @@ public static String formatBytes(long bytes) {
}
}
-/**
C0urante commented on code in PR #15379:
URL: https://github.com/apache/kafka/pull/15379#discussion_r1583252760
##
connect/transforms/src/main/java/org/apache/kafka/connect/transforms/field/SingleFieldPath.java:
##
@@ -0,0 +1,240 @@
+/*
+ * Licensed to the Apache Software Founda
m1a2st commented on PR #15779:
URL: https://github.com/apache/kafka/pull/15779#issuecomment-2083099739
Rely on #15766
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
rreddy-22 commented on code in PR #15785:
URL: https://github.com/apache/kafka/pull/15785#discussion_r1583332135
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -1350,6 +1351,11 @@ private
CoordinatorResult consumerGr
rreddy-22 commented on code in PR #15785:
URL: https://github.com/apache/kafka/pull/15785#discussion_r158025
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -1350,6 +1351,11 @@ private
CoordinatorResult consumerGr
rreddy-22 commented on code in PR #15785:
URL: https://github.com/apache/kafka/pull/15785#discussion_r1583294148
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -1307,13 +1307,14 @@ private
CoordinatorResult consumerGr
rreddy-22 commented on code in PR #15785:
URL: https://github.com/apache/kafka/pull/15785#discussion_r1583294148
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -1307,13 +1307,14 @@ private
CoordinatorResult consumerGr
rreddy-22 commented on code in PR #15785:
URL: https://github.com/apache/kafka/pull/15785#discussion_r1583294148
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -1307,13 +1307,14 @@ private
CoordinatorResult consumerGr
C0urante commented on code in PR #13801:
URL: https://github.com/apache/kafka/pull/13801#discussion_r1583356709
##
connect/runtime/src/test/java/org/apache/kafka/connect/storage/ConnectorOffsetBackingStoreTest.java:
##
@@ -0,0 +1,410 @@
+/*
+ * Licensed to the Apache Software Fo
[
https://issues.apache.org/jira/browse/KAFKA-16639?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Philip Nee reassigned KAFKA-16639:
--
Assignee: Philip Nee (was: Chia-Ping Tsai)
> AsyncKafkaConsumer#close does not send heartbea
[
https://issues.apache.org/jira/browse/KAFKA-16639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17842099#comment-17842099
]
Chia-Ping Tsai commented on KAFKA-16639:
check the code again. It seems there ar
CalvinConfluent commented on code in PR #15702:
URL: https://github.com/apache/kafka/pull/15702#discussion_r1583422586
##
metadata/src/main/java/org/apache/kafka/controller/BrokersToElrs.java:
##
@@ -159,4 +160,14 @@ BrokersToIsrs.PartitionsOnReplicaIterator
partitionsWithBroke
CalvinConfluent commented on code in PR #15702:
URL: https://github.com/apache/kafka/pull/15702#discussion_r1583423622
##
metadata/src/main/java/org/apache/kafka/controller/ConfigurationControlManager.java:
##
@@ -260,6 +279,7 @@ private ApiError incrementalAlterConfigResource(
CalvinConfluent commented on code in PR #15702:
URL: https://github.com/apache/kafka/pull/15702#discussion_r1583424779
##
metadata/src/main/java/org/apache/kafka/controller/ConfigurationControlManager.java:
##
@@ -308,6 +328,48 @@ private ApiError validateAlterConfig(ConfigResou
[
https://issues.apache.org/jira/browse/KAFKA-16640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17842104#comment-17842104
]
Greg Harris commented on KAFKA-16640:
-
Hi [~chia7712] does this depend on
https://i
chia7712 commented on code in PR #15773:
URL: https://github.com/apache/kafka/pull/15773#discussion_r1583431374
##
server-common/src/main/java/org/apache/kafka/server/config/ServerLogConfigs.java:
##
@@ -86,7 +86,7 @@ public class ServerLogConfigs {
public static final St
[
https://issues.apache.org/jira/browse/KAFKA-16640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17842107#comment-17842107
]
Chia-Ping Tsai commented on KAFKA-16640:
{quote}
does this depend on https://iss
[
https://issues.apache.org/jira/browse/KAFKA-16640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17842110#comment-17842110
]
Greg Harris commented on KAFKA-16640:
-
Okay, I understand now. SGTM!
> Replace Test
dajac commented on code in PR #15818:
URL: https://github.com/apache/kafka/pull/15818#discussion_r1583441095
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -1499,33 +1499,28 @@ private
CoordinatorResult consumerGr
) t
dajac commented on code in PR #15818:
URL: https://github.com/apache/kafka/pull/15818#discussion_r1583442656
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -1560,13 +1561,15 @@ private List
consumerGroupStaticMemberGroupLe
chia7712 merged PR #15822:
URL: https://github.com/apache/kafka/pull/15822
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
CalvinConfluent commented on code in PR #15702:
URL: https://github.com/apache/kafka/pull/15702#discussion_r1583446833
##
metadata/src/main/java/org/apache/kafka/controller/ConfigurationControlManager.java:
##
@@ -308,6 +328,48 @@ private ApiError validateAlterConfig(ConfigResou
kirktrue commented on code in PR #15723:
URL: https://github.com/apache/kafka/pull/15723#discussion_r1583450102
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/RequestState.java:
##
@@ -98,12 +93,11 @@ public boolean canSendRequest(final long currentTimeMs)
rreddy-22 commented on code in PR #15785:
URL: https://github.com/apache/kafka/pull/15785#discussion_r1583450532
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java:
##
@@ -966,6 +982,61 @@ private static void maybeUpdateSubscribedTo
[
https://issues.apache.org/jira/browse/KAFKA-16576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True reassigned KAFKA-16576:
-
Assignee: (was: Kirk True)
> New consumer fails with assert in consumer_test.py’s test_cons
kirktrue commented on code in PR #15640:
URL: https://github.com/apache/kafka/pull/15640#discussion_r1583452722
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##
@@ -946,8 +907,7 @@ public Map
committed(final Set>
listTopics(Durat
chia7712 commented on code in PR #15745:
URL: https://github.com/apache/kafka/pull/15745#discussion_r1583452740
##
core/src/test/java/kafka/test/junit/ClusterTestExtensions.java:
##
@@ -162,32 +162,39 @@ private void processClusterTest(ExtensionContext context,
ClusterTest anno
kirktrue commented on code in PR #15640:
URL: https://github.com/apache/kafka/pull/15640#discussion_r1583451774
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/CompletableBackgroundEvent.java:
##
@@ -27,19 +30,34 @@
public abstract class CompletableB
kirktrue commented on code in PR #15640:
URL: https://github.com/apache/kafka/pull/15640#discussion_r1583452334
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##
@@ -1169,8 +1129,7 @@ private Map
beginningOrEndOffset(Collection
of
[
https://issues.apache.org/jira/browse/KAFKA-16576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-16576:
--
Priority: Minor (was: Blocker)
> New consumer fails with assert in consumer_test.py’s test_consumer_f
chia7712 commented on code in PR #15766:
URL: https://github.com/apache/kafka/pull/15766#discussion_r1583466928
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/ConsumerGroupExecutor.java:
##
@@ -0,0 +1,190 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
Greg Harris created KAFKA-16641:
---
Summary: MM2 offset translation should interpolate between sparse
OffsetSyncs
Key: KAFKA-16641
URL: https://issues.apache.org/jira/browse/KAFKA-16641
Project: Kafka
1 - 100 of 174 matches
Mail list logo
