FrankYang0529 commented on code in PR #15745:
URL: https://github.com/apache/kafka/pull/15745#discussion_r1582797729
##########
core/src/test/java/kafka/test/junit/ClusterTestExtensions.java:
##########
@@ -162,32 +162,39 @@ private void processClusterTest(ExtensionContext context,
ClusterTest annot, Clu
controllers = annot.controllers();
}
- if (brokers <= 0 || controllers <= 0) {
- throw new IllegalArgumentException("Number of brokers/controllers
must be greater than zero.");
+ final int disksPerBroker;
+ if (annot.disksPerBroker() == 0) {
+ disksPerBroker = defaults.disksPerBroker();
Review Comment:
Yeah, I remove `brokers`, `controllers`, and `disksPerBroker`, but keeping
`type`. We can't get attribute from `ClusterConfig#Builder` and we need `type`
to run `invocationContexts`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
