Re: [PR] KAFKA-16452: Bound high-watermark offset to range between LLSO and LEO [kafka]

2024-04-13 Thread via GitHub
kamalcph commented on code in PR #15634: URL: https://github.com/apache/kafka/pull/15634#discussion_r1563885907 ## core/src/main/scala/kafka/log/UnifiedLog.scala: ## @@ -282,15 +282,15 @@ class UnifiedLog(@volatile var logStartOffset: Long, /** * Update high watermark w

Re: [PR] KAFKA-16452: Bound high-watermark offset to range between LLSO and LEO [kafka]

2024-04-13 Thread via GitHub
kamalcph commented on code in PR #15634: URL: https://github.com/apache/kafka/pull/15634#discussion_r1563885907 ## core/src/main/scala/kafka/log/UnifiedLog.scala: ## @@ -282,15 +282,15 @@ class UnifiedLog(@volatile var logStartOffset: Long, /** * Update high watermark w

Re: [PR] KAFKA-16452: Bound high-watermark offset to range between LLSO and LEO [kafka]

2024-04-13 Thread via GitHub
kamalcph commented on code in PR #15634: URL: https://github.com/apache/kafka/pull/15634#discussion_r1563885907 ## core/src/main/scala/kafka/log/UnifiedLog.scala: ## @@ -282,15 +282,15 @@ class UnifiedLog(@volatile var logStartOffset: Long, /** * Update high watermark w

[jira] [Commented] (KAFKA-16544) DescribeTopicsResult#allTopicIds and DescribeTopicsResult#allTopicNames should return null instead of throwing NPE

2024-04-13 Thread Kuan Po Tseng (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17836797#comment-17836797 ] Kuan Po Tseng commented on KAFKA-16544: --- gentle ping [~chia7712], are you working

Re: [PR] KAFKA-16362: Fix type-unsafety in KStreamKStreamJoin caused by isLeftSide [kafka]

2024-04-13 Thread via GitHub
raminqaf commented on code in PR #15601: URL: https://github.com/apache/kafka/pull/15601#discussion_r1563929782 ## streams/src/main/java/org/apache/kafka/streams/state/internals/LeftOrRightValue.java: ## @@ -63,21 +63,6 @@ public static LeftOrRightValue makeRightValue(final V2

Re: [PR] KAFKA-16362: Fix type-unsafety in KStreamKStreamJoin caused by isLeftSide [kafka]

2024-04-13 Thread via GitHub
raminqaf commented on code in PR #15601: URL: https://github.com/apache/kafka/pull/15601#discussion_r1563938474 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamJoin.java: ## Review Comment: No more un safe type casting to be found in this c

Re: [PR] KAFKA-15729: Add KRaft support in GetOffsetShellTest [kafka]

2024-04-13 Thread via GitHub
Owen-CH-Leung commented on PR #15489: URL: https://github.com/apache/kafka/pull/15489#issuecomment-2053607875 > @Owen-CH-Leung > > The root cause is that not all produce records succeed to be sent, and we don't check all sends before closing producer. As our CI is very busy, it could

[jira] [Assigned] (KAFKA-16544) DescribeTopicsResult#allTopicIds and DescribeTopicsResult#allTopicNames should return null instead of throwing NPE

2024-04-13 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16544?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai reassigned KAFKA-16544: -- Assignee: Kuan Po Tseng (was: Chia-Ping Tsai) > DescribeTopicsResult#allTopicIds and

Re: [PR] Fix incorrect Java equals comparison of Uuid by reference [kafka]

2024-04-13 Thread via GitHub
chia7712 merged PR #15707: URL: https://github.com/apache/kafka/pull/15707 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Commented] (KAFKA-16545) Auto adjust the replica factor according to number of broker when using ClusterTestExtensions

2024-04-13 Thread PoAn Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17836822#comment-17836822 ] PoAn Yang commented on KAFKA-16545: --- Hi [~chia7712], I'm interested in this issue. May

[jira] [Assigned] (KAFKA-16545) Auto adjust the replica factor according to number of broker when using ClusterTestExtensions

2024-04-13 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16545?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai reassigned KAFKA-16545: -- Assignee: PoAn Yang (was: Chia-Ping Tsai) > Auto adjust the replica factor according

[PR] MINOR: Add test for PartitionMetadataFile [kafka]

2024-04-13 Thread via GitHub
KevinZTW opened a new pull request, #15714: URL: https://github.com/apache/kafka/pull/15714 In PartitionMetadataFile.java, there is a defensive early-fail design when setting a different topicId, but there are no corresponding test cases. Hence, this PR adds two tests for setting the same a

Re: [PR] MINOR: Add test for PartitionMetadataFile [kafka]

2024-04-13 Thread via GitHub
chia7712 commented on code in PR #15714: URL: https://github.com/apache/kafka/pull/15714#discussion_r1564094159 ## storage/src/test/java/org/apache/kafka/storage/internals/checkpoint/PartitionMetadataFileTest.java: ## @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache Software Foun

Re: [PR] KAFKA-15729: Add KRaft support in GetOffsetShellTest [kafka]

2024-04-13 Thread via GitHub
chia7712 commented on code in PR #15489: URL: https://github.com/apache/kafka/pull/15489#discussion_r1564099443 ## tools/src/test/java/org/apache/kafka/tools/GetOffsetShellTest.java: ## @@ -48,7 +53,7 @@ import static org.junit.jupiter.api.Assertions.assertTrue; @ExtendWith(

Re: [PR] Kafka-16540: Update partitions if min isr config is changed. [kafka]

2024-04-13 Thread via GitHub
CalvinConfluent commented on code in PR #15702: URL: https://github.com/apache/kafka/pull/15702#discussion_r1564110479 ## metadata/src/main/java/org/apache/kafka/controller/ConfigurationControlManager.java: ## @@ -423,6 +441,17 @@ public void replay(ConfigRecord record) {

Re: [PR] KAFKA-16073: Increment the local-log-start-offset before deleting segments in memory table [kafka]

2024-04-13 Thread via GitHub
kamalcph commented on PR #15631: URL: https://github.com/apache/kafka/pull/15631#issuecomment-2053698624 Re-triggered the tests. Tests failures are unrelated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[jira] [Assigned] (KAFKA-14915) Option to consume multiple partitions that have their data in remote storage for the target offsets.

2024-04-13 Thread Kamal Chandraprakash (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14915?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kamal Chandraprakash reassigned KAFKA-14915: Assignee: (was: Kamal Chandraprakash) > Option to consume multiple pa

[jira] [Assigned] (KAFKA-16511) Leaking tiered segments

2024-04-13 Thread Kamal Chandraprakash (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16511?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kamal Chandraprakash reassigned KAFKA-16511: Assignee: Kamal Chandraprakash > Leaking tiered segments > --

[jira] [Assigned] (KAFKA-13560) Load indexes and data in async manner in the critical path of replica fetcher threads.

2024-04-13 Thread Kamal Chandraprakash (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13560?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kamal Chandraprakash reassigned KAFKA-13560: Assignee: (was: Kamal Chandraprakash) > Load indexes and data in asyn

[jira] [Assigned] (KAFKA-9578) Kafka Tiered Storage - System Tests

2024-04-13 Thread Kamal Chandraprakash (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9578?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kamal Chandraprakash reassigned KAFKA-9578: --- Assignee: (was: Kamal Chandraprakash) > Kafka Tiered Storage - System T

[jira] [Assigned] (KAFKA-15682) Ensure internal remote log metadata topic does not expire its segments before deleting user-topic segments

2024-04-13 Thread Kamal Chandraprakash (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15682?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kamal Chandraprakash reassigned KAFKA-15682: Assignee: (was: Kamal Chandraprakash) > Ensure internal remote log me

[jira] [Assigned] (KAFKA-15682) Ensure internal remote log metadata topic does not expire its segments before deleting user-topic segments

2024-04-13 Thread Kamal Chandraprakash (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15682?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kamal Chandraprakash reassigned KAFKA-15682: Assignee: Kamal Chandraprakash > Ensure internal remote log metadata topi

[jira] [Assigned] (KAFKA-15341) Enabling TS for a topic during rolling restart causes problems

2024-04-13 Thread Kamal Chandraprakash (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15341?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kamal Chandraprakash reassigned KAFKA-15341: Assignee: (was: Kamal Chandraprakash) > Enabling TS for a topic durin

[jira] [Assigned] (KAFKA-15341) Enabling TS for a topic during rolling restart causes problems

2024-04-13 Thread Kamal Chandraprakash (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15341?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kamal Chandraprakash reassigned KAFKA-15341: Assignee: Kamal Chandraprakash > Enabling TS for a topic during rolling r

[jira] [Updated] (KAFKA-15776) Update delay timeout for DelayedRemoteFetch request

2024-04-13 Thread Kamal Chandraprakash (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15776?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kamal Chandraprakash updated KAFKA-15776: - Labels: kip (was: ) > Update delay timeout for DelayedRemoteFetch request > ---

[jira] [Updated] (KAFKA-15776) Update delay timeout for DelayedRemoteFetch request

2024-04-13 Thread Kamal Chandraprakash (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15776?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kamal Chandraprakash updated KAFKA-15776: - Labels: kip-1018 (was: kip) > Update delay timeout for DelayedRemoteFetch reque

[jira] [Updated] (KAFKA-15480) Add RemoteStorageInterruptedException

2024-04-13 Thread Kamal Chandraprakash (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kamal Chandraprakash updated KAFKA-15480: - Labels: kip (was: ) > Add RemoteStorageInterruptedException > -

[PR] KAFKA-16484: Support to define per broker/controller property by ClusterConfigProperty [kafka]

2024-04-13 Thread via GitHub
brandboat opened a new pull request, #15715: URL: https://github.com/apache/kafka/pull/15715 related to KAFKA-16484 Introduce a new field `id` in annotation `ClusterConfigProperty`. The main purpose of new field is to define specific broker/controller(kraft) property. And the default

Re: [PR] KAFKA-15729: Add KRaft support in GetOffsetShellTest [kafka]

2024-04-13 Thread via GitHub
Owen-CH-Leung commented on code in PR #15489: URL: https://github.com/apache/kafka/pull/15489#discussion_r1564142762 ## tools/src/test/java/org/apache/kafka/tools/GetOffsetShellTest.java: ## @@ -48,7 +53,7 @@ import static org.junit.jupiter.api.Assertions.assertTrue; @Extend

Re: [PR] KAFKA-15729: Add KRaft support in GetOffsetShellTest [kafka]

2024-04-13 Thread via GitHub
Owen-CH-Leung commented on code in PR #15489: URL: https://github.com/apache/kafka/pull/15489#discussion_r1564142762 ## tools/src/test/java/org/apache/kafka/tools/GetOffsetShellTest.java: ## @@ -48,7 +53,7 @@ import static org.junit.jupiter.api.Assertions.assertTrue; @Extend

Re: [PR] KAFKA-15729: Add KRaft support in GetOffsetShellTest [kafka]

2024-04-13 Thread via GitHub
chia7712 commented on code in PR #15489: URL: https://github.com/apache/kafka/pull/15489#discussion_r1564147419 ## tools/src/test/java/org/apache/kafka/tools/GetOffsetShellTest.java: ## @@ -48,7 +53,7 @@ import static org.junit.jupiter.api.Assertions.assertTrue; @ExtendWith(

Re: [PR] MINOR: Add test for PartitionMetadataFile [kafka]

2024-04-13 Thread via GitHub
brandboat commented on code in PR #15714: URL: https://github.com/apache/kafka/pull/15714#discussion_r1564160360 ## storage/src/test/java/org/apache/kafka/storage/internals/checkpoint/PartitionMetadataFileTest.java: ## @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache Software Fou

[jira] [Created] (KAFKA-16546) add docs to explain how to update cluster-wide default by Admin#incrementalAlterConfigs

2024-04-13 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-16546: -- Summary: add docs to explain how to update cluster-wide default by Admin#incrementalAlterConfigs Key: KAFKA-16546 URL: https://issues.apache.org/jira/browse/KAFKA-16546

[jira] [Updated] (KAFKA-16546) add docs to explain how to update cluster-wide default by Admin#incrementalAlterConfigs

2024-04-13 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16546?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-16546: --- Priority: Minor (was: Major) > add docs to explain how to update cluster-wide default by >

[jira] [Created] (KAFKA-16547) add test for DescribeConfigsOptions#includeDocumentation

2024-04-13 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-16547: -- Summary: add test for DescribeConfigsOptions#includeDocumentation Key: KAFKA-16547 URL: https://issues.apache.org/jira/browse/KAFKA-16547 Project: Kafka

[jira] [Assigned] (KAFKA-16547) add test for DescribeConfigsOptions#includeDocumentation

2024-04-13 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16547?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai reassigned KAFKA-16547: -- Assignee: Chia-Ping Tsai > add test for DescribeConfigsOptions#includeDocumentation >

Re: [PR] KAFKA-16484: Support to define per broker/controller property by ClusterConfigProperty [kafka]

2024-04-13 Thread via GitHub
chia7712 commented on code in PR #15715: URL: https://github.com/apache/kafka/pull/15715#discussion_r1564305286 ## core/src/test/java/kafka/test/junit/RaftClusterInvocationContext.java: ## @@ -99,6 +99,10 @@ public List getAdditionalExtensions() { clusterCon

Re: [PR] MINOR: Fix flaky test testRackAwareRangeAssignor [kafka]

2024-04-13 Thread via GitHub
github-actions[bot] commented on PR #14829: URL: https://github.com/apache/kafka/pull/14829#issuecomment-2053887957 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has merge

Re: [PR] KAFKA-15729: Add KRaft support in GetOffsetShellTest [kafka]

2024-04-13 Thread via GitHub
Owen-CH-Leung commented on code in PR #15489: URL: https://github.com/apache/kafka/pull/15489#discussion_r1564488318 ## tools/src/test/java/org/apache/kafka/tools/GetOffsetShellTest.java: ## @@ -48,7 +53,7 @@ import static org.junit.jupiter.api.Assertions.assertTrue; @Extend