Owen-CH-Leung commented on code in PR #15489:
URL: https://github.com/apache/kafka/pull/15489#discussion_r1564142762
##########
tools/src/test/java/org/apache/kafka/tools/GetOffsetShellTest.java:
##########
@@ -48,7 +53,7 @@
import static org.junit.jupiter.api.Assertions.assertTrue;
@ExtendWith(value = ClusterTestExtensions.class)
-@ClusterTestDefaults(clusterType = Type.ZK)
+@ClusterTestDefaults(clusterType = Type.ALL)
@Tag("integration")
Review Comment:
those server config are annotated with `@BeforeEach`. Do you mean you want
to put them like below ?
```
@ClusterTest(clusterType = Type.ALL, serverProperties = {
@ClusterConfigProperty(key = "auto.create.topics.enable", value
= "false"),
@ClusterConfigProperty(key = "offsets.topic.replication.factor",
value = "1"),
@ClusterConfigProperty(key = "offsets.topic.num.partitions",
value = "4")
})
```
If so we'd have to modify each test. `ClusterTestDefaults` didn't have the
API `serverProperties` so I think it wouldn't compile
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
