[GitHub] [kafka] mimaison merged pull request #13171: KAFKA-14584: Deprecate StateChangeLogMerger tool

mimaison merged PR #13171: URL: https://github.com/apache/kafka/pull/13171 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[GitHub] [kafka] showuon commented on pull request #13535: KAFKA-9579 Fetch implementation for records in the remote storage through a specific purgatory.

showuon commented on PR #13535: URL: https://github.com/apache/kafka/pull/13535#issuecomment-1527204055 @Hangleton @junrao @jeqo , any other comments to this PR? We hope we can merge it in the early stage of a release, so that we can have enough time to test the stability and have more impr

[GitHub] [kafka] mdedetrich commented on pull request #11792: Replace EasyMock/PowerMock with Mockito in DistributedHerderTest

mdedetrich commented on PR #11792: URL: https://github.com/apache/kafka/pull/11792#issuecomment-1527237583 @yashmayya I don't really have time to finish this any time soon so feel free to take over -- This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [kafka] dajac merged pull request #13550: KAFKA-14639: A single partition may be revoked and assign during a single round of rebalance

dajac merged PR #13550: URL: https://github.com/apache/kafka/pull/13550 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

[GitHub] [kafka] showuon commented on a diff in pull request #13561: KAFKA-14888: Added remote log segments retention functionality based on time and size.

showuon commented on code in PR #13561: URL: https://github.com/apache/kafka/pull/13561#discussion_r1180121259 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -581,11 +588,18 @@ public void run() { if (isLeader()) { // Co

[GitHub] [kafka] dajac commented on pull request #13550: KAFKA-14639: A single partition may be revoked and assign during a single round of rebalance

dajac commented on PR #13550: URL: https://github.com/apache/kafka/pull/13550#issuecomment-1527244890 Merged to trunk and 3.5. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[jira] [Resolved] (KAFKA-14639) Kafka CooperativeStickyAssignor revokes/assigns partition in one rebalance cycle

[ https://issues.apache.org/jira/browse/KAFKA-14639?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot resolved KAFKA-14639. - Fix Version/s: 3.5.0 Reviewer: David Jacot Resolution: Fixed > Kafka Cooperative

[GitHub] [kafka] dajac commented on a diff in pull request #13644: KAFKA-14500; [1/N] Rewrite MemberMetadata in Java

dajac commented on code in PR #13644: URL: https://github.com/apache/kafka/pull/13644#discussion_r1180180911 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/generic/GenericGroupMember.java: ## @@ -0,0 +1,560 @@ +/** + * Licensed to the Apache Software Found

[GitHub] [kafka] yashmayya commented on pull request #13646: KAFKA-14938: Fixing flaky test testConnectorBoundary

yashmayya commented on PR #13646: URL: https://github.com/apache/kafka/pull/13646#issuecomment-1527292922 Thanks @sambhav-jain-16 > What I suspect is happening is that when the method is initially storing the end offsets of the partitions, the connector hasn't produced 100 records t

[GitHub] [kafka] aiven-anton commented on a diff in pull request #13649: MINOR: Fix incorrect description of SessionLifetimeMs

aiven-anton commented on code in PR #13649: URL: https://github.com/apache/kafka/pull/13649#discussion_r1180246714 ## clients/src/main/resources/common/message/SaslAuthenticateResponse.json: ## @@ -29,6 +29,6 @@ { "name": "AuthBytes", "type": "bytes", "versions": "0+",

[GitHub] [kafka] divijvaidya commented on a diff in pull request #13561: KAFKA-14888: Added remote log segments retention functionality based on time and size.

divijvaidya commented on code in PR #13561: URL: https://github.com/apache/kafka/pull/13561#discussion_r1180254846 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -581,11 +588,18 @@ public void run() { if (isLeader()) { /

[GitHub] [kafka] mimaison merged pull request #13649: MINOR: Fix incorrect description of SessionLifetimeMs

mimaison merged PR #13649: URL: https://github.com/apache/kafka/pull/13649 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[GitHub] [kafka] divijvaidya commented on a diff in pull request #13535: KAFKA-9579 Fetch implementation for records in the remote storage through a specific purgatory.

divijvaidya commented on code in PR #13535: URL: https://github.com/apache/kafka/pull/13535#discussion_r1180144730 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -600,25 +622,208 @@ public String toString() { } } -long findHighestRemoteOf

[jira] [Commented] (KAFKA-14947) Duplicate records are getting created in the topic.

[ https://issues.apache.org/jira/browse/KAFKA-14947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17717662#comment-17717662 ] krishnendu Das commented on KAFKA-14947: [~yash.mayya] Thanks for your comment.

[jira] [Created] (KAFKA-14951) Changing the cleanup.policy on an existing topic from "delete" to "compact" seems to change it to "compact,delete" even though it says "compact"

Tomasz Kaszuba created KAFKA-14951: -- Summary: Changing the cleanup.policy on an existing topic from "delete" to "compact" seems to change it to "compact,delete" even though it says "compact" Key: KAFKA-14951 URL

[GitHub] [kafka] dajac commented on a diff in pull request #13637: KAFKA-14462; [10/N] Add TargetAssignmentBuilder

dajac commented on code in PR #13637: URL: https://github.com/apache/kafka/pull/13637#discussion_r1180404680 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroupMemberTest.java: ## @@ -0,0 +1,307 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] dajac commented on a diff in pull request #13637: KAFKA-14462; [10/N] Add TargetAssignmentBuilder

dajac commented on code in PR #13637: URL: https://github.com/apache/kafka/pull/13637#discussion_r1180405622 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/TargetAssignmentBuilder.java: ## @@ -0,0 +1,327 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] dajac commented on a diff in pull request #13637: KAFKA-14462; [10/N] Add TargetAssignmentBuilder

dajac commented on code in PR #13637: URL: https://github.com/apache/kafka/pull/13637#discussion_r1180406549 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/TargetAssignmentBuilder.java: ## @@ -0,0 +1,327 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] dajac commented on a diff in pull request #13637: KAFKA-14462; [10/N] Add TargetAssignmentBuilder

dajac commented on code in PR #13637: URL: https://github.com/apache/kafka/pull/13637#discussion_r1180408510 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/TargetAssignmentBuilder.java: ## @@ -0,0 +1,327 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] dajac commented on a diff in pull request #13637: KAFKA-14462; [10/N] Add TargetAssignmentBuilder

dajac commented on code in PR #13637: URL: https://github.com/apache/kafka/pull/13637#discussion_r1180410020 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/TargetAssignmentBuilder.java: ## @@ -0,0 +1,327 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] yashmayya commented on pull request #11792: Replace EasyMock/PowerMock with Mockito in DistributedHerderTest

yashmayya commented on PR #11792: URL: https://github.com/apache/kafka/pull/11792#issuecomment-1527579890 @mdedetrich no problem, I've assigned https://issues.apache.org/jira/browse/KAFKA-13187 to myself and I'll start working on it next week. -- This is an automated message from the Apa

[jira] [Assigned] (KAFKA-13187) Replace EasyMock and PowerMock with Mockito for DistributedHerderTest

[ https://issues.apache.org/jira/browse/KAFKA-13187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yash Mayya reassigned KAFKA-13187: -- Assignee: Yash Mayya (was: Matthew de Detrich) > Replace EasyMock and PowerMock with Mockito

[GitHub] [kafka] dajac commented on a diff in pull request #13637: KAFKA-14462; [10/N] Add TargetAssignmentBuilder

dajac commented on code in PR #13637: URL: https://github.com/apache/kafka/pull/13637#discussion_r1180425612 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/consumer/TargetAssignmentBuilderTest.java: ## @@ -0,0 +1,688 @@ +/* + * Licensed to the Apache Softw

[GitHub] [kafka] dajac commented on a diff in pull request #13637: KAFKA-14462; [10/N] Add TargetAssignmentBuilder

dajac commented on code in PR #13637: URL: https://github.com/apache/kafka/pull/13637#discussion_r1180427210 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/consumer/TargetAssignmentBuilderTest.java: ## @@ -0,0 +1,688 @@ +/* + * Licensed to the Apache Softw

[GitHub] [kafka] dajac commented on a diff in pull request #13637: KAFKA-14462; [10/N] Add TargetAssignmentBuilder

dajac commented on code in PR #13637: URL: https://github.com/apache/kafka/pull/13637#discussion_r1180451832 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/consumer/TargetAssignmentBuilderTest.java: ## @@ -0,0 +1,688 @@ +/* + * Licensed to the Apache Softw

[GitHub] [kafka] dajac commented on a diff in pull request #13637: KAFKA-14462; [10/N] Add TargetAssignmentBuilder

dajac commented on code in PR #13637: URL: https://github.com/apache/kafka/pull/13637#discussion_r1180463243 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroupMemberTest.java: ## @@ -0,0 +1,307 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] dajac commented on pull request #13637: KAFKA-14462; [10/N] Add TargetAssignmentBuilder

dajac commented on PR #13637: URL: https://github.com/apache/kafka/pull/13637#issuecomment-1527632827 @jolshan @rreddy-22 @jeffkbkim Thanks for your comments. I have addressed all of them. -- This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [kafka] bmscomp commented on a diff in pull request #13627: MINOR: simplify if else conditions in Uuid.compareTo method

bmscomp commented on code in PR #13627: URL: https://github.com/apache/kafka/pull/13627#discussion_r1178371488 ## clients/src/main/java/org/apache/kafka/common/Uuid.java: ## @@ -143,12 +143,6 @@ public int compareTo(Uuid other) { return 1; Review Comment: @divij

[GitHub] [kafka] vamossagar12 commented on pull request #13646: KAFKA-14938: Fixing flaky test testConnectorBoundary

vamossagar12 commented on PR #13646: URL: https://github.com/apache/kafka/pull/13646#issuecomment-1527703722 Yeah I agree with @yashmayya . Moreover this ``` Yes it will fail, but consumeAll is not failing due to timeout here but rather due to its nature of storing the end offsets

[GitHub] [kafka] mjsax commented on a diff in pull request #13633: KAFKA-14839: Exclude protected variable from JavaDocs

mjsax commented on code in PR #13633: URL: https://github.com/apache/kafka/pull/13633#discussion_r1180546756 ## build.gradle: ## @@ -2057,6 +2057,7 @@ project(':streams') { srcJar.dependsOn 'processMessages' javadoc { +options.memberLevel = JavadocMemberLevel.PUBLIC

[jira] [Updated] (KAFKA-14949) Add Streams upgrade tests from AK 3.4

[ https://issues.apache.org/jira/browse/KAFKA-14949?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-14949: Component/s: system tests > Add Streams upgrade tests from AK 3.4 > --

[GitHub] [kafka] vamossagar12 commented on pull request #13594: KAFKA-14913: Using ThreadUtils.shutdownExecutorServiceQuietly to close executors in Connect Runtime

vamossagar12 commented on PR #13594: URL: https://github.com/apache/kafka/pull/13594#issuecomment-1527739912 @urbandan , i took the liberty and modified the `shutdownExecutorServiceQuietly` to do a 2-phased shutdown as suggested in JavaDocs. Also, modified `MemoryOffsetBackingStore, Source

[GitHub] [kafka] philipnee commented on pull request #13550: KAFKA-14639: A single partition may be revoked and assign during a single round of rebalance

philipnee commented on PR #13550: URL: https://github.com/apache/kafka/pull/13550#issuecomment-1527744080 Thanks David, FWIW: I think we also want to back port it to 3.4, I'll raise a PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [kafka] dajac merged pull request #13618: MINOR: Fixing typos in the ConsumerCoordinators

dajac merged PR #13618: URL: https://github.com/apache/kafka/pull/13618 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

[GitHub] [kafka] jolshan commented on a diff in pull request #13637: KAFKA-14462; [10/N] Add TargetAssignmentBuilder

jolshan commented on code in PR #13637: URL: https://github.com/apache/kafka/pull/13637#discussion_r1180569515 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroupMemberTest.java: ## @@ -0,0 +1,307 @@ +/* + * Licensed to the Apache Softwar

[GitHub] [kafka] dajac commented on a diff in pull request #13637: KAFKA-14462; [10/N] Add TargetAssignmentBuilder

dajac commented on code in PR #13637: URL: https://github.com/apache/kafka/pull/13637#discussion_r1180572223 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroupMemberTest.java: ## @@ -0,0 +1,307 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] jolshan commented on a diff in pull request #13637: KAFKA-14462; [10/N] Add TargetAssignmentBuilder

jolshan commented on code in PR #13637: URL: https://github.com/apache/kafka/pull/13637#discussion_r1180575457 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroupMemberTest.java: ## @@ -0,0 +1,307 @@ +/* + * Licensed to the Apache Softwar

[GitHub] [kafka] dajac commented on a diff in pull request #13637: KAFKA-14462; [10/N] Add TargetAssignmentBuilder

dajac commented on code in PR #13637: URL: https://github.com/apache/kafka/pull/13637#discussion_r1180576777 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroupMemberTest.java: ## @@ -0,0 +1,307 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #13267: KAFKA-14694: RPCProducerIdManager should not wait on new block

jeffkbkim commented on code in PR #13267: URL: https://github.com/apache/kafka/pull/13267#discussion_r1180578924 ## core/src/main/scala/kafka/coordinator/transaction/ProducerIdManager.scala: ## @@ -123,73 +129,94 @@ class ZkProducerIdManager(brokerId: Int, } } - def g

[GitHub] [kafka] jolshan commented on a diff in pull request #13637: KAFKA-14462; [10/N] Add TargetAssignmentBuilder

jolshan commented on code in PR #13637: URL: https://github.com/apache/kafka/pull/13637#discussion_r1180588499 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/TargetAssignmentBuilder.java: ## @@ -0,0 +1,327 @@ +/* + * Licensed to the Apache Softwar

[GitHub] [kafka] jolshan commented on a diff in pull request #13637: KAFKA-14462; [10/N] Add TargetAssignmentBuilder

jolshan commented on code in PR #13637: URL: https://github.com/apache/kafka/pull/13637#discussion_r1180589296 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/TargetAssignmentBuilder.java: ## @@ -0,0 +1,327 @@ +/* + * Licensed to the Apache Softwar

[GitHub] [kafka] jolshan commented on a diff in pull request #13637: KAFKA-14462; [10/N] Add TargetAssignmentBuilder

jolshan commented on code in PR #13637: URL: https://github.com/apache/kafka/pull/13637#discussion_r1180590049 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/TargetAssignmentBuilder.java: ## @@ -0,0 +1,327 @@ +/* + * Licensed to the Apache Softwar

[GitHub] [kafka] jolshan commented on a diff in pull request #13637: KAFKA-14462; [10/N] Add TargetAssignmentBuilder

jolshan commented on code in PR #13637: URL: https://github.com/apache/kafka/pull/13637#discussion_r1180590786 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/consumer/TargetAssignmentBuilderTest.java: ## @@ -0,0 +1,688 @@ +/* + * Licensed to the Apache Sof

[GitHub] [kafka] jolshan commented on a diff in pull request #13637: KAFKA-14462; [10/N] Add TargetAssignmentBuilder

jolshan commented on code in PR #13637: URL: https://github.com/apache/kafka/pull/13637#discussion_r1180593876 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/consumer/TargetAssignmentBuilderTest.java: ## @@ -0,0 +1,688 @@ +/* + * Licensed to the Apache Sof

[GitHub] [kafka] jolshan commented on a diff in pull request #13637: KAFKA-14462; [10/N] Add TargetAssignmentBuilder

jolshan commented on code in PR #13637: URL: https://github.com/apache/kafka/pull/13637#discussion_r1180598466 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/consumer/TargetAssignmentBuilderTest.java: ## @@ -0,0 +1,698 @@ +/* + * Licensed to the Apache Sof

[GitHub] [kafka] jolshan commented on a diff in pull request #13637: KAFKA-14462; [10/N] Add TargetAssignmentBuilder

jolshan commented on code in PR #13637: URL: https://github.com/apache/kafka/pull/13637#discussion_r1180601499 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/consumer/TargetAssignmentBuilderTest.java: ## @@ -0,0 +1,698 @@ +/* + * Licensed to the Apache Sof

[GitHub] [kafka] philipnee opened a new pull request, #13652: Cherry pick KAFKA-14639

philipnee opened a new pull request, #13652: URL: https://github.com/apache/kafka/pull/13652 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of testi

[GitHub] [kafka] dajac commented on a diff in pull request #13637: KAFKA-14462; [10/N] Add TargetAssignmentBuilder

dajac commented on code in PR #13637: URL: https://github.com/apache/kafka/pull/13637#discussion_r1180604733 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/TargetAssignmentBuilder.java: ## @@ -0,0 +1,327 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] dajac commented on a diff in pull request #13637: KAFKA-14462; [10/N] Add TargetAssignmentBuilder

dajac commented on code in PR #13637: URL: https://github.com/apache/kafka/pull/13637#discussion_r1180606875 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/TargetAssignmentBuilder.java: ## @@ -0,0 +1,327 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] dajac commented on a diff in pull request #13637: KAFKA-14462; [10/N] Add TargetAssignmentBuilder

dajac commented on code in PR #13637: URL: https://github.com/apache/kafka/pull/13637#discussion_r1180607217 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/consumer/TargetAssignmentBuilderTest.java: ## @@ -0,0 +1,688 @@ +/* + * Licensed to the Apache Softw

[GitHub] [kafka] dajac commented on a diff in pull request #13637: KAFKA-14462; [10/N] Add TargetAssignmentBuilder

dajac commented on code in PR #13637: URL: https://github.com/apache/kafka/pull/13637#discussion_r1180608354 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/consumer/TargetAssignmentBuilderTest.java: ## @@ -0,0 +1,698 @@ +/* + * Licensed to the Apache Softw

[GitHub] [kafka] dajac commented on a diff in pull request #13637: KAFKA-14462; [10/N] Add TargetAssignmentBuilder

dajac commented on code in PR #13637: URL: https://github.com/apache/kafka/pull/13637#discussion_r1180608631 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/consumer/TargetAssignmentBuilderTest.java: ## @@ -0,0 +1,698 @@ +/* + * Licensed to the Apache Softw

[jira] [Commented] (KAFKA-13891) sync group failed with rebalanceInProgress error cause rebalance many rounds in coopeartive

[ https://issues.apache.org/jira/browse/KAFKA-13891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17717745#comment-17717745 ] Philip Nee commented on KAFKA-13891: [~dajac] - I think we resolve this and the subs

[GitHub] [kafka] jolshan commented on a diff in pull request #13637: KAFKA-14462; [10/N] Add TargetAssignmentBuilder

jolshan commented on code in PR #13637: URL: https://github.com/apache/kafka/pull/13637#discussion_r1180613326 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroupMemberTest.java: ## @@ -0,0 +1,307 @@ +/* + * Licensed to the Apache Softwar

[GitHub] [kafka] jolshan commented on a diff in pull request #12149: KAFKA-13668: Retry upon missing initProducerId due to authorization error

jolshan commented on code in PR #12149: URL: https://github.com/apache/kafka/pull/12149#discussion_r1180619843 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java: ## @@ -300,9 +301,13 @@ void runOnce() { try { transacti

[GitHub] [kafka] philipnee commented on a diff in pull request #12149: KAFKA-13668: Retry upon missing initProducerId due to authorization error

philipnee commented on code in PR #12149: URL: https://github.com/apache/kafka/pull/12149#discussion_r1180625792 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java: ## @@ -300,9 +301,13 @@ void runOnce() { try { transac

[GitHub] [kafka] mjsax commented on a diff in pull request #11433: KAFKA-13295: Avoiding Transation timeouts arising due to long restora…

mjsax commented on code in PR #11433: URL: https://github.com/apache/kafka/pull/11433#discussion_r832815852 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -262,6 +262,42 @@ private void closeDirtyAndRevive(final Collection taskWith

[GitHub] [kafka] ijuma commented on pull request #13647: MINOR: fix KRaftClusterTest and KRaft integration test failure

ijuma commented on PR #13647: URL: https://github.com/apache/kafka/pull/13647#issuecomment-1527834450 @mumrah the original PR had the same failures, how come we merged it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [kafka] jolshan commented on a diff in pull request #12149: KAFKA-13668: Retry upon missing initProducerId due to authorization error

jolshan commented on code in PR #12149: URL: https://github.com/apache/kafka/pull/12149#discussion_r1180672146 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java: ## @@ -300,9 +301,13 @@ void runOnce() { try { transacti

[GitHub] [kafka] jolshan commented on a diff in pull request #12149: KAFKA-13668: Retry upon missing initProducerId due to authorization error

jolshan commented on code in PR #12149: URL: https://github.com/apache/kafka/pull/12149#discussion_r1180672745 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java: ## @@ -300,9 +301,13 @@ void runOnce() { try { transacti

[GitHub] [kafka] kirktrue commented on pull request #13640: KAFKA-14937: Refactoring for client code to reduce boilerplate

kirktrue commented on PR #13640: URL: https://github.com/apache/kafka/pull/13640#issuecomment-1527914720 The Spotbugs validation is passing and there are no new test failures. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [kafka] kirktrue commented on pull request #13591: KAFKA-14831: Illegal state errors should be fatal in transactional producer

kirktrue commented on PR #13591: URL: https://github.com/apache/kafka/pull/13591#issuecomment-1527916726 The test failures are Kraft-related and don't appear to be caused by this change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [kafka] kirktrue commented on pull request #13528: KAFKA-14879: Update system tests to use latest versions

kirktrue commented on PR #13528: URL: https://github.com/apache/kafka/pull/13528#issuecomment-1527918482 Test failures are Kraft-related and do not appear to be caused by this change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] kirktrue commented on a diff in pull request #13623: KAFKA-14926: Remove metrics on Log Cleaner shutdown

kirktrue commented on code in PR #13623: URL: https://github.com/apache/kafka/pull/13623#discussion_r1180722737 ## core/src/main/scala/kafka/log/LogCleaner.scala: ## @@ -167,8 +167,20 @@ class LogCleaner(initialConfig: CleanerConfig, */ def shutdown(): Unit = { info(

[GitHub] [kafka] kirktrue commented on a diff in pull request #13617: MINOR:code optimization in QuorumController

kirktrue commented on code in PR #13617: URL: https://github.com/apache/kafka/pull/13617#discussion_r1180727333 ## metadata/src/main/java/org/apache/kafka/controller/QuorumController.java: ## @@ -1635,7 +1636,7 @@ private enum ImbalanceSchedule { /** * Tracks if a sna

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #13637: KAFKA-14462; [10/N] Add TargetAssignmentBuilder

jeffkbkim commented on code in PR #13637: URL: https://github.com/apache/kafka/pull/13637#discussion_r1180707601 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/TargetAssignmentBuilder.java: ## @@ -0,0 +1,327 @@ +/* + * Licensed to the Apache Softw

[GitHub] [kafka] mumrah commented on pull request #13647: MINOR: fix KRaftClusterTest and KRaft integration test failure

mumrah commented on PR #13647: URL: https://github.com/apache/kafka/pull/13647#issuecomment-1528072990 The test failure was introduced by a commit fairly late in #13407. I did briefly investigate it, but couldn't reproduce it locally, so I figured it was existing flakiness. Basically, it's

[GitHub] [kafka] kirktrue commented on a diff in pull request #13607: KAFKA-14916: Fix code that assumes transactional ID implies all records are transactional

kirktrue commented on code in PR #13607: URL: https://github.com/apache/kafka/pull/13607#discussion_r1180838837 ## clients/src/test/java/org/apache/kafka/common/requests/ProduceRequestTest.java: ## @@ -238,6 +238,37 @@ public void testV6AndBelowCannotUseZStdCompression() {

[GitHub] [kafka] kirktrue commented on a diff in pull request #13605: KAFKA-14950: implement assign() and assignment()

kirktrue commented on code in PR #13605: URL: https://github.com/apache/kafka/pull/13605#discussion_r1180848020 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumer.java: ## @@ -537,7 +568,9 @@ public void subscribe(Pattern pattern) {

[GitHub] [kafka] kirktrue commented on pull request #13581: A document on the current usage of Kafka project is added

kirktrue commented on PR #13581: URL: https://github.com/apache/kafka/pull/13581#issuecomment-1528144605 @SijoJoseph2002 just for my own understanding, did you intend to change this much source? -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] jolshan commented on a diff in pull request #13607: KAFKA-14916: Fix code that assumes transactional ID implies all records are transactional

jolshan commented on code in PR #13607: URL: https://github.com/apache/kafka/pull/13607#discussion_r1180864129 ## clients/src/main/java/org/apache/kafka/common/requests/ProduceRequest.java: ## @@ -222,6 +223,27 @@ public void clearPartitionRecords() { partitionSizes();

[GitHub] [kafka] jolshan commented on a diff in pull request #13607: KAFKA-14916: Fix code that assumes transactional ID implies all records are transactional

jolshan commented on code in PR #13607: URL: https://github.com/apache/kafka/pull/13607#discussion_r1180864382 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -642,7 +642,14 @@ class ReplicaManager(val config: KafkaConfig, (entriesPerPartition, Map.emp

[GitHub] [kafka] jolshan commented on a diff in pull request #13607: KAFKA-14916: Fix code that assumes transactional ID implies all records are transactional

jolshan commented on code in PR #13607: URL: https://github.com/apache/kafka/pull/13607#discussion_r1180865066 ## clients/src/main/java/org/apache/kafka/common/requests/ProduceRequest.java: ## @@ -222,6 +223,27 @@ public void clearPartitionRecords() { partitionSizes();

[GitHub] [kafka] kirktrue commented on pull request #13568: KAFKA-14906:Extract the coordinator service log from server log

kirktrue commented on PR #13568: URL: https://github.com/apache/kafka/pull/13568#issuecomment-1528167503 Logging configuration is something the administrator can change as desired, right? Is there a clear benefit to the majority of users for this change? I can imagine it being a welcome cha

[GitHub] [kafka] jolshan commented on pull request #13607: KAFKA-14916: Fix code that assumes transactional ID implies all records are transactional

jolshan commented on PR #13607: URL: https://github.com/apache/kafka/pull/13607#issuecomment-1528168395 One concern that came up when I was thinking about this PR is if we can have a produce request with more than one producer ID when we overflow epoch. Basically, I need to confirm we flush

[GitHub] [kafka] jolshan commented on a diff in pull request #13591: KAFKA-14831: Illegal state errors should be fatal in transactional producer

jolshan commented on code in PR #13591: URL: https://github.com/apache/kafka/pull/13591#discussion_r1180880417 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -196,6 +196,44 @@ private enum Priority { } } +/

[GitHub] [kafka] jolshan commented on a diff in pull request #13591: KAFKA-14831: Illegal state errors should be fatal in transactional producer

jolshan commented on code in PR #13591: URL: https://github.com/apache/kafka/pull/13591#discussion_r1180880696 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -196,6 +196,44 @@ private enum Priority { } } +/

[GitHub] [kafka] kirktrue commented on a diff in pull request #13591: KAFKA-14831: Illegal state errors should be fatal in transactional producer

kirktrue commented on code in PR #13591: URL: https://github.com/apache/kafka/pull/13591#discussion_r1180881100 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -196,6 +196,44 @@ private enum Priority { } } +

[GitHub] [kafka] jolshan commented on a diff in pull request #13591: KAFKA-14831: Illegal state errors should be fatal in transactional producer

jolshan commented on code in PR #13591: URL: https://github.com/apache/kafka/pull/13591#discussion_r1180880988 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -196,6 +196,44 @@ private enum Priority { } } +/

[GitHub] [kafka] kirktrue commented on a diff in pull request #13591: KAFKA-14831: Illegal state errors should be fatal in transactional producer

kirktrue commented on code in PR #13591: URL: https://github.com/apache/kafka/pull/13591#discussion_r1180881150 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -196,6 +196,44 @@ private enum Priority { } } +

[GitHub] [kafka] jolshan commented on a diff in pull request #13591: KAFKA-14831: Illegal state errors should be fatal in transactional producer

jolshan commented on code in PR #13591: URL: https://github.com/apache/kafka/pull/13591#discussion_r1180883557 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -384,14 +436,19 @@ synchronized boolean isAborting() { }

[GitHub] [kafka] jolshan commented on a diff in pull request #13591: KAFKA-14831: Illegal state errors should be fatal in transactional producer

jolshan commented on code in PR #13591: URL: https://github.com/apache/kafka/pull/13591#discussion_r1180884390 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -384,14 +436,19 @@ synchronized boolean isAborting() { }

[GitHub] [kafka] jolshan commented on a diff in pull request #13591: KAFKA-14831: Illegal state errors should be fatal in transactional producer

jolshan commented on code in PR #13591: URL: https://github.com/apache/kafka/pull/13591#discussion_r1180884390 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -384,14 +436,19 @@ synchronized boolean isAborting() { }

[GitHub] [kafka] jolshan commented on a diff in pull request #13591: KAFKA-14831: Illegal state errors should be fatal in transactional producer

jolshan commented on code in PR #13591: URL: https://github.com/apache/kafka/pull/13591#discussion_r1180886011 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -384,14 +436,19 @@ synchronized boolean isAborting() { }

[GitHub] [kafka] jolshan commented on pull request #13591: KAFKA-14831: Illegal state errors should be fatal in transactional producer

jolshan commented on PR #13591: URL: https://github.com/apache/kafka/pull/13591#issuecomment-1528256534 @kirktrue do we have a list of transitions we consider internal vs external? It would be nice to review that list as well as the code. -- This is an automated message from the Apache Gi

[GitHub] [kafka] kirktrue commented on a diff in pull request #13591: KAFKA-14831: Illegal state errors should be fatal in transactional producer

kirktrue commented on code in PR #13591: URL: https://github.com/apache/kafka/pull/13591#discussion_r1180888455 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -384,14 +436,19 @@ synchronized boolean isAborting() { }

[jira] [Created] (KAFKA-14952) Publish metrics when source connector fails to poll data

Ravindranath Kakarla created KAFKA-14952: Summary: Publish metrics when source connector fails to poll data Key: KAFKA-14952 URL: https://issues.apache.org/jira/browse/KAFKA-14952 Project: Kafk

[GitHub] [kafka] kirktrue commented on pull request #13591: KAFKA-14831: Illegal state errors should be fatal in transactional producer

kirktrue commented on PR #13591: URL: https://github.com/apache/kafka/pull/13591#issuecomment-1528441772 Temporarily marking this as a draft as I've committed some code that is not fully vetted yet. -- This is an automated message from the Apache Git Service. To respond to the message, pl

[jira] [Updated] (KAFKA-14952) Publish metrics when source connector fails to poll data

[ https://issues.apache.org/jira/browse/KAFKA-14952?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ravindranath Kakarla updated KAFKA-14952: - Description: Currently, there is no metric in Kafka Connect to track when a sour

[jira] [Updated] (KAFKA-14952) Publish metrics when source connector fails to poll data

[ https://issues.apache.org/jira/browse/KAFKA-14952?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ravindranath Kakarla updated KAFKA-14952: - Description: Currently, there is no metric in Kafka Connect to track when a sour