[jira] [Created] (KAFKA-14933) Document Kafka Connect's log level REST APIs added in KIP-495

2023-04-25 Thread Yash Mayya (Jira)
Yash Mayya created KAFKA-14933: -- Summary: Document Kafka Connect's log level REST APIs added in KIP-495 Key: KAFKA-14933 URL: https://issues.apache.org/jira/browse/KAFKA-14933 Project: Kafka Is

[jira] [Commented] (KAFKA-14911) Add system tests for rolling upgrade path of KIP-904

2023-04-25 Thread Victoria Xia (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17716134#comment-17716134 ] Victoria Xia commented on KAFKA-14911: -- I can help pick this up, in light of the up

[GitHub] [kafka] machi1990 commented on pull request #13626: MINOR: only set sslEngine#setUseClientMode to false once when ssl mode is server

2023-04-25 Thread via GitHub
machi1990 commented on PR #13626: URL: https://github.com/apache/kafka/pull/13626#issuecomment-1521299054 Thanks @maulin-vasavada -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[GitHub] [kafka] yashmayya opened a new pull request, #13635: MINOR: Fix Javadoc for configureAdminResources in Connect's RestServer

2023-04-25 Thread via GitHub
yashmayya opened a new pull request, #13635: URL: https://github.com/apache/kafka/pull/13635 - The param Javadoc was likely copied from `configureRegularResources` ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test cov

[GitHub] [kafka] yashmayya commented on pull request #13635: MINOR: Fix Javadoc for configureAdminResources in Connect's RestServer

2023-04-25 Thread via GitHub
yashmayya commented on PR #13635: URL: https://github.com/apache/kafka/pull/13635#issuecomment-1521380683 cc @C0urante -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

[GitHub] [kafka] dajac commented on pull request #13600: KAFKA-14869: Bump coordinator value records to flexible versions (KIP…

2023-04-25 Thread via GitHub
dajac commented on PR #13600: URL: https://github.com/apache/kafka/pull/13600#issuecomment-1521400266 The last build is green. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [kafka] dajac merged pull request #13600: KAFKA-14869: Bump coordinator value records to flexible versions (KIP…

2023-04-25 Thread via GitHub
dajac merged PR #13600: URL: https://github.com/apache/kafka/pull/13600 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

[GitHub] [kafka] dajac commented on pull request #13601: KAFKA-14869: Bump coordinator value records to flexible versions (KIP…

2023-04-25 Thread via GitHub
dajac commented on PR #13601: URL: https://github.com/apache/kafka/pull/13601#issuecomment-1521402202 Failed tests are not related: ``` Build / JDK 17 and Scala 2.13 / testClientDisconnectionUpdatesRequestMetrics() – kafka.network.SocketServerTest 15s Build / JDK 17 and Scala 2.1

[GitHub] [kafka] dajac merged pull request #13601: KAFKA-14869: Bump coordinator value records to flexible versions (KIP…

2023-04-25 Thread via GitHub
dajac merged PR #13601: URL: https://github.com/apache/kafka/pull/13601 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

[GitHub] [kafka] dajac commented on pull request #13602: KAFKA-14869: Bump coordinator value records to flexible versions (KIP…

2023-04-25 Thread via GitHub
dajac commented on PR #13602: URL: https://github.com/apache/kafka/pull/13602#issuecomment-1521403475 Build looks good. Failed test is not related. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] dajac merged pull request #13602: KAFKA-14869: Bump coordinator value records to flexible versions (KIP…

2023-04-25 Thread via GitHub
dajac merged PR #13602: URL: https://github.com/apache/kafka/pull/13602 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

[GitHub] [kafka] yashmayya opened a new pull request, #13636: KAFKA-14933: Document Kafka Connect's log level REST APIs added in KIP-495

2023-04-25 Thread via GitHub
yashmayya opened a new pull request, #13636: URL: https://github.com/apache/kafka/pull/13636 - https://issues.apache.org/jira/browse/KAFKA-14933 - [KIP-495](https://cwiki.apache.org/confluence/display/KAFKA/KIP-495%3A+Dynamically+Adjust+Log+Levels+in+Connect) added 3 REST APIs to allow d

[GitHub] [kafka] yashmayya commented on pull request #13636: KAFKA-14933: Document Kafka Connect's log level REST APIs added in KIP-495

2023-04-25 Thread via GitHub
yashmayya commented on PR #13636: URL: https://github.com/apache/kafka/pull/13636#issuecomment-1521406022 @C0urante @mimaison could you please take a look whenever possible? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [kafka] gharris1727 commented on a diff in pull request #13429: KAFKA-14666: Add MM2 in-memory offset translation index for offsets behind replication

2023-04-25 Thread via GitHub
gharris1727 commented on code in PR #13429: URL: https://github.com/apache/kafka/pull/13429#discussion_r1176202013 ## connect/mirror/src/main/java/org/apache/kafka/connect/mirror/OffsetSyncStore.java: ## @@ -139,10 +180,141 @@ public void close() { protected void handleReco

[GitHub] [kafka] gharris1727 commented on a diff in pull request #13429: KAFKA-14666: Add MM2 in-memory offset translation index for offsets behind replication

2023-04-25 Thread via GitHub
gharris1727 commented on code in PR #13429: URL: https://github.com/apache/kafka/pull/13429#discussion_r1176205390 ## connect/mirror/src/main/java/org/apache/kafka/connect/mirror/OffsetSyncStore.java: ## @@ -139,10 +180,141 @@ public void close() { protected void handleReco

[GitHub] [kafka] dajac commented on a diff in pull request #13538: KAFKA-14462; [8/N] Add ConsumerGroupMember

2023-04-25 Thread via GitHub
dajac commented on code in PR #13538: URL: https://github.com/apache/kafka/pull/13538#discussion_r1176216652 ## checkstyle/suppressions.xml: ## @@ -318,6 +318,14 @@ + + +

[GitHub] [kafka] dajac commented on a diff in pull request #13538: KAFKA-14462; [8/N] Add ConsumerGroupMember

2023-04-25 Thread via GitHub
dajac commented on code in PR #13538: URL: https://github.com/apache/kafka/pull/13538#discussion_r1176228286 ## checkstyle/suppressions.xml: ## @@ -318,6 +318,14 @@ + + +

[GitHub] [kafka] gharris1727 commented on a diff in pull request #13429: KAFKA-14666: Add MM2 in-memory offset translation index for offsets behind replication

2023-04-25 Thread via GitHub
gharris1727 commented on code in PR #13429: URL: https://github.com/apache/kafka/pull/13429#discussion_r1176247653 ## connect/mirror/src/main/java/org/apache/kafka/connect/mirror/OffsetSyncStore.java: ## @@ -139,10 +180,141 @@ public void close() { protected void handleReco

[GitHub] [kafka] machi1990 commented on pull request #13626: MINOR: only set sslEngine#setUseClientMode to false once when ssl mode is server

2023-04-25 Thread via GitHub
machi1990 commented on PR #13626: URL: https://github.com/apache/kafka/pull/13626#issuecomment-1521462905 Thanks for the review @divijvaidya > As a note to help the reviewers, the removed line in this PR is duplicated by line 192. > https://github.com/apache/kafka/pull/13626/fil

[GitHub] [kafka] divijvaidya commented on a diff in pull request #13627: MINOR: simplify if else conditions in Uuid.compareTo method

2023-04-25 Thread via GitHub
divijvaidya commented on code in PR #13627: URL: https://github.com/apache/kafka/pull/13627#discussion_r1176249165 ## clients/src/main/java/org/apache/kafka/common/Uuid.java: ## @@ -143,12 +143,6 @@ public int compareTo(Uuid other) { return 1; Review Comment: Ca

[GitHub] [kafka] yashmayya commented on a diff in pull request #13465: KAFKA-14368: Connect offset write REST API

2023-04-25 Thread via GitHub
yashmayya commented on code in PR #13465: URL: https://github.com/apache/kafka/pull/13465#discussion_r1167415541 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Worker.java: ## @@ -1247,6 +1257,257 @@ void sourceConnectorOffsets(String connName, ConnectorOffse

[GitHub] [kafka] divijvaidya commented on pull request #13625: MINOR: Upgrade gradle wrapper to the last stable version 8.1.1

2023-04-25 Thread via GitHub
divijvaidya commented on PR #13625: URL: https://github.com/apache/kafka/pull/13625#issuecomment-1521479258 This supersedes an open PR at https://github.com/apache/kafka/pull/13569/files @ijuma would you like to review this one and close the other one, since the gradle recommendation from

[GitHub] [kafka] divijvaidya commented on pull request #13569: MINOR: Upgrade to Gradle 8.1

2023-04-25 Thread via GitHub
divijvaidya commented on PR #13569: URL: https://github.com/apache/kafka/pull/13569#issuecomment-1521481245 A new big fix release is available 8.1.1 and the release notes mention: "We recommend users upgrade to 8.1.1 instead of 8.1." I would suggest to discard this PR and instead revi

[GitHub] [kafka] vamossagar12 commented on pull request #13594: KAFKA-14913: Using ThreadUtils.shutdownExecutorServiceQuietly to close executors in Connect Runtime

2023-04-25 Thread via GitHub
vamossagar12 commented on PR #13594: URL: https://github.com/apache/kafka/pull/13594#issuecomment-1521506051 I checked the flow again and ConnectException being thrown is handled from `AbstractWorkerSourceTask#close` via the `Utils.closeQuietly` method which the Worker#stop doesn't. Nonethe

[GitHub] [kafka] dajac opened a new pull request, #13637: KAFKA-14462; [10/N] Add TargetAssignmentBuilder

2023-04-25 Thread via GitHub
dajac opened a new pull request, #13637: URL: https://github.com/apache/kafka/pull/13637 Built on top of https://github.com/apache/kafka/pull/13544. This patch adds TargetAssignmentBuilder. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementatio

[GitHub] [kafka] omkreddy merged pull request #13626: MINOR: only set sslEngine#setUseClientMode to false once when ssl mode is server

2023-04-25 Thread via GitHub
omkreddy merged PR #13626: URL: https://github.com/apache/kafka/pull/13626 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[GitHub] [kafka] machi1990 commented on pull request #13626: MINOR: only set sslEngine#setUseClientMode to false once when ssl mode is server

2023-04-25 Thread via GitHub
machi1990 commented on PR #13626: URL: https://github.com/apache/kafka/pull/13626#issuecomment-1521519704 Thanks @omkreddy for the review! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[GitHub] [kafka] clolov commented on pull request #13621: KAFKA-14133: Migrate ChangeLogReader mock in TaskManagerTest to Mockito

2023-04-25 Thread via GitHub
clolov commented on PR #13621: URL: https://github.com/apache/kafka/pull/13621#issuecomment-1521580408 Great! Thank you @cadonna, I will aim to address the comments either today or tomorrow! -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] machi1990 commented on pull request #13611: MINOR: remove unused variable from QuorumMetaLogListener#handleCommit method

2023-04-25 Thread via GitHub
machi1990 commented on PR #13611: URL: https://github.com/apache/kafka/pull/13611#issuecomment-1521610996 Thanks for the review @divijvaidya > Could you please check where was this added and what commit was it's usage removed? Such unused variable may be hiding bugs where they should

[GitHub] [kafka] machi1990 commented on a diff in pull request #13634: KAFKA-14929: Fixing flaky test putTopicStateRetriableFailure

2023-04-25 Thread via GitHub
machi1990 commented on code in PR #13634: URL: https://github.com/apache/kafka/pull/13634#discussion_r1176376840 ## connect/runtime/src/test/java/org/apache/kafka/connect/storage/KafkaStatusBackingStoreFormatTest.java: ## @@ -216,7 +216,7 @@ public void putTopicStateRetriableFai

[GitHub] [kafka] machi1990 commented on a diff in pull request #13636: KAFKA-14933: Document Kafka Connect's log level REST APIs added in KIP-495

2023-04-25 Thread via GitHub
machi1990 commented on code in PR #13636: URL: https://github.com/apache/kafka/pull/13636#discussion_r1176378206 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/rest/resources/LoggingResource.java: ## @@ -128,7 +128,7 @@ public Response getLogger(final @PathPar

[GitHub] [kafka] bmscomp commented on a diff in pull request #13627: MINOR: simplify if else conditions in Uuid.compareTo method

2023-04-25 Thread via GitHub
bmscomp commented on code in PR #13627: URL: https://github.com/apache/kafka/pull/13627#discussion_r1176384671 ## .gitignore: ## @@ -35,6 +35,7 @@ Vagrantfile.local config/server-* config/zookeeper-* core/data/* +core/data2/* Review Comment: @divijvaidya Yes it comes fro

[GitHub] [kafka] dajac merged pull request #13603: KAFKA-14869: Bump coordinator value records to flexible versions (KIP…

2023-04-25 Thread via GitHub
dajac merged PR #13603: URL: https://github.com/apache/kafka/pull/13603 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

[jira] [Resolved] (KAFKA-14869) txn and group coordinator downgrade foundation

2023-04-25 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14869?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot resolved KAFKA-14869. - Fix Version/s: 3.2.4 3.1.3 3.0.3 3.4.1

[GitHub] [kafka] bmscomp commented on a diff in pull request #13627: MINOR: simplify if else conditions in Uuid.compareTo method

2023-04-25 Thread via GitHub
bmscomp commented on code in PR #13627: URL: https://github.com/apache/kafka/pull/13627#discussion_r1176409358 ## clients/src/main/java/org/apache/kafka/common/Uuid.java: ## @@ -143,12 +143,6 @@ public int compareTo(Uuid other) { return 1; Review Comment: @divij

[GitHub] [kafka] yashmayya commented on a diff in pull request #13636: KAFKA-14933: Document Kafka Connect's log level REST APIs added in KIP-495

2023-04-25 Thread via GitHub
yashmayya commented on code in PR #13636: URL: https://github.com/apache/kafka/pull/13636#discussion_r1176431515 ## docs/connect.html: ## @@ -328,7 +328,25 @@ REST API GET /- return basic information about the Kafka Connect cluster such as the version of the Connect w

[GitHub] [kafka] showuon commented on a diff in pull request #13514: KAFKA-14752: Kafka examples improvements - consumer changes

2023-04-25 Thread via GitHub
showuon commented on code in PR #13514: URL: https://github.com/apache/kafka/pull/13514#discussion_r1176408614 ## examples/src/main/java/kafka/examples/Consumer.java: ## @@ -76,12 +79,17 @@ public Consumer(String threadName, public void run() { // the consumer inst

[GitHub] [kafka] showuon commented on pull request #13459: KAFKA-14592: Move FeatureCommand to tools

2023-04-25 Thread via GitHub
showuon commented on PR #13459: URL: https://github.com/apache/kafka/pull/13459#issuecomment-1521704802 Failed tests are unrelated: ``` Build / JDK 17 and Scala 2.13 / org.apache.kafka.connect.storage.KafkaStatusBackingStoreFormatTest.putTopicStateRetriableFailure Build / JD

[GitHub] [kafka] showuon merged pull request #13459: KAFKA-14592: Move FeatureCommand to tools

2023-04-25 Thread via GitHub
showuon merged PR #13459: URL: https://github.com/apache/kafka/pull/13459 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[GitHub] [kafka] dajac opened a new pull request, #13638: KAFKA-14462; [11/N] Add CurrentAssignmentBuilder

2023-04-25 Thread via GitHub
dajac opened a new pull request, #13638: URL: https://github.com/apache/kafka/pull/13638 Built on top of https://github.com/apache/kafka/pull/13544. This patch adds CurrentAssignmentBuilder. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementati

[GitHub] [kafka] machi1990 commented on a diff in pull request #13636: KAFKA-14933: Document Kafka Connect's log level REST APIs added in KIP-495

2023-04-25 Thread via GitHub
machi1990 commented on code in PR #13636: URL: https://github.com/apache/kafka/pull/13636#discussion_r1176447760 ## docs/connect.html: ## @@ -328,7 +328,25 @@ REST API GET /- return basic information about the Kafka Connect cluster such as the version of the Connect w

[GitHub] [kafka] divijvaidya commented on a diff in pull request #13627: MINOR: simplify if else conditions in Uuid.compareTo method

2023-04-25 Thread via GitHub
divijvaidya commented on code in PR #13627: URL: https://github.com/apache/kafka/pull/13627#discussion_r1176447810 ## clients/src/main/java/org/apache/kafka/common/Uuid.java: ## @@ -143,12 +143,6 @@ public int compareTo(Uuid other) { return 1; Review Comment: So

[GitHub] [kafka] electrical commented on pull request #12358: KAFKA-13988:Fix mm2 auto.offset.reset=latest not working

2023-04-25 Thread via GitHub
electrical commented on PR #12358: URL: https://github.com/apache/kafka/pull/12358#issuecomment-1521739130 @yuz10 are you able to ping someone to get this moving forward? This must be blocking a lot of people of upgrading existing installs. Thanks. -- This is an automated message f

[GitHub] [kafka] dajac commented on a diff in pull request #13443: KAFKA-14514: Add Sticky Range Assignor on the Server (KIP-848)

2023-04-25 Thread via GitHub
dajac commented on code in PR #13443: URL: https://github.com/apache/kafka/pull/13443#discussion_r1176483468 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/RangeAssignor.java: ## @@ -0,0 +1,261 @@ +/* + * Licensed to the Apache Software Foundation

[jira] [Updated] (KAFKA-14172) bug: State stores lose state when tasks are reassigned under EOS wit…

2023-04-25 Thread Lucas Brutschy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lucas Brutschy updated KAFKA-14172: --- Fix Version/s: 3.5.0 > bug: State stores lose state when tasks are reassigned under EOS wit…

[jira] [Assigned] (KAFKA-14172) bug: State stores lose state when tasks are reassigned under EOS wit…

2023-04-25 Thread Lucas Brutschy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lucas Brutschy reassigned KAFKA-14172: -- Assignee: Guozhang Wang > bug: State stores lose state when tasks are reassigned unde

[jira] [Resolved] (KAFKA-14172) bug: State stores lose state when tasks are reassigned under EOS wit…

2023-04-25 Thread Lucas Brutschy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lucas Brutschy resolved KAFKA-14172. Resolution: Fixed > bug: State stores lose state when tasks are reassigned under EOS wit…

[GitHub] [kafka] dajac commented on a diff in pull request #13443: KAFKA-14514: Add Sticky Range Assignor on the Server (KIP-848)

2023-04-25 Thread via GitHub
dajac commented on code in PR #13443: URL: https://github.com/apache/kafka/pull/13443#discussion_r1176489630 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/RangeAssignor.java: ## @@ -0,0 +1,261 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] C0urante commented on a diff in pull request #13429: KAFKA-14666: Add MM2 in-memory offset translation index for offsets behind replication

2023-04-25 Thread via GitHub
C0urante commented on code in PR #13429: URL: https://github.com/apache/kafka/pull/13429#discussion_r1176509940 ## connect/mirror/src/test/java/org/apache/kafka/connect/mirror/OffsetSyncStoreTest.java: ## @@ -57,52 +57,96 @@ public void testOffsetTranslation() { /

[GitHub] [kafka] C0urante commented on a diff in pull request #13429: KAFKA-14666: Add MM2 in-memory offset translation index for offsets behind replication

2023-04-25 Thread via GitHub
C0urante commented on code in PR #13429: URL: https://github.com/apache/kafka/pull/13429#discussion_r1175063429 ## connect/mirror/src/test/java/org/apache/kafka/connect/mirror/OffsetSyncStoreTest.java: ## @@ -57,52 +58,170 @@ public void testOffsetTranslation() {

[GitHub] [kafka] bmscomp commented on a diff in pull request #13627: MINOR: simplify if else conditions in Uuid.compareTo method

2023-04-25 Thread via GitHub
bmscomp commented on code in PR #13627: URL: https://github.com/apache/kafka/pull/13627#discussion_r1176527874 ## clients/src/main/java/org/apache/kafka/common/Uuid.java: ## @@ -143,12 +143,6 @@ public int compareTo(Uuid other) { return 1; Review Comment: Thanks

[GitHub] [kafka] gharris1727 commented on a diff in pull request #13429: KAFKA-14666: Add MM2 in-memory offset translation index for offsets behind replication

2023-04-25 Thread via GitHub
gharris1727 commented on code in PR #13429: URL: https://github.com/apache/kafka/pull/13429#discussion_r1176536050 ## connect/mirror/src/test/java/org/apache/kafka/connect/mirror/OffsetSyncStoreTest.java: ## @@ -57,52 +58,170 @@ public void testOffsetTranslation() {

[GitHub] [kafka] ijuma commented on pull request #13569: MINOR: Upgrade to Gradle 8.1

2023-04-25 Thread via GitHub
ijuma commented on PR #13569: URL: https://github.com/apache/kafka/pull/13569#issuecomment-1521824170 It's a little odd to create a new PR instead of simply updating the one that's open... -- This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [kafka] bmscomp commented on pull request #13569: MINOR: Upgrade to Gradle 8.1

2023-04-25 Thread via GitHub
bmscomp commented on PR #13569: URL: https://github.com/apache/kafka/pull/13569#issuecomment-1521831677 @ijuma Apologies, may be it's more wise to close the one I created and keep updating this one, I'll update my pull request since it contains also some Gradle plugin upgrades -- Th

[jira] [Commented] (KAFKA-14666) MM2 should translate consumer group offsets behind replication flow

2023-04-25 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17716280#comment-17716280 ] Chris Egerton commented on KAFKA-14666: --- [~mimaison] I believe this should be a re

[GitHub] [kafka] divijvaidya commented on pull request #13135: KAFKA-14633: Reduce data copy & buffer allocation during decompression

2023-04-25 Thread via GitHub
divijvaidya commented on PR #13135: URL: https://github.com/apache/kafka/pull/13135#issuecomment-1521852820 This is ready for review. A summary of the changes is provided below. **On the server:** 1. This PR starts using buffer pools to allocate intermediate buffer which is used by

[jira] [Commented] (KAFKA-14666) MM2 should translate consumer group offsets behind replication flow

2023-04-25 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17716286#comment-17716286 ] Mickael Maison commented on KAFKA-14666: I thought we were further from resoluti

[GitHub] [kafka] divijvaidya commented on a diff in pull request #13135: KAFKA-14633: Reduce data copy & buffer allocation during decompression

2023-04-25 Thread via GitHub
divijvaidya commented on code in PR #13135: URL: https://github.com/apache/kafka/pull/13135#discussion_r1176575715 ## clients/src/main/java/org/apache/kafka/common/utils/ByteBufferInputStream.java: ## @@ -29,6 +30,11 @@ public ByteBufferInputStream(ByteBuffer buffer) {

[GitHub] [kafka] mumrah commented on a diff in pull request #13407: KAFKA-14805 KRaft controller supports pre-migration mode

2023-04-25 Thread via GitHub
mumrah commented on code in PR #13407: URL: https://github.com/apache/kafka/pull/13407#discussion_r1176597177 ## core/src/test/scala/unit/kafka/server/BrokerRegistrationRequestTest.scala: ## @@ -145,25 +146,29 @@ class BrokerRegistrationRequestTest { } @ClusterTest(clust

[jira] [Created] (KAFKA-14934) KafkaClusterTestKit makes FaultHandler accessible

2023-04-25 Thread David Arthur (Jira)
David Arthur created KAFKA-14934: Summary: KafkaClusterTestKit makes FaultHandler accessible Key: KAFKA-14934 URL: https://issues.apache.org/jira/browse/KAFKA-14934 Project: Kafka Issue Type:

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #13544: KAFKA-14462; [9/N] Add RecordHelpers

2023-04-25 Thread via GitHub
jeffkbkim commented on code in PR #13544: URL: https://github.com/apache/kafka/pull/13544#discussion_r1176590727 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/RecordHelpers.java: ## @@ -0,0 +1,371 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[jira] [Commented] (KAFKA-12485) Speed up Consumer#committed by returning cached offsets for owned partitions

2023-04-25 Thread Manyanda Chitimbo (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17716307#comment-17716307 ] Manyanda Chitimbo commented on KAFKA-12485: --- Hi [~ableegoldman] I am current l

[GitHub] [kafka] dajac opened a new pull request, #13639: KAFKA-14462; [12/N] Add GroupMetadataManager and ConsumerGroup

2023-04-25 Thread via GitHub
dajac opened a new pull request, #13639: URL: https://github.com/apache/kafka/pull/13639 This PR is build on top of https://github.com/apache/kafka/pull/13637 and https://github.com/apache/kafka/pull/13638. This PR adds the GroupMetadataManager to the group-coordinator module. This

[GitHub] [kafka] dajac commented on a diff in pull request #13476: KAFKA-14462; [4/N] Add GroupMetadataManager: ConsumerGroups Management, Members Management and Reconciliation Logic

2023-04-25 Thread via GitHub
dajac commented on code in PR #13476: URL: https://github.com/apache/kafka/pull/13476#discussion_r1176631863 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -0,0 +1,873 @@ +/* + * Licensed to the Apache Software Foundation (

[GitHub] [kafka] dajac commented on a diff in pull request #13476: KAFKA-14462; [4/N] Add GroupMetadataManager: ConsumerGroups Management, Members Management and Reconciliation Logic

2023-04-25 Thread via GitHub
dajac commented on code in PR #13476: URL: https://github.com/apache/kafka/pull/13476#discussion_r1176632816 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -0,0 +1,873 @@ +/* + * Licensed to the Apache Software Foundation (

[GitHub] [kafka] dajac commented on a diff in pull request #13476: KAFKA-14462; [4/N] Add GroupMetadataManager: ConsumerGroups Management, Members Management and Reconciliation Logic

2023-04-25 Thread via GitHub
dajac commented on code in PR #13476: URL: https://github.com/apache/kafka/pull/13476#discussion_r1176634255 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -0,0 +1,873 @@ +/* + * Licensed to the Apache Software Foundation (

[GitHub] [kafka] dajac commented on a diff in pull request #13476: KAFKA-14462; [4/N] Add GroupMetadataManager: ConsumerGroups Management, Members Management and Reconciliation Logic

2023-04-25 Thread via GitHub
dajac commented on code in PR #13476: URL: https://github.com/apache/kafka/pull/13476#discussion_r1176634664 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java: ## @@ -0,0 +1,535 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] dajac commented on pull request #13476: KAFKA-14462; [4/N] Add GroupMetadataManager: ConsumerGroups Management, Members Management and Reconciliation Logic

2023-04-25 Thread via GitHub
dajac commented on PR #13476: URL: https://github.com/apache/kafka/pull/13476#issuecomment-1521927635 Closing this PR as I have opened smaller ones with the same code. @jeffkbkim I have addressed some of your last comments in https://github.com/apache/kafka/pull/13639. -- This is an auto

[GitHub] [kafka] dajac closed pull request #13476: KAFKA-14462; [4/N] Add GroupMetadataManager: ConsumerGroups Management, Members Management and Reconciliation Logic

2023-04-25 Thread via GitHub
dajac closed pull request #13476: KAFKA-14462; [4/N] Add GroupMetadataManager: ConsumerGroups Management, Members Management and Reconciliation Logic URL: https://github.com/apache/kafka/pull/13476 -- This is an automated message from the Apache Git Service. To respond to the message, please

Consumer Lag Metrics/ Topic level metrics

2023-04-25 Thread Kafka Life
Dear Kafka Experts Could you please suggest good metrics exporter for consumer lag and topic level metrics apart from Linkedin kafka burrow for the kafka broker cluster.

[GitHub] [kafka] mimaison merged pull request #13636: KAFKA-14933: Document Kafka Connect's log level REST APIs added in KIP-495

2023-04-25 Thread via GitHub
mimaison merged PR #13636: URL: https://github.com/apache/kafka/pull/13636 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[GitHub] [kafka] yashmayya commented on pull request #13636: KAFKA-14933: Document Kafka Connect's log level REST APIs added in KIP-495

2023-04-25 Thread via GitHub
yashmayya commented on PR #13636: URL: https://github.com/apache/kafka/pull/13636#issuecomment-1522043739 Thanks Mickael! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [kafka] jolshan merged pull request #13632: KAFKA-14931: Revert KAFKA-14561 in 3.5

2023-04-25 Thread via GitHub
jolshan merged PR #13632: URL: https://github.com/apache/kafka/pull/13632 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[jira] [Resolved] (KAFKA-14931) Revert KAFKA-14561 in 3.5

2023-04-25 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14931?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justine Olshan resolved KAFKA-14931. Resolution: Fixed > Revert KAFKA-14561 in 3.5 > - > >

[jira] [Updated] (KAFKA-14922) kafka-streams-application-reset deletes topics not belonging to specified application-id

2023-04-25 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14922?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-14922: Labels: beginner needs-kip newbie (was: ) > kafka-streams-application-reset deletes topic

[GitHub] [kafka] dajac merged pull request #13538: KAFKA-14462; [8/N] Add ConsumerGroupMember

2023-04-25 Thread via GitHub
dajac merged PR #13538: URL: https://github.com/apache/kafka/pull/13538 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

[GitHub] [kafka] dajac commented on a diff in pull request #13544: KAFKA-14462; [9/N] Add RecordHelpers

2023-04-25 Thread via GitHub
dajac commented on code in PR #13544: URL: https://github.com/apache/kafka/pull/13544#discussion_r1176791643 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/RecordHelpers.java: ## @@ -0,0 +1,371 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #13544: KAFKA-14462; [9/N] Add RecordHelpers

2023-04-25 Thread via GitHub
jeffkbkim commented on code in PR #13544: URL: https://github.com/apache/kafka/pull/13544#discussion_r1176793376 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/RecordHelpers.java: ## @@ -0,0 +1,371 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #13544: KAFKA-14462; [9/N] Add RecordHelpers

2023-04-25 Thread via GitHub
jeffkbkim commented on code in PR #13544: URL: https://github.com/apache/kafka/pull/13544#discussion_r1176800586 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/RecordHelpers.java: ## @@ -0,0 +1,371 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[jira] [Created] (KAFKA-14935) Wire Protocol Documentation Does Not Explain Header Versioning

2023-04-25 Thread Andrew Thaddeus Martin (Jira)
Andrew Thaddeus Martin created KAFKA-14935: -- Summary: Wire Protocol Documentation Does Not Explain Header Versioning Key: KAFKA-14935 URL: https://issues.apache.org/jira/browse/KAFKA-14935 Pr

[jira] [Updated] (KAFKA-14935) Wire Protocol Documentation Does Not Explain Header Versioning

2023-04-25 Thread Andrew Thaddeus Martin (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14935?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Thaddeus Martin updated KAFKA-14935: --- Description: The documentation for Kafka's wire protocol does not explain ho

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13637: KAFKA-14462; [10/N] Add TargetAssignmentBuilder

2023-04-25 Thread via GitHub
rreddy-22 commented on code in PR #13637: URL: https://github.com/apache/kafka/pull/13637#discussion_r1176822091 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/TargetAssignmentBuilder.java: ## @@ -0,0 +1,327 @@ +/* + * Licensed to the Apache Softw

[GitHub] [kafka] dajac commented on a diff in pull request #13544: KAFKA-14462; [9/N] Add RecordHelpers

2023-04-25 Thread via GitHub
dajac commented on code in PR #13544: URL: https://github.com/apache/kafka/pull/13544#discussion_r1176825997 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/RecordHelpers.java: ## @@ -0,0 +1,371 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

[GitHub] [kafka] mumrah commented on a diff in pull request #13631: KAFKA-14909: check zkMigrationReady tag before migration

2023-04-25 Thread via GitHub
mumrah commented on code in PR #13631: URL: https://github.com/apache/kafka/pull/13631#discussion_r1176825739 ## metadata/src/main/java/org/apache/kafka/controller/QuorumFeatures.java: ## @@ -128,4 +128,27 @@ VersionRange localSupportedFeature(String featureName) { boolean

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13637: KAFKA-14462; [10/N] Add TargetAssignmentBuilder

2023-04-25 Thread via GitHub
rreddy-22 commented on code in PR #13637: URL: https://github.com/apache/kafka/pull/13637#discussion_r1176848867 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/TargetAssignmentBuilder.java: ## @@ -0,0 +1,327 @@ +/* + * Licensed to the Apache Softw

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #13443: KAFKA-14514: Add Sticky Range Assignor on the Server (KIP-848)

2023-04-25 Thread via GitHub
jeffkbkim commented on code in PR #13443: URL: https://github.com/apache/kafka/pull/13443#discussion_r1176631579 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/RangeAssignor.java: ## @@ -0,0 +1,261 @@ +/* + * Licensed to the Apache Software Founda

[GitHub] [kafka] divijvaidya commented on pull request #13284: KAFKA-14718: Fix flaky DedicatedMirrorIntegrationTest

2023-04-25 Thread via GitHub
divijvaidya commented on PR #13284: URL: https://github.com/apache/kafka/pull/13284#issuecomment-150743 Hey @C0urante I haven't forgotten about this PR :) I am stuck right now and would solicit your help here. I have made the changes that you suggested but the below condition is n

[jira] [Updated] (KAFKA-14892) Harmonize package names in storage module

2023-04-25 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14892?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-14892: Fix Version/s: 3.6.0 > Harmonize package names in storage module > ---

[jira] [Created] (KAFKA-14936) Add Grace Period To Stream Table Join

2023-04-25 Thread Walker Carlson (Jira)
Walker Carlson created KAFKA-14936: -- Summary: Add Grace Period To Stream Table Join Key: KAFKA-14936 URL: https://issues.apache.org/jira/browse/KAFKA-14936 Project: Kafka Issue Type: Improve

[GitHub] [kafka] jolshan commented on a diff in pull request #13544: KAFKA-14462; [9/N] Add RecordHelpers

2023-04-25 Thread via GitHub
jolshan commented on code in PR #13544: URL: https://github.com/apache/kafka/pull/13544#discussion_r1176933020 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/RecordHelpers.java: ## @@ -0,0 +1,371 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] jolshan commented on a diff in pull request #13544: KAFKA-14462; [9/N] Add RecordHelpers

2023-04-25 Thread via GitHub
jolshan commented on code in PR #13544: URL: https://github.com/apache/kafka/pull/13544#discussion_r1176936158 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/RecordHelpers.java: ## @@ -0,0 +1,371 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] jolshan commented on a diff in pull request #13544: KAFKA-14462; [9/N] Add RecordHelpers

2023-04-25 Thread via GitHub
jolshan commented on code in PR #13544: URL: https://github.com/apache/kafka/pull/13544#discussion_r1176941034 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/RecordHelpers.java: ## @@ -0,0 +1,371 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[jira] [Commented] (KAFKA-12570) Improve Documentation on COMPACT_ARRAY usage

2023-04-25 Thread Andrew Thaddeus Martin (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17716413#comment-17716413 ] Andrew Thaddeus Martin commented on KAFKA-12570: The documentation of CO

[jira] [Updated] (KAFKA-14172) bug: State stores lose state when tasks are reassigned under EOS wit…

2023-04-25 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-14172: Fix Version/s: 3.4.1 > bug: State stores lose state when tasks are reassigned under EOS wi

[jira] [Updated] (KAFKA-14936) Add Grace Period To Stream Table Join

2023-04-25 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-14936: Labels: kip streams (was: streams) > Add Grace Period To Stream Table Join >

[jira] [Commented] (KAFKA-14935) Wire Protocol Documentation Does Not Explain Header Versioning

2023-04-25 Thread Andrew Thaddeus Martin (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17716418#comment-17716418 ] Andrew Thaddeus Martin commented on KAFKA-14935: In `clients/build/resou

[GitHub] [kafka] philipnee commented on a diff in pull request #13550: KAFKA-14639 - A single partition may be revoked and assign during a single round of rebalance

2023-04-25 Thread via GitHub
philipnee commented on code in PR #13550: URL: https://github.com/apache/kafka/pull/13550#discussion_r1176980400 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java: ## @@ -835,6 +839,8 @@ public void handle(SyncGroupResponse syncRespons

[GitHub] [kafka] philipnee commented on a diff in pull request #13550: KAFKA-14639 - A single partition may be revoked and assign during a single round of rebalance

2023-04-25 Thread via GitHub
philipnee commented on code in PR #13550: URL: https://github.com/apache/kafka/pull/13550#discussion_r1176980677 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java: ## @@ -835,6 +835,7 @@ public void handle(SyncGroupResponse syncRespons

[GitHub] [kafka] philipnee commented on pull request #13550: KAFKA-14639 - A single partition may be revoked and assign during a single round of rebalance

2023-04-25 Thread via GitHub
philipnee commented on PR #13550: URL: https://github.com/apache/kafka/pull/13550#issuecomment-1522355547 Hey @mimaison - Sorry for the late notice. We've been trying to fix this issue for the coming release 3.5. Would it be possible to include this for the 3.5 release? We should be able t

[jira] [Created] (KAFKA-14937) Refactoring for client code to reduce boilerplate

2023-04-25 Thread Kirk True (Jira)
Kirk True created KAFKA-14937: - Summary: Refactoring for client code to reduce boilerplate Key: KAFKA-14937 URL: https://issues.apache.org/jira/browse/KAFKA-14937 Project: Kafka Issue Type: Sub-t

  1   2   >