Vikash Mishra created KAFKA-14923:
-
Summary: Upgrade io.netty_netty-codec for CVE-2022-41881
Key: KAFKA-14923
URL: https://issues.apache.org/jira/browse/KAFKA-14923
Project: Kafka
Issue Type:
Claude Warren created KAFKA-14924:
-
Summary: Kafka DOAP file has an error
Key: KAFKA-14924
URL: https://issues.apache.org/jira/browse/KAFKA-14924
Project: Kafka
Issue Type: Bug
Comp
[
https://issues.apache.org/jira/browse/KAFKA-14923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17714463#comment-17714463
]
Vikash Mishra commented on KAFKA-14923:
---
[Mickael Maison|https://cwiki.apache.org
fvaleri commented on PR #13614:
URL: https://github.com/apache/kafka/pull/13614#issuecomment-1515869259
@vamossagar12 Thanks!
Can you also add this redirection to KAFKA-14705?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
[
https://issues.apache.org/jira/browse/KAFKA-14705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sagar Rao updated KAFKA-14705:
--
Description:
Redirections:
- core/src/main/scala/kafka/tools/JmxTool
- core/src/main/scala/kafka/too
vamossagar12 commented on PR #13614:
URL: https://github.com/apache/kafka/pull/13614#issuecomment-1515894145
Thanks @fvaleri . I did it but initially had thought I would do it after the
merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
dajac commented on code in PR #13537:
URL: https://github.com/apache/kafka/pull/13537#discussion_r1172227215
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/TopicMetadata.java:
##
@@ -0,0 +1,109 @@
+/*
+ * Licensed to the Apache Software Foundation
dajac commented on code in PR #13537:
URL: https://github.com/apache/kafka/pull/13537#discussion_r1172236944
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/Assignment.java:
##
@@ -0,0 +1,144 @@
+/*
+ * Licensed to the Apache Software Foundation (A
dajac commented on code in PR #13537:
URL: https://github.com/apache/kafka/pull/13537#discussion_r1172243757
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/consumer/AssignmentTest.java:
##
@@ -0,0 +1,137 @@
+/*
+ * Licensed to the Apache Software Foundatio
mimaison merged PR #13614:
URL: https://github.com/apache/kafka/pull/13614
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
[
https://issues.apache.org/jira/browse/KAFKA-14922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17714484#comment-17714484
]
Bruno Cadonna commented on KAFKA-14922:
---
I see.
We could add a warning with the l
mimaison commented on PR #13614:
URL: https://github.com/apache/kafka/pull/13614#issuecomment-1515923050
Backported to 3.5 as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
dajac commented on code in PR #13537:
URL: https://github.com/apache/kafka/pull/13537#discussion_r1172250882
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/VersionedMetadata.java:
##
@@ -0,0 +1,85 @@
+/*
+ * Licensed to the Apache Software Foundat
dajac commented on code in PR #13537:
URL: https://github.com/apache/kafka/pull/13537#discussion_r1172252094
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/Assignment.java:
##
@@ -0,0 +1,144 @@
+/*
+ * Licensed to the Apache Software Foundation (A
dajac commented on code in PR #13537:
URL: https://github.com/apache/kafka/pull/13537#discussion_r1172253675
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ClientAssignor.java:
##
@@ -0,0 +1,150 @@
+/*
+ * Licensed to the Apache Software Foundatio
dajac commented on PR #13537:
URL: https://github.com/apache/kafka/pull/13537#issuecomment-1515931229
@jolshan @jeffkbkim Thanks for your comments. I have addressed them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
dajac commented on PR #13596:
URL: https://github.com/apache/kafka/pull/13596#issuecomment-1515975989
@jeffkbkim This PR has failures related to the change. Could you take a look?
```
Build / JDK 11 and Scala 2.13 /
testLoadGroupsAndOffsetsWillIgnoreUnknownMessage() –
kafka.coordinato
dajac commented on PR #13597:
URL: https://github.com/apache/kafka/pull/13597#issuecomment-1515976436
@jeffkbkim This one as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
dajac commented on code in PR #13443:
URL: https://github.com/apache/kafka/pull/13443#discussion_r1172314693
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/RangeAssignor.java:
##
@@ -0,0 +1,240 @@
+/*
+ * Licensed to the Apache Software Foundation
dajac commented on code in PR #13443:
URL: https://github.com/apache/kafka/pull/13443#discussion_r1172321570
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/RangeAssignor.java:
##
@@ -0,0 +1,240 @@
+/*
+ * Licensed to the Apache Software Foundation
dajac commented on code in PR #13443:
URL: https://github.com/apache/kafka/pull/13443#discussion_r1172322335
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/RangeAssignor.java:
##
@@ -0,0 +1,256 @@
+/*
+ * Licensed to the Apache Software Foundation
dajac commented on code in PR #13443:
URL: https://github.com/apache/kafka/pull/13443#discussion_r1172324109
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/assignor/RangeAssignorTest.java:
##
@@ -0,0 +1,499 @@
+/*
+ * Licensed to the Apache Software Founda
dajac commented on code in PR #13443:
URL: https://github.com/apache/kafka/pull/13443#discussion_r1172325053
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/assignor/RangeAssignorTest.java:
##
@@ -0,0 +1,499 @@
+/*
+ * Licensed to the Apache Software Founda
dajac commented on code in PR #13443:
URL: https://github.com/apache/kafka/pull/13443#discussion_r1172325341
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/assignor/RangeAssignorTest.java:
##
@@ -0,0 +1,499 @@
+/*
+ * Licensed to the Apache Software Founda
divijvaidya commented on PR #13619:
URL: https://github.com/apache/kafka/pull/13619#issuecomment-1516093525
Hi @rvansa
Thank you for your first contribution to Apache Kafka! Thanks to you, today
I learnt something new (CRaC).
For an effective discussion on this topic, starting a
Mickael Maison created KAFKA-14925:
--
Summary: The website shouldn't load external resources
Key: KAFKA-14925
URL: https://issues.apache.org/jira/browse/KAFKA-14925
Project: Kafka
Issue Type:
[
https://issues.apache.org/jira/browse/KAFKA-14923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17714541#comment-17714541
]
Yash Mayya commented on KAFKA-14923:
[~vikashmishra0808] looks like [https://github.
rvansa commented on PR #13619:
URL: https://github.com/apache/kafka/pull/13619#issuecomment-1516133197
Sure, thanks for the pointers! I'll go through the docs and compose a
proposal on the mailing list. If you don't mind I'll keep this PR open in the
meantime.
> What is the downside
urbandan commented on code in PR #13429:
URL: https://github.com/apache/kafka/pull/13429#discussion_r1172435439
##
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/OffsetSyncStore.java:
##
@@ -139,10 +171,103 @@ public void close() {
protected void handleRecord(
Hangleton commented on PR #13619:
URL: https://github.com/apache/kafka/pull/13619#issuecomment-1516151278
Hi, Radim,
Thanks for the PR. This would definitely need a KIP.
I am quite curious about the use cases driving this. Some problems I see
with the approach:
- Apache
rvansa commented on PR #13619:
URL: https://github.com/apache/kafka/pull/13619#issuecomment-1516168111
Hi @Hangleton , in this PR I am not addressing the broker but a client.
Since I am not that familiar with the whole project, I am following the
whack-a-mole strategy; in my case I am tryin
jeffkbkim commented on code in PR #13537:
URL: https://github.com/apache/kafka/pull/13537#discussion_r1172502546
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ClientAssignor.java:
##
@@ -0,0 +1,150 @@
+/*
+ * Licensed to the Apache Software Found
dajac commented on code in PR #13537:
URL: https://github.com/apache/kafka/pull/13537#discussion_r1172519824
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ClientAssignor.java:
##
@@ -0,0 +1,150 @@
+/*
+ * Licensed to the Apache Software Foundatio
jeffkbkim commented on code in PR #13537:
URL: https://github.com/apache/kafka/pull/13537#discussion_r1172529291
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ClientAssignor.java:
##
@@ -0,0 +1,150 @@
+/*
+ * Licensed to the Apache Software Found
satishd commented on code in PR #13535:
URL: https://github.com/apache/kafka/pull/13535#discussion_r1172535684
##
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##
@@ -600,6 +622,176 @@ public String toString() {
}
}
+public FetchDataInfo read(Rem
clolov commented on PR #13260:
URL: https://github.com/apache/kafka/pull/13260#issuecomment-1516273036
Hello @mimaison, @ijuma and @cmccabe! Since
[KIP-902](https://cwiki.apache.org/confluence/display/KAFKA/KIP-902%3A+Upgrade+Zookeeper+to+3.8.1)
has been accepted I have rebased this pull re
chia7712 opened a new pull request, #13620:
URL: https://github.com/apache/kafka/pull/13620
#13390 remove the `remote_kraft` and the replacement is `isolated_kraft`
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test co
dengziming commented on PR #13562:
URL: https://github.com/apache/kafka/pull/13562#issuecomment-1516312511
Do you forgot to remove GetOffsetShell.scala and change
`bin/kafka-get-offsets.sh` command?
> KafkaServerTestHarness extends QuorumTestHarness, all of them are written
in Scala
[
https://issues.apache.org/jira/browse/KAFKA-14877?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Divij Vaidya updated KAFKA-14877:
-
Fix Version/s: 3.6.0
> refactor InMemoryLeaderEpochCheckpoint
>
[
https://issues.apache.org/jira/browse/KAFKA-14877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17714594#comment-17714594
]
Divij Vaidya commented on KAFKA-14877:
--
I will pick this up if there is no objectio
[
https://issues.apache.org/jira/browse/KAFKA-14877?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Divij Vaidya reassigned KAFKA-14877:
Assignee: Divij Vaidya
> refactor InMemoryLeaderEpochCheckpoint
> ---
tinaselenge commented on code in PR #13459:
URL: https://github.com/apache/kafka/pull/13459#discussion_r1172577875
##
tools/src/test/java/org/apache/kafka/tools/FeatureCommandTest.java:
##
@@ -0,0 +1,292 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or mo
dajac commented on code in PR #13537:
URL: https://github.com/apache/kafka/pull/13537#discussion_r1172597532
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ClientAssignor.java:
##
@@ -0,0 +1,150 @@
+/*
+ * Licensed to the Apache Software Foundatio
[
https://issues.apache.org/jira/browse/KAFKA-14922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17714597#comment-17714597
]
Jørgen commented on KAFKA-14922:
An _improvement_ would be to only return topics that ex
dengziming commented on code in PR #13555:
URL: https://github.com/apache/kafka/pull/13555#discussion_r1172598460
##
server-common/src/main/java/org/apache/kafka/purgatory/Purgatory.java:
##
@@ -26,10 +26,9 @@
/**
* The purgatory which holds events that have been started, b
jeffkbkim commented on code in PR #13537:
URL: https://github.com/apache/kafka/pull/13537#discussion_r1172600639
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ClientAssignor.java:
##
@@ -0,0 +1,150 @@
+/*
+ * Licensed to the Apache Software Found
mumrah commented on code in PR #13407:
URL: https://github.com/apache/kafka/pull/13407#discussion_r1172621439
##
metadata/src/main/java/org/apache/kafka/controller/metrics/ControllerMetadataMetricsPublisher.java:
##
@@ -115,6 +115,9 @@ private void publishDelta(MetadataDelta del
dajac commented on code in PR #13537:
URL: https://github.com/apache/kafka/pull/13537#discussion_r1172621475
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ClientAssignor.java:
##
@@ -0,0 +1,150 @@
+/*
+ * Licensed to the Apache Software Foundatio
mumrah commented on code in PR #13461:
URL: https://github.com/apache/kafka/pull/13461#discussion_r1172646961
##
metadata/src/main/java/org/apache/kafka/metadata/migration/KRaftMigrationDriver.java:
##
@@ -174,12 +173,12 @@ private boolean areZkBrokersReadyForMigration() {
[
https://issues.apache.org/jira/browse/KAFKA-14923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17714612#comment-17714612
]
Vikash Mishra commented on KAFKA-14923:
---
[~yash.mayya] Awesome, thanks for the det
dajac commented on code in PR #13555:
URL: https://github.com/apache/kafka/pull/13555#discussion_r1172674549
##
server-common/src/main/java/org/apache/kafka/purgatory/Purgatory.java:
##
@@ -26,10 +26,9 @@
/**
* The purgatory which holds events that have been started, but no
jeffkbkim commented on PR #13604:
URL: https://github.com/apache/kafka/pull/13604#issuecomment-1516438325
@dajac i see Selector test failures that pass locally. Can we re-trigger the
build?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
mumrah commented on PR #13461:
URL: https://github.com/apache/kafka/pull/13461#issuecomment-1516441727
> Should we wrap the calls to quotaEntityConsumer.accept (and other
consumers) so that if it throws an exception, we log an ERROR message to log4j
to let us know what failed?
Yes, t
jeffkbkim commented on PR #13603:
URL: https://github.com/apache/kafka/pull/13603#issuecomment-1516453173
@dajac
```
org.apache.kafka.streams.integration.SmokeTestDriverIntegrationTest.
shouldWorkWithRebalance
kafka.api.ConsumerBounceTest.testSubscribeWhenTopicUnavailable()
```
jsancio commented on code in PR #13555:
URL: https://github.com/apache/kafka/pull/13555#discussion_r1172724317
##
server-common/src/main/java/org/apache/kafka/purgatory/DeferredEventPurgatory.java:
##
@@ -26,10 +26,9 @@
/**
* The purgatory which holds events that have been
clolov opened a new pull request, #13621:
URL: https://github.com/apache/kafka/pull/13621
This pull request takes a similar approach as the one outlined in
https://github.com/apache/kafka/pull/13529 to move each mock separately to ease
reviewing the code.
Once https://github.com/apac
clolov commented on PR #13621:
URL: https://github.com/apache/kafka/pull/13621#issuecomment-1516499410
Heya @cadonna! I hope this attempt is what you had in mind? Unless I am
wrong the removals detailed in the pull request are sensible as Mockito should
be returning empty collections for me
dajac commented on code in PR #13555:
URL: https://github.com/apache/kafka/pull/13555#discussion_r1172735940
##
server-common/src/main/java/org/apache/kafka/purgatory/DeferredEventPurgatory.java:
##
@@ -26,10 +26,9 @@
/**
* The purgatory which holds events that have been st
dajac commented on code in PR #13555:
URL: https://github.com/apache/kafka/pull/13555#discussion_r1172738445
##
server-common/src/main/java/org/apache/kafka/purgatory/DeferredEventPurgatory.java:
##
@@ -26,10 +26,9 @@
/**
* The purgatory which holds events that have been st
rondagostino commented on code in PR #13437:
URL: https://github.com/apache/kafka/pull/13437#discussion_r1172661731
##
server-common/src/main/java/org/apache/kafka/server/immutable/ImmutableNavigableSet.java:
##
@@ -0,0 +1,59 @@
+/*
+ * Licensed to the Apache Software Foundation
gharris1727 commented on code in PR #13429:
URL: https://github.com/apache/kafka/pull/13429#discussion_r1172772709
##
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/OffsetSyncStore.java:
##
@@ -139,10 +171,103 @@ public void close() {
protected void handleReco
jsancio commented on code in PR #13555:
URL: https://github.com/apache/kafka/pull/13555#discussion_r1172793737
##
server-common/src/main/java/org/apache/kafka/purgatory/DeferredEventPurgatory.java:
##
@@ -26,10 +26,9 @@
/**
* The purgatory which holds events that have been
rreddy-22 commented on code in PR #13443:
URL: https://github.com/apache/kafka/pull/13443#discussion_r1172824513
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/assignor/RangeAssignorTest.java:
##
@@ -0,0 +1,499 @@
+/*
+ * Licensed to the Apache Software Fo
tinaselenge commented on code in PR #13459:
URL: https://github.com/apache/kafka/pull/13459#discussion_r1172832601
##
tools/src/main/java/org/apache/kafka/tools/FeatureCommand.java:
##
@@ -307,25 +294,24 @@ private static void update(String op, Admin admin,
Map up
jolshan commented on PR #13579:
URL: https://github.com/apache/kafka/pull/13579#issuecomment-1516620151
Many many connect failures still 😔
Failures appear to be unrelated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
jolshan merged PR #13579:
URL: https://github.com/apache/kafka/pull/13579
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
jolshan commented on PR #13579:
URL: https://github.com/apache/kafka/pull/13579#issuecomment-1516624342
Will also cherry-pick to 3.5
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
tinaselenge commented on PR #13459:
URL: https://github.com/apache/kafka/pull/13459#issuecomment-1516631750
@showuon Thank you so much. I have addressed the comments but left couple of
them to clarify first.
--
This is an automated message from the Apache Git Service.
To respond to the m
jsancio commented on code in PR #13555:
URL: https://github.com/apache/kafka/pull/13555#discussion_r1172839235
##
server-common/src/main/java/org/apache/kafka/deferred/DeferredEvent.java:
##
@@ -15,12 +15,12 @@
* limitations under the License.
*/
-package org.apache.kafka.
emissionnebula commented on code in PR #13437:
URL: https://github.com/apache/kafka/pull/13437#discussion_r1172848492
##
server-common/src/test/java/org/apache/kafka/server/immutable/pcollections/PCollectionsImmutableMapTest.java:
##
@@ -225,77 +225,59 @@ public void testDelegat
emissionnebula commented on code in PR #13437:
URL: https://github.com/apache/kafka/pull/13437#discussion_r1172848492
##
server-common/src/test/java/org/apache/kafka/server/immutable/pcollections/PCollectionsImmutableMapTest.java:
##
@@ -225,77 +225,59 @@ public void testDelegat
emissionnebula commented on code in PR #13437:
URL: https://github.com/apache/kafka/pull/13437#discussion_r1172850344
##
server-common/src/test/java/org/apache/kafka/server/immutable/DelegationChecker.java:
##
@@ -139,6 +163,16 @@ public void doFunctionDelegationCheck() {
[
https://issues.apache.org/jira/browse/KAFKA-14916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justine Olshan updated KAFKA-14916:
---
Description:
KAFKA-14561 wrote code that assumed that if a transactional ID was included,
a
[
https://issues.apache.org/jira/browse/KAFKA-14884?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justine Olshan resolved KAFKA-14884.
Resolution: Fixed
> Include check transaction is still ongoing right before append
>
divijvaidya commented on code in PR #13135:
URL: https://github.com/apache/kafka/pull/13135#discussion_r1172881788
##
clients/src/main/java/org/apache/kafka/common/record/CompressionType.java:
##
@@ -90,8 +95,13 @@ public OutputStream wrapForOutput(ByteBufferOutputStream
buffer
divijvaidya commented on code in PR #13135:
URL: https://github.com/apache/kafka/pull/13135#discussion_r1172882018
##
clients/src/main/java/org/apache/kafka/common/record/CompressionType.java:
##
@@ -108,12 +117,18 @@ public OutputStream wrapForOutput(ByteBufferOutputStream
buf
divijvaidya commented on code in PR #13135:
URL: https://github.com/apache/kafka/pull/13135#discussion_r1172883027
##
clients/src/main/java/org/apache/kafka/common/record/CompressionType.java:
##
@@ -126,6 +144,11 @@ public OutputStream wrapForOutput(ByteBufferOutputStream
buff
divijvaidya commented on code in PR #13135:
URL: https://github.com/apache/kafka/pull/13135#discussion_r1172883282
##
clients/src/main/java/org/apache/kafka/common/record/CompressionType.java:
##
@@ -157,7 +186,14 @@ public InputStream wrapForInput(ByteBuffer buffer, byte
messa
divijvaidya commented on code in PR #13135:
URL: https://github.com/apache/kafka/pull/13135#discussion_r1172884561
##
clients/src/main/java/org/apache/kafka/common/utils/ChunkedBytesStream.java:
##
@@ -0,0 +1,211 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
divijvaidya commented on code in PR #13135:
URL: https://github.com/apache/kafka/pull/13135#discussion_r1172889948
##
clients/src/main/java/org/apache/kafka/common/utils/SkippableChunkedBytesStream.java:
##
@@ -0,0 +1,62 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
divijvaidya commented on code in PR #13135:
URL: https://github.com/apache/kafka/pull/13135#discussion_r1172892464
##
clients/src/test/java/org/apache/kafka/common/utils/SkippableChunkedBytesStreamTest.java:
##
@@ -0,0 +1,104 @@
+/*
+ * Licensed to the Apache Software Foundation
cmccabe commented on PR #13572:
URL: https://github.com/apache/kafka/pull/13572#issuecomment-1516694321
Hi all,
Unfortunately I had to revert this. This is a change to our public API since
it will allow multiple Kafka servers to be started on the same port. This kind
of change needs
divijvaidya commented on PR #13572:
URL: https://github.com/apache/kafka/pull/13572#issuecomment-1516728614
Hey @cmccabe, we can have a community discussion over the mailing list but I
am not following one of your statements here.
> since it will allow multiple Kafka servers to be sta
jolshan commented on code in PR #13537:
URL: https://github.com/apache/kafka/pull/13537#discussion_r1172939142
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ClientAssignor.java:
##
@@ -0,0 +1,150 @@
+/*
+ * Licensed to the Apache Software Foundat
jolshan commented on code in PR #13537:
URL: https://github.com/apache/kafka/pull/13537#discussion_r1172939598
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/consumer/ClientAssignorTest.java:
##
@@ -0,0 +1,133 @@
+/*
+ * Licensed to the Apache Software Fou
jolshan commented on code in PR #13537:
URL: https://github.com/apache/kafka/pull/13537#discussion_r1172939909
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/consumer/ClientAssignorTest.java:
##
@@ -0,0 +1,133 @@
+/*
+ * Licensed to the Apache Software Fou
emissionnebula commented on code in PR #13437:
URL: https://github.com/apache/kafka/pull/13437#discussion_r1172848492
##
server-common/src/test/java/org/apache/kafka/server/immutable/pcollections/PCollectionsImmutableMapTest.java:
##
@@ -225,77 +225,59 @@ public void testDelegat
dajac commented on code in PR #13537:
URL: https://github.com/apache/kafka/pull/13537#discussion_r1172946358
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/consumer/ClientAssignorTest.java:
##
@@ -0,0 +1,133 @@
+/*
+ * Licensed to the Apache Software Found
dajac commented on code in PR #13537:
URL: https://github.com/apache/kafka/pull/13537#discussion_r1172945841
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ClientAssignor.java:
##
@@ -0,0 +1,150 @@
+/*
+ * Licensed to the Apache Software Foundatio
jeffkbkim commented on code in PR #13537:
URL: https://github.com/apache/kafka/pull/13537#discussion_r1172953390
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ClientAssignor.java:
##
@@ -0,0 +1,150 @@
+/*
+ * Licensed to the Apache Software Found
[
https://issues.apache.org/jira/browse/KAFKA-14884?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justine Olshan reopened KAFKA-14884:
I'm confused by all my blockers 🤦♀️
> Include check transaction is still ongoing right befor
[
https://issues.apache.org/jira/browse/KAFKA-14904?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justine Olshan resolved KAFKA-14904.
Resolution: Fixed
> Flaky Test kafka.api.TransactionsBounceTest.testWithGroupId()
> -
philipnee commented on PR #12149:
URL: https://github.com/apache/kafka/pull/12149#issuecomment-1516893160
Hey @jolshan - Thanks for the review. i reverted those
documentation/comment changes in the senderTest.java (for the produceResponse
authorization error).
--
This is an automated me
philipnee commented on PR #12149:
URL: https://github.com/apache/kafka/pull/12149#issuecomment-1516893617
Failing tests don't seem to be related.
```
Build / JDK 8 and Scala 2.12 /
testReplicationIsCreatingTopicsUsingProvidedForwardingAdmin() –
org.apache.kafka.connect.mirror.inte
rreddy-22 commented on code in PR #13443:
URL: https://github.com/apache/kafka/pull/13443#discussion_r1173050527
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/RangeAssignor.java:
##
@@ -0,0 +1,240 @@
+/*
+ * Licensed to the Apache Software Founda
szalapski commented on PR #5876:
URL: https://github.com/apache/kafka/pull/5876#issuecomment-1516905377
Sad that this didn't get in.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
cmccabe commented on code in PR #13407:
URL: https://github.com/apache/kafka/pull/13407#discussion_r1173062239
##
core/src/test/scala/integration/kafka/zk/ZkMigrationIntegrationTest.scala:
##
@@ -324,4 +329,29 @@ class ZkMigrationIntegrationTest {
assertTrue(firstProducer
cmccabe commented on code in PR #13407:
URL: https://github.com/apache/kafka/pull/13407#discussion_r1173062692
##
core/src/test/scala/integration/kafka/zk/ZkMigrationIntegrationTest.scala:
##
@@ -324,4 +329,29 @@ class ZkMigrationIntegrationTest {
assertTrue(firstProducer
cmccabe commented on code in PR #13407:
URL: https://github.com/apache/kafka/pull/13407#discussion_r1173066452
##
core/src/test/scala/unit/kafka/server/BrokerRegistrationRequestTest.scala:
##
@@ -145,25 +146,29 @@ class BrokerRegistrationRequestTest {
}
@ClusterTest(clus
cmccabe commented on code in PR #13407:
URL: https://github.com/apache/kafka/pull/13407#discussion_r1173068660
##
metadata/src/main/java/org/apache/kafka/controller/FeatureControlManager.java:
##
@@ -232,13 +248,20 @@ private ApiError updateMetadataVersion(
Consumer rec
1 - 100 of 139 matches
Mail list logo
