cmccabe commented on code in PR #13407:
URL: https://github.com/apache/kafka/pull/13407#discussion_r1173066452
##########
core/src/test/scala/unit/kafka/server/BrokerRegistrationRequestTest.scala:
##########
@@ -145,25 +146,29 @@ class BrokerRegistrationRequestTest {
}
@ClusterTest(clusterType = Type.KRAFT, brokers = 0, controllers = 1,
metadataVersion = MetadataVersion.IBP_3_3_IV3,
- serverProperties = Array(new ClusterConfigProperty(key =
"zookeeper.metadata.migration.enable", value = "true")))
- def testRegisterZkWithKRaftOldMetadataVersion(clusterInstance:
ClusterInstance): Unit = {
+ serverProperties = Array(new ClusterConfigProperty(key =
"zookeeper.metadata.migration.enable", value = "false")))
Review Comment:
Do we have a test of trying to start the controller with
`zookeeper.metadata.migration.enable = true` and a bootstrap MV that's too old?
It should exit the controller, right? (Due to throwing that RuntimeException)?
It would be good to have an integration test of that...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
