[GitHub] [kafka] dajac commented on a diff in pull request #13505: KAFKA-14462; [5/N] Add EventAccumulator

dajac commented on code in PR #13505: URL: https://github.com/apache/kafka/pull/13505#discussion_r1163723563 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/EventAccumulator.java: ## @@ -0,0 +1,256 @@ +/* + * Licensed to the Apache Software Foundati

[GitHub] [kafka] dajac commented on a diff in pull request #13511: KAFKA-14869: ignore unknown record types for coordinators

dajac commented on code in PR #13511: URL: https://github.com/apache/kafka/pull/13511#discussion_r1163731655 ## clients/src/main/java/org/apache/kafka/common/protocol/MessageUtil.java: ## @@ -231,4 +231,38 @@ public static byte[] toVersionPrefixedBytes(final short version, fina

[GitHub] [kafka] rajinisivaram commented on pull request #13539: KAFKA-14891: Fix rack-aware range assignor to assign co-partitioned subsets

rajinisivaram commented on PR #13539: URL: https://github.com/apache/kafka/pull/13539#issuecomment-1504803232 @dajac Thanks for the review. Test failures not related, merging to trunk. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] rajinisivaram merged pull request #13539: KAFKA-14891: Fix rack-aware range assignor to assign co-partitioned subsets

rajinisivaram merged PR #13539: URL: https://github.com/apache/kafka/pull/13539 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.a

[jira] [Resolved] (KAFKA-14891) Fix rack-aware range assignor to improve rack-awareness with co-partitioning

[ https://issues.apache.org/jira/browse/KAFKA-14891?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajini Sivaram resolved KAFKA-14891. Fix Version/s: 3.5.0 Reviewer: David Jacot Resolution: Fixed > Fix rack-aw

[GitHub] [kafka] dajac commented on a diff in pull request #13526: KAFKA-14869: bump coordinator Value records to flexible versions

dajac commented on code in PR #13526: URL: https://github.com/apache/kafka/pull/13526#discussion_r1163741549 ## core/src/test/scala/unit/kafka/coordinator/group/GroupMetadataManagerTest.scala: ## @@ -2466,6 +2467,34 @@ class GroupMetadataManagerTest { verifySerde(version)

[GitHub] [kafka] dajac commented on a diff in pull request #13526: KAFKA-14869: bump coordinator Value records to flexible versions

dajac commented on code in PR #13526: URL: https://github.com/apache/kafka/pull/13526#discussion_r1163746136 ## core/src/main/resources/common/message/TransactionLogValue.json: ## @@ -13,27 +13,29 @@ // See the License for the specific language governing permissions and // lim

[GitHub] [kafka] Hangleton commented on a diff in pull request #13505: KAFKA-14462; [5/N] Add EventAccumulator

Hangleton commented on code in PR #13505: URL: https://github.com/apache/kafka/pull/13505#discussion_r1163756580 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/ConcurrentEventQueue.java: ## @@ -0,0 +1,258 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] miccab commented on a diff in pull request #13534: KAFKA-14054: Handle TimeoutException gracefully

miccab commented on code in PR #13534: URL: https://github.com/apache/kafka/pull/13534#discussion_r1163759932 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java: ## @@ -1195,13 +1195,8 @@ public boolean commitNeeded() {

[GitHub] [kafka] tinaselenge commented on a diff in pull request #13459: KAFKA-14592: Move FeatureCommand to tools

tinaselenge commented on code in PR #13459: URL: https://github.com/apache/kafka/pull/13459#discussion_r1163787618 ## tools/src/main/java/org/apache/kafka/tools/FeatureCommand.java: ## @@ -0,0 +1,331 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more +

[GitHub] [kafka] clolov commented on a diff in pull request #13514: KAFKA-14752: Kafka examples improvements - consumer changes

clolov commented on code in PR #13514: URL: https://github.com/apache/kafka/pull/13514#discussion_r1163804088 ## examples/src/main/java/kafka/examples/Consumer.java: ## @@ -22,96 +22,110 @@ import org.apache.kafka.clients.consumer.ConsumerRecords; import org.apache.kafka.clien

[jira] [Resolved] (KAFKA-14889) RemoteLogManager - allow consumer fetch records from remote storage implementation

[ https://issues.apache.org/jira/browse/KAFKA-14889?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen resolved KAFKA-14889. --- Resolution: Duplicate > RemoteLogManager - allow consumer fetch records from remote storage > imple

[GitHub] [kafka] vamossagar12 commented on a diff in pull request #13530: KAFKA-14858: Handle exceptions thrown from Connector::taskConfigs in Connect's standalone mode

vamossagar12 commented on code in PR #13530: URL: https://github.com/apache/kafka/pull/13530#discussion_r1163797689 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerder.java: ## @@ -296,7 +301,12 @@ public synchronized void restartConnect

[GitHub] [kafka] clolov commented on a diff in pull request #13529: KAFKA-14133: Migrate topology builder mock in TaskManagerTest to mockito

clolov commented on code in PR #13529: URL: https://github.com/apache/kafka/pull/13529#discussion_r1163868654 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java: ## @@ -2895,10 +2871,8 @@ public void shouldNotCommitOnHandleAssignmentIfNoT

[GitHub] [kafka] clolov commented on pull request #12607: KAFKA-14133: Replace EasyMock with Mockito in streams tests

clolov commented on PR #12607: URL: https://github.com/apache/kafka/pull/12607#issuecomment-1504960483 Heya @cadonna, thank you for the review! The approach you have taken in the other PR makes sense to me, so I will aim to open a few pull requests in a similar fashion. What worries you abo

[GitHub] [kafka] dimitarndimitrov commented on a diff in pull request #13432: KAFKA-14821 Implement the listOffsets API with AdminApiDriver

dimitarndimitrov commented on code in PR #13432: URL: https://github.com/apache/kafka/pull/13432#discussion_r1163915187 ## clients/src/main/java/org/apache/kafka/clients/admin/internals/AdminApiDriver.java: ## @@ -260,12 +261,18 @@ public void onFailure( .filter

[GitHub] [kafka] dimitarndimitrov commented on a diff in pull request #13432: KAFKA-14821 Implement the listOffsets API with AdminApiDriver

dimitarndimitrov commented on code in PR #13432: URL: https://github.com/apache/kafka/pull/13432#discussion_r1163919103 ## clients/src/main/java/org/apache/kafka/clients/admin/internals/ListOffsetsHandler.java: ## @@ -0,0 +1,229 @@ +/* + * Licensed to the Apache Software Foundat

[GitHub] [kafka] dimitarndimitrov commented on a diff in pull request #13432: KAFKA-14821 Implement the listOffsets API with AdminApiDriver

dimitarndimitrov commented on code in PR #13432: URL: https://github.com/apache/kafka/pull/13432#discussion_r1163919103 ## clients/src/main/java/org/apache/kafka/clients/admin/internals/ListOffsetsHandler.java: ## @@ -0,0 +1,229 @@ +/* + * Licensed to the Apache Software Foundat

[GitHub] [kafka] dimitarndimitrov commented on a diff in pull request #13432: KAFKA-14821 Implement the listOffsets API with AdminApiDriver

dimitarndimitrov commented on code in PR #13432: URL: https://github.com/apache/kafka/pull/13432#discussion_r1163924668 ## clients/src/main/java/org/apache/kafka/clients/admin/internals/ListOffsetsHandler.java: ## @@ -0,0 +1,229 @@ +/* + * Licensed to the Apache Software Foundat

[GitHub] [kafka] dimitarndimitrov commented on a diff in pull request #13432: KAFKA-14821 Implement the listOffsets API with AdminApiDriver

dimitarndimitrov commented on code in PR #13432: URL: https://github.com/apache/kafka/pull/13432#discussion_r1163925697 ## clients/src/main/java/org/apache/kafka/clients/admin/OffsetSpec.java: ## @@ -33,7 +33,7 @@ public static class TimestampSpec extends OffsetSpec {

[GitHub] [kafka] dimitarndimitrov commented on a diff in pull request #13432: KAFKA-14821 Implement the listOffsets API with AdminApiDriver

dimitarndimitrov commented on code in PR #13432: URL: https://github.com/apache/kafka/pull/13432#discussion_r1163925933 ## clients/src/main/java/org/apache/kafka/clients/admin/internals/ListOffsetsHandler.java: ## @@ -0,0 +1,229 @@ +/* + * Licensed to the Apache Software Foundat

[jira] (KAFKA-14705) Remove redirection/deprecated classes

[ https://issues.apache.org/jira/browse/KAFKA-14705 ] Federico Valeri deleted comment on KAFKA-14705: - was (Author: fvaleri): https://github.com/apache/kafka/pull/13195 > Remove redirection/deprecated classes > -

[GitHub] [kafka] fvaleri commented on pull request #13122: KAFKA-14594: Move LogDirsCommand to tools module

fvaleri commented on PR #13122: URL: https://github.com/apache/kafka/pull/13122#issuecomment-1505038104 @clolov can you address the comments from Mickael so that we can have a chance to merge it in time for 3.5.0? -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [kafka] fvaleri commented on pull request #13158: KAFKA-14647: Moving TopicFilter to server-common/utils

fvaleri commented on PR #13158: URL: https://github.com/apache/kafka/pull/13158#issuecomment-1505050897 @ijuma these classes are currently used in both tools and core modules. Not all tools will be migrated in the same release and we also have the deprecated MirrorMaker 1, which we do not p

[GitHub] [kafka] showuon commented on a diff in pull request #13535: [DRAFT] KAFKA-9579 Fetch implementation for records in the remote storage through a specific purgatory.

showuon commented on code in PR #13535: URL: https://github.com/apache/kafka/pull/13535#discussion_r1163946844 ## core/src/main/java/kafka/log/remote/RemoteLogReader.java: ## @@ -0,0 +1,70 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contribu

[jira] [Updated] (KAFKA-14705) Remove redirections and deprecated classes

[ https://issues.apache.org/jira/browse/KAFKA-14705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Federico Valeri updated KAFKA-14705: Summary: Remove redirections and deprecated classes (was: Remove redirection/deprecated c

[jira] [Updated] (KAFKA-14705) Remove redirections and deprecated classes

[ https://issues.apache.org/jira/browse/KAFKA-14705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Federico Valeri updated KAFKA-14705: Description: Redirections: - core/kafka.tools.JmxTool - core/kafka.tools.StateChangeLogMe

[jira] [Updated] (KAFKA-14705) Remove tools redirections and deprecations

[ https://issues.apache.org/jira/browse/KAFKA-14705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Federico Valeri updated KAFKA-14705: Description: Redirections: - core/kafka.tools.JmxTool - core/kafka.tools.StateChangeLogMe

[jira] [Updated] (KAFKA-14705) Remove tools redirections and deprecations

[ https://issues.apache.org/jira/browse/KAFKA-14705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Federico Valeri updated KAFKA-14705: Summary: Remove tools redirections and deprecations (was: Remove redirections and depreca

[GitHub] [kafka] showuon commented on a diff in pull request #13525: KAFKA-14883: Expose `observer` state in KRaft metrics

showuon commented on code in PR #13525: URL: https://github.com/apache/kafka/pull/13525#discussion_r1163964084 ## raft/src/test/java/org/apache/kafka/raft/internals/KafkaRaftMetricsTest.java: ## @@ -137,14 +137,14 @@ public void shouldRecordNonVoterQuorumState() throws IOExcept

[GitHub] [kafka] dajac merged pull request #13520: KAFKA-14462; [4/N] Add Group, Record and Result

dajac merged PR #13520: URL: https://github.com/apache/kafka/pull/13520 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

[GitHub] [kafka] dajac opened a new pull request, #13544: KAFKA-14462; [9/N] Add RecordHelpers

dajac opened a new pull request, #13544: URL: https://github.com/apache/kafka/pull/13544 Built on top of https://github.com/apache/kafka/pull/13538. This patch adds RecordHelpers. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [

[GitHub] [kafka] dajac commented on a diff in pull request #13524: MINOR: Refine `PartitionAssignor` server-side interface

dajac commented on code in PR #13524: URL: https://github.com/apache/kafka/pull/13524#discussion_r1163998694 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/AssignmentMemberSpec.java: ## @@ -37,29 +39,30 @@ public class AssignmentMemberSpec {

[GitHub] [kafka] dajac commented on a diff in pull request #13524: MINOR: Refine `PartitionAssignor` server-side interface

dajac commented on code in PR #13524: URL: https://github.com/apache/kafka/pull/13524#discussion_r1163998872 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/AssignmentMemberSpec.java: ## @@ -29,37 +31,53 @@ public class AssignmentMemberSpec {

[GitHub] [kafka] dajac commented on pull request #13240: KAFKA-14690: Add topic IDs to the OffsetCommit API version 9

dajac commented on PR #13240: URL: https://github.com/apache/kafka/pull/13240#issuecomment-1505120343 @Hangleton There are a few conflicts. Could you please rebase the PR? I plan to make another pass on it afterwards. -- This is an automated message from the Apache Git Service. To respond

[GitHub] [kafka] Hangleton commented on pull request #13240: KAFKA-14690: Add topic IDs to the OffsetCommit API version 9

Hangleton commented on PR #13240: URL: https://github.com/apache/kafka/pull/13240#issuecomment-1505154651 > @Hangleton There are a few conflicts. Could you please rebase the PR? I plan to make another pass on it afterwards. Sure, done. Thanks! -- This is an automated message from t

[GitHub] [kafka] yashmayya commented on a diff in pull request #13530: KAFKA-14858: Handle exceptions thrown from Connector::taskConfigs in Connect's standalone mode

yashmayya commented on code in PR #13530: URL: https://github.com/apache/kafka/pull/13530#discussion_r1164035350 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerder.java: ## @@ -229,7 +229,12 @@ private synchronized void putConnectorConf

[GitHub] [kafka] emissionnebula commented on pull request #13280: KAFKA-14735: Improve KRaft metadata image change performance at high …

emissionnebula commented on PR #13280: URL: https://github.com/apache/kafka/pull/13280#issuecomment-1505166712 > I don't see strong motivation for having that in the name. Most of the examples you have simply documented it which we can as well. Yeah, correct. Scala doesn't include it

[GitHub] [kafka] urbandan commented on a diff in pull request #13433: KAFKA-12694, KAFKA-3910: Add cyclic schema support, fix default struct values

urbandan commented on code in PR #13433: URL: https://github.com/apache/kafka/pull/13433#discussion_r1164053318 ## connect/api/src/test/java/org/apache/kafka/connect/data/SchemaBuilderTest.java: ## @@ -36,6 +38,255 @@ public class SchemaBuilderTest { private static final St

[GitHub] [kafka] Hangleton commented on a diff in pull request #13524: MINOR: Refine `PartitionAssignor` server-side interface

Hangleton commented on code in PR #13524: URL: https://github.com/apache/kafka/pull/13524#discussion_r1164088051 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/common/TopicIdToPartition.java: ## @@ -0,0 +1,76 @@ +/* + * Licensed to the Apache Software Foun

[jira] [Updated] (KAFKA-14593) Move LeaderElectionCommand to tools

[ https://issues.apache.org/jira/browse/KAFKA-14593?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison updated KAFKA-14593: --- Fix Version/s: (was: 3.5.0) > Move LeaderElectionCommand to tools >

[jira] [Updated] (KAFKA-14585) Move StorageTool to tools

[ https://issues.apache.org/jira/browse/KAFKA-14585?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison updated KAFKA-14585: --- Fix Version/s: (was: 3.5.0) > Move StorageTool to tools > - > >

[jira] [Updated] (KAFKA-14596) Move TopicCommand to tools

[ https://issues.apache.org/jira/browse/KAFKA-14596?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison updated KAFKA-14596: --- Fix Version/s: (was: 3.5.0) > Move TopicCommand to tools > -- >

[GitHub] [kafka] Hangleton commented on pull request #13214: KAFKA-14577: Move the scala ConsoleProducer from core to tools module

Hangleton commented on PR #13214: URL: https://github.com/apache/kafka/pull/13214#issuecomment-1505225119 > @Hangleton should we move to RecordReader interface now and then call another round of review? Also note [this comment](https://github.com/apache/kafka/pull/13454#issuecomment-1497842

[jira] [Updated] (KAFKA-12622) Automate LICENSE file validation

[ https://issues.apache.org/jira/browse/KAFKA-12622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison updated KAFKA-12622: --- Fix Version/s: 3.6.0 (was: 3.5.0) > Automate LICENSE file validation

[GitHub] [kafka] fvaleri commented on pull request #13195: Minor: Add JmxTool note and redirection

fvaleri commented on PR #13195: URL: https://github.com/apache/kafka/pull/13195#issuecomment-1505280658 @mimaison I also added the missing wrapper scripts for this tool as specified in KIP-906 and changed the system tests to use it. With this there is no more reference to the generic kafka-

[jira] [Updated] (KAFKA-14705) Remove tools redirections and deprecations

[ https://issues.apache.org/jira/browse/KAFKA-14705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Federico Valeri updated KAFKA-14705: Description: Redirections: - core/src/main/scala/kafka/tools/JmxTool - core/src/main/scal

[jira] [Updated] (KAFKA-14705) Remove tools redirections and deprecations

[ https://issues.apache.org/jira/browse/KAFKA-14705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Federico Valeri updated KAFKA-14705: Description: Redirections: - core/src/main/scala/kafka/tools/JmxTool - core/src/main/scal

[jira] [Updated] (KAFKA-14705) Remove tools redirections and deprecations

[ https://issues.apache.org/jira/browse/KAFKA-14705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Federico Valeri updated KAFKA-14705: Affects Version/s: (was: 3.5.0) > Remove tools redirections and deprecations > ---

[jira] [Updated] (KAFKA-14705) Remove all tools redirections and deprecations

[ https://issues.apache.org/jira/browse/KAFKA-14705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Federico Valeri updated KAFKA-14705: Summary: Remove all tools redirections and deprecations (was: Remove tools redirections a

[jira] [Comment Edited] (KAFKA-14592) Move FeatureCommand to tools

[ https://issues.apache.org/jira/browse/KAFKA-14592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17689019#comment-17689019 ] Federico Valeri edited comment on KAFKA-14592 at 4/12/23 1:48 PM:

[jira] [Comment Edited] (KAFKA-14582) Move JmxTool to tools

[ https://issues.apache.org/jira/browse/KAFKA-14582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17683838#comment-17683838 ] Federico Valeri edited comment on KAFKA-14582 at 4/12/23 1:53 PM:

[GitHub] [kafka] vamossagar12 commented on a diff in pull request #13530: KAFKA-14858: Handle exceptions thrown from Connector::taskConfigs in Connect's standalone mode

vamossagar12 commented on code in PR #13530: URL: https://github.com/apache/kafka/pull/13530#discussion_r1164182093 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerderTest.java: ## @@ -402,6 +403,44 @@ public void testRestartConnectorFai

[GitHub] [kafka] vamossagar12 commented on a diff in pull request #13530: KAFKA-14858: Handle exceptions thrown from Connector::taskConfigs in Connect's standalone mode

vamossagar12 commented on code in PR #13530: URL: https://github.com/apache/kafka/pull/13530#discussion_r1164183743 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerder.java: ## @@ -229,7 +229,12 @@ private synchronized void putConnectorC

[jira] [Resolved] (KAFKA-14890) Kafka initiates shutdown due to connectivity problem with Zookeeper and FatalExitError from ChangeNotificationProcessorThread

[ https://issues.apache.org/jira/browse/KAFKA-14890?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ron Dagostino resolved KAFKA-14890. --- Resolution: Duplicate Duplicate of https://issues.apache.org/jira/browse/KAFKA-14887 > Kafk

[GitHub] [kafka] vamossagar12 commented on a diff in pull request #11433: KAFKA-13295: Avoiding Transation timeouts arising due to long restora…

vamossagar12 commented on code in PR #11433: URL: https://github.com/apache/kafka/pull/11433#discussion_r1164262483 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -342,7 +342,18 @@ public void handleAssignment(final Map> activeTasks

[GitHub] [kafka] vamossagar12 commented on a diff in pull request #11433: KAFKA-13295: Avoiding Transation timeouts arising due to long restora…

vamossagar12 commented on code in PR #11433: URL: https://github.com/apache/kafka/pull/11433#discussion_r1164262483 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -342,7 +342,18 @@ public void handleAssignment(final Map> activeTasks

[GitHub] [kafka] dimitarndimitrov commented on a diff in pull request #13432: KAFKA-14821 Implement the listOffsets API with AdminApiDriver

dimitarndimitrov commented on code in PR #13432: URL: https://github.com/apache/kafka/pull/13432#discussion_r1164285539 ## clients/src/main/java/org/apache/kafka/clients/admin/internals/AdminApiDriver.java: ## @@ -260,12 +261,29 @@ public void onFailure( .filter

[GitHub] [kafka] satishd commented on a diff in pull request #13535: [DRAFT] KAFKA-9579 Fetch implementation for records in the remote storage through a specific purgatory.

satishd commented on code in PR #13535: URL: https://github.com/apache/kafka/pull/13535#discussion_r1164325078 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -1083,48 +1095,100 @@ class ReplicaManager(val config: KafkaConfig, fetchPartitionStatus += (

[GitHub] [kafka] satishd commented on a diff in pull request #13535: [DRAFT] KAFKA-9579 Fetch implementation for records in the remote storage through a specific purgatory.

satishd commented on code in PR #13535: URL: https://github.com/apache/kafka/pull/13535#discussion_r1164328159 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -1196,17 +1252,45 @@ class ReplicaManager(val config: KafkaConfig, _: FencedLeaderEpoc

[GitHub] [kafka] clolov commented on pull request #13122: KAFKA-14594: Move LogDirsCommand to tools module

clolov commented on PR #13122: URL: https://github.com/apache/kafka/pull/13122#issuecomment-1505525910 Yes, sorry, this feel off my radar. You will have a next commit tomorrow morning! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] jolshan commented on a diff in pull request #13391: KAFKA-14561: Improve transactions experience for older clients by ensuring ongoing transaction

jolshan commented on code in PR #13391: URL: https://github.com/apache/kafka/pull/13391#discussion_r1164335669 ## core/src/main/scala/kafka/server/KafkaRequestHandler.scala: ## @@ -69,20 +108,52 @@ class KafkaRequestHandler(id: Int, completeShutdown() retur

[GitHub] [kafka] jolshan commented on a diff in pull request #13391: KAFKA-14561: Improve transactions experience for older clients by ensuring ongoing transaction

jolshan commented on code in PR #13391: URL: https://github.com/apache/kafka/pull/13391#discussion_r1164335669 ## core/src/main/scala/kafka/server/KafkaRequestHandler.scala: ## @@ -69,20 +108,52 @@ class KafkaRequestHandler(id: Int, completeShutdown() retur

[GitHub] [kafka] jolshan commented on pull request #13391: KAFKA-14561: Improve transactions experience for older clients by ensuring ongoing transaction

jolshan commented on PR #13391: URL: https://github.com/apache/kafka/pull/13391#issuecomment-1505528988 I realized I didn't push sorry :( Just pushed now. I will also look at that failure some more today. -- This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [kafka] jeffkbkim commented on pull request #13524: MINOR: Refine `PartitionAssignor` server-side interface

jeffkbkim commented on PR #13524: URL: https://github.com/apache/kafka/pull/13524#issuecomment-1505542589 > We need to add a way to provide the racks. One way would be to augment AssignmentTopicMetadata with them. Another way would be to pass ClusterDescriber interface to PartitionAssignor#

[GitHub] [kafka] C0urante merged pull request #13494: MINOR: update the batch size connect task metrics documentation

C0urante merged PR #13494: URL: https://github.com/apache/kafka/pull/13494 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[GitHub] [kafka] mjsax commented on a diff in pull request #13477: KAFKA-7499: Handle serialization error in ProductionExceptionHandler

mjsax commented on code in PR #13477: URL: https://github.com/apache/kafka/pull/13477#discussion_r1163702670 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/RecordCollectorImpl.java: ## @@ -213,6 +212,31 @@ public void send(final String topic,

[GitHub] [kafka] mjsax commented on a diff in pull request #13477: KAFKA-7499: Handle serialization error in ProductionExceptionHandler

mjsax commented on code in PR #13477: URL: https://github.com/apache/kafka/pull/13477#discussion_r1164381176 ## streams/src/main/java/org/apache/kafka/streams/errors/ProductionExceptionHandler.java: ## @@ -34,6 +35,18 @@ public interface ProductionExceptionHandler extends Confi

[jira] [Updated] (KAFKA-14209) Optimize stream stream self join to use single state store

[ https://issues.apache.org/jira/browse/KAFKA-14209?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-14209: Labels: kip (was: ) > Optimize stream stream self join to use single state store > --

[GitHub] [kafka] junrao commented on a diff in pull request #13391: KAFKA-14561: Improve transactions experience for older clients by ensuring ongoing transaction

junrao commented on code in PR #13391: URL: https://github.com/apache/kafka/pull/13391#discussion_r1164392731 ## core/src/main/scala/kafka/server/KafkaRequestHandler.scala: ## @@ -69,20 +108,52 @@ class KafkaRequestHandler(id: Int, completeShutdown() return

[jira] [Updated] (KAFKA-14209) Optimize stream stream self join to use single state store

[ https://issues.apache.org/jira/browse/KAFKA-14209?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-14209: Description: KIP-862: [https://cwiki.apache.org/confluence/display/KAFKA/KIP-862%3A+Self-

[GitHub] [kafka] jolshan commented on a diff in pull request #13391: KAFKA-14561: Improve transactions experience for older clients by ensuring ongoing transaction

jolshan commented on code in PR #13391: URL: https://github.com/apache/kafka/pull/13391#discussion_r1164399008 ## core/src/main/scala/kafka/server/KafkaRequestHandler.scala: ## @@ -69,20 +108,52 @@ class KafkaRequestHandler(id: Int, completeShutdown() retur

[GitHub] [kafka] jolshan commented on pull request #13391: KAFKA-14561: Improve transactions experience for older clients by ensuring ongoing transaction

jolshan commented on PR #13391: URL: https://github.com/apache/kafka/pull/13391#issuecomment-1505622263 Found the issue -- we didn't correctly handle disconnects which would cause NPEs and force close the producer. Pushed the code to handle disconnects -- locally I did not see the issue aft

[GitHub] [kafka] C0urante commented on pull request #13453: KAFKA-12525: Ignoring Stale status statuses when reading from Status …

C0urante commented on PR #13453: URL: https://github.com/apache/kafka/pull/13453#issuecomment-1505626455 @vamossagar12 I'm a little confused by this comment: > I chose to take this route as it appeared to me that the check doesn't really harm much. Isn't the harm here that we i

[GitHub] [kafka] cmccabe commented on pull request #13521: MINOR: Add tests verifying leadership during and after reassignments in KRaft mode

cmccabe commented on PR #13521: URL: https://github.com/apache/kafka/pull/13521#issuecomment-1505631320 Thanks for tackling this! Question about the first test: > First, it adds a test that makes sure we handle what happens when a reassignment completes and none of the new repl

[GitHub] [kafka] hachikuji commented on a diff in pull request #13536: KAFKA-14462; [6/N] Update Records

hachikuji commented on code in PR #13536: URL: https://github.com/apache/kafka/pull/13536#discussion_r1164424570 ## group-coordinator/src/main/resources/common/message/ConsumerGroupCurrentMemberAssignmentValue.json: ## @@ -22,16 +22,29 @@ "fields": [ { "name": "MemberEpo

[GitHub] [kafka] junrao commented on a diff in pull request #13391: KAFKA-14561: Improve transactions experience for older clients by ensuring ongoing transaction

junrao commented on code in PR #13391: URL: https://github.com/apache/kafka/pull/13391#discussion_r1164424805 ## core/src/main/scala/kafka/server/KafkaRequestHandler.scala: ## @@ -69,20 +108,52 @@ class KafkaRequestHandler(id: Int, completeShutdown() return

[GitHub] [kafka] C0urante commented on a diff in pull request #13530: KAFKA-14858: Handle exceptions thrown from Connector::taskConfigs in Connect's standalone mode

C0urante commented on code in PR #13530: URL: https://github.com/apache/kafka/pull/13530#discussion_r1164425895 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerder.java: ## @@ -229,7 +229,12 @@ private synchronized void putConnectorConfi

[GitHub] [kafka] jolshan commented on a diff in pull request #13391: KAFKA-14561: Improve transactions experience for older clients by ensuring ongoing transaction

jolshan commented on code in PR #13391: URL: https://github.com/apache/kafka/pull/13391#discussion_r1164431328 ## core/src/main/scala/kafka/server/KafkaRequestHandler.scala: ## @@ -69,20 +108,52 @@ class KafkaRequestHandler(id: Int, completeShutdown() retur

[GitHub] [kafka] mjsax commented on a diff in pull request #13534: KAFKA-14054: Handle TimeoutException gracefully

mjsax commented on code in PR #13534: URL: https://github.com/apache/kafka/pull/13534#discussion_r1164442798 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java: ## @@ -1195,13 +1195,8 @@ public boolean commitNeeded() {

[GitHub] [kafka] cmccabe commented on pull request #12196: KAFKA-14084: Implement SCRAM support in KRaft

cmccabe commented on PR #12196: URL: https://github.com/apache/kafka/pull/12196#issuecomment-1505668648 superseded by #13114 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [kafka] cmccabe closed pull request #12196: KAFKA-14084: Implement SCRAM support in KRaft

cmccabe closed pull request #12196: KAFKA-14084: Implement SCRAM support in KRaft URL: https://github.com/apache/kafka/pull/12196 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [kafka] junrao commented on a diff in pull request #13391: KAFKA-14561: Improve transactions experience for older clients by ensuring ongoing transaction

junrao commented on code in PR #13391: URL: https://github.com/apache/kafka/pull/13391#discussion_r1164445859 ## core/src/main/scala/kafka/server/KafkaRequestHandler.scala: ## @@ -69,20 +108,52 @@ class KafkaRequestHandler(id: Int, completeShutdown() return

[GitHub] [kafka] andymg3 commented on pull request #13521: MINOR: Add tests verifying leadership during and after reassignments in KRaft mode

andymg3 commented on PR #13521: URL: https://github.com/apache/kafka/pull/13521#issuecomment-1505671376 > Thanks for tackling this! > > Question about the first test: > > > First, it adds a test that makes sure we handle what happens when a reassignment completes and none of th

[GitHub] [kafka] cmccabe closed pull request #12776: KAFKA-14327: Unify KRaft snapshot generation between broker and controller

cmccabe closed pull request #12776: KAFKA-14327: Unify KRaft snapshot generation between broker and controller URL: https://github.com/apache/kafka/pull/12776 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [kafka] jolshan commented on a diff in pull request #13391: KAFKA-14561: Improve transactions experience for older clients by ensuring ongoing transaction

jolshan commented on code in PR #13391: URL: https://github.com/apache/kafka/pull/13391#discussion_r1164431328 ## core/src/main/scala/kafka/server/KafkaRequestHandler.scala: ## @@ -69,20 +108,52 @@ class KafkaRequestHandler(id: Int, completeShutdown() retur

[GitHub] [kafka] cmccabe commented on pull request #12776: KAFKA-14327: Unify KRaft snapshot generation between broker and controller

cmccabe commented on PR #12776: URL: https://github.com/apache/kafka/pull/12776#issuecomment-1505672282 I split this PR into a lot of PRs and they are now all in. So time to close this! Thanks, all. -- This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [kafka] jolshan commented on a diff in pull request #13391: KAFKA-14561: Improve transactions experience for older clients by ensuring ongoing transaction

jolshan commented on code in PR #13391: URL: https://github.com/apache/kafka/pull/13391#discussion_r1164460056 ## core/src/main/scala/kafka/server/KafkaRequestHandler.scala: ## @@ -69,20 +108,52 @@ class KafkaRequestHandler(id: Int, completeShutdown() retur

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13443: KAFKA-14514: Add Server Side Sticky Range Assignor (KIP-848)

rreddy-22 commented on code in PR #13443: URL: https://github.com/apache/kafka/pull/13443#discussion_r1164463357 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/AssignmentMemberSpec.java: ## @@ -37,29 +40,28 @@ public class AssignmentMemberSpec {

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13443: KAFKA-14514: Add Server Side Sticky Range Assignor (KIP-848)

rreddy-22 commented on code in PR #13443: URL: https://github.com/apache/kafka/pull/13443#discussion_r1164463758 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/GroupAssignment.java: ## @@ -35,6 +35,10 @@ public GroupAssignment( this.membe

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13443: KAFKA-14514: Add Server Side Sticky Range Assignor (KIP-848)

rreddy-22 commented on code in PR #13443: URL: https://github.com/apache/kafka/pull/13443#discussion_r1164465796 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/ServerSideStickyRangeAssignor.java: ## @@ -0,0 +1,257 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] C0urante commented on a diff in pull request #13465: KAFKA-14368: Connect offset write REST API

C0urante commented on code in PR #13465: URL: https://github.com/apache/kafka/pull/13465#discussion_r1164465874 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Worker.java: ## @@ -114,6 +127,7 @@ public class Worker { public static final long CONNECTOR_G

[jira] [Updated] (KAFKA-14897) 3.4.0 release notes do not mention fixing KAFKA-14696

[ https://issues.apache.org/jira/browse/KAFKA-14897?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gray updated KAFKA-14897: - Description: According to KAFKA-14696, CVE-2023-25194 was addressed in version 3.4.0 but I see nothing about the

[jira] [Updated] (KAFKA-14897) 3.4.0 release notes do not mention fixing KAFKA-14696

[ https://issues.apache.org/jira/browse/KAFKA-14897?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gray updated KAFKA-14897: - Summary: 3.4.0 release notes do not mention fixing KAFKA-14696 (was: 3.4.0 release notes does not mention fixin

[jira] [Created] (KAFKA-14897) 3.4.0 release notes does not mention fixing KAFKA-14696

Gray created KAFKA-14897: Summary: 3.4.0 release notes does not mention fixing KAFKA-14696 Key: KAFKA-14897 URL: https://issues.apache.org/jira/browse/KAFKA-14897 Project: Kafka Issue Type: Task

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13443: KAFKA-14514: Add Server Side Sticky Range Assignor (KIP-848)

rreddy-22 commented on code in PR #13443: URL: https://github.com/apache/kafka/pull/13443#discussion_r1164469564 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/ServerSideStickyRangeAssignor.java: ## @@ -0,0 +1,257 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13443: KAFKA-14514: Add Server Side Sticky Range Assignor (KIP-848)

rreddy-22 commented on code in PR #13443: URL: https://github.com/apache/kafka/pull/13443#discussion_r1164470089 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/ServerSideStickyRangeAssignor.java: ## @@ -0,0 +1,257 @@ +/* + * Licensed to the Apache

[jira] [Updated] (KAFKA-14897) 3.4.0 release notes do not mention fixing KAFKA-14696

[ https://issues.apache.org/jira/browse/KAFKA-14897?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gray updated KAFKA-14897: - Description: According to KAFKA-14696, CVE-2023-25194 was addressed in version 3.4.0 but I see nothing about the

[GitHub] [kafka] junrao commented on a diff in pull request #13391: KAFKA-14561: Improve transactions experience for older clients by ensuring ongoing transaction

junrao commented on code in PR #13391: URL: https://github.com/apache/kafka/pull/13391#discussion_r1164476174 ## core/src/main/scala/kafka/server/KafkaRequestHandler.scala: ## @@ -69,20 +108,52 @@ class KafkaRequestHandler(id: Int, completeShutdown() return

[jira] [Created] (KAFKA-14898) [ MirrorMaker ] sync.topic.configs.enabled not working as expected

Srinivas Boga created KAFKA-14898: - Summary: [ MirrorMaker ] sync.topic.configs.enabled not working as expected Key: KAFKA-14898 URL: https://issues.apache.org/jira/browse/KAFKA-14898 Project: Kafka

  1   2   3   >