clolov commented on code in PR #13529:
URL: https://github.com/apache/kafka/pull/13529#discussion_r1163868654
##########
streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java:
##########
@@ -2895,10 +2871,8 @@ public void
shouldNotCommitOnHandleAssignmentIfNoTaskClosed() {
expect(activeTaskCreator.createTasks(anyObject(),
eq(Collections.emptyMap()))).andReturn(Collections.emptySet());
expect(standbyTaskCreator.createTasks(eq(assignmentStandby))).andReturn(singletonList(task10));
expect(standbyTaskCreator.createTasks(eq(Collections.emptyMap()))).andReturn(Collections.emptySet());
- topologyBuilder.addSubscribedTopicsFromAssignment(eq(asList(t1p0)),
anyString());
Review Comment:
Is the idea here that since we do not rely on the return value from this
method you do not want to verify this interaction? I noticed that earlier in
the pull request we do verify interactions of this type.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
