vcrfxia commented on code in PR #13274:
URL: https://github.com/apache/kafka/pull/13274#discussion_r1124151220
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KeyValueStoreMaterializer.java:
##
@@ -48,20 +55,30 @@ public StoreBuilder>
materialize() {
pierDipi commented on PR #13325:
URL: https://github.com/apache/kafka/pull/13325#issuecomment-1453176497
It seems that test failures are not related
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
jiafu1115 opened a new pull request, #13335:
URL: https://github.com/apache/kafka/pull/13335
Hi Team:
https://issues.apache.org/jira/projects/KAFKA/issues/KAFKA-14768
This PR is draft one which adopt the proposal 2 which solve the issue 2
which I mentioned in the JIRA
(2) ca
[
https://issues.apache.org/jira/browse/KAFKA-14768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17696089#comment-17696089
]
fujian commented on KAFKA-14768:
Hi [~showuon]:
I create another PR : [KAFKA-14768: ad
[
https://issues.apache.org/jira/browse/KAFKA-14768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17695956#comment-17695956
]
fujian edited comment on KAFKA-14768 at 3/3/23 8:56 AM:
Hi [~sh
jiafu1115 commented on PR #13335:
URL: https://github.com/apache/kafka/pull/13335#issuecomment-1453191584
@showuon here is the another proposal to solve part of the issues. thanks
for your comment about this proposal.
--
This is an automated message from the Apache Git Service.
To respond
[
https://issues.apache.org/jira/browse/KAFKA-14768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17696089#comment-17696089
]
fujian edited comment on KAFKA-14768 at 3/3/23 9:13 AM:
Hi [~sh
chia7712 commented on code in PR #13327:
URL: https://github.com/apache/kafka/pull/13327#discussion_r1124201822
##
core/src/main/scala/kafka/server/KafkaConfig.scala:
##
@@ -678,7 +678,7 @@ object KafkaConfig {
"start from " + MaxReservedBrokerIdProp + " + 1."
val MessageM
urbandan commented on PR #10566:
URL: https://github.com/apache/kafka/pull/10566#issuecomment-1453223698
@C0urante Yes, you are right about the short-circuit, but it is caused by
the defaultValue ref equals. Which means that my previous code works with your
latest proposal, but this one doe
lucasbru opened a new pull request, #13336:
URL: https://github.com/apache/kafka/pull/13336
The test was leaking memory via Mockito internals. Piggybacking an update to
JUnit5.
### Test strategy
Ran the tests 10,000 times.
Before:
![image](https://user-images.github
lucasbru commented on PR #13336:
URL: https://github.com/apache/kafka/pull/13336#issuecomment-1453283942
@cadonna Could you have a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
lucasbru commented on PR #13318:
URL: https://github.com/apache/kafka/pull/13318#issuecomment-1453303374
We had a failure of `Build / JDK 11 and Scala 2.13 /
org.apache.kafka.streams.integration.PauseResumeIntegrationTest.[1] true`. I'm
pretty sure that one was not flaky before. Any chance
mimaison commented on PR #13328:
URL: https://github.com/apache/kafka/pull/13328#issuecomment-1453366283
None of the test failures are related to this change, all tests pass locally
so merging to trunk.
--
This is an automated message from the Apache Git Service.
To respond to the message
mimaison merged PR #13328:
URL: https://github.com/apache/kafka/pull/13328
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
[
https://issues.apache.org/jira/browse/KAFKA-14745?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mickael Maison resolved KAFKA-14745.
Fix Version/s: 3.5.0
Resolution: Fixed
> MirrorSourceConnector keeps creating Repli
Hangleton commented on PR #13240:
URL: https://github.com/apache/kafka/pull/13240#issuecomment-1453452130
The integration test `MirrorConnectorsIntegrationBaseTest` is failing due to
unknown topic id detected from the admin client. I am looking into it.
--
This is an automated message fro
edoardocomar commented on PR #13113:
URL: https://github.com/apache/kafka/pull/13113#issuecomment-1453510691
bump @mimaison @rajinisivaram @tombentley @ijuma
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
Proven Provenzano created KAFKA-14775:
-
Summary: Support SCRAM for broker to controller authentication
Key: KAFKA-14775
URL: https://issues.apache.org/jira/browse/KAFKA-14775
Project: Kafka
Hangleton commented on PR #13240:
URL: https://github.com/apache/kafka/pull/13240#issuecomment-1453619279
Used v8 for AlterConsumerGroupOffsets in the admin client and added
corresponding unit and integration tests. `MirrorConnectorsIntegrationBaseTest`
is now successful.
--
This is an a
Proven Provenzano created KAFKA-14776:
-
Summary: Update SCRAM system tests to run with KRaft
Key: KAFKA-14776
URL: https://issues.apache.org/jira/browse/KAFKA-14776
Project: Kafka
Issue T
Hangleton commented on code in PR #13240:
URL: https://github.com/apache/kafka/pull/13240#discussion_r1124559198
##
clients/src/main/java/org/apache/kafka/common/requests/OffsetCommitResponse.java:
##
@@ -167,8 +213,24 @@ public Builder addPartitions(
}
publ
Hangleton commented on code in PR #13240:
URL: https://github.com/apache/kafka/pull/13240#discussion_r1124559198
##
clients/src/main/java/org/apache/kafka/common/requests/OffsetCommitResponse.java:
##
@@ -167,8 +213,24 @@ public Builder addPartitions(
}
publ
[
https://issues.apache.org/jira/browse/KAFKA-14649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Egerton updated KAFKA-14649:
--
Fix Version/s: 3.4.1
> Failures instantiating Connect plugins hides other plugins from REST AP
pprovenzano commented on code in PR #13114:
URL: https://github.com/apache/kafka/pull/13114#discussion_r1124583449
##
core/src/main/scala/kafka/server/metadata/BrokerMetadataPublisher.scala:
##
@@ -221,6 +223,21 @@ class BrokerMetadataPublisher(
s"quotas in ${deltaNam
vvcephei commented on code in PR #13274:
URL: https://github.com/apache/kafka/pull/13274#discussion_r1124670079
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KeyValueStoreMaterializer.java:
##
@@ -48,20 +55,30 @@ public StoreBuilder>
materialize() {
philipnee commented on PR #13269:
URL: https://github.com/apache/kafka/pull/13269#issuecomment-1453770724
There's a bunch of failing DedicatedMirrorIntegrationTest - most likely
unrelated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log o
viktorsomogyi commented on code in PR #12992:
URL: https://github.com/apache/kafka/pull/12992#discussion_r1124689076
##
clients/src/main/java/org/apache/kafka/common/config/provider/EnvVarConfigProvider.java:
##
@@ -0,0 +1,94 @@
+/*
+ * Licensed to the Apache Software Foundation
philipnee commented on PR #13269:
URL: https://github.com/apache/kafka/pull/13269#issuecomment-1453776408
@cadonna - Thanks for the feedback there. I added the EOS check before the
checkpoint. I also made a bunch of changes to the tests. To make things
obvious, I added a comment to these
viktorsomogyi commented on code in PR #12992:
URL: https://github.com/apache/kafka/pull/12992#discussion_r1124689076
##
clients/src/main/java/org/apache/kafka/common/config/provider/EnvVarConfigProvider.java:
##
@@ -0,0 +1,94 @@
+/*
+ * Licensed to the Apache Software Foundation
viktorsomogyi commented on code in PR #12992:
URL: https://github.com/apache/kafka/pull/12992#discussion_r1124689076
##
clients/src/main/java/org/apache/kafka/common/config/provider/EnvVarConfigProvider.java:
##
@@ -0,0 +1,94 @@
+/*
+ * Licensed to the Apache Software Foundation
pprovenzano commented on PR #13114:
URL: https://github.com/apache/kafka/pull/13114#issuecomment-1453878000
I've added the MetadataVersion fixes with tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
dajac commented on code in PR #13231:
URL: https://github.com/apache/kafka/pull/13231#discussion_r1124792127
##
clients/src/main/java/org/apache/kafka/common/requests/AddPartitionsToTxnRequest.java:
##
@@ -34,22 +43,38 @@ public class AddPartitionsToTxnRequest extends
AbstractR
jolshan commented on code in PR #13231:
URL: https://github.com/apache/kafka/pull/13231#discussion_r1124830314
##
clients/src/test/java/org/apache/kafka/common/requests/AddPartitionsToTxnResponseTest.java:
##
@@ -58,42 +65,75 @@ public void setUp() {
errorsMap.put(tp2,
cmccabe commented on code in PR #13114:
URL: https://github.com/apache/kafka/pull/13114#discussion_r1124830672
##
metadata/src/test/java/org/apache/kafka/image/ScramImageTest.java:
##
@@ -0,0 +1,161 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+
jolshan commented on code in PR #13231:
URL: https://github.com/apache/kafka/pull/13231#discussion_r1124831349
##
clients/src/test/java/org/apache/kafka/common/requests/AddPartitionsToTxnResponseTest.java:
##
@@ -58,42 +65,75 @@ public void setUp() {
errorsMap.put(tp2,
jolshan commented on code in PR #13231:
URL: https://github.com/apache/kafka/pull/13231#discussion_r1124831869
##
core/src/main/scala/kafka/coordinator/transaction/TransactionCoordinator.scala:
##
@@ -317,6 +322,34 @@ class TransactionCoordinator(txnConfig: TransactionConfig,
[
https://issues.apache.org/jira/browse/KAFKA-9234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax reassigned KAFKA-9234:
--
Assignee: Ganesh Sahu (was: Manasvi Gupta)
> Consider using @Nullable and @Nonnull an
[
https://issues.apache.org/jira/browse/KAFKA-9234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17696249#comment-17696249
]
Matthias J. Sax commented on KAFKA-9234:
{quote}I just joined the community this
guozhangwang commented on PR #13269:
URL: https://github.com/apache/kafka/pull/13269#issuecomment-1453914588
Sorry for jumping into this PR late @philipnee , for this ticket, we have
fixed it in the new state updater thread
([KAFKA-10199](https://issues.apache.org/jira/browse/KAFKA-10199).
philipnee commented on PR #12038:
URL: https://github.com/apache/kafka/pull/12038#issuecomment-1453914893
Well, not "hard to reproduce", I have not had luck to reproduce it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
guozhangwang merged PR #13336:
URL: https://github.com/apache/kafka/pull/13336
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.ap
philipnee commented on PR #13269:
URL: https://github.com/apache/kafka/pull/13269#issuecomment-1453919620
Oh yeah, I was wondering about that, too - it's up to you. We can abandon
this and wait for 10199 to be completed.
--
This is an automated message from the Apache Git Service.
To resp
philipnee commented on PR #13269:
URL: https://github.com/apache/kafka/pull/13269#issuecomment-1453921659
i took a peek at it because @mjsax mentioned it is easy to work on.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
cmccabe merged PR #13114:
URL: https://github.com/apache/kafka/pull/13114
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
philipnee closed pull request #13269: KAFKA-12634 enforce checkpoint after
restoration
URL: https://github.com/apache/kafka/pull/13269
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
guozhangwang commented on PR #13318:
URL: https://github.com/apache/kafka/pull/13318#issuecomment-1453957529
> We had a failure of Build / JDK 11 and Scala 2.13 /
org.apache.kafka.streams.integration.PauseResumeIntegrationTest.[1] true. I'm
pretty sure that one was not flaky before. Any cha
[
https://issues.apache.org/jira/browse/KAFKA-14748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17696279#comment-17696279
]
Guozhang Wang commented on KAFKA-14748:
---
For table-table FK left-joins, if we have
guozhangwang merged PR #13082:
URL: https://github.com/apache/kafka/pull/13082
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.ap
guozhangwang commented on PR #13301:
URL: https://github.com/apache/kafka/pull/13301#issuecomment-1453981950
Got it, thanks for confirming. The rule of thumb is that for any code
potentially in production, we would make sure they have test coverage. So as
long as we could make it to cover t
cmccabe commented on PR #13114:
URL: https://github.com/apache/kafka/pull/13114#issuecomment-1453998511
follow-ons:
https://issues.apache.org/jira/browse/KAFKA-14765
https://issues.apache.org/jira/browse/KAFKA-14775
https://issues.apache.org/jira/browse/KAFKA-14776
--
This is an
cmccabe opened a new pull request, #13337:
URL: https://github.com/apache/kafka/pull/13337
This PR refactors MetadataPublisher's interface a bit. There is now a
handleControllerChange callback. This is something that some publishers might
want. A good example is ZkMigrationClient.
Th
cmccabe commented on PR #13332:
URL: https://github.com/apache/kafka/pull/13332#issuecomment-1454000670
Let me split out the MetadataPublisher refactoring part.
https://github.com/apache/kafka/pull/13337
--
This is an automated message from the Apache Git Service.
To respond to the mess
cmccabe commented on PR #13331:
URL: https://github.com/apache/kafka/pull/13331#issuecomment-1454006628
Fix checkstyle
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
guozhangwang commented on code in PR #13330:
URL: https://github.com/apache/kafka/pull/13330#discussion_r1124915057
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ProtocolRequestManager.java:
##
@@ -0,0 +1,118 @@
+package org.apache.kafka.clients.consumer.i
lucasbru commented on code in PR #13318:
URL: https://github.com/apache/kafka/pull/13318#discussion_r1124916956
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdater.java:
##
@@ -312,16 +305,20 @@ private void
addToExceptionsAndFailedTasksThe
jolshan commented on code in PR #13231:
URL: https://github.com/apache/kafka/pull/13231#discussion_r1124925652
##
core/src/test/scala/unit/kafka/coordinator/transaction/TransactionCoordinatorTest.scala:
##
@@ -1185,4 +1213,8 @@ class TransactionCoordinatorTest {
def errorsCal
C0urante commented on PR #10566:
URL: https://github.com/apache/kafka/pull/10566#issuecomment-1454040953
Ah thanks @urbandan, that helps. It's worth noting that the latest example
test case is probably missing calls to actually set the default value for the
schema builder instances? (Things
jolshan commented on code in PR #13231:
URL: https://github.com/apache/kafka/pull/13231#discussion_r1124937664
##
clients/src/main/java/org/apache/kafka/common/requests/AddPartitionsToTxnResponse.java:
##
@@ -80,45 +105,44 @@ topicName, new
AddPartitionsToTxnPartitionResultColl
[
https://issues.apache.org/jira/browse/KAFKA-9234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17696300#comment-17696300
]
Adam edited comment on KAFKA-9234 at 3/3/23 8:04 PM:
-
I'd like to chi
[
https://issues.apache.org/jira/browse/KAFKA-9234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17696300#comment-17696300
]
Adam commented on KAFKA-9234:
-
I'd like to chip in: Since the last PR there has been an effor
[
https://issues.apache.org/jira/browse/KAFKA-9234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17696300#comment-17696300
]
Adam edited comment on KAFKA-9234 at 3/3/23 8:05 PM:
-
I'd like to chi
pprovenzano opened a new pull request, #13338:
URL: https://github.com/apache/kafka/pull/13338
Implement KIP-900
Update kafka-storage to be able to add SCRAM records to the bootstrap
metadata file at format time so that SCRAM is enabled at initial start of KRaft
cluster.
*More
[
https://issues.apache.org/jira/browse/KAFKA-9234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17696306#comment-17696306
]
Matthias J. Sax commented on KAFKA-9234:
Thanks for the pointer – I am not famili
[
https://issues.apache.org/jira/browse/KAFKA-14084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Proven Provenzano reassigned KAFKA-14084:
-
Assignee: Proven Provenzano (was: Colin McCabe)
> Support SCRAM when using KRa
[
https://issues.apache.org/jira/browse/KAFKA-14084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17696309#comment-17696309
]
Proven Provenzano commented on KAFKA-14084:
---
Base support without bootstrap su
[
https://issues.apache.org/jira/browse/KAFKA-14765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17696311#comment-17696311
]
Proven Provenzano commented on KAFKA-14765:
---
PR [13114 |https://github.com/apa
[
https://issues.apache.org/jira/browse/KAFKA-14748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17696313#comment-17696313
]
Matthias J. Sax commented on KAFKA-14748:
-
Yes, the behavior would change. But m
[
https://issues.apache.org/jira/browse/KAFKA-13882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17696324#comment-17696324
]
ASF GitHub Bot commented on KAFKA-13882:
mjsax commented on PR #410:
URL: https:
jolshan commented on code in PR #13231:
URL: https://github.com/apache/kafka/pull/13231#discussion_r1125017580
##
clients/src/test/java/org/apache/kafka/common/requests/RequestResponseTest.java:
##
@@ -2598,12 +2604,37 @@ private OffsetsForLeaderEpochResponse
createLeaderEpochR
philipnee commented on code in PR #12813:
URL: https://github.com/apache/kafka/pull/12813#discussion_r1125051927
##
clients/src/main/java/org/apache/kafka/clients/NetworkClient.java:
##
@@ -753,7 +756,8 @@ public static AbstractResponse parseResponse(ByteBuffer
responseBuffer,
dejan2609 opened a new pull request, #13339:
URL: https://github.com/apache/kafka/pull/13339
Related links:
- zinc release notes: https://github.com/sbt/zinc/releases/tag/v1.8.0
- gradle release notes: https://github.com/gradle/gradle/releases/tag/v8.0.2
- gradle diff:
vcrfxia opened a new pull request, #13340:
URL: https://github.com/apache/kafka/pull/13340
(This PR is stacked on https://github.com/apache/kafka/pull/13292 -- only
the last commit needs to be reviewed separately.)
Adds integration tests for the new versioned stores introduced in
[KI
satishd merged PR #13304:
URL: https://github.com/apache/kafka/pull/13304
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
ijuma commented on PR #13339:
URL: https://github.com/apache/kafka/pull/13339#issuecomment-1454394562
Thanks for the PR. I think the following workaround where we use `:` is no
longer required:
https://github.com/apache/kafka/blob/trunk/build.gradle#L685
This is the PR where it
jeffkbkim commented on code in PR #13329:
URL: https://github.com/apache/kafka/pull/13329#discussion_r1125367811
##
core/src/test/scala/unit/kafka/server/ConsumerGroupHeartbeatRequestTest.scala:
##
@@ -54,6 +54,20 @@ class ConsumerGroupHeartbeatRequestTest(cluster:
ClusterInsta
ijuma commented on code in PR #13116:
URL: https://github.com/apache/kafka/pull/13116#discussion_r1125408496
##
metadata/src/main/java/org/apache/kafka/controller/ControllerRequestContext.java:
##
@@ -42,19 +45,39 @@ public static OptionalLong requestTimeoutMsToDeadlineNs(
76 matches
Mail list logo
