[GitHub] [kafka] urbandan commented on pull request #10566: KAFKA-12694 Avoid schema mismatch DataException when validating default values

[via GitHub]

urbandan commented on PR #10566:
URL: https://github.com/apache/kafka/pull/10566#issuecomment-1453223698

   @C0urante Yes, you are right about the short-circuit, but it is caused by 
the defaultValue ref equals. Which means that my previous code works with your 
latest proposal, but this one doesn't (infinite loop):
   
   SchemaBuilder builder1 = SchemaBuilder.struct()
       .field("f1", Schema.BOOLEAN_SCHEMA);
   Struct defaultValue1 = new Struct(builder);
   defaultValue1.put("f1", true);
   
   SchemaBuilder builder2 = SchemaBuilder.struct()
       .field("f1", Schema.BOOLEAN_SCHEMA);
   Struct defaultValue2 = new Struct(builder);
   defaultValue2.put("f1", true);
   
   assertEquals(builder1, builder2);


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org