[jira] [Commented] (KAFKA-13771) Support to explicitly delete delegationTokens that have expired but have not been automatically cleaned up

[ https://issues.apache.org/jira/browse/KAFKA-13771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17694399#comment-17694399 ] RivenSun commented on KAFKA-13771: -- [~showuon]  Thanks a lot! > Support to explicitly

[jira] [Resolved] (KAFKA-13771) Support to explicitly delete delegationTokens that have expired but have not been automatically cleaned up

[ https://issues.apache.org/jira/browse/KAFKA-13771?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] RivenSun resolved KAFKA-13771. -- Resolution: Resolved > Support to explicitly delete delegationTokens that have expired but have not >

[GitHub] [kafka] yashmayya commented on a diff in pull request #13276: KAFKA-14732: Use an exponential backoff retry mechanism while reconfiguring connector tasks

yashmayya commented on code in PR #13276: URL: https://github.com/apache/kafka/pull/13276#discussion_r1119636919 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/distributed/DistributedHerderTest.java: ## @@ -3694,6 +3694,54 @@ public void shouldThrowWhenStartA

[GitHub] [kafka] yashmayya opened a new pull request, #13317: MINOR: ExponentialBackoff Javadoc improvements

yashmayya opened a new pull request, #13317: URL: https://github.com/apache/kafka/pull/13317 - Rendered Javadoc before: https://user-images.githubusercontent.com/23502577/221804392-c203ea98-bc9b-43e1-83ff-817c70337945.png";> - Rendered Javadoc after: https://user-images.githu

[GitHub] [kafka] yashmayya commented on pull request #13317: MINOR: ExponentialBackoff Javadoc improvements

yashmayya commented on PR #13317: URL: https://github.com/apache/kafka/pull/13317#issuecomment-1447823925 cc @C0urante - I've split this off from https://github.com/apache/kafka/pull/13276 -- This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [kafka] Hangleton commented on a diff in pull request #13240: KAFKA-14690: Add topic IDs to OffsetCommit API and propagate for request version >= 9

Hangleton commented on code in PR #13240: URL: https://github.com/apache/kafka/pull/13240#discussion_r1119798298 ## clients/src/main/resources/common/message/OffsetCommitRequest.json: ## @@ -47,8 +49,10 @@ "about": "The time period in ms to retain the offset." }, { "

[GitHub] [kafka] Hangleton commented on pull request #13240: KAFKA-14690: Add topic IDs to OffsetCommit API and propagate for request version >= 9

Hangleton commented on PR #13240: URL: https://github.com/apache/kafka/pull/13240#issuecomment-1447864999 Thanks for review David. Updating the PR to enforce the exclusive use of topic IDs from version 9 and adding the integration test you mentioned. Thanks for the guidance! -- This is a

[GitHub] [kafka] edoardocomar merged pull request #13291: KAFKA-14742: Throttle connectors in ExactlyOnceSourceIntegrationTest to fix flakey OOMEs

edoardocomar merged PR #13291: URL: https://github.com/apache/kafka/pull/13291 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.ap

[GitHub] [kafka] Hangleton commented on pull request #13312: KAFKA-14766: Improve performance of VarInt encoding and decoding

Hangleton commented on PR #13312: URL: https://github.com/apache/kafka/pull/13312#issuecomment-1447962623 Thanks for the PR. It is interesting that unrolling the loop while keeping the same underlying logic yields this increase in throughput for writing varints. A few questions: - Wh

[GitHub] [kafka] nizhikov commented on pull request #13247: KAFKA-14595 Move value objects of ReassignPartitionsCommand to java

nizhikov commented on PR #13247: URL: https://github.com/apache/kafka/pull/13247#issuecomment-1448178059 @mimaison New classes moved to tools. Please, share your opinion - should I continue work on this task and move task logic to java? Or we will merge current changes and then mov

[GitHub] [kafka] divijvaidya commented on pull request #13285: KAFKA-13874 Avoid synchronization in SocketServer metrics

divijvaidya commented on PR #13285: URL: https://github.com/apache/kafka/pull/13285#issuecomment-1448210313 Hey @chia7712 > the mutable ArrayBuffer won't be modified after it is created I have a different view of this. Please correct me if I am wrong. The number of network

[GitHub] [kafka] divijvaidya commented on pull request #13284: KAFKA-14718: Make MirrorMaker startup synchronously depend on connector start

divijvaidya commented on PR #13284: URL: https://github.com/apache/kafka/pull/13284#issuecomment-1448267997 Thank you for the detailed explanation @C0urante! > so this doesn't really buy us much right now. Oops, my bad! I did not notice that. > this only guarantees that c

[GitHub] [kafka] C0urante merged pull request #13317: MINOR: ExponentialBackoff Javadoc improvements

C0urante merged PR #13317: URL: https://github.com/apache/kafka/pull/13317 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[GitHub] [kafka] chia7712 commented on pull request #13285: KAFKA-13874 Avoid synchronization in SocketServer metrics

chia7712 commented on PR #13285: URL: https://github.com/apache/kafka/pull/13285#issuecomment-1448290193 > Consider the following scenario which will go wrong with the changes in this PR: @divijvaidya thanks for nice explanation. You are right. I will adopt the solution#1 - reduce t

[GitHub] [kafka] divijvaidya commented on pull request #13312: KAFKA-14766: Improve performance of VarInt encoding and decoding

divijvaidya commented on PR #13312: URL: https://github.com/apache/kafka/pull/13312#issuecomment-1448299260 > It is interesting that unrolling the loop while keeping the same underlying logic yields this increase in throughput for writing varints Yes, indeed. In non hotspot code paths

[GitHub] [kafka] C0urante merged pull request #13193: KAFKA-14659 source-record-write-[rate|total] metrics include filtered records

C0urante merged PR #13193: URL: https://github.com/apache/kafka/pull/13193 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Resolved] (KAFKA-14659) source-record-write-[rate|total] metrics include filtered records

[ https://issues.apache.org/jira/browse/KAFKA-14659?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton resolved KAFKA-14659. --- Resolution: Fixed > source-record-write-[rate|total] metrics include filtered records >

[jira] [Updated] (KAFKA-14659) source-record-write-[rate|total] metrics include filtered records

[ https://issues.apache.org/jira/browse/KAFKA-14659?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton updated KAFKA-14659: -- Fix Version/s: 3.5.0 > source-record-write-[rate|total] metrics include filtered records > ---

[GitHub] [kafka] divijvaidya commented on pull request #13312: KAFKA-14766: Improve performance of VarInt encoding and decoding

divijvaidya commented on PR #13312: URL: https://github.com/apache/kafka/pull/13312#issuecomment-1448306949 Tagging a few folks who may be interested in reviewing this: @ijuma @jasonk000 @hachikuji. Kindly review when you get an opportunity. -- This is an automated message from the Apache

[jira] [Updated] (KAFKA-14659) source-record-write-[rate|total] metrics include filtered records

[ https://issues.apache.org/jira/browse/KAFKA-14659?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton updated KAFKA-14659: -- Fix Version/s: 3.4.1 > source-record-write-[rate|total] metrics include filtered records > ---

[jira] [Updated] (KAFKA-14659) source-record-write-[rate|total] metrics include filtered records

[ https://issues.apache.org/jira/browse/KAFKA-14659?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton updated KAFKA-14659: -- Fix Version/s: 3.3.3 > source-record-write-[rate|total] metrics include filtered records > ---

[GitHub] [kafka] divijvaidya commented on pull request #12620: KAFKA-14206: upgrade zookeeper version to 3.7.1

divijvaidya commented on PR #12620: URL: https://github.com/apache/kafka/pull/12620#issuecomment-1448325538 Completing the conversation here, in case someone comes around reading this old thread. We have a new KIP and a PR for Zk migration to 3.8.1 which would hopefully land in 3.5.

[GitHub] [kafka] ijuma commented on a diff in pull request #13312: KAFKA-14766: Improve performance of VarInt encoding and decoding

ijuma commented on code in PR #13312: URL: https://github.com/apache/kafka/pull/13312#discussion_r1120217103 ## clients/src/main/java/org/apache/kafka/common/utils/ByteUtils.java: ## @@ -292,29 +415,66 @@ public static double readDouble(ByteBuffer buffer) { * @param buffer

[GitHub] [kafka] ijuma commented on pull request #13316: MINOR: srcJar should depend on processMessages task

ijuma commented on PR #13316: URL: https://github.com/apache/kafka/pull/13316#issuecomment-1448363891 Test failures are unrelated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[GitHub] [kafka] ijuma merged pull request #13316: MINOR: srcJar should depend on processMessages task

ijuma merged PR #13316: URL: https://github.com/apache/kafka/pull/13316 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

[GitHub] [kafka] C0urante commented on a diff in pull request #13276: KAFKA-14732: Use an exponential backoff retry mechanism while reconfiguring connector tasks

C0urante commented on code in PR #13276: URL: https://github.com/apache/kafka/pull/13276#discussion_r1120259483 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/distributed/DistributedHerderTest.java: ## @@ -3694,6 +3694,54 @@ public void shouldThrowWhenStartAn

[GitHub] [kafka] C0urante merged pull request #13276: KAFKA-14732: Use an exponential backoff retry mechanism while reconfiguring connector tasks

C0urante merged PR #13276: URL: https://github.com/apache/kafka/pull/13276 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Updated] (KAFKA-14732) Use an exponential backoff retry mechanism while reconfiguring connector tasks

[ https://issues.apache.org/jira/browse/KAFKA-14732?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton updated KAFKA-14732: -- Fix Version/s: 3.5.0 > Use an exponential backoff retry mechanism while reconfiguring connecto

[GitHub] [kafka] yashmayya commented on a diff in pull request #13276: KAFKA-14732: Use an exponential backoff retry mechanism while reconfiguring connector tasks

yashmayya commented on code in PR #13276: URL: https://github.com/apache/kafka/pull/13276#discussion_r1119640881 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/distributed/DistributedHerderTest.java: ## @@ -3694,6 +3694,54 @@ public void shouldThrowWhenStartA

[GitHub] [kafka] divijvaidya commented on a diff in pull request #13312: KAFKA-14766: Improve performance of VarInt encoding and decoding

divijvaidya commented on code in PR #13312: URL: https://github.com/apache/kafka/pull/13312#discussion_r1120323557 ## clients/src/main/java/org/apache/kafka/common/utils/ByteUtils.java: ## @@ -150,17 +151,32 @@ public static void writeUnsignedIntLE(byte[] buffer, int offset, in

[GitHub] [kafka] divijvaidya commented on a diff in pull request #13312: KAFKA-14766: Improve performance of VarInt encoding and decoding

divijvaidya commented on code in PR #13312: URL: https://github.com/apache/kafka/pull/13312#discussion_r1120328865 ## clients/src/main/java/org/apache/kafka/common/utils/ByteUtils.java: ## @@ -227,17 +259,62 @@ public static int readVarint(DataInput in) throws IOException {

[GitHub] [kafka] C0urante merged pull request #13184: KAFKA-14671: Refactor PredicatedTransformation to not implement Transformation

C0urante merged PR #13184: URL: https://github.com/apache/kafka/pull/13184 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[GitHub] [kafka] divijvaidya commented on a diff in pull request #13312: KAFKA-14766: Improve performance of VarInt encoding and decoding

divijvaidya commented on code in PR #13312: URL: https://github.com/apache/kafka/pull/13312#discussion_r1120354148 ## clients/src/main/java/org/apache/kafka/common/utils/ByteUtils.java: ## @@ -292,29 +415,66 @@ public static double readDouble(ByteBuffer buffer) { * @param

[GitHub] [kafka] satishd commented on a diff in pull request #13309: MINOR Moved a few log segment util methods from LocalLog to LogFileUtils

satishd commented on code in PR #13309: URL: https://github.com/apache/kafka/pull/13309#discussion_r1120421628 ## storage/src/main/java/org/apache/kafka/storage/internals/log/LogFileUtils.java: ## @@ -72,4 +92,99 @@ private static String filenamePrefixFromOffset(long offset) {

[GitHub] [kafka] satishd commented on pull request #13309: MINOR Moved a few log segment util methods from LocalLog to LogFileUtils

satishd commented on PR #13309: URL: https://github.com/apache/kafka/pull/13309#issuecomment-1448524298 Thanks @junrao for the review. Addressed them with the latest commit/comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Commented] (KAFKA-14748) Relax non-null FK left-join requirement

[ https://issues.apache.org/jira/browse/KAFKA-14748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17694652#comment-17694652 ] Guozhang Wang commented on KAFKA-14748: --- I agree for Stream-Stream joins now, sinc

[GitHub] [kafka] guozhangwang commented on a diff in pull request #13190: KAFKA-12639: exit upon expired timer to prevent tight looping

guozhangwang commented on code in PR #13190: URL: https://github.com/apache/kafka/pull/13190#discussion_r1120456284 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinatorTest.java: ## @@ -1484,6 +1484,8 @@ public void testRebalanceWithMetadataCh

[GitHub] [kafka] ijuma commented on a diff in pull request #13312: KAFKA-14766: Improve performance of VarInt encoding and decoding

ijuma commented on code in PR #13312: URL: https://github.com/apache/kafka/pull/13312#discussion_r1120470741 ## clients/src/main/java/org/apache/kafka/common/utils/ByteUtils.java: ## @@ -227,17 +259,62 @@ public static int readVarint(DataInput in) throws IOException { * @

[GitHub] [kafka] guozhangwang commented on a diff in pull request #13190: KAFKA-12639: exit upon expired timer to prevent tight looping

guozhangwang commented on code in PR #13190: URL: https://github.com/apache/kafka/pull/13190#discussion_r1120460193 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java: ## @@ -500,14 +500,24 @@ boolean joinGroupIfNeeded(final Timer timer

[GitHub] [kafka] gharris1727 commented on pull request #13313: KAFKA-14760: Move ThroughputThrottler from tools to clients, remove tools dependency from connect-runtime

gharris1727 commented on PR #13313: URL: https://github.com/apache/kafka/pull/13313#issuecomment-1448576594 I removed the checkstyle statements which allow `connect-runtime` to import `tools`. Since this is the only dependency on `tools`, we also have an opportunity to disallow _any_ import

[GitHub] [kafka] philipnee commented on a diff in pull request #13190: KAFKA-12639: exit upon expired timer to prevent tight looping

philipnee commented on code in PR #13190: URL: https://github.com/apache/kafka/pull/13190#discussion_r1120481527 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java: ## @@ -500,14 +500,24 @@ boolean joinGroupIfNeeded(final Timer timer) {

[GitHub] [kafka] C0urante commented on pull request #13284: KAFKA-14718: Make MirrorMaker startup synchronously depend on connector start

C0urante commented on PR #13284: URL: https://github.com/apache/kafka/pull/13284#issuecomment-1448579807 > I think that fixing the test by extending the timeout might hide the problems that users may be facing in production as well. I don't think that bumping the timeouts in these tes

[GitHub] [kafka] ijuma commented on a diff in pull request #13067: KAFKA-14524: Rewrite KafkaMetricsGroup in Java

ijuma commented on code in PR #13067: URL: https://github.com/apache/kafka/pull/13067#discussion_r1120488775 ## core/src/main/scala/kafka/network/RequestChannel.scala: ## @@ -497,51 +501,59 @@ object RequestMetrics { val ErrorsPerSec = "ErrorsPerSec" } -class RequestMetric

[jira] [Assigned] (KAFKA-14533) Flaky Test SmokeTestDriverIntegrationTest.shouldWorkWithRebalance

[ https://issues.apache.org/jira/browse/KAFKA-14533?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax reassigned KAFKA-14533: --- Assignee: Guozhang Wang > Flaky Test SmokeTestDriverIntegrationTest.shouldWorkWithR

[GitHub] [kafka] satishd commented on pull request #13304: KAFKA-14726 Move/rewrite of LogReadInfo, LogOffsetSnapshot, LogStartOffsetIncrementReason to storage module

satishd commented on PR #13304: URL: https://github.com/apache/kafka/pull/13304#issuecomment-1448587425 Thanks @junrao for your review. Addressed them with the latest commit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [kafka] C0urante commented on a diff in pull request #13287: MINOR: Refactor task change logic to AbstractHerder, reuse for standalone mode.

C0urante commented on code in PR #13287: URL: https://github.com/apache/kafka/pull/13287#discussion_r1120511592 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerder.java: ## @@ -427,9 +427,8 @@ private void updateConnectorTasks(String con

[GitHub] [kafka] C0urante merged pull request #13286: MINOR: reformat ClusterConfigState constructions in Abstract & DistributedHerder

C0urante merged PR #13286: URL: https://github.com/apache/kafka/pull/13286 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[GitHub] [kafka] ivanyu commented on a diff in pull request #13067: KAFKA-14524: Rewrite KafkaMetricsGroup in Java

ivanyu commented on code in PR #13067: URL: https://github.com/apache/kafka/pull/13067#discussion_r1120551247 ## core/src/main/scala/kafka/network/RequestChannel.scala: ## @@ -497,51 +501,59 @@ object RequestMetrics { val ErrorsPerSec = "ErrorsPerSec" } -class RequestMetri

[GitHub] [kafka] C0urante commented on a diff in pull request #12992: KIP-887: Add ConfigProvider to make use of environment variables

C0urante commented on code in PR #12992: URL: https://github.com/apache/kafka/pull/12992#discussion_r1120561014 ## clients/src/main/java/org/apache/kafka/common/config/provider/EnvVarConfigProvider.java: ## @@ -0,0 +1,94 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] [kafka] C0urante commented on a diff in pull request #12992: KIP-887: Add ConfigProvider to make use of environment variables

C0urante commented on code in PR #12992: URL: https://github.com/apache/kafka/pull/12992#discussion_r1120563796 ## clients/src/main/java/org/apache/kafka/common/config/provider/EnvVarConfigProvider.java: ## @@ -0,0 +1,114 @@ +/* + * Licensed to the Apache Software Foundation (AS

[GitHub] [kafka] gharris1727 commented on a diff in pull request #13287: MINOR: Refactor task change logic to AbstractHerder, reuse for standalone mode.

gharris1727 commented on code in PR #13287: URL: https://github.com/apache/kafka/pull/13287#discussion_r1120610035 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerder.java: ## @@ -427,9 +427,8 @@ private void updateConnectorTasks(String

[jira] [Comment Edited] (KAFKA-14767) Gradle build fails with missing commitId after git gc

[ https://issues.apache.org/jira/browse/KAFKA-14767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17694207#comment-17694207 ] Greg Harris edited comment on KAFKA-14767 at 2/28/23 7:01 PM:

[jira] [Comment Edited] (KAFKA-14767) Gradle build fails with missing commitId after git gc

[ https://issues.apache.org/jira/browse/KAFKA-14767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17694207#comment-17694207 ] Greg Harris edited comment on KAFKA-14767 at 2/28/23 7:01 PM:

[GitHub] [kafka] C0urante commented on a diff in pull request #13287: MINOR: Refactor task change logic to AbstractHerder, reuse for standalone mode.

C0urante commented on code in PR #13287: URL: https://github.com/apache/kafka/pull/13287#discussion_r1120636637 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerder.java: ## @@ -427,9 +427,8 @@ private void updateConnectorTasks(String con

[GitHub] [kafka] lbownik commented on a diff in pull request #13067: KAFKA-14524: Rewrite KafkaMetricsGroup in Java

lbownik commented on code in PR #13067: URL: https://github.com/apache/kafka/pull/13067#discussion_r1120661170 ## server-common/src/main/java/org/apache/kafka/server/metrics/KafkaMetricsGroup.java: ## @@ -0,0 +1,160 @@ +/* + * Licensed to the Apache Software Foundation (ASF) und

[GitHub] [kafka] philipnee commented on a diff in pull request #13190: KAFKA-12639: exit upon expired timer to prevent tight looping

philipnee commented on code in PR #13190: URL: https://github.com/apache/kafka/pull/13190#discussion_r1120663942 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinatorTest.java: ## @@ -1484,7 +1484,8 @@ public void testRebalanceWithMetadataChang

[GitHub] [kafka] philipnee commented on a diff in pull request #13190: KAFKA-12639: exit upon expired timer to prevent tight looping

philipnee commented on code in PR #13190: URL: https://github.com/apache/kafka/pull/13190#discussion_r1120665269 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java: ## @@ -501,13 +501,18 @@ boolean joinGroupIfNeeded(final Timer timer) {

[GitHub] [kafka] OneCricketeer commented on a diff in pull request #12992: KIP-887: Add ConfigProvider to make use of environment variables

OneCricketeer commented on code in PR #12992: URL: https://github.com/apache/kafka/pull/12992#discussion_r1114750313 ## clients/src/main/java/org/apache/kafka/common/config/provider/EnvVarConfigProvider.java: ## @@ -41,6 +46,14 @@ public EnvVarConfigProvider(Map envVarsAsArgume

[GitHub] [kafka] C0urante commented on a diff in pull request #12992: KIP-887: Add ConfigProvider to make use of environment variables

C0urante commented on code in PR #12992: URL: https://github.com/apache/kafka/pull/12992#discussion_r1120750168 ## clients/src/main/java/org/apache/kafka/common/config/provider/EnvVarConfigProvider.java: ## @@ -0,0 +1,94 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] [kafka] C0urante commented on a diff in pull request #13185: KAFKA-14670: (part 1) Wrap Connectors in IsolatedConnector objects

C0urante commented on code in PR #13185: URL: https://github.com/apache/kafka/pull/13185#discussion_r1120685793 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/isolation/IsolatedPlugin.java: ## @@ -0,0 +1,122 @@ +/* + * Licensed to the Apache Software Foundatio

[jira] [Created] (KAFKA-14769) NPE in ControllerMetricsManager when upgrading from old KRaft version

David Arthur created KAFKA-14769: Summary: NPE in ControllerMetricsManager when upgrading from old KRaft version Key: KAFKA-14769 URL: https://issues.apache.org/jira/browse/KAFKA-14769 Project: Kafka

[jira] [Resolved] (KAFKA-14769) NPE in ControllerMetricsManager when upgrading from old KRaft version

[ https://issues.apache.org/jira/browse/KAFKA-14769?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur resolved KAFKA-14769. -- Resolution: Invalid > NPE in ControllerMetricsManager when upgrading from old KRaft version >

[jira] [Updated] (KAFKA-14769) NPE in ControllerMetricsManager when upgrading from old KRaft version

[ https://issues.apache.org/jira/browse/KAFKA-14769?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur updated KAFKA-14769: - Fix Version/s: (was: 3.5.0) (was: 3.4.1) > NPE in ControllerMetricsMa

[jira] [Updated] (KAFKA-14769) NPE in ControllerMetricsManager when upgrading from old KRaft version

[ https://issues.apache.org/jira/browse/KAFKA-14769?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur updated KAFKA-14769: - Affects Version/s: (was: 3.4.0) > NPE in ControllerMetricsManager when upgrading from old KR

[GitHub] [kafka] C0urante commented on a diff in pull request #13182: KAFKA-14649: Isolate failures during plugin path scanning to single plugin classes

C0urante commented on code in PR #13182: URL: https://github.com/apache/kafka/pull/13182#discussion_r1120776026 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/isolation/DelegatingClassLoader.java: ## @@ -419,7 +423,14 @@ private Collection> getServiceLoaderP

[GitHub] [kafka] gharris1727 commented on a diff in pull request #13185: KAFKA-14670: (part 1) Wrap Connectors in IsolatedConnector objects

gharris1727 commented on code in PR #13185: URL: https://github.com/apache/kafka/pull/13185#discussion_r1120864255 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/isolation/IsolatedPlugin.java: ## @@ -0,0 +1,122 @@ +/* + * Licensed to the Apache Software Founda

[GitHub] [kafka] gharris1727 commented on a diff in pull request #13185: KAFKA-14670: (part 1) Wrap Connectors in IsolatedConnector objects

gharris1727 commented on code in PR #13185: URL: https://github.com/apache/kafka/pull/13185#discussion_r1120867064 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/isolation/IsolatedPlugin.java: ## @@ -0,0 +1,122 @@ +/* + * Licensed to the Apache Software Founda

[GitHub] [kafka] cmccabe closed pull request #13176: MINOR: some ZK migration code cleanups.

cmccabe closed pull request #13176: MINOR: some ZK migration code cleanups. URL: https://github.com/apache/kafka/pull/13176 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

[GitHub] [kafka] ijuma commented on a diff in pull request #13315: KAFKA-14767: Fix missing commitId build error after git gc

ijuma commented on code in PR #13315: URL: https://github.com/apache/kafka/pull/13315#discussion_r1120878251 ## build.gradle: ## @@ -159,16 +159,9 @@ def determineCommitId() { def takeFromHash = 16 if (project.hasProperty('commitId')) { commitId.take(takeFromHash) -

[GitHub] [kafka] gharris1727 commented on a diff in pull request #13185: KAFKA-14670: (part 1) Wrap Connectors in IsolatedConnector objects

gharris1727 commented on code in PR #13185: URL: https://github.com/apache/kafka/pull/13185#discussion_r1120880473 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/isolation/IsolatedPlugin.java: ## @@ -0,0 +1,122 @@ +/* + * Licensed to the Apache Software Founda

[GitHub] [kafka] C0urante commented on a diff in pull request #13185: KAFKA-14670: (part 1) Wrap Connectors in IsolatedConnector objects

C0urante commented on code in PR #13185: URL: https://github.com/apache/kafka/pull/13185#discussion_r1120886025 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/isolation/IsolatedPlugin.java: ## @@ -0,0 +1,122 @@ +/* + * Licensed to the Apache Software Foundatio

[GitHub] [kafka] C0urante commented on a diff in pull request #13185: KAFKA-14670: (part 1) Wrap Connectors in IsolatedConnector objects

C0urante commented on code in PR #13185: URL: https://github.com/apache/kafka/pull/13185#discussion_r1120887378 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/isolation/IsolatedPlugin.java: ## @@ -0,0 +1,122 @@ +/* + * Licensed to the Apache Software Foundatio

[GitHub] [kafka] C0urante commented on a diff in pull request #13185: KAFKA-14670: (part 1) Wrap Connectors in IsolatedConnector objects

C0urante commented on code in PR #13185: URL: https://github.com/apache/kafka/pull/13185#discussion_r1120889645 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/isolation/IsolatedPlugin.java: ## @@ -0,0 +1,122 @@ +/* + * Licensed to the Apache Software Foundatio

[GitHub] [kafka] gharris1727 commented on a diff in pull request #13185: KAFKA-14670: (part 1) Wrap Connectors in IsolatedConnector objects

gharris1727 commented on code in PR #13185: URL: https://github.com/apache/kafka/pull/13185#discussion_r1120897608 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/isolation/IsolatedPlugin.java: ## @@ -0,0 +1,122 @@ +/* + * Licensed to the Apache Software Founda

[GitHub] [kafka] gharris1727 commented on a diff in pull request #13185: KAFKA-14670: (part 1) Wrap Connectors in IsolatedConnector objects

gharris1727 commented on code in PR #13185: URL: https://github.com/apache/kafka/pull/13185#discussion_r1120897608 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/isolation/IsolatedPlugin.java: ## @@ -0,0 +1,122 @@ +/* + * Licensed to the Apache Software Founda

[GitHub] [kafka] OneCricketeer commented on a diff in pull request #12992: KIP-887: Add ConfigProvider to make use of environment variables

OneCricketeer commented on code in PR #12992: URL: https://github.com/apache/kafka/pull/12992#discussion_r1120908532 ## clients/src/main/java/org/apache/kafka/common/config/provider/EnvVarConfigProvider.java: ## @@ -0,0 +1,94 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] junrao commented on a diff in pull request #13304: KAFKA-14726 Move/rewrite of LogReadInfo, LogOffsetSnapshot, LogStartOffsetIncrementReason to storage module

junrao commented on code in PR #13304: URL: https://github.com/apache/kafka/pull/13304#discussion_r1120915339 ## storage/src/main/java/org/apache/kafka/storage/internals/log/LogReadInfo.java: ## @@ -0,0 +1,87 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [kafka] guozhangwang commented on pull request #13288: MINOR: fix rerun-tests for unit test

guozhangwang commented on PR #13288: URL: https://github.com/apache/kafka/pull/13288#issuecomment-1449082224 The referenced https://github.com/apache/kafka/pull/11926 seems not relevant, is there a typo in the PR number? -- This is an automated message from the Apache Git Service. To resp

[GitHub] [kafka] ijuma commented on a diff in pull request #13304: KAFKA-14726 Move/rewrite of LogReadInfo, LogOffsetSnapshot, LogStartOffsetIncrementReason to storage module

ijuma commented on code in PR #13304: URL: https://github.com/apache/kafka/pull/13304#discussion_r112095 ## storage/src/main/java/org/apache/kafka/storage/internals/log/LogReadInfo.java: ## @@ -0,0 +1,60 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one o

[GitHub] [kafka] ijuma commented on a diff in pull request #13304: KAFKA-14726 Move/rewrite of LogReadInfo, LogOffsetSnapshot, LogStartOffsetIncrementReason to storage module

ijuma commented on code in PR #13304: URL: https://github.com/apache/kafka/pull/13304#discussion_r1120933708 ## storage/src/main/java/org/apache/kafka/storage/internals/log/LogReadInfo.java: ## @@ -0,0 +1,87 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one o

[GitHub] [kafka] ijuma commented on pull request #13315: KAFKA-14767: Fix missing commitId build error after git gc

ijuma commented on PR #13315: URL: https://github.com/apache/kafka/pull/13315#issuecomment-1449090030 Looks like the build failed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[GitHub] [kafka] chia7712 commented on pull request #13288: MINOR: fix rerun-tests for unit test

chia7712 commented on PR #13288: URL: https://github.com/apache/kafka/pull/13288#issuecomment-1449114559 > The referenced https://github.com/apache/kafka/pull/11926 seems not relevant, is there a typo in the PR number? #11926 added the new property to avoid recompiling the tests. see

[GitHub] [kafka] gharris1727 commented on pull request #13315: KAFKA-14767: Fix missing commitId build error after git gc

gharris1727 commented on PR #13315: URL: https://github.com/apache/kafka/pull/13315#issuecomment-1449121574 @ijuma I don't know how my change would impact the execution order of rat vs processTestMessages, do you have any intuition? The commitId change that I originally proposed (with

[GitHub] [kafka] cmccabe commented on a diff in pull request #13114: KAFKA-14084: SCRAM support in KRaft.

cmccabe commented on code in PR #13114: URL: https://github.com/apache/kafka/pull/13114#discussion_r1120961672 ## core/src/main/scala/kafka/server/ControllerApis.scala: ## @@ -99,6 +99,7 @@ class ControllerApis(val requestChannel: RequestChannel, case ApiKeys.INCREMENTA

[GitHub] [kafka] cmccabe commented on a diff in pull request #13114: KAFKA-14084: SCRAM support in KRaft.

cmccabe commented on code in PR #13114: URL: https://github.com/apache/kafka/pull/13114#discussion_r1120962516 ## core/src/main/scala/kafka/server/metadata/BrokerMetadataPublisher.scala: ## @@ -221,6 +223,21 @@ class BrokerMetadataPublisher( s"quotas in ${deltaName}",

[GitHub] [kafka] cmccabe commented on a diff in pull request #13114: KAFKA-14084: SCRAM support in KRaft.

cmccabe commented on code in PR #13114: URL: https://github.com/apache/kafka/pull/13114#discussion_r1120962516 ## core/src/main/scala/kafka/server/metadata/BrokerMetadataPublisher.scala: ## @@ -221,6 +223,21 @@ class BrokerMetadataPublisher( s"quotas in ${deltaName}",

[GitHub] [kafka] cmccabe commented on a diff in pull request #13114: KAFKA-14084: SCRAM support in KRaft.

cmccabe commented on code in PR #13114: URL: https://github.com/apache/kafka/pull/13114#discussion_r1120967385 ## metadata/src/main/java/org/apache/kafka/image/ScramImage.java: ## @@ -0,0 +1,97 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * con

[GitHub] [kafka] jolshan commented on a diff in pull request #13231: KAFKA-14402: Update AddPartitionsToTxn protocol to batch and handle verifyOnly requests

jolshan commented on code in PR #13231: URL: https://github.com/apache/kafka/pull/13231#discussion_r1120967466 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -1328,7 +1328,7 @@ Priority priority() { @Override

[GitHub] [kafka] cmccabe commented on pull request #13114: KAFKA-14084: SCRAM support in KRaft.

cmccabe commented on PR #13114: URL: https://github.com/apache/kafka/pull/13114#issuecomment-1449130005 We need a test like `./metadata/src/test/java/org/apache/kafka/image/ScramImageTesst.java` , similar to the tests for the other Image classes. -- This is an automated message from the

[GitHub] [kafka] cmccabe commented on pull request #13114: KAFKA-14084: SCRAM support in KRaft.

cmccabe commented on PR #13114: URL: https://github.com/apache/kafka/pull/13114#issuecomment-1449130059 Thanks for this, @pprovenzano . It all looks good, but there is one change that we really do need here: we need to add SCRAM to MetadataVersion. I suspect we can add it to `IBP_3_5_IV0`.

[GitHub] [kafka] jolshan commented on a diff in pull request #13231: KAFKA-14402: Update AddPartitionsToTxn protocol to batch and handle verifyOnly requests

jolshan commented on code in PR #13231: URL: https://github.com/apache/kafka/pull/13231#discussion_r1120976648 ## clients/src/main/resources/common/message/AddPartitionsToTxnResponse.json: ## @@ -22,22 +22,37 @@ // Version 2 adds the support for new error code PRODUCER_FENCED

[GitHub] [kafka] jolshan commented on a diff in pull request #13231: KAFKA-14402: Update AddPartitionsToTxn protocol to batch and handle verifyOnly requests

jolshan commented on code in PR #13231: URL: https://github.com/apache/kafka/pull/13231#discussion_r1120986902 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -2384,68 +2385,116 @@ class KafkaApis(val requestChannel: RequestChannel, if (config.interBrokerProtocol

[GitHub] [kafka] jolshan commented on a diff in pull request #13231: KAFKA-14402: Update AddPartitionsToTxn protocol to batch and handle verifyOnly requests

jolshan commented on code in PR #13231: URL: https://github.com/apache/kafka/pull/13231#discussion_r1120990845 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -2384,68 +2385,116 @@ class KafkaApis(val requestChannel: RequestChannel, if (config.interBrokerProtocol

[GitHub] [kafka] jolshan commented on a diff in pull request #13231: KAFKA-14402: Update AddPartitionsToTxn protocol to batch and handle verifyOnly requests

jolshan commented on code in PR #13231: URL: https://github.com/apache/kafka/pull/13231#discussion_r1120991153 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -2384,68 +2385,116 @@ class KafkaApis(val requestChannel: RequestChannel, if (config.interBrokerProtocol

[GitHub] [kafka] jolshan commented on a diff in pull request #13231: KAFKA-14402: Update AddPartitionsToTxn protocol to batch and handle verifyOnly requests

jolshan commented on code in PR #13231: URL: https://github.com/apache/kafka/pull/13231#discussion_r1121005648 ## core/src/test/scala/unit/kafka/server/KafkaApisTest.scala: ## @@ -1962,7 +1962,9 @@ class KafkaApisTest { ArgumentMatchers.eq(producerId), Argument

[GitHub] [kafka] guozhangwang opened a new pull request, #13318: [DO NOT MERGE] Re-enable state-updater in SmokeTestDriverIntegrationTest

guozhangwang opened a new pull request, #13318: URL: https://github.com/apache/kafka/pull/13318 1. Print fine-grained streams exception when list-offset fails. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverag

[jira] [Commented] (KAFKA-14533) Flaky Test SmokeTestDriverIntegrationTest.shouldWorkWithRebalance

[ https://issues.apache.org/jira/browse/KAFKA-14533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17694801#comment-17694801 ] Guozhang Wang commented on KAFKA-14533: --- I took some time into this, also cannot f

[GitHub] [kafka] philipnee commented on pull request #13190: KAFKA-12639: exit upon expired timer to prevent tight looping

philipnee commented on PR #13190: URL: https://github.com/apache/kafka/pull/13190#issuecomment-1449185108 Hmm. I think these tests are flaky actually ``` Build / JDK 17 and Scala 2.13 / shouldPauseStandbyTaskAndNotTransitToUpdateStandbyAgain() – org.apache.kafka.streams.processor.inte

[GitHub] [kafka] guozhangwang merged pull request #13190: KAFKA-12639: exit upon expired timer to prevent tight looping

guozhangwang merged PR #13190: URL: https://github.com/apache/kafka/pull/13190 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.ap

[GitHub] [kafka] guozhangwang commented on pull request #13190: KAFKA-12639: exit upon expired timer to prevent tight looping

guozhangwang commented on PR #13190: URL: https://github.com/apache/kafka/pull/13190#issuecomment-1449185984 The test failures are not relevant (but some of them are related to DefaultStateUpdaterTest.. sigh). -- This is an automated message from the Apache Git Service. To respond to the

  1   2   >