C0urante commented on code in PR #12992: URL: https://github.com/apache/kafka/pull/12992#discussion_r1120750168
########## clients/src/main/java/org/apache/kafka/common/config/provider/EnvVarConfigProvider.java: ########## @@ -0,0 +1,94 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.common.config.provider; + +import org.apache.kafka.common.config.ConfigData; +import org.apache.kafka.common.config.ConfigException; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import java.io.IOException; +import java.util.HashMap; +import java.util.Map; +import java.util.Set; + +public class EnvVarConfigProvider implements ConfigProvider { + private final Map<String, String> envVarMap; + + public EnvVarConfigProvider() { + envVarMap = getEnvVars(); + } + + public EnvVarConfigProvider(Map<String, String> envVarsAsArgument) { + envVarMap = envVarsAsArgument; + } + + private static final Logger log = LoggerFactory.getLogger(EnvVarConfigProvider.class); + + @Override + public void configure(Map<String, ?> configs) { + } Review Comment: Sorry, by "deploy code", do you mean a custom connector class? Because if that's the case, then credentials leakage is not going to be prevented by modifying this config provider since the connector can just invoke `System::getEnv` and do whatever it wants with that info. If we're discussing connector configurations instead, then it's already possible, and basically necessary, to lock down your Connect worker's REST API to prevent users from submitting arbitrary connector configurations to your worker in anything but local testing environments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
