[GitHub] [kafka] omkreddy commented on a diff in pull request #13114: KAFKA-14084: SCRAM support in KRaft.

omkreddy commented on code in PR #13114: URL: https://github.com/apache/kafka/pull/13114#discussion_r1106751131 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -3296,17 +3296,23 @@ class KafkaApis(val requestChannel: RequestChannel, } def handleDescribeUserScr

[GitHub] [kafka] omkreddy commented on a diff in pull request #13114: KAFKA-14084: SCRAM support in KRaft.

omkreddy commented on code in PR #13114: URL: https://github.com/apache/kafka/pull/13114#discussion_r1106755866 ## core/src/test/scala/unit/kafka/server/AlterUserScramCredentialsRequestTest.scala: ## @@ -260,11 +271,13 @@ class AlterUserScramCredentialsRequestTest extends BaseR

[jira] [Commented] (KAFKA-14713) Kafka Streams global table startup takes too long

[ https://issues.apache.org/jira/browse/KAFKA-14713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17688945#comment-17688945 ] Tamas commented on KAFKA-14713: --- Hi [~mjsax] looks similar, but not exactly. They see this

[jira] [Comment Edited] (KAFKA-14713) Kafka Streams global table startup takes too long

[ https://issues.apache.org/jira/browse/KAFKA-14713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17688945#comment-17688945 ] Tamas edited comment on KAFKA-14713 at 2/15/23 8:52 AM: Hi [~mjs

[jira] [Updated] (KAFKA-14704) Follower should truncate before incrementing high watermark

[ https://issues.apache.org/jira/browse/KAFKA-14704?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot updated KAFKA-14704: Fix Version/s: 2.8.3 3.2.4 3.1.3 3.0.3 >

[GitHub] [kafka] satishd opened a new pull request, #13255: KAFKA 14714: Move/Rewrite RollParams, LogAppendInfo, and LeaderHwChange to storage module.

satishd opened a new pull request, #13255: URL: https://github.com/apache/kafka/pull/13255 KAFKA 14714: Move/Rewrite RollParams, LogAppendInfo, and LeaderHwChange to storage module. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation -

[GitHub] [kafka] vamossagar12 commented on pull request #13158: KAFKA-14647: Moving TopicFilter to server-common/utils

vamossagar12 commented on PR #13158: URL: https://github.com/apache/kafka/pull/13158#issuecomment-1430997152 > Hi @vamossagar12 this looks good, but I still think we should move `GetOffsetShellParsingTest` to `TopicPartitionFilterTest` removing any reference to `GetOffsetShell` (there is al

[GitHub] [kafka] showuon commented on pull request #13238: KAFKA-14708: Use Java thread instead of kafka library for example purpose

showuon commented on PR #13238: URL: https://github.com/apache/kafka/pull/13238#issuecomment-1431011866 @philipnee , there's spotbug error, could you help fix it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [kafka] benru89 commented on pull request #11442: KAFKA-7883 add schema.namespace support to SetSchemaMetadata SMT in Kafka Connect

benru89 commented on PR #11442: URL: https://github.com/apache/kafka/pull/11442#issuecomment-1431013263 whats the status of this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[jira] [Resolved] (KAFKA-14716) Connect schema does not allow struct default values

[ https://issues.apache.org/jira/browse/KAFKA-14716?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Urban resolved KAFKA-14716. -- Resolution: Duplicate > Connect schema does not allow struct default values >

[jira] [Commented] (KAFKA-14716) Connect schema does not allow struct default values

[ https://issues.apache.org/jira/browse/KAFKA-14716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17688979#comment-17688979 ] Daniel Urban commented on KAFKA-14716: -- [~ChrisEgerton] Indeed, it is, thanks for p

[GitHub] [kafka] urbandan commented on pull request #10566: KAFKA-12694 Avoid schema mismatch DataException when validating default values

urbandan commented on PR #10566: URL: https://github.com/apache/kafka/pull/10566#issuecomment-1431030129 I would propose a 4th option as well: changing the ConnectSchema#validateValue method to use a different logic for Struct default values: 1. Use the Schema methods 2. Ignore option

[jira] [Updated] (KAFKA-14590) Move DelegationTokenCommand to tools

[ https://issues.apache.org/jira/browse/KAFKA-14590?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gantigmaa Selenge updated KAFKA-14590: -- Fix Version/s: 3.5.0 Affects Version/s: (was: 3.5.0) > Move DelegationToke

[jira] [Commented] (KAFKA-14592) Move FeatureCommand to tools

[ https://issues.apache.org/jira/browse/KAFKA-14592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17689019#comment-17689019 ] Federico Valeri commented on KAFKA-14592: - Here we should also add the missing B

[GitHub] [kafka] mimaison commented on pull request #11442: KAFKA-7883 add schema.namespace support to SetSchemaMetadata SMT in Kafka Connect

mimaison commented on PR #11442: URL: https://github.com/apache/kafka/pull/11442#issuecomment-1431141433 To be able to merge this, the associated [KIP](https://cwiki.apache.org/confluence/display/KAFKA/KIP-855%3A+Add+schema.namespace+parameter+to+SetSchemaMetadata+SMT+in+Kafka+Connect) must

[GitHub] [kafka] dejan2609 commented on pull request #13205: KAFKA-14680: gradle version upgrade 7 -->> 8

dejan2609 commented on PR #13205: URL: https://github.com/apache/kafka/pull/13205#issuecomment-1431231802 @ijuma some findigs: build fails due to issues with gradle wrapper bootstrapping. I will post more details today. -- This is an automated message from the Apache Git Service.

[GitHub] [kafka] chia7712 commented on a diff in pull request #13248: KAFKA-14717 KafkaStreams can' get running if the rebalance happens be…

chia7712 commented on code in PR #13248: URL: https://github.com/apache/kafka/pull/13248#discussion_r1107014705 ## streams/src/test/java/org/apache/kafka/streams/integration/AdjustStreamThreadCountTest.java: ## @@ -257,6 +258,23 @@ private Thread adjustCountHelperThread(final Ka

[jira] [Updated] (KAFKA-12473) Make the "cooperative-sticky, range" as the default assignor

[ https://issues.apache.org/jira/browse/KAFKA-12473?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen updated KAFKA-12473: -- Fix Version/s: (was: 3.5.0) > Make the "cooperative-sticky, range" as the default assignor > -

[jira] [Commented] (KAFKA-12473) Make the "cooperative-sticky, range" as the default assignor

[ https://issues.apache.org/jira/browse/KAFKA-12473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17689070#comment-17689070 ] Luke Chen commented on KAFKA-12473: --- Removed the fixed version value until we have som

[jira] [Created] (KAFKA-14720) Tools migration guidelines

Federico Valeri created KAFKA-14720: --- Summary: Tools migration guidelines Key: KAFKA-14720 URL: https://issues.apache.org/jira/browse/KAFKA-14720 Project: Kafka Issue Type: Improvement

[jira] [Updated] (KAFKA-14720) Tools migration guidelines

[ https://issues.apache.org/jira/browse/KAFKA-14720?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Federico Valeri updated KAFKA-14720: Description: The tools migration effort is ongoing and being tracked in KAFKA-14525. This

[jira] [Assigned] (KAFKA-14720) Tools migration guidelines

[ https://issues.apache.org/jira/browse/KAFKA-14720?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Federico Valeri reassigned KAFKA-14720: --- Assignee: Federico Valeri > Tools migration guidelines > --

[GitHub] [kafka] dejan2609 commented on pull request #13205: KAFKA-14680: gradle version upgrade 7 -->> 8

dejan2609 commented on PR #13205: URL: https://github.com/apache/kafka/pull/13205#issuecomment-1431370263 Update: gradle wrapper bootstrapping is ok now, but spotless Scala checks are failing... Searching for a solution. -- This is an automated message from the Apache Git Service. To

[GitHub] [kafka] ijuma commented on pull request #13247: KAFKA-14595 Move value objects of ReassignPartitionsCommand to java

ijuma commented on PR #13247: URL: https://github.com/apache/kafka/pull/13247#issuecomment-1431422276 If you want to do it in small steps, one way is that you introduce the new classes, but you do not update the command to use them. That way you can put them in the right destination from th

[jira] [Updated] (KAFKA-14720) Tools migration guidelines

[ https://issues.apache.org/jira/browse/KAFKA-14720?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Federico Valeri updated KAFKA-14720: Description: The tools migration effort is ongoing and being tracked in KAFKA-14525. This

[GitHub] [kafka] nizhikov commented on pull request #13247: KAFKA-14595 Move value objects of ReassignPartitionsCommand to java

nizhikov commented on PR #13247: URL: https://github.com/apache/kafka/pull/13247#issuecomment-1431428999 Hello @ijuma > If you want to do it in small steps It's more about simplify review then my personal preferences :) For now, I introduced java classes from `ReassignPa

[GitHub] [kafka] pprovenzano commented on a diff in pull request #13114: KAFKA-14084: SCRAM support in KRaft.

pprovenzano commented on code in PR #13114: URL: https://github.com/apache/kafka/pull/13114#discussion_r1107184550 ## metadata/src/main/java/org/apache/kafka/image/ScramImage.java: ## @@ -50,6 +58,63 @@ public void write(ImageWriter writer, ImageWriterOptions options) {

[GitHub] [kafka] pprovenzano commented on a diff in pull request #13114: KAFKA-14084: SCRAM support in KRaft.

pprovenzano commented on code in PR #13114: URL: https://github.com/apache/kafka/pull/13114#discussion_r1107193412 ## metadata/src/main/java/org/apache/kafka/image/ScramImage.java: ## @@ -50,6 +58,63 @@ public void write(ImageWriter writer, ImageWriterOptions options) {

[GitHub] [kafka] pprovenzano commented on a diff in pull request #13114: KAFKA-14084: SCRAM support in KRaft.

pprovenzano commented on code in PR #13114: URL: https://github.com/apache/kafka/pull/13114#discussion_r1107200727 ## metadata/src/main/java/org/apache/kafka/image/ScramImage.java: ## @@ -50,6 +58,63 @@ public void write(ImageWriter writer, ImageWriterOptions options) {

[GitHub] [kafka] pprovenzano commented on a diff in pull request #13114: KAFKA-14084: SCRAM support in KRaft.

pprovenzano commented on code in PR #13114: URL: https://github.com/apache/kafka/pull/13114#discussion_r1107200727 ## metadata/src/main/java/org/apache/kafka/image/ScramImage.java: ## @@ -50,6 +58,63 @@ public void write(ImageWriter writer, ImageWriterOptions options) {

[GitHub] [kafka] pprovenzano commented on a diff in pull request #13114: KAFKA-14084: SCRAM support in KRaft.

pprovenzano commented on code in PR #13114: URL: https://github.com/apache/kafka/pull/13114#discussion_r1107211109 ## metadata/src/main/java/org/apache/kafka/image/ScramImage.java: ## @@ -50,6 +58,63 @@ public void write(ImageWriter writer, ImageWriterOptions options) {

[GitHub] [kafka] pprovenzano commented on a diff in pull request #13114: KAFKA-14084: SCRAM support in KRaft.

pprovenzano commented on code in PR #13114: URL: https://github.com/apache/kafka/pull/13114#discussion_r1107227490 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -3611,12 +3617,4 @@ object KafkaApis { private def unsupported(text: String): Exception = { new U

[GitHub] [kafka] C0urante commented on a diff in pull request #13178: KAFKA-12468, KAFKA-13659, KAFKA-12566: Fix MM2 causing negative downstream lag

C0urante commented on code in PR #13178: URL: https://github.com/apache/kafka/pull/13178#discussion_r1107273995 ## connect/mirror/src/main/java/org/apache/kafka/connect/mirror/OffsetSyncStore.java: ## @@ -16,40 +16,88 @@ */ package org.apache.kafka.connect.mirror; -import o

[GitHub] [kafka] C0urante commented on a diff in pull request #13178: KAFKA-12468, KAFKA-13659, KAFKA-12566: Fix MM2 causing negative downstream lag

C0urante commented on code in PR #13178: URL: https://github.com/apache/kafka/pull/13178#discussion_r1107275404 ## connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorCheckpointTask.java: ## @@ -134,9 +138,9 @@ public String version() { @Override public

[GitHub] [kafka] dejan2609 commented on pull request #13205: KAFKA-14680: gradle version upgrade 7 -->> 8

dejan2609 commented on PR #13205: URL: https://github.com/apache/kafka/pull/13205#issuecomment-1431575644 It seems that Spotless Gradle plugin needs to be alligned with Gradle 8.0 (I filed a ticket here: https://github.com/diffplug/spotless/issues/1572) Thing is that they dropped supp

[GitHub] [kafka] clolov commented on pull request #13219: MINOR: Simplify JUnit assertions; remove accidental unnecessary code

clolov commented on PR #13219: URL: https://github.com/apache/kafka/pull/13219#issuecomment-1431608450 @divijvaidya, as suggested I have left only test changes in this pull request. Furthermore, I believe I have fixed all `assertEquals` which had arguments the wrong way around 😊 -- This

[GitHub] [kafka] pprovenzano commented on a diff in pull request #13114: KAFKA-14084: SCRAM support in KRaft.

pprovenzano commented on code in PR #13114: URL: https://github.com/apache/kafka/pull/13114#discussion_r1107329539 ## core/src/main/scala/kafka/server/ControllerApis.scala: ## @@ -99,6 +99,7 @@ class ControllerApis(val requestChannel: RequestChannel, case ApiKeys.INCREM

[GitHub] [kafka] pprovenzano commented on a diff in pull request #13114: KAFKA-14084: SCRAM support in KRaft.

pprovenzano commented on code in PR #13114: URL: https://github.com/apache/kafka/pull/13114#discussion_r1107329945 ## metadata/src/main/java/org/apache/kafka/image/ScramImage.java: ## @@ -50,6 +58,63 @@ public void write(ImageWriter writer, ImageWriterOptions options) {

[GitHub] [kafka] C0urante commented on a diff in pull request #13178: KAFKA-12468, KAFKA-13659, KAFKA-12566: Fix MM2 causing negative downstream lag

C0urante commented on code in PR #13178: URL: https://github.com/apache/kafka/pull/13178#discussion_r1107345427 ## connect/runtime/src/main/java/org/apache/kafka/connect/util/KafkaBasedLog.java: ## @@ -392,6 +400,17 @@ protected Consumer createConsumer() { return new Ka

[GitHub] [kafka] C0urante commented on a diff in pull request #13178: KAFKA-12468, KAFKA-13659, KAFKA-12566: Fix MM2 causing negative downstream lag

C0urante commented on code in PR #13178: URL: https://github.com/apache/kafka/pull/13178#discussion_r1107352681 ## connect/mirror/src/test/java/org/apache/kafka/connect/mirror/integration/MirrorConnectorsIntegrationBaseTest.java: ## @@ -701,43 +745,151 @@ protected void produceM

[GitHub] [kafka] mumrah opened a new pull request, #13257: MINOR: Add ZK migration docs to the packaged docs

mumrah opened a new pull request, #13257: URL: https://github.com/apache/kafka/pull/13257 This patch brings in the ZK migration docs that were added for the 3.4 release. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [kafka] ijuma commented on pull request #13205: KAFKA-14680: gradle version upgrade 7 -->> 8

ijuma commented on PR #13205: URL: https://github.com/apache/kafka/pull/13205#issuecomment-1431655901 An alternative would be to drop spotless until we drop support for Java 8 (Apache Kafka 4.0). What actually uses spotless today? -- This is an automated message from the Apache Git Servic

[GitHub] [kafka] C0urante commented on a diff in pull request #13208: KAFKA-5756: Wait for concurrent offset flush to complete before starting next flush

C0urante commented on code in PR #13208: URL: https://github.com/apache/kafka/pull/13208#discussion_r1106236517 ## connect/runtime/src/test/java/org/apache/kafka/connect/storage/OffsetStorageWriterTest.java: ## @@ -135,38 +135,40 @@ public void testFlushFailureReplacesOffsets()

[GitHub] [kafka] C0urante commented on a diff in pull request #13208: KAFKA-5756: Wait for concurrent offset flush to complete before starting next flush

C0urante commented on code in PR #13208: URL: https://github.com/apache/kafka/pull/13208#discussion_r1107391193 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/AbstractWorkerSourceTask.java: ## @@ -365,6 +365,10 @@ public void execute() { } catch (Inte

[jira] [Created] (KAFKA-14721) Kafka listener uses wrong login class

Daniel Urban created KAFKA-14721: Summary: Kafka listener uses wrong login class Key: KAFKA-14721 URL: https://issues.apache.org/jira/browse/KAFKA-14721 Project: Kafka Issue Type: Bug Aff

[GitHub] [kafka] dejan2609 commented on pull request #13205: KAFKA-14680: gradle version upgrade 7 -->> 8

dejan2609 commented on PR #13205: URL: https://github.com/apache/kafka/pull/13205#issuecomment-1431760212 At the moment spotless is used via Jenkins CI server :arrow_right: Jenkinsfile 'spotlessScalaCheck' task execution: https://github.com/apache/kafka/blob/3.4.0/Jenkinsfile#L23 My

[GitHub] [kafka] lucasbru commented on a diff in pull request #13025: KAFKA-14299: Fix pause and resume with state updater

lucasbru commented on code in PR #13025: URL: https://github.com/apache/kafka/pull/13025#discussion_r1107498812 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/ReadOnlyTask.java: ## @@ -190,7 +190,7 @@ public void clearTaskTimeout() { @Override

[GitHub] [kafka] lucasbru commented on a diff in pull request #13025: KAFKA-14299: Fix pause and resume with state updater

lucasbru commented on code in PR #13025: URL: https://github.com/apache/kafka/pull/13025#discussion_r1107498812 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/ReadOnlyTask.java: ## @@ -190,7 +190,7 @@ public void clearTaskTimeout() { @Override

[jira] [Created] (KAFKA-14722) Make BooleanSerde public

Matthias J. Sax created KAFKA-14722: --- Summary: Make BooleanSerde public Key: KAFKA-14722 URL: https://issues.apache.org/jira/browse/KAFKA-14722 Project: Kafka Issue Type: Improvement

[GitHub] [kafka] mjsax commented on a diff in pull request #13249: KAFKA-14491: [8/N] Add serdes for ValueAndTimestamp with null value

mjsax commented on code in PR #13249: URL: https://github.com/apache/kafka/pull/13249#discussion_r1107522774 ## streams/src/main/java/org/apache/kafka/streams/state/internals/NullableValueAndTimestampSerde.java: ## @@ -0,0 +1,87 @@ +/* + * Licensed to the Apache Software Foundat

[GitHub] [kafka] vcrfxia commented on a diff in pull request #13243: KAFKA-14491: [7/N] Enforce strict grace period for versioned stores

vcrfxia commented on code in PR #13243: URL: https://github.com/apache/kafka/pull/13243#discussion_r1107567122 ## streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBVersionedStore.java: ## @@ -283,7 +293,12 @@ public void init(final StateStoreContext context,

[GitHub] [kafka] guozhangwang commented on a diff in pull request #13192: KAFKA-14675: Extract metadata-related tasks from Fetcher into MetadataFetcher 1/4

guozhangwang commented on code in PR #13192: URL: https://github.com/apache/kafka/pull/13192#discussion_r1107569600 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/MetadataFetcher.java: ## @@ -0,0 +1,805 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] jolshan commented on a diff in pull request #13231: KAFKA-14402: Update AddPartitionsToTxn protocol to batch and handle verifyOnly requests

jolshan commented on code in PR #13231: URL: https://github.com/apache/kafka/pull/13231#discussion_r1107587497 ## clients/src/main/java/org/apache/kafka/common/requests/AddPartitionsToTxnRequest.java: ## @@ -101,15 +130,61 @@ public String toString() { public AddPartitionsT

[GitHub] [kafka] jolshan commented on a diff in pull request #13231: KAFKA-14402: Update AddPartitionsToTxn protocol to batch and handle verifyOnly requests

jolshan commented on code in PR #13231: URL: https://github.com/apache/kafka/pull/13231#discussion_r1107589437 ## core/src/main/scala/kafka/coordinator/transaction/TransactionCoordinator.scala: ## @@ -352,7 +353,12 @@ class TransactionCoordinator(txnConfig: TransactionConfig,

[GitHub] [kafka] jolshan commented on a diff in pull request #13231: KAFKA-14402: Update AddPartitionsToTxn protocol to batch and handle verifyOnly requests

jolshan commented on code in PR #13231: URL: https://github.com/apache/kafka/pull/13231#discussion_r1107589884 ## clients/src/test/java/org/apache/kafka/common/requests/AddPartitionsToTxnResponseTest.java: ## @@ -84,16 +88,59 @@ public void testParse() { topicCollecti

[GitHub] [kafka] jolshan commented on a diff in pull request #13231: KAFKA-14402: Update AddPartitionsToTxn protocol to batch and handle verifyOnly requests

jolshan commented on code in PR #13231: URL: https://github.com/apache/kafka/pull/13231#discussion_r1107590295 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -2383,68 +2384,101 @@ class KafkaApis(val requestChannel: RequestChannel, if (config.interBrokerProtocol

[GitHub] [kafka] jolshan commented on a diff in pull request #13231: KAFKA-14402: Update AddPartitionsToTxn protocol to batch and handle verifyOnly requests

jolshan commented on code in PR #13231: URL: https://github.com/apache/kafka/pull/13231#discussion_r1107590667 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -2383,68 +2384,101 @@ class KafkaApis(val requestChannel: RequestChannel, if (config.interBrokerProtocol

[GitHub] [kafka] jolshan commented on a diff in pull request #13231: KAFKA-14402: Update AddPartitionsToTxn protocol to batch and handle verifyOnly requests

jolshan commented on code in PR #13231: URL: https://github.com/apache/kafka/pull/13231#discussion_r1107592032 ## clients/src/main/java/org/apache/kafka/common/requests/AddPartitionsToTxnRequest.java: ## @@ -101,15 +130,61 @@ public String toString() { public AddPartitionsT

[jira] [Created] (KAFKA-14723) Do not write expired store records to changelog

Victoria Xia created KAFKA-14723: Summary: Do not write expired store records to changelog Key: KAFKA-14723 URL: https://issues.apache.org/jira/browse/KAFKA-14723 Project: Kafka Issue Type: I

[jira] [Updated] (KAFKA-14723) Do not write expired store records to changelog

[ https://issues.apache.org/jira/browse/KAFKA-14723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Victoria Xia updated KAFKA-14723: - Description: Window stores and versioned stores both have concepts of "retention" and "expirati

[GitHub] [kafka] vcrfxia commented on a diff in pull request #13243: KAFKA-14491: [7/N] Enforce strict grace period for versioned stores

vcrfxia commented on code in PR #13243: URL: https://github.com/apache/kafka/pull/13243#discussion_r1107595402 ## streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBVersionedStore.java: ## @@ -297,6 +312,12 @@ void restoreBatch(final Collection> records) {

[jira] [Updated] (KAFKA-14274) Fetcher refactor—split Fetcher into Fetcher and MetadataFetcher

[ https://issues.apache.org/jira/browse/KAFKA-14274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-14274: -- Summary: Fetcher refactor—split Fetcher into Fetcher and MetadataFetcher (was: Implement fetching log

[jira] [Updated] (KAFKA-14274) Split Fetcher into Fetcher and MetadataFetcher

[ https://issues.apache.org/jira/browse/KAFKA-14274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-14274: -- Summary: Split Fetcher into Fetcher and MetadataFetcher (was: Fetcher refactor—split Fetcher into Fet

[jira] [Updated] (KAFKA-14365) Extract common logic from Fetcher into FetcherUtils

[ https://issues.apache.org/jira/browse/KAFKA-14365?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-14365: -- Summary: Extract common logic from Fetcher into FetcherUtils (was: Refactor Fetcher to allow differen

[GitHub] [kafka] vcrfxia commented on a diff in pull request #13243: KAFKA-14491: [7/N] Enforce strict grace period for versioned stores

vcrfxia commented on code in PR #13243: URL: https://github.com/apache/kafka/pull/13243#discussion_r1107613538 ## streams/src/test/java/org/apache/kafka/streams/state/internals/RocksDBVersionedStoreTest.java: ## @@ -523,6 +537,63 @@ public void shouldRestoreMultipleBatches() {

[jira] [Updated] (KAFKA-14675) Extract metadata-related tasks from Fetcher into MetadataFetcher

[ https://issues.apache.org/jira/browse/KAFKA-14675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-14675: -- Parent: (was: KAFKA-14365) Issue Type: Improvement (was: Sub-task) > Extract metadata-rel

[jira] [Updated] (KAFKA-14365) Extract common logic from Fetcher into FetcherUtils

[ https://issues.apache.org/jira/browse/KAFKA-14365?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-14365: -- Priority: Major (was: Minor) > Extract common logic from Fetcher into FetcherUtils >

[jira] [Updated] (KAFKA-14365) Extract common logic from Fetcher into FetcherUtils

[ https://issues.apache.org/jira/browse/KAFKA-14365?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-14365: -- Description: The {{Fetcher}} class is used internally by the `KafkaConsumer` to fetch records from the

[jira] [Updated] (KAFKA-14365) Extract common logic from Fetcher into FetcherUtils

[ https://issues.apache.org/jira/browse/KAFKA-14365?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-14365: -- Description: The {{Fetcher}} class is used internally by the {{KafkaConsumer}} to fetch records from t

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #13231: KAFKA-14402: Update AddPartitionsToTxn protocol to batch and handle verifyOnly requests

jeffkbkim commented on code in PR #13231: URL: https://github.com/apache/kafka/pull/13231#discussion_r1107618273 ## clients/src/main/java/org/apache/kafka/common/requests/AddPartitionsToTxnRequest.java: ## @@ -101,15 +130,61 @@ public String toString() { public AddPartition

[jira] [Updated] (KAFKA-14365) Extract common logic from Fetcher into FetcherUtils

[ https://issues.apache.org/jira/browse/KAFKA-14365?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-14365: -- Description: The {{Fetcher}} class is used internally by the {{KafkaConsumer}} to fetch records from

[jira] [Updated] (KAFKA-14675) Extract metadata-related tasks from Fetcher into MetadataFetcher

[ https://issues.apache.org/jira/browse/KAFKA-14675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-14675: -- Description: The {{Fetcher}} class is used internally by the {{KafkaConsumer}} to fetch records from

[jira] [Updated] (KAFKA-14365) Extract common logic from Fetcher into FetcherUtils

[ https://issues.apache.org/jira/browse/KAFKA-14365?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-14365: -- Description: The {{Fetcher}} class is used internally by the {{KafkaConsumer}} to fetch records from

[jira] [Updated] (KAFKA-14274) Split Fetcher into Fetcher and MetadataFetcher

[ https://issues.apache.org/jira/browse/KAFKA-14274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-14274: -- Description: The {{Fetcher}} class is used internally by the {{KafkaConsumer}} to fetch records from

[jira] [Updated] (KAFKA-14274) Split Fetcher into Fetcher and MetadataFetcher

[ https://issues.apache.org/jira/browse/KAFKA-14274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-14274: -- Component/s: clients > Split Fetcher into Fetcher and MetadataFetcher > --

[jira] [Updated] (KAFKA-14274) Split Fetcher into Fetcher and MetadataFetcher

[ https://issues.apache.org/jira/browse/KAFKA-14274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-14274: -- Description: The {{Fetcher}} class is used internally by the {{KafkaConsumer}} to fetch records from

[jira] [Updated] (KAFKA-14274) Introduce FetchRequestManager

[ https://issues.apache.org/jira/browse/KAFKA-14274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-14274: -- Summary: Introduce FetchRequestManager (was: Split Fetcher into Fetcher and MetadataFetcher) > Intro

[GitHub] [kafka] jolshan commented on a diff in pull request #13231: KAFKA-14402: Update AddPartitionsToTxn protocol to batch and handle verifyOnly requests

jolshan commented on code in PR #13231: URL: https://github.com/apache/kafka/pull/13231#discussion_r1107626067 ## clients/src/main/java/org/apache/kafka/common/requests/AddPartitionsToTxnRequest.java: ## @@ -101,15 +130,61 @@ public String toString() { public AddPartitionsT

[GitHub] [kafka] gharris1727 commented on a diff in pull request #13178: KAFKA-12468, KAFKA-13659, KAFKA-12566: Fix MM2 causing negative downstream lag

gharris1727 commented on code in PR #13178: URL: https://github.com/apache/kafka/pull/13178#discussion_r1107628693 ## connect/mirror/src/test/java/org/apache/kafka/connect/mirror/integration/MirrorConnectorsIntegrationBaseTest.java: ## @@ -701,43 +745,151 @@ protected void produ

[jira] [Updated] (KAFKA-14274) Introduce FetchRequestManager

[ https://issues.apache.org/jira/browse/KAFKA-14274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-14274: -- Description: The {{Fetcher}} class is used internally by the {{KafkaConsumer}} to fetch records from

[GitHub] [kafka] gharris1727 commented on a diff in pull request #13178: KAFKA-12468, KAFKA-13659, KAFKA-12566: Fix MM2 causing negative downstream lag

gharris1727 commented on code in PR #13178: URL: https://github.com/apache/kafka/pull/13178#discussion_r1107634292 ## connect/mirror/src/test/java/org/apache/kafka/connect/mirror/OffsetSyncStoreTest.java: ## @@ -30,7 +30,7 @@ public class OffsetSyncStoreTest { static class

[jira] [Updated] (KAFKA-14274) Introduce FetchRequestManager to integrate fetch into new consumer threading refactor

[ https://issues.apache.org/jira/browse/KAFKA-14274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-14274: -- Summary: Introduce FetchRequestManager to integrate fetch into new consumer threading refactor (was:

[jira] [Updated] (KAFKA-14274) Introduce FetchRequestManager to integrate fetch into new consumer threading refactor

[ https://issues.apache.org/jira/browse/KAFKA-14274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-14274: -- Parent: (was: KAFKA-14246) Issue Type: Improvement (was: Sub-task) > Introduce FetchReque

[jira] [Created] (KAFKA-14724) Port tests in FetcherTest to FetchRequestManagerTest

Kirk True created KAFKA-14724: - Summary: Port tests in FetcherTest to FetchRequestManagerTest Key: KAFKA-14724 URL: https://issues.apache.org/jira/browse/KAFKA-14724 Project: Kafka Issue Type: Im

[GitHub] [kafka] gharris1727 commented on a diff in pull request #13178: KAFKA-12468, KAFKA-13659, KAFKA-12566: Fix MM2 causing negative downstream lag

gharris1727 commented on code in PR #13178: URL: https://github.com/apache/kafka/pull/13178#discussion_r1107647929 ## connect/mirror/src/test/java/org/apache/kafka/connect/mirror/integration/MirrorConnectorsIntegrationBaseTest.java: ## @@ -578,7 +551,7 @@ public void testNoCheck

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #13231: KAFKA-14402: Update AddPartitionsToTxn protocol to batch and handle verifyOnly requests

jeffkbkim commented on code in PR #13231: URL: https://github.com/apache/kafka/pull/13231#discussion_r1107649386 ## clients/src/main/java/org/apache/kafka/common/requests/AddPartitionsToTxnRequest.java: ## @@ -101,15 +130,61 @@ public String toString() { public AddPartition

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #13231: KAFKA-14402: Update AddPartitionsToTxn protocol to batch and handle verifyOnly requests

jeffkbkim commented on code in PR #13231: URL: https://github.com/apache/kafka/pull/13231#discussion_r1107649386 ## clients/src/main/java/org/apache/kafka/common/requests/AddPartitionsToTxnRequest.java: ## @@ -101,15 +130,61 @@ public String toString() { public AddPartition

[GitHub] [kafka] hachikuji commented on a diff in pull request #13231: KAFKA-14402: Update AddPartitionsToTxn protocol to batch and handle verifyOnly requests

hachikuji commented on code in PR #13231: URL: https://github.com/apache/kafka/pull/13231#discussion_r1107606857 ## clients/src/main/java/org/apache/kafka/common/requests/AddPartitionsToTxnRequest.java: ## @@ -35,21 +44,43 @@ public class AddPartitionsToTxnRequest extends Abstr

[GitHub] [kafka] jolshan commented on a diff in pull request #13231: KAFKA-14402: Update AddPartitionsToTxn protocol to batch and handle verifyOnly requests

jolshan commented on code in PR #13231: URL: https://github.com/apache/kafka/pull/13231#discussion_r1107662160 ## clients/src/main/java/org/apache/kafka/common/requests/AddPartitionsToTxnRequest.java: ## @@ -101,15 +130,61 @@ public String toString() { public AddPartitionsT

[GitHub] [kafka] jolshan commented on a diff in pull request #13231: KAFKA-14402: Update AddPartitionsToTxn protocol to batch and handle verifyOnly requests

jolshan commented on code in PR #13231: URL: https://github.com/apache/kafka/pull/13231#discussion_r1107662689 ## clients/src/main/java/org/apache/kafka/common/requests/AddPartitionsToTxnRequest.java: ## @@ -66,24 +97,22 @@ public Builder(final String transactionalId,

[GitHub] [kafka] gharris1727 commented on a diff in pull request #13208: KAFKA-5756: Wait for concurrent offset flush to complete before starting next flush

gharris1727 commented on code in PR #13208: URL: https://github.com/apache/kafka/pull/13208#discussion_r1107664475 ## connect/runtime/src/test/java/org/apache/kafka/connect/storage/OffsetStorageWriterTest.java: ## @@ -135,38 +135,40 @@ public void testFlushFailureReplacesOffsets

[GitHub] [kafka] gharris1727 commented on a diff in pull request #13208: KAFKA-5756: Wait for concurrent offset flush to complete before starting next flush

gharris1727 commented on code in PR #13208: URL: https://github.com/apache/kafka/pull/13208#discussion_r1107669147 ## connect/runtime/src/main/java/org/apache/kafka/connect/storage/OffsetStorageWriter.java: ## @@ -100,23 +104,45 @@ private boolean flushing() { /** *

[GitHub] [kafka] vcrfxia commented on a diff in pull request #13243: KAFKA-14491: [7/N] Enforce strict grace period for versioned stores

vcrfxia commented on code in PR #13243: URL: https://github.com/apache/kafka/pull/13243#discussion_r1107672610 ## streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBVersionedStore.java: ## @@ -283,7 +293,12 @@ public void init(final StateStoreContext context,

[GitHub] [kafka] vcrfxia commented on pull request #13243: KAFKA-14491: [7/N] Enforce strict grace period for versioned stores

vcrfxia commented on PR #13243: URL: https://github.com/apache/kafka/pull/13243#issuecomment-1431970157 > One more thought: should we add verification about the "droppedRecordSensor" into all unit tests that drop records? Included this test update in the latest commit. I believe I've

[GitHub] [kafka] C0urante commented on a diff in pull request #13191: KAFKA-14060: Replace EasyMock and PowerMock with Mockito in AbstractWorkerSourceTaskTest

C0urante commented on code in PR #13191: URL: https://github.com/apache/kafka/pull/13191#discussion_r1107510674 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/AbstractWorkerSourceTaskTest.java: ## @@ -235,115 +236,100 @@ public void testMetricsGroup() { p

[GitHub] [kafka] vcrfxia commented on a diff in pull request #13252: KAFKA-14491: [11/N] Add metered wrapper for versioned stores

vcrfxia commented on code in PR #13252: URL: https://github.com/apache/kafka/pull/13252#discussion_r1107700533 ## streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredVersionedKeyValueStore.java: ## @@ -0,0 +1,226 @@ +/* + * Licensed to the Apache Software Found

[GitHub] [kafka] mjsax commented on a diff in pull request #13243: KAFKA-14491: [7/N] Enforce strict grace period for versioned stores

mjsax commented on code in PR #13243: URL: https://github.com/apache/kafka/pull/13243#discussion_r1107704159 ## streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBVersionedStore.java: ## @@ -283,7 +293,12 @@ public void init(final StateStoreContext context, fi

[GitHub] [kafka] mjsax commented on a diff in pull request #13243: KAFKA-14491: [7/N] Enforce strict grace period for versioned stores

mjsax commented on code in PR #13243: URL: https://github.com/apache/kafka/pull/13243#discussion_r1107705172 ## streams/src/test/java/org/apache/kafka/streams/state/internals/RocksDBVersionedStoreTest.java: ## @@ -523,6 +537,63 @@ public void shouldRestoreMultipleBatches() {

[GitHub] [kafka] mjsax commented on a diff in pull request #13243: KAFKA-14491: [7/N] Enforce strict grace period for versioned stores

mjsax commented on code in PR #13243: URL: https://github.com/apache/kafka/pull/13243#discussion_r1107707006 ## streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBVersionedStore.java: ## @@ -458,8 +460,22 @@ public void writeLatestValues(final WriteBatch batch

[GitHub] [kafka] mjsax commented on a diff in pull request #13243: KAFKA-14491: [7/N] Enforce strict grace period for versioned stores

mjsax commented on code in PR #13243: URL: https://github.com/apache/kafka/pull/13243#discussion_r1107711967 ## streams/src/test/java/org/apache/kafka/streams/state/internals/RocksDBVersionedStoreTest.java: ## @@ -523,6 +537,63 @@ public void shouldRestoreMultipleBatches() {

  1   2   >