[GitHub] [kafka] dajac merged pull request #13203: KAFKA-14048: Add new `__consumer_offsets` records from KIP-848

2023-02-09 Thread via GitHub
dajac merged PR #13203: URL: https://github.com/apache/kafka/pull/13203 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

[GitHub] [kafka] dajac merged pull request #12972: KAFKA-14391; Add ConsumerGroupHeartbeat API

2023-02-09 Thread via GitHub
dajac merged PR #12972: URL: https://github.com/apache/kafka/pull/12972 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

[jira] [Resolved] (KAFKA-14391) Add ConsumerGroupHeartbeat API

2023-02-09 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot resolved KAFKA-14391. - Fix Version/s: 3.5.0 Reviewer: Jason Gustafson Resolution: Fixed > Add ConsumerG

[jira] [Resolved] (KAFKA-14679) Add new __consumer_offsets records

2023-02-09 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14679?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot resolved KAFKA-14679. - Fix Version/s: 3.5.0 Reviewer: Mickael Maison Resolution: Fixed > Add new __cons

[jira] [Resolved] (KAFKA-14695) broker will get LEADER_AND_ISR is not enabled error while ZK migrating to KRaft

2023-02-09 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14695?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen resolved KAFKA-14695. --- Resolution: Duplicate > broker will get LEADER_AND_ISR is not enabled error while ZK migrating to >

[GitHub] [kafka] lucasbru commented on pull request #13082: MINOR: Clarify docs for Streams config max.warmup.replicas.

2023-02-09 Thread via GitHub
lucasbru commented on PR #13082: URL: https://github.com/apache/kafka/pull/13082#issuecomment-1423811305 hmmm, not sure what went wrong there. anyways, this is how it renders: ![Screenshot 2023-02-09 at 09 28 15](https://user-images.githubusercontent.com/1628637/217757939-3c2

[GitHub] [kafka] cadonna commented on pull request #13127: KAFKA-14586: Moving StreamResetter to tools

2023-02-09 Thread via GitHub
cadonna commented on PR #13127: URL: https://github.com/apache/kafka/pull/13127#issuecomment-1423822867 @vamossagar12 The PR LGTM except for the checkstyle issues. Could you also please post a link to a successful system test run of the system tests that use the streams resetter? -- This

[jira] [Commented] (KAFKA-14692) Issues in Zookeeper to KRaft migration docs

2023-02-09 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17686281#comment-17686281 ] Luke Chen commented on KAFKA-14692: --- For (4) the error: {code:java} org.apache.kafka.c

[jira] [Created] (KAFKA-14696) CVE-2023-25194: Apache Kafka: Possible RCE/Denial of service attack via SASL JAAS JndiLoginModule configuration using Kafka Connect

2023-02-09 Thread MillieZhang (Jira)
MillieZhang created KAFKA-14696: --- Summary: CVE-2023-25194: Apache Kafka: Possible RCE/Denial of service attack via SASL JAAS JndiLoginModule configuration using Kafka Connect Key: KAFKA-14696 URL: https://issues.apa

[GitHub] [kafka] vamossagar12 commented on pull request #13127: KAFKA-14586: Moving StreamResetter to tools

2023-02-09 Thread via GitHub
vamossagar12 commented on PR #13127: URL: https://github.com/apache/kafka/pull/13127#issuecomment-1423890722 Thanks @cadonna , would do the same. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kafka] mimaison commented on a diff in pull request #12366: KAFKA-14021: Implement new KIP-618 APIs in MirrorSourceConnector

2023-02-09 Thread via GitHub
mimaison commented on code in PR #12366: URL: https://github.com/apache/kafka/pull/12366#discussion_r1101228972 ## connect/mirror/README.md: ## @@ -194,6 +194,10 @@ it is important to keep configuration consistent across flows to the same target cluster. In most cases, your en

[jira] [Commented] (KAFKA-14692) Issues in Zookeeper to KRaft migration docs

2023-02-09 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17686352#comment-17686352 ] Luke Chen commented on KAFKA-14692: --- I was wrong about the workaround. It just let the

[GitHub] [kafka] ppatierno opened a new pull request, #13222: Fixed typos in KRaft related metrics documentation

2023-02-09 Thread via GitHub
ppatierno opened a new pull request, #13222: URL: https://github.com/apache/kafka/pull/13222 Trivial PR about fixing a couple of typos on KRaft related metrics documentation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [kafka] mimaison merged pull request #13222: Fixed typos in KRaft related metrics documentation

2023-02-09 Thread via GitHub
mimaison merged PR #13222: URL: https://github.com/apache/kafka/pull/13222 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[GitHub] [kafka] mimaison commented on pull request #13222: Fixed typos in KRaft related metrics documentation

2023-02-09 Thread via GitHub
mimaison commented on PR #13222: URL: https://github.com/apache/kafka/pull/13222#issuecomment-1424015276 Thanks @ppatierno, can you open a similar PR against https://github.com/apache/kafka-site? It looks like these typos are in both: - https://github.com/apache/kafka-site/blob/asf-sit

[GitHub] [kafka] ppatierno commented on pull request #13222: Fixed typos in KRaft related metrics documentation

2023-02-09 Thread via GitHub
ppatierno commented on PR #13222: URL: https://github.com/apache/kafka/pull/13222#issuecomment-1424021151 @mimaison thanks! sure will do! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [kafka] mimaison commented on a diff in pull request #12366: KAFKA-14021: Implement new KIP-618 APIs in MirrorSourceConnector

2023-02-09 Thread via GitHub
mimaison commented on code in PR #12366: URL: https://github.com/apache/kafka/pull/12366#discussion_r1101361513 ## connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorSourceConnector.java: ## @@ -188,11 +196,52 @@ public ConfigDef config() { return Mirror

[jira] [Commented] (KAFKA-14692) Issues in Zookeeper to KRaft migration docs

2023-02-09 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17686404#comment-17686404 ] Luke Chen commented on KAFKA-14692: --- [~mumrah] , I think we should filter out (isMigra

[GitHub] [kafka] satishd commented on a diff in pull request #13040: KAFKA-14480 Move/Rewrite ProducerStateManager to storage module.

2023-02-09 Thread via GitHub
satishd commented on code in PR #13040: URL: https://github.com/apache/kafka/pull/13040#discussion_r1101428207 ## core/src/test/scala/unit/kafka/log/LogTestUtils.scala: ## @@ -247,7 +246,7 @@ object LogTestUtils { } def listProducerSnapshotOffsets(logDir: File): Seq[Long

[GitHub] [kafka] satishd commented on a diff in pull request #13040: KAFKA-14480 Move/Rewrite ProducerStateManager to storage module.

2023-02-09 Thread via GitHub
satishd commented on code in PR #13040: URL: https://github.com/apache/kafka/pull/13040#discussion_r1101429242 ## core/src/test/scala/integration/kafka/api/TransactionsTest.scala: ## @@ -685,7 +685,7 @@ class TransactionsTest extends IntegrationTestHarness { // get here w

[GitHub] [kafka] satishd commented on a diff in pull request #13040: KAFKA-14480 Move/Rewrite ProducerStateManager to storage module.

2023-02-09 Thread via GitHub
satishd commented on code in PR #13040: URL: https://github.com/apache/kafka/pull/13040#discussion_r1101430927 ## core/src/main/scala/kafka/log/UnifiedLog.scala: ## @@ -680,20 +680,20 @@ class UnifiedLog(@volatile var logStartOffset: Long, } private[log] def activeProduc

[GitHub] [kafka] satishd commented on a diff in pull request #13040: KAFKA-14480 Move/Rewrite ProducerStateManager to storage module.

2023-02-09 Thread via GitHub
satishd commented on code in PR #13040: URL: https://github.com/apache/kafka/pull/13040#discussion_r1101431448 ## storage/src/main/java/org/apache/kafka/server/log/internals/ProducerStateManager.java: ## @@ -0,0 +1,671 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] satishd commented on pull request #13040: KAFKA-14480 Move/Rewrite ProducerStateManager to storage module.

2023-02-09 Thread via GitHub
satishd commented on PR #13040: URL: https://github.com/apache/kafka/pull/13040#issuecomment-1424157795 Thanks @ijuma for the review. Addressed them inline and/or with the latest commits. -- This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [kafka] bozhao12 opened a new pull request, #13223: MINOR: fix some typo in SharedServer.scala/KafkaRaftServer.scala

2023-02-09 Thread via GitHub
bozhao12 opened a new pull request, #13223: URL: https://github.com/apache/kafka/pull/13223 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of testin

[GitHub] [kafka] ijuma commented on pull request #13218: MINOR: Remove unnecessary usage of `LazyIndex`

2023-02-09 Thread via GitHub
ijuma commented on PR #13218: URL: https://github.com/apache/kafka/pull/13218#issuecomment-1424207352 @satishd Thanks for the explanation. Can you show me where that happens? You can see that every change I made included a `.get.sanityCheck` call immediately after creation. -- This is an

[GitHub] [kafka] ijuma commented on a diff in pull request #13040: KAFKA-14480 Move/Rewrite ProducerStateManager to storage module.

2023-02-09 Thread via GitHub
ijuma commented on code in PR #13040: URL: https://github.com/apache/kafka/pull/13040#discussion_r1101480397 ## core/src/main/scala/kafka/log/UnifiedLog.scala: ## @@ -680,20 +680,20 @@ class UnifiedLog(@volatile var logStartOffset: Long, } private[log] def activeProducer

[GitHub] [kafka] ijuma commented on a diff in pull request #13040: KAFKA-14480 Move/Rewrite ProducerStateManager to storage module.

2023-02-09 Thread via GitHub
ijuma commented on code in PR #13040: URL: https://github.com/apache/kafka/pull/13040#discussion_r1101481342 ## core/src/test/scala/unit/kafka/log/LogTestUtils.scala: ## @@ -247,7 +246,7 @@ object LogTestUtils { } def listProducerSnapshotOffsets(logDir: File): Seq[Long]

[GitHub] [kafka] ijuma commented on pull request #13040: KAFKA-14480 Move/Rewrite ProducerStateManager to storage module.

2023-02-09 Thread via GitHub
ijuma commented on PR #13040: URL: https://github.com/apache/kafka/pull/13040#issuecomment-1424214703 Thanks for the updates, I'll review them in a couple of days. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [kafka] littlehorse-eng commented on pull request #13082: MINOR: Clarify docs for Streams config max.warmup.replicas.

2023-02-09 Thread via GitHub
littlehorse-eng commented on PR #13082: URL: https://github.com/apache/kafka/pull/13082#issuecomment-1424221038 Thank you very much for the assist here! This looks how I was hoping it would look…not bad for a backend engineer 😉 Now we just need to have someone confirm the actual cha

[GitHub] [kafka] dajac merged pull request #12590: KAFKA-7109: Close fetch sessions on close of consumer

2023-02-09 Thread via GitHub
dajac merged PR #12590: URL: https://github.com/apache/kafka/pull/12590 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

[GitHub] [kafka] stanislavkozlovski merged pull request #13199: MINOR: Update build and test dependencies for 3.5

2023-02-09 Thread via GitHub
stanislavkozlovski merged PR #13199: URL: https://github.com/apache/kafka/pull/13199 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@ka

[jira] [Commented] (KAFKA-14692) Issues in Zookeeper to KRaft migration docs

2023-02-09 Thread David Arthur (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17686568#comment-17686568 ] David Arthur commented on KAFKA-14692: -- [~mimaison] do you mind opening a new ticke

[jira] [Updated] (KAFKA-14692) Issues in Zookeeper to KRaft migration docs

2023-02-09 Thread David Arthur (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14692?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur updated KAFKA-14692: - Component/s: kraft > Issues in Zookeeper to KRaft migration docs > -

[jira] [Created] (KAFKA-14697) KRaft controller should not send LISR to KRaft brokers during migration

2023-02-09 Thread David Arthur (Jira)
David Arthur created KAFKA-14697: Summary: KRaft controller should not send LISR to KRaft brokers during migration Key: KAFKA-14697 URL: https://issues.apache.org/jira/browse/KAFKA-14697 Project: Kafk

[jira] [Comment Edited] (KAFKA-14692) Issues in Zookeeper to KRaft migration docs

2023-02-09 Thread David Arthur (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17686568#comment-17686568 ] David Arthur edited comment on KAFKA-14692 at 2/9/23 3:21 PM:

[jira] [Comment Edited] (KAFKA-14692) Issues in Zookeeper to KRaft migration docs

2023-02-09 Thread David Arthur (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17686568#comment-17686568 ] David Arthur edited comment on KAFKA-14692 at 2/9/23 3:21 PM:

[jira] [Commented] (KAFKA-14697) KRaft controller should not send LISR to KRaft brokers during migration

2023-02-09 Thread David Arthur (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17686590#comment-17686590 ] David Arthur commented on KAFKA-14697: -- cc [~showuon] [~mimaison] > KRaft controll

[jira] [Updated] (KAFKA-14692) Issues in Zookeeper to KRaft migration docs

2023-02-09 Thread David Arthur (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14692?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur updated KAFKA-14692: - Fix Version/s: 3.5.0 3.4.1 > Issues in Zookeeper to KRaft migration docs > --

[jira] [Commented] (KAFKA-14698) Received request api key LEADER_AND_ISR which is not enabled

2023-02-09 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17686592#comment-17686592 ] Mickael Maison commented on KAFKA-14698: cc [~mumrah] > Received request api ke

[jira] [Created] (KAFKA-14698) Received request api key LEADER_AND_ISR which is not enabled

2023-02-09 Thread Mickael Maison (Jira)
Mickael Maison created KAFKA-14698: -- Summary: Received request api key LEADER_AND_ISR which is not enabled Key: KAFKA-14698 URL: https://issues.apache.org/jira/browse/KAFKA-14698 Project: Kafka

[jira] [Commented] (KAFKA-14692) Issues in Zookeeper to KRaft migration docs

2023-02-09 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17686594#comment-17686594 ] Mickael Maison commented on KAFKA-14692: Closing this ticket as we've addressed

[jira] [Commented] (KAFKA-14692) Issues in Zookeeper to KRaft migration docs

2023-02-09 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17686595#comment-17686595 ] Mickael Maison commented on KAFKA-14692: Actually not closing just yet as so far

[GitHub] [kafka] fvaleri commented on a diff in pull request #13215: KAFKA-14578: Move ConsumerPerformance to tools

2023-02-09 Thread via GitHub
fvaleri commented on code in PR #13215: URL: https://github.com/apache/kafka/pull/13215#discussion_r1101636896 ## tools/src/main/java/org/apache/kafka/tools/ConsumerPerformance.java: ## @@ -0,0 +1,394 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more

[GitHub] [kafka] fvaleri commented on a diff in pull request #13215: KAFKA-14578: Move ConsumerPerformance to tools

2023-02-09 Thread via GitHub
fvaleri commented on code in PR #13215: URL: https://github.com/apache/kafka/pull/13215#discussion_r1101637316 ## tools/src/main/java/org/apache/kafka/tools/ConsumerPerformance.java: ## @@ -0,0 +1,394 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more

[jira] [Created] (KAFKA-14699) Kafka Connect framework errors.tolerance improvement

2023-02-09 Thread Miguel Costa (Jira)
Miguel Costa created KAFKA-14699: Summary: Kafka Connect framework errors.tolerance improvement Key: KAFKA-14699 URL: https://issues.apache.org/jira/browse/KAFKA-14699 Project: Kafka Issue T

[GitHub] [kafka] fvaleri commented on pull request #13122: KAFKA-14594: Move LogDirsCommand to tools module

2023-02-09 Thread via GitHub
fvaleri commented on PR #13122: URL: https://github.com/apache/kafka/pull/13122#issuecomment-1424403375 @mimaison I think this is ready if you have time for a review :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[GitHub] [kafka] C0urante commented on pull request #13137: KAFKA-15086: Intra-cluster communication for Mirror Maker 2

2023-02-09 Thread via GitHub
C0urante commented on PR #13137: URL: https://github.com/apache/kafka/pull/13137#issuecomment-1424408278 Thanks for the reviews, everyone! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[jira] [Assigned] (KAFKA-9981) Running a dedicated mm2 cluster with more than one nodes,When the configuration is updated the task is not aware and will lose the update operation.

2023-02-09 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton reassigned KAFKA-9981: Assignee: Chris Egerton > Running a dedicated mm2 cluster with more than one nodes,When th

[jira] [Resolved] (KAFKA-14697) KRaft controller should not send LISR to KRaft brokers during migration

2023-02-09 Thread David Arthur (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14697?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur resolved KAFKA-14697. -- Fix Version/s: (was: 3.5.0) (was: 3.4.1) Resolution: Duplicat

[jira] [Commented] (KAFKA-14697) KRaft controller should not send LISR to KRaft brokers during migration

2023-02-09 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17686613#comment-17686613 ] Mickael Maison commented on KAFKA-14697: Ignoring the errors and continuing the

[jira] [Commented] (KAFKA-14698) Received request api key LEADER_AND_ISR which is not enabled

2023-02-09 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17686614#comment-17686614 ] Mickael Maison commented on KAFKA-14698: Ignoring the errors and continuing the

[GitHub] [kafka] C0urante merged pull request #13137: KAFKA-15086, KAFKA-9981: Intra-cluster communication for Mirror Maker 2

2023-02-09 Thread via GitHub
C0urante merged PR #13137: URL: https://github.com/apache/kafka/pull/13137 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Updated] (KAFKA-14698) Received request api key LEADER_AND_ISR which is not enabled

2023-02-09 Thread David Arthur (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14698?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur updated KAFKA-14698: - Fix Version/s: 3.5.0 3.4.1 > Received request api key LEADER_AND_ISR which is

[jira] [Resolved] (KAFKA-9981) Running a dedicated mm2 cluster with more than one nodes,When the configuration is updated the task is not aware and will lose the update operation.

2023-02-09 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton resolved KAFKA-9981. -- Fix Version/s: 3.5.0 Resolution: Fixed > Running a dedicated mm2 cluster with more than

[jira] [Updated] (KAFKA-14698) Received request api key LEADER_AND_ISR which is not enabled

2023-02-09 Thread David Arthur (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14698?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur updated KAFKA-14698: - Attachment: test_online_migration.tar.gz > Received request api key LEADER_AND_ISR which is not

[jira] [Commented] (KAFKA-14698) Received request api key LEADER_AND_ISR which is not enabled

2023-02-09 Thread David Arthur (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17686615#comment-17686615 ] David Arthur commented on KAFKA-14698: -- Thanks [~mimaison]. I've uploaded the logs

[GitHub] [kafka] C0urante commented on pull request #8656: KAFKA-9981; dedicated mm2 cluster lose the update operation.

2023-02-09 Thread via GitHub
C0urante commented on PR #8656: URL: https://github.com/apache/kafka/pull/8656#issuecomment-1424416521 Closing as this issue has been addressed by https://github.com/apache/kafka/pull/13137 / [KIP-710](https://cwiki.apache.org/confluence/display/KAFKA/KIP-710%3A+Full+support+for+distributed

[GitHub] [kafka] C0urante closed pull request #8656: KAFKA-9981; dedicated mm2 cluster lose the update operation.

2023-02-09 Thread via GitHub
C0urante closed pull request #8656: KAFKA-9981; dedicated mm2 cluster lose the update operation. URL: https://github.com/apache/kafka/pull/8656 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[jira] [Commented] (KAFKA-14698) Received request api key LEADER_AND_ISR which is not enabled

2023-02-09 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17686618#comment-17686618 ] Mickael Maison commented on KAFKA-14698: Yeah it seems it's just noise in the en

[jira] [Commented] (KAFKA-14698) Received request api key LEADER_AND_ISR which is not enabled

2023-02-09 Thread David Arthur (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17686623#comment-17686623 ] David Arthur commented on KAFKA-14698: -- Yea, I agree. Any ERROR is pretty concernin

[GitHub] [kafka] C0urante commented on pull request #13137: KAFKA-15086, KAFKA-9981: Intra-cluster communication for Mirror Maker 2

2023-02-09 Thread via GitHub
C0urante commented on PR #13137: URL: https://github.com/apache/kafka/pull/13137#issuecomment-1424428493 Whoops--there was a typo in the title at the time of merge. It should refer to [KAFKA-10586](https://issues.apache.org/jira/browse/KAFKA-10586), not KAFKA-15086. -- This is an automat

[jira] [Assigned] (KAFKA-14698) Received request api key LEADER_AND_ISR which is not enabled

2023-02-09 Thread David Arthur (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14698?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur reassigned KAFKA-14698: Assignee: Akhilesh Chaganti > Received request api key LEADER_AND_ISR which is not enable

[jira] [Commented] (KAFKA-14674) Backport fix for KAFKA-14455 to 3.3 and 3.4 branches

2023-02-09 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-14674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17686648#comment-17686648 ] Marcel Stör commented on KAFKA-14674: - I wasn't able to find any EOL information on

[GitHub] [kafka] pprovenzano commented on a diff in pull request #13114: KAFKA-14084: SCRAM support in KRaft.

2023-02-09 Thread via GitHub
pprovenzano commented on code in PR #13114: URL: https://github.com/apache/kafka/pull/13114#discussion_r1101766963 ## metadata/src/main/java/org/apache/kafka/controller/ScramControlManager.java: ## @@ -0,0 +1,307 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [kafka] omkreddy commented on a diff in pull request #13114: KAFKA-14084: SCRAM support in KRaft.

2023-02-09 Thread via GitHub
omkreddy commented on code in PR #13114: URL: https://github.com/apache/kafka/pull/13114#discussion_r1101769724 ## metadata/src/main/java/org/apache/kafka/controller/ScramControlManager.java: ## @@ -0,0 +1,307 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [kafka] pprovenzano commented on a diff in pull request #13114: KAFKA-14084: SCRAM support in KRaft.

2023-02-09 Thread via GitHub
pprovenzano commented on code in PR #13114: URL: https://github.com/apache/kafka/pull/13114#discussion_r1101777913 ## metadata/src/main/java/org/apache/kafka/image/ScramImage.java: ## @@ -0,0 +1,97 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [kafka] C0urante commented on pull request #13178: KAFKA-12468, KAFKA-12566: Fix MM2 causing negative downstream lag

2023-02-09 Thread via GitHub
C0urante commented on PR #13178: URL: https://github.com/apache/kafka/pull/13178#issuecomment-1424539164 @mimaison This is a moderately large change in behavior and if possible, it'd be nice to get another set of eyes on it before merging. We don't need another reviewer for the PR changes (

[GitHub] [kafka] fvaleri commented on a diff in pull request #13214: KAFKA-14577: Move the scala ConsoleProducer from core to tools module

2023-02-09 Thread via GitHub
fvaleri commented on code in PR #13214: URL: https://github.com/apache/kafka/pull/13214#discussion_r1101716594 ## server-common/src/main/java/org/apache/kafka/server/util/ToolsUtils.java: ## @@ -16,17 +16,29 @@ */ package org.apache.kafka.server.util; +import joptsimple.Opt

[GitHub] [kafka] fvaleri commented on a diff in pull request #13214: KAFKA-14577: Move the scala ConsoleProducer from core to tools module

2023-02-09 Thread via GitHub
fvaleri commented on code in PR #13214: URL: https://github.com/apache/kafka/pull/13214#discussion_r1101811769 ## tools/src/main/java/org/apache/kafka/tools/MessageReader.java: ## @@ -0,0 +1,48 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * con

[GitHub] [kafka] fvaleri commented on pull request #13214: KAFKA-14577: Move the scala ConsoleProducer from core to tools module

2023-02-09 Thread via GitHub
fvaleri commented on PR #13214: URL: https://github.com/apache/kafka/pull/13214#issuecomment-1424569047 @showuon if you have some time, this looks almost ready. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[jira] [Created] (KAFKA-14700) Produce request interceptors

2023-02-09 Thread David Mariassy (Jira)
David Mariassy created KAFKA-14700: -- Summary: Produce request interceptors Key: KAFKA-14700 URL: https://issues.apache.org/jira/browse/KAFKA-14700 Project: Kafka Issue Type: Improvement

[jira] [Assigned] (KAFKA-6793) Unnecessary warning log message

2023-02-09 Thread Philip Nee (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-6793?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Philip Nee reassigned KAFKA-6793: - Assignee: Philip Nee > Unnecessary warning log message > > >

[GitHub] [kafka] dmariassy opened a new pull request, #13224: KAFKA-14700: Produce request interceptors

2023-02-09 Thread via GitHub
dmariassy opened a new pull request, #13224: URL: https://github.com/apache/kafka/pull/13224 First stab at implementing produce request interceptors as defined in KIP-905 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify t

[GitHub] [kafka] philipnee opened a new pull request, #13225: KAFKA-6793

2023-02-09 Thread via GitHub
philipnee opened a new pull request, #13225: URL: https://github.com/apache/kafka/pull/13225 Reviving this old discussion, apparently the PR was closed so I reopened another one. **Issue**: Recently we've encountered complaints about the warning being too noisy, therefore we want to

[GitHub] [kafka] akhileshchg commented on a diff in pull request #13183: KAFKA-14668 Avoid unnecessary UMR during ZK migration

2023-02-09 Thread via GitHub
akhileshchg commented on code in PR #13183: URL: https://github.com/apache/kafka/pull/13183#discussion_r1101829449 ## metadata/src/main/java/org/apache/kafka/metadata/migration/KRaftMigrationDriver.java: ## @@ -274,11 +310,6 @@ public void run() throws Exception {

[jira] [Commented] (KAFKA-6793) Unnecessary warning log message

2023-02-09 Thread Philip Nee (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-6793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17686677#comment-17686677 ] Philip Nee commented on KAFKA-6793: --- We're also observing the same issue.   > Unnecess

[GitHub] [kafka] jolshan commented on a diff in pull request #13202: KAFKA-14513; Add broker side PartitionAssignor interface

2023-02-09 Thread via GitHub
jolshan commented on code in PR #13202: URL: https://github.com/apache/kafka/pull/13202#discussion_r1101847493 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/AssignmentSpec.java: ## @@ -0,0 +1,73 @@ +/* + * Licensed to the Apache Software Foundati

[GitHub] [kafka] mumrah commented on a diff in pull request #13183: KAFKA-14668 Avoid unnecessary UMR during ZK migration

2023-02-09 Thread via GitHub
mumrah commented on code in PR #13183: URL: https://github.com/apache/kafka/pull/13183#discussion_r1101861663 ## metadata/src/main/java/org/apache/kafka/metadata/migration/KRaftMigrationDriver.java: ## @@ -274,11 +310,6 @@ public void run() throws Exception { ne

[GitHub] [kafka] jolshan commented on a diff in pull request #13202: KAFKA-14513; Add broker side PartitionAssignor interface

2023-02-09 Thread via GitHub
jolshan commented on code in PR #13202: URL: https://github.com/apache/kafka/pull/13202#discussion_r1101861603 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/GroupAssignment.java: ## @@ -0,0 +1,57 @@ +/* + * Licensed to the Apache Software Foundat

[GitHub] [kafka] jolshan commented on a diff in pull request #13202: KAFKA-14513; Add broker side PartitionAssignor interface

2023-02-09 Thread via GitHub
jolshan commented on code in PR #13202: URL: https://github.com/apache/kafka/pull/13202#discussion_r1101863484 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/PartitionAssignor.java: ## @@ -0,0 +1,43 @@ +/* + * Licensed to the Apache Software Found

[GitHub] [kafka] mumrah merged pull request #13183: KAFKA-14668 Avoid unnecessary UMR during ZK migration

2023-02-09 Thread via GitHub
mumrah merged PR #13183: URL: https://github.com/apache/kafka/pull/13183 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.o

[GitHub] [kafka] jolshan commented on a diff in pull request #13202: KAFKA-14513; Add broker side PartitionAssignor interface

2023-02-09 Thread via GitHub
jolshan commented on code in PR #13202: URL: https://github.com/apache/kafka/pull/13202#discussion_r1101869241 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/PartitionAssignor.java: ## @@ -0,0 +1,43 @@ +/* + * Licensed to the Apache Software Found

[GitHub] [kafka] jolshan commented on a diff in pull request #13202: KAFKA-14513; Add broker side PartitionAssignor interface

2023-02-09 Thread via GitHub
jolshan commented on code in PR #13202: URL: https://github.com/apache/kafka/pull/13202#discussion_r1101869241 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/PartitionAssignor.java: ## @@ -0,0 +1,43 @@ +/* + * Licensed to the Apache Software Found

[GitHub] [kafka] junrao commented on a diff in pull request #13206: [KAFKA-14685] Refactor logic to handle OFFSET_MOVED_TO_TIERED_STORAGE error

2023-02-09 Thread via GitHub
junrao commented on code in PR #13206: URL: https://github.com/apache/kafka/pull/13206#discussion_r1101875350 ## core/src/main/java/kafka/server/ReplicaFetcherTierStateMachine.java: ## @@ -0,0 +1,265 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more +

[jira] [Assigned] (KAFKA-14693) KRaft Controller and ProcessExitingFaultHandler can deadlock shutdown

2023-02-09 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-14693?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] José Armando García Sancio reassigned KAFKA-14693: -- Assignee: José Armando García Sancio > KRaft Controller and P

[GitHub] [kafka] guozhangwang merged pull request #13167: KAFKA-14650: Synchronize access to tasks inside task manager

2023-02-09 Thread via GitHub
guozhangwang merged PR #13167: URL: https://github.com/apache/kafka/pull/13167 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.ap

[jira] [Commented] (KAFKA-14696) CVE-2023-25194: Apache Kafka: Possible RCE/Denial of service attack via SASL JAAS JndiLoginModule configuration using Kafka Connect

2023-02-09 Thread Manikumar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17686696#comment-17686696 ] Manikumar commented on KAFKA-14696: --- There are no plans to provide a patch for older v

[GitHub] [kafka] vcrfxia commented on a diff in pull request #13188: KAFKA-14491: [5/N] Basic operations for RocksDB versioned store

2023-02-09 Thread via GitHub
vcrfxia commented on code in PR #13188: URL: https://github.com/apache/kafka/pull/13188#discussion_r1101882173 ## streams/src/main/java/org/apache/kafka/streams/state/VersionedKeyValueStore.java: ## @@ -0,0 +1,99 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [kafka] Hangleton commented on a diff in pull request #13214: KAFKA-14577: Move the scala ConsoleProducer from core to tools module

2023-02-09 Thread via GitHub
Hangleton commented on code in PR #13214: URL: https://github.com/apache/kafka/pull/13214#discussion_r1101887714 ## tools/src/main/java/org/apache/kafka/tools/MessageReader.java: ## @@ -0,0 +1,48 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * c

[GitHub] [kafka] dajac commented on a diff in pull request #13202: KAFKA-14513; Add broker side PartitionAssignor interface

2023-02-09 Thread via GitHub
dajac commented on code in PR #13202: URL: https://github.com/apache/kafka/pull/13202#discussion_r1101888535 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/PartitionAssignor.java: ## @@ -0,0 +1,43 @@ +/* + * Licensed to the Apache Software Foundat

[GitHub] [kafka] dajac commented on a diff in pull request #13202: KAFKA-14513; Add broker side PartitionAssignor interface

2023-02-09 Thread via GitHub
dajac commented on code in PR #13202: URL: https://github.com/apache/kafka/pull/13202#discussion_r1101889893 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/PartitionAssignor.java: ## @@ -0,0 +1,43 @@ +/* + * Licensed to the Apache Software Foundat

[GitHub] [kafka] lmr3796 commented on pull request #13187: MINOR: Log lastCaughtUpTime on ISR shrinkage

2023-02-09 Thread via GitHub
lmr3796 commented on PR #13187: URL: https://github.com/apache/kafka/pull/13187#issuecomment-1424662401 @clolov for visibility -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [kafka] vcrfxia commented on a diff in pull request #13188: KAFKA-14491: [5/N] Basic operations for RocksDB versioned store

2023-02-09 Thread via GitHub
vcrfxia commented on code in PR #13188: URL: https://github.com/apache/kafka/pull/13188#discussion_r1101897601 ## streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBVersionedStore.java: ## @@ -0,0 +1,792 @@ +/* + * Licensed to the Apache Software Foundation (A

[GitHub] [kafka] jolshan commented on a diff in pull request #13202: KAFKA-14513; Add broker side PartitionAssignor interface

2023-02-09 Thread via GitHub
jolshan commented on code in PR #13202: URL: https://github.com/apache/kafka/pull/13202#discussion_r1101899467 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/PartitionAssignor.java: ## @@ -0,0 +1,43 @@ +/* + * Licensed to the Apache Software Found

[GitHub] [kafka] jolshan commented on a diff in pull request #13202: KAFKA-14513; Add broker side PartitionAssignor interface

2023-02-09 Thread via GitHub
jolshan commented on code in PR #13202: URL: https://github.com/apache/kafka/pull/13202#discussion_r1101900196 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/PartitionAssignor.java: ## @@ -0,0 +1,43 @@ +/* + * Licensed to the Apache Software Found

[GitHub] [kafka] vcrfxia commented on a diff in pull request #13188: KAFKA-14491: [5/N] Basic operations for RocksDB versioned store

2023-02-09 Thread via GitHub
vcrfxia commented on code in PR #13188: URL: https://github.com/apache/kafka/pull/13188#discussion_r1101902156 ## streams/src/main/java/org/apache/kafka/streams/state/VersionedKeyValueStore.java: ## @@ -0,0 +1,99 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [kafka] vcrfxia commented on a diff in pull request #13189: KAFKA-14491: [6/N] Support restoring RocksDB versioned store from changelog

2023-02-09 Thread via GitHub
vcrfxia commented on code in PR #13189: URL: https://github.com/apache/kafka/pull/13189#discussion_r1101910583 ## streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBVersionedStore.java: ## @@ -0,0 +1,877 @@ +/* + * Licensed to the Apache Software Foundation (A

[GitHub] [kafka] vcrfxia commented on a diff in pull request #13189: KAFKA-14491: [6/N] Support restoring RocksDB versioned store from changelog

2023-02-09 Thread via GitHub
vcrfxia commented on code in PR #13189: URL: https://github.com/apache/kafka/pull/13189#discussion_r1101914047 ## streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBVersionedStore.java: ## @@ -333,10 +384,34 @@ interface VersionedStoreSegment { long s

[GitHub] [kafka] vcrfxia commented on a diff in pull request #13189: KAFKA-14491: [6/N] Support restoring RocksDB versioned store from changelog

2023-02-09 Thread via GitHub
vcrfxia commented on code in PR #13189: URL: https://github.com/apache/kafka/pull/13189#discussion_r1101915894 ## streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBVersionedStoreRestoreWriteBuffer.java: ## @@ -0,0 +1,269 @@ +/* + * Licensed to the Apache Soft

[jira] [Updated] (KAFKA-14700) Produce request interceptors

2023-02-09 Thread David Mariassy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Mariassy updated KAFKA-14700: --- Description: See [KIP-905|https://cwiki.apache.org/confluence/display/KAFKA/KIP-905%3A+Broke

  1   2   >