dajac merged PR #13200:
URL: https://github.com/apache/kafka/pull/13200
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
[
https://issues.apache.org/jira/browse/KAFKA-14678?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Jacot resolved KAFKA-14678.
-
Fix Version/s: 3.5.0
Resolution: Fixed
> Move __consumer_offsets records from core to gro
[
https://issues.apache.org/jira/browse/KAFKA-14513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Jacot reassigned KAFKA-14513:
---
Assignee: David Jacot
> Add broker side PartitionAssignor interface
> -
dajac commented on PR #13203:
URL: https://github.com/apache/kafka/pull/13203#issuecomment-1420381203
Hey @mimaison. As you reviewed https://github.com/apache/kafka/pull/13200,
do you mind reviewing this one?
--
This is an automated message from the Apache Git Service.
To respond to the
satishd commented on code in PR #13206:
URL: https://github.com/apache/kafka/pull/13206#discussion_r1098319549
##
core/src/main/java/kafka/server/ReplicaFetcherTierStateMachine.java:
##
@@ -0,0 +1,246 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
fvaleri commented on PR #13171:
URL: https://github.com/apache/kafka/pull/13171#issuecomment-1420398056
Given that clearly nobody is using this tool, I'm wondering if we should
deprecate in 3.5 and remove in 4.0.
--
This is an automated message from the Apache Git Service.
To respond to t
[
https://issues.apache.org/jira/browse/KAFKA-14630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17685181#comment-17685181
]
Divij Vaidya commented on KAFKA-14630:
--
I have added a new feature to zstd-jni whic
satishd commented on PR #13046:
URL: https://github.com/apache/kafka/pull/13046#issuecomment-1420484181
Test failures do not seem to be related to the PR changes, merging to trunk.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
[
https://issues.apache.org/jira/browse/KAFKA-14635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17685183#comment-17685183
]
Divij Vaidya commented on KAFKA-14635:
--
This might not have much benefit since Zstd
[
https://issues.apache.org/jira/browse/KAFKA-14631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17685186#comment-17685186
]
Divij Vaidya commented on KAFKA-14631:
--
Today, in the code, we validate that not un
satishd merged PR #13046:
URL: https://github.com/apache/kafka/pull/13046
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
mimaison commented on code in PR #13203:
URL: https://github.com/apache/kafka/pull/13203#discussion_r1098462254
##
group-coordinator/src/main/resources/common/message/ConsumerGroupCurrentMemberAssignmentKey.json:
##
@@ -0,0 +1,26 @@
+// Licensed to the Apache Software Foundation
clolov opened a new pull request, #13210:
URL: https://github.com/apache/kafka/pull/13210
I ran IntelliJ IDEA's Code Inspection and corrected occurrences of the
following:
*
https://www.jetbrains.com/help/idea/list-of-java-inspections.html#class-structure
(final method in final class)
clolov commented on PR #13210:
URL: https://github.com/apache/kafka/pull/13210#issuecomment-1420581252
@divijvaidya for visibility
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
fvaleri commented on code in PR #13122:
URL: https://github.com/apache/kafka/pull/13122#discussion_r1098445584
##
tools/src/main/java/org/apache/kafka/tools/LogDirsCommand.java:
##
@@ -0,0 +1,174 @@
+package org.apache.kafka.tools;
+
+import com.fasterxml.jackson.core.JsonProces
fvaleri commented on code in PR #13122:
URL: https://github.com/apache/kafka/pull/13122#discussion_r1098445584
##
tools/src/main/java/org/apache/kafka/tools/LogDirsCommand.java:
##
@@ -0,0 +1,174 @@
+package org.apache.kafka.tools;
+
+import com.fasterxml.jackson.core.JsonProces
fvaleri commented on code in PR #13122:
URL: https://github.com/apache/kafka/pull/13122#discussion_r1098517712
##
clients/src/test/java/org/apache/kafka/clients/admin/MockAdminClient.java:
##
@@ -870,7 +870,37 @@ synchronized public AlterReplicaLogDirsResult
alterReplicaLogDirs
mimaison commented on PR #13208:
URL: https://github.com/apache/kafka/pull/13208#issuecomment-1420604272
Thanks @gharris1727 for the PR! The changes look good to me. Since it's an
old and tricky issue, I'd like @C0urante to also take a look, if possible,
before merging.
--
This is an aut
rajinisivaram opened a new pull request, #13211:
URL: https://github.com/apache/kafka/pull/13211
We currently cache login managers in static maps for both static JAAS config
using system property and for JAAS config specified using Kafka config
`sasl.jaas.config`. In addition to the JAAS co
mimaison commented on PR #12366:
URL: https://github.com/apache/kafka/pull/12366#issuecomment-1420613374
@C0urante Let's try to get this in. If you rebase I'll take another look
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
clolov opened a new pull request, #13212:
URL: https://github.com/apache/kafka/pull/13212
I ran IntelliJ IDEA's Code Inspection and corrected occurrences of the
following:
* https://www.jetbrains.com/help/idea/list-of-java-inspections.html#javadoc
(declaration has problems in Javadoc ref
clolov commented on PR #13212:
URL: https://github.com/apache/kafka/pull/13212#issuecomment-1420626007
@divijvaidya for visibility
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
Ahmed Toumi created KAFKA-14687:
---
Summary: Possible issue on documentation : producerConfig ->
retries
Key: KAFKA-14687
URL: https://issues.apache.org/jira/browse/KAFKA-14687
Project: Kafka
Is
Satish Duggana created KAFKA-14688:
--
Summary: Move org.apache.kafka.server.log.internals to
org.apache.kafka.storage.internals.log
Key: KAFKA-14688
URL: https://issues.apache.org/jira/browse/KAFKA-14688
[
https://issues.apache.org/jira/browse/KAFKA-14688?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Satish Duggana updated KAFKA-14688:
---
Description: This is a followup item from
https://github.com/apache/kafka/pull/13046 with th
satishd opened a new pull request, #13213:
URL: https://github.com/apache/kafka/pull/13213
KAFKA-14688 Move package org.apache.kafka.server.log.internals to
org.apache.kafka.storage.internals.log
This is a followup item from https://github.com/apache/kafka/pull/13046 with
the [commen
satishd commented on code in PR #13213:
URL: https://github.com/apache/kafka/pull/13213#discussion_r1098558585
##
storage/src/main/java/org/apache/kafka/storage/internals/log/AbstractIndex.java:
##
@@ -64,8 +65,7 @@ private enum SearchResultType {
*/
private volatile
showuon commented on code in PR #13099:
URL: https://github.com/apache/kafka/pull/13099#discussion_r1098593071
##
clients/src/main/java/org/apache/kafka/common/utils/Utils.java:
##
@@ -1496,4 +1496,32 @@ public static String replaceSuffix(String str, String
oldSuffix, String ne
showuon commented on code in PR #13099:
URL: https://github.com/apache/kafka/pull/13099#discussion_r1098593520
##
clients/src/main/java/org/apache/kafka/common/utils/Utils.java:
##
@@ -1496,4 +1496,32 @@ public static String replaceSuffix(String str, String
oldSuffix, String ne
showuon commented on PR #13099:
URL: https://github.com/apache/kafka/pull/13099#issuecomment-1420692624
@ijuma @tombentley @clolov , I've updated the PR to throw exception when
overflowed. Please take a look again. Thank you.
--
This is an automated message from the Apache Git Service.
To
dajac commented on code in PR #13116:
URL: https://github.com/apache/kafka/pull/13116#discussion_r1098623901
##
core/src/main/scala/kafka/server/ControllerApis.scala:
##
@@ -322,15 +325,37 @@ class ControllerApis(val requestChannel: RequestChannel,
}
}
dajac commented on code in PR #12972:
URL: https://github.com/apache/kafka/pull/12972#discussion_r1098628288
##
clients/src/main/java/org/apache/kafka/common/errors/FencedMemberEpochException.java:
##
@@ -0,0 +1,23 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) unde
dajac commented on code in PR #12972:
URL: https://github.com/apache/kafka/pull/12972#discussion_r1098630635
##
clients/src/main/java/org/apache/kafka/common/protocol/ApiKeys.java:
##
@@ -212,6 +215,36 @@ public boolean isVersionSupported(short apiVersion) {
return apiV
dajac commented on code in PR #12972:
URL: https://github.com/apache/kafka/pull/12972#discussion_r1098633270
##
clients/src/main/resources/common/message/ConsumerGroupHeartbeatResponse.json:
##
@@ -0,0 +1,70 @@
+// Licensed to the Apache Software Foundation (ASF) under one or mo
dajac commented on code in PR #12972:
URL: https://github.com/apache/kafka/pull/12972#discussion_r1098634292
##
clients/src/main/resources/common/message/ConsumerGroupHeartbeatResponse.json:
##
@@ -0,0 +1,70 @@
+// Licensed to the Apache Software Foundation (ASF) under one or mo
dajac commented on code in PR #12972:
URL: https://github.com/apache/kafka/pull/12972#discussion_r1098634689
##
core/src/main/scala/kafka/server/ApiVersionManager.scala:
##
@@ -45,55 +45,70 @@ object ApiVersionManager {
listenerType,
forwardingManager,
suppo
dajac commented on code in PR #12972:
URL: https://github.com/apache/kafka/pull/12972#discussion_r1098641948
##
generator/src/main/java/org/apache/kafka/message/MessageSpec.java:
##
@@ -70,6 +74,12 @@ public MessageSpec(@JsonProperty("name") String name,
"messag
dajac commented on code in PR #12972:
URL: https://github.com/apache/kafka/pull/12972#discussion_r1098642239
##
generator/src/main/java/org/apache/kafka/message/RequestApiStabilityType.java:
##
@@ -0,0 +1,27 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one o
urbandan commented on PR #13163:
URL: https://github.com/apache/kafka/pull/13163#issuecomment-1420758683
@C0urante Thanks for the comments, addressed them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
clolov commented on PR #13212:
URL: https://github.com/apache/kafka/pull/13212#issuecomment-1420762600
```
[2023-02-07T11:33:01.745Z] > Task :clients:compileJava
[2023-02-07T11:33:01.745Z]
/home/jenkins/jenkins-agent/workspace/Kafka_kafka-pr_PR-13212/clients/src/main/java/org/apach
ijuma commented on code in PR #13213:
URL: https://github.com/apache/kafka/pull/13213#discussion_r1098655061
##
storage/src/main/java/org/apache/kafka/storage/internals/log/AbstractIndex.java:
##
@@ -64,8 +65,7 @@ private enum SearchResultType {
*/
private volatile in
lucasbru commented on code in PR #13025:
URL: https://github.com/apache/kafka/pull/13025#discussion_r1097298086
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java:
##
@@ -1534,7 +1540,13 @@ Set standbyTaskIds() {
Map allTasks() {
dajac commented on code in PR #12972:
URL: https://github.com/apache/kafka/pull/12972#discussion_r1098684544
##
clients/src/main/java/org/apache/kafka/common/protocol/ApiKeys.java:
##
@@ -212,6 +215,36 @@ public boolean isVersionSupported(short apiVersion) {
return apiV
dajac commented on code in PR #12972:
URL: https://github.com/apache/kafka/pull/12972#discussion_r1098685000
##
core/src/test/scala/unit/kafka/server/ApiVersionManagerTest.scala:
##
@@ -40,10 +40,15 @@ class ApiVersionManagerTest {
listenerType = apiScope,
forwardi
dajac commented on code in PR #13203:
URL: https://github.com/apache/kafka/pull/13203#discussion_r1098689954
##
group-coordinator/src/main/resources/common/message/ConsumerGroupCurrentMemberAssignmentKey.json:
##
@@ -0,0 +1,26 @@
+// Licensed to the Apache Software Foundation (A
dajac commented on code in PR #13203:
URL: https://github.com/apache/kafka/pull/13203#discussion_r1098691309
##
group-coordinator/src/main/resources/common/message/ConsumerGroupCurrentMemberAssignmentKey.json:
##
@@ -0,0 +1,26 @@
+// Licensed to the Apache Software Foundation (A
dajac commented on code in PR #13203:
URL: https://github.com/apache/kafka/pull/13203#discussion_r1098693395
##
group-coordinator/src/main/resources/common/message/ConsumerGroupPartitionMetadataValue.json:
##
@@ -0,0 +1,30 @@
+// Licensed to the Apache Software Foundation (ASF)
satishd commented on code in PR #13213:
URL: https://github.com/apache/kafka/pull/13213#discussion_r1098698848
##
storage/src/main/java/org/apache/kafka/storage/internals/log/AbstractIndex.java:
##
@@ -64,8 +65,7 @@ private enum SearchResultType {
*/
private volatile
satishd commented on code in PR #13213:
URL: https://github.com/apache/kafka/pull/13213#discussion_r1098698848
##
storage/src/main/java/org/apache/kafka/storage/internals/log/AbstractIndex.java:
##
@@ -64,8 +65,7 @@ private enum SearchResultType {
*/
private volatile
satishd commented on code in PR #13213:
URL: https://github.com/apache/kafka/pull/13213#discussion_r1098698848
##
storage/src/main/java/org/apache/kafka/storage/internals/log/AbstractIndex.java:
##
@@ -64,8 +65,7 @@ private enum SearchResultType {
*/
private volatile
ijuma commented on code in PR #13213:
URL: https://github.com/apache/kafka/pull/13213#discussion_r1098706079
##
storage/src/main/java/org/apache/kafka/storage/internals/log/AbstractIndex.java:
##
@@ -64,8 +65,7 @@ private enum SearchResultType {
*/
private volatile in
satishd commented on PR #13213:
URL: https://github.com/apache/kafka/pull/13213#issuecomment-1420880690
Thanks @ijuma for your review. spotBugs task is fixed with the latest commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
clolov commented on PR #13122:
URL: https://github.com/apache/kafka/pull/13122#issuecomment-1420901116
Heya @fvaleri, I hope I have addressed all your comments.
Unless I am wrong, the only difference between the two outputs is that in
the old the error was
```
"error": null
```
dajac commented on code in PR #13196:
URL: https://github.com/apache/kafka/pull/13196#discussion_r1098775244
##
core/src/main/scala/kafka/server/ReplicaManager.scala:
##
@@ -334,6 +334,29 @@ class ReplicaManager(val config: KafkaConfig,
topicPartitions.foreach(tp =>
delaye
clolov commented on PR #13191:
URL: https://github.com/apache/kafka/pull/13191#issuecomment-1420944086
> It's also worth noting that there are unused stubbings in some of these
tests, which should be failing the build but are not at the moment due to
[KAFKA-14682](https://issues.apache.org/
C0urante commented on PR #13191:
URL: https://github.com/apache/kafka/pull/13191#issuecomment-1420949503
@clolov I've provided some information on that front in the description for
[the ticket I linked](https://issues.apache.org/jira/browse/KAFKA-14682).
TL;DR: I believe it's because we use
mimaison commented on code in PR #13195:
URL: https://github.com/apache/kafka/pull/13195#discussion_r1098805966
##
docs/upgrade.html:
##
@@ -19,6 +19,16 @@
divijvaidya commented on code in PR #13212:
URL: https://github.com/apache/kafka/pull/13212#discussion_r1098802862
##
clients/src/main/java/org/apache/kafka/clients/admin/AlterClientQuotasOptions.java:
##
@@ -19,6 +19,8 @@
import org.apache.kafka.common.annotation.InterfaceSt
kirktrue commented on code in PR #12813:
URL: https://github.com/apache/kafka/pull/12813#discussion_r1098825578
##
clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java:
##
@@ -549,7 +549,13 @@ private boolean awaitNodeReady(Node node,
FindCoordinatorReq
[
https://issues.apache.org/jira/browse/KAFKA-14317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17685353#comment-17685353
]
Kirk True commented on KAFKA-14317:
---
[~dajac] could you take another look at the PR? T
[
https://issues.apache.org/jira/browse/KAFKA-14675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-14675:
--
Reviewer: Jason Gustafson
> Extract metadata-related tasks from Fetcher into MetadataFetcher
> ---
jeqo commented on code in PR #13177:
URL: https://github.com/apache/kafka/pull/13177#discussion_r1096076032
##
jmh-benchmarks/src/main/java/org/apache/kafka/jmh/common/metrics/SensorBenchmark.java:
##
@@ -0,0 +1,145 @@
+package org.apache.kafka.jmh.common.metrics;
+
+import org.
Hangleton opened a new pull request, #13214:
URL: https://github.com/apache/kafka/pull/13214
Code move for the `consoleProducer` as part of KAFKA-14525 - Move CLI tools
from `core` to `tools` module. The copy is as identical as possible as the
original class and provides iso-functionality.
[
https://issues.apache.org/jira/browse/KAFKA-14593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17685366#comment-17685366
]
Alexandre Dupriez commented on KAFKA-14593:
---
Thanks for following-up. I picke
C0urante commented on PR #12366:
URL: https://github.com/apache/kafka/pull/12366#issuecomment-1421008599
@mimaison Thanks, I've rebased. I've also removed the changes to the offset
sync semaphore since https://github.com/apache/kafka/pull/13181 should obviate
them.
--
This is an automate
[
https://issues.apache.org/jira/browse/KAFKA-14579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alexandre Dupriez reassigned KAFKA-14579:
-
Assignee: Alexandre Dupriez
> Move DumpLogSegments to tools
> -
mimaison commented on PR #12366:
URL: https://github.com/apache/kafka/pull/12366#issuecomment-1421014723
Thanks Chris for the quick reply! I'll take a look this week.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
[
https://issues.apache.org/jira/browse/KAFKA-14482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alexandre Dupriez reassigned KAFKA-14482:
-
Assignee: Alexandre Dupriez
> Move LogLoader to storage module
> --
[
https://issues.apache.org/jira/browse/KAFKA-14484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alexandre Dupriez reassigned KAFKA-14484:
-
Assignee: Alexandre Dupriez
> Move UnifiedLog to storage module
> -
Kedar Joshi created KAFKA-14689:
---
Summary: Kafka won't start on Windows in KRaft mode
Key: KAFKA-14689
URL: https://issues.apache.org/jira/browse/KAFKA-14689
Project: Kafka
Issue Type: Bug
[
https://issues.apache.org/jira/browse/KAFKA-14689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kedar Joshi updated KAFKA-14689:
Description:
Kafka 3.4 is unable to start in KRaft mode on Windows 10.
Kafka is started in Kafka
mimaison merged PR #13210:
URL: https://github.com/apache/kafka/pull/13210
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
dajac commented on PR #12972:
URL: https://github.com/apache/kafka/pull/12972#issuecomment-1421105810
@hachikuji Thanks for your review. I have addressed your comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
guozhangwang commented on PR #13125:
URL: https://github.com/apache/kafka/pull/13125#issuecomment-1421133959
@yufeiyan1220 just following up on this PR. Do you want to address the
latest comment, I'm thinking if we can just move `throttleTimeSensor` to the
Selector while keeping its group n
fvaleri opened a new pull request, #13215:
URL: https://github.com/apache/kafka/pull/13215
```sh
=== test data
bin/kafka-producer-perf-test.sh --num-records 3 --record-size 1000
--throughput 200 --topic my-topic --producer-props bootstrap.servers=:9092
linger.ms=0 batch.size=16384
fvaleri commented on PR #13215:
URL: https://github.com/apache/kafka/pull/13215#issuecomment-1421199547
@mimaison @OmniaGM @clolov
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
jsancio commented on code in PR #13207:
URL: https://github.com/apache/kafka/pull/13207#discussion_r1098994575
##
raft/src/main/java/org/apache/kafka/raft/internals/KafkaRaftMetrics.java:
##
@@ -133,26 +131,27 @@ public KafkaRaftMetrics(Metrics metrics, String
metricGrpPrefix,
kirktrue commented on PR #13211:
URL: https://github.com/apache/kafka/pull/13211#issuecomment-1421255523
@rajinisivaram - LGTM.
It took me a second to verify that the `configs` that was passed into the
`LoginMetadata ` wasn't being used directly in the `hashCode` and `equals`
methods
[
https://issues.apache.org/jira/browse/KAFKA-14648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17685418#comment-17685418
]
Kirk True commented on KAFKA-14648:
---
Would a fix for this cover the case where
`Clien
[
https://issues.apache.org/jira/browse/KAFKA-14648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17685418#comment-17685418
]
Kirk True edited comment on KAFKA-14648 at 2/7/23 6:29 PM:
---
Wo
[
https://issues.apache.org/jira/browse/KAFKA-14648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17685418#comment-17685418
]
Kirk True edited comment on KAFKA-14648 at 2/7/23 6:30 PM:
---
Wo
hachikuji commented on code in PR #12972:
URL: https://github.com/apache/kafka/pull/12972#discussion_r1099052637
##
generator/src/main/java/org/apache/kafka/message/ApiMessageTypeGenerator.java:
##
@@ -408,6 +410,23 @@ private void generateListenerTypesEnum() {
buffer.p
[
https://issues.apache.org/jira/browse/KAFKA-14648?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True reassigned KAFKA-14648:
-
Assignee: Kirk True
> Do not fail clients if bootstrap servers is not immediately resolvable
>
hachikuji commented on code in PR #13207:
URL: https://github.com/apache/kafka/pull/13207#discussion_r1099065953
##
raft/src/main/java/org/apache/kafka/raft/internals/KafkaRaftMetrics.java:
##
@@ -133,26 +131,27 @@ public KafkaRaftMetrics(Metrics metrics, String
metricGrpPrefix
guozhangwang commented on code in PR #12972:
URL: https://github.com/apache/kafka/pull/12972#discussion_r1099081262
##
clients/src/main/resources/common/message/ConsumerGroupHeartbeatRequest.json:
##
@@ -0,0 +1,66 @@
+// Licensed to the Apache Software Foundation (ASF) under one
[
https://issues.apache.org/jira/browse/KAFKA-14648?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True reassigned KAFKA-14648:
-
Assignee: Philip Nee (was: Kirk True)
> Do not fail clients if bootstrap servers is not immedi
dajac commented on code in PR #12972:
URL: https://github.com/apache/kafka/pull/12972#discussion_r1099084820
##
generator/src/main/java/org/apache/kafka/message/ApiMessageTypeGenerator.java:
##
@@ -408,6 +410,23 @@ private void generateListenerTypesEnum() {
buffer.print
guozhangwang commented on code in PR #12972:
URL: https://github.com/apache/kafka/pull/12972#discussion_r1099085546
##
core/src/test/scala/unit/kafka/server/ApiVersionsRequestTest.scala:
##
@@ -44,6 +44,13 @@ class ApiVersionsRequestTest(cluster: ClusterInstance)
extends Abstra
guozhangwang commented on PR #12813:
URL: https://github.com/apache/kafka/pull/12813#issuecomment-1421307753
I made another pass and it LGTM now. leaving to @dajac for a final look and
merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please lo
dajac commented on code in PR #12972:
URL: https://github.com/apache/kafka/pull/12972#discussion_r1099087860
##
core/src/test/scala/unit/kafka/server/ApiVersionsRequestTest.scala:
##
@@ -44,6 +44,13 @@ class ApiVersionsRequestTest(cluster: ClusterInstance)
extends AbstractApiVe
dajac commented on PR #12813:
URL: https://github.com/apache/kafka/pull/12813#issuecomment-1421316241
@guozhangwang Thanks. I will do this tomorrow. In the mean time, I have
re-triggered the CI as they were multiple failures.
--
This is an automated message from the Apache Git Service.
To
mjsax merged PR #13209:
URL: https://github.com/apache/kafka/pull/13209
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
guozhangwang commented on code in PR #13021:
URL: https://github.com/apache/kafka/pull/13021#discussion_r1096350392
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java:
##
@@ -0,0 +1,224 @@
+/*
+ * Licensed to the Apache Software Founda
guozhangwang commented on PR #13021:
URL: https://github.com/apache/kafka/pull/13021#issuecomment-1421334205
Made another look, LGTM. Leaving for @hachikuji for a final look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
guozhangwang merged PR #13179:
URL: https://github.com/apache/kafka/pull/13179
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.ap
guozhangwang commented on PR #13179:
URL: https://github.com/apache/kafka/pull/13179#issuecomment-1421336158
Merged to trunk after updating the javadoc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
scholzj opened a new pull request, #13216:
URL: https://github.com/apache/kafka/pull/13216
The `connect-log4j.properties` file configures the log level for the
ZooKeeper logger. That seems unnecessary since Kafka Connect does not use
ZooKeeper directly in any way. This PR removes it from th
philipnee commented on PR #13021:
URL: https://github.com/apache/kafka/pull/13021#issuecomment-1421340357
much thanks @guozhangwang
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
guozhangwang commented on PR #13025:
URL: https://github.com/apache/kafka/pull/13025#issuecomment-1421340480
I do not have further comments. @cadonna do you want to take a final look?
If not I can go ahead and merge it.
--
This is an automated message from the Apache Git Service.
To respo
philipnee opened a new pull request, #13217:
URL: https://github.com/apache/kafka/pull/13217
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of testi
1 - 100 of 123 matches
Mail list logo
