hachikuji commented on code in PR #12972:
URL: https://github.com/apache/kafka/pull/12972#discussion_r1099052637
##########
generator/src/main/java/org/apache/kafka/message/ApiMessageTypeGenerator.java:
##########
@@ -408,6 +410,23 @@ private void generateListenerTypesEnum() {
buffer.printf("}%n");
}
+ private void generateHighestStableVersion() {
+ buffer.printf("public short highestStableVersion(boolean
enableUnstableLastVersion) {%n");
Review Comment:
nit: It's a little odd to call this `highestStableVersion` and also accept a
flag to enable unstable versions. Maybe we could replace the implementation of
`highestSupportedVersion` to accept the flag.
Or alternatively, the helper can be `highestStableVersion()` and we can drop
the flag. Then we can check the flag in the code and use either
`highestStableVersion` or `highestSupportedVersion`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
