Federico Valeri created KAFKA-14628:
---
Summary: Move CommandLineUtils and CommandDefaultOptions shared
classes
Key: KAFKA-14628
URL: https://issues.apache.org/jira/browse/KAFKA-14628
Project: Kafka
[
https://issues.apache.org/jira/browse/KAFKA-14628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Federico Valeri reassigned KAFKA-14628:
---
Assignee: Federico Valeri
> Move CommandLineUtils and CommandDefaultOptions shared
[
https://issues.apache.org/jira/browse/KAFKA-14590?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gantigmaa Selenge reassigned KAFKA-14590:
-
Assignee: Gantigmaa Selenge
> Move DelegationTokenCommand to tools
> --
clolov commented on code in PR #13099:
URL: https://github.com/apache/kafka/pull/13099#discussion_r1073321039
##
clients/src/main/java/org/apache/kafka/common/utils/Utils.java:
##
@@ -1496,4 +1496,32 @@ public static String replaceSuffix(String str, String
oldSuffix, String new
divijvaidya commented on PR #13078:
URL: https://github.com/apache/kafka/pull/13078#issuecomment-138670
@ijuma @jolshan what I wanted to convey was a situation where the
approximate nature of this metrics may cause problem during troubleshooting.
**But I was wrong. I read the code incor
dajac commented on code in PR #13112:
URL: https://github.com/apache/kafka/pull/13112#discussion_r1073331102
##
core/src/main/scala/kafka/server/BrokerServer.scala:
##
@@ -282,8 +283,12 @@ class BrokerServer(
tokenManager.startup() // does nothing, we just need a token ma
dajac commented on code in PR #13112:
URL: https://github.com/apache/kafka/pull/13112#discussion_r107332
##
core/src/main/scala/kafka/coordinator/group/GroupCoordinatorAdapter.scala:
##
@@ -511,4 +532,57 @@ class GroupCoordinatorAdapter(
future
}
+
+ override def
dajac commented on code in PR #13112:
URL: https://github.com/apache/kafka/pull/13112#discussion_r1073334166
##
core/src/main/scala/kafka/server/KafkaApis.scala:
##
@@ -310,9 +307,9 @@ class KafkaApis(val requestChannel: RequestChannel,
if (topicPartition.topic == GRO
showuon commented on code in PR #13099:
URL: https://github.com/apache/kafka/pull/13099#discussion_r1073368235
##
clients/src/main/java/org/apache/kafka/common/utils/Utils.java:
##
@@ -1496,4 +1496,32 @@ public static String replaceSuffix(String str, String
oldSuffix, String ne
[
https://issues.apache.org/jira/browse/KAFKA-5072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17678185#comment-17678185
]
Nikolay Latyshev commented on KAFKA-5072:
-
Hi, it seems there is no activity. Can
[
https://issues.apache.org/jira/browse/KAFKA-8206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17678209#comment-17678209
]
Ivan Yurchenko commented on KAFKA-8206:
---
Sorry all for it took really long time, bu
Divij Vaidya created KAFKA-14629:
Summary: Performance improvement for Zstd compressed workload
Key: KAFKA-14629
URL: https://issues.apache.org/jira/browse/KAFKA-14629
Project: Kafka
Issue Ty
Divij Vaidya created KAFKA-14630:
Summary: Update zstd-jni version to 1.5.2-4
Key: KAFKA-14630
URL: https://issues.apache.org/jira/browse/KAFKA-14630
Project: Kafka
Issue Type: Sub-task
Divij Vaidya created KAFKA-14631:
Summary: Compression optimization: do not read the key/value for
last record in the batch
Key: KAFKA-14631
URL: https://issues.apache.org/jira/browse/KAFKA-14631
Proj
Divij Vaidya created KAFKA-14632:
Summary: Compression optimization: Remove unnecessary intermediate
buffers
Key: KAFKA-14632
URL: https://issues.apache.org/jira/browse/KAFKA-14632
Project: Kafka
Divij Vaidya created KAFKA-14633:
Summary: Compression optimization: Use BufferSupplier to allocate
the intermediate decompressed buffer
Key: KAFKA-14633
URL: https://issues.apache.org/jira/browse/KAFKA-14633
Divij Vaidya created KAFKA-14634:
Summary: Compression optimization: Calculate the size of
decompressed buffer dynamically at runtime.
Key: KAFKA-14634
URL: https://issues.apache.org/jira/browse/KAFKA-14634
Divij Vaidya created KAFKA-14635:
Summary: Compression optimization: Use direct memory buffers for
(de)compression
Key: KAFKA-14635
URL: https://issues.apache.org/jira/browse/KAFKA-14635
Project: Kafk
Divij Vaidya created KAFKA-14636:
Summary: Compression optimization: Use zstd dictionary based
(de)compression
Key: KAFKA-14636
URL: https://issues.apache.org/jira/browse/KAFKA-14636
Project: Kafka
[
https://issues.apache.org/jira/browse/KAFKA-14630?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Divij Vaidya updated KAFKA-14630:
-
Summary: Update zstd-jni version to 1.5.2-3 (was: Update zstd-jni version
to 1.5.2-4)
> Update
[
https://issues.apache.org/jira/browse/KAFKA-14630?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Divij Vaidya updated KAFKA-14630:
-
Fix Version/s: (was: 3.5.0)
> Update zstd-jni version to 1.5.2-3
> -
[
https://issues.apache.org/jira/browse/KAFKA-14630?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Divij Vaidya updated KAFKA-14630:
-
Description:
The latest version of zstd-jni as of Jan 2023 is 1.5.2-5. Note that this
version i
[
https://issues.apache.org/jira/browse/KAFKA-14630?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Divij Vaidya updated KAFKA-14630:
-
Summary: Update zstd-jni version to 1.5.2-5 (was: Update zstd-jni version
to 1.5.2-3)
> Update
ijuma commented on code in PR #13099:
URL: https://github.com/apache/kafka/pull/13099#discussion_r1073567726
##
clients/src/main/java/org/apache/kafka/common/utils/Utils.java:
##
@@ -1496,4 +1496,32 @@ public static String replaceSuffix(String str, String
oldSuffix, String newS
divijvaidya commented on PR #13111:
URL: https://github.com/apache/kafka/pull/13111#issuecomment-1387158089
Thanks for the comments folks. I would like to break the conversation as
multiple FAQs and hopefully that would address the questions and points that
you have raised above.
**W
dajac commented on code in PR #13112:
URL: https://github.com/apache/kafka/pull/13112#discussion_r1073605900
##
core/src/main/scala/kafka/server/KafkaApis.scala:
##
@@ -357,8 +354,9 @@ class KafkaApis(val requestChannel: RequestChannel,
new UpdateMetadataResponse(new
U
dajac commented on code in PR #13112:
URL: https://github.com/apache/kafka/pull/13112#discussion_r1073607143
##
core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala:
##
@@ -810,19 +810,22 @@ class GroupMetadataManager(brokerId: Int,
*/
private def maybeU
[
https://issues.apache.org/jira/browse/KAFKA-14625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17678259#comment-17678259
]
Sagar Rao commented on KAFKA-14625:
---
[~ijuma] , I see. [~satish.duggana] , do you thin
dajac commented on code in PR #13112:
URL: https://github.com/apache/kafka/pull/13112#discussion_r1073607143
##
core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala:
##
@@ -810,19 +810,22 @@ class GroupMetadataManager(brokerId: Int,
*/
private def maybeU
ijuma commented on PR #13111:
URL: https://github.com/apache/kafka/pull/13111#issuecomment-1387170499
> Yes. <2.8 client with >=2.8 server will have this bug.
This is not quite right. You need multiple things:
1. Tools older than 3.0
2. Tools need to use `--zookeeper` instead
[
https://issues.apache.org/jira/browse/KAFKA-14580?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sagar Rao reassigned KAFKA-14580:
-
Assignee: Sagar Rao
> Move EndToEndLatency to tools
> -
>
>
vamossagar12 commented on PR #13095:
URL: https://github.com/apache/kafka/pull/13095#issuecomment-1387172335
> Builds on 8 and 17 are ok. Test failure on 11 is unrelated and it works
fine on my machine.
>
> Thanks.
Thanks @fvaleri . @mimaison would you be able to take a look as
divijvaidya commented on PR #13111:
URL: https://github.com/apache/kafka/pull/13111#issuecomment-1387172611
> > Yes. <2.8 client with >=2.8 server will have this bug.
>
> This is not quite right. You need multiple things:
>
> 1. Tools older than 3.0
> 2. Tools need to use `--
divijvaidya commented on PR #13111:
URL: https://github.com/apache/kafka/pull/13111#issuecomment-1387174278
I am not super sure (still checking) but I believe
https://github.com/yahoo/CMAK is a popular 3P tool that directly accesses
zookeeper with older clients.
--
This is an automated m
divijvaidya commented on code in PR #13111:
URL: https://github.com/apache/kafka/pull/13111#discussion_r1073623221
##
core/src/main/scala/kafka/controller/KafkaController.scala:
##
@@ -1698,7 +1708,7 @@ class KafkaController(val config: KafkaConfig,
private def processPartiti
divijvaidya commented on code in PR #13111:
URL: https://github.com/apache/kafka/pull/13111#discussion_r1073626693
##
core/src/main/scala/kafka/controller/KafkaController.scala:
##
@@ -1664,11 +1664,21 @@ class KafkaController(val config: KafkaConfig,
}
private def proce
[
https://issues.apache.org/jira/browse/KAFKA-14565?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Terry Beard updated KAFKA-14565:
Description:
The Consumer and Producer interceptor interfaces and their corresponding Kafka
Consu
ijuma commented on PR #13111:
URL: https://github.com/apache/kafka/pull/13111#issuecomment-1387227338
I guess these are the two relevant issues:
1. https://github.com/yahoo/CMAK/issues/900
2. https://github.com/yahoo/CMAK/issues/898
Not sure how easy it would be, but contribu
[
https://issues.apache.org/jira/browse/KAFKA-14565?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Terry Beard updated KAFKA-14565:
Description:
The Consumer and Producer interceptor interfaces and their corresponding Kafka
Consu
[
https://issues.apache.org/jira/browse/KAFKA-14565?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Terry Beard updated KAFKA-14565:
Description:
The Consumer and Producer interceptor interfaces and their corresponding Kafka
Consu
[
https://issues.apache.org/jira/browse/KAFKA-14565?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Terry Beard updated KAFKA-14565:
Description:
The Consumer and Producer interceptor interfaces and their corresponding Kafka
Consu
dajac commented on PR #13112:
URL: https://github.com/apache/kafka/pull/13112#issuecomment-1387451894
All builds are green! I haven't seen this for a very long time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
vamossagar12 opened a new pull request, #13127:
URL: https://github.com/apache/kafka/pull/13127
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of te
vamossagar12 commented on PR #13127:
URL: https://github.com/apache/kafka/pull/13127#issuecomment-1387469292
@mjsax , I noticed you had worked on the StreamsResetter tool. Would you be
able to review this smallish PR? The idea is to move it from core module to
tools module which is part of
dajac commented on code in PR #13112:
URL: https://github.com/apache/kafka/pull/13112#discussion_r1073895006
##
core/src/test/resources/log4j.properties:
##
@@ -18,7 +18,7 @@ log4j.appender.stdout=org.apache.log4j.ConsoleAppender
log4j.appender.stdout.layout=org.apache.log4j.Pa
jolshan commented on PR #13111:
URL: https://github.com/apache/kafka/pull/13111#issuecomment-1387498846
@divijvaidya My other concern here is that even though this fixes the issue
in the case where the controller stays the same, it doesn't cover controller
re-election. This means we would s
fvaleri commented on code in PR #13122:
URL: https://github.com/apache/kafka/pull/13122#discussion_r1073900755
##
tools/src/main/java/org/apache/kafka/tools/LogDirsCommand.java:
##
@@ -0,0 +1,158 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ *
fvaleri commented on code in PR #13122:
URL: https://github.com/apache/kafka/pull/13122#discussion_r1073900755
##
tools/src/main/java/org/apache/kafka/tools/LogDirsCommand.java:
##
@@ -0,0 +1,158 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ *
hachikuji commented on code in PR #13107:
URL: https://github.com/apache/kafka/pull/13107#discussion_r1073904486
##
core/src/main/scala/kafka/server/ReplicaManager.scala:
##
@@ -390,7 +390,7 @@ class ReplicaManager(val config: KafkaConfig,
// epoch, a sentinel val
jolshan commented on code in PR #13107:
URL: https://github.com/apache/kafka/pull/13107#discussion_r1073908135
##
core/src/main/scala/kafka/server/ReplicaManager.scala:
##
@@ -390,7 +390,7 @@ class ReplicaManager(val config: KafkaConfig,
// epoch, a sentinel value
dajac commented on PR #13111:
URL: https://github.com/apache/kafka/pull/13111#issuecomment-1387512615
> If this is a big issue for tiered storage, then we could still be in
trouble.
Will this code still be around by the time tiered storage is completed?
--
This is an automated mess
jolshan commented on PR #13111:
URL: https://github.com/apache/kafka/pull/13111#issuecomment-1387522464
> When same segment for same topic is uploaded with different topic Ids, it
leads to an unrecoverable situation.
Also curious if we can upload a segment with the wrong ID if the lea
jolshan merged PR #13107:
URL: https://github.com/apache/kafka/pull/13107
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
jolshan commented on code in PR #13112:
URL: https://github.com/apache/kafka/pull/13112#discussion_r1073925637
##
core/src/main/scala/kafka/coordinator/group/GroupCoordinatorAdapter.scala:
##
@@ -511,4 +532,57 @@ class GroupCoordinatorAdapter(
future
}
+
+ override de
jolshan commented on code in PR #13112:
URL: https://github.com/apache/kafka/pull/13112#discussion_r1073926490
##
core/src/main/scala/kafka/server/KafkaApis.scala:
##
@@ -310,9 +307,9 @@ class KafkaApis(val requestChannel: RequestChannel,
if (topicPartition.topic == G
jolshan commented on code in PR #13112:
URL: https://github.com/apache/kafka/pull/13112#discussion_r1073937486
##
core/src/main/scala/kafka/coordinator/group/GroupCoordinatorAdapter.scala:
##
@@ -511,4 +532,53 @@ class GroupCoordinatorAdapter(
future
}
+
+ override de
satishd commented on PR #13040:
URL: https://github.com/apache/kafka/pull/13040#issuecomment-1387574662
@ijuma It looks like the changes that were done in the conversions were
accidentally dropped in my local repo while doing a few rebases and squashes
with trunk and other changes. I should
jolshan commented on code in PR #13112:
URL: https://github.com/apache/kafka/pull/13112#discussion_r1073945942
##
core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala:
##
@@ -810,19 +810,22 @@ class GroupMetadataManager(brokerId: Int,
*/
private def mayb
jolshan commented on code in PR #13112:
URL: https://github.com/apache/kafka/pull/13112#discussion_r1073948248
##
core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala:
##
@@ -810,19 +810,22 @@ class GroupMetadataManager(brokerId: Int,
*/
private def mayb
dajac commented on code in PR #13112:
URL: https://github.com/apache/kafka/pull/13112#discussion_r1073958844
##
core/src/main/scala/kafka/coordinator/group/GroupCoordinatorAdapter.scala:
##
@@ -511,4 +532,53 @@ class GroupCoordinatorAdapter(
future
}
+
+ override def
dajac commented on code in PR #13112:
URL: https://github.com/apache/kafka/pull/13112#discussion_r1073960778
##
core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala:
##
@@ -810,19 +810,22 @@ class GroupMetadataManager(brokerId: Int,
*/
private def maybeU
dajac commented on code in PR #13112:
URL: https://github.com/apache/kafka/pull/13112#discussion_r1073960778
##
core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala:
##
@@ -810,19 +810,22 @@ class GroupMetadataManager(brokerId: Int,
*/
private def maybeU
dajac commented on code in PR #13112:
URL: https://github.com/apache/kafka/pull/13112#discussion_r1073960778
##
core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala:
##
@@ -810,19 +810,22 @@ class GroupMetadataManager(brokerId: Int,
*/
private def maybeU
jolshan commented on code in PR #13112:
URL: https://github.com/apache/kafka/pull/13112#discussion_r1073964326
##
core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala:
##
@@ -810,19 +810,22 @@ class GroupMetadataManager(brokerId: Int,
*/
private def mayb
jolshan commented on code in PR #13112:
URL: https://github.com/apache/kafka/pull/13112#discussion_r1073964326
##
core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala:
##
@@ -810,19 +810,22 @@ class GroupMetadataManager(brokerId: Int,
*/
private def mayb
dajac commented on code in PR #13112:
URL: https://github.com/apache/kafka/pull/13112#discussion_r1073982833
##
core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala:
##
@@ -810,19 +810,22 @@ class GroupMetadataManager(brokerId: Int,
*/
private def maybeU
Akhilesh Chaganti created KAFKA-14637:
-
Summary: Upgrade to 3.4 from old versions (< 0.10) are failing due
to incompatible meta.properties check
Key: KAFKA-14637
URL: https://issues.apache.org/jira/browse/KAFK
[
https://issues.apache.org/jira/browse/KAFKA-14637?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Akhilesh Chaganti reassigned KAFKA-14637:
-
Assignee: Akhilesh Chaganti
> Upgrade to 3.4 from old versions (< 0.10) are fai
dajac commented on code in PR #13112:
URL: https://github.com/apache/kafka/pull/13112#discussion_r1074022302
##
core/src/main/scala/kafka/server/KafkaApis.scala:
##
@@ -310,9 +307,9 @@ class KafkaApis(val requestChannel: RequestChannel,
if (topicPartition.topic == GRO
ijuma commented on PR #13040:
URL: https://github.com/apache/kafka/pull/13040#issuecomment-1387745094
@satishd No worries, it happens to all of us. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
[
https://issues.apache.org/jira/browse/KAFKA-13972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gustafson updated KAFKA-13972:
Fix Version/s: 3.4.1
> Reassignment cancellation causes stray replicas
> -
[
https://issues.apache.org/jira/browse/KAFKA-13972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17678390#comment-17678390
]
Jason Gustafson commented on KAFKA-13972:
-
The patch still needs to be picked in
jolshan commented on code in PR #13112:
URL: https://github.com/apache/kafka/pull/13112#discussion_r1080547019
##
core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala:
##
@@ -810,19 +810,22 @@ class GroupMetadataManager(brokerId: Int,
*/
private def mayb
rishiraj88 commented on code in PR #13112:
URL: https://github.com/apache/kafka/pull/13112#discussion_r1080573968
##
core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala:
##
@@ -810,19 +810,22 @@ class GroupMetadataManager(brokerId: Int,
*/
private def m
hachikuji commented on PR #12922:
URL: https://github.com/apache/kafka/pull/12922#issuecomment-1396203599
Note I'm holding off on merging this patch because I realized when writing
the test case that Justine suggested that the code was not correctly handling
the case when the next in-line b
jolshan commented on code in PR #13112:
URL: https://github.com/apache/kafka/pull/13112#discussion_r1080653448
##
core/src/main/scala/kafka/coordinator/group/GroupCoordinatorAdapter.scala:
##
@@ -511,4 +532,53 @@ class GroupCoordinatorAdapter(
future
}
+
+ override de
erichaagdev opened a new pull request, #13128:
URL: https://github.com/apache/kafka/pull/13128
It is a good practice to always define a root project name. However, this
change is specifically being made to address a build caching miss as a result
of not having the root project name defined.
jolshan commented on code in PR #13112:
URL: https://github.com/apache/kafka/pull/13112#discussion_r1080661020
##
core/src/test/scala/unit/kafka/server/KafkaApisTest.scala:
##
@@ -3448,7 +3445,7 @@ class KafkaApisTest {
val expectedJoinGroupResponse = new JoinGroupResponseD
jolshan commented on code in PR #13112:
URL: https://github.com/apache/kafka/pull/13112#discussion_r1080662718
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinator.java:
##
@@ -215,4 +223,86 @@ CompletableFuture deleteOffsets(
OffsetDel
jolshan commented on code in PR #13112:
URL: https://github.com/apache/kafka/pull/13112#discussion_r1080665363
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinator.java:
##
@@ -215,4 +223,86 @@ CompletableFuture deleteOffsets(
OffsetDel
jolshan commented on code in PR #13112:
URL: https://github.com/apache/kafka/pull/13112#discussion_r1080666149
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinator.java:
##
@@ -215,4 +223,86 @@ CompletableFuture deleteOffsets(
OffsetDel
philipnee commented on PR #13125:
URL: https://github.com/apache/kafka/pull/13125#issuecomment-1396238469
Thanks for the PR and the issue @yufeiyan1220 - I wonder if the clean up is
necessary, as the metrics will be closed upon the client closing. Willing to
hear what others say.
--
This
hachikuji commented on code in PR #13021:
URL: https://github.com/apache/kafka/pull/13021#discussion_r1080689650
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java:
##
@@ -0,0 +1,280 @@
+/*
+ * Licensed to the Apache Software Foundatio
Alex Sorokoumov created KAFKA-14638:
---
Summary: Documentation for transaction.timeout.ms should be more
precise
Key: KAFKA-14638
URL: https://issues.apache.org/jira/browse/KAFKA-14638
Project: Kafka
Ge opened a new pull request, #13129:
URL: https://github.com/apache/kafka/pull/13129
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of testing
akhileshchg opened a new pull request, #13130:
URL: https://github.com/apache/kafka/pull/13130
3.4 introduced a change that requires cluster.id to be present in
meta.properties if the file is available. This information is not persisted by
the brokers in old versions (< 0.10). So on upgrade
ijuma commented on code in PR #13130:
URL: https://github.com/apache/kafka/pull/13130#discussion_r1080736930
##
core/src/main/scala/kafka/server/BrokerMetadataCheckpoint.scala:
##
@@ -157,7 +157,8 @@ case class MetaProperties(
object BrokerMetadataCheckpoint extends Logging {
akhileshchg commented on code in PR #13130:
URL: https://github.com/apache/kafka/pull/13130#discussion_r1080739852
##
core/src/main/scala/kafka/server/BrokerMetadataCheckpoint.scala:
##
@@ -157,7 +157,8 @@ case class MetaProperties(
object BrokerMetadataCheckpoint extends Loggi
philipnee commented on code in PR #13021:
URL: https://github.com/apache/kafka/pull/13021#discussion_r1080743797
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java:
##
@@ -0,0 +1,280 @@
+/*
+ * Licensed to the Apache Software Foundatio
vamossagar12 commented on PR #13127:
URL: https://github.com/apache/kafka/pull/13127#issuecomment-1396439952
Adding @fvaleri . There are checkstyle issues, which I would fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
90 matches
Mail list logo
