ijuma commented on code in PR #13130:
URL: https://github.com/apache/kafka/pull/13130#discussion_r1080736930
##########
core/src/main/scala/kafka/server/BrokerMetadataCheckpoint.scala:
##########
@@ -157,7 +157,8 @@ case class MetaProperties(
object BrokerMetadataCheckpoint extends Logging {
def getBrokerMetadataAndOfflineDirs(
logDirs: collection.Seq[String],
- ignoreMissing: Boolean
+ ignoreMissing: Boolean,
+ kraftMode: Boolean = false
Review Comment:
Default arguments like this make it easy to miss places that should be
updated. Better to be explicit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
