[GitHub] [kafka] lucasbru commented on a diff in pull request #13025: KAFKA-14299: Make sure no progress is made on paused topologies

2023-01-12 Thread GitBox
lucasbru commented on code in PR #13025: URL: https://github.com/apache/kafka/pull/13025#discussion_r1067891929 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdater.java: ## @@ -276,6 +276,11 @@ private void addTask(final Task task) {

[GitHub] [kafka] clolov commented on a diff in pull request #13094: MINOR: Various cleanups in client tests

2023-01-12 Thread GitBox
clolov commented on code in PR #13094: URL: https://github.com/apache/kafka/pull/13094#discussion_r1067891312 ## clients/src/test/java/org/apache/kafka/clients/producer/internals/RecordAccumulatorTest.java: ## @@ -331,17 +331,15 @@ public void testStressfulSituation() throws Exc

[GitHub] [kafka] clolov commented on a diff in pull request #13096: MINOR: Multiple clean ups associated with scala collection

2023-01-12 Thread GitBox
clolov commented on code in PR #13096: URL: https://github.com/apache/kafka/pull/13096#discussion_r1067909965 ## core/src/main/scala/kafka/server/FetchSession.scala: ## @@ -705,10 +705,7 @@ class FetchSessionCache(private val maxEntries: Int, } def remove(sessionId: Int)

[GitHub] [kafka] tinaselenge commented on a diff in pull request #13102: KAFKA-14371: Remove unused clusterId field from quorum-state file

2023-01-12 Thread GitBox
tinaselenge commented on code in PR #13102: URL: https://github.com/apache/kafka/pull/13102#discussion_r1067964100 ## raft/src/test/java/org/apache/kafka/raft/FileBasedStateStoreTest.java: ## @@ -90,6 +98,43 @@ public void testWriteElectionState() throws IOException { a

[jira] [Commented] (KAFKA-13805) Upgrade vulnerable dependencies march 2022

2023-01-12 Thread Christo Lolov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17675945#comment-17675945 ] Christo Lolov commented on KAFKA-13805: --- Both 2.8.2 and 3.0.2 have since been rele

[jira] [Resolved] (KAFKA-13805) Upgrade vulnerable dependencies march 2022

2023-01-12 Thread Christo Lolov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13805?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christo Lolov resolved KAFKA-13805. --- Resolution: Fixed > Upgrade vulnerable dependencies march 2022 > ---

[jira] [Resolved] (KAFKA-14199) Installed kafka in ubuntu and not able to access in browser. org.apache.kafka.common.network.InvalidReceiveException: Invalid receive (size = 1195725856 larger than 10

2023-01-12 Thread Christo Lolov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christo Lolov resolved KAFKA-14199. --- Resolution: Fixed > Installed kafka in ubuntu and not able to access in browser. > org.apa

[jira] [Commented] (KAFKA-14199) Installed kafka in ubuntu and not able to access in browser. org.apache.kafka.common.network.InvalidReceiveException: Invalid receive (size = 1195725856 larger than 1

2023-01-12 Thread Christo Lolov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17675946#comment-17675946 ] Christo Lolov commented on KAFKA-14199: --- There has been no further request for hel

[GitHub] [kafka] cadonna merged pull request #13017: KAFKA-14530: Check state updater more often

2023-01-12 Thread GitBox
cadonna merged PR #13017: URL: https://github.com/apache/kafka/pull/13017 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[GitHub] [kafka] cadonna commented on a diff in pull request #13025: KAFKA-14299: Make sure no progress is made on paused topologies

2023-01-12 Thread GitBox
cadonna commented on code in PR #13025: URL: https://github.com/apache/kafka/pull/13025#discussion_r1068096858 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdater.java: ## @@ -411,6 +422,7 @@ private void checkAllUpdatingTaskStates(final lon

[jira] [Created] (KAFKA-14616) Topic recreation with offline broker causes permanent URPs

2023-01-12 Thread Omnia Ibrahim (Jira)
Omnia Ibrahim created KAFKA-14616: - Summary: Topic recreation with offline broker causes permanent URPs Key: KAFKA-14616 URL: https://issues.apache.org/jira/browse/KAFKA-14616 Project: Kafka

[jira] [Updated] (KAFKA-14616) Topic recreation with offline broker causes permanent URPs

2023-01-12 Thread Omnia Ibrahim (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14616?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Omnia Ibrahim updated KAFKA-14616: -- Description: We are facing an odd situation when we delete and recreate a topic while broker

[jira] [Updated] (KAFKA-14616) Topic recreation with offline broker causes permanent URPs

2023-01-12 Thread Omnia Ibrahim (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14616?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Omnia Ibrahim updated KAFKA-14616: -- Description: We are facing an odd situation when we delete and recreate a topic while broker

[jira] [Updated] (KAFKA-14616) Topic recreation with offline broker causes permanent URPs

2023-01-12 Thread Omnia Ibrahim (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14616?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Omnia Ibrahim updated KAFKA-14616: -- Description: We are facing an odd situation when we delete and recreate a topic while broker

[jira] [Updated] (KAFKA-14616) Topic recreation with offline broker causes permanent URPs

2023-01-12 Thread Omnia Ibrahim (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14616?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Omnia Ibrahim updated KAFKA-14616: -- Description: We are facing an odd situation when we delete and recreate a topic while broker

[GitHub] [kafka] dajac commented on a diff in pull request #12886: KAFKA-14367; Add `OffsetCommit` to the new `GroupCoordinator` interface

2023-01-12 Thread GitBox
dajac commented on code in PR #12886: URL: https://github.com/apache/kafka/pull/12886#discussion_r1068168361 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinator.java: ## @@ -164,5 +166,20 @@ CompletableFuture> fetch String groupId,

[GitHub] [kafka] dajac commented on a diff in pull request #12886: KAFKA-14367; Add `OffsetCommit` to the new `GroupCoordinator` interface

2023-01-12 Thread GitBox
dajac commented on code in PR #12886: URL: https://github.com/apache/kafka/pull/12886#discussion_r1068171485 ## clients/src/main/java/org/apache/kafka/common/requests/OffsetCommitResponse.java: ## @@ -116,4 +118,80 @@ public void maybeSetThrottleTimeMs(int throttleTimeMs) {

[jira] [Updated] (KAFKA-14616) Topic recreation with offline broker causes permanent URPs

2023-01-12 Thread Omnia Ibrahim (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14616?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Omnia Ibrahim updated KAFKA-14616: -- Description: We are facing an odd situation when we delete and recreate a topic while broker

[jira] [Updated] (KAFKA-14616) Topic recreation with offline broker causes permanent URPs

2023-01-12 Thread Omnia Ibrahim (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14616?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Omnia Ibrahim updated KAFKA-14616: -- Description: We are facing an odd situation when we delete and recreate a topic while broker

[GitHub] [kafka] dajac commented on a diff in pull request #12886: KAFKA-14367; Add `OffsetCommit` to the new `GroupCoordinator` interface

2023-01-12 Thread GitBox
dajac commented on code in PR #12886: URL: https://github.com/apache/kafka/pull/12886#discussion_r1068220054 ## core/src/main/scala/kafka/coordinator/group/GroupCoordinatorAdapter.scala: ## @@ -234,4 +240,78 @@ class GroupCoordinatorAdapter( } CompletableFuture.complet

[GitHub] [kafka] dajac commented on pull request #12886: KAFKA-14367; Add `OffsetCommit` to the new `GroupCoordinator` interface

2023-01-12 Thread GitBox
dajac commented on PR #12886: URL: https://github.com/apache/kafka/pull/12886#issuecomment-1380487750 @jeffkbkim @jolshan I updated the PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[GitHub] [kafka] dajac commented on a diff in pull request #12901: KAFKA-14367; Add `TxnOffsetCommit` to the new `GroupCoordinator` interface

2023-01-12 Thread GitBox
dajac commented on code in PR #12901: URL: https://github.com/apache/kafka/pull/12901#discussion_r1068262236 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -2464,90 +2464,108 @@ class KafkaApis(val requestChannel: RequestChannel, } } - def handleTxnOffsetC

[GitHub] [kafka] dajac commented on a diff in pull request #12901: KAFKA-14367; Add `TxnOffsetCommit` to the new `GroupCoordinator` interface

2023-01-12 Thread GitBox
dajac commented on code in PR #12901: URL: https://github.com/apache/kafka/pull/12901#discussion_r1068262843 ## core/src/test/scala/unit/kafka/coordinator/group/GroupCoordinatorAdapterTest.scala: ## @@ -58,7 +62,7 @@ class GroupCoordinatorAdapterTest { @ApiKeyVersionsSource(a

[jira] [Assigned] (KAFKA-14615) Use sizeCompare(Iterable[_]) to compare two iterables

2023-01-12 Thread Kamalesh Palanisamy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14615?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kamalesh Palanisamy reassigned KAFKA-14615: --- Assignee: Kamalesh Palanisamy > Use sizeCompare(Iterable[_]) to compare two

[jira] [Commented] (KAFKA-14615) Use sizeCompare(Iterable[_]) to compare two iterables

2023-01-12 Thread Kamalesh Palanisamy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17676239#comment-17676239 ] Kamalesh Palanisamy commented on KAFKA-14615: - [~divijvaidya] I am looking i

[GitHub] [kafka] andymg3 commented on a diff in pull request #13104: KAFKA-14612: Make sure to write a new topics ConfigRecords to metadata log iff the topic is created

2023-01-12 Thread GitBox
andymg3 commented on code in PR #13104: URL: https://github.com/apache/kafka/pull/13104#discussion_r1067622366 ## metadata/src/test/java/org/apache/kafka/controller/ReplicationControlManagerTest.java: ## @@ -605,6 +617,45 @@ public void testCreateTopicsWithConfigs() throws Excep

[GitHub] [kafka] woja commented on pull request #11743: KAFKA-13660: Switch log4j12 to reload4j

2023-01-12 Thread GitBox
woja commented on PR #11743: URL: https://github.com/apache/kafka/pull/11743#issuecomment-1380686527 (apologies if this is not the place for this - if not please forward this or redirect me!) Since this is included in 3.2.0 (and cherry picked to 3.1) the cve list (here https:

[GitHub] [kafka] ijuma commented on pull request #11743: KAFKA-13660: Switch log4j12 to reload4j

2023-01-12 Thread GitBox
ijuma commented on PR #11743: URL: https://github.com/apache/kafka/pull/11743#issuecomment-1380691131 @woja Good call out. Would you like to submit a PR to fix it? cc @omkreddy -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [kafka] ijuma commented on pull request #13098: MINOR: remove BrokerMetadataListener

2023-01-12 Thread GitBox
ijuma commented on PR #13098: URL: https://github.com/apache/kafka/pull/13098#issuecomment-1380693617 Yay for deleting code. Worth explaining in the PR why we can delete this now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[jira] [Commented] (KAFKA-14615) Use sizeCompare(Iterable[_]) to compare two iterables

2023-01-12 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17676256#comment-17676256 ] Divij Vaidya commented on KAFKA-14615: -- Hey Kamalesh Thank you for your interest i

[jira] [Updated] (KAFKA-14611) ZK broker should not send epoch during registration

2023-01-12 Thread David Arthur (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur updated KAFKA-14611: - Fix Version/s: 3.5.0 > ZK broker should not send epoch during registration > ---

[jira] [Resolved] (KAFKA-14611) ZK broker should not send epoch during registration

2023-01-12 Thread David Arthur (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur resolved KAFKA-14611. -- Resolution: Fixed > ZK broker should not send epoch during registration >

[jira] [Commented] (KAFKA-14611) ZK broker should not send epoch during registration

2023-01-12 Thread David Arthur (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17676260#comment-17676260 ] David Arthur commented on KAFKA-14611: -- The commit for this fix was incorrectly lab

[GitHub] [kafka] jolshan commented on pull request #12886: KAFKA-14367; Add `OffsetCommit` to the new `GroupCoordinator` interface

2023-01-12 Thread GitBox
jolshan commented on PR #12886: URL: https://github.com/apache/kafka/pull/12886#issuecomment-1380723669 Still looks good to me 😄 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[GitHub] [kafka] dajac commented on pull request #12886: KAFKA-14367; Add `OffsetCommit` to the new `GroupCoordinator` interface

2023-01-12 Thread GitBox
dajac commented on PR #12886: URL: https://github.com/apache/kafka/pull/12886#issuecomment-1380727110 Failed tests are not related. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[GitHub] [kafka] dajac commented on pull request #12886: KAFKA-14367; Add `OffsetCommit` to the new `GroupCoordinator` interface

2023-01-12 Thread GitBox
dajac commented on PR #12886: URL: https://github.com/apache/kafka/pull/12886#issuecomment-1380731056 I will go ahead and merge it. I can do follow-ups if needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [kafka] dajac merged pull request #12886: KAFKA-14367; Add `OffsetCommit` to the new `GroupCoordinator` interface

2023-01-12 Thread GitBox
dajac merged PR #12886: URL: https://github.com/apache/kafka/pull/12886 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

[jira] [Commented] (KAFKA-14615) Use sizeCompare(Iterable[_]) to compare two iterables

2023-01-12 Thread Kamalesh Palanisamy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17676268#comment-17676268 ] Kamalesh Palanisamy commented on KAFKA-14615: - Oh okay. How do I find out Ji

[GitHub] [kafka] dajac commented on pull request #12901: KAFKA-14367; Add `TxnOffsetCommit` to the new `GroupCoordinator` interface

2023-01-12 Thread GitBox
dajac commented on PR #12901: URL: https://github.com/apache/kafka/pull/12901#issuecomment-1380781953 @jolshan @jeffkbkim Updated the PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [kafka] cmccabe commented on pull request #13089: KAFKA-14601: Improve exception handling in KafkaEventQueue

2023-01-12 Thread GitBox
cmccabe commented on PR #13089: URL: https://github.com/apache/kafka/pull/13089#issuecomment-1380795169 > One question I had is, do we see interrupts in production environments, or just on Jenkins? I would expect KafkaEventQueue to normally get shutdown cleanly via the normal shutdown routi

[jira] [Commented] (KAFKA-14603) Move KafkaMetricsGroup to server-common module.

2023-01-12 Thread Ivan Yurchenko (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17676282#comment-17676282 ] Ivan Yurchenko commented on KAFKA-14603: Thank you [~satish.duggana]. I'll move

[GitHub] [kafka] cmccabe merged pull request #13089: KAFKA-14601: Improve exception handling in KafkaEventQueue

2023-01-12 Thread GitBox
cmccabe merged PR #13089: URL: https://github.com/apache/kafka/pull/13089 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[GitHub] [kafka] dajac commented on a diff in pull request #12902: KAFKA-14367; Add `OffsetDelete` to the new `GroupCoordinator` interface

2023-01-12 Thread GitBox
dajac commented on code in PR #12902: URL: https://github.com/apache/kafka/pull/12902#discussion_r1068450233 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -3110,61 +3110,69 @@ class KafkaApis(val requestChannel: RequestChannel, } } - def handleOffsetDelet

[GitHub] [kafka] jolshan commented on a diff in pull request #12901: KAFKA-14367; Add `TxnOffsetCommit` to the new `GroupCoordinator` interface

2023-01-12 Thread GitBox
jolshan commented on code in PR #12901: URL: https://github.com/apache/kafka/pull/12901#discussion_r1068469845 ## core/src/main/scala/kafka/coordinator/group/GroupCoordinatorAdapter.scala: ## @@ -397,19 +389,24 @@ class GroupCoordinatorAdapter( request: TxnOffsetCommitReque

[GitHub] [kafka] sjetha commented on pull request #12331: KAFKA-1194: changes needed to run on Windows

2023-01-12 Thread GitBox
sjetha commented on PR #12331: URL: https://github.com/apache/kafka/pull/12331#issuecomment-1380820361 This is a really important fix for Windows. Can someone help move this along, please? -- This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [kafka] hachikuji commented on a diff in pull request #13104: KAFKA-14612: Make sure to write a new topics ConfigRecords to metadata log iff the topic is created

2023-01-12 Thread GitBox
hachikuji commented on code in PR #13104: URL: https://github.com/apache/kafka/pull/13104#discussion_r1068504478 ## metadata/src/test/java/org/apache/kafka/controller/ReplicationControlManagerTest.java: ## @@ -605,6 +617,45 @@ public void testCreateTopicsWithConfigs() throws Exc

[GitHub] [kafka] andymg3 commented on a diff in pull request #13104: KAFKA-14612: Make sure to write a new topics ConfigRecords to metadata log iff the topic is created

2023-01-12 Thread GitBox
andymg3 commented on code in PR #13104: URL: https://github.com/apache/kafka/pull/13104#discussion_r1068539671 ## metadata/src/test/java/org/apache/kafka/controller/ReplicationControlManagerTest.java: ## @@ -605,6 +617,45 @@ public void testCreateTopicsWithConfigs() throws Excep

[GitHub] [kafka] dajac commented on a diff in pull request #12901: KAFKA-14367; Add `TxnOffsetCommit` to the new `GroupCoordinator` interface

2023-01-12 Thread GitBox
dajac commented on code in PR #12901: URL: https://github.com/apache/kafka/pull/12901#discussion_r1068554964 ## core/src/main/scala/kafka/coordinator/group/GroupCoordinatorAdapter.scala: ## @@ -397,19 +389,24 @@ class GroupCoordinatorAdapter( request: TxnOffsetCommitRequest

[GitHub] [kafka] C0urante opened a new pull request, #13106: KAFKA-13709 (follow-up): Fix wording around exactly-once in Connect

2023-01-12 Thread GitBox
C0urante opened a new pull request, #13106: URL: https://github.com/apache/kafka/pull/13106 Filed in response to [discussion](https://github.com/apache/kafka/pull/12941#discussion_r1057921805) on the PR that added docs for exactly-once support in Connect. -- This is an automated message

[GitHub] [kafka] C0urante commented on a diff in pull request #12941: KAFKA-13709: Add docs for exactly-once support in Connect

2023-01-12 Thread GitBox
C0urante commented on code in PR #12941: URL: https://github.com/apache/kafka/pull/12941#discussion_r1068558694 ## docs/connect.html: ## @@ -369,6 +369,114 @@ Error Reportin # Tolerate all errors. errors.tolerance=all +Exactly-once support + +Kafka Connect is capabl

[GitHub] [kafka] C0urante commented on pull request #13106: KAFKA-13709 (follow-up): Fix wording around exactly-once in Connect

2023-01-12 Thread GitBox
C0urante commented on PR #13106: URL: https://github.com/apache/kafka/pull/13106#issuecomment-1380913304 cc @mjsax -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

[GitHub] [kafka] hachikuji commented on pull request #12271: KAFKA-13972; Ensure that replicas are stopped after cancelled reassignment

2023-01-12 Thread GitBox
hachikuji commented on PR #12271: URL: https://github.com/apache/kafka/pull/12271#issuecomment-1380969366 I'm going to close this PR and submit a new one which is tailored a little more closely to the problem with cancellation. I think there's not much appetite at the moment for a big chang

[GitHub] [kafka] hachikuji closed pull request #12271: KAFKA-13972; Ensure that replicas are stopped after cancelled reassignment

2023-01-12 Thread GitBox
hachikuji closed pull request #12271: KAFKA-13972; Ensure that replicas are stopped after cancelled reassignment URL: https://github.com/apache/kafka/pull/12271 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [kafka] dajac commented on pull request #12797: MINOR: Remove requirement to specify --bootstrap-server in utility scripts if specified in property file

2023-01-12 Thread GitBox
dajac commented on PR #12797: URL: https://github.com/apache/kafka/pull/12797#issuecomment-1380988519 Should we add unit tests? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

[jira] [Created] (KAFKA-14617) Replicas with stale broker epoch should not be allowed to join the ISR

2023-01-12 Thread Calvin Liu (Jira)
Calvin Liu created KAFKA-14617: -- Summary: Replicas with stale broker epoch should not be allowed to join the ISR Key: KAFKA-14617 URL: https://issues.apache.org/jira/browse/KAFKA-14617 Project: Kafka

[jira] [Assigned] (KAFKA-14617) Replicas with stale broker epoch should not be allowed to join the ISR

2023-01-12 Thread Calvin Liu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14617?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Calvin Liu reassigned KAFKA-14617: -- Assignee: Calvin Liu > Replicas with stale broker epoch should not be allowed to join the ISR

[jira] [Commented] (KAFKA-14565) Improve Interceptor Resource Leakage Prevention

2023-01-12 Thread Terry Beard (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17676359#comment-17676359 ] Terry Beard commented on KAFKA-14565: - [~ChrisEgerton]  I understood you the first t

[jira] [Comment Edited] (KAFKA-14565) Improve Interceptor Resource Leakage Prevention

2023-01-12 Thread Terry Beard (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17676359#comment-17676359 ] Terry Beard edited comment on KAFKA-14565 at 1/12/23 10:33 PM: ---

[GitHub] [kafka] mjsax commented on a diff in pull request #12742: KAFKA-10892: Shared Readonly State Stores ( revisited )

2023-01-12 Thread GitBox
mjsax commented on code in PR #12742: URL: https://github.com/apache/kafka/pull/12742#discussion_r1068740650 ## streams/src/main/java/org/apache/kafka/streams/Topology.java: ## @@ -737,6 +737,85 @@ public synchronized Topology addStateStore(final StoreBuilder storeBuilder,

[GitHub] [kafka] mjsax commented on pull request #11047: MINOR: Remove unnecessary code for WindowStoreBuilder.

2023-01-12 Thread GitBox
mjsax commented on PR #11047: URL: https://github.com/apache/kafka/pull/11047#issuecomment-1381080907 @tang7526 -- are you still interested to finish this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[jira] [Created] (KAFKA-14618) Off by one error in generated snapshot IDs causes misaligned fetching

2023-01-12 Thread Jason Gustafson (Jira)
Jason Gustafson created KAFKA-14618: --- Summary: Off by one error in generated snapshot IDs causes misaligned fetching Key: KAFKA-14618 URL: https://issues.apache.org/jira/browse/KAFKA-14618 Project:

[GitHub] [kafka] mjsax commented on pull request #12608: Enable KStream to be merged with itself

2023-01-12 Thread GitBox
mjsax commented on PR #12608: URL: https://github.com/apache/kafka/pull/12608#issuecomment-1381081214 @Danny02 -- Are you still interested to finish this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [kafka] hachikuji opened a new pull request, #13107: KAFKA-13972; Ensure replica state deleted after reassignment cancellation

2023-01-12 Thread GitBox
hachikuji opened a new pull request, #13107: URL: https://github.com/apache/kafka/pull/13107 When a reassignment is cancelled, we need to delete the partition state of adding replicas. Failing to do so causes "stray" partitions which take up disk space and can cause topicId conflicts if the

[jira] [Updated] (KAFKA-14618) Off by one error in generated snapshot IDs causes misaligned fetching

2023-01-12 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-14618?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] José Armando García Sancio updated KAFKA-14618: --- Description: We implemented new snapshot generation logic here: [htt

[jira] [Updated] (KAFKA-14618) Off by one error in generated snapshot IDs causes misaligned fetching

2023-01-12 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-14618?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] José Armando García Sancio updated KAFKA-14618: --- Description: We implemented new snapshot generation logic here: [htt

[jira] [Created] (KAFKA-14619) KRaft validate snapshot id are at batch boundries

2023-01-12 Thread Jira
José Armando García Sancio created KAFKA-14619: -- Summary: KRaft validate snapshot id are at batch boundries Key: KAFKA-14619 URL: https://issues.apache.org/jira/browse/KAFKA-14619 Project:

[jira] [Created] (KAFKA-14620) Add a type for SnapshotId

2023-01-12 Thread Jira
José Armando García Sancio created KAFKA-14620: -- Summary: Add a type for SnapshotId Key: KAFKA-14620 URL: https://issues.apache.org/jira/browse/KAFKA-14620 Project: Kafka Issue T

[GitHub] [kafka] jolshan commented on a diff in pull request #13107: KAFKA-13972; Ensure replica state deleted after reassignment cancellation

2023-01-12 Thread GitBox
jolshan commented on code in PR #13107: URL: https://github.com/apache/kafka/pull/13107#discussion_r1068766335 ## core/src/main/scala/kafka/controller/ControllerChannelManager.scala: ## @@ -436,17 +436,22 @@ abstract class AbstractControllerBrokerRequestBatch(config: KafkaConfi

[GitHub] [kafka] mjsax commented on pull request #9328: MINOR: Add deleteDir for streams quickstart test

2023-01-12 Thread GitBox
mjsax commented on PR #9328: URL: https://github.com/apache/kafka/pull/9328#issuecomment-1381110829 Closing as stale. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [kafka] mjsax closed pull request #9328: MINOR: Add deleteDir for streams quickstart test

2023-01-12 Thread GitBox
mjsax closed pull request #9328: MINOR: Add deleteDir for streams quickstart test URL: https://github.com/apache/kafka/pull/9328 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [kafka] hachikuji commented on a diff in pull request #13107: KAFKA-13972; Ensure replica state deleted after reassignment cancellation

2023-01-12 Thread GitBox
hachikuji commented on code in PR #13107: URL: https://github.com/apache/kafka/pull/13107#discussion_r1068783227 ## core/src/main/scala/kafka/controller/ControllerChannelManager.scala: ## @@ -436,17 +436,22 @@ abstract class AbstractControllerBrokerRequestBatch(config: KafkaCon

[GitHub] [kafka] hachikuji commented on a diff in pull request #13107: KAFKA-13972; Ensure replica state deleted after reassignment cancellation

2023-01-12 Thread GitBox
hachikuji commented on code in PR #13107: URL: https://github.com/apache/kafka/pull/13107#discussion_r1068783227 ## core/src/main/scala/kafka/controller/ControllerChannelManager.scala: ## @@ -436,17 +436,22 @@ abstract class AbstractControllerBrokerRequestBatch(config: KafkaCon

[jira] [Comment Edited] (KAFKA-14565) Improve Interceptor Resource Leakage Prevention

2023-01-12 Thread Terry Beard (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17676359#comment-17676359 ] Terry Beard edited comment on KAFKA-14565 at 1/13/23 12:12 AM: ---

[GitHub] [kafka] hachikuji merged pull request #13104: KAFKA-14612: Make sure to write a new topics ConfigRecords to metadata log iff the topic is created

2023-01-12 Thread GitBox
hachikuji merged PR #13104: URL: https://github.com/apache/kafka/pull/13104 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apach

[jira] [Assigned] (KAFKA-14618) Off by one error in generated snapshot IDs causes misaligned fetching

2023-01-12 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-14618?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] José Armando García Sancio reassigned KAFKA-14618: -- Assignee: José Armando García Sancio (was: Jason Gustafson)

[GitHub] [kafka] ijuma commented on a diff in pull request #13085: KAFKA-14568: Move FetchDataInfo and related to storage module

2023-01-12 Thread GitBox
ijuma commented on code in PR #13085: URL: https://github.com/apache/kafka/pull/13085#discussion_r1068799077 ## storage/src/main/java/org/apache/kafka/server/log/internals/FetchDataInfo.java: ## @@ -0,0 +1,78 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [kafka] ijuma commented on a diff in pull request #13085: KAFKA-14568: Move FetchDataInfo and related to storage module

2023-01-12 Thread GitBox
ijuma commented on code in PR #13085: URL: https://github.com/apache/kafka/pull/13085#discussion_r1068798767 ## core/src/test/scala/unit/kafka/server/ReplicaAlterLogDirsThreadTest.scala: ## @@ -276,25 +276,22 @@ class ReplicaAlterLogDirsThreadTest { val callbackCaptor: Argu

[GitHub] [kafka] ijuma commented on a diff in pull request #13085: KAFKA-14568: Move FetchDataInfo and related to storage module

2023-01-12 Thread GitBox
ijuma commented on code in PR #13085: URL: https://github.com/apache/kafka/pull/13085#discussion_r1068799278 ## storage/src/main/java/org/apache/kafka/server/log/internals/FetchParams.java: ## @@ -0,0 +1,125 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one o

[jira] [Resolved] (KAFKA-14612) Topic config records written to log even when topic creation fails

2023-01-12 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14612?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson resolved KAFKA-14612. - Fix Version/s: 3.4.0 Resolution: Fixed > Topic config records written to log even

[GitHub] [kafka] jolshan commented on a diff in pull request #13107: KAFKA-13972; Ensure replica state deleted after reassignment cancellation

2023-01-12 Thread GitBox
jolshan commented on code in PR #13107: URL: https://github.com/apache/kafka/pull/13107#discussion_r1068804579 ## core/src/main/scala/kafka/controller/ControllerChannelManager.scala: ## @@ -436,17 +436,22 @@ abstract class AbstractControllerBrokerRequestBatch(config: KafkaConfi

[GitHub] [kafka] jsancio opened a new pull request, #13108: KAFKA-14618; Fix off by one error in snapshot id

2023-01-12 Thread GitBox
jsancio opened a new pull request, #13108: URL: https://github.com/apache/kafka/pull/13108 The KRaft client expects the offset of the snapshot id to be an end offset. End offsets are exclusive. The MetadataProvenance type was createing a snapshot id using the last contained offset which is

[GitHub] [kafka] jsancio commented on a diff in pull request #13108: KAFKA-14618; Fix off by one error in snapshot id

2023-01-12 Thread GitBox
jsancio commented on code in PR #13108: URL: https://github.com/apache/kafka/pull/13108#discussion_r1068830987 ## metadata/src/main/java/org/apache/kafka/image/MetadataProvenance.java: ## @@ -28,30 +29,30 @@ public final class MetadataProvenance { public static final Metad

[jira] [Commented] (KAFKA-14459) Document how to use and close a 'Statistics' in the example RocksDBConfigSetter

2023-01-12 Thread Sujay Hegde (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17676431#comment-17676431 ] Sujay Hegde commented on KAFKA-14459: - Hi [~ableegoldman] . Sure will have a look an

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #12901: KAFKA-14367; Add `TxnOffsetCommit` to the new `GroupCoordinator` interface

2023-01-12 Thread GitBox
jeffkbkim commented on code in PR #12901: URL: https://github.com/apache/kafka/pull/12901#discussion_r1068928367 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -2464,90 +2464,108 @@ class KafkaApis(val requestChannel: RequestChannel, } } - def handleTxnOff

[GitHub] [kafka] ijuma commented on pull request #13085: KAFKA-14568: Move FetchDataInfo and related to storage module

2023-01-12 Thread GitBox
ijuma commented on PR #13085: URL: https://github.com/apache/kafka/pull/13085#issuecomment-1381334743 JDK 8 and 11 builds passed, 17 had 2 unrelated failures. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [kafka] ijuma merged pull request #13085: KAFKA-14568: Move FetchDataInfo and related to storage module

2023-01-12 Thread GitBox
ijuma merged PR #13085: URL: https://github.com/apache/kafka/pull/13085 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

[jira] [Resolved] (KAFKA-14568) Move FetchDataInfo and related to storage module

2023-01-12 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma resolved KAFKA-14568. - Resolution: Fixed > Move FetchDataInfo and related to storage module > -

[GitHub] [kafka] cmccabe commented on a diff in pull request #13108: KAFKA-14618; Fix off by one error in snapshot id

2023-01-12 Thread GitBox
cmccabe commented on code in PR #13108: URL: https://github.com/apache/kafka/pull/13108#discussion_r1068983515 ## metadata/src/main/java/org/apache/kafka/image/MetadataProvenance.java: ## @@ -28,30 +29,30 @@ public final class MetadataProvenance { public static final Metad

[GitHub] [kafka] dajac commented on pull request #12901: KAFKA-14367; Add `TxnOffsetCommit` to the new `GroupCoordinator` interface

2023-01-12 Thread GitBox
dajac commented on PR #12901: URL: https://github.com/apache/kafka/pull/12901#issuecomment-1381438609 Failed tests are not related. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[GitHub] [kafka] dajac commented on a diff in pull request #12901: KAFKA-14367; Add `TxnOffsetCommit` to the new `GroupCoordinator` interface

2023-01-12 Thread GitBox
dajac commented on code in PR #12901: URL: https://github.com/apache/kafka/pull/12901#discussion_r1069047687 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -2464,90 +2464,108 @@ class KafkaApis(val requestChannel: RequestChannel, } } - def handleTxnOffsetC