ijuma commented on code in PR #13085:
URL: https://github.com/apache/kafka/pull/13085#discussion_r1068798767
##########
core/src/test/scala/unit/kafka/server/ReplicaAlterLogDirsThreadTest.scala:
##########
@@ -276,25 +276,22 @@ class ReplicaAlterLogDirsThreadTest {
val callbackCaptor: ArgumentCaptor[Seq[(TopicIdPartition,
FetchPartitionData)] => Unit] =
ArgumentCaptor.forClass(classOf[Seq[(TopicIdPartition,
FetchPartitionData)] => Unit])
- val expectedFetchParams = FetchParams(
- requestVersion = ApiKeys.FETCH.latestVersion,
- replicaId = Request.FutureLocalReplicaId,
- maxWaitMs = 0L,
- minBytes = 0,
- maxBytes = config.replicaFetchResponseMaxBytes,
- isolation = FetchLogEnd,
- clientMetadata = None
+ val expectedFetchParams = new FetchParams(
+ ApiKeys.FETCH.latestVersion,
+ FetchRequest.FUTURE_LOCAL_REPLICA_ID,
+ 0L,
+ 0,
+ config.replicaFetchResponseMaxBytes,
+ FetchIsolation.LOG_END,
+ Optional.empty()
)
- println(expectedFetchParams)
-
when(replicaManager.fetchMessages(
params = ArgumentMatchers.eq(expectedFetchParams),
fetchInfos = ArgumentMatchers.eq(Seq(topicIdPartition -> requestData)),
quota = ArgumentMatchers.eq(UnboundedQuota),
responseCallback = callbackCaptor.capture(),
)).thenAnswer(_ => {
- println("Did we get the callback?")
Review Comment:
Deleted two stray `println` here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
