[GitHub] [kafka] calmera commented on a diff in pull request #12742: KAFKA-10892: Shared Readonly State Stores ( revisited )

calmera commented on code in PR #12742: URL: https://github.com/apache/kafka/pull/12742#discussion_r1063269411 ## streams/src/main/java/org/apache/kafka/streams/Topology.java: ## @@ -737,6 +737,91 @@ public synchronized Topology addStateStore(final StoreBuilder storeBuilder,

[GitHub] [kafka] calmera commented on a diff in pull request #12742: KAFKA-10892: Shared Readonly State Stores ( revisited )

calmera commented on code in PR #12742: URL: https://github.com/apache/kafka/pull/12742#discussion_r1063270375 ## streams/src/main/java/org/apache/kafka/streams/Topology.java: ## @@ -737,6 +737,91 @@ public synchronized Topology addStateStore(final StoreBuilder storeBuilder,

[GitHub] [kafka] calmera commented on a diff in pull request #12742: KAFKA-10892: Shared Readonly State Stores ( revisited )

calmera commented on code in PR #12742: URL: https://github.com/apache/kafka/pull/12742#discussion_r1063271295 ## streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamBranchTest.java: ## @@ -59,7 +59,7 @@ public void testKStreamBranch() { assertEqua

[GitHub] [kafka] calmera commented on a diff in pull request #12742: KAFKA-10892: Shared Readonly State Stores ( revisited )

calmera commented on code in PR #12742: URL: https://github.com/apache/kafka/pull/12742#discussion_r1063273259 ## streams/src/test/java/org/apache/kafka/test/MockProcessor.java: ## @@ -28,9 +29,11 @@ import java.util.List; import java.util.Map; -@SuppressWarnings("deprecatio

[GitHub] [kafka] rajinisivaram commented on pull request #13081: Re-using callbackHandler for refreshing Kerberos TGT when keytab is not used

rajinisivaram commented on PR #13081: URL: https://github.com/apache/kafka/pull/13081#issuecomment-1373402351 @vladimirdyuzhev Thanks for the PR. Since this is a security-related change, can we create a JIRA with the details from the PR description and include the ticket in the PR title? Ca

[GitHub] [kafka] rajinisivaram commented on a diff in pull request #13081: Re-using callbackHandler for refreshing Kerberos TGT when keytab is not used

rajinisivaram commented on code in PR #13081: URL: https://github.com/apache/kafka/pull/13081#discussion_r1063281046 ## clients/src/main/java/org/apache/kafka/common/security/kerberos/KerberosLogin.java: ## @@ -90,6 +91,7 @@ public void configure(Map configs, String contextName

[jira] [Created] (KAFKA-14598) Fix flaky ConnectRestApiTest

Ashwin Pankaj created KAFKA-14598: - Summary: Fix flaky ConnectRestApiTest Key: KAFKA-14598 URL: https://issues.apache.org/jira/browse/KAFKA-14598 Project: Kafka Issue Type: Bug Comp

[jira] [Updated] (KAFKA-14598) Fix flaky ConnectRestApiTest

[ https://issues.apache.org/jira/browse/KAFKA-14598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashwin Pankaj updated KAFKA-14598: -- Description: ConnectRestApiTest sometimes fails with the message {{ConnectRestError(404, '\n

[jira] [Updated] (KAFKA-14598) Fix flaky ConnectRestApiTest

[ https://issues.apache.org/jira/browse/KAFKA-14598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashwin Pankaj updated KAFKA-14598: -- Description: ConnectRestApiTest sometimes fails with the message {{ConnectRestError(404, '\n

[GitHub] [kafka] calmera commented on a diff in pull request #12742: KAFKA-10892: Shared Readonly State Stores ( revisited )

calmera commented on code in PR #12742: URL: https://github.com/apache/kafka/pull/12742#discussion_r1063310192 ## docs/streams/developer-guide/processor-api.html: ## @@ -396,6 +397,21 @@ + +ReadOnly S

[GitHub] [kafka] ashwinpankaj opened a new pull request, #13084: KAFKA-14598: Fix flaky ConnectRestApiTest

ashwinpankaj opened a new pull request, #13084: URL: https://github.com/apache/kafka/pull/13084 https://issues.apache.org/jira/browse/KAFKA-14598 ConnectRestApiTest sometimes fails with the message ``` ConnectRestError(404, '\n\n\nError 404 Not Found\n\nHTTP ERROR 404 Not Found

[jira] [Created] (KAFKA-14599) MirrorMaker pluggable interfaces missing from public API

Mickael Maison created KAFKA-14599: -- Summary: MirrorMaker pluggable interfaces missing from public API Key: KAFKA-14599 URL: https://issues.apache.org/jira/browse/KAFKA-14599 Project: Kafka

[GitHub] [kafka] calmera commented on a diff in pull request #12742: KAFKA-10892: Shared Readonly State Stores ( revisited )

calmera commented on code in PR #12742: URL: https://github.com/apache/kafka/pull/12742#discussion_r1063316877 ## docs/streams/developer-guide/processor-api.html: ## @@ -396,6 +397,21 @@ + +ReadOnly S

[GitHub] [kafka] tombentley merged pull request #13071: MINOR: doc: note how JDK-8136913 can affect client SASL

tombentley merged PR #13071: URL: https://github.com/apache/kafka/pull/13071 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apac

[GitHub] [kafka] calmera commented on a diff in pull request #12742: KAFKA-10892: Shared Readonly State Stores ( revisited )

calmera commented on code in PR #12742: URL: https://github.com/apache/kafka/pull/12742#discussion_r1063323844 ## streams/src/main/java/org/apache/kafka/streams/Topology.java: ## @@ -737,6 +737,91 @@ public synchronized Topology addStateStore(final StoreBuilder storeBuilder,

[GitHub] [kafka] calmera commented on pull request #12742: KAFKA-10892: Shared Readonly State Stores ( revisited )

calmera commented on PR #12742: URL: https://github.com/apache/kafka/pull/12742#issuecomment-1373454834 I agree we need to have some tests for that but that will require a bit more time and effort. I'll try to allocate some time to get that done, but if there is someone else who wants to ju

[jira] [Resolved] (KAFKA-14072) Crashed MirrorCheckpointConnector appears as running in REST API

[ https://issues.apache.org/jira/browse/KAFKA-14072?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison resolved KAFKA-14072. Fix Version/s: 3.5.0 Resolution: Fixed This looks like it's the same issue as KAFKA

[GitHub] [kafka] satishd commented on a diff in pull request #13043: KAFKA-14558: Move LastRecord, TxnMetadata, BatchMetadata, ProducerStateEntry, and ProducerAppendInfo to the storage module

satishd commented on code in PR #13043: URL: https://github.com/apache/kafka/pull/13043#discussion_r1063467329 ## storage/src/main/java/org/apache/kafka/server/log/internals/ProducerAppendInfo.java: ## @@ -0,0 +1,238 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

[GitHub] [kafka] vladimirdyuzhev commented on a diff in pull request #13081: Re-using callbackHandler for refreshing Kerberos TGT when keytab is not used

vladimirdyuzhev commented on code in PR #13081: URL: https://github.com/apache/kafka/pull/13081#discussion_r1063475320 ## clients/src/main/java/org/apache/kafka/common/security/kerberos/KerberosLogin.java: ## @@ -90,6 +91,7 @@ public void configure(Map configs, String contextNa

[GitHub] [kafka] fvaleri opened a new pull request, #13085: KAFKA-14568: Move FetchDataInfo and related to storage module

fvaleri opened a new pull request, #13085: URL: https://github.com/apache/kafka/pull/13085 Part of KAFKA-14470: Move log layer to storage module. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kafka] fvaleri commented on pull request #13085: KAFKA-14568: Move FetchDataInfo and related to storage module

fvaleri commented on PR #13085: URL: https://github.com/apache/kafka/pull/13085#issuecomment-1373794678 @ijuma @satishd fyi -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [kafka] ijuma commented on a diff in pull request #13085: KAFKA-14568: Move FetchDataInfo and related to storage module

ijuma commented on code in PR #13085: URL: https://github.com/apache/kafka/pull/13085#discussion_r1063544116 ## storage/src/main/java/org/apache/kafka/server/log/internals/FetchIsolation.java: ## @@ -0,0 +1,36 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [kafka] emilnkrastev commented on a diff in pull request #11818: KAFKA-12558: Do not prematurely mutate partiton state and provide con…

emilnkrastev commented on code in PR #11818: URL: https://github.com/apache/kafka/pull/11818#discussion_r1063558786 ## connect/mirror/src/test/java/org/apache/kafka/connect/mirror/MirrorSourceTaskTest.java: ## @@ -81,15 +88,25 @@ public void testOffsetSync() { MirrorSou

[GitHub] [kafka] emilnkrastev commented on a diff in pull request #11818: KAFKA-12558: Do not prematurely mutate partiton state and provide con…

emilnkrastev commented on code in PR #11818: URL: https://github.com/apache/kafka/pull/11818#discussion_r1063558786 ## connect/mirror/src/test/java/org/apache/kafka/connect/mirror/MirrorSourceTaskTest.java: ## @@ -81,15 +88,25 @@ public void testOffsetSync() { MirrorSou

[GitHub] [kafka] emilnkrastev commented on a diff in pull request #11818: KAFKA-12558: Do not prematurely mutate partiton state and provide con…

emilnkrastev commented on code in PR #11818: URL: https://github.com/apache/kafka/pull/11818#discussion_r1063563770 ## connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorSourceTask.java: ## @@ -69,14 +69,19 @@ public MirrorSourceTask() {} // for testing

[GitHub] [kafka] fvaleri commented on a diff in pull request #13085: KAFKA-14568: Move FetchDataInfo and related to storage module

fvaleri commented on code in PR #13085: URL: https://github.com/apache/kafka/pull/13085#discussion_r1063594153 ## storage/src/main/java/org/apache/kafka/server/log/internals/FetchIsolation.java: ## @@ -0,0 +1,36 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under o

[GitHub] [kafka] ijuma commented on a diff in pull request #13085: KAFKA-14568: Move FetchDataInfo and related to storage module

ijuma commented on code in PR #13085: URL: https://github.com/apache/kafka/pull/13085#discussion_r1063598351 ## storage/src/main/java/org/apache/kafka/server/log/internals/FetchIsolation.java: ## @@ -0,0 +1,36 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [kafka] fvaleri commented on a diff in pull request #13085: KAFKA-14568: Move FetchDataInfo and related to storage module

fvaleri commented on code in PR #13085: URL: https://github.com/apache/kafka/pull/13085#discussion_r1063609877 ## storage/src/main/java/org/apache/kafka/server/log/internals/FetchIsolation.java: ## @@ -0,0 +1,36 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under o

[GitHub] [kafka] ijuma commented on a diff in pull request #13085: KAFKA-14568: Move FetchDataInfo and related to storage module

ijuma commented on code in PR #13085: URL: https://github.com/apache/kafka/pull/13085#discussion_r1063613984 ## storage/src/main/java/org/apache/kafka/server/log/internals/FetchIsolation.java: ## @@ -0,0 +1,36 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [kafka] ijuma commented on a diff in pull request #13085: KAFKA-14568: Move FetchDataInfo and related to storage module

ijuma commented on code in PR #13085: URL: https://github.com/apache/kafka/pull/13085#discussion_r1063613984 ## storage/src/main/java/org/apache/kafka/server/log/internals/FetchIsolation.java: ## @@ -0,0 +1,36 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [kafka] fvaleri commented on a diff in pull request #13085: KAFKA-14568: Move FetchDataInfo and related to storage module

fvaleri commented on code in PR #13085: URL: https://github.com/apache/kafka/pull/13085#discussion_r1063631875 ## storage/src/main/java/org/apache/kafka/server/log/internals/FetchIsolation.java: ## @@ -0,0 +1,36 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under o

[GitHub] [kafka] chia7712 commented on a diff in pull request #13075: KAFKA-9087 Replace log high watermark by future log high watermark wh…

chia7712 commented on code in PR #13075: URL: https://github.com/apache/kafka/pull/13075#discussion_r1063654318 ## core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala: ## @@ -205,6 +205,61 @@ class ReplicaManagerTest { when(cache.getAliveBrokerNodes(any[ListenerN

[GitHub] [kafka] chia7712 commented on a diff in pull request #13075: KAFKA-9087 Replace log high watermark by future log high watermark wh…

chia7712 commented on code in PR #13075: URL: https://github.com/apache/kafka/pull/13075#discussion_r1063654698 ## core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala: ## @@ -205,6 +205,61 @@ class ReplicaManagerTest { when(cache.getAliveBrokerNodes(any[ListenerN

[GitHub] [kafka] satishd commented on pull request #13043: KAFKA-14558: Move LastRecord, TxnMetadata, BatchMetadata, ProducerStateEntry, and ProducerAppendInfo to the storage module

satishd commented on PR #13043: URL: https://github.com/apache/kafka/pull/13043#issuecomment-1373959751 Thanks @ijuma for the review. I address them in the code and replied to your comment. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[jira] [Assigned] (KAFKA-14535) Flaky test PlaintextEndToEndAuthorizationTest.testNoConsumeWithoutDescribeAclViaSubscribe

[ https://issues.apache.org/jira/browse/KAFKA-14535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Harris reassigned KAFKA-14535: --- Assignee: Greg Harris > Flaky test > PlaintextEndToEndAuthorizationTest.testNoConsumeWitho

[GitHub] [kafka] junrao commented on a diff in pull request #13075: KAFKA-9087 Replace log high watermark by future log high watermark wh…

junrao commented on code in PR #13075: URL: https://github.com/apache/kafka/pull/13075#discussion_r1063679649 ## core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala: ## @@ -205,6 +205,61 @@ class ReplicaManagerTest { when(cache.getAliveBrokerNodes(any[ListenerNam

[GitHub] [kafka] ijuma commented on a diff in pull request #13085: KAFKA-14568: Move FetchDataInfo and related to storage module

ijuma commented on code in PR #13085: URL: https://github.com/apache/kafka/pull/13085#discussion_r1063687740 ## core/src/main/scala/kafka/log/UnifiedLog.scala: ## @@ -1249,12 +1249,10 @@ class UnifiedLog(@volatile var logStartOffset: Long, isolation: FetchIsolation,

[GitHub] [kafka] gharris1727 opened a new pull request, #13086: KAFKA-14535: Fix flaky EndToEndAuthorization tests which were sensitive to ACL change reordering

gharris1727 opened a new pull request, #13086: URL: https://github.com/apache/kafka/pull/13086 The ACL change methods (create, delete) are eventually consistent across a Kafka cluster. As part of that, changes to the same resource made to different brokers may be reordered. In this test, a

[GitHub] [kafka] ijuma commented on a diff in pull request #13085: KAFKA-14568: Move FetchDataInfo and related to storage module

ijuma commented on code in PR #13085: URL: https://github.com/apache/kafka/pull/13085#discussion_r1063688608 ## storage/src/main/java/org/apache/kafka/server/log/internals/FetchIsolation.java: ## @@ -0,0 +1,41 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [kafka] gharris1727 commented on pull request #13086: KAFKA-14535: Fix flaky EndToEndAuthorization tests which were sensitive to ACL change reordering

gharris1727 commented on PR #13086: URL: https://github.com/apache/kafka/pull/13086#issuecomment-1374008851 The last people working in this area were @pprovenzano @omkreddy and @soarez, if any of you have some time i'd appreciate a review on this test which flakes ~10-20% of the time. Thank

[GitHub] [kafka] ijuma commented on a diff in pull request #13046: KAFKA-14551 Move LeaderEpochFileCache and its dependencies to the storage module.

ijuma commented on code in PR #13046: URL: https://github.com/apache/kafka/pull/13046#discussion_r1063705498 ## core/src/main/scala/kafka/log/UnifiedLog.scala: ## @@ -995,11 +994,12 @@ class UnifiedLog(@volatile var logStartOffset: Long, } } - def latestEpoch: Option[

[GitHub] [kafka] ijuma commented on a diff in pull request #13046: KAFKA-14551 Move LeaderEpochFileCache and its dependencies to the storage module.

ijuma commented on code in PR #13046: URL: https://github.com/apache/kafka/pull/13046#discussion_r1063708632 ## core/src/main/scala/kafka/server/checkpoints/OffsetCheckpointFile.scala: ## @@ -65,9 +65,14 @@ class OffsetCheckpointFile(val file: File, logDirFailureChannel: LogDir

[GitHub] [kafka] ijuma commented on a diff in pull request #13046: KAFKA-14551 Move LeaderEpochFileCache and its dependencies to the storage module.

ijuma commented on code in PR #13046: URL: https://github.com/apache/kafka/pull/13046#discussion_r1063709428 ## storage/src/main/java/org/apache/kafka/server/log/internals/LeaderEpochFileCache.java: ## @@ -0,0 +1,380 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

[GitHub] [kafka] ijuma commented on pull request #13046: KAFKA-14551 Move LeaderEpochFileCache and its dependencies to the storage module.

ijuma commented on PR #13046: URL: https://github.com/apache/kafka/pull/13046#issuecomment-1374023466 I have a few more comments on this PR, will get back to it soon. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [kafka] ijuma commented on a diff in pull request #13043: KAFKA-14558: Move LastRecord, TxnMetadata, BatchMetadata, ProducerStateEntry, and ProducerAppendInfo to the storage module

ijuma commented on code in PR #13043: URL: https://github.com/apache/kafka/pull/13043#discussion_r1063714637 ## storage/src/main/java/org/apache/kafka/server/log/internals/TxnMetadata.java: ## @@ -0,0 +1,70 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[jira] [Created] (KAFKA-14600) Flaky test ProducerIdExpirationTest

Greg Harris created KAFKA-14600: --- Summary: Flaky test ProducerIdExpirationTest Key: KAFKA-14600 URL: https://issues.apache.org/jira/browse/KAFKA-14600 Project: Kafka Issue Type: Test

[GitHub] [kafka] ijuma commented on a diff in pull request #13043: KAFKA-14558: Move LastRecord, TxnMetadata, BatchMetadata, ProducerStateEntry, and ProducerAppendInfo to the storage module

ijuma commented on code in PR #13043: URL: https://github.com/apache/kafka/pull/13043#discussion_r1063720614 ## storage/src/main/java/org/apache/kafka/server/log/internals/ProducerStateEntry.java: ## @@ -0,0 +1,148 @@ +/* + * Licensed to the Apache Software Foundation (ASF) unde

[GitHub] [kafka] ijuma commented on a diff in pull request #13043: KAFKA-14558: Move LastRecord, TxnMetadata, BatchMetadata, ProducerStateEntry, and ProducerAppendInfo to the storage module

ijuma commented on code in PR #13043: URL: https://github.com/apache/kafka/pull/13043#discussion_r1063720614 ## storage/src/main/java/org/apache/kafka/server/log/internals/ProducerStateEntry.java: ## @@ -0,0 +1,148 @@ +/* + * Licensed to the Apache Software Foundation (ASF) unde

[GitHub] [kafka] ijuma commented on a diff in pull request #13043: KAFKA-14558: Move LastRecord, TxnMetadata, BatchMetadata, ProducerStateEntry, and ProducerAppendInfo to the storage module

ijuma commented on code in PR #13043: URL: https://github.com/apache/kafka/pull/13043#discussion_r1063722024 ## storage/src/main/java/org/apache/kafka/server/log/internals/ProducerStateEntry.java: ## @@ -0,0 +1,143 @@ +/* + * Licensed to the Apache Software Foundation (ASF) unde

[GitHub] [kafka] gharris1727 opened a new pull request, #13087: KAFKA-14600: Reduce flakiness in ProducerIdExpirationTest

gharris1727 opened a new pull request, #13087: URL: https://github.com/apache/kafka/pull/13087 The broker appears to be timing out the producer ID before the test can see it. Increase the timeouts to compensate for slower CI environments. Similar to the fix applied in #13036

[GitHub] [kafka] gharris1727 commented on pull request #13087: KAFKA-14600: Reduce flakiness in ProducerIdExpirationTest

gharris1727 commented on PR #13087: URL: https://github.com/apache/kafka/pull/13087#issuecomment-1374038135 @jolshan could you take a look at this as well? I didn't realize these two tests were failing in a similar fashion. -- This is an automated message from the Apache Git Service. To r

[GitHub] [kafka] ijuma commented on a diff in pull request #13043: KAFKA-14558: Move LastRecord, TxnMetadata, BatchMetadata, ProducerStateEntry, and ProducerAppendInfo to the storage module

ijuma commented on code in PR #13043: URL: https://github.com/apache/kafka/pull/13043#discussion_r1063725076 ## core/src/main/scala/kafka/log/LogCleaner.scala: ## @@ -174,7 +174,8 @@ class LogCleaner(initialConfig: CleanerConfig, } override def validateReconfiguration(ne

[GitHub] [kafka] ijuma commented on a diff in pull request #13043: KAFKA-14558: Move LastRecord, TxnMetadata, BatchMetadata, ProducerStateEntry, and ProducerAppendInfo to the storage module

ijuma commented on code in PR #13043: URL: https://github.com/apache/kafka/pull/13043#discussion_r1063726604 ## storage/src/main/java/org/apache/kafka/server/log/internals/ProducerAppendInfo.java: ## @@ -0,0 +1,238 @@ +/* + * Licensed to the Apache Software Foundation (ASF) unde

[jira] [Created] (KAFKA-14601) Improve exception handling in KafkaEventQueue

Colin McCabe created KAFKA-14601: Summary: Improve exception handling in KafkaEventQueue Key: KAFKA-14601 URL: https://issues.apache.org/jira/browse/KAFKA-14601 Project: Kafka Issue Type: Bug

[GitHub] [kafka] ijuma commented on a diff in pull request #13043: KAFKA-14558: Move LastRecord, TxnMetadata, BatchMetadata, ProducerStateEntry, and ProducerAppendInfo to the storage module

ijuma commented on code in PR #13043: URL: https://github.com/apache/kafka/pull/13043#discussion_r1063733019 ## core/src/test/scala/unit/kafka/log/ProducerStateManagerTest.scala: ## @@ -255,15 +259,28 @@ class ProducerStateManagerTest { appendData(30L, 31L, secondAppend)

[GitHub] [kafka] chia7712 commented on a diff in pull request #13075: KAFKA-9087 Replace log high watermark by future log high watermark wh…

chia7712 commented on code in PR #13075: URL: https://github.com/apache/kafka/pull/13075#discussion_r1063756861 ## core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala: ## @@ -205,6 +205,61 @@ class ReplicaManagerTest { when(cache.getAliveBrokerNodes(any[ListenerN

[GitHub] [kafka] chia7712 commented on a diff in pull request #13075: KAFKA-9087 Replace log high watermark by future log high watermark wh…

chia7712 commented on code in PR #13075: URL: https://github.com/apache/kafka/pull/13075#discussion_r1063758284 ## core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala: ## @@ -205,6 +205,63 @@ class ReplicaManagerTest { when(cache.getAliveBrokerNodes(any[ListenerN

[GitHub] [kafka] michaeljmarshall commented on pull request #13032: KAFKA-14540: Fix DataOutputStreamWritable#writeByteBuffer

michaeljmarshall commented on PR #13032: URL: https://github.com/apache/kafka/pull/13032#issuecomment-1374113532 Thanks for catching my mistake @viktorsomogyi. My mistake was trusting IntelliJ to run the test. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] michaeljmarshall commented on a diff in pull request #13032: KAFKA-14540: Fix DataOutputStreamWritable#writeByteBuffer

michaeljmarshall commented on code in PR #13032: URL: https://github.com/apache/kafka/pull/13032#discussion_r1063786426 ## clients/src/test/java/org/apache/kafka/common/protocol/DataOutputStreamWritableTest.java: ## @@ -0,0 +1,66 @@ +/* + * Licensed to the Apache Software Founda

[GitHub] [kafka] justinrlee commented on pull request #12797: MINOR: Remove requirement to specify --bootstrap-server in utility scripts if specified in property file

justinrlee commented on PR #12797: URL: https://github.com/apache/kafka/pull/12797#issuecomment-1374119222 Give me a little bit, will add sample outputs for different scenarios shortly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

[GitHub] [kafka] gharris1727 commented on pull request #13084: KAFKA-14598: Fix flaky ConnectRestApiTest

gharris1727 commented on PR #13084: URL: https://github.com/apache/kafka/pull/13084#issuecomment-1374130131 Is this a change in behavior? It appears that the default mode is LISTEN: https://github.com/apache/kafka/blob/95910af3a9125c3c67fe5daebf1e01d7ec6f20c7/tests/kafkatest/services/connect

[GitHub] [kafka] junrao commented on a diff in pull request #13075: KAFKA-9087 Replace log high watermark by future log high watermark wh…

junrao commented on code in PR #13075: URL: https://github.com/apache/kafka/pull/13075#discussion_r1063808402 ## core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala: ## @@ -205,6 +205,63 @@ class ReplicaManagerTest { when(cache.getAliveBrokerNodes(any[ListenerNam

[GitHub] [kafka] chb2ab opened a new pull request, #13088: 2.8 kafka-9648

chb2ab opened a new pull request, #13088: URL: https://github.com/apache/kafka/pull/13088 Cherry-picking KAFKA-9648, more details in this thread https://confluent.slack.com/archives/C04HL38HTU1/p1672725997759019 Conflicts: Whitespace in SocketServerTest.scala -- This is an

[GitHub] [kafka] chb2ab closed pull request #13088: 2.8 kafka-9648

chb2ab closed pull request #13088: 2.8 kafka-9648 URL: https://github.com/apache/kafka/pull/13088 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-u

[GitHub] [kafka] chia7712 commented on a diff in pull request #13075: KAFKA-9087 Replace log high watermark by future log high watermark wh…

chia7712 commented on code in PR #13075: URL: https://github.com/apache/kafka/pull/13075#discussion_r1063817794 ## core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala: ## @@ -205,6 +205,61 @@ class ReplicaManagerTest { when(cache.getAliveBrokerNodes(any[ListenerN

[GitHub] [kafka] mjsax commented on pull request #13077: KAFKA-14279; Add 3.3.x streams system tests

mjsax commented on PR #13077: URL: https://github.com/apache/kafka/pull/13077#issuecomment-1374181721 @jsancio -- any update? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [kafka] junrao commented on a diff in pull request #12462: [KAFKA-9965] Fix accumulator tryAppend, so that fresh new producerBatch is created

junrao commented on code in PR #12462: URL: https://github.com/apache/kafka/pull/12462#discussion_r1063864650 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordAccumulator.java: ## @@ -287,12 +291,16 @@ public RecordAppendResult append(String topic,

[GitHub] [kafka] artemlivshits commented on a diff in pull request #12462: [KAFKA-9965] Fix accumulator tryAppend, so that fresh new producerBatch is created

artemlivshits commented on code in PR #12462: URL: https://github.com/apache/kafka/pull/12462#discussion_r1063869321 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordAccumulator.java: ## @@ -287,12 +291,16 @@ public RecordAppendResult append(String topi

[jira] [Commented] (KAFKA-14573) RoundRobinPartitioner doesn't work as expected with topic that has 6 partitions

[ https://issues.apache.org/jira/browse/KAFKA-14573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17655598#comment-17655598 ] Justine Olshan commented on KAFKA-14573: May be related to this issue? [https://

[GitHub] [kafka] ijuma commented on a diff in pull request #12462: [KAFKA-9965] Fix accumulator tryAppend, so that fresh new producerBatch is created

ijuma commented on code in PR #12462: URL: https://github.com/apache/kafka/pull/12462#discussion_r1063873789 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordAccumulator.java: ## @@ -287,12 +291,16 @@ public RecordAppendResult append(String topic,

[GitHub] [kafka] junrao commented on a diff in pull request #12462: [KAFKA-9965] Fix accumulator tryAppend, so that fresh new producerBatch is created

junrao commented on code in PR #12462: URL: https://github.com/apache/kafka/pull/12462#discussion_r1063875734 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordAccumulator.java: ## @@ -287,12 +291,16 @@ public RecordAppendResult append(String topic,

[GitHub] [kafka] jolshan commented on a diff in pull request #12462: [KAFKA-9965] Fix accumulator tryAppend, so that fresh new producerBatch is created

jolshan commented on code in PR #12462: URL: https://github.com/apache/kafka/pull/12462#discussion_r1063875994 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordAccumulator.java: ## @@ -287,12 +291,16 @@ public RecordAppendResult append(String topic,

[GitHub] [kafka] artemlivshits commented on a diff in pull request #12462: [KAFKA-9965] Fix accumulator tryAppend, so that fresh new producerBatch is created

artemlivshits commented on code in PR #12462: URL: https://github.com/apache/kafka/pull/12462#discussion_r1063879030 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordAccumulator.java: ## @@ -287,12 +291,16 @@ public RecordAppendResult append(String topi

[GitHub] [kafka] jolshan commented on a diff in pull request #12462: [KAFKA-9965] Fix accumulator tryAppend, so that fresh new producerBatch is created

jolshan commented on code in PR #12462: URL: https://github.com/apache/kafka/pull/12462#discussion_r1063883812 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordAccumulator.java: ## @@ -287,12 +291,16 @@ public RecordAppendResult append(String topic,

[GitHub] [kafka] jolshan commented on a diff in pull request #12462: [KAFKA-9965] Fix accumulator tryAppend, so that fresh new producerBatch is created

jolshan commented on code in PR #12462: URL: https://github.com/apache/kafka/pull/12462#discussion_r1063883812 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordAccumulator.java: ## @@ -287,12 +291,16 @@ public RecordAppendResult append(String topic,

[GitHub] [kafka] ijuma commented on a diff in pull request #12462: [KAFKA-9965] Fix accumulator tryAppend, so that fresh new producerBatch is created

ijuma commented on code in PR #12462: URL: https://github.com/apache/kafka/pull/12462#discussion_r1063884499 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordAccumulator.java: ## @@ -287,12 +291,16 @@ public RecordAppendResult append(String topic,

[GitHub] [kafka] anatasiavela commented on a diff in pull request #13078: KAFKA-13999: Add ProducerCount metrics (KIP-847)

anatasiavela commented on code in PR #13078: URL: https://github.com/apache/kafka/pull/13078#discussion_r1063885018 ## core/src/main/scala/kafka/log/UnifiedLog.scala: ## @@ -576,6 +576,13 @@ class UnifiedLog(@volatile var logStartOffset: Long, } }, period = producerIdExp

[GitHub] [kafka] anatasiavela commented on a diff in pull request #13078: KAFKA-13999: Add ProducerCount metrics (KIP-847)

anatasiavela commented on code in PR #13078: URL: https://github.com/apache/kafka/pull/13078#discussion_r1063885166 ## core/src/main/scala/kafka/log/ProducerStateManager.scala: ## @@ -685,6 +692,7 @@ class ProducerStateManager( if (logEndOffset != mapEndOffset) { p

[GitHub] [kafka] anatasiavela commented on pull request #13078: KAFKA-13999: Add ProducerCount metrics (KIP-847)

anatasiavela commented on PR #13078: URL: https://github.com/apache/kafka/pull/13078#issuecomment-1374267644 Thank you for the review @divijvaidya! I've addressed your comments and made changes accordingly, so please take a look whenever you get the chance. Thanks! -- This is an automated

[GitHub] [kafka] jolshan commented on a diff in pull request #12462: [KAFKA-9965] Fix accumulator tryAppend, so that fresh new producerBatch is created

jolshan commented on code in PR #12462: URL: https://github.com/apache/kafka/pull/12462#discussion_r1063885987 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordAccumulator.java: ## @@ -287,12 +291,16 @@ public RecordAppendResult append(String topic,

[GitHub] [kafka] artemlivshits commented on a diff in pull request #12462: [KAFKA-9965] Fix accumulator tryAppend, so that fresh new producerBatch is created

artemlivshits commented on code in PR #12462: URL: https://github.com/apache/kafka/pull/12462#discussion_r1063886879 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordAccumulator.java: ## @@ -287,12 +291,16 @@ public RecordAppendResult append(String topi

[GitHub] [kafka] jolshan commented on a diff in pull request #13078: KAFKA-13999: Add ProducerCount metrics (KIP-847)

jolshan commented on code in PR #13078: URL: https://github.com/apache/kafka/pull/13078#discussion_r1063889005 ## core/src/main/scala/kafka/log/ProducerStateManager.scala: ## @@ -684,7 +700,7 @@ class ProducerStateManager( } if (logEndOffset != mapEndOffset) { -

[GitHub] [kafka] anatasiavela commented on a diff in pull request #13078: KAFKA-13999: Add ProducerCount metrics (KIP-847)

anatasiavela commented on code in PR #13078: URL: https://github.com/apache/kafka/pull/13078#discussion_r1063890647 ## core/src/main/scala/kafka/log/ProducerStateManager.scala: ## @@ -684,7 +700,7 @@ class ProducerStateManager( } if (logEndOffset != mapEndOffset) { -

[GitHub] [kafka] jolshan commented on a diff in pull request #13078: KAFKA-13999: Add ProducerCount metrics (KIP-847)

jolshan commented on code in PR #13078: URL: https://github.com/apache/kafka/pull/13078#discussion_r1063895230 ## core/src/main/scala/kafka/log/ProducerStateManager.scala: ## @@ -684,7 +700,7 @@ class ProducerStateManager( } if (logEndOffset != mapEndOffset) { -

[GitHub] [kafka] cmccabe opened a new pull request, #13089: KAFKA-14601: Improve exception handling in KafkaEventQueue

cmccabe opened a new pull request, #13089: URL: https://github.com/apache/kafka/pull/13089 If KafkaEventQueue gets an InterruptedException while waiting for a condition variable, it currently exits immediately. Instead, it should complete the remaining events exceptionally and then execute

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #12870: KAFKA-14367; Add `OffsetFetch` to the new `GroupCoordinator` interface

jeffkbkim commented on code in PR #12870: URL: https://github.com/apache/kafka/pull/12870#discussion_r1063877209 ## clients/src/main/java/org/apache/kafka/common/requests/OffsetFetchResponse.java: ## @@ -208,6 +203,56 @@ public OffsetFetchResponse(int throttleTimeMs, th

[GitHub] [kafka] showuon commented on pull request #13050: MINOR: add error reason when controller failed to handle events

showuon commented on PR #13050: URL: https://github.com/apache/kafka/pull/13050#issuecomment-1374334192 All tests passed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [kafka] showuon merged pull request #13050: MINOR: add error reason when controller failed to handle events

showuon merged PR #13050: URL: https://github.com/apache/kafka/pull/13050 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[GitHub] [kafka] satishd commented on a diff in pull request #13046: KAFKA-14551 Move LeaderEpochFileCache and its dependencies to the storage module.

satishd commented on code in PR #13046: URL: https://github.com/apache/kafka/pull/13046#discussion_r1063953030 ## storage/src/main/java/org/apache/kafka/server/log/internals/LeaderEpochCheckpoint.java: ## @@ -0,0 +1,26 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] satishd commented on a diff in pull request #13043: KAFKA-14558: Move LastRecord, TxnMetadata, BatchMetadata, ProducerStateEntry, and ProducerAppendInfo to the storage module

satishd commented on code in PR #13043: URL: https://github.com/apache/kafka/pull/13043#discussion_r1063954363 ## storage/src/main/java/org/apache/kafka/server/log/internals/ProducerAppendInfo.java: ## @@ -0,0 +1,238 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

[jira] [Created] (KAFKA-14602) offsetDelta in BatchMetadata is an int but the values are computed as difference of offsets which are longs.

Satish Duggana created KAFKA-14602: -- Summary: offsetDelta in BatchMetadata is an int but the values are computed as difference of offsets which are longs. Key: KAFKA-14602 URL: https://issues.apache.org/jira/brow

[GitHub] [kafka] rishiraj88 commented on pull request #12906: make CI pass

rishiraj88 commented on PR #12906: URL: https://github.com/apache/kafka/pull/12906#issuecomment-1374387095 Thanks, @Scanteianu , for the quick reference to guidelines and checklist. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [kafka] satishd commented on a diff in pull request #13043: KAFKA-14558: Move LastRecord, TxnMetadata, BatchMetadata, ProducerStateEntry, and ProducerAppendInfo to the storage module

satishd commented on code in PR #13043: URL: https://github.com/apache/kafka/pull/13043#discussion_r1063961399 ## storage/src/main/java/org/apache/kafka/server/log/internals/ProducerAppendInfo.java: ## @@ -0,0 +1,238 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

[GitHub] [kafka] chia7712 commented on pull request #13075: KAFKA-9087 Replace log high watermark by future log high watermark wh…

chia7712 commented on PR #13075: URL: https://github.com/apache/kafka/pull/13075#issuecomment-1374403802 unrelated error ``` Build / JDK 11 and Scala 2.13 / kafka.admin.ReassignPartitionsIntegrationTest.testAlterReassignmentThrottle(String).quorum=kraft | 26 秒 | 1 Build / JDK 11 an

[GitHub] [kafka] satishd commented on a diff in pull request #13043: KAFKA-14558: Move LastRecord, TxnMetadata, BatchMetadata, ProducerStateEntry, and ProducerAppendInfo to the storage module

satishd commented on code in PR #13043: URL: https://github.com/apache/kafka/pull/13043#discussion_r1063969839 ## storage/src/main/java/org/apache/kafka/server/log/internals/ProducerStateEntry.java: ## @@ -0,0 +1,143 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

[GitHub] [kafka] chia7712 merged pull request #13075: KAFKA-9087 Replace log high watermark by future log high watermark wh…

chia7712 merged PR #13075: URL: https://github.com/apache/kafka/pull/13075 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Resolved] (KAFKA-9087) ReplicaAlterLogDirs stuck and restart fails with java.lang.IllegalStateException: Offset mismatch for the future replica

[ https://issues.apache.org/jira/browse/KAFKA-9087?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-9087. --- Fix Version/s: 3.5.0 Assignee: Chia-Ping Tsai Resolution: Fixed > ReplicaAlte