emilnkrastev commented on code in PR #11818:
URL: https://github.com/apache/kafka/pull/11818#discussion_r1063563770
##########
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorSourceTask.java:
##########
@@ -69,14 +69,19 @@ public MirrorSourceTask() {}
// for testing
MirrorSourceTask(KafkaConsumer<byte[], byte[]> consumer,
MirrorSourceMetrics metrics, String sourceClusterAlias,
- ReplicationPolicy replicationPolicy, long maxOffsetLag,
KafkaProducer<byte[], byte[]> producer) {
+ ReplicationPolicy replicationPolicy, long maxOffsetLag,
KafkaProducer<byte[], byte[]> producer,
+ Semaphore outstandingOffsetSyncs, Map<TopicPartition,
PartitionState> partitionStates,
Review Comment:
I have updated the MR without mocking the outstanding syncs semaphore but I
have preserved the semaphore constructor parameter. The semaphore is getting
initialized in the `start` method and I could not find a better way to avoid
the NPE.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
