dajac merged PR #13023:
URL: https://github.com/apache/kafka/pull/13023
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
dajac commented on PR #13023:
URL: https://github.com/apache/kafka/pull/13023#issuecomment-1361005539
Merged to trunk, 3.4 and 3.3.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
dajac commented on code in PR #13023:
URL: https://github.com/apache/kafka/pull/13023#discussion_r1054106713
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/SubscriptionState.java:
##
@@ -620,7 +620,12 @@ public synchronized Optional
preferredReadReplica(To
[
https://issues.apache.org/jira/browse/KAFKA-14532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Jacot resolved KAFKA-14532.
-
Resolution: Fixed
> Correctly handle failed fetch when partitions unassigned
> -
[
https://issues.apache.org/jira/browse/KAFKA-14532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Jacot updated KAFKA-14532:
Summary: Correctly handle failed fetch when partitions unassigned (was:
IllegalStateException whe
dajac merged PR #12982:
URL: https://github.com/apache/kafka/pull/12982
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
lhotari commented on code in PR #13032:
URL: https://github.com/apache/kafka/pull/13032#discussion_r1054114528
##
clients/src/main/java/org/apache/kafka/common/protocol/DataOutputStreamWritable.java:
##
@@ -99,7 +99,7 @@ public void writeUnsignedVarint(int i) {
public void
dajac commented on PR #12982:
URL: https://github.com/apache/kafka/pull/12982#issuecomment-1361022525
Merged to trunk, 3.4 and 3.3.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
[
https://issues.apache.org/jira/browse/KAFKA-13107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17650437#comment-17650437
]
Nikolay Izhikov commented on KAFKA-13107:
-
Hello, [~Fuud]
Do you have logs?
lucasbru commented on code in PR #13017:
URL: https://github.com/apache/kafka/pull/13017#discussion_r1054215201
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java:
##
@@ -880,9 +885,7 @@ void runOnce() {
private void initializeAndRestore
cadonna commented on code in PR #12739:
URL: https://github.com/apache/kafka/pull/12739#discussion_r1054286982
##
streams/src/test/java/org/apache/kafka/streams/state/internals/TimeOrderedCachingPersistentWindowStoreTest.java:
##
@@ -104,11 +108,10 @@ public class TimeOrderedCac
cadonna commented on PR #13014:
URL: https://github.com/apache/kafka/pull/13014#issuecomment-1361257639
Build failures are not related:
```
Build / JDK 11 and Scala 2.13 /
org.apache.kafka.connect.mirror.integration.IdentityReplicationIntegrationTest.testReplication()
Build / JDK 11
cadonna merged PR #13014:
URL: https://github.com/apache/kafka/pull/13014
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
[
https://issues.apache.org/jira/browse/KAFKA-14461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bruno Cadonna resolved KAFKA-14461.
---
Resolution: Fixed
> StoreQueryIntegrationTest#shouldQuerySpecificActivePartitionStores logic
cadonna commented on PR #12959:
URL: https://github.com/apache/kafka/pull/12959#issuecomment-1361260371
Build failures are not related:
```
Build / JDK 11 and Scala 2.13 /
org.apache.kafka.clients.consumer.StickyAssignorTest.testLargeAssignmentAndGroupWithNonEqualSubscription()
Buil
cadonna merged PR #12959:
URL: https://github.com/apache/kafka/pull/12959
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
ijuma commented on PR #13012:
URL: https://github.com/apache/kafka/pull/13012#issuecomment-1361291206
JDK 17 build passed, the other failures are flaky. Re-running the test suite
just in case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please l
ijuma commented on code in PR #13032:
URL: https://github.com/apache/kafka/pull/13032#discussion_r1054369362
##
clients/src/main/java/org/apache/kafka/common/protocol/DataOutputStreamWritable.java:
##
@@ -99,7 +99,7 @@ public void writeUnsignedVarint(int i) {
public void wr
ijuma merged PR #13024:
URL: https://github.com/apache/kafka/pull/13024
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
ijuma commented on PR #13024:
URL: https://github.com/apache/kafka/pull/13024#issuecomment-1361298288
Annoyingly, the commit was somehow pushed prematurely while I was still
editing the commit message - not quite sure how that happened. Apologies for
the bad commit message and the missing r
[
https://issues.apache.org/jira/browse/KAFKA-14479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ismael Juma resolved KAFKA-14479.
-
Resolution: Duplicate
Doing it as part of KAFKA-14478 instead.
> Move CleanerConfig to storage
[
https://issues.apache.org/jira/browse/KAFKA-14478?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ismael Juma updated KAFKA-14478:
Summary: Move LogConfig/CleanerConfig to storage module (was: Move
LogConfig to storage module)
[
https://issues.apache.org/jira/browse/KAFKA-14128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17650896#comment-17650896
]
Lucia Cerchie commented on KAFKA-14128:
---
working on this
> Kafka Streams terminat
Divij Vaidya created KAFKA-14541:
Summary: Profile produce workload for Apache Kafka
Key: KAFKA-14541
URL: https://issues.apache.org/jira/browse/KAFKA-14541
Project: Kafka
Issue Type: Improve
[
https://issues.apache.org/jira/browse/KAFKA-14392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ron Dagostino updated KAFKA-14392:
--
Affects Version/s: (was: 3.4.0)
> KRaft broker heartbeat timeout should not exceed broker.
[
https://issues.apache.org/jira/browse/KAFKA-14392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ron Dagostino updated KAFKA-14392:
--
Fix Version/s: 3.4.0
(was: 3.5.0)
> KRaft broker heartbeat timeout shou
[
https://issues.apache.org/jira/browse/KAFKA-14541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Divij Vaidya updated KAFKA-14541:
-
Description:
I have been profiling Kafka (3.4.0 / trunk right now) for a produce only
workload
[
https://issues.apache.org/jira/browse/KAFKA-14541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Divij Vaidya updated KAFKA-14541:
-
Description:
I have been profiling Kafka (3.4.0 / trunk right now) for a produce only
workload
[
https://issues.apache.org/jira/browse/KAFKA-14541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Divij Vaidya updated KAFKA-14541:
-
Description:
I have been profiling Kafka (3.4.0 / trunk right now) for a produce only
workload
mumrah commented on code in PR #13033:
URL: https://github.com/apache/kafka/pull/13033#discussion_r1054455358
##
core/src/main/scala/kafka/server/metadata/BrokerMetadataListener.scala:
##
@@ -289,6 +316,59 @@ class BrokerMetadataListener(
BatchLoadResults(numBatches, numRec
mumrah commented on code in PR #13033:
URL: https://github.com/apache/kafka/pull/13033#discussion_r1054483117
##
core/src/main/scala/kafka/server/metadata/BrokerMetadataListener.scala:
##
@@ -76,6 +77,21 @@ class BrokerMetadataListener(
*/
private var _highestTimestamp =
mumrah commented on code in PR #13033:
URL: https://github.com/apache/kafka/pull/13033#discussion_r1054455358
##
core/src/main/scala/kafka/server/metadata/BrokerMetadataListener.scala:
##
@@ -289,6 +316,59 @@ class BrokerMetadataListener(
BatchLoadResults(numBatches, numRec
mumrah commented on code in PR #13033:
URL: https://github.com/apache/kafka/pull/13033#discussion_r1054485418
##
metadata/src/main/java/org/apache/kafka/controller/QuorumController.java:
##
@@ -1071,7 +1136,11 @@ public ControllerResult generateRecordsAndResult()
throws Excepti
dajac commented on code in PR #12870:
URL: https://github.com/apache/kafka/pull/12870#discussion_r1054490432
##
core/src/main/scala/kafka/server/KafkaApis.scala:
##
@@ -1395,79 +1389,123 @@ class KafkaApis(val requestChannel: RequestChannel,
offsetFetchResponse
}
dajac commented on code in PR #12870:
URL: https://github.com/apache/kafka/pull/12870#discussion_r1054490900
##
core/src/test/scala/unit/kafka/server/KafkaApisTest.scala:
##
@@ -3405,6 +3405,341 @@ class KafkaApisTest {
assertEquals(Errors.GROUP_AUTHORIZATION_FAILED, respon
dajac commented on code in PR #12870:
URL: https://github.com/apache/kafka/pull/12870#discussion_r1054492204
##
clients/src/main/java/org/apache/kafka/common/requests/OffsetFetchResponse.java:
##
@@ -19,6 +19,7 @@
import java.util.Map.Entry;
Review Comment:
As I follow-up,
dajac commented on code in PR #12870:
URL: https://github.com/apache/kafka/pull/12870#discussion_r1054493387
##
core/src/test/scala/unit/kafka/server/OffsetFetchRequestTest.scala:
##
@@ -150,42 +149,6 @@ class OffsetFetchRequestTest extends BaseRequestTest {
}
}
- @Te
dajac commented on code in PR #12870:
URL: https://github.com/apache/kafka/pull/12870#discussion_r1054494189
##
core/src/main/scala/kafka/server/KafkaApis.scala:
##
@@ -1338,11 +1337,12 @@ class KafkaApis(val requestChannel: RequestChannel,
/**
* Handle an offset fetch re
dajac commented on code in PR #12870:
URL: https://github.com/apache/kafka/pull/12870#discussion_r1054494916
##
core/src/main/scala/kafka/server/KafkaApis.scala:
##
@@ -1397,77 +1397,172 @@ class KafkaApis(val requestChannel: RequestChannel,
requestHelper.sendResponseMaybeT
[
https://issues.apache.org/jira/browse/KAFKA-14541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Divij Vaidya updated KAFKA-14541:
-
Description:
I have been profiling Kafka (3.4.0 / trunk right now) for a produce only
workload
dajac commented on code in PR #12870:
URL: https://github.com/apache/kafka/pull/12870#discussion_r1054496553
##
core/src/test/scala/unit/kafka/server/OffsetFetchRequestTest.scala:
##
@@ -150,42 +149,6 @@ class OffsetFetchRequestTest extends BaseRequestTest {
}
}
- @Te
David Jacot created KAFKA-14542:
---
Summary: Deprecate OffsetFetch/Commit version 0 and remove them in
4.0
Key: KAFKA-14542
URL: https://issues.apache.org/jira/browse/KAFKA-14542
Project: Kafka
[
https://issues.apache.org/jira/browse/KAFKA-14470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17650927#comment-17650927
]
Mickael Maison commented on KAFKA-14470:
Should we also move classes like LogOff
michaeljmarshall commented on code in PR #13032:
URL: https://github.com/apache/kafka/pull/13032#discussion_r1054547725
##
clients/src/main/java/org/apache/kafka/common/protocol/DataOutputStreamWritable.java:
##
@@ -99,7 +99,7 @@ public void writeUnsignedVarint(int i) {
pub
dajac commented on code in PR #12886:
URL: https://github.com/apache/kafka/pull/12886#discussion_r1054582822
##
core/src/main/java/kafka/server/builders/KafkaApisBuilder.java:
##
@@ -178,6 +179,7 @@ public KafkaApis build() {
metadataSupport,
dajac commented on code in PR #12886:
URL: https://github.com/apache/kafka/pull/12886#discussion_r1054592382
##
core/src/main/scala/kafka/server/KafkaApis.scala:
##
@@ -407,136 +416,200 @@ class KafkaApis(val requestChannel: RequestChannel,
* Handle an offset commit request
michaeljmarshall commented on code in PR #13032:
URL: https://github.com/apache/kafka/pull/13032#discussion_r1054597086
##
clients/src/test/java/org/apache/kafka/common/protocol/DataOutputStreamWritableTest.java:
##
@@ -0,0 +1,47 @@
+/*
+ * Licensed to the Apache Software Founda
C0urante commented on PR #12735:
URL: https://github.com/apache/kafka/pull/12735#issuecomment-1361648543
FYI, I've changed the Jira ticket in the title from KAFKA-14059 (which
refers to a different test class) to KAFKA-14132, which is the umbrella issue
for migration from EasyMock/PowerMock
C0urante merged PR #12735:
URL: https://github.com/apache/kafka/pull/12735
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
[
https://issues.apache.org/jira/browse/KAFKA-14132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Egerton updated KAFKA-14132:
--
Description:
{color:#de350b}Some of the tests below use EasyMock as well. For those migrate
b
michaeljmarshall commented on code in PR #13032:
URL: https://github.com/apache/kafka/pull/13032#discussion_r1054618672
##
clients/src/test/java/org/apache/kafka/common/protocol/DataOutputStreamWritableTest.java:
##
@@ -0,0 +1,47 @@
+/*
+ * Licensed to the Apache Software Founda
[
https://issues.apache.org/jira/browse/KAFKA-13933?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Federico Valeri updated KAFKA-13933:
Description:
When there is an authentication error after the initial TCP connection, the
jolshan commented on code in PR #12870:
URL: https://github.com/apache/kafka/pull/12870#discussion_r1054632844
##
clients/src/main/java/org/apache/kafka/common/requests/OffsetFetchResponse.java:
##
@@ -19,6 +19,7 @@
import java.util.Map.Entry;
Review Comment:
sounds like a
jolshan commented on code in PR #12870:
URL: https://github.com/apache/kafka/pull/12870#discussion_r1054636234
##
core/src/main/scala/kafka/server/KafkaApis.scala:
##
@@ -1395,79 +1389,123 @@ class KafkaApis(val requestChannel: RequestChannel,
offsetFetchResponse
}
[
https://issues.apache.org/jira/browse/KAFKA-14470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17650947#comment-17650947
]
Ismael Juma commented on KAFKA-14470:
-
[~mimaison] Dependencies of the log layer cla
jolshan commented on code in PR #12870:
URL: https://github.com/apache/kafka/pull/12870#discussion_r1054638304
##
core/src/test/scala/unit/kafka/server/KafkaApisTest.scala:
##
@@ -3405,6 +3405,341 @@ class KafkaApisTest {
assertEquals(Errors.GROUP_AUTHORIZATION_FAILED, resp
jolshan commented on code in PR #12870:
URL: https://github.com/apache/kafka/pull/12870#discussion_r1054640668
##
core/src/test/scala/unit/kafka/server/OffsetFetchRequestTest.scala:
##
@@ -150,42 +149,6 @@ class OffsetFetchRequestTest extends BaseRequestTest {
}
}
- @
cmccabe commented on code in PR #13029:
URL: https://github.com/apache/kafka/pull/13029#discussion_r1054647289
##
clients/src/main/resources/common/message/ApiVersionsResponse.json:
##
@@ -25,9 +25,12 @@
// not in the header. The length of the header must not change in order
jolshan commented on code in PR #12886:
URL: https://github.com/apache/kafka/pull/12886#discussion_r1054648954
##
core/src/main/scala/kafka/server/KafkaApis.scala:
##
@@ -407,136 +416,200 @@ class KafkaApis(val requestChannel: RequestChannel,
* Handle an offset commit reques
Mickael Maison created KAFKA-14543:
--
Summary: Move LogOffsetMetadata to storage module
Key: KAFKA-14543
URL: https://issues.apache.org/jira/browse/KAFKA-14543
Project: Kafka
Issue Type: Sub-
C0urante merged PR #12947:
URL: https://github.com/apache/kafka/pull/12947
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
[
https://issues.apache.org/jira/browse/KAFKA-13467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17650964#comment-17650964
]
Ivan Yurchenko commented on KAFKA-13467:
Probably related https://issues.apache.
lihaosky opened a new pull request, #13034:
URL: https://github.com/apache/kafka/pull/13034
## Description
Remove unnecessary calls in assign method
## Test
Existing tests
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
[
https://issues.apache.org/jira/browse/KAFKA-13881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17650968#comment-17650968
]
Mickael Maison commented on KAFKA-13881:
[~gharris1727] Are you planning to open
mimaison commented on PR #12936:
URL: https://github.com/apache/kafka/pull/12936#issuecomment-1361845545
@mjsax @ableegoldman Can you take a look? Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
Chia-Ping Tsai created KAFKA-14544:
--
Summary: The "is-future" should be removed from metrics tags after
future log becomes current log
Key: KAFKA-14544
URL: https://issues.apache.org/jira/browse/KAFKA-14544
chia7712 commented on PR #12979:
URL: https://github.com/apache/kafka/pull/12979#issuecomment-1361909104
file a jira as this is related to true bug
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
junrao commented on code in PR #13012:
URL: https://github.com/apache/kafka/pull/13012#discussion_r1054705599
##
core/src/main/scala/kafka/log/UnifiedLog.scala:
##
@@ -2185,6 +2188,27 @@ object UnifiedLog extends Logging {
private[log] def createNewCleanedSegment(dir: File, l
C0urante commented on code in PR #12802:
URL: https://github.com/apache/kafka/pull/12802#discussion_r1054700417
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/DistributedHerder.java:
##
@@ -1658,11 +1659,20 @@ private void backoff(long ms) {
[
https://issues.apache.org/jira/browse/KAFKA-9087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17650979#comment-17650979
]
Chia-Ping Tsai commented on KAFKA-9087:
---
We encountered this error also. The root c
cmccabe merged PR #13001:
URL: https://github.com/apache/kafka/pull/13001
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
cmccabe commented on code in PR #13029:
URL: https://github.com/apache/kafka/pull/13029#discussion_r1054764792
##
clients/src/main/resources/common/message/ApiVersionsResponse.json:
##
@@ -69,6 +69,9 @@
{"name": "MinVersionLevel", "type": "int16", "versions": "3+",
cmccabe commented on code in PR #13033:
URL: https://github.com/apache/kafka/pull/13033#discussion_r1054775292
##
core/src/main/scala/kafka/server/metadata/BrokerMetadataListener.scala:
##
@@ -289,6 +316,59 @@ class BrokerMetadataListener(
BatchLoadResults(numBatches, numRe
cmccabe commented on code in PR #13033:
URL: https://github.com/apache/kafka/pull/13033#discussion_r1054776436
##
metadata/src/main/java/org/apache/kafka/controller/QuorumController.java:
##
@@ -860,7 +886,7 @@ public void handleCommit(BatchReader
reader) {
cmccabe commented on code in PR #13033:
URL: https://github.com/apache/kafka/pull/13033#discussion_r1054777011
##
core/src/main/scala/kafka/server/metadata/BrokerMetadataListener.scala:
##
@@ -76,6 +77,21 @@ class BrokerMetadataListener(
*/
private var _highestTimestamp =
cmccabe commented on code in PR #13033:
URL: https://github.com/apache/kafka/pull/13033#discussion_r1054777972
##
metadata/src/main/java/org/apache/kafka/controller/QuorumController.java:
##
@@ -1071,7 +1136,11 @@ public ControllerResult generateRecordsAndResult()
throws Except
dajac commented on code in PR #12870:
URL: https://github.com/apache/kafka/pull/12870#discussion_r1054778185
##
core/src/test/scala/unit/kafka/server/KafkaApisTest.scala:
##
@@ -3405,6 +3405,341 @@ class KafkaApisTest {
assertEquals(Errors.GROUP_AUTHORIZATION_FAILED, respon
dajac commented on code in PR #12886:
URL: https://github.com/apache/kafka/pull/12886#discussion_r1054778967
##
core/src/main/scala/kafka/server/KafkaApis.scala:
##
@@ -407,136 +416,200 @@ class KafkaApis(val requestChannel: RequestChannel,
* Handle an offset commit request
dajac commented on PR #12886:
URL: https://github.com/apache/kafka/pull/12886#issuecomment-1362010257
@jolshan @OmniaGM Thanks for your comments. I just updated the PR. I have
tried to simplify the code in KafkaApis as much as possible. Let me know what
you think.
--
This is an automated
cmccabe commented on PR #13033:
URL: https://github.com/apache/kafka/pull/13033#issuecomment-1362010708
@mumrah : you're right that we need to be checking MV before generating
these records.
On second thought, I also think we should be using abort transation rather
than checking reco
dajac commented on code in PR #12870:
URL: https://github.com/apache/kafka/pull/12870#discussion_r1054782481
##
core/src/test/scala/unit/kafka/server/KafkaApisTest.scala:
##
@@ -3405,6 +3405,341 @@ class KafkaApisTest {
assertEquals(Errors.GROUP_AUTHORIZATION_FAILED, respon
chia7712 opened a new pull request, #13035:
URL: https://github.com/apache/kafka/pull/13035
We encountered this error also. The root cause is about race condition.
1. ReplicaAlterLogDirsThread has fetched the data for topic partition
1. ReplicaManager#alterReplicaLogDirs changes the fut
dajac commented on code in PR #12870:
URL: https://github.com/apache/kafka/pull/12870#discussion_r1054793572
##
core/src/test/scala/unit/kafka/server/OffsetFetchRequestTest.scala:
##
@@ -150,42 +149,6 @@ class OffsetFetchRequestTest extends BaseRequestTest {
}
}
- @Te
jolshan commented on code in PR #12886:
URL: https://github.com/apache/kafka/pull/12886#discussion_r1054814682
##
core/src/main/scala/kafka/coordinator/group/GroupCoordinatorAdapter.scala:
##
@@ -234,4 +240,78 @@ class GroupCoordinatorAdapter(
}
CompletableFuture.compl
jolshan commented on code in PR #12886:
URL: https://github.com/apache/kafka/pull/12886#discussion_r1054814682
##
core/src/main/scala/kafka/coordinator/group/GroupCoordinatorAdapter.scala:
##
@@ -234,4 +240,78 @@ class GroupCoordinatorAdapter(
}
CompletableFuture.compl
jolshan commented on code in PR #12886:
URL: https://github.com/apache/kafka/pull/12886#discussion_r1054819922
##
core/src/main/scala/kafka/server/KafkaApis.scala:
##
@@ -411,137 +411,144 @@ class KafkaApis(val requestChannel: RequestChannel,
/**
* Handle an offset commit
ijuma commented on code in PR #13012:
URL: https://github.com/apache/kafka/pull/13012#discussion_r1054822187
##
core/src/main/scala/kafka/log/UnifiedLog.scala:
##
@@ -2185,6 +2188,27 @@ object UnifiedLog extends Logging {
private[log] def createNewCleanedSegment(dir: File, lo
ijuma commented on code in PR #13012:
URL: https://github.com/apache/kafka/pull/13012#discussion_r1054822697
##
clients/src/test/java/org/apache/kafka/common/utils/PrimitiveRefTest.java:
##
@@ -14,15 +14,19 @@
* See the License for the specific language governing permissions a
dajac commented on code in PR #12886:
URL: https://github.com/apache/kafka/pull/12886#discussion_r1054822770
##
core/src/main/scala/kafka/server/KafkaApis.scala:
##
@@ -411,137 +411,144 @@ class KafkaApis(val requestChannel: RequestChannel,
/**
* Handle an offset commit r
ijuma commented on PR #13012:
URL: https://github.com/apache/kafka/pull/13012#issuecomment-1362078506
@junrao Pushed a change that addresses two of the review comments. I left a
comment for the other review comment.
--
This is an automated message from the Apache Git Service.
To respond t
jolshan commented on code in PR #12886:
URL: https://github.com/apache/kafka/pull/12886#discussion_r1054830892
##
core/src/main/scala/kafka/coordinator/group/GroupCoordinatorAdapter.scala:
##
@@ -234,4 +240,78 @@ class GroupCoordinatorAdapter(
}
CompletableFuture.compl
jolshan commented on code in PR #12886:
URL: https://github.com/apache/kafka/pull/12886#discussion_r1054833397
##
core/src/main/scala/kafka/server/KafkaApis.scala:
##
@@ -411,137 +411,144 @@ class KafkaApis(val requestChannel: RequestChannel,
/**
* Handle an offset commit
jolshan commented on code in PR #12886:
URL: https://github.com/apache/kafka/pull/12886#discussion_r1054834094
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinator.java:
##
@@ -52,6 +54,7 @@ CompletableFuture joinGroup(
);
/**
+<
jolshan commented on code in PR #12870:
URL: https://github.com/apache/kafka/pull/12870#discussion_r1054835003
##
core/src/test/scala/unit/kafka/server/KafkaApisTest.scala:
##
@@ -3405,6 +3405,341 @@ class KafkaApisTest {
assertEquals(Errors.GROUP_AUTHORIZATION_FAILED, resp
[
https://issues.apache.org/jira/browse/KAFKA-14271?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Egerton updated KAFKA-14271:
--
Fix Version/s: (was: 3.4.0)
(was: 3.3.2)
> Topic recreation fails i
junrao commented on code in PR #13012:
URL: https://github.com/apache/kafka/pull/13012#discussion_r1054846959
##
core/src/main/scala/kafka/log/UnifiedLog.scala:
##
@@ -2185,6 +2188,27 @@ object UnifiedLog extends Logging {
private[log] def createNewCleanedSegment(dir: File, l
philipnee commented on code in PR #12590:
URL: https://github.com/apache/kafka/pull/12590#discussion_r1054670620
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/Fetcher.java:
##
@@ -1933,11 +1943,79 @@ private Map
topicPartitionTags(TopicPartition tp) {
philipnee commented on code in PR #12870:
URL: https://github.com/apache/kafka/pull/12870#discussion_r1054847935
##
clients/src/main/java/org/apache/kafka/common/requests/OffsetFetchRequest.java:
##
@@ -227,6 +227,24 @@ public boolean requireStable() {
return data.requi
gharris1727 opened a new pull request, #13036:
URL: https://github.com/apache/kafka/pull/13036
This test asserts that after a producerId expires and before a transactionId
expires, the producerId is reused in a subsequent epoch.
The transactionId expiration time used in this test was too
gharris1727 commented on PR #13036:
URL: https://github.com/apache/kafka/pull/13036#issuecomment-1362127508
@jolshan Could you take a look at this test stabilization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
1 - 100 of 128 matches
Mail list logo
